Re: [U-Boot] [PATCH v4 3/7] ARM: omap-common: Add standard access for board description EEPROM

2015-11-09 Thread Nishanth Menon
On 11/05/2015 06:39 PM, Steve Kipisz wrote: [...] > +#define TI_EEPROM_HDR_NAME_LEN 8 > +#define TI_EEPROM_HDR_REV_LEN12 > +#define TI_EEPROM_HDR_SERIAL_LEN 4 ^^ minor typo here as well. Serial should be 12 and REV is 4. [...] -- Regards, Nisha

Re: [U-Boot] [PATCH v2 5/5] board: ti: AM57xx: Add detection logic for AM57xx-evm

2015-11-03 Thread Nishanth Menon
me dt overlay instead of evm dtb. I dont know about what will eventually become in upstream. So, I suggest dropping the above change. Also, in the future, could you cc beagleboard-x15 <beagleboard-...@googlegroups.com> for all patches that impact beagleboard-X15 I am sure folks there will be in

Re: [U-Boot] [PATCH v2 3/5] ARM: omap-common: Add standard access for board description EEPROM

2015-11-03 Thread Nishanth Menon
> + * @rev_tag:Revision tag to check in eeprom >>> + * @cmp_len:How many chars to compare? >>> + * >>> + * NOTE: revision information is often messed up (hence the str len >>> match) :( >>> + * >>> + * Return: false if board information does not match OR eeprom >>> was'nt read. >>> + * true otherwise >>> + */ >>> +static inline bool board_am_rev_is(char *rev_tag, int cmp_len) >>> +{ >>> +struct ti_am_eeprom *ep = TI_AM_EEPROM_DATA; >>> +int l; >>> + >>> +if (ep->header != TI_EEPROM_HEADER_MAGIC) >>> +return false; >>> + >>> +l = cmp_len > TI_EEPROM_HDR_REV_LEN ? TI_EEPROM_HDR_NAME_LEN : >>> cmp_len; >>> +return !strncmp(ep->version, rev_tag, l); >>> +} >> >> Same here. >> > I thought by making them static inline would save space. I prefer that myself as well. -- Regards, Nishanth Menon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v3 3/5] ARM: omap-common: Add standard access for board description EEPROM

2015-11-04 Thread Nishanth Menon
int rc; > + > + /* Incase of invalid eeprom contents */ > + p->name[0] = 0x00; > + p->version[0] = 0x00; > + p->serial[0] = 0x00; > + > + rc = ti_i2c_eeprom_am_get(bus_addr, dev_addr, ); > + if (rc) > + return rc; > + > + /* > + * Alas! we have to null terminate and cleanup the strings! > + */ > + strlcpy(p->name, ep->name, TI_EEPROM_HDR_NAME_LEN); > + ti_eeprom_string_cleanup(p->name); > + strlcpy(p->version, ep->version, TI_EEPROM_HDR_NAME_LEN); > + ti_eeprom_string_cleanup(p->version); > + strlcpy(p->serial, ep->serial, TI_EEPROM_HDR_NAME_LEN); > + ti_eeprom_string_cleanup(p->serial); > + return 0; > +} > + > +void __maybe_unused set_board_info_env(char *name, char *revision, > +char *serial) > +{ > + char *unknown = "unknown"; > + > + if (name) > + setenv("board_name", name); > + > + if (revision) > + setenv("board_revision", revision); > + else > + setenv("board_revision", unknown); > + > + if (serial) > + setenv("board_serial", serial); > + else > + setenv("board_serial", unknown); > +} > I just think a single file should be sufficient here. -- Regards, Nishanth Menon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v3 0/5] ARM: omap-common: Add board detection support for TI EVMs

2015-11-04 Thread Nishanth Menon
h. If I attempt to apply this series on current u-boot master, I will fail and that does not give me a good impression of the series overall. Apologies on ranting about this, but I'd thought it might help you give a better perspective of what, at least I, as a reviewer would like to see in a series. --

Re: [U-Boot] [PATCH v2 3/5] ARM: omap-common: Add standard access for board description EEPROM

2015-11-03 Thread Nishanth Menon
ve? > AFAIK, inline places the function code inside the the caller function > and thus spreads into each caller, no? It probably saves some branches, > but how does that save space? I dont think it saves space, but rather a function call overhead for trivial code as above. > Also, AFAIR, we try to not place code inside headers, unless the code > is a stub. That does not always make sense. here it is a straight forward comparison.. why hide it a function call deep when you can inline it? -- Regards, Nishanth Menon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v3 3/5] ARM: omap-common: Add standard access for board description EEPROM

2015-11-04 Thread Nishanth Menon
On 11/04/2015 05:43 PM, Nishanth Menon wrote: [...] >> index 5cd6873f5e97..9d85d31b2cf1 100644 >> --- a/board/ti/am57xx/Makefile >> +++ b/board/ti/am57xx/Makefile >> @@ -6,3 +6,5 @@ >> # >> >> obj-y := board.o >> +obj-y += ../commo

Re: [U-Boot] [PATCH] Makefile: Include vendor common library in include search path

2015-11-04 Thread Nishanth Menon
On 11/05/2015 01:28 AM, Nishanth Menon wrote: > When the vendor common libraries exists, then board should be able to > reference headers located there, rather than having to do weird logic > such as '#include "../common/xyz.h"'. > > Signed-off-by: Ni

Re: [U-Boot] [PATCH v3 3/5] ARM: omap-common: Add standard access for board description EEPROM

2015-11-04 Thread Nishanth Menon
/ libs-$(HAVE_VENDOR_COMMON_LIB) += board/$(VENDOR)/common/ -- Regards, Nishanth Menon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] Makefile: Include vendor common library in include search path

2015-11-04 Thread Nishanth Menon
When the vendor common libraries exists, then board should be able to reference headers located there, rather than having to do weird logic such as '#include "../common/xyz.h"'. Signed-off-by: Nishanth Menon <n...@ti.com> --- Makefile| 1 + board/ti/am57xx/b

Re: [U-Boot] [PATCH v2 3/5] ARM: omap-common: Add standard access for board description EEPROM

2015-11-03 Thread Nishanth Menon
On 11/03/2015 03:07 PM, Igor Grinberg wrote: > On 11/03/15 19:45, Nishanth Menon wrote: >> On 11/03/2015 11:02 AM, Igor Grinberg wrote: >> >>>>>>> + >>>>>>> +/** >>>>>>> + * board_am_rev_is() - Compare board revision

Re: [U-Boot] [PATCH] Makefile: Include vendor common library in include search path

2015-11-05 Thread Nishanth Menon
On Thu, Nov 5, 2015 at 6:15 PM, Simon Glass <s...@chromium.org> wrote: > Hi, > > On 5 November 2015 at 00:32, Nishanth Menon <n...@ti.com> wrote: >> On 11/05/2015 01:28 AM, Nishanth Menon wrote: >>> When the vendor common libraries exists, then board should be a

Re: [U-Boot] [PATCH] Makefile: Include vendor common library in include search path

2015-11-06 Thread Nishanth Menon
On 11/05/2015 10:50 PM, Masahiro Yamada wrote: > 2015-11-06 12:30 GMT+09:00 Nishanth Menon <n...@ti.com>: >> On Thu, Nov 5, 2015 at 6:15 PM, Simon Glass <s...@chromium.org> wrote: >>> Hi, >>> >>> On 5 November 2015 at 00:32, Nishanth Menon <n...@t

Re: [U-Boot] [PATCH] Makefile: Include vendor common library in include search path

2015-11-06 Thread Nishanth Menon
On 11:10-20151106, Nishanth Menon wrote: > On 11/05/2015 10:50 PM, Masahiro Yamada wrote: > > 2015-11-06 12:30 GMT+09:00 Nishanth Menon <n...@ti.com>: > >> On Thu, Nov 5, 2015 at 6:15 PM, Simon Glass <s...@chromium.org> wrote: > >>> Hi, > >>>

Re: [U-Boot] [PATCH v2] board: ti: beagle_x15: Rename to indicate support for TI am57xx evms

2015-10-31 Thread Nishanth Menon
100%) > rename board/ti/{beagle_x15 => am57xx}/mux_data.h (100%) > delete mode 100644 board/ti/beagle_x15/MAINTAINERS > rename configs/{beagle_x15_defconfig => am57xx_evm_nodt_defconfig} (100%) > rename include/configs/{beagle_x15.h => am57xx_evm.h} (96%) Mostly looks fine to

Re: [U-Boot] [PATCH v2 3/5] ARM: omap-common: Add standard access for board description EEPROM

2015-11-03 Thread Nishanth Menon
; > that, no - let the compiler do the gc anyways? > The gc should work, yes. But this is also TI-centric code and should > end up in board/ti/ similar to how the Siemens AM335x EEPROM code is > under board/siemens/ because they didn't re-use the TI format :) aaah

Re: [U-Boot] [PATCH] mmc: omap_hsmmc: fix initialization order of mmc block devices

2015-10-13 Thread Nishanth Menon
> U-Boot# >> >> So, if this patch has no chance for mainline, please let me >> know it, thanks! >> > > IIRC, Nishanth had posted a patch something similar but got rejected for > some reason. Probably Nishanth can comment more here. > overall the feedback I rece

Re: [U-Boot] [PATCH 1/3] drivers: Introduce a simplified remoteproc framework

2015-08-27 Thread Nishanth Menon
On Thu, Aug 27, 2015 at 10:49 AM, Simon Glass s...@chromium.org wrote: +U-Boot Aaah.. i missed a reply-all, did'nt I?.. Sorry about that. On 26 August 2015 at 16:51, Nishanth Menon n...@ti.com wrote: On Tue, Aug 25, 2015 at 9:26 PM, Simon Glass s...@chromium.org wrote: +#include dm

[U-Boot] [PATCH V2 3/4] sandbox: Introduce dummy remoteproc nodes

2015-08-27 Thread Nishanth Menon
Introduce dummy devices for sandbox remoteproc device and enable it by default Signed-off-by: Nishanth Menon n...@ti.com --- Changes in V2: - review comments incorporated from V1. V1: https://patchwork.ozlabs.org/patch/510196/ arch/sandbox/dts/test.dts | 13 + configs

[U-Boot] [PATCH V2 4/4] test: Add basic tests for remoteproc

2015-08-27 Thread Nishanth Menon
Use the sandbox environment for the basic tests. Signed-off-by: Nishanth Menon n...@ti.com --- New patch. test/dm/Makefile | 1 + test/dm/remoteproc.c | 67 2 files changed, 68 insertions(+) create mode 100644 test/dm/remoteproc.c diff

[U-Boot] [PATCH V2 1/4] drivers: Introduce a simplified remoteproc framework

2015-08-27 Thread Nishanth Menon
, no execution from external memory, or specific image format needs). This basic framework can then (hopefully) be extensible to other complex SoC processor support as need be. Signed-off-by: Nishanth Menon n...@ti.com --- Changes in V2: - review comments incorporated from v1 V1: https

[U-Boot] [PATCH V2 2/4] remoteproc: Introduce a sandbox dummy driver

2015-08-27 Thread Nishanth Menon
with empty hooks. Idea being to give an approximate idea to implement own remoteproc driver using this as a template. Signed-off-by: Nishanth Menon n...@ti.com --- Changes in V2: - review comments incorporated from v1 V1: https://patchwork.ozlabs.org/patch/510197/ drivers/remoteproc

[U-Boot] [PATCH V2 0/4] drivers/sandbox: Introduce a simplified remoteproc framework

2015-08-27 Thread Nishanth Menon
://pastebin.ubuntu.com/12212006/ Nishanth Menon (4): drivers: Introduce a simplified remoteproc framework remoteproc: Introduce a sandbox dummy driver sandbox: Introduce dummy remoteproc nodes test: Add basic tests for remoteproc arch/sandbox/dts/test.dts | 13 + common/Kconfig

Re: [U-Boot] [PATCH V2 4/4] test: Add basic tests for remoteproc

2015-09-16 Thread Nishanth Menon
On 21:46-20150901, Simon Glass wrote: > On 27 August 2015 at 22:07, Nishanth Menon <n...@ti.com> wrote: > > Use the sandbox environment for the basic tests. > > > > Signed-off-by: Nishanth Menon <n...@ti.com> > > --- > > New patch. > > > &g

Re: [U-Boot] [PATCH V2 1/4] drivers: Introduce a simplified remoteproc framework

2015-09-16 Thread Nishanth Menon
int rproc_ping(int id); > > +int rproc_is_running(int id); > > Can you move your function comments to here? This where you define > your API, and it is the file that people will read. Will do so as well. -- Regards, Nishanth Menon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH V2 2/4] remoteproc: Introduce a sandbox dummy driver

2015-09-16 Thread Nishanth Menon
On 21:46-20150901, Simon Glass wrote: > On 27 August 2015 at 22:07, Nishanth Menon <n...@ti.com> wrote: > [...] > Reviewed-by: Simon Glass <s...@chromium.org> Thanks. will update and post the next rev with the mentioned changes incorporated. > > Nit below. [...] &

[U-Boot] [PATCH V3 4/4] test: Add basic tests for remoteproc

2015-09-17 Thread Nishanth Menon
Use the sandbox environment for the basic tests. Reviewed-by: Simon Glass <s...@chromium.org> Tested-by: Simon Glass <s...@chromium.org> Signed-off-by: Nishanth Menon <n...@ti.com> --- Changes since V1: - Comment cleanup (dropped '..') - Picked up Simon's Tested

[U-Boot] [PATCH V3 1/4] drivers: Introduce a simplified remoteproc framework

2015-09-17 Thread Nishanth Menon
, no execution from external memory, or specific image format needs). This basic framework can then (hopefully) be extensible to other complex SoC processor support as need be. Reviewed-by: Simon Glass <s...@chromium.org> Signed-off-by: Nishanth Menon <n...@ti.com> --- Changes since V2:(re

[U-Boot] [PATCH V3 2/4] remoteproc: Introduce a sandbox dummy driver

2015-09-17 Thread Nishanth Menon
with empty hooks. Idea being to give an approximate idea to implement own remoteproc driver using this as a template. Reviewed-by: Simon Glass <s...@chromium.org> Signed-off-by: Nishanth Menon <n...@ti.com> --- Changes Since V2: - Fixed TODO message for removal of non-DT

[U-Boot] [PATCH V3 3/4] sandbox: Introduce dummy remoteproc nodes

2015-09-17 Thread Nishanth Menon
Introduce dummy devices for sandbox remoteproc device and enable it by default Reviewed-by: Simon Glass <s...@chromium.org> Signed-off-by: Nishanth Menon <n...@ti.com> --- Changes since V2: - Picked up Simon's reviewed-by from V2. V2: https://patchwork.ozlabs.org/patch/51175

[U-Boot] [PATCH V3 0/4] drivers/sandbox: Introduce a simplified remoteproc framework

2015-09-17 Thread Nishanth Menon
://marc.info/?l=u-boot=144073487701030=2 V1: http://lists.denx.de/pipermail/u-boot/2015-August/225085.html Test Log: http://pastebin.ubuntu.com/12432507/ Nishanth Menon (4): drivers: Introduce a simplified remoteproc framework remoteproc: Introduce a sandbox dummy driver sandbox: Introduce dummy

[U-Boot] [PATCH] common: cli_simple: Recursively parse variables

2015-12-04 Thread Nishanth Menon
When we use the following in bootargs: v1=abc v2=123-${v1} echo $v2 we get 123-${v1} This is because we do not recursively check to see if v2 by itself has a hidden variable. Fix the same with recursive call Signed-off-by: Nishanth Menon <n...@ti.com> --- Testing with sandbox

[U-Boot] [PATCH] common: cli_hush: Do a simple recursive variables parsing

2015-12-04 Thread Nishanth Menon
level variable default assignment etc would not function. Signed-off-by: Nishanth Menon <n...@ti.com> --- For next level recursion of variables to work, this patch depends on https://patchwork.ozlabs.org/patch/552823/ Tested on Sandbox. common/cli_hush.c | 24

[U-Boot] [PATCH] common: cli_hush: Fix up simple typo

2015-12-04 Thread Nishanth Menon
Correct the spelling for character.. Signed-off-by: Nishanth Menon <n...@ti.com> --- common/cli_hush.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/cli_hush.c b/common/cli_hush.c index a7cac4fcb9df..5a26af80c758 100644 --- a/common/cli_hush.c +++ b/

Re: [U-Boot] [PATCH V2 00/12] Series to move headers to a consistent include location

2015-12-19 Thread Nishanth Menon
ed to just drop the entire series. --- Regards, Nishanth Menon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] drivers: remoteproc: rproc-uclass: Fix check for NULL pointers

2015-11-30 Thread Nishanth Menon
; Signed-off-by: Nishanth Menon <n...@ti.com> --- Test log: http://pastebin.ubuntu.com/13591420/ drivers/remoteproc/rproc-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/remoteproc/rproc-uclass.c b/drivers/remoteproc/rproc-uclass.c index a421e12e5d16..2

Re: [U-Boot] [PATCH] serial: 16550: Drop OMAP1510 support

2016-05-26 Thread Nishanth Menon
On 05/24/2016 07:13 PM, Marek Vasut wrote: > The CONFIG_OMAP1510 is no longer defined, so remove this dead code. > > Signed-off-by: Marek Vasut <ma...@denx.de> > Cc: Tom Rini <tr...@konsulko.com> > Cc: Simon Glass <s...@chromium.org> Acked-by: Nishanth Menon <

Re: [U-Boot] [PATCH] ARM: k2g: Configure reset mux to device reset

2016-05-26 Thread Nishanth Menon
t the reset mux: > - Device Reset > - An interrupt to the ARM_GIC > - An interrupt to the ARM_GIC followed by a device reset. > > Right now to give a default watchdog behaviour "Device reset" is > being selected. > > Signed-off-by: Lokesh Vutla <lokeshvu...

[U-Boot] [PATCH V2 6/6] configs: k2g_evm: Add TI power processor support

2016-02-25 Thread Nishanth Menon
Enable support for PMMC the TI power processor on K2G. This processor manages all power management related activities on the SoC and and allows the Operating Systems on compute processors such as ARM, DSP to offload the power logic away into the power processor. Signed-off-by: Nishanth Menon &l

[U-Boot] [PATCH V2 3/6] ARM: keystone2: psc: introduce function to hold and release module in reset.

2016-02-25 Thread Nishanth Menon
These are useful for modules that need to be held in reset and are enabled for data to be loaded on to them. Typically these are microcontrollers or other processing entities in the system. Signed-off-by: Nishanth Menon <n...@ti.com> --- V2: no change V1: https://patchwork.ozlabs.org/patch/

[U-Boot] [PATCH V2 1/6] ARM: keystone2: psc: redo doc in kernel-doc format

2016-02-25 Thread Nishanth Menon
u-boot coding style guidance in http://www.denx.de/wiki/U-Boot/CodingStyle clearly mentions that the kernel doc style shall be followed for documentation in u-boot. Current PSC documentation standard does not, so fix that. Signed-off-by: Nishanth Menon <n...@ti.com> --- V2: no change V1:

[U-Boot] [PATCH V2 2/6] ARM: keystone2: psc-defs: use adequate () for macros

2016-02-25 Thread Nishanth Menon
'#define X a | b' is better defined as '#define X (a | b)' for obvious reasons. Signed-off-by: Nishanth Menon <n...@ti.com> --- V2: No change V1: https://patchwork.ozlabs.org/patch/510211/ arch/arm/mach-keystone/include/mach/psc_defs.h | 6 +++--- 1 file changed, 3 insertions(+), 3 del

Re: [U-Boot] [PATCH 5/6] ARM: keystone2: use SPD info to configure K2HK and K2E DDR3

2016-02-26 Thread Nishanth Menon
On Fri, Feb 26, 2016 at 12:16 PM, Tom Rini <tr...@konsulko.com> wrote: > On Thu, Feb 25, 2016 at 09:52:14AM -0600, Nishanth Menon wrote: > >> From: Vitaly Andrianov <vita...@ti.com> >> >> This commit replaces hard-coded EMIF and PHY DDR3 configurations for &

Re: [U-Boot] [PATCH V2 5/6] ARM: dts: k2g: Add support for PMMC

2016-02-26 Thread Nishanth Menon
On Fri, Feb 26, 2016 at 12:18 PM, Tom Rini <tr...@konsulko.com> wrote: > On Thu, Feb 25, 2016 at 12:53:46PM -0600, Nishanth Menon wrote: > >> Enable support for PMMC the TI power processor on K2G. This processor >> manages all power management related activities on t

Re: [U-Boot] [PATCH V2 2/6] ARM: keystone2: psc-defs: use adequate () for macros

2016-02-26 Thread Nishanth Menon
On Fri, Feb 26, 2016 at 12:17 PM, Tom Rini <tr...@konsulko.com> wrote: > On Thu, Feb 25, 2016 at 12:53:43PM -0600, Nishanth Menon wrote: > >> '#define X a | b' is better defined as '#define X (a | b)' for obvious >> reasons. >> >> Signed-off-by: Nishanth Meno

Re: [U-Boot] [PATCH V2 5/6] ARM: dts: k2g: Add support for PMMC

2016-02-26 Thread Nishanth Menon
Tom, On Fri, Feb 26, 2016 at 6:27 PM, Tom Rini <tr...@konsulko.com> wrote: > On Fri, Feb 26, 2016 at 06:18:30PM -0600, Nishanth Menon wrote: >> On Fri, Feb 26, 2016 at 12:18 PM, Tom Rini <tr...@konsulko.com> wrote: >> > On Thu, Feb 25, 2016 at 12:53:46

[U-Boot] [PATCH 1/6] ARM: keystone2: Use macro for DSP GEM power domain

2016-02-25 Thread Nishanth Menon
From: Suman Anna <s-a...@ti.com> Define a macro for the DSP GEM power domain id number and use it instead of a hard-coded number in the code that disables all the DSPs on various Keystone2 SoCs. Signed-off-by: Suman Anna <s-a...@ti.com> Signed-off-by: Nishanth Menon <n...@ti.com

[U-Boot] [PATCH 0/6] ARM: keystone2: Miscellaneous fixes

2016-02-25 Thread Nishanth Menon
Hi, Please find various fixes for DDR, DSP and speed grade operations w.r.t Keystone devices Based on master 52dd704bf8ed Merge branch 'master' of http://git.denx.de/u-boot-sunxi Lokesh Vutla (2): ARM: keystone2: Allow for board specific speed definitions ARM: keystone2: K2G: Add

[U-Boot] [PATCH 4/6] ARM: keystone2: K2G: Add support for different arm/device speeds

2016-02-25 Thread Nishanth Menon
m> Signed-off-by: Nishanth Menon <n...@ti.com> --- arch/arm/mach-keystone/clock.c | 7 +++- arch/arm/mach-keystone/include/mach/clock-k2g.h | 4 +- arch/arm/mach-keystone/include/mach/clock.h | 4 ++ board/ti/ks2_evm/board_k2g.c| 50 ++

[U-Boot] [PATCH 5/6] ARM: keystone2: use SPD info to configure K2HK and K2E DDR3

2016-02-25 Thread Nishanth Menon
lation for DDR3 with 1600MHz and 1333MHz only. Signed-off-by: Vitaly Andrianov <vita...@ti.com> Signed-off-by: Lokesh Vutla <lokeshvu...@ti.com> Signed-off-by: Nishanth Menon <n...@ti.com> --- arch/arm/mach-keystone/Makefile| 2 + arch/arm/mach-keystone/d

[U-Boot] [PATCH 2/6] ARM: keystone2: K2G: power-off DSP during boot

2016-02-25 Thread Nishanth Menon
on K2G. Do note that the PSC clock domain module id for DSP on K2G differs from that of previous Keystone2 SoCs. Signed-off-by: Suman Anna <s-a...@ti.com> Signed-off-by: Nishanth Menon <n...@ti.com> --- arch/arm/mach-keystone/include/mach/hardware-k2g.h | 7 +-- 1 file changed,

[U-Boot] [PATCH 3/6] ARM: keystone2: Allow for board specific speed definitions

2016-02-25 Thread Nishanth Menon
From: Lokesh Vutla <lokeshvu...@ti.com> Its not compulsory that speed definition should be same on EFUSE_BOOTROM register for all keystone 2 devices. So, allow for board specific speed definitions. Signed-off-by: Lokesh Vutla <lokeshvu...@ti.com> Signed-off-by: Nishanth Menon

[U-Boot] [PATCH 6/6] ARM: keystone2: use detected ddr3a size

2016-02-25 Thread Nishanth Menon
hat returns ddr3 size has to be implemented. See hardware-k2l.h Signed-off-by: Vitaly Andrianov <vita...@ti.com> Signed-off-by: Nishanth Menon <n...@ti.com> --- arch/arm/mach-keystone/ddr3_spd.c | 10 ++ arch/arm/mach-keystone/include/mach/ddr3.h | 1 + ar

[U-Boot] [PATCH] ARM: keystone2: Get rid of unused clock files

2016-02-24 Thread Nishanth Menon
With commit fe772ebd285b ("ARM: keystone2: Use common definition for clk_get_rate"), we have centralized the clock code into a common clock logic and the redundant files, unfortunately remained... Clean that up. Signed-off-by: Nishanth Menon <n...@ti.com> --- arch/arm/mach-keys

Re: [U-Boot] [PATCH] spl: arm: Make sure to include u_boot_list_*_part_disk_*

2016-03-15 Thread Nishanth Menon
On 03/15/2016 04:58 PM, Tom Rini wrote: > Starting with 96e5b03 we use a linker list for partition table > information. However since we use this in SPL we need to make sure that > the SPL linker scripts include these as well. > > Cc: Nishanth Menon <n...@ti.com> > Cc:

[U-Boot] [PATCH] dm: part: fix missing driver name in debug print

2016-03-15 Thread Nishanth Menon
Fixes the following warning with PART_DEBUG enabled: disk/part.c: In function ‘get_partition_info’: disk/part.c:372:3: warning: format ‘%s’ expects a matching ‘char *’ argument [-Wformat] Signed-off-by: Nishanth Menon <n...@ti.com> --- disk/part.c |3 ++- 1 file changed, 2 insertions

[U-Boot] [PATCH 4/7] board: ti: DRA72: revC evm: Update sdram timing configuration for SR2.0

2016-03-15 Thread Nishanth Menon
ration tool 1.1.1. NOTE: we use eeprom information (ram_size) to update the configuration. Tested-by: Vishal Mahaveer <vish...@ti.com> Signed-off-by: Ravi Babu <ravib...@ti.com> Signed-off-by: Nishanth Menon <n...@ti.com> --- boar

[U-Boot] [PATCH 2/7] ARM: DRA7: hwdata: Update ioreg data for DRA72 SR2.0

2016-03-15 Thread Nishanth Menon
Based on data from EMIF configuration tool 1.1.1. Expected update for CTRL_WKUP_EMIF1_SDRAM_CONFIG_EXT in the next revision of the tool has been incorporated as well. Signed-off-by: Nishanth Menon <n...@ti.com> --- arch/arm/cpu/armv7/omap5/hw_data.c | 16 +++- 1 file chang

[U-Boot] [PATCH 0/7] board: ti: DRA72: Add support for SR2.0 rev C evm

2016-03-15 Thread Nishanth Menon
/ Nishanth Menon (5): ARM: DRA7: hwdata: Update ioreg data for DRA72 SR2.0 ARM: DRA72: sdram: Update sdram ext phy configuration for SR2.0 ARM: OMAP5/DRA7: Split iodelay functionality into sub steps ARM: OMAP5/DRA7: Expose do_set_iodelay board: ti: DRA7: Add DRA72-rev C evm pinmux Ravi Babu

[U-Boot] [PATCH 1/7] ARM: DRA72x: Add support for detection of SR2.0

2016-03-15 Thread Nishanth Menon
From: Ravi Babu <ravib...@ti.com> Add support for detection of SR2.0 version of DRA72x family of processors. Signed-off-by: Ravi Babu <ravib...@ti.com> Signed-off-by: Nishanth Menon <n...@ti.com> --- arch/arm/cpu/armv7/omap5/hw_data.c |2 ++ arch/arm/cpu/armv7/omap5/hw

[U-Boot] [PATCH 7/7] board: ti: DRA7: Add DRA72-rev C evm pinmux

2016-03-15 Thread Nishanth Menon
Add the pinmux data for rev C evm. This is different from previous revisions of the platform thanks to the deltas introduced both from silicon side and from SoC side. Based on J6EcoES2_EVM_Base_Config-20160309b and PCT-DRA72x-v1.3.0.7 for SR2.0 silicon. Signed-off-by: Nishanth Menon <n...@ti.

[U-Boot] [PATCH 5/7] ARM: OMAP5/DRA7: Split iodelay functionality into sub steps

2016-03-15 Thread Nishanth Menon
isolation. While we retain the older __recalibrate_iodelay function which provides a ready sequencing, __recalibrate_iodelay_start and __recalibrate_iodelay_end may be alternatively used now and the callers will be responsible for the correct sequencing of operations. Signed-off-by: Nishanth Menon &l

[U-Boot] [PATCH 6/7] ARM: OMAP5/DRA7: Expose do_set_iodelay

2016-03-15 Thread Nishanth Menon
do_set_iodelay can now be used from board files based on needs of the platforms variation they have. Signed-off-by: Nishanth Menon <n...@ti.com> --- arch/arm/cpu/armv7/omap5/dra7xx_iodelay.c|4 ++-- arch/arm/include/asm/arch-omap5/dra7xx_iodelay.h |2 ++ 2 files chan

[U-Boot] [PATCH 3/7] ARM: DRA72: sdram: Update sdram ext phy configuration for SR2.0

2016-03-15 Thread Nishanth Menon
Based on data from EMIF configuration tool 1.1.1. Signed-off-by: Nishanth Menon <n...@ti.com> --- arch/arm/cpu/armv7/omap5/sdram.c | 44 +- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/arch/arm/cpu/armv7/omap5/sdram.c b/arch/arm/cpu

Re: [U-Boot] [PATCH] ti_armv7_common: env: Add NFS loading support to default enviroment

2016-03-11 Thread Nishanth Menon
NFS configs/|grep -v "is not set" it might actually be nicer.. for the actual env variables to eventually get into include/config_distro_bootcmd.h perhaps? I dont know about that atm.. -- Regards, Nishanth Menon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 0/3] ARM: keystone2: Cleanup macros

2016-03-15 Thread Nishanth Menon
: http://pastebin.ubuntu.com/15392337/ Nishanth Menon (3): ARM: keystone2: Convert BOOTBITMASK to static inline function ARM: keystone2: Convert BOOT_READ_BITFIELD into static inline function ARM: keystone2: Convert BOOT_SET_BITFIELD into static inline function arch/arm/mach-keystone/include

[U-Boot] [PATCH 3/3] ARM: keystone2: Convert BOOT_SET_BITFIELD into static inline function

2016-03-15 Thread Nishanth Menon
Fix up BOOT_SET_BITFIELD to be a static inline function to be readable with the same functionality. Reported-by: Tom Rini <tr...@konsulko.com> Signed-off-by: Nishanth Menon <n...@ti.com> --- arch/arm/mach-keystone/include/mach/psc_defs.h | 18 +++--- 1 file changed, 1

[U-Boot] [PATCH 1/3] ARM: keystone2: Convert BOOTBITMASK to static inline function

2016-03-15 Thread Nishanth Menon
BOOTBITMASK is almost impossible to decode, so convert it into a simpler static line functions of equivalent solution. Reported-by: Tom Rini <tr...@konsulko.com> Signed-off-by: Nishanth Menon <n...@ti.com> --- arch/arm/mach-keystone/include/mach/psc_defs.h | 14 +- 1 fil

[U-Boot] [PATCH 2/3] ARM: keystone2: Convert BOOT_READ_BITFIELD into static inline function

2016-03-15 Thread Nishanth Menon
BOOT_READ_BITFIELD can easily be a static inline function and be a little more readable with the same functionality. Reported-by: Tom Rini <tr...@konsulko.com> Signed-off-by: Nishanth Menon <n...@ti.com> --- arch/arm/mach-keystone/include/mach/psc_defs.h | 25 +++--

[U-Boot] [PATCH] board: ti: am57xx: Update EMIF SDRAM 1 and 3 Timings

2016-04-08 Thread Nishanth Menon
tivate for a different bank, minus 1. Update T_CKESR from 4 to 3 based on AM57xx TRM - Minimum number of DDR clocks cycles for which SDRAM must remain in self refresh, minus 1. Signed-off-by: Schuyler Patton <spat...@ti.com> Signed-off-by: Nishanth Menon <n...@ti.com> --- X15 BOM:

[U-Boot] [PATCH] board: ti: am57xx: Add support for am572x idk in SPL

2016-04-08 Thread Nishanth Menon
system support with this patch. Signed-off-by: Schuyler Patton <spat...@ti.com> Signed-off-by: Steve Kipisz <s-kipi...@ti.com> Signed-off-by: Nishanth Menon <n...@ti.com> --- Boot Log: http://pastebin.ubuntu.com/15699618/ board/ti/am57xx/board.c| 32 +- board/ti

[U-Boot] [PATCH 0/2] ARM: keystone2: Fix missing privilege ID

2016-03-23 Thread Nishanth Menon
by u-boot wrong access to GPMC. (testing was performed using out-of-tree solution for this) Nishanth Menon (2): ARM: keystone2: Refactor MSMC macros to avoid #ifdeffery ARM: keystone2: Add missing privilege ID settings arch/arm/mach-keystone/include/mach/hardware-k2e.h | 3 - arch/arm/mach

[U-Boot] [PATCH 2/2] ARM: keystone2: Add missing privilege ID settings

2016-03-23 Thread Nishanth Menon
as shared, we also ensure SoC wide coherency is enabled. Reported-by: Bin Liu <b-...@ti.com> Signed-off-by: Nishanth Menon <n...@ti.com> --- arch/arm/mach-keystone/include/mach/hardware.h | 23 ++ arch/arm/mach-keystone/init.c | 32 +++

[U-Boot] [PATCH 1/2] ARM: keystone2: Refactor MSMC macros to avoid #ifdeffery

2016-03-23 Thread Nishanth Menon
the PCIe configuration is moved after the msmc configuration is complete, but that should ideally have no functional impact. Signed-off-by: Nishanth Menon <n...@ti.com> --- arch/arm/mach-keystone/include/mach/hardware-k2e.h | 3 -- arch/arm/mach-keystone/include/mach/hardware-k2l.h | 3 -- ar

[U-Boot] [PATCH V2 2/6] ARM: keystone2: K2G: power-off DSP during boot

2016-03-04 Thread Nishanth Menon
on K2G. Do note that the PSC clock domain module id for DSP on K2G differs from that of previous Keystone2 SoCs. Signed-off-by: Suman Anna <s-a...@ti.com> Signed-off-by: Nishanth Menon <n...@ti.com> Reviewed-by: Tom Rini <tr...@konsulko.com> --- Changes in V2: - Picked

[U-Boot] [PATCH V2 5/6] ARM: keystone2: use SPD info to configure K2HK and K2E DDR3

2016-03-04 Thread Nishanth Menon
lation for DDR3 with 1600MHz and 1333MHz only. Signed-off-by: Vitaly Andrianov <vita...@ti.com> Signed-off-by: Lokesh Vutla <lokeshvu...@ti.com> Signed-off-by: Nishanth Menon <n...@ti.com> --- Changes in V2: - Updated copyright to include 2016 - remoted puts

[U-Boot] [PATCH V2 4/6] ARM: keystone2: K2G: Add support for different arm/device speeds

2016-03-04 Thread Nishanth Menon
m> Signed-off-by: Nishanth Menon <n...@ti.com> Reviewed-by: Tom Rini <tr...@konsulko.com> --- Changes in V2: - Picked up Reviewed by V1: https://patchwork.ozlabs.org/patch/588156/ arch/arm/mach-keystone/clock.c | 7 +++- arch/arm/mach-keystone/inclu

[U-Boot] [PATCH V2 6/6] ARM: keystone2: use detected ddr3a size

2016-03-04 Thread Nishanth Menon
hat returns ddr3 size has to be implemented. See hardware-k2l.h Signed-off-by: Vitaly Andrianov <vita...@ti.com> Signed-off-by: Nishanth Menon <n...@ti.com> Reviewed-by: Tom Rini <tr...@konsulko.com> --- Changes in V2: - Picked up Reviewed by V1: https://patchwork.ozlabs

[U-Boot] [PATCH V2 1/6] ARM: keystone2: Use macro for DSP GEM power domain

2016-03-04 Thread Nishanth Menon
From: Suman Anna <s-a...@ti.com> Define a macro for the DSP GEM power domain id number and use it instead of a hard-coded number in the code that disables all the DSPs on various Keystone2 SoCs. Signed-off-by: Suman Anna <s-a...@ti.com> Signed-off-by: Nishanth Menon <n...@t

[U-Boot] [PATCH V2 3/6] ARM: keystone2: Allow for board specific speed definitions

2016-03-04 Thread Nishanth Menon
From: Lokesh Vutla <lokeshvu...@ti.com> Its not compulsory that speed definition should be same on EFUSE_BOOTROM register for all keystone 2 devices. So, allow for board specific speed definitions. Signed-off-by: Lokesh Vutla <lokeshvu...@ti.com> Signed-off-by: Nishanth Menon

[U-Boot] [PATCH V2 0/6] ARM: keystone2: Miscellaneous fixes

2016-03-04 Thread Nishanth Menon
Hi, Please find various fixes for DDR, DSP and speed grade operations w.r.t Keystone devices Based on master 52dd704bf8ed Merge branch 'master' of http://git.denx.de/u-boot-sunxi Changes in V2: - updates to patch #5 (review comments) - picked up reviewed by V1:

[U-Boot] [PATCH 1/4] ARM: OMAP5/DRA7: Get rid of control_std_fuse_opp_vdd_mpu_2

2016-04-21 Thread Nishanth Menon
ons especially since they are reused. This also makes it simpler to prevent mistakes involved when changing the boot OPP for the device. Signed-off-by: Nishanth Menon <n...@ti.com> --- arch/arm/cpu/armv7/omap-common/clocks-common.c | 4 ++-- arch/arm/cpu/armv7/omap5/prcm-regs.c | 2

[U-Boot] [PATCH 3/4] ARM: OMAP5: Enable ABB configuration for MM voltage domain

2016-04-21 Thread Nishanth Menon
Woodruff <r-woodru...@ti.com> Signed-off-by: Nishanth Menon <n...@ti.com> --- arch/arm/cpu/armv7/omap-common/clocks-common.c | 9 + arch/arm/cpu/armv7/omap5/hw_data.c | 1 + arch/arm/cpu/armv7/omap5/prcm-regs.c | 4 arch/arm/include/asm/arch-omap5/omap.h

[U-Boot] [PATCH 0/4] ARM: OMAP5/DRA7: Update ABB Configuration for all valid domains

2016-04-21 Thread Nishanth Menon
consistent with the voltage configuration for all domains that have need for ABB. Series is based on v2016.05-rc2 Boot Log: OMAP5uevm: http://pastebin.ubuntu.com/15971620/ AM572x-X15: http://pastebin.ubuntu.com/15971707/ Nishanth Menon (4): ARM: OMAP5/DRA7: Get rid

[U-Boot] [PATCH 4/4] ARM: DRA7: Add ABB setup for all domains

2016-04-21 Thread Nishanth Menon
to debug. This specifically is a concern with DRA7 generation of SoCs since other than VDD_MPU, all other domains are only permitted to setup the voltages to required OPP only at boot. Reported-by: Richard Woodruff <r-woodru...@ti.com> Signed-off-by: Nishanth Menon <n...@ti.com> --- arch/a

[U-Boot] [PATCH 2/4] ARM: OMAP5/DRA7: Move ABB TXDONE mask to voltage structure

2016-04-21 Thread Nishanth Menon
-by: Nishanth Menon <n...@ti.com> --- arch/arm/cpu/armv7/omap-common/clocks-common.c | 4 ++-- arch/arm/cpu/armv7/omap5/hw_data.c | 3 +++ arch/arm/include/asm/omap_common.h | 2 ++ board/ti/am57xx/board.c| 1 + 4 files changed, 8 insertions

Re: [U-Boot] [PATCH] ARM: OMAP4+: Fix DPLL programming sequence

2016-05-23 Thread Nishanth Menon
_dividers: > + setup_post_dividers(base, params); > + > /* Lock */ > if (lock) > do_lock_dpll(base); > > -setup_post_dividers: > - setup_post_dividers(base, params); > - > /* Wait till the DPLL locks */ > if (lock) >

Re: [U-Boot] [PATCH 1/3] SPL: Let spl_parse_image_header() return value

2016-05-20 Thread Nishanth Menon
return err; > > - spl_parse_image_header(header); > + err = spl_parse_image_header(header); > + if (err) > + return err; > err = spi_flash_read(flash, CONFIG_SYS_SPI_U_BOOT_OFFS, >

Re: [U-Boot] keystone: k2h/e/l: Fix DMA coherency for QM PDSP

2016-07-18 Thread Nishanth Menon
coherency for QM PDSP. Given that msmc_k2hkle_common_setup is valid for all K2H/K/L/E SoCs, the #ifdef should been removed in the first place. Do the same. Signed-off-by: Murali Karicheri <m-kariche...@ti.com> Acked-by: Nishanth Menon <n...@ti.com> --- arch/arm/mach-keystone/init.c |

Re: [U-Boot] [PATCH v2 1/6] arm: am57xx: reintroduce the CONFIG_AM57XX symbol

2017-02-14 Thread Nishanth Menon
have no understanding of USB integration done in u-boot to comment better. -- Regards, Nishanth Menon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] board: am57xx: Fix missing check for beagle_x15

2016-09-02 Thread Nishanth Menon
On Fri, Sep 2, 2016 at 6:04 AM, Lokesh Vutla <lokeshvu...@ti.com> wrote: > > > On Friday 02 September 2016 01:23 PM, Nishanth Menon wrote: [...] > Instead an entry can be added for x15 like below? So, that future rev of > x15 can be updated > > diff --git a/board/t

[U-Boot] [PATCH V2] board: am57xx: Fix missing check for beagle_x15

2016-09-02 Thread Nishanth Menon
When beagleboard-X15 is booted, we see the following log: Unidentified board claims BBRDX15_ in eeprom header This is because of the missing check for x15 (the default) and reports an error for a valid board configuration. Fix the same. Signed-off-by: Nishanth Menon <n...@ti.com> --- C

Re: [U-Boot] [PATCH v2 0/7] Adds support for secure boot on Keystone SoCs (K2E)

2016-09-03 Thread Nishanth Menon
at u-boot. we dont want to detect and hang in kernel - the debug is just painful. -- Regards, Nishanth Menon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] board: am57xx: Fix missing check for beagle_x15

2016-09-02 Thread Nishanth Menon
When beagleboard-X15 is booted, we see the following log: Unidentified board claims BBRDX15_ in eeprom header This is because of the missing check for x15 (the default) and reports an error for a valid board configuration. fix the same. Signed-off-by: Nishanth Menon <n...@ti.com> ---

[U-Boot] [PATCH] board: am57xx: MAINTAINERS: Update for current maintainer

2016-09-02 Thread Nishanth Menon
Felipe Balbi has move on from TI and the current email ID is no longer valid. So, replacing with Lokesh. While at it, update missing config file which was untracked. Signed-off-by: Nishanth Menon <n...@ti.com> --- board/ti/am57xx/MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 de

[U-Boot] [PATCH 2/3] ti: common: board_detect: Setup initial default value for config as well

2016-10-11 Thread Nishanth Menon
config should have been initialized along with others as defaults. Signed-off-by: Nishanth Menon <n...@ti.com> --- board/ti/common/board_detect.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/board/ti/common/board_detect.c b/board/ti/common/board_detect.c index 7c552d20656a..13aac2

[U-Boot] [PATCH 3/3] ti: common: board_detect: Return a valid empty string for un-initialized eeprom

2016-10-11 Thread Nishanth Menon
the empty string to the caller. Reported-by: Brad Griffis <bgrif...@ti.com> Signed-off-by: Nishanth Menon <n...@ti.com> --- board/ti/common/board_detect.c | 12 +++- board/ti/common/board_detect.h | 6 +++--- 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/board/ti

[U-Boot] [PATCH 1/3] ti: common: board_detect: Replace hardcoded value with macro

2016-10-11 Thread Nishanth Menon
We should have used TI_DEAD_EEPROM_MAGIC in the first place. Fixes: d3b98a9eb941 ("ti: common: dra7: Add standard access for board description EEPROM") Signed-off-by: Nishanth Menon <n...@ti.com> --- board/ti/common/board_detect.c | 2 +- 1 file changed, 1 insertion(+), 1 d

[U-Boot] [PATCH 0/3] ti: common: board_detect: basic fixes for blank eeprom

2016-10-11 Thread Nishanth Menon
In some cases where eeprom has not been programmed, Brad reported issues of crash at strcmp against NULL, this series was triggered thanks to issue in manufacturing flow where the mandatory eeprom programming was missed. Nishanth Menon (3): ti: common: board_detect: Replace hardcoded value

Re: [U-Boot] __FILE__ usage and and SPL limits for SRAM

2017-03-28 Thread Nishanth Menon
not build into the source folder, instead, all binary builds are pointed to either a temporary location or a package build location. So, while O=source_path/build would aliviate the problem, it still does'nt really solve the root of the issue. -- --- Regards, Nishanth Menon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

<    1   2   3   4   5   6   7   8   9   10   >