From: Ovidiu Panait
Existing debug output is mixed with the function name:
initcall_run_list() initcall: 25263initcall_run_list() (relocated to 425263)
Turn it to:
initcall_run_list() initcall: 25263 (relocated to 425263)
Signed-off-by: Ovidiu Panait
---
include/initcall.h | 8 +---
1
clear_bss is already used by 3 arches (x86, arc, xtensa), so make it generic
and provide a weak nop stub for it. This also removes arch-specific ifdef
duplications around clear_bss.
Signed-off-by: Ovidiu Panait
---
common/board_f.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions
This removes the arch-specific checks for "checkcpu" function from the init
sequence. Make "checkcpu" generic and provide a weak nop stub instead.
Signed-off-by: Ovidiu Panait
---
common/board_f.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git
Do this as a preparation for removing initr_bedbug wrapper from
common/board_r.c.
Signed-off-by: Ovidiu Panait
---
cmd/bedbug.c | 4 ++--
include/bedbug/type.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/cmd/bedbug.c b/cmd/bedbug.c
index 9fee528830
Drop initr_bedbug wrapper and call bedbug_init directly during the init
sequence.
Signed-off-by: Ovidiu Panait
---
common/board_r.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/common/board_r.c b/common/board_r.c
index bdb0389e31..d9015cd057 100644
initr_enable_interrupts() is an ARM-specific wrapper over enable_interrupts(),
which is run during the common init sequence. It can be eliminated by moving
the enable_interrupts() call to the end of interrupt_init() function, in
arch/arm/lib/interrupts*.c.
Signed-off-by: Ovidiu Panait
---
arch
Drop initr_bedbug wrapper and call bedbug_init directly during the init
sequence.
Signed-off-by: Ovidiu Panait
Reviewed-by: Simon Glass
---
v2 updates:
- add reviewed-by tag
common/board_r.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/common/board_r.c b
Do this as a preparation for removing initr_bedbug wrapper from
common/board_r.c.
Signed-off-by: Ovidiu Panait
Reviewed-by: Simon Glass
---
v2 updates:
- fix checkpatch warnings
- add reviewed-by tag
cmd/bedbug.c | 4 ++--
include/bedbug/type.h | 2 +-
2 files changed, 3
initr_enable_interrupts() is an ARM-specific wrapper over
enable_interrupts(), which is run during the common init sequence. It can
be eliminated by moving the enable_interrupts() call to the end of
interrupt_init() function, in arch/arm/lib/interrupts*.c.
Signed-off-by: Ovidiu Panait
Reviewed
On 05.04.2020 19:53, Sean Anderson wrote:
On 4/5/20 12:47 PM, Ovidiu Panait wrote:
Currently, dm drivers command produces a segfault:
=> dm drivers
DriverCompatible
Segmentation fault (core dumped)
This is caused by a NULL pointer derefere
Currently, dm drivers command produces a segfault:
=> dm drivers
DriverCompatible
Segmentation fault (core dumped)
This is caused by a NULL pointer dereference of entry->of_match.
Add a check to prevent this.
Signed-off-by: Ovidiu Panait
Cc
Refactor the printing sequence in dm_dump_drivers to make it more clear.
Signed-off-by: Ovidiu Panait
Cc: Sean Anderson
Cc: Simon Glass
---
drivers/core/dump.c | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/core/dump.c b/drivers/core/dump.c
).
Signed-off-by: Ovidiu Panait
---
arch/arm/include/asm/cache.h | 2 ++
arch/arm/lib/cache.c | 33 +
arch/arm/mach-versal/cpu.c | 6 +-
arch/arm/mach-zynqmp/cpu.c | 6 +-
common/board_f.c | 32
Move the ARM-specific reserve_mmu definition from common/board_f.c
to arch/arm/lib/cache.c.
Signed-off-by: Ovidiu Panait
---
arch/arm/lib/cache.c | 28
common/board_f.c | 28
2 files changed, 28 insertions(+), 28 deletions(-)
diff
arch_reserve_mmu, there would be two
weak definitions for it, one in common/board_f.c and one in
arch/arm/lib/cache.c.
Signed-off-by: Ovidiu Panait
---
arch/arm/include/asm/cache.h | 11 +++
arch/arm/lib/cache.c | 5 +
arch/arm/mach-versal/cpu.c | 3 ++-
arch/arm/mach-zynqmp
Introduce arch_reserve_mmu to allow for architecture-specific reserve_mmu
routines. Also, define a weak nop stub for it.
Signed-off-by: Ovidiu Panait
---
arch/arm/lib/cache.c | 2 +-
common/board_f.c | 9 ++---
include/init.h | 13 -
3 files changed, 19 insertions
e.c:9:
arch/arm/lib/cache.c:141:52: error: 'volatile struct arch_global_data' has no
member named 'tlb_addr'
...
Ovidiu Panait (3):
common/board_f: Move arm-specific reserve_mmu to arch/arm/lib/cache.c
arm: asm/cache.c: Introduce arm_reserve_mmu
common/board_f: Make reserve_mmu ge
ved
when the number of commits change. By removing the _of_#_ part of the
directory path, the commits will be rebuilt only if the commit sha or the
position in the patchset changes. Also, update the testcase to reflect this
change.
Signed-off-by: Ovidiu Panait
---
tools/buildman/builder.py |
This converts ad-hoc CONFIG_DELAY_ENVIRONMENT to Kconfig.
Signed-off-by: Ovidiu Panait
---
env/Kconfig | 12
scripts/config_whitelist.txt | 1 -
2 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/env/Kconfig b/env/Kconfig
index af63ac52f7..ed94e83ec1
Replace the "pci enum" preboot sequence with CONFIG_PCI_INIT_R=y.
Signed-off-by: Ovidiu Panait
---
configs/qemu_arm_defconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/configs/qemu_arm_defconfig b/configs/qemu_arm_defconfig
index f807dfc10e..a847398
Enable CONFIG_PCI_INIT_R for qemux86 and qemux86-64 pci enumeration during
boot in order to eliminate the custom preboot commands in
include/configs/qemu-x86.h.
Signed-off-by: Ovidiu Panait
---
configs/qemu-x86_64_defconfig | 1 +
configs/qemu-x86_defconfig| 1 +
include/configs/qemu-x86.h
preserves the current behavior in the !DM_PCI case
(pci_init is run unconditionally at boot).
Signed-off-by: Ovidiu Panait
---
common/Kconfig | 10 ++
common/board_r.c | 5 ++---
2 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/common/Kconfig b/common/Kconfig
index
Use IS_ENABLED() instead of #ifdef in should_load_env and initr_env
functions.
No functional change intended.
Signed-off-by: Ovidiu Panait
---
common/board_r.c | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/common/board_r.c b/common/board_r.c
index
Replace the "pci enum" preboot sequence with CONFIG_PCI_INIT_R=y.
Signed-off-by: Ovidiu Panait
---
configs/qemu_arm64_defconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/configs/qemu_arm64_defconfig b/configs/qemu_arm64_defconfig
index 80e0ad55e0..53c653d
00 WA 0 0 32
This means that the __bss_start assignment in the linker script is bogus,
as the actual bss section start is located elsewhere. Remove this
assignment, as the __bss_start symbol is not used on sandbox anyway.
Signed-off-by: Ovidiu Panait
---
arch/sandbox/
ifdef CONFIG_SYS_I2C
...
#else
...
#endif
}
#endif
Remove the dead #else preprocessor code.
Fixes: 69153988a6f ("i2c: Finish dropping use of CONFIG_I2C_HARD")
Signed-off-by: Ovidiu Panait
---
common/board_f.c | 4
1 file changed, 4 deletions(-)
diff --g
if (IS_ENABLED(CONFIG_SYS_HAS_SRAM)) {
bd->bi_sramstart = CONFIG_SYS_SRAM_BASE; /* start of SRAM */
bd->bi_sramsize = CONFIG_SYS_SRAM_SIZE; /* size of SRAM */
Reviewed-by: Ovidiu Panait
9,6 @@ int checkboard(void)
return 0;
}
-int dram_init_banksize(void)
-{
- return 0;
-}
-
int board_postclk_init(void)
{
/*
Reviewed-by: Ovidiu Panait
bdinfo_print_num("sramstart", (ulong)bd->bi_sramstart);
bdinfo_print_num("sramsize", (ulong)bd->bi_sramsize);
Reviewed-by: Ovidiu Panait
lude
-
-DECLARE_GLOBAL_DATA_PTR;
-
-int arch_setup_bdinfo(void)
-{
- struct bd_info *bd = gd->bd;
-
- bd->bi_memstart = PHYSADDR(CONFIG_SYS_SDRAM_BASE);
- bd->bi_memsize = CONFIG_SYS_SDRAM_SIZE;
-
- return 0;
-}
Reviewed-by: Ovidiu Panait
From: Ovidiu Panait
Factor out reading IP base address to ofdata_to_platdata function, which
is designed for this purpose. Also, drop the dev->priv NULL check, since
this is already done by the dm core when allocating space using
priv_auto_alloc_size feature. (in drivers/core/devic
From: Ovidiu Panait
Remove CONFIG_IS_ENABLED(OF_CONTROL) check from DM_FLAG_PRE_RELOC, since
this driver only supports OF_CONTROL.
drivers/pinctrl/broadcom/Kconfig:
config PINCTRL_BCM283X
depends on ARCH_BCM283X && PINCTRL_FULL && OF_CONTROL
Cc: Matthias Brugger
Signe
From: Ovidiu Panait
Currently, the return value of dev_read_u32_default is stored in an u32,
causing the subsequent "if (function < 0)" to always be false:
u32 function;
...
function = dev_read_u32_default(config, "brcm,function", -1);
if (function < 0) {
debu
->reloc_off for post-reloc
exception setup.
Cc: Michal Simek
Signed-off-by: Ovidiu Panait
---
v2:
- fix coding style
- save r2/r3/r6/r7/r8/r10 on the stack when entering __setup_exceptions
arch/microblaze/cpu/start.S | 197 +++-
1 file changed, 103 inserti
Implement early init by calling generic board_init_f_alloc_reserve and
board_init_f_init_reserve functions:
* drop SYS_MALLOC_F_LEN related code, as allocation and gd->malloc_base
assignment are taken care of by the generic functions
* drop _gd logic
Cc: Michal Simek
Signed-off-by: Ovi
also fixes the following build error when CONFIG_SPL_SIZE_LIMIT
is set by menuconfig to 0x0:
...
spl/u-boot-spl.bin exceeds file size limit:
limit: 0 bytes
actual: 0x80f0 bytes
excess: 0x80f0 bytes
Signed-off-by: Ovidiu Panait
---
Makefile | 4 ++--
common/s
checking (void *)FDT_ADDR_T_NONE to check for NULL.
Signed-off-by: Ovidiu Panait
---
drivers/clk/aspeed/clk_ast2500.c | 4 ++--
drivers/core/fdtaddr.c| 5 -
drivers/i2c/ast_i2c.c | 4 ++--
drivers/pinctrl/mvebu/pinctrl-mvebu.c | 2 +-
drivers/timer
Remove CONFIG_IS_ENABLED(OF_CONTROL) check from DM_FLAG_PRE_RELOC, since
this driver only supports OF_CONTROL.
drivers/pinctrl/broadcom/Kconfig:
config PINCTRL_BCM283X
depends on ARCH_BCM283X && PINCTRL_FULL && OF_CONTROL
Signed-off-by: Ovidiu Panait
---
drivers/pinctrl/
atdata).
Signed-off-by: Ovidiu Panait
---
drivers/pinctrl/broadcom/pinctrl-bcm283x.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/pinctrl/broadcom/pinctrl-bcm283x.c
b/drivers/pinctrl/broadcom/pinctrl-bcm283x.c
index 8bf7916627..9ab0baee33
dev_read_addr_ptr returns NULL on failure, so add the proper check.
Signed-off-by: Ovidiu Panait
---
drivers/pinctrl/broadcom/pinctrl-bcm283x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/broadcom/pinctrl-bcm283x.c
b/drivers/pinctrl/broadcom/pinctrl
unction for pinconfig %s (%d)\n",
config->name, function);
return -EINVAL;
}
Make "function" variable an int to fix this.
Signed-off-by: Ovidiu Panait
---
drivers/pinctrl/broadcom/pinctrl-bcm283x.c | 2 +-
1 file changed, 1 insertion(+), 1 d
Implement early init by calling generic board_init_f_alloc_reserve and
board_init_f_init_reserve functions:
* drop SYS_MALLOC_F_LEN related code, as allocation and gd->malloc_base
assignment are taken care of by the generic functions
* drop _gd logic
Signed-off-by: Ovidiu Panait
---
a
->reloc_off for post-reloc
exception setup.
Signed-off-by: Ovidiu Panait
---
arch/microblaze/cpu/start.S | 183 +---
1 file changed, 88 insertions(+), 95 deletions(-)
diff --git a/arch/microblaze/cpu/start.S b/arch/microblaze/cpu/start.S
index cbec299
Hi Simon,
On 21.07.2020 17:17, Simon Glass wrote:
On Mon, 20 Jul 2020 at 08:20, Ovidiu Panait wrote:
Factor out ppc-specific bdinfo setup from generic init sequence to
arch_setup_bdinfo in arch/powerpc/lib/bdinfo.c.
Signed-off-by: Ovidiu Panait
---
arch/powerpc/lib/bdinfo.c | 25
(void *)FDT_ADDR_T_NONE to check for NULL.
Signed-off-by: Ovidiu Panait
---
drivers/clk/aspeed/clk_ast2500.c | 4 ++--
drivers/core/fdtaddr.c| 4 +++-
drivers/i2c/ast_i2c.c | 4 ++--
drivers/pinctrl/mvebu/pinctrl-mvebu.c | 2 +-
drivers/timer/ast_timer.c
Add flat tree test case to cover devfdt_get_addr_ptr function.
Signed-off-by: Ovidiu Panait
---
test/dm/test-fdt.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/test/dm/test-fdt.c b/test/dm/test-fdt.c
index 8ef7c7a88e..fc089684ac 100644
--- a/test/dm/test-fdt.c
+++ b
Hi Stefan,
On 13.08.2020 08:47, Stefan Roese wrote:
arch_setup_bdinfo() only configures the deprecated bi_memstart &
bi_memsize values, which should not be needed any more. Lets remove
this file completely.
Signed-off-by: Stefan Roese
---
Changes in v4:
- New patch
Hi Stefan,
On 13.08.2020 11:15, Stefan Roese wrote:
Hi Ovidiu,
On 13.08.20 10:09, Stefan Roese wrote:
Hi Ovidiu,
On 13.08.20 09:57, Ovidiu Panait wrote:
Hi Stefan,
On 13.08.2020 08:47, Stefan Roese wrote:
arch_setup_bdinfo() only configures the deprecated bi_memstart &
bi_memsize va
earlier and might call blkcache_invalidate (in
mmc_select_hwpart()) when trying to load the environment from mmc via
env_load().
To fix this issue, move blkcache_init boot call earlier, before mmc gets
initialized.
Cc: Angelo Durgehello
Signed-off-by: Ovidiu Panait
---
common/board_r.c | 6
Use IS_ENABLED() instead of #ifdef in blk_post_probe function.
No functional change intended.
Signed-off-by: Ovidiu Panait
---
drivers/block/blk-uclass.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/block/blk-uclass.c b/drivers/block/blk-uclass.c
index
Factor out ppc-specific bdinfo setup from generic init sequence to
arch_setup_bdinfo in arch/powerpc/lib/bdinfo.c.
Signed-off-by: Ovidiu Panait
---
arch/powerpc/lib/bdinfo.c | 42 +++
common/board_f.c | 39 ++--
2
Factor out m68k-specific bdinfo setup to arch_setup_bdinfo in
arch/m68k/lib/bdinfo.c. Also, use if(IS_ENABLED()) instead of #ifdef where
possible.
Signed-off-by: Ovidiu Panait
---
arch/m68k/lib/bdinfo.c | 32
common/board_f.c | 14 --
2 files
Extend manual relocation of block_cache list pointers to all platforms that
enable CONFIG_NEEDS_MANUAL_RELOC. Remove m68k-specific checks and provide a
single implementation that adds gd->reloc_off to the pre-relocation
pointers.
Cc: Angelo Durgehello
Signed-off-by: Ovidiu Panait
---
com
in order to silence the following checkpatch
warning:
check: extern prototypes should be avoided in .h files
Signed-off-by: Ovidiu Panait
---
drivers/serial/serial-uclass.c | 4 ++--
drivers/serial/serial.c| 4 +++-
include/serial.h | 2 +-
3 files changed, 6 insertions(+), 4
Hi,
On 09.07.2020 12:15, Heinrich Schuchardt wrote:
On 09.07.20 10:04, Ovidiu Panait wrote:
Factor out mips-specific bdinfo setup from generic init sequence to
arch_setup_bdinfo in arch/mips/lib/boot.c.
Signed-off-by: Ovidiu Panait
---
arch/mips/lib/boot.c | 18 ++
common
Remove the initr_serial->serial_initialize indirection and call
serial_initialize directly.
Signed-off-by: Ovidiu Panait
---
common/board_r.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/common/board_r.c b/common/board_r.c
index 5e924322b2..522059c5a5 100
Factor out sh-specific bdinfo setup from generic init sequence to
arch_setup_bdinfo in arch/sh/lib/board.c.
Signed-off-by: Ovidiu Panait
---
arch/sh/lib/board.c | 18 ++
common/board_f.c| 4 ++--
2 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/arch/sh/lib
nit,
introduce arch_setup_bdinfo weak initcall so that everyone can define their
own bdinfo setup routines.
Signed-off-by: Ovidiu Panait
---
common/board_f.c | 6 ++
include/init.h | 12
2 files changed, 18 insertions(+)
diff --git a/common/board_f.c b/common/board_f.c
in
Factor out mips-specific bdinfo setup from generic init sequence to
arch_setup_bdinfo in arch/mips/lib/boot.c.
Signed-off-by: Ovidiu Panait
---
arch/mips/lib/boot.c | 18 ++
common/board_f.c | 25 +
2 files changed, 19 insertions(+), 24 deletions
Factor out sh-specific bdinfo setup from generic init sequence to
arch_setup_bdinfo in arch/sh/lib/board.c. Also, use if(IS_ENABLED())
instead of #ifdef where possible.
Signed-off-by: Ovidiu Panait
---
v2 updates:
- use "if (IS_ENABLED(CONFIG_SYS_HAS_SRAM))" instead of
Factor out ppc-specific bdinfo setup from generic init sequence to
arch_setup_bdinfo in arch/powerpc/lib/bdinfo.c. Also, use if(IS_ENABLED())
instead of #ifdef where possible.
Signed-off-by: Ovidiu Panait
---
v2 updates:
- use "if (IS_ENABLED(CONFIG_SYS_HAS_SRAM))" instead of
in order to silence the following checkpatch
warning:
check: extern prototypes should be avoided in .h files
Reviewed-by: Simon Glass
Signed-off-by: Ovidiu Panait
---
v2 updates:
- add reviewed-by tag
drivers/serial/serial-uclass.c | 4 ++--
drivers/serial/serial.c| 4 +++-
include/serial.h
off-by: Ovidiu Panait
---
v2 updates:
- add reviewed-by tag
common/board_r.c | 2 +-
drivers/block/blkcache.c | 13 +++--
2 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/common/board_r.c b/common/board_r.c
index 522059c5a5..29d831d5eb 100644
--- a/common/board_r.c
++
Remove the initr_serial->serial_initialize indirection and call
serial_initialize directly.
Reviewed-by: Simon Glass
Signed-off-by: Ovidiu Panait
---
v2 updates:
- add reviewed-by tag
common/board_r.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/common/board_
earlier and might call blkcache_invalidate (in
mmc_select_hwpart()) when trying to load the environment from mmc via
env_load().
To fix this issue, move blkcache_init boot call earlier, before mmc gets
initialized.
Cc: Angelo Durgehello
Reviewed-by: Simon Glass
Signed-off-by: Ovidiu Panait
---
v2
Factor out m68k-specific bdinfo setup to arch_setup_bdinfo in
arch/m68k/lib/bdinfo.c. Also, use if(IS_ENABLED()) instead of #ifdef where
possible.
Signed-off-by: Ovidiu Panait
---
v2 updates:
- use "if (IS_ENABLED(CONFIG_SYS_HAS_SRAM))" instead of
"#ifdef CONFIG_SYS_SRAM_BASE&q
This converts ad-hoc CONFIG_SYS_SRAM_SIZE to Kconfig.
Signed-off-by: Ovidiu Panait
---
Kconfig | 7 +++
include/configs/devkit8000.h | 1 -
include/configs/pic32mzdask.h | 2 --
include/configs/tricorder.h | 1 -
scripts/config_whitelist.txt | 1 -
5 files changed
Remove ad-hoc CONFIG_SYS_SRAM_START and use CONFIG_SYS_SRAM_BASE instead.
Signed-off-by: Ovidiu Panait
---
Kconfig | 2 ++
include/configs/devkit8000.h | 3 ---
include/configs/tricorder.h | 3 ---
scripts/config_whitelist.txt | 1 -
4 files changed, 2 insertions(+), 7
Factor out mips-specific bdinfo setup from generic init sequence to
arch_setup_bdinfo in arch/mips/lib/boot.c. Also, use if(IS_ENABLED())
instead of #ifdef where possible.
Signed-off-by: Ovidiu Panait
---
v2 updates:
- use "if (IS_ENABLED(CONFIG_SYS_HAS_SRAM))" instead of
nit,
introduce arch_setup_bdinfo weak initcall so that everyone can define their
own bdinfo setup routines.
Reviewed-by: Simon Glass
Signed-off-by: Ovidiu Panait
---
v2 updates:
- add reviewed-by tag
common/board_f.c | 6 ++
include/init.h | 12
2 files changed, 18 inserti
Use IS_ENABLED() instead of #ifdef in blk_post_probe function.
No functional change intended.
Reviewed-by: Simon Glass
Signed-off-by: Ovidiu Panait
---
v2 updates:
- add reviewed-by tag
drivers/block/blk-uclass.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git
In order to be able to replace "#ifdef CONFIG_SYS_SRAM_BASE" sequences
with the IS_ENABLED() equivalent, introduce a new boolean Kconfig option
that signals whether the platform has SRAM support.
Signed-off-by: Ovidiu Panait
---
Kconfig | 11 +++
1 file changed, 11 insertion
This converts ad-hoc CONFIG_SYS_SRAM_BASE to Kconfig.
Signed-off-by: Ovidiu Panait
---
Kconfig | 5 +
include/configs/pic32mzdask.h | 1 -
scripts/config_whitelist.txt | 1 -
3 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/Kconfig b/Kconfig
index
Hi Simon,
On 15.07.2020 04:05, Simon Glass wrote:
On Fri, 10 Jul 2020 at 04:25, Ovidiu Panait wrote:
Factor out m68k-specific bdinfo setup to arch_setup_bdinfo in
arch/m68k/lib/bdinfo.c. Also, use if(IS_ENABLED()) instead of #ifdef where
possible.
Signed-off-by: Ovidiu Panait
---
v2 updates
Hi,
On 27.05.2020 15:05, Matthias Brugger wrote:
On 27/05/2020 08:41, Ovidiu Panait wrote:
According to the description of devfdt_get_addr_ptr, this function should
return NULL on failure, but currently it returns (void *)FDT_ADDR_T_NONE.
This is also a problem because there are two
unction for pinconfig %s (%d)\n",
config->name, function);
return -EINVAL;
}
Make "function" variable an int to fix this.
Signed-off-by: Ovidiu Panait
---
drivers/pinctrl/broadcom/pinctrl-bcm283x.c | 2 +-
1 file changed, 1 insertion(+), 1 d
Remove CONFIG_IS_ENABLED(OF_CONTROL) check from DM_FLAG_PRE_RELOC, since
this driver only supports OF_CONTROL.
drivers/pinctrl/broadcom/Kconfig:
config PINCTRL_BCM283X
depends on ARCH_BCM283X && PINCTRL_FULL && OF_CONTROL
Signed-off-by: Ovidiu Panait
---
drivers/pinctrl/
atdata).
Signed-off-by: Ovidiu Panait
---
drivers/pinctrl/broadcom/pinctrl-bcm283x.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/pinctrl/broadcom/pinctrl-bcm283x.c
b/drivers/pinctrl/broadcom/pinctrl-bcm283x.c
index 8bf7916627..9ab0baee33
wed-by: Simon Glass
Reviewed-by: Eric Nelson
Signed-off-by: Ovidiu Panait
---
common/board_r.c | 2 +-
drivers/block/blkcache.c | 13 +++--
2 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/common/board_r.c b/common/board_r.c
index 79772135a4..63c53b7b96 100
in order to silence the following checkpatch
warning:
check: extern prototypes should be avoided in .h files
Reviewed-by: Simon Glass
Signed-off-by: Ovidiu Panait
---
drivers/serial/serial-uclass.c | 4 ++--
drivers/serial/serial.c| 4 +++-
include/serial.h | 2 +-
3 files
This converts ad-hoc CONFIG_SYS_SRAM_SIZE to Kconfig.
Reviewed-by: Simon Glass
Signed-off-by: Ovidiu Panait
---
Kconfig | 7 +++
include/configs/devkit8000.h | 1 -
include/configs/pic32mzdask.h | 2 --
include/configs/tricorder.h | 1 -
scripts
Remove the initr_serial->serial_initialize indirection and call
serial_initialize directly.
Reviewed-by: Simon Glass
Signed-off-by: Ovidiu Panait
---
common/board_r.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/common/board_r.c b/common/board_r.c
in
Factor out m68k-specific bdinfo setup to arch_setup_bdinfo in
arch/m68k/lib/bdinfo.c. Also, use if(IS_ENABLED()) instead of #ifdef where
possible.
Reviewed-by: Simon Glass
Signed-off-by: Ovidiu Panait
---
arch/m68k/lib/bdinfo.c | 21 +
common/board_f.c | 19
nit,
introduce arch_setup_bdinfo weak initcall so that everyone can define their
own bdinfo setup routines.
Reviewed-by: Simon Glass
Signed-off-by: Ovidiu Panait
---
common/board_f.c | 7 ++-
include/init.h | 12
2 files changed, 18 insertions(+), 1 deletion(-)
diff --
Introduce setup_bdinfo initcall as a generic routine to populate bdinfo
fields.
Reviewed-by: Simon Glass
Signed-off-by: Ovidiu Panait
---
common/board_f.c | 6 ++
include/init.h | 10 ++
2 files changed, 16 insertions(+)
diff --git a/common/board_f.c b/common/board_f.c
index
bi_sramstart and bi_sramsize are generic members of the bd_info structure,
so move the m68k/powerpc-specific prints to generic code. Also, print them
only if SRAM support is enabled via CONFIG_SYS_HAS_SRAM.
Reviewed-by: Simon Glass
Signed-off-by: Ovidiu Panait
---
arch/m68k/lib/bdinfo.c
Now that all arch specific code was converted to setup_bdinfo, we can
remove setup_board_part1.
Reviewed-by: Simon Glass
Signed-off-by: Ovidiu Panait
---
common/board_f.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/common/board_f.c b/common/board_f.c
index
Factor out ppc-specific bdinfo setup from generic init sequence to
arch_setup_bdinfo in arch/powerpc/lib/bdinfo.c.
Reviewed-by: Simon Glass
Signed-off-by: Ovidiu Panait
---
arch/powerpc/lib/bdinfo.c | 25 +
common/board_f.c | 36
Move sram related bdinfo from arch-specific setup_board_part1 to generic
code in setup_bdinfo. Also use "if (IS_ENABLED(CONFIG_SYS_HAS_SRAM))"
instead of "#ifdef CONFIG_SYS_SRAM_BASE".
Reviewed-by: Simon Glass
Signed-off-by: Ovidiu Panait
---
common/board_f.c | 10 +-
Remove ad-hoc CONFIG_SYS_SRAM_START and use CONFIG_SYS_SRAM_BASE instead.
Reviewed-by: Simon Glass
Signed-off-by: Ovidiu Panait
---
Kconfig | 2 ++
include/configs/devkit8000.h | 3 ---
include/configs/tricorder.h | 3 ---
scripts/config_whitelist.txt | 1 -
4 files
the generic flags.
For ARC architecture, remove ARCH_EARLY_INIT_R from Kconfig since it is
not needed anymore.
Also, use gd->ram_base to populate bi_memstart to avoid an ifdef.
Signed-off-by: Ovidiu Panait
---
arch/Kconfig | 1 -
arch/arc/lib/cpu.c| 7 ---
This converts ad-hoc CONFIG_SYS_SRAM_BASE to Kconfig.
Reviewed-by: Simon Glass
Signed-off-by: Ovidiu Panait
---
Kconfig | 5 +
include/configs/pic32mzdask.h | 1 -
scripts/config_whitelist.txt | 1 -
3 files changed, 5 insertions(+), 2 deletions(-)
diff --git
In order to be able to replace "#ifdef CONFIG_SYS_SRAM_BASE" sequences
with the IS_ENABLED() equivalent, introduce a new boolean Kconfig option
that signals whether the platform has SRAM support.
Reviewed-by: Simon Glass
Signed-off-by: Ovidiu Panait
---
Kconfig | 11 +
Signed-off-by: Ovidiu Panait
---
common/board_r.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/common/board_r.c b/common/board_r.c
index 63c53b7b96..1c307383d5 100644
--- a/common/board_r.c
+++ b/common/board_r.c
@@ -705,6 +705,9 @@ static init_fnc_t init_sequence_r
Use IS_ENABLED() instead of #ifdef in blk_post_probe function.
No functional change intended.
Reviewed-by: Simon Glass
Signed-off-by: Ovidiu Panait
---
drivers/block/blk-uclass.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/block/blk-uclass.c b/drivers
On 21.07.2020 10:05, Alexey Brodkin wrote:
Hi Ovidiu,
[snip]
diff --git a/arch/arc/lib/cpu.c b/arch/arc/lib/cpu.c
index 27b5832a0c..ccb7e1b265 100644
--- a/arch/arc/lib/cpu.c
+++ b/arch/arc/lib/cpu.c
@@ -27,8 +27,6 @@ int arch_cpu_init(void)
int arch_early_init_r(void)
{
-
Hi Simon,
On 28.07.2020 21:58, Simon Glass wrote:
Hi Ovidiu,
On Tue, 21 Jul 2020 at 10:43, Ovidiu Panait wrote:
Hi Simon,
On 21.07.2020 17:17, Simon Glass wrote:
On Mon, 20 Jul 2020 at 08:20, Ovidiu Panait wrote:
Factor out ppc-specific bdinfo setup from generic init sequence
Signed-off-by: Ovidiu Panait
---
common/board_r.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/common/board_r.c b/common/board_r.c
index 63c53b7b96..1c307383d5 100644
--- a/common/board_r.c
+++ b/common/board_r.c
@@ -705,6 +705,9 @@ static init_fnc_t init_sequence_r
Factor out ppc-specific bdinfo setup from generic init sequence to
arch_setup_bdinfo in arch/powerpc/lib/bdinfo.c.
Signed-off-by: Ovidiu Panait
---
arch/powerpc/lib/bdinfo.c | 25 +
common/board_f.c | 36 ++--
2 files changed, 27
Remove the initr_serial->serial_initialize indirection and call
serial_initialize directly.
Reviewed-by: Simon Glass
Signed-off-by: Ovidiu Panait
---
common/board_r.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/common/board_r.c b/common/board_r.c
in
1 - 100 of 347 matches
Mail list logo
