Re: [PATCH 1/2] global: Clean up arch/*/dts/Makefile

2023-11-19 Thread Rasmus Villemoes
On 19/11/2023 20.09, Simon Glass wrote: > On Fri, 17 Nov 2023 at 15:52, Tom Rini wrote: >> >> With commit 3609e1dc ("dts: automatically build necessary .dtb files") >> we now have logic that will ensure that all device trees needed in the >> binary are built automatically. Any device tree that

[PATCH v2 6/6] led: add TI LP5562 LED driver

2023-11-17 Thread Rasmus Villemoes
. As our boards only have the R,G,B outputs connected, I have not actually tested how the white channel behaves, but the R,G,B work exactly as expected. [1] https://lore.kernel.org/u-boot/1547150757-1561-1-git-send-email-douglas.zo...@climate.com/ Cc: Doug Zobel Signed-off-by: Rasmus Villemoes

[PATCH v2 3/6] led: introduce led_bind_generic()

2023-11-17 Thread Rasmus Villemoes
All existing drivers in drivers/led/ contain a .bind method that does exactly the same thing, with just the actual driver name differing. Create a helper so all those individual methods can be changed to one-liners. Reviewed-by: Marek Vasut Signed-off-by: Rasmus Villemoes --- drivers/led/led

[PATCH v2 1/6] led-uclass: honour ->label field populated by driver's own .bind

2023-11-17 Thread Rasmus Villemoes
If the driver's own .bind method has populated uc_plat->label, don't override that. This is necessary for an upcoming driver for ti,lp5562, where the DT binding unfortunately says to use "chan-name" and not "label". Reviewed-by: Christian Gmeiner Reviewed-by: Marek Vasut

[PATCH v2 2/6] led-uclass: do not create fallback label for top-level node

2023-11-17 Thread Rasmus Villemoes
to the LED driver explicitly via device_bind_driver_to_node(). This is similar to what e3aa76644c2a did for gpio_led, but that fix was then supplanted by 01074697801b. Fixes: 83c63f0d1185 ("led: Move OF "label" property parsing to core") Signed-off-by: Rasmus Villemoes --- drivers/led/l

[PATCH v2 4/6] led: led_gpio: use led_bind_generic() helper

2023-11-17 Thread Rasmus Villemoes
Use the helper led_bind_generic() to reduce code duplication. Signed-off-by: Rasmus Villemoes --- drivers/led/led_gpio.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/led/led_gpio.c b/drivers/led/led_gpio.c index fbed151b5d9..71421de628c 100644

[PATCH v2 0/6] some LED patches

2023-11-17 Thread Rasmus Villemoes
oug Zobel (1): led: add TI LP5562 LED driver Rasmus Villemoes (5): led-uclass: honour ->label field populated by driver's own .bind led-uclass: do not create fallback label for top-level node led: introduce led_bind_generic() led: led_gpio: use led_bind_generic() helper led: led_pw

[PATCH v2 5/6] led: led_pwm: use led_bind_generic() helper

2023-11-17 Thread Rasmus Villemoes
Use the helper led_bind_generic() to reduce code duplication. Signed-off-by: Rasmus Villemoes --- drivers/led/led_pwm.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/led/led_pwm.c b/drivers/led/led_pwm.c index 7c8eae9337b..ae6de3087ab 100644

[PATCH] gpio: pca953x_gpio: support optional reset-gpios property

2024-04-10 Thread Rasmus Villemoes
The DT bindings for the pca953x family has an optional reset-gpios property. If present, ensure that the device is taken out of reset before attempting to read from it. Signed-off-by: Rasmus Villemoes --- drivers/gpio/pca953x_gpio.c | 8 1 file changed, 8 insertions(+) diff --git

Re: [PATCH] gpio: pca953x_gpio: support optional reset-gpios property

2024-04-10 Thread Rasmus Villemoes
On 10/04/2024 14.24, Quentin Schulz wrote: > Hi Rasmus, > >> @@ -321,6 +322,13 @@ static int pca953x_probe(struct udevice *dev) >>     driver_data = dev_get_driver_data(dev); >>   +    /* If a reset-gpios property is present, take the device out of >> reset. */ >> +    ret =

<    4   5   6   7   8   9