Re: TPM SPI issue

2023-11-30 Thread Sean Anderson
Hi Niek, On 11/29/23 18:58, niek.nooij...@omron.com wrote: Hi Fabio I'm using the socfpga_cyclone5 with the designwire_spi driver. I added the TPM to the devicetree as so: &spi0 {   status = "okay";   num-cs = <2>;   mram0@0 { compatible = "spi-dev"; reg = <0

[PATCH] doc: Replace examples of MD5 and SHA1 with SHA256

2023-12-02 Thread Sean Anderson
for non-verified-boot scenarios (since someone could just replace the checksum), but I wanted to be complete. Signed-off-by: Sean Anderson --- doc/chromium/files/chromebook_jerry.its | 4 +- doc/chromium/files/nyan-big.its | 4 +- doc/usage/cmd/imxtract.rst | 6 +- doc

Re: [PATCH] doc: Replace examples of MD5 and SHA1 with SHA256

2023-12-02 Thread Sean Anderson
On 12/2/23 14:33, Sean Anderson wrote: Both SHA1 and (especially) MD5 are no longer as safe as they once were for cryptographic use. Replaces examples which use them with examples using SHA256 instead. This will provide more-secure defaults for users who use documentation examples as a base for

Re: [PATCH 118/149] board: sipeed: Remove and add needed includes

2024-04-30 Thread Sean Anderson
On 4/30/24 22:42, Tom Rini wrote: Remove from this board vendor directory and when needed add missing include files directly. Signed-off-by: Tom Rini --- Cc: Sean Anderson --- board/sipeed/maix/maix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/sipeed/maix

Re: [RFC PATCH v1 1/1] mmc: snps_sdhci: Add sdhci driver support for TH1520 SoC

2024-04-02 Thread Sean Anderson
On 3/30/24 13:59, Maksim Kiselev wrote: > Add support for DesignWare SDHCI host controller on Alibaba TH1520 SoC > > Signed-off-by: Maksim Kiselev > --- > drivers/mmc/Kconfig | 12 + > drivers/mmc/Makefile | 1 + > drivers/mmc/snps_sdhci.c | 464 +++

Re: [PATCH 1/2] dm: core: add support for fallback drivers

2024-04-10 Thread Sean Anderson
On 4/10/24 15:44, Tom Rini wrote: On Wed, Apr 10, 2024 at 07:27:17PM +0200, Heinrich Schuchardt wrote: Am 10. April 2024 19:06:57 MESZ schrieb Caleb Connolly : Introduce support for a uclass to provide a fallback/stub driver which can be used when no device is found for a given node. This mi

Re: [PATCH 1/1] sandbox: don't call os_close with invalid file descriptor

2024-04-10 Thread Sean Anderson
, OS_O_RDONLY); if (fd < 0) { printf("Cannot open file '%s'\n", fname); - goto err; + return -EIO; } size = os_filesize(fd); if (size < 0) { Fixes: 566bf3a8698 ("sandbox: Add a function to read

Re: [PATCH 1/1] sandbox: use sane access rights for files

2024-04-10 Thread Sean Anderson
size) < 0) return -EIO; close(fd); - if (chmod(fname, 0777)) + if (chmod(fname, 0755)) return -ENOEXEC; return 0; Reviewed-by: Sean Anderson

Re: [PATCH] clk: Propagate clk_set_rate() if CLK_SET_PARENT_RATE present

2024-04-10 Thread Sean Anderson
On 3/7/24 19:04, Sam Protsenko wrote: Sometimes clocks provided to a consumer might not have .set_rate operation (like gate or mux clocks), but have CLK_SET_PARENT_RATE flag set. In that case it's usually possible to find a parent up the tree which is capable of setting the rate (div, pll, etc).

Re: [PATCH v3] clk: set initial best mux parent to current parent with CLK_MUX_ROUND_CLOSEST

2024-04-10 Thread Sean Anderson
On 3/12/24 04:52, Yang Xiwen wrote: On 3/11/2024 5:34 PM, Maxime Ripard wrote: On Thu, Mar 07, 2024 at 07:18:05PM +0800, Yang Xiwen wrote: On 3/7/2024 4:48 PM, Maxime Ripard wrote: Hi, On Thu, Mar 07, 2024 at 10:03:50AM +0800, Yang Xiwen via B4 Relay wrote: From: Yang Xiwen Originally, the

Re: [PATCH] clk: Fix error message in clk_get_bulk

2024-04-10 Thread Sean Anderson
release all clocks for %p\n", + debug("%s: could not release all clocks for %p\n", __func__, dev); return ret; Reviewed-by: Sean Anderson

Re: [PATCH 1/1] clk: sifive: append missing \n to messages

2024-04-10 Thread Sean Anderson
u64 n; if (c->flags & WRPLL_FLAGS_EXT_FEEDBACK_MASK) { - WARN(1, "external feedback mode not yet supported"); + WARN(1, "external feedback mode not yet supported\n"); return ULONG_MAX; } Reviewed-by: Sean Anderson But maybe these should be dev_dbg?

Re: [PATCH] clk: sifive: check wrpll_configure_for_rate() return value

2024-04-10 Thread Sean Anderson
_clock *pc, memcpy(&c, &pwd->c, sizeof(c)); - wrpll_configure_for_rate(&c, rate, *parent_rate); + r = wrpll_configure_for_rate(&c, rate, *parent_rate); + if (r) + return r; return wrpll_calc_output_rate(&c, *parent_rate); } Reviewed-by: Sean Anderson

Re: [PATCH 1/1] clk: sifive: avoid declaring static variables in includes

2024-04-10 Thread Sean Anderson
On 2/16/24 18:18, Heinrich Schuchardt wrote: The existing code is unnecessarily convoluted: Arrays __prci_init_clocks_fu[5|7]40 are initialized with data. In separate includes fu[5|7]40-prci.h the size of the arrays is provided as constants. By moving the structures prci_clk_fu[5|7]40 to the r

Re: [PATCH] clk: imx8mp: add pwm clocks support

2024-04-10 Thread Sean Anderson
uot;, base + 0x4190, 0)); clk_dm(IMX8MP_CLK_I2C4_ROOT, imx_clk_gate4("i2c4_root_clk", "i2c4", base + 0x41a0, 0)); + clk_dm(IMX8MP_CLK_PWM1_ROOT, imx_clk_gate4("pwm1_root_clk", "pwm1", base + 0x4280, 0)); + clk_dm(IMX8MP_CLK_PWM2_ROOT, imx_clk_gate4("pwm2_root_clk", "pwm2", base + 0x4290, 0)); + clk_dm(IMX8MP_CLK_PWM3_ROOT, imx_clk_gate4("pwm3_root_clk", "pwm3", base + 0x42a0, 0)); + clk_dm(IMX8MP_CLK_PWM4_ROOT, imx_clk_gate4("pwm4_root_clk", "pwm4", base + 0x42b0, 0)); clk_dm(IMX8MP_CLK_QSPI_ROOT, imx_clk_gate4("qspi_root_clk", "qspi", base + 0x42f0, 0)); clk_dm(IMX8MP_CLK_I2C5_ROOT, imx_clk_gate2("i2c5_root_clk", "i2c5", base + 0x4330, 0)); clk_dm(IMX8MP_CLK_I2C6_ROOT, imx_clk_gate2("i2c6_root_clk", "i2c6", base + 0x4340, 0)); Acked-by: Sean Anderson But I would like to see a RB from one of the i.MX maintainers (CC'd).

Re: [PATCH] clk: imx8mp: add pwm clocks support

2024-04-10 Thread Sean Anderson
On 4/10/24 23:18, Sean Anderson wrote: On 3/10/23 10:15, Tommaso Merciai wrote: Add clocks support for the PWM controllers. This is ported from Linux v6.3.0-rc1 Signed-off-by: Tommaso Merciai ---   drivers/clk/imx/clk-imx8mp.c | 24   1 file changed, 24 insertions

Re: [PATCH 1/1] clk: sifive: append missing \n to messages

2024-04-11 Thread Sean Anderson
On 4/11/24 04:37, Heinrich Schuchardt wrote: On 11.04.24 05:13, Sean Anderson wrote: On 2/16/24 11:35, Heinrich Schuchardt wrote: If multiple messages are written, line-feeds improve the readability. Fixes: c40b6df87fc0 ("clk: Add SiFive FU540 PRCI clock driver") Signed-off-by

Re: [PATCH] mmc: sdhci: programmable clock calculation needs multiplier +1

2024-04-15 Thread Sean Anderson
therwise the actual clock > +* multiplier is one more than the value of Clock Multiplier > +* in the Capabilities Register. > +*/ > + if (host->clk_mul) > + host->clk_mul += 1; > } > > if (host->max_clk == 0) { > -- > 2.43.2 > Reviewed-by: Sean Anderson

[PATCH 0/3] patman: A fix and some new tags

2024-04-18 Thread Sean Anderson
This series has a fix along with a couple of convenient tags. Sean Anderson (3): patman: Fix tests if add_maintainers is set to False patman: Add Commit-cc as an alias for Patch-cc patman: Add a tag for when a patch gets added to a series tools/patman/func_test.py

[PATCH 1/3] patman: Fix tests if add_maintainers is set to False

2024-04-18 Thread Sean Anderson
intainer-script' argument") Signed-off-by: Sean Anderson --- tools/patman/func_test.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/patman/func_test.py b/tools/patman/func_test.py index e3918497cf4..9c016fb5e9a 100644 --- a/tools/patman/func_test.py +++ b/

[PATCH 2/3] patman: Add Commit-cc as an alias for Patch-cc

2024-04-18 Thread Sean Anderson
Most tags referring to commits (or patches) are named Commit-something. The exception is Patch-cc. Add a Commit-cc alias so we can use whichever one is convenient. Signed-off-by: Sean Anderson --- tools/patman/func_test.py| 5 - tools/patman

[PATCH 3/3] patman: Add a tag for when a patch gets added to a series

2024-04-18 Thread Sean Anderson
y just noise in most series, but they may be useful for treewide series to distinguish 'gpio: frobnicate' from 'reset: frobnicate', so I've left them in. Suggestions for the above appreciated. Suggested-by: Douglas Anderson Signed-off-by: Sean Anderson --- tools/pa

Re: [PATCH v2 02/23] clk: rockchip: rk3588: Add REF_CLK_USB3OTGx support

2024-04-18 Thread Sean Anderson
B3OTG1: + case REF_CLK_USB3OTG2: case TMCLK_EMMC: case TCLK_WDT0: ret = OSC_HZ; Acked-by: Sean Anderson

Re: [PATCH v2 01/23] clk: rockchip: rk356x: Add CLK_USB3OTGx_REF support

2024-04-18 Thread Sean Anderson
-by: Sean Anderson

[PATCH] lib: sparse: Fix error checking for write_sparse_chunk_raw

2024-02-01 Thread Sean Anderson
nk: https://lore.kernel.org/u-boot/1b323ec3-59b0-490b-a2f0-fd961dafcf49@moroto.mountain/ Signed-off-by: Sean Anderson --- lib/image-sparse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/image-sparse.c b/lib/image-sparse.c index f8289064692..09225692e9b 100644 --- a

Re: [PATCH v3 2/3] board: Add support for Conclusive WHLE-LS1046A

2024-02-06 Thread Sean Anderson
On 11/28/23 05:34, Artur Rojek wrote: > Introduce support for Conclusive WHLE-LS1046A Single Board Computer. > > Co-developed-by: Jakub Klama > Signed-off-by: Jakub Klama > Signed-off-by: Artur Rojek > --- > > v3: no change > > v2: - drop non-DM_ETH case > - clean-up defines in configs/wh

Re: [PATCH v3 3/3] board: Add support for Conclusive WHLE-LS1088A

2024-02-06 Thread Sean Anderson
On 11/28/23 05:34, Artur Rojek wrote: > Introduce support for Conclusive WHLE-LS1088A Single Board Computer. > > Co-developed-by: Jakub Klama > Signed-off-by: Jakub Klama > Signed-off-by: Artur Rojek > --- > > v3: new patch > > arch/arm/Kconfig | 19 ++ > arch/a

Re: [PATCH v4] misc: fs-loader: Use fw_storage_interface instead of storage_interface

2024-02-07 Thread Sean Anderson
On 1/30/24 01:26, MD Danish Anwar wrote: The fs-loader driver reads env storage_interface and uses it to load firmware file into memory using the medium set by env. Update the driver to use env fw_storage_interface as this variable is only used to load firmwares. The env storage_interface will ac

[PATCH] boot: Only define checksum algos when the hashes are enabled

2024-02-15 Thread Sean Anderson
Don't define checksum algos when the underlying hashes are not enabled. This allows disabling these hashes in SPL (or U-Boot). Fixes: d16b38f4270 ("Add support for SHA384 and SHA512") Fixes: 646257d1f40 ("rsa: add sha256-rsa2048 algorithm") Signed-off-by: Sean Anderson -

[PATCH] arm64: zynqmp: Support semhosting boot method

2024-02-15 Thread Sean Anderson
on't break compatibility with existing debuggers that don't expect us to hit semihosting breakpoints. Signed-off-by: Sean Anderson --- arch/arm/mach-zynqmp/spl.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-zynqmp/spl.c b/arch/arm/mach-zynqmp/spl

Re: [PATCH] arm64: zynqmp: Support semhosting boot method

2024-02-15 Thread Sean Anderson
On 2/15/24 14:08, Michal Simek wrote: > > > On 2/15/24 18:19, Sean Anderson wrote: >> Currently, when we boot from JTAG we try to boot U-Boot from RAM. >> However, this is a bit tricky to time, since the debugger has to wait >> for SPL to initialize RAM before it can l

Re: [PATCH] arm64: zynqmp: Support semhosting boot method

2024-02-15 Thread Sean Anderson
On 2/15/24 14:31, Sean Anderson wrote: > On 2/15/24 14:08, Michal Simek wrote: >> >> >> On 2/15/24 18:19, Sean Anderson wrote: >>> Currently, when we boot from JTAG we try to boot U-Boot from RAM. >>> However, this is a bit tricky to time, since the debugge

Re: [PATCH] arm64: zynqmp: Support semhosting boot method

2024-02-16 Thread Sean Anderson
On 2/16/24 10:06, Michal Simek wrote: > > > On 2/16/24 14:48, Michal Simek wrote: >> >> >> On 2/15/24 20:31, Sean Anderson wrote: >>> On 2/15/24 14:08, Michal Simek wrote: >>>> >>>> >>>> On 2/15/24 18:19, Sean Anderson wrote

Re: [PATCH] arm64: zynqmp: Support semhosting boot method

2024-02-16 Thread Sean Anderson
On 2/16/24 11:03, Sean Anderson wrote: > On 2/16/24 10:06, Michal Simek wrote: >> >> >> On 2/16/24 14:48, Michal Simek wrote: >>> >>> >>> On 2/15/24 20:31, Sean Anderson wrote: >>>> On 2/15/24 14:08, Michal Simek wrote: >>>&

Re: HABv4 with SPL and u-boot-dtb.img on i.MX6

2024-02-20 Thread Sean Anderson
On 2/20/24 04:50, Benjamin Lemouzy wrote: > Hello, > > I'm trying to make secure boot work on i.MX6 SABRE with SPL and > u-boot-dtb.img files and I'm not sure how to do it. > > I'm using the U-Boot vanilla master branch (2024.04-rc2) with the following > configuration: > > # Remove some stuff

Re: [PATCH] arm64: zynqmp: Support semhosting boot method

2024-02-20 Thread Sean Anderson
On 2/20/24 13:24, Michal Simek wrote: > > > On 2/16/24 17:09, Sean Anderson wrote: >> On 2/16/24 11:03, Sean Anderson wrote: >>> On 2/16/24 10:06, Michal Simek wrote: >>>> >>>> >>>> On 2/16/24 14:48, Michal Simek wrote: >>>>&

Re: [PATCH] arm64: zynqmp: Support semhosting boot method

2024-02-20 Thread Sean Anderson
On 2/20/24 14:18, Michal Simek wrote: > > > On 2/20/24 19:43, Sean Anderson wrote: >> On 2/20/24 13:24, Michal Simek wrote: >>> >>> >>> On 2/16/24 17:09, Sean Anderson wrote: >>>> On 2/16/24 11:03, Sean Anderson wrote: >>>>> On

Re: [PATCH] ecdsa: Avoid null pointer crash in ecdsa-verify due to absent property

2024-02-21 Thread Sean Anderson
Hi Bob, On 2/21/24 19:27, Bob Wolff wrote: If mixed rsa and ecdsa keys are specified in dtsi, an rsa key can be sent into the ecdsa verify. Without the ecdsa,curve property, this function will crash due to lack of checking the null pointer return. You can wrap commit messages at 75 characters

[PATCH v2] arm64: zynqmp: Support semihosting boot method

2024-02-22 Thread Sean Anderson
From: Sean Anderson Currently, when we boot from JTAG we try to boot U-Boot from RAM. However, this is a bit tricky to time, since the debugger has to wait for SPL to initialize RAM before it can load U-Boot. This can result in long waits, since occasionally initializing RAM (and other things in

Re: [PATCH] arm64: zynqmp: Support semhosting boot method

2024-02-22 Thread Sean Anderson
On 2/22/24 05:34, Michal Simek wrote: > > > On 2/20/24 20:30, Sean Anderson wrote: >> On 2/20/24 14:18, Michal Simek wrote: >>> >>> >>> On 2/20/24 19:43, Sean Anderson wrote: >>>> On 2/20/24 13:24, Michal Simek wrote: >>>>> >&

Re: [PATCH v2] arm64: zynqmp: Support semihosting boot method

2024-02-22 Thread Sean Anderson
On 2/22/24 14:36, Fabio Estevam wrote: > On Thu, Feb 22, 2024 at 1:53 PM Sean Anderson wrote: >> >> From: Sean Anderson > ... >> Signed-off-by: Sean Anderson >> --- >> I'm resending this from my linux.dev email as my regular email is >> mangling m

[RESEND PATCH v2] arm64: zynqmp: Support semihosting boot method

2024-02-22 Thread Sean Anderson
on't break compatibility with existing debuggers that don't expect us to hit semihosting breakpoints. Signed-off-by: Sean Anderson --- I'm resending this from my linux.dev email as my regular email is mangling my patches. Changes in v2: - Fix typo in subject arch/arm/mach-zynqmp/spl.

Re: [PATCH] Check curve_name for null to avoid crash

2024-02-22 Thread Sean Anderson
ey. Likely not an ecdsa key.\n"); + return -ENOMSG; + } + key->size_bits = ecdsa_key_size(key->curve_name); if (key->size_bits == 0) { debug("Unknown ECDSA curve '%s'", key->curve_name); Reviewed-by: Sean Anderson

Re: [PATCH] clk: Revise help text for clk_get_parent_rate()

2024-02-23 Thread Sean Anderson
parent of current clock rate. + * clk_get_parent_rate() - Get rate of current clock's parent. * @clk: A clock struct that was previously successfully requested by *clk_request/get_by_*(). * base-commit: 7bb761c42d75b2ebacc7190a76cc5385cbba1045 Reviewed-by: Sean Anderson

Re: [PATCH v5] misc: fs-loader: Use fw_storage_interface instead of storage_interface

2024-02-27 Thread Sean Anderson
Hi Danish, On 2/27/24 05:26, MD Danish Anwar wrote: On 09/02/24 3:38 pm, MD Danish Anwar wrote: The fs-loader driver reads env storage_interface and uses it to load firmware file into memory using the medium set by env. Update the driver to use env fw_storage_interface as this variable is only

Re: patman regression?

2020-12-22 Thread Sean Anderson
On 12/11/20 11:29 AM, Simon Glass wrote: Hi Bin, On Thu, 10 Dec 2020 at 21:37, Bin Meng wrote: On Fri, Dec 11, 2020 at 12:32 PM Sean Anderson wrote: On 12/10/20 11:27 PM, Bin Meng wrote: On Fri, Dec 11, 2020 at 12:08 PM Bin Meng wrote: Hi Simon, The following command no longer works

[PATCH v1] riscv: Add support for SPI on Kendryte K210

2020-12-22 Thread Sean Anderson
a minimal/least effort bootcmd, so suggestions (especially in the form of patches) are welcome. I didn't set up distro boot because I think it is unlikely that any general-purpose linux distros will ever be ported to this board. Signed-off-by: Sean Anderson --- Sorry for the late follow-up

[PATCH v2] riscv: Add support for SPI on Kendryte K210

2020-12-22 Thread Sean Anderson
a minimal/least effort bootcmd, so suggestions (especially in the form of patches) are welcome. I didn't set up distro boot because I think it is unlikely that any general-purpose linux distros will ever be ported to this board. Signed-off-by: Sean Anderson --- Sorry for the late follow-up

[PATCH v5 1/6] wdt: dw: Switch to using fls for log2

2020-12-22 Thread Sean Anderson
log_2_n_round_up is only found in arm. fls performs the same job and is generic. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v2) Changes in v2: - Fix fls being off-by-one when compared to log_2_n_round_up drivers/watchdog/designware_wdt.c | 3 +-- 1 file

[PATCH v5 2/6] wdt: dw: Switch to if(CONFIG()) instead of using #if

2020-12-22 Thread Sean Anderson
This is preferred over #if because the compiler can check syntax even if the feature is disabled. This cannot be used for CONFIG_CLK because CONFIG_DW_WDT_CLOCK_KHZ is not defined on all platforms. Signed-off-by: Sean Anderson Reviewed-by: Heinrich Schuchardt --- (no changes since v1

[PATCH v5 3/6] wdt: dw: Enable the clock before using it

2020-12-22 Thread Sean Anderson
The watchdog won't work if the clock isn't enabled. Fixes: cf89ef8d10f240554541c20b2e1bdcdd58d1d7e6 Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v1) drivers/watchdog/designware_wdt.c | 4 1 file changed, 4 insertions(+) diff --git a/driver

[PATCH v5 4/6] wdt: dw: Free the clock on error

2020-12-22 Thread Sean Anderson
The clock subsystem requires that clk_free be called on clocks obtained via clk_get_*. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v4) Changes in v4: - Fix build error without CONFIG_CLK drivers/watchdog/designware_wdt.c | 18 +- 1 file

[PATCH v5 0/6] wdt: Add support for watchdogs on Kendryte K210

2020-12-22 Thread Sean Anderson
which were sent for version 1 Changes in v2: - Fix fls being off-by-one when compared to log_2_n_round_up - Move watchdog enable to k210.dtsi as it does not depend on anything board-specific. Sean Anderson (6): wdt: dw: Switch to using fls for log2 wdt: dw: Switch to if(CONFIG()) instead of

[PATCH v5 5/6] riscv: Add watchdog bindings for the k210

2020-12-22 Thread Sean Anderson
This adds the necessary bindings. Most of them are already there. Signed-off-by: Sean Anderson Acked-by: Rick Chen --- (no changes since v2) Changes in v2: - Move watchdog enable to k210.dtsi as it does not depend on anything board-specific. arch/riscv/dts/k210.dtsi | 1 - 1 file changed

[PATCH v5 6/6] riscv: Enable watchdog for the k210

2020-12-22 Thread Sean Anderson
This enables the necessary config options. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v1) board/sipeed/maix/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/board/sipeed/maix/Kconfig b/board/sipeed/maix/Kconfig index 4c42dd2087..95fe6d9706 100644

Re: patman regression?

2020-12-22 Thread Sean Anderson
On 12/22/20 7:06 PM, Simon Glass wrote: Hi Sean, On Tue, 22 Dec 2020 at 16:51, Sean Anderson wrote: On 12/11/20 11:29 AM, Simon Glass wrote: Hi Bin, On Thu, 10 Dec 2020 at 21:37, Bin Meng wrote: On Fri, Dec 11, 2020 at 12:32 PM Sean Anderson wrote: On 12/10/20 11:27 PM, Bin Meng

Re: [PATCH 2/2] patman: Quieten down the alias checking

2020-12-22 Thread Sean Anderson
On 12/22/20 10:14 PM, Simon Glass wrote: When a tag is used in a patch subject (e.g. "tag: rest of message") and it cannot be found as an alias, patman currently reports a fatal error, unless -t is provided, in which case it reports a warning. Experience suggest that the fatal error is not very

[PATCH] mx6ul(l)evk: Enable DM_ETH_PHY

2020-12-28 Thread Sean Anderson
from ROM , eth0: ethernet@2188000 As an alternative to DM_ETH_PHY, FEC_MXC_SHARE_MDIO could also have been used to achieve the same effect. Signed-off-by: Sean Anderson --- configs/mx6ul_14x14_evk_defconfig | 1 + configs/mx6ul_9x9_evk_defconfig | 1 + configs

Re: [PATCH] common: board_f: fix to display wrong memory information

2020-12-29 Thread Sean Anderson
On 12/29/20 6:24 PM, Jaehoon Chung wrote: When run meminfo command, it's displayed wrong memory information. Because it's using gd->ram_size what didn't configure ram size. what -> which? On 4G RPI4 target - Before U-Boot> meminfo DRAM: 948MiB - After U-Boot> meminfo DRAM: 3.

[PATCH 0/9] This series adds support for flashing eMMC boot partitions, and for

2020-12-31 Thread Sean Anderson
on one board, but I have *not* tested the mt85-specific KConfigs. Hopefully this series can be a way to phase out those options. Sean Anderson (9): mmc: sandbox: Add support for writing test: dm: Add test for fastboot mmc partition naming part: Give several functions more useful return values

[PATCH 1/9] mmc: sandbox: Add support for writing

2020-12-31 Thread Sean Anderson
This adds support writing to the sandbox mmc backed by an in-memory buffer. The unit test has been updated to test reading, writing, and erasing. I'm not sure what MMC erase to; I picked 0, but if it's 0xFF then that can be easily changed. Signed-off-by: Sean Anderson --- d

[PATCH 2/9] test: dm: Add test for fastboot mmc partition naming

2020-12-31 Thread Sean Anderson
This test verifies the mapping between fastboot partitions and partitions as understood by U-Boot. It also tests the creation of GPT partitions, though that is not the primary goal. Signed-off-by: Sean Anderson --- configs/sandbox64_defconfig | 2 ++ configs/sandbox_defconfig | 2 ++ test

[PATCH 4/9] part: Support getting whole disk from part_get_info_by_dev_and_name_or_num

2020-12-31 Thread Sean Anderson
This adds an option to part_get_info_by_dev_and_name_or_num to allow callers to specify whether whole-disk partitions are fine. Signed-off-by: Sean Anderson --- cmd/ab_select.c | 3 ++- disk/part.c | 5 +++-- include/part.h | 6 +- 3 files changed, 10 insertions(+), 4 deletions

[PATCH 3/9] part: Give several functions more useful return values

2020-12-31 Thread Sean Anderson
Several functions in disk/part.c just return -1 on error. This makes them return different errnos for different failures. This helps callers differentiate between failures, even if they cannot read stdout. Signed-off-by: Sean Anderson --- disk/part.c | 50

[PATCH 5/9] part: Support string block devices in part_get_info_by_dev_and_name

2020-12-31 Thread Sean Anderson
This adds support for things like "#partname" and "0.1#partname". The block device parsing is done like in blk_get_device_part_str. Signed-off-by: Sean Anderson --- disk/part.c | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff -

[PATCH 6/9] fastboot: Remove mmcpart argument from raw_part_get_info_by_name

2020-12-31 Thread Sean Anderson
The only thing mmcpart was used for was to pass to blk_dselect_hwpart. This calls blk_dselect_hwpart directly from raw_part_get_info_by_name. The error handling is dropped, but it is reintroduced in the next commit (albeit less specificly). Signed-off-by: Sean Anderson --- drivers/fastboot

[PATCH 7/9] fastboot: Move part_get_info_by_name_or_alias after raw_part_get_info_by_name

2020-12-31 Thread Sean Anderson
This makes the next commit more readable by doing the move now. Signed-off-by: Sean Anderson --- drivers/fastboot/fb_mmc.c | 44 +++ 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/fastboot/fb_mmc.c b/drivers/fastboot/fb_mmc.c index

[PATCH 8/9] fastboot: Allow u-boot-style partitions

2020-12-31 Thread Sean Anderson
allows There should be no conflicts with the existing system, but just in case, I have ordered detection of these names after all existing names. The fastboot_mmc_part test has been updated for these new names. Signed-off-by: Sean Anderson --- drivers/fas

[PATCH 9/9] fastboot: Document alternate partition names

2020-12-31 Thread Sean Anderson
This documents the new partition names added in the previous commit. Signed-off-by: Sean Anderson --- doc/android/fastboot.rst | 28 1 file changed, 28 insertions(+) diff --git a/doc/android/fastboot.rst b/doc/android/fastboot.rst index 2877c3cbaa..2ca80ae844

Re: [PATCH 9/9] fastboot: Document alternate partition names

2020-12-31 Thread Sean Anderson
On 12/31/20 7:36 PM, Heinrich Schuchardt wrote: On 12/31/20 11:48 PM, Sean Anderson wrote: This documents the new partition names added in the previous commit. Signed-off-by: Sean Anderson --- doc/android/fastboot.rst | 28 1 file changed, 28 insertions

Re: [PATCH 8/9] fastboot: Allow u-boot-style partitions

2021-01-04 Thread Sean Anderson
On 12/31/20 5:48 PM, Sean Anderson wrote: > This adds support for partitions of the form "dev.hwpart:part" and > "dev#partname". This allows one to flash to eMMC boot partitions without > having to use CONFIG_FASTBOOT_MMC_BOOT1_SUPPORT. It also allows one to > f

Re: [PATCH v2 2/2] riscv: timer: Add support for an early timer

2021-01-04 Thread Sean Anderson
; sagar.ka...@sifive.com; Rick Jian-Zhi Chen(陳建志); pragnesh.pa...@openfive.com; Pragnesh Patel; Palmer Dabbelt; Sean Anderson; Claudiu Beznea; Simon Glass Subject: [PATCH v2 2/2] riscv: timer: Add support for an early timer Added support for timer_early_get_count() and timer_early_get_rate() This is

Re: [PATCH 4/9] part: Support getting whole disk from part_get_info_by_dev_and_name_or_num

2021-01-07 Thread Sean Anderson
On 1/7/21 7:35 AM, Simon Glass wrote: > On Thu, 31 Dec 2020 at 15:49, Sean Anderson wrote: >> >> This adds an option to part_get_info_by_dev_and_name_or_num to allow >> callers to specify whether whole-disk partitions are fine. >> >> Signed-off-by:

Re: [PATCH 5/9] part: Support string block devices in part_get_info_by_dev_and_name

2021-01-07 Thread Sean Anderson
On 1/7/21 7:35 AM, Simon Glass wrote: On Thu, 31 Dec 2020 at 15:49, Sean Anderson wrote: This adds support for things like "#partname" and "0.1#partname". The block device parsing is done like in blk_get_device_part_str. Signed-off-by: Sean Anderson ---

[PATCH v2 0/9] fastboot: Add better support for specifying partitions

2021-01-07 Thread Sean Anderson
under doc/usage Sean Anderson (9): mmc: sandbox: Add support for writing test: dm: Add test for fastboot mmc partition naming part: Give several functions more useful return values part: Support getting whole disk from part_get_info_by_dev_and_name_or_num part: Support string block

[PATCH v2 1/9] mmc: sandbox: Add support for writing

2021-01-07 Thread Sean Anderson
This adds support writing to the sandbox mmc backed by an in-memory buffer. The unit test has been updated to test reading, writing, and erasing. I'm not sure what MMCs erase to; I picked 0, but if it's 0xFF then that can be easily changed. Signed-off-by: Sean Anderson Reviewed-by: S

[PATCH v2 2/9] test: dm: Add test for fastboot mmc partition naming

2021-01-07 Thread Sean Anderson
This test verifies the mapping between fastboot partitions and partitions as understood by U-Boot. It also tests the creation of GPT partitions, though that is not the primary goal. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v1) configs/sandbox64_defconfig

[PATCH v2 3/9] part: Give several functions more useful return values

2021-01-07 Thread Sean Anderson
Several functions in disk/part.c just return -1 on error. This makes them return different errnos for different failures. This helps callers differentiate between failures, even if they cannot read stdout. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v1) disk

[PATCH v2 4/9] part: Support getting whole disk from part_get_info_by_dev_and_name_or_num

2021-01-07 Thread Sean Anderson
This adds an option to part_get_info_by_dev_and_name_or_num to allow callers to specify whether whole-disk partitions are fine. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v1) cmd/ab_select.c | 3 ++- disk/part.c | 5 +++-- include/part.h | 6 +- 3

[PATCH v2 5/9] part: Support string block devices in part_get_info_by_dev_and_name

2021-01-07 Thread Sean Anderson
This adds support for things like "#partname" and "0.1#partname". The block device parsing is done like in blk_get_device_part_str. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- Changes in v2: - Update documentation disk/part.c | 41 ++--

[PATCH v2 7/9] fastboot: Move part_get_info_by_name_or_alias after raw_part_get_info_by_name

2021-01-07 Thread Sean Anderson
This makes the next commit more readable by doing the move now. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v1) drivers/fastboot/fb_mmc.c | 44 +++ 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers

[PATCH v2 9/9] fastboot: Partition specification

2021-01-07 Thread Sean Anderson
This documents the way U-Boot understands partitions specifications. This also updates the fastboot documentation for the changes in the previous commit. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- Changes in v2: - Move partition documentation under doc/usage doc/android

[PATCH v2 8/9] fastboot: Allow u-boot-style partitions

2021-01-07 Thread Sean Anderson
allows There should be no conflicts with the existing system, but just in case, I have ordered detection of these names after all existing names. The fastboot_mmc_part test has been updated for these new names. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- Changes in v2: - Fix acc

[PATCH v2 6/9] fastboot: Remove mmcpart argument from raw_part_get_info_by_name

2021-01-07 Thread Sean Anderson
The only thing mmcpart was used for was to pass to blk_dselect_hwpart. This calls blk_dselect_hwpart directly from raw_part_get_info_by_name. The error handling is dropped, but it is reintroduced in the next commit (albeit less specificly). Signed-off-by: Sean Anderson Reviewed-by: Simon Glass

Re: [PATCH v5 0/6] wdt: Add support for watchdogs on Kendryte K210

2021-01-12 Thread Sean Anderson
On 12/22/20 6:58 PM, Sean Anderson wrote: This series depends on https://patchwork.ozlabs.org/project/uboot/list/?series=200642 Changes in v5: - Rebase on u-boot/master Changes in v4: - Fix build error without CONFIG_CLK Changes in v3: - Note dependency on "time: Fix get_ticks bein

Re: [PATCH 4/5] log: convert pr_*() to logging

2021-01-16 Thread Sean Anderson
On 1/4/21 2:02 AM, Heinrich Schuchardt wrote: In drivers we use a family of printing functions including pr_err() and pr_cont(). CONFIG_LOGLEVEL is used to control which of these lead to output via printf(). Our logging functions allow finer grained control of output. So replace printf() by the

Re: [PATCH 4/5] log: convert pr_*() to logging

2021-01-17 Thread Sean Anderson
On 1/17/21 2:26 AM, Heinrich Schuchardt wrote: On 1/17/21 1:37 AM, Sean Anderson wrote: On 1/4/21 2:02 AM, Heinrich Schuchardt wrote: In drivers we use a family of printing functions including pr_err() and pr_cont(). CONFIG_LOGLEVEL is used to control which of these lead to output via printf

Re: Contributor meeting notes 19-Jan-21

2021-01-20 Thread Sean Anderson
On 1/20/21 6:18 PM, Jaehoon Chung wrote: Hi, On 1/20/21 3:54 AM, Simon Glass wrote: Hi, Thank you for attending! Full notes at [1] Tuesday 19 January 2021 Present: Daniel Schwierzeck, Heinrich Schuchardt, Michal Simek, Sean Anderson, Simon Glass, Walter Lozano Notes: [all] Introductions

Re: [PATCH v2 7/7] riscv: Update SiFive device tree for new CLINT driver

2020-08-18 Thread Sean Anderson
On 8/18/20 5:22 AM, Bin Meng wrote: > +Anup Patel > > On Wed, Jul 29, 2020 at 5:57 PM Sean Anderson wrote: >> >> We may need to add a clock-frequency binding like for the K210. >> >> Signed-off-by: Sean Anderson >> --- >> This patch builds but has N

Re: [PATCH 1/1] riscv: don't jump to 0x0 in handle_ipi()

2020-08-18 Thread Sean Anderson
On 8/18/20 5:00 AM, Heinrich Schuchardt wrote: > On 11.08.20 12:32, Sean Anderson wrote: >> On 8/11/20 3:50 AM, Heinrich Schuchardt wrote: >>> On 11.08.20 08:20, Rick Chen wrote: >>>> Hi Heinrich >>>> >>>>> From: Heinrich Schuchardt [

Re: [PATCH v2 1/1] configs: defconfig for Sipeed Maix in S-mode

2020-08-19 Thread Sean Anderson
_PATH=/u-boot-dtb.bin > + > +The value of FW_PAYLOAD_OFFSET must match CONFIG_SYS_TEXT_BASE - 0x8000. > + > +The file to flash is build/platform/kendryte/k210/firmware/fw_payload.bin. > + > Loading Images > ^^ > > @@ -363,3 +406,9 @@ AddressSize Description > interrupts) > 0x8801f000 0x1000credits > == = === > + > +Links > +- > + > +[1] https://github.com/riscv/riscv-sbi-doc > +RISC-V Supervisor Binary Interface Specification > -- > 2.28.0 > Reviewed-by: Sean Anderson

Re: [PATCH v5 11/11] riscv: Add FPIOA and GPIO support for Kendryte K210

2020-08-19 Thread Sean Anderson
s dirty (and CONSOLE_LOGLEVEL is not >> changed). It also boots when changes are made to the device tree and then >> committed. I don't know why this happens. These breakages only occur after >> bf2fb81ad3. >> >> Signed-off-by: Sean Anderson >> --- >&g

Re: [PATCH v2 6/7] riscv: Update Kendryte device tree for new CLINT driver

2020-08-20 Thread Sean Anderson
On 8/20/20 3:45 AM, Bin Meng wrote: > On Wed, Jul 29, 2020 at 5:57 PM Sean Anderson wrote: >> >> AFAIK because the K210 clock driver does not come up until after >> relocation, the clint will always use the clock-frequency parameter. >> Ideally, it should update itse

Re: [PATCH v2 2/7] riscv: Rework Andes PLMT as a UCLASS_TIMER driver

2020-08-20 Thread Sean Anderson
On 8/20/20 3:40 AM, Bin Meng wrote: > On Wed, Jul 29, 2020 at 5:56 PM Sean Anderson wrote: >> >> This converts the PLMT driver from the riscv-specific timer interface to be >> a DM-based UCLASS_TIMER driver. >> >> Signed-off-by: Sean Anderson >> --- >&

Re: [PATCH v2 4/7] riscv: Rework Sifive CLINT as UCLASS_TIMER driver

2020-08-20 Thread Sean Anderson
On 8/20/20 3:43 AM, Bin Meng wrote: > On Wed, Jul 29, 2020 at 5:56 PM Sean Anderson wrote: >> >> This converts the clint driver from the riscv-specific interface to be a >> DM-based UCLASS_TIMER driver. We also need to re-add the initialization for >> IPI back

Re: [PATCH v5 11/11] riscv: Add FPIOA and GPIO support for Kendryte K210

2020-08-21 Thread Sean Anderson
; > Could someone tell me which toolchain is recommended for building the u-boot > for > boards Kendryte K210 ? > > [1] > https://github.com/kendryte/kendryte-gnu-toolchainhttps://github.com/kendryte/kendryte-gnu-toolchain > > Many thanks, > Ruinland > > On Thu, Aug

Re: [PATCH v2 1/1] timer: dw-apb: fix compiler warnings

2020-08-26 Thread Sean Anderson
On 8/26/20 4:29 PM, Heinrich Schuchardt wrote: > readl() and writel() expect void *. Do not pass an integer value. > > Remove unused include asm/arch/timer.h. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Bin Meng > --- > v2: > correct typo in commit message > --- > drivers/timer

Re: [PATCH 04/31] clk: add clk_round_rate()

2020-08-29 Thread Sean Anderson
On 8/29/20 5:20 PM, Simon Glass wrote: > Hi Dario, > > +Stephen Warren > On Tue, 25 Aug 2020 at 03:24, Dario Binacchi wrote: >> >> It returns the rate which will be set if you ask clk_set_rate() to set >> that rate. It provides a way to query exactly what rate you'll get if >> you call clk_set_

Re: [PATCH 04/31] clk: add clk_round_rate()

2020-08-29 Thread Sean Anderson
On 8/29/20 5:48 PM, Sean Anderson wrote: > > On 8/29/20 5:20 PM, Simon Glass wrote: >> Hi Dario, >> >> +Stephen Warren >> On Tue, 25 Aug 2020 at 03:24, Dario Binacchi wrote: >>> >>> It returns the rate which will be set if you ask clk_set_rate()

Re: [PATCH v5 11/11] riscv: Add FPIOA and GPIO support for Kendryte K210

2020-08-31 Thread Sean Anderson
K210. >>>>> >>>>> The board does not boot unless CONSOLE_LOGLEVEL is set to a non-default >>>>> value . It also boots when the tree is dirty (and CONSOLE_LOGLEVEL is not >>>>> changed). It also boots when changes are made to the device tre

<    2   3   4   5   6   7   8   9   10   11   >