[PATCH v4 11/12] x86: qemu: Expand ROM size

2023-11-12 Thread Simon Glass
Expand the ROM for x86_64 to 2MB to make space for the font, as it is already on the edge. Signed-off-by: Simon Glass --- (no changes since v1) board/emulation/qemu-x86/Kconfig | 3 ++- configs/qemu-x86_64_defconfig| 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git

[PATCH v4 10/12] x86: coreboot: Enable truetype fonts

2023-11-12 Thread Simon Glass
Truetype fonts look better in the menu, so enable them. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch to enable truetype fonts in coreboot arch/x86/dts/coreboot.dts| 10 ++ configs/coreboot64_defconfig | 1 + configs/coreboot_defconfig

[PATCH v4 12/12] x86: qemu: Enable truetype fonts

2023-11-12 Thread Simon Glass
Enable this feature to provide a larger font choice and more attractive menus. Expand the ROM for x86_64 to 2MB to make space for the font. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch to enable truetype fonts in qemu-x86 and qemu-x86_64 configs/qemu

[PATCH v4 09/12] x86: Enable SSE in 64-bit mode

2023-11-12 Thread Simon Glass
This is needed to support Truetype fonts. In any case, the compiler expects SSE to be available in 64-bit mode. Provide an option to enable SSE so that hardware floating-point arithmetic works. Signed-off-by: Simon Glass Suggested-by: Bin Meng --- Changes in v4: - Use a Kconfig option arch

[PATCH v4 07/12] video: Correct setting of cursor position

2023-11-12 Thread Simon Glass
The ANSI codes are not correctly handled at present, in that the requested X position is added to the current one. Correct this and also call vidconsole_entry_start() to start a new text line. Signed-off-by: Simon Glass --- (no changes since v1) drivers/video/vidconsole-uclass.c | 15

[PATCH v4 08/12] video: Drop unnecessary truetype operations from SPL

2023-11-12 Thread Simon Glass
Saving and restoring entries is used for expo and for the command line, which we don't use in SPL. Drop these methods. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v3) Changes in v3: - Add new patch to drop unnecessary truetype operations from SPL drivers/video

[PATCH v4 03/12] bootstd: Add a return code to bootflow menu

2023-11-12 Thread Simon Glass
Return an error when the user does not select an OS, so we know whether to boot or not. Move calling of bootflow_menu_run() into a separate function so we can call it from other places. Expand the test to cover these cases. Add some documentation also, while we are here. Signed-off-by: Simon

[PATCH v4 01/12] efi: Correct handling of frame buffer

2023-11-12 Thread Simon Glass
t;Things that are private to the uclass: don't use these in the driver") which is why this was missed when the VIDEO_COPY feature was added. Signed-off-by: Simon Glass Fixes: 8f661a5b662 ("efi_loader: gop: Expose fb when 32bpp") Reviewed-by: Bin Meng --- (no changes since v2)

[PATCH v4 05/12] usb: Avoid unbinding devices in use by bootflows

2023-11-12 Thread Simon Glass
when booting a distro from USB. This was found using a device with 4 bootflows, the last of which was USB. Signed-off-by: Simon Glass --- Changes in v4: - Don't rename the legacy-USB functions - Add a bit more detail to the comment Changes in v2: - Add new patch to avoid unbinding devices in use

[PATCH v4 06/12] expo: Correct background colour

2023-11-12 Thread Simon Glass
Use the correct background colour when using white-on-black. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) boot/expo.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/boot/expo.c b/boot/expo.c index 139d684f8e6e..cadb6a0ad6e3 100644

[PATCH v4 04/12] x86: coreboot: Add a boot script

2023-11-12 Thread Simon Glass
Provide the user with a list of available boot options. Selecting one causes it to be booted. Pressing causes U-Boot to return to the command-line prompt. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v3) Changes in v3: - Clear the screen before booting Changes

[PATCH v4 02/12] bootstd: Refactor mmc prep to allow a different scan

2023-11-12 Thread Simon Glass
Adjust scan_mmc4_bootdev() and related function so that the caller can do its own 'bootflow scan' command. This allows it to change the flags if needed. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch to refactor mmc prep to allow a different scan test

[PATCH v4 00/12] Resolve issues with booting distros on x86

2023-11-12 Thread Simon Glass
some more comments to the header file - Add fixes tag - Add new patch to add a return code to bootflow menu - Add new patch to add a coreboot boot script - Add new patch to avoid unbinding devices in use by bootflows Simon Glass (12): efi: Correct handling of frame buffer bootstd: Refactor mmc

Re: [PATCH v2 3/6] common/board_f: Catch bloblist before starting resevations

2023-11-12 Thread Simon Glass
-- > V2: Fix typo in commit title and checkpatch warnings/checks > V3: No change > --- > common/board_f.c | 33 ++--- > 1 file changed, 30 insertions(+), 3 deletions(-) Reviewed-by: Simon Glass > > diff --git a/common/board_f.c b/common/board_f.c &

Re: [PATCH v2 4/4] usb: Avoid unbinding devices in use by bootflows

2023-11-12 Thread Simon Glass
Hi Mattijs, On Sat, 23 Sept 2023 at 10:39, Mattijs Korpershoek wrote: > > Hi Simon, > > Thank you for your patch. Thanks for reviewing it! > > On ven., sept. 22, 2023 at 15:38, Simon Glass wrote: > > > When a USB device is unbound, it causes any bootflows attached t

Re: [PATCH v3 09/12] x86: Enable SSE in 64-bit mode

2023-11-12 Thread Simon Glass
Hi Bin, On Mon, 6 Nov 2023 at 08:36, Tom Rini wrote: > > On Mon, Nov 06, 2023 at 06:26:15PM +0800, Bin Meng wrote: > > + Tom, > > > > Hi Simon, > > > > On Mon, Nov 6, 2023 at 12:29 AM Simon Glass wrote: > > > > > > Hi Bin, &g

Re: [PATCH 2/4] efi: Collect the ACPI tables in the app

2023-11-12 Thread Simon Glass
Hi Heinrich, On Sun, 12 Nov 2023 at 09:22, Heinrich Schuchardt wrote: > > On 11/12/23 16:58, Simon Glass wrote: > > Locate these so that they can be displayed using the 'acpi' command. > > > > Signed-off-by: Simon Glass > > --- > > > > lib/efi/efi_a

[PATCH 3/4] efi: Correct display of table GUIDs

2023-11-12 Thread Simon Glass
The printf() %pU option decodes GUIDs so it is not necessary to do this first. Drop the incorrect code. Signed-off-by: Simon Glass --- cmd/efi_common.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/cmd/efi_common.c b/cmd/efi_common.c index f4056096cd3f..1aa2351fcdfd

[PATCH 4/4] efi: Avoid using dm_scan_other()

2023-11-12 Thread Simon Glass
This function is defined by bootstd so using it precludes using that feature. Use the board_early_init_r() feature instead. Signed-off-by: Simon Glass --- configs/efi-x86_app64_defconfig | 1 + lib/efi/efi_app.c | 5 ++--- 2 files changed, 3 insertions(+), 3 deletions(-) diff

[PATCH 2/4] efi: Collect the ACPI tables in the app

2023-11-12 Thread Simon Glass
Locate these so that they can be displayed using the 'acpi' command. Signed-off-by: Simon Glass --- lib/efi/efi_app.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/lib/efi/efi_app.c b/lib/efi/efi_app.c index 2209410f35b5..c5eb816655ea 100644

[PATCH 1/4] acpi: Use __packed with struct acpi_xsdt

2023-11-12 Thread Simon Glass
Since struct acpi_table_header is not a multiple of 64 bits, use the __packed option for struct acpi_xsdt This ensures that the entry[] array starts on the correct boundary. Signed-off-by: Simon Glass --- include/acpi/acpi_table.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 0/4] efi: Minor improvements for the EFI app

2023-11-12 Thread Simon Glass
This series collects a few fixes and improvements useful when booting U-Boot as an EFI app. Simon Glass (4): acpi: Use __packed with struct acpi_xsdt efi: Collect the ACPI tables in the app efi: Correct display of table GUIDs efi: Avoid using dm_scan_other() cmd/efi_common.c

[PATCH 7/7] fdt: Move ft_verify_fdt() before the final fixups

2023-11-12 Thread Simon Glass
Move this check before the FDT fixups so that we can use a livetree after this point. Signed-off-by: Simon Glass --- boot/image-fdt.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/boot/image-fdt.c b/boot/image-fdt.c index 3e889be9f2b6..c2b6c5338385 100644

[PATCH 6/7] fdt: Drop the confusing casts in lmb_free()

2023-11-12 Thread Simon Glass
Just use map_to_sysmem() instead of all the casting. Signed-off-by: Simon Glass --- boot/image-fdt.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/boot/image-fdt.c b/boot/image-fdt.c index ac7dc055cc9c..3e889be9f2b6 100644 --- a/boot/image-fdt.c +++ b/boot/image

[PATCH 5/7] boot: Move adding initrd earlier in image_setup_libfdt()

2023-11-12 Thread Simon Glass
This may as well happen before the general event is emitted, so move it. This will allow us to use the livetree for the event part, but the flattree for the earlier part. Signed-off-by: Simon Glass --- boot/image-fdt.c | 5 - include/fdt_support.h | 12 +++- 2 files changed

[PATCH 4/7] fdt: ppc: Drop extra size for ramdisk

2023-11-12 Thread Simon Glass
being the least of them. Therefore this extra hack for ramdisk seems unnecessary. Drop it. Signed-off-by: Simon Glass --- boot/image-fdt.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/boot/image-fdt.c b/boot/image-fdt.c index 54d219da7da1..408369d489ca 100644 --- a/boot/image-fdt.c

[PATCH 0/7] fdt: Move towards using ofnode for devicetree fixups

2023-11-12 Thread Simon Glass
fixups. This should make it possible to whittle away at the former. This series is based on Sean's one here: https://patchwork.ozlabs.org/project/uboot/list/?series=380576=* Simon Glass (7): boot: Drop size parameter from image_setup_libfdt() fdt: Check for a valid fdt in oftree_ensure

[PATCH 3/7] fdt: Improve the comment for fdt_shrink_to_minimum()

2023-11-12 Thread Simon Glass
Add a bit more detail about what this function does. Signed-off-by: Simon Glass --- boot/fdt_support.c| 1 - include/fdt_support.h | 12 +++- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/boot/fdt_support.c b/boot/fdt_support.c index 09ce5828659e..510ad24a999d

[PATCH 2/7] fdt: Check for a valid fdt in oftree_ensure()

2023-11-12 Thread Simon Glass
Check the header before starting to use it, since this could provide very confusing later, when ofnode calls start to fail. Signed-off-by: Simon Glass --- drivers/core/ofnode.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/core/ofnode.c b/drivers/core/ofnode.c index

[PATCH 1/7] boot: Drop size parameter from image_setup_libfdt()

2023-11-12 Thread Simon Glass
The of_size parameter is not used, so remove it. Signed-off-by: Simon Glass --- arch/mips/lib/bootm.c | 4 ++-- boot/image-board.c| 2 +- boot/image-fdt.c | 3 ++- cmd/bootefi.c | 2 +- include/image.h | 3 +-- lib/efi_loader

[PATCH] sandbox: Fix VPL instructions

2023-11-12 Thread Simon Glass
Fix the devicetree used with sandbox. This is needed because the default (full) devicetree must be used by all phases of boot, with sandbox. Signed-off-by: Simon Glass --- doc/arch/sandbox/sandbox.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/arch/sandbox

Re: [PATCH] configs: rockpro64: Enable SPI command and full BOOTSTD

2023-11-12 Thread Simon Glass
ards use standard boot, this only enables full commands > for one particular board, why is this board special? Or is there merit > to imply enable of full commands for all rockchip boards? I suppose we do this in a lot of cases, where we enable commands and other features on various boar

[PATCH v2 4/5] bootm: Move arm64-image processing later

2023-11-11 Thread Simon Glass
If the image is compressed, then the existing check fails, since the header is wrong. Move the check later in the boot process, after the kernel is decompressed. This allows use of bootm with compressed kernels, while still permitting an uncompressed kernel to be used. Signed-off-by: Simon Glass

[PATCH v2 5/5] boot: Don't allow kernel_noload with compression

2023-11-11 Thread Simon Glass
It is not possible to execute the kernel in-place without loading it. Detect this and show an error, to avoid a crash. Signed-off-by: Simon Glass --- Changes in v2: - Add a 'success' case to the cover letter - Redo how the arm64 support is implemented boot/bootm.c | 4 1 file changed, 4

[PATCH v2 3/5] bootm: Allow omitting the load address

2023-11-11 Thread Simon Glass
reasonable to me. It might perhaps be useful to introduce an 'entry-offset' property which allows the entry to be set as an offset from the load address, whether that is explicit or calculated. Signed-off-by: Simon Glass --- Changes in v2: - Allow omitting the load address rather than messing

[PATCH v2 1/5] image: Correct load_bug typo

2023-11-11 Thread Simon Glass
Correct a typo in the function comment for image_decomp(). Signed-off-by: Simon Glass --- (no changes since v1) include/image.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/image.h b/include/image.h index 2e3cf839ee36..0fe67852c563 100644 --- a/include/image.h

[PATCH v2 2/5] image: Show the load address when decompressing

2023-11-11 Thread Simon Glass
The destination address for decompression (or copying) is useful information. Show this to the user while booting, e.g.: Uncompressing Kernel Image (no loading done) to 208 Signed-off-by: Simon Glass --- (no changes since v1) boot/image.c | 13 + 1 file changed, 9

[PATCH v2 0/5] bootm: Handle compressed arm64 images with bootm

2023-11-11 Thread Simon Glass
than messing with kernel_noload - Rework the patch based on a better understanding of events - Add a 'success' case to the cover letter - Redo how the arm64 support is implemented Simon Glass (5): image: Correct load_bug typo image: Show the load address when decompressing bootm: Allow omitting the

Re: [PATCH 3/3] test: dm: adjust ACPI test

2023-11-11 Thread Simon Glass
sertions(+), 9 deletions(-) > Reviewed-by: Simon Glass Ideally this should be in the commit which made the change, do avoid test failures on particular commits. Regards, Simon

Re: [PATCH 2/3] cmd: acpi: fix acpi list command

2023-11-11 Thread Simon Glass
Hi Heinrich, On Sat, 11 Nov 2023 at 06:42, Heinrich Schuchardt wrote: > > ACPI tables may comprise either RSDT, XSDT, or both. The current code fails > to check the presence of the RSDT table before accessing it. This leads to > an exception if the RSDT table is not provided. > > The XSDT table

Re: [PATCH 1/3] acpi: fix struct acpi_xsdt

2023-11-11 Thread Simon Glass
> 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass It is really unfortunate. Would it be worth adding a test for this, which actually checks the member offset? > > diff --git a/include/acpi/acpi_table.h b/include/acpi/acpi_table.h > index a3b67259e6..20ac3

Re: [PATCH] virtio: rng: gracefully handle 0 byte returns

2023-11-11 Thread Simon Glass
Hi Andre, On Fri, 10 Nov 2023 at 07:16, Andre Przywara wrote: > > On Fri, 10 Nov 2023 05:53:59 -0700 > Simon Glass wrote: > > Hi Simon, > > > On Tue, 7 Nov 2023 at 09:09, Andre Przywara wrote: > > > > > > According to the virtio v1.x "entropy d

Re: [PATCH] configs: rockpro64: Enable SPI command and full BOOTSTD

2023-11-11 Thread Simon Glass
Hi Shantur, On Fri, 10 Nov 2023 at 17:14, Shantur Rathore wrote: > > RockPro64 has a 16MB onboard SPI chip and current u-boot takes > around 2MB, we can enable more features. What takes 2MB? I have never seen U-Boot get close to that large! Regards, Simon > Updating config to enable SPI

Re: [PATCH 1/1] tpm: remove superfluous check in tpm_tis_send()

2023-11-11 Thread Simon Glass
d() > https://lore.kernel.org/u-boot/yafwdtkkyrr7q...@apalos.home/ > > Signed-off-by: Heinrich Schuchardt > --- > drivers/tpm/tpm2_tis_core.c | 3 --- > 1 file changed, 3 deletions(-) > Reviewed-by: Simon Glass

[PATCH v2 4/4] image: Correct load_bug typo

2023-11-11 Thread Simon Glass
Correct a typo in the function comment for image_decomp(). Signed-off-by: Simon Glass --- Changes in v2: - Add a 'success' case to the cover letter include/image.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/image.h b/include/image.h index 2e3cf839ee36

[PATCH v2 3/4] image: Show the load address when decompressing

2023-11-11 Thread Simon Glass
The destination address for decompression (or copying) is useful information. Show this to the user while booting, e.g.: Uncompressing Kernel Image (no loading done) to 208 Signed-off-by: Simon Glass --- (no changes since v1) boot/image.c | 13 + 1 file changed, 9

[PATCH v2 1/4] bootm: Allow ignoring the load address with kernel_noload

2023-11-11 Thread Simon Glass
reasonable to me. Signed-off-by: Simon Glass --- (no changes since v1) boot/bootm.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/boot/bootm.c b/boot/bootm.c index cb61485c226c..7583be5a4515 100644 --- a/boot/bootm.c +++ b/boot/bootm.c @@ -176,7 +176,13 @@ static int

[PATCH v2 2/4] bootm: Move arm64-image processing later

2023-11-11 Thread Simon Glass
If the image is compressed, then the existing check fails, since the header is wrong. Move the check later in the boot process, after the kernel is decompressed. This allows use of bootm with compressed kernels, while still permitting an uncompressed kernel to be used. Signed-off-by: Simon Glass

[PATCH v2 0/4] bootm: Handle compressed arm64 images with bootm

2023-11-11 Thread Simon Glass
ess 0, which may not be valid on the board. We can use the kernel_addr_r environment variable instead. A patch is included to show the kernel load-address, so it is easy to see what is going on. Changes in v2: - Add a 'success' case to the cover letter Simon Glass (4): bootm: Allow ignor

[PATCH v2 3/3] tpm: Drop unwanted special cases for sandbox

2023-11-11 Thread Simon Glass
These don't seem to be needed. Add a few notes about what to do next. Also mention parallel tests in at the top of thefile. Signed-off-by: Simon Glass Reviewed-by: Ilias Apalodimas --- (no changes since v1) test/py/tests/test_tpm2.py | 46 +- 1 file

[PATCH v2 1/3] tpm: sandbox: Support self-test continue in emulator

2023-11-11 Thread Simon Glass
Add support for the self-test continue command in the TPM v1.2 emulator, to match the functionality in the TPM v2 emulator. Signed-off-by: Simon Glass Reviewed-by: Ilias Apalodimas --- (no changes since v1) drivers/tpm/tpm_tis_sandbox.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v2 0/3] tpm: Start to tidy up TPM tests

2023-11-11 Thread Simon Glass
is to have a few tests which do init, then have the rest of the tests assume that the init is done. Tests that depend on the TPM already being inited can use 'tpm autostart' which works OK on sandbox and real hardware. Changes in v2: - Keep test_tpm2_continue_self_test() Simon Glass (3): tpm

[PATCH v2 2/3] tpm: Convert sandbox-focussed tests to C

2023-11-11 Thread Simon Glass
the Python tpm_init test to use 'tpm autostart', since this deals with starting up ready for the tests below. Signed-off-by: Simon Glass --- Changes in v2: - Keep test_tpm2_continue_self_test() test/dm/tpm.c | 77 +- test/py/tests/test_tpm2.py | 38

[PATCH 28/29] bootm: Add a function to check overlap

2023-11-11 Thread Simon Glass
Move this code into a function to reduce code size and make it easier to understand. Drop the unnecessary 0x to help a little with code size. Use this in bootm_find_images() Signed-off-by: Simon Glass --- boot/bootm.c | 51 ++- 1 file changed

[PATCH 27/29] bootm: Adjust the parameters of bootm_find_images()

2023-11-11 Thread Simon Glass
to the header file and tidy it a little. Signed-off-by: Simon Glass --- boot/bootm.c| 45 ++--- cmd/booti.c | 4 +++- cmd/bootz.c | 4 +++- include/bootm.h | 26 +++--- 4 files changed, 43 insertions(+), 36 deletions(-) diff --git

[PATCH 26/29] bootm: optee: Drop special call to bootm_find_other()

2023-11-11 Thread Simon Glass
bootm_os_get_boot_func() Signed-off-by: Simon Glass --- boot/bootm.c| 2 +- boot/bootm_os.c | 10 -- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/boot/bootm.c b/boot/bootm.c index 342d6211a097..62b6ca957f5b 100644 --- a/boot/bootm.c +++ b/boot/bootm.c @@ -583,7 +583,7

[PATCH 29/29] bootm: Reduce arguments to bootm_find_other()

2023-11-11 Thread Simon Glass
Rather than passing the full list of command arguments, pass only those which are needed. Signed-off-by: Simon Glass --- boot/bootm.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/boot/bootm.c b/boot/bootm.c index a803b0749be0..b0eecbb0dd3c 100644

[PATCH 25/29] bootm: efi: Drop special call to bootm_find_other()

2023-11-11 Thread Simon Glass
The normal bootm flow calls bootm_find_other() can call the BOOTM_STATE_FINDOTHER state as part of its processing. Fix the condition there so that this hack can be removed. -off-by: Simon Glass Signed-off-by: Simon Glass --- boot/bootm.c| 10 +- boot/bootm_os.c | 6 -- 2

[PATCH 24/29] bootm: Simplify Android ramdisk addr in bootm_find_images()

2023-11-11 Thread Simon Glass
-by: Simon Glass --- boot/bootm.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/boot/bootm.c b/boot/bootm.c index c71368431c48..41cb52fb72c7 100644 --- a/boot/bootm.c +++ b/boot/bootm.c @@ -489,15 +489,20 @@ int bootm_find_images(int flag, int argc, char *const argv

[PATCH 16/29] bootm: Reduce arguments to boot_find_os()

2023-11-11 Thread Simon Glass
This function only uses one argument so pass it in directly. Signed-off-by: Simon Glass --- boot/bootm.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/boot/bootm.c b/boot/bootm.c index ec43d4e7e8ba..2358d68c2861 100644 --- a/boot/bootm.c +++ b/boot/bootm.c

[PATCH 23/29] bootm: Reduce arguments to boot_get_loadables()

2023-11-11 Thread Simon Glass
This function only uses two arguments. The 'arch' always has a constant value, so drop it. This simplifies the function call. Tidy up the function comment while we are here. Signed-off-by: Simon Glass --- boot/bootm.c | 3 +-- boot/image-board.c | 6 +++--- include/image.h| 24

[PATCH 19/29] bootm: Drop #ifdef in bootm_find_images()

2023-11-11 Thread Simon Glass
The OF_LIBFDT #ifdef makes it harder to use a local variable for that code block. Convert it to if() instead. Signed-off-by: Simon Glass --- boot/bootm.c | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/boot/bootm.c b/boot/bootm.c

[PATCH 20/29] bootm: Pass image buffer to boot_get_fdt()

2023-11-11 Thread Simon Glass
we are here. Signed-off-by: Simon Glass --- boot/bootm.c | 11 +++ boot/image-fdt.c | 32 +++- include/image.h | 31 --- 3 files changed, 38 insertions(+), 36 deletions(-) diff --git a/boot/bootm.c b/boot/bootm.c index

[PATCH 22/29] bootm: Reduce arguments to boot_get_fpga()

2023-11-11 Thread Simon Glass
This function only uses two arguments. The 'arch' always has a constant value, so drop it. This simplifies the function call. Signed-off-by: Simon Glass --- boot/bootm.c | 3 +-- boot/image-board.c | 5 ++--- include/image.h| 9 +++-- 3 files changed, 10 insertions(+), 7

[PATCH 18/29] fdt: Allow use of fdt_support inside if() statements

2023-11-11 Thread Simon Glass
Most of the fdt_support.h header file is included only if OF_LIBFDT or OF_CONTROL are enabled. This means that calling functions defined in that file must happen inside an #ifdef This is unnecessary, so reduce the condition to just !USE_HOSTCC Signed-off-by: Simon Glass --- include

[PATCH 17/29] bootm: Reduce arguments to boot_get_ramdisk()

2023-11-11 Thread Simon Glass
strange, since it can use argv[0], so deal with that in the caller. Signed-off-by: Simon Glass --- boot/bootm.c | 15 ++- boot/image-board.c | 39 ++- include/image.h| 27 +-- 3 files changed, 41 insertions(+), 40

[PATCH 12/29] bootm: Adjust boot_get_kernel() to return an error

2023-11-11 Thread Simon Glass
This function obtains lots of error codes and then throws them away. Update it to return the error, moving the image pointer to an argument. Signed-off-by: Simon Glass --- boot/bootm.c | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/boot

[PATCH 13/29] bootm: Use the error return from boot_get_kernel()

2023-11-11 Thread Simon Glass
Rather than looking for a zero-sized image, use the error code returned to determine if things are OK. Signed-off-by: Simon Glass --- boot/bootm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/boot/bootm.c b/boot/bootm.c index 57eaa1ff10df..5e3b5e940734 100644

[PATCH 21/29] bootm: Reduce arguments to boot_get_fdt()

2023-11-11 Thread Simon Glass
This function only uses one argument from bootm (argv[2]) so pass it in directly. Signed-off-by: Simon Glass --- boot/bootm.c | 5 +++-- boot/image-fdt.c | 9 +++-- include/image.h | 5 ++--- 3 files changed, 8 insertions(+), 11 deletions(-) diff --git a/boot/bootm.c b/boot/bootm.c

[PATCH 14/29] bootstage: Drop BOOTSTAGE_ID_FIT_KERNEL_INFO

2023-11-11 Thread Simon Glass
This is a misnomer since we don't necessarily know that the image is a FIT. Use the existing BOOTSTAGE_ID_CHECK_IMAGETYPE instead. Signed-off-by: Simon Glass --- boot/bootm.c| 2 +- include/bootstage.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/boot/bootm.c b

[PATCH 11/29] image: Document error codes from fit_image_load()

2023-11-11 Thread Simon Glass
Put a list of these in the function documentation so it is easier to decode what went wrong. Signed-off-by: Simon Glass --- include/image.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/include/image.h b/include/image.h index 798c5f9c16e4..d37e44721672 100644

[PATCH 08/29] bootm: Move boot_get_kernel() higher in the file

2023-11-11 Thread Simon Glass
Move this code and image_get_kernel() higher in the file to avoid the need for a forward declaration. No attempt is made to remove #ifdefs or adjust the code in any other way. Signed-off-by: Simon Glass --- boot/bootm.c | 376 +-- 1 file changed

[PATCH 15/29] bootm: Move error printing out of boot_get_kernel()

2023-11-11 Thread Simon Glass
The same error message is printed in two places. Move it out to the caller so we can avoid passing in the command name. Leave the bootstage handling where it is. Signed-off-by: Simon Glass --- boot/bootm.c | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git

[PATCH 10/29] bootm: Reduce arguments to boot_get_kernel()

2023-11-11 Thread Simon Glass
This function only uses one argument and just needs to know the name of the command which called it. Adjust the function to use only what it needs. This will make it easier to call from a non-command context. Tidy up the function comment while we are here. Signed-off-by: Simon Glass --- boot

[PATCH 06/29] bootm: Drop arguments from bootm_start()

2023-11-11 Thread Simon Glass
This function does not use its arguments. Drop them. Signed-off-by: Simon Glass --- boot/bootm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/boot/bootm.c b/boot/bootm.c index cb61485c226c..fda97706fc26 100644 --- a/boot/bootm.c +++ b/boot/bootm.c @@ -69,8 +69,7

[PATCH 03/29] treewide: Tidy up semicolon after command macros

2023-11-11 Thread Simon Glass
The U_BOOT_CMD_COMPLETE() macro has a semicolon at the end, perhaps inadvertently. Some code has taken advantage of this. Tidy this up by dropping the semicolon from the macro and adding it to macro invocations as required. Signed-off-by: Simon Glass --- board/freescale/common/vid.c | 2

[PATCH 07/29] bootm: Simplify arguments for bootm_pre_load()

2023-11-11 Thread Simon Glass
Move the argument decoding to the caller, to avoid needing to pass the command-line arguments. Add a function comment while we are here. Signed-off-by: Simon Glass --- boot/bootm.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/boot/bootm.c b/boot

[PATCH 09/29] image: Tidy up genimg_get_kernel_addr_fit()

2023-11-11 Thread Simon Glass
This function does not modify its first argument, so mark it const. Also move the comments to the header file and expand them to provide more useful information. Signed-off-by: Simon Glass --- boot/bootm.c | 3 +-- boot/image-board.c | 17 + include/image.h| 29

[PATCH 05/29] bootstd: Introduce programmable boot

2023-11-11 Thread Simon Glass
At present bootstd requires CONFIG_CMDLINE to operate. Add a new 'programmable' boot which can be used when no command line is available. For now it does almost nothing, since most bootmeths require the command line. Signed-off-by: Simon Glass --- boot/Kconfig | 11 ++ boot

[PATCH 04/29] bootstd: Add missing header file from bootdev.h

2023-11-11 Thread Simon Glass
Add a dm/uclass-id.h to the bootdev header file, since it uses enum uclass_id Signed-off-by: Simon Glass --- include/bootdev.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/bootdev.h b/include/bootdev.h index b079a91b5b7f..c1362673d418 100644 --- a/include/bootdev.h +++ b/include

[PATCH 02/29] mmc: env: Unify the U_BOOT_ENV_LOCATION conditions

2023-11-11 Thread Simon Glass
The declaration of U_BOOT_ENV_LOCATION() uses a different #ifdef condition from the code it calls. Use the same condition to avoid a build warning if CONFIG_CMD_SAVEENV is disabled. Signed-off-by: Simon Glass --- env/mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/env

[PATCH 00/29] bootm: Refactoring to reduce reliance on CMDLINE (part A)

2023-11-11 Thread Simon Glass
text +72.0 This should be removed by: https://source.denx.de/u-boot/custodians/u-boot-dm/-/issues/11 but it is not included in this series as it is already large enough. No functional change is intended in this series. Simon Glass (29): arm: x86: Drop discarding of command linker-lists

[PATCH 01/29] arm: x86: Drop discarding of command linker-lists

2023-11-11 Thread Simon Glass
Since we can now cleanly disable CMDLINE when needed, drop the rules which discard the command code. It will not be built in the first place. Signed-off-by: Simon Glass --- arch/arm/cpu/u-boot.lds | 3 --- arch/x86/cpu/u-boot-64.lds | 4 arch/x86/cpu/u-boot-spl.lds | 4 arch

[PATCH v5 3/3] arm64: boot: Support Flat Image Tree

2023-11-10 Thread Simon Glass
to change the compression other than by editing the rule for $(obj)/image.fit While FIT supports a ramdisk / initrd, no attempt is made to support this here, since it must be built separately from the Linux build. Signed-off-by: Simon Glass --- Changes in v5: - Correct compression rule which

[PATCH v5 2/3] arm: boot: Move the single quotes for image name

2023-11-10 Thread Simon Glass
Add quotes where UIMAGE_NAME is used, rather than where it is defined. This allows the UIMAGE_NAME variable to be set by the user. Signed-off-by: Simon Glass --- (no changes since v4) Changes in v4: - Add a patch to move the single quotes for image name scripts/Makefile.lib | 4 ++-- 1 file

[PATCH v5 1/3] kbuild: arm64: Add BOOT_TARGETS variable

2023-11-10 Thread Simon Glass
Add a new variable containing a list of possible targets. Mark them as phony. This matches the approach taken for arch/arm Signed-off-by: Simon Glass --- (no changes since v1) arch/arm64/Makefile | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/Makefile b

[PATCH v5 0/3] arm64: Add a build target for Flat Image Tree

2023-11-10 Thread Simon Glass
- Include the kernel image in the file count - Add a pointer to the FIT spec and mention of its wide industry usage - Mention the kernel version in the FIT description Simon Glass (3): kbuild: arm64: Add BOOT_TARGETS variable arm: boot: Move the single quotes for image name arm64: boot: Su

Re: [PATCH] virtio: rng: gracefully handle 0 byte returns

2023-11-10 Thread Simon Glass
Hi Andre, On Tue, 7 Nov 2023 at 09:09, Andre Przywara wrote: > > According to the virtio v1.x "entropy device" specification, a virtio-rng > device is supposed to always return at least one byte of entropy. > However the virtio v0.9 spec does not mention such a requirement. > > The Arm Fixed

Re: [PATCH] acpi: move acpi_get_rsdp_addr() to acpi/acpi_table.h

2023-11-10 Thread Simon Glass
Hi Tom, Heinrich, On Thu, 9 Nov 2023 at 13:42, Tom Rini wrote: > > On Thu, Nov 09, 2023 at 12:28:26PM -0800, Heinrich Schuchardt wrote: > > On 11/9/23 11:24, Tom Rini wrote: > > > On Thu, Nov 09, 2023 at 09:23:02AM -0800, Heinrich Schuchardt wrote: > > > > > > > Function acpi_get_rsdp_addr() is

Re: [PATCH] acpi: move acpi_get_rsdp_addr() to acpi/acpi_table.h

2023-11-10 Thread Simon Glass
t; arch/x86/include/asm/acpi_table.h | 9 - > drivers/misc/qfw.c| 1 + > include/acpi/acpi_table.h | 9 + > 3 files changed, 10 insertions(+), 9 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH 1/3] linux/time.h: Add Linux time conversion defines

2023-11-10 Thread Simon Glass
; include/linux/time.h | 9 + > 1 file changed, 9 insertions(+) Reviewed-by: Simon Glass

Re: [PATCH] doc: typo 'form' in qfw.rst

2023-11-10 Thread Simon Glass
On Thu, 9 Nov 2023 at 09:35, Heinrich Schuchardt wrote: > > %s/form/from/ > > Fixes: d46bee8c2d24 ("doc: qfw man-page") > Signed-off-by: Heinrich Schuchardt > --- > doc/usage/cmd/qfw.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass

Re: [PATCH] pci: ecm generic: use dev_read_() interface

2023-11-10 Thread Simon Glass
NFIG_OF_LIVE breaks the PCIe enumeration on Qemu Risc-V virt > > > > machine. The issue is described in the link below: > > > > > > > > Link: https://source.denx.de/u-boot/custodians/u-boot-dm/-/issues/1 > > > > Signed-off-by: Mayuresh Chitale > > > &

Re: [PATCH] riscv: binman: fix the load field format

2023-11-10 Thread Simon Glass
Hi Randolph, On Wed, Nov 8, 2023, 20:15 Randolph wrote: > > The #address-cells is now equal to 2. The format of the load field for > the Linux kernel doesn't match. > > Signed-off-by: Randolph > --- > arch/riscv/dts/binman.dtsi | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff

Re: [PATCH v3 0/2] rng: Provide a RNG based on the RISC-V Zkr ISA extension

2023-11-10 Thread Simon Glass
Hi, On Wed, 8 Nov 2023 at 10:38, Palmer Dabbelt wrote: > > On Tue, 07 Nov 2023 15:12:16 PST (-0800), Conor Dooley wrote: > > +CC Palmer > > > > On Tue, Nov 07, 2023 at 05:38:37PM -0500, Tom Rini wrote: > >> On Tue, Nov 07, 2023 at 10:27:50PM +, Conor Dooley wrote: > >> > On Tue, Nov 07, 2023

Re: [PATCH v11 00/24] Modernize U-Boot shell

2023-11-08 Thread Simon Glass
Hi Peter, On Wed, 8 Nov 2023 at 05:14, Peter Robinson wrote: > > On Wed, Nov 8, 2023 at 12:49 AM Francis Laniel > wrote: > > > > Hi. > > > > > > During 2021 summer, Sean Anderson wrote a contribution to add a new shell, > > based > > on LIL, to U-Boot [1, 2]. > > While one of the goals of this

Re: [PATCH v11 8/9] cmd: efidebug: add uri device path

2023-11-08 Thread Simon Glass
t; > Signed-off-by: Masahisa Kojima > Acked-by: Ilias Apalodimas > --- > cmd/efidebug.c | 51 > include/net.h | 8 ++ > net/wget.c | 71 ++ > 3 files changed, 130 insertions(+) Reviewed-by

Re: [PATCH] scsi: Have scsi_init_dev_desc_priv() use memset

2023-11-08 Thread Simon Glass
ockchip: block: blk-uclass: add bounce buffer flag to > blk_desc") > Signed-off-by: Tom Rini > --- > Cc: Johan Jonker > --- > drivers/scsi/scsi.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH v7 08/26] spl: Refactor spl_load_info->read to use units of bytes

2023-11-08 Thread Simon Glass
| 24 -- > common/spl/spl_nand.c | 8 ++--- > include/spl.h | 18 +++ > test/image/spl_load_os.c | 13 ++++---- > 7 files changed, 82 insertions(+), 93 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH] sysreset: Fix unsupported request return values

2023-11-08 Thread Simon Glass
iles changed, 9 insertions(+), 9 deletions(-) Reviewed-by: Simon Glass > > diff --git a/drivers/sysreset/poweroff_gpio.c > b/drivers/sysreset/poweroff_gpio.c > index a5c24fd85bca..ad04e4b1a85e 100644 > --- a/drivers/sysreset/poweroff_gpio.c > +++ b/drivers/sysreset/poweroff

<    6   7   8   9   10   11   12   13   14   15   >