Re: [PATCH v3 22/32] efi: Update EFI_LOADER to depend on DM_ETH

2023-10-22 Thread Simon Glass
Hi, On Sun, 22 Oct 2023 at 07:59, Tom Rini wrote: > > On Sun, Oct 22, 2023 at 10:29:22AM -0400, Tom Rini wrote: > > On Sun, Oct 22, 2023 at 08:08:11AM +0200, Heinrich Schuchardt wrote: > > > On 10/21/23 20:26, Tom Rini wrote: > > > > On Sat, Oct 21, 2023 at 08

Re: [PATCH v3 32/32] sandbox: Add a test for disabling CONFIG_CMDLINE

2023-10-21 Thread Simon Glass
Hi Tom, On Thu, 19 Oct 2023 at 07:57, Tom Rini wrote: > > On Thu, Oct 19, 2023 at 08:00:00AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Wed, 18 Oct 2023 at 20:32, Tom Rini wrote: > > > > > > On Mon, Oct 16, 2023 at 04:28:23PM -0600, Simon Glas

Re: [PATCH v2 30/32] fdt: Allow the devicetree to come from a bloblist

2023-10-21 Thread Simon Glass
Hi Raymond, On Fri, 20 Oct 2023 at 15:15, Raymond Mao wrote: > > Hi Simon, > > On Thu, 21 Sept 2023 at 04:58, Simon Glass wrote: > > > > Standard passage provides for a bloblist to be passed from one firmware > > phase to the next. That can be used to pass the dev

Re: [PATCH v3 22/32] efi: Update EFI_LOADER to depend on DM_ETH

2023-10-21 Thread Simon Glass
Hi, On Thu, 19 Oct 2023 at 17:30, AKASHI Takahiro wrote: > > On Thu, Oct 19, 2023 at 08:01:11AM -0600, Simon Glass wrote: > > Hi Heinrich, > > > > On Wed, 18 Oct 2023 at 06:55, Heinrich Schuchardt > > wrote: > > > > > > On 10/17/23 16:09, Tom R

Re: [v4.1 2/2] CI, pytest: Add a test for sandbox without LTO

2023-10-21 Thread Simon Glass
I think is more > reasonable than reworking the introduction of > test/py/tests/test_sandbox_opts.py > > Cc: Simon Glass > --- > .azure-pipelines.yml | 3 --- > .gitlab-ci.yml | 12 > test/py/tests/test_sandbox_opts.py

Re: [PATCH v2 1/1] efi_loader: expose the device-tree file name

2023-10-21 Thread Simon Glass
Hi Tom, On Fri, 20 Oct 2023 at 09:24, Tom Rini wrote: > > On Fri, Oct 20, 2023 at 05:40:03PM +0200, Heinrich Schuchardt wrote: > > On 20.10.23 15:21, Simon Glass wrote: > > > +Doug Anderson > > > > > > Hi Heinrich, > > > > > > On Th

[PATCH] smbios: arm64: Allow table to be written at a fixed addr

2023-10-20 Thread Simon Glass
U-Boot typically sets up its malloc() pool near the top of memory. On ARM64 systems this can result in an SMBIOS table above 4GB which is not supported by SMBIOSv2. Work around this problem by providing a new option to choose an address just below 4GB, if needed. Signed-off-by: Simon Glass

Re: [PATCH v2 1/1] efi_loader: expose the device-tree file name

2023-10-20 Thread Simon Glass
Trying again to add Doug as we chatted briefly about this yesterday. On Fri, Oct 20, 2023, 07:21 Simon Glass wrote: > > +Doug Anderson > > Hi Heinrich, > > On Thu, 19 Oct 2023 at 09:09, Heinrich Schuchardt > wrote: > > > > On 19.10.23 15:55, Sim

Re: [PATCH 30/32] fdt: Allow the devicetree to come from a bloblist

2023-10-20 Thread Simon Glass
Hi Ilias, On Fri, 20 Oct 2023 at 01:22, Ilias Apalodimas wrote: > > Hi Simon, > > On Wed, 18 Oct 2023 at 18:26, Simon Glass wrote: > > > > Hi Ilias, > > > > On Mon, 25 Sept 2023 at 04:19, Ilias Apalodimas > > wrote: > > > > > > Hi S

Re: [PATCH v2 1/1] efi_loader: expose the device-tree file name

2023-10-20 Thread Simon Glass
+Doug Anderson Hi Heinrich, On Thu, 19 Oct 2023 at 09:09, Heinrich Schuchardt wrote: > > On 19.10.23 15:55, Simon Glass wrote: > > Hi Heinrich, > > > > On Wed, 18 Oct 2023 at 02:15, Heinrich Schuchardt > > wrote: > >> > >> On 10/1

Re: U-Boot 2023.10 does not boot from uSD on RPi4

2023-10-19 Thread Simon Glass
Hi Ivan, On Thu, 19 Oct 2023 at 08:29, Ivan Ivanov wrote: > > On Thu, 2023-10-19 at 08:00 -0600, Simon Glass wrote: > > > > > > > > [2] > > > > https://patchwork.ozlabs.org/project/uboot/patch/20230923205017.1754340-1-...@chromium.org/ > > >

Re: [PATCH v3 22/32] efi: Update EFI_LOADER to depend on DM_ETH

2023-10-19 Thread Simon Glass
Hi Heinrich, On Wed, 18 Oct 2023 at 06:55, Heinrich Schuchardt wrote: > > On 10/17/23 16:09, Tom Rini wrote: > > On Mon, Oct 16, 2023 at 04:28:13PM -0600, Simon Glass wrote: > > > >> Since efi_device_path.c calls eth_get_dev() and assumes that Ethernet is > >&

Re: [PATCH v3 22/32] efi: Update EFI_LOADER to depend on DM_ETH

2023-10-19 Thread Simon Glass
Hi Peter, On Thu, 19 Oct 2023 at 04:40, Peter Robinson wrote: > > On Wed, Oct 18, 2023 at 4:29 PM Simon Glass wrote: > > > > Hi Tom, > > > > On Wed, 18 Oct 2023 at 07:37, Tom Rini wrote: > > > > > > On Mon, Oct 16, 2023 at 04:28:13

Re: U-Boot 2023.10 does not boot from uSD on RPi4

2023-10-19 Thread Simon Glass
x.de/pipermail/u-boot/2023-October/533158.html > > > > > > > > > 'git bisect' points to: > > > > > ** > > > > > commit c771e5b8c2a186fb072b6c6f571d4a3cc86efba9 > > > > > Author: Simon Glass > > > > > Date: Thu Jul 27 15

Re: [PATCH v3 32/32] sandbox: Add a test for disabling CONFIG_CMDLINE

2023-10-19 Thread Simon Glass
Hi Tom, On Wed, 18 Oct 2023 at 20:32, Tom Rini wrote: > > On Mon, Oct 16, 2023 at 04:28:23PM -0600, Simon Glass wrote: > > > Now that everything is working, add a test to make sure that this > > builds correctly. > > > > Signed-off-by: Simon

Re: [PATCH v3 04/32] cmd: Add a few more dependencies on CMDLINE

2023-10-19 Thread Simon Glass
Hi Heinrich, On Wed, 18 Oct 2023 at 07:14, Heinrich Schuchardt wrote: > > On 10/17/23 00:27, Simon Glass wrote: > > Add this to some more commands to avoid build errors with sandbox. > > > > Note that this is a temporary solution to expose more problems. A later >

Re: [PATCH v3 14/32] bootm: Allow building when cleanup functions are missing

2023-10-19 Thread Simon Glass
Hi Tom, On Wed, 18 Oct 2023 at 06:39, Tom Rini wrote: > > On Tue, Oct 17, 2023 at 09:31:04PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 17 Oct 2023 at 08:02, Tom Rini wrote: > > > > > > On Mon, Oct 16, 2023 at 04:28:05PM -0600, Simon Glass

Re: [RFC PATCH 4/5] video: Skip framebuffer reservation if already reserved

2023-10-19 Thread Simon Glass
c | 8 > 1 file changed, 8 insertions(+) Reviewed-by: Simon Glass > > diff --git a/drivers/video/video-uclass.c b/drivers/video/video-uclass.c > index f743ed74c8..bac30187e7 100644 > --- a/drivers/video/video-uclass.c > +++ b/drivers/video/video-uclass.c > @@ -12

Re: [PATCH v3 1/2] binman: openssl: x509: ti_secure_rom: Add support for bootcore_opts

2023-10-19 Thread Simon Glass
Hi Neha, On Tue, 17 Oct 2023 at 23:20, Neha Malcom Francis wrote: > > Hi Simon > > On 18/10/23 09:03, Simon Glass wrote: > > Hi Neha, > > > > On Tue, 17 Oct 2023 at 03:58, Neha Malcom Francis wrote: > >> > >> Hi Simon > >>

Re: [RFC PATCH 1/5] arm: mach-k3: common: Reserve video memory from end of the RAM

2023-10-19 Thread Simon Glass
s the case if previous stage > reserved region say somewhere in the middle and not at > the end of RAM. > > Suggested-by: Simon Glass > Signed-off-by: Devarsh Thakkar > --- > arch/arm/mach-k3/common.c | 21 + > 1 file changed, 21 insertions(+) > &g

Re: [PATCH v2 1/1] efi_loader: expose the device-tree file name

2023-10-19 Thread Simon Glass
Hi Heinrich, On Wed, 18 Oct 2023 at 02:15, Heinrich Schuchardt wrote: > > On 10/18/23 05:33, Simon Glass wrote: > > Hi Heinrich, > > > > On Tue, 17 Oct 2023 at 07:50, Heinrich Schuchardt > > wrote: > >> > >> Forward and backward compatibilit

Re: [PATCH v3 22/32] efi: Update EFI_LOADER to depend on DM_ETH

2023-10-18 Thread Simon Glass
Hi Tom, On Wed, 18 Oct 2023 at 09:27, Tom Rini wrote: > > On Wed, Oct 18, 2023 at 09:23:42AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Wed, 18 Oct 2023 at 07:37, Tom Rini wrote: > > > > > > On Mon, Oct 16, 2023 at 04:28:13PM -0600, Simon Glass wr

Re: [PATCH 2/2] bootcount: Add driver model I2C driver

2023-10-18 Thread Simon Glass
Hi Philip, On Wed, 18 Oct 2023 at 05:00, Philip Oberfichtner wrote: > > Hi Heiko, > > On Wed, Oct 18, 2023 at 06:31:57AM +0200, Heiko Schocher wrote: > > [...] > > > > May Philip can use uclass_get_device_by_phandle and try a list of > > possible UCLASS candidates, like UCLASS_RTC,

Re: [PATCH v5 4/8] rockchip: block: blk-uclass: add bounce buffer flag to blk_desc

2023-10-18 Thread Simon Glass
; drivers/block/blk-uclass.c | 4 ++-- > drivers/scsi/scsi.c| 4 > include/blk.h | 1 + > 3 files changed, 7 insertions(+), 2 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH v5 2/8] rockchip: dm: prepare rkmtd UCLASS

2023-10-18 Thread Simon Glass
art.c| 4 > drivers/block/blk-uclass.c | 1 + > include/dm/uclass-id.h | 1 + > 3 files changed, 6 insertions(+) Reviewed-by: Simon Glass

Re: [PATCH 30/32] fdt: Allow the devicetree to come from a bloblist

2023-10-18 Thread Simon Glass
Hi Ilias, On Mon, 25 Sept 2023 at 04:19, Ilias Apalodimas wrote: > > Hi Simon, > > [...] > > > > > >> +config OF_BLOBLIST > > > > >> + bool "DTB is provided by a bloblist" > > > > >> + help > > > > >> + Select this to read the devicetree from the >

Re: [PATCH v3 02/32] bootstd: Correct dependencies on CMDLINE

2023-10-18 Thread Simon Glass
Hi Tom, On Wed, 18 Oct 2023 at 08:42, Tom Rini wrote: > > On Mon, Oct 16, 2023 at 04:27:53PM -0600, Simon Glass wrote: > > With recent changes over the last few years in boot/Kconfig it is > > no-longer possible to disable CMDLINE. It results in various link > > errors be

Re: [PATCH v3 22/32] efi: Update EFI_LOADER to depend on DM_ETH

2023-10-18 Thread Simon Glass
Hi Tom, On Wed, 18 Oct 2023 at 07:37, Tom Rini wrote: > > On Mon, Oct 16, 2023 at 04:28:13PM -0600, Simon Glass wrote: > > > Since efi_device_path.c calls eth_get_dev() and assumes that Ethernet is > > available, add it as an explicit dependency. > > >

Re: [PATCH 3/5] smbios: Use SMBIOS 3.0 to support an address above 4GB

2023-10-17 Thread Simon Glass
Hi Caleb, On Tue, 17 Oct 2023 at 11:59, Caleb Connolly wrote: > > Hi Both, > > [...] > >>> > >>> @@ -513,13 +517,23 @@ ulong write_smbios_table(ulong addr) > >>>*/ > >>> table_addr = (ulong)map_sysmem(tables, 0); > >>> if (sizeof(table_addr) > sizeof(u32) && table_addr > >

Re: [PATCH] cros_ec: spi: disable annoying key echo on console

2023-10-17 Thread Simon Glass
file changed, 1 deletion(-) Reviewed-by: Simon Glass I thought a similar patch went in ages ago but I now see it was in cros_ec_i2c.c > > diff --git a/drivers/misc/cros_ec_spi.c b/drivers/misc/cros_ec_spi.c > index 001f0a85ca..7317f4b0f1 100644 > --- a/drivers/misc/cros_ec_spi.c > +++ b

Re: [PATCH v3 1/2] binman: openssl: x509: ti_secure_rom: Add support for bootcore_opts

2023-10-17 Thread Simon Glass
Hi Neha, On Tue, 17 Oct 2023 at 03:58, Neha Malcom Francis wrote: > > Hi Simon > > On 08/10/23 04:39, Simon Glass wrote: > > Hi Neha, > > > > On Fri, 6 Oct 2023 at 04:07, Neha Malcom Francis wrote: > >> > >> According to the TRMs of K3 pla

Re: [PATCH v2 1/1] efi_loader: expose the device-tree file name

2023-10-17 Thread Simon Glass
Hi Heinrich, On Tue, 17 Oct 2023 at 07:50, Heinrich Schuchardt wrote: > > Forward and backward compatibility of Linux kernel device-trees is > sometimes missing. One solution approach is to load a kernel specific > device-tree. This can either be done via a U-Boot scripts (like the one >

Re: [RESEND PATCH v1 1/2] spi: add support for Amlogic A1 SPI Flash Controller

2023-10-17 Thread Simon Glass
sertions(+) > create mode 100644 drivers/spi/meson_spifc_a1.c Reviewed-by: Simon Glass nits below > > diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig > index 854b8b88da..dedb366370 100644 > --- a/drivers/spi/Kconfig > +++ b/drivers/spi/Kconfig > @@ -251,6 +251,14 @@ config M

Re: [PATCH 2/2] bootcount: Add driver model I2C driver

2023-10-17 Thread Simon Glass
Hi Philip, On Tue, 17 Oct 2023 at 06:57, Philip Oberfichtner wrote: > > Hi Simon, > > maybe you can give me a hint on how to implement this cleanly in driver > model? > > To sum it up, I'd like to have a phandle pointing to *any* I2C device, > not knowing which UCLASS actually fits. Then the

Re: [PATCH] bootm: Fix flags used for bootargs string substitution

2023-10-17 Thread Simon Glass
Hi Piotr, On Tue, 17 Oct 2023 at 10:35, Tom Rini wrote: > > On Tue, Oct 17, 2023 at 12:53:05PM +0200, Piotr Kubik wrote: > > > Commit <51bb33846ad2> introduced a feature of bootargs > > Checkpatch will complain that this should be: > In commit 51bb33846ad2 ("bootm: Support string substitution in

Re: [PATCH v3 21/32] efi: Rearrange the Kconfig for CMD_BOOTEFI_BOOTMGR

2023-10-17 Thread Simon Glass
Hi Tom, On Tue, Oct 17, 2023, 07:13 Tom Rini wrote: > > On Mon, Oct 16, 2023 at 04:28:12PM -0600, Simon Glass wrote: > > The command should not be used to enable library functionality. Add a > > new BOOTEFI_BOOTMGR Kconfig for that. Adjust the conditions so that the >

Re: [PATCH v3 22/32] efi: Update EFI_LOADER to depend on DM_ETH

2023-10-17 Thread Simon Glass
Hi, On Tue, 17 Oct 2023 at 08:09, Tom Rini wrote: > > On Mon, Oct 16, 2023 at 04:28:13PM -0600, Simon Glass wrote: > > > Since efi_device_path.c calls eth_get_dev() and assumes that Ethernet is > > available, add it as an explicit dependency. > > >

Re: [PATCH v3 19/32] video: Dont require the font command

2023-10-17 Thread Simon Glass
Hi Tom, On Tue, 17 Oct 2023 at 08:07, Tom Rini wrote: > > On Mon, Oct 16, 2023 at 04:28:10PM -0600, Simon Glass wrote: > > While it is nice to have the font command, using 'select' makes it > > impossible to build the console code without it. Change this to use &

Re: [PATCH v3 18/32] video: Allow use without CONFIG_CMDLINE

2023-10-17 Thread Simon Glass
Hi Tom, On Tue, 17 Oct 2023 at 08:07, Tom Rini wrote: > > On Mon, Oct 16, 2023 at 04:28:09PM -0600, Simon Glass wrote: > > > Provide a fallback for when CONFIG_SYS_CBSIZE is not provided, so that > > the console can still be used. > > > > Signed-off-by: Simon G

Re: [PATCH v3 16/32] net: Depend on CONFIG_CMDLINE

2023-10-17 Thread Simon Glass
Hi Tom, On Tue, 17 Oct 2023 at 08:04, Tom Rini wrote: > > On Mon, Oct 16, 2023 at 04:28:07PM -0600, Simon Glass wrote: > > > At present it isn't possible to use networking without the command line > > enabled. Add this as a condition. > > > > Signed-off-by: Si

Re: [PATCH v4 4/8] rockchip: block: blk-uclass: disable bounce buffer support for rkmtd

2023-10-17 Thread Simon Glass
Hi Johan, On Tue, 17 Oct 2023 at 06:44, Johan Jonker wrote: > > > > On 10/16/23 23:54, Simon Glass wrote: > > Hi Johan, > > > > On Sun, 15 Oct 2023 at 16:33, Johan Jonker wrote: > >> > >> Disable bounce buffer support for rkmtd. > >>

Re: [PATCH v3 14/32] bootm: Allow building when cleanup functions are missing

2023-10-17 Thread Simon Glass
Hi Tom, On Tue, 17 Oct 2023 at 08:02, Tom Rini wrote: > > On Mon, Oct 16, 2023 at 04:28:05PM -0600, Simon Glass wrote: > > > There are two cleanup functions needed during boot which depend on > > CMD_BOOTM: bootm_disable_interrupts() and board_quiesce_devices() > >

Re: [PATCH v3 12/32] env: Split out non-command code into a new file

2023-10-17 Thread Simon Glass
Hi Tom, On Tue, 17 Oct 2023 at 07:40, Tom Rini wrote: > > On Mon, Oct 16, 2023 at 04:28:03PM -0600, Simon Glass wrote: > > > It is not possible to set environment variables without having > > CONFIG_CMD_NVEDIT enabled. When CONFIG_CMDLINE is disabled, we need a >

Re: [PATCH v3 04/32] cmd: Add a few more dependencies on CMDLINE

2023-10-17 Thread Simon Glass
Hi Tom, On Tue, 17 Oct 2023 at 07:32, Tom Rini wrote: > > On Mon, Oct 16, 2023 at 04:27:55PM -0600, Simon Glass wrote: > > > Add this to some more commands to avoid build errors with sandbox. > > > > Note that this is a temporary solution to expose more probl

Re: [PATCH v3 02/32] bootstd: Correct dependencies on CMDLINE

2023-10-17 Thread Simon Glass
Hi Tom, On Tue, 17 Oct 2023 at 07:32, Tom Rini wrote: > > On Mon, Oct 16, 2023 at 04:27:53PM -0600, Simon Glass wrote: > > > With recent changes over the last few years in boot/Kconfig it is > > no-longer possible to disable CMDLINE. It results in various link > >

Re: [PATCH] doc: build: update description of build dependencies for Alpine Linux

2023-10-17 Thread Simon Glass
On Tue, 17 Oct 2023 at 13:47, Milan P. Stanić wrote: > > --- > doc/build/gcc.rst | 24 ++-- > 1 file changed, 22 insertions(+), 2 deletions(-) > Reviewed-by: Simon Glass

Re: [PATCH 1/1] config: qemu: relax print and console buffer size

2023-10-17 Thread Simon Glass
g | 2 -- > configs/qemu-riscv64_smode_defconfig | 2 -- > configs/qemu-riscv64_spl_defconfig | 2 -- > configs/qemu-x86_64_defconfig| 1 - > configs/qemu-x86_defconfig | 1 - > configs/qemu_arm64_defconfig | 2 -- > configs/qemu_arm_defconfig | 2 -- > 11 files changed, 19 deletions(-) Reviewed-by: Simon Glass

[PATCH] mbr: Test tweaks

2023-10-16 Thread Simon Glass
/ Signed-off-by: Simon Glass --- arch/Kconfig | 2 ++ arch/sandbox/dts/test.dts | 1 + configs/sandbox_defconfig | 2 -- configs/sandbox_flattree_defconfig | 2 ++ test/boot/bootdev.c| 2 +- test/cmd/mbr.c | 13

[PATCH v3 32/32] sandbox: Add a test for disabling CONFIG_CMDLINE

2023-10-16 Thread Simon Glass
Now that everything is working, add a test to make sure that this builds correctly. Signed-off-by: Simon Glass --- Changes in v3: - Rebase on Tom's LONGHELP series - Correct 'of' typo test/py/tests/test_sandbox_opts.py | 20 1 file changed, 20 insertions(+) create mode

[PATCH v3 29/32] arm: x86: Drop discarding of command linker-lists

2023-10-16 Thread Simon Glass
Since we can now cleanly disable CMDLINE when needed, drop the rules which discard the command code. It will not be built in the first place. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Add new patch to drop discarding of command linker-lists arch/arm/cpu/u

[PATCH v3 31/32] treewide: Tidy up semicolon after command macros

2023-10-16 Thread Simon Glass
The U_BOOT_CMD_COMPLETE() macro has a semicolon at the end, perhaps inadvertently. Some code has taken advantage of this. Tidy this up by dropping the semicolon from the macro and adding it to macro invocations as required. Signed-off-by: Simon Glass --- Changes in v3: - Add new patch to tidy

[PATCH v3 30/32] mmc: env: Unify the U_BOOT_ENV_LOCATION conditions

2023-10-16 Thread Simon Glass
The declaration of U_BOOT_ENV_LOCATION() uses a different #ifdef condition from the code it calls. Use the same condition to avoid a build warning if CONFIG_CMD_SAVEENV is disabled. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Add new patch to unify

[PATCH v3 28/32] sandbox: Avoid requiring cmdline

2023-10-16 Thread Simon Glass
Use 'imply' rather than 'select' for command-related options, so that it is possible to build sandbox without CONFIG_CMDLINE enabled. Signed-off-by: Simon Glass --- Changes in v3: - Reorder the Kconfig options a little arch/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

[PATCH v3 24/32] Add a new Kconfig for command-line entry

2023-10-16 Thread Simon Glass
At present EXPO requires CMDLINE since it uses cli_readline, which is enabled by CMDLINE. It should be possible to enter lines of text to an expo without having CMDLINE available. Fix this dependency by creating a new Kconfig for cli_readline Signed-off-by: Simon Glass --- Changes in v3: - Add

[PATCH v3 23/32] cli: Split command-line-editing into its own file

2023-10-16 Thread Simon Glass
This features has buffers and code which is behind an #ifdef at present. Move it into its own file, exporting functions as needed. Drop add_idx_minus_one() since it is not used. Signed-off-by: Simon Glass --- (no changes since v1) boot/Kconfig | 3 +- common/Makefile | 7

[PATCH v3 25/32] Add a new Kconfig for command-line history

2023-10-16 Thread Simon Glass
. Signed-off-by: Simon Glass --- Changes in v3: - Add new patch with a Kconfig for command-line entry cmd/Kconfig| 15 +-- common/cli_cread.c | 24 ++-- include/cli.h | 3 ++- 3 files changed, 29 insertions(+), 13 deletions(-) diff --git a/cmd/Kconfig

[PATCH v3 26/32] sandbox: Disable CONFIG_DISTRO_DEFAULTS

2023-10-16 Thread Simon Glass
(was "run distro_bootcmd") DISTRO_DEFAULTS Note that the tools-only build has already disabled DISTRO_DEFAULTS and BOOTSTD_FULL Signed-off-by: Simon Glass --- (no changes since v1) arch/Kconfig | 5 + boot/Kconfig | 6 +++--

[PATCH v3 27/32] cmd: Make all commands depend on CMDLINE

2023-10-16 Thread Simon Glass
If this option is disabled, commands should not be available. Convert the CMDLINE option into a menuconfig and make every command in cmd/Kconfig depend on it. Signed-off-by: Simon Glass --- (no changes since v1) cmd/Kconfig | 31 +-- 1 file changed, 9 insertions

[PATCH v3 16/32] net: Depend on CONFIG_CMDLINE

2023-10-16 Thread Simon Glass
At present it isn't possible to use networking without the command line enabled. Add this as a condition. Signed-off-by: Simon Glass Reviewed-by: Ramon Fried --- (no changes since v1) cmd/Kconfig | 1 + net/Kconfig | 1 + 2 files changed, 2 insertions(+) diff --git a/cmd/Kconfig b/cmd

[PATCH v3 18/32] video: Allow use without CONFIG_CMDLINE

2023-10-16 Thread Simon Glass
Provide a fallback for when CONFIG_SYS_CBSIZE is not provided, so that the console can still be used. Signed-off-by: Simon Glass --- (no changes since v1) drivers/video/console_truetype.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/video/console_truetype.c b/drivers/video

[PATCH v3 10/32] Move bootmenu_conv_key() into its own file

2023-10-16 Thread Simon Glass
This conversion function is used by expo which does not require CMDLINE. The menu feature does require CMDLINE. Move the function into a separate file so that it can be used even when CMDLINE is not enabled. Signed-off-by: Simon Glass --- (no changes since v1) common/Makefile| 2

[PATCH v3 17/32] log: Allow use without CONFIG_CMDLINE

2023-10-16 Thread Simon Glass
When CONFIG_SYS_CBSIZE is not used we need an alternative. For logging it seems that CONFIG_SYS_PBSIZE is a better choice anyway, so update this. Signed-off-by: Simon Glass --- (no changes since v1) common/log.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common

[PATCH v3 21/32] efi: Rearrange the Kconfig for CMD_BOOTEFI_BOOTMGR

2023-10-16 Thread Simon Glass
The command should not be used to enable library functionality. Add a new BOOTEFI_BOOTMGR Kconfig for that. Adjust the conditions so that the same code is built. Signed-off-by: Simon Glass Suggested-by: AKASHI Takahiro --- Changes in v3: - Add new patch to rearrange the Kconfig

[PATCH v3 22/32] efi: Update EFI_LOADER to depend on DM_ETH

2023-10-16 Thread Simon Glass
Since efi_device_path.c calls eth_get_dev() and assumes that Ethernet is available, add it as an explicit dependency. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Add new patch to update EFI_LOADER to depend on DM_ETH lib/efi_loader/Kconfig | 1 + 1 file changed, 1

[PATCH v3 20/32] efi: Make commands depend on CMDLINE

2023-10-16 Thread Simon Glass
Most of the EFI functionality requires the command line, so make this explicit. Future work could adjust this, but it needs effort within the booting support first, like the bootm command. Signed-off-by: Simon Glass Suggested-by: AKASHI Takahiro --- (no changes since v2) Changes in v2

[PATCH v3 19/32] video: Dont require the font command

2023-10-16 Thread Simon Glass
While it is nice to have the font command, using 'select' makes it impossible to build the console code without it. Change this to use 'imply' instead. Signed-off-by: Simon Glass --- (no changes since v1) drivers/video/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v3 15/32] fdt: Move working_fdt into fdt_support

2023-10-16 Thread Simon Glass
This can be accessed even when commands are not enabled. Move it into the fdt_support.c file, which is where most of the FDT helpers are. Signed-off-by: Simon Glass --- (no changes since v1) boot/fdt_support.c | 5 + cmd/fdt.c | 5 - 2 files changed, 5 insertions(+), 5

[PATCH v3 11/32] pxe: Depend on CMDLINE

2023-10-16 Thread Simon Glass
We cannot use PXE or sysboot commands without CONFIG_CMDLINE so add the required condition. Signed-off-by: Simon Glass --- (no changes since v1) cmd/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cmd/Kconfig b/cmd/Kconfig index 00a7f84bce99..18be3da972d2 100644 --- a/cmd

[PATCH v3 14/32] bootm: Allow building when cleanup functions are missing

2023-10-16 Thread Simon Glass
There are two cleanup functions needed during boot which depend on CMD_BOOTM: bootm_disable_interrupts() and board_quiesce_devices() Provide static inline versions of these for when commands are not enabled. Signed-off-by: Simon Glass --- (no changes since v1) arch/arm/lib/bootm.c | 2

[PATCH v3 12/32] env: Split out non-command code into a new file

2023-10-16 Thread Simon Glass
will be dropped at link time. Update the Makefile rule to only include the env commands when CONFIG_CMD_NVEDIT is enabled. Signed-off-by: Simon Glass --- (no changes since v1) cmd/Makefile | 2 +- cmd/nvedit.c | 122 ++--- env/Makefile

[PATCH v3 13/32] console: Move SYS_PBSIZE into common/

2023-10-16 Thread Simon Glass
This relates to printing output and does not need a command line. Move it next to the other console-related options. Signed-off-by: Simon Glass --- (no changes since v1) cmd/Kconfig| 5 - common/Kconfig | 5 + 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/cmd

[PATCH v3 09/32] cmd: Use an #ifdef around run_commandf()

2023-10-16 Thread Simon Glass
This is not available if CMDLINE is disabled, so add an #ifdef to correct this. Signed-off-by: Simon Glass --- (no changes since v1) common/cli.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/common/cli.c b/common/cli.c index 3916a7b10a7d..4d0fea4387f2 100644 --- a/common/cli.c +++ b

[PATCH v3 06/32] sifive: Drop an unnecessary #ifdef

2023-10-16 Thread Simon Glass
This code is normally compiled for sifive, but sandbox can also compile it. We should not use UNIT_TEST as a synonym for SANDBOX, since it is possible to disable UNIT_TEST for sandbox. Drop the condition since it isn't needed. Signed-off-by: Simon Glass Suggested-by: Sean Anderson --- Changes

[PATCH v3 08/32] cli: Always build cli_getch

2023-10-16 Thread Simon Glass
This module is used for user input with menus, not just with the command line. Compile it always, so it is available even when CMDLINE is disabled. Signed-off-by: Simon Glass --- (no changes since v1) common/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/common

[PATCH v3 04/32] cmd: Add a few more dependencies on CMDLINE

2023-10-16 Thread Simon Glass
Add this to some more commands to avoid build errors with sandbox. Note that this is a temporary solution to expose more problems. A later patch puts these behind an 'if CMDLINE' Signed-off-by: Simon Glass --- Changes in v3: - Add an explation as to why this patch is here cmd/Kconfig | 6

[PATCH v3 07/32] fastboot: Declare a dependency on CMDLINE

2023-10-16 Thread Simon Glass
When CMDLINE is not enabled, this code fails to build. Correct this by adding a condition. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Change this to use a Kconfig dependency instead of code failing drivers/fastboot/Kconfig | 1 + 1 file changed, 1 insertion

[PATCH v3 05/32] test: Make UNIT_TEST depend on CMDLINE

2023-10-16 Thread Simon Glass
Many tests make some use of the command line, so require it for all test code. This could be teased apart, perhaps with a test flag indicating that it uses the command line. Leave that for later. Signed-off-by: Simon Glass Reviewed-by: Tom Rini --- Changes in v3: - Fix 'ut' typo test

[PATCH v3 03/32] autoboot: Correct dependencies on CMDLINE

2023-10-16 Thread Simon Glass
Make AUTOBOOT depend on CMDLINE since it is mostly meaningless without it. Signed-off-by: Simon Glass Reviewed-by: Tom Rini --- (no changes since v2) Changes in v2: - Move AUTOBOOT_USE_MENUKEY under AUTOBOOT boot/Kconfig | 29 +++-- 1 file changed, 19 insertions

[PATCH v3 02/32] bootstd: Correct dependencies on CMDLINE

2023-10-16 Thread Simon Glass
be better to have all commands depend on CMDLINE, but that is extremely difficult at present, since some functions use CMD_xxx to enable feature xxx. For example networking and environment have a number of problems to tease apart. Signed-off-by: Simon Glass --- Changes in v3: - Reword commit

[PATCH v3 01/32] buildman: Use oldconfig when adjusting the config

2023-10-16 Thread Simon Glass
We cannot be sure that the new config is consistent, particularly when changing a major item like CONFIG_CMDLINE. Use 'make oldconfig' to check that and avoid any such problems. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builder.py | 2 +- tools/buildman

[PATCH v3 00/32] Tidy up use of CONFIG_CMDLINE

2023-10-16 Thread Simon Glass
on DM_ETH - Add new patch to drop discarding of command linker-lists - Add new patch to unify the U_BOOT_ENV_LOCATION conditions Simon Glass (32): buildman: Use oldconfig when adjusting the config bootstd: Correct dependencies on CMDLINE autoboot: Correct dependencies on CMDLINE cmd: Add

Re: [PATCH v7 2/2] schemas: Add some common reserved-memory usages

2023-10-16 Thread Simon Glass
Hi Rob, On Mon, 16 Oct 2023 at 10:50, Rob Herring wrote: > > On Fri, Oct 13, 2023 at 4:09 PM Simon Glass wrote: > > > > Hi Rob, > > > > On Fri, 13 Oct 2023 at 13:42, Rob Herring wrote: > > > > > > On Fri, Oct 6, 2023 at 7:03 PM Simon Glass wrote

Re: [PATCH v2 2/2] serial: introduce CONFIG_CONSOLE_FLUSH_ON_NEWLINE

2023-10-16 Thread Simon Glass
elides _serial_flush(), but it won't warn about it being > unused. > > Signed-off-by: Rasmus Villemoes > --- > common/Kconfig | 10 ++ > drivers/serial/serial-uclass.c | 8 ++-- > 2 files changed, 16 insertions(+), 2 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH v4 4/8] rockchip: block: blk-uclass: disable bounce buffer support for rkmtd

2023-10-16 Thread Simon Glass
Hi Johan, On Sun, 15 Oct 2023 at 16:33, Johan Jonker wrote: > > Disable bounce buffer support for rkmtd. > > Signed-off-by: Johan Jonker > Reviewed-by: Kever Yang > --- > > Changed V3: > New patch > --- > drivers/block/blk-uclass.c | 6 +++--- > 1 file changed, 3 insertions(+), 3

Re: [PATCH v5 2/6] cmd: Add a sysinfo command

2023-10-16 Thread Simon Glass
Hi Detlev, On Mon, 16 Oct 2023 at 08:21, Detlev Casanova wrote: > > On Monday, October 2, 2023 2:56:28 P.M. EDT Simon Glass wrote: > > On Mon, 2 Oct 2023 at 09:21, Detlev Casanova > > > > wrote: > > > The command is able to show different information for the ru

Re: [PATCH v4 2/8] rockchip: dm: prepare rkmtd UCLASS

2023-10-16 Thread Simon Glass
art.c| 4 > drivers/block/blk-uclass.c | 1 + > include/dm/uclass-id.h | 1 + > 3 files changed, 6 insertions(+) Reviewed-by: Simon Glass

Re: [PATCH v7 1/2] schemas: memory: Add ECC properties

2023-10-16 Thread Simon Glass
Hi Rob, On Mon, 16 Oct 2023 at 13:57, Rob Herring wrote: > > On Tue, Sep 26, 2023 at 01:42:38PM -0600, Simon Glass wrote: > > Some memories provide ECC detection and/or correction. For software which > > wants to check memory, it is helpful to see which regions provid

Re: [PATCH v2] cmd: mbr: Allow 4 MBR partitions without need for extended

2023-10-16 Thread Simon Glass
Hi, On Mon, 16 Oct 2023 at 10:14, Tom Rini wrote: > > On Mon, Oct 09, 2023 at 01:24:36AM +, Alexander Gendin wrote: > > > Current code allows up to 3 MBR partitions without extended one. > > If more than 3 partitions are required, then extended partition(s) > > must be used. > > This commit

Re: [PATCH v2 17/29] net: bootp: Fall back to BOOTP from DHCP when unit testing

2023-10-15 Thread Simon Glass
t;> shouldn't try to send a DHCPREQUEST packet, since it won't be DHCPACKed. > >> Transition straight to BIND. This is only enabled for UNIT_TEST to avoid > >> bloat, since I suspect the number of BOOTP servers in the wild is > >> vanishingly small.

Re: [PATCH 1/2] command.h: Add a U_BOOT_LONGHELP macro

2023-10-15 Thread Simon Glass
Hi Tom, On Sat, 7 Oct 2023 at 13:13, Tom Rini wrote: > > In order to be able to discard unused long help texts without further > linker lists, add a macro for defining the long help messages which uses > __maybe_unused. This allows us to discard them as unreferenced as part > of the link. > >

Re: [PATCH v3] rockchip: configs: sandbox: enable rkmtd command

2023-10-15 Thread Simon Glass
, 2 insertions(+) Reviewed-by: Simon Glass

[PATCH 3/6] binman: Ensure attributes always come last in the metadata

2023-10-15 Thread Simon Glass
no data will follow the attributes. This mirrors commit f0cc7adb2f in coreboot. Signed-off-by: Simon Glass --- tools/binman/cbfs_util.py | 46 --- 1 file changed, 24 insertions(+), 22 deletions(-) diff --git a/tools/binman/cbfs_util.py b/tools/binman/cbfs_util.py

Re: [PATCH v3 6/7] rockchip: test: dm: add rkmtd test

2023-10-15 Thread Simon Glass
t/dm/rkmtd.c | 201 +++++++ > > 2 files changed, 202 insertions(+) > > create mode 100644 test/dm/rkmtd.c Reviewed-by: Simon Glass nits below > > > > diff --git a/test/dm/Makefile b/test/dm/Makefile > > index 7ed00733c1a6..a5e

[PATCH 6/6] binman: Move stage header into a CBFS attribute

2023-10-15 Thread Simon Glass
cbfsutil completely changed the way that stages are formatted in CBFS. Adjust the binman implementation to do the same. This mirrors commit 81dc20e744 in coreboot. Signed-off-by: Simon Glass --- tools/binman/cbfs_util.py | 64 +- tools/binman

Re: [PATCH v1] drivers: don't compile Secure Monitor UCLASS unconditionally

2023-10-15 Thread Simon Glass
uclass") > > Signed-off-by: Alexey Romanov > --- > drivers/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Simon Glass

[PATCH v2 6/6] smbios: Require the caller to align the SMBIOS table

2023-10-15 Thread Simon Glass
All callers handle this alignment, so drop the unnecessary code. This simplifies things a little. Signed-off-by: Simon Glass --- (no changes since v1) include/smbios.h | 5 + lib/smbios.c | 2 -- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/include/smbios.h b/include

[PATCH 5/6] binman: Rename TYPE_STAGE to TYPE_LEGACY_STAGE

2023-10-15 Thread Simon Glass
In preparation for changing how stages are stored, rename the existing stage tag. Signed-off-by: Simon Glass --- cmd/cbfs.c | 2 +- include/cbfs.h | 2 +- tools/binman/cbfs_util.py | 12 ++-- tools/binman/cbfs_util_test.py | 3 ++- 4 files

Re: [RESEND PATCH v3 0/3] rpi: Convert to standard boot

2023-10-15 Thread Simon Glass
Hi Peter, On Tue, 10 Oct 2023 at 08:58, Simon Glass wrote: > > Hi Peter, > > On Sun, 8 Oct 2023 at 14:20, Simon Glass wrote: > > > > Hi Peter, > > > > On Sun, 8 Oct 2023 at 12:02, Peter Robinson wrote: > > > > > > Hi Simon, > > &g

Re: [PATCH v2 24/29] test: spl: Add functions to create filesystems

2023-10-15 Thread Simon Glass
| 306 +++ > 5 files changed, 328 insertions(+) > create mode 100644 test/image/spl_load_fs.c Reviewed-by: Simon Glass

[PATCH v2 5/6] efi: Use the correct GUID for the SMBIOS table

2023-10-15 Thread Simon Glass
EFI does not use the 'anchor string' to determine the SMBIOS table version, instead preferring to have two separate GUIDs. Use the correct one, depending on the table version. Call unmap_system() to balance to the use of map_sysmem() Signed-off-by: Simon Glass --- Changes in v2: - Add a note

<    9   10   11   12   13   14   15   16   17   18   >