[PATCH v2 1/3] dt-bindings: mtd: fixed-partitions: Add binman compatible

2023-10-02 Thread Simon Glass
Add a compatible string for binman, so we can extend fixed-partitions in various ways. Signed-off-by: Simon Glass --- Changes in v2: - Drop mention of 'enhanced features' in fixed-partitions.yaml - Mention Binman input and output properties - Use plain partition@xxx for the node name

Re: [PATCH] scripts/Makefile.lib: also consider $(CONFIG_SYS_BOARD)-u-boot.dtsi

2023-10-02 Thread Simon Glass
Hi Tom, On Mon, 2 Oct 2023 at 09:12, Tom Rini wrote: > > On Mon, Oct 02, 2023 at 08:43:41AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Mon, 2 Oct 2023 at 08:09, Tom Rini wrote: > > > > > > On Sun, Oct 01, 2023 at 07:17:27PM -0600, Simon Glass wro

Re: [PATCHv10 01/15] submodule: add lwIP as git submodule

2023-10-02 Thread Simon Glass
oot-tpm/tools/binman/state.py", line >> 14, in >> from dtoc import fdt >> File "/builds/u-boot/custodians/u-boot-tpm/tools/dtoc/fdt.py", line 14, in >> >> from libfdt import QUIET_NOTFOUND >> ImportError: cannot import name 'QUIET_NOTF

Re: [PATCH] scripts/Makefile.lib: also consider $(CONFIG_SYS_BOARD)-u-boot.dtsi

2023-10-02 Thread Simon Glass
Hi Tom, On Mon, 2 Oct 2023 at 08:09, Tom Rini wrote: > > On Sun, Oct 01, 2023 at 07:17:27PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Fri, 29 Sept 2023 at 10:02, Tom Rini wrote: > > > > > > On Fri, Sep 29, 2023 at 09:15:00AM -

Re: [RFC PATCH v2 4/8] binman: k3: add k3-security.h and include it in k3-binman.dtsi

2023-10-01 Thread Simon Glass
s/k3-binman.dtsi | 2 ++ > arch/arm/dts/k3-security.h | 58 > + > 2 files changed, 60 insertions(+) > Reviewed-by: Simon Glass nits below > diff --git a/arch/arm/dts/k3-binman.dtsi b/arch/arm/dts/k3-binman.dtsi > index 2ea2dd18a12b..71ff

Re: [PATCH] scripts/Makefile.lib: also consider $(CONFIG_SYS_BOARD)-u-boot.dtsi

2023-10-01 Thread Simon Glass
Hi Tom, On Fri, 29 Sept 2023 at 10:02, Tom Rini wrote: > > On Fri, Sep 29, 2023 at 09:15:00AM -0600, Simon Glass wrote: > > Hi Rasmus, > > > > On Mon, 25 Sept 2023 at 13:05, Rasmus Villemoes > > wrote: > > > > > > On 25/09/2023 20.19, Tom Rini w

Re: [PATCH 1/2] image-host: add a check of the return value of snprintf.

2023-10-01 Thread Simon Glass
Hi Hugo, On Wed, 27 Sept 2023 at 06:24, Hugo Cornelis wrote: > Please add a commit message > --- > tools/image-host.c | 27 ++- > 1 file changed, 26 insertions(+), 1 deletion(-) > > diff --git a/tools/image-host.c b/tools/image-host.c > index a6b0a94420..0c92a2ddeb

Re: [PATCH v2 30/32] fdt: Allow the devicetree to come from a bloblist

2023-10-01 Thread Simon Glass
Hi Ilias, On Tue, 26 Sept 2023 at 07:13, Ilias Apalodimas wrote: > > Hi Simon, > > [...] > > > > > > > > > > > So, instead of adding OF_BLOBLIST, just move this code under OF_BOARD, > > > > > inside an IS_ENABLED(BLOBLIST) check. If a bloblist is required and > > > > > the previous stage loader

Re: [PATCH 02/15] cmd: host: Mandate the filename parameter in the 'bind' command

2023-10-01 Thread Simon Glass
useful. > > Signed-off-by: Bin Meng > --- > > cmd/host.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Reviewed-by: Simon Glass

Re: [PATCH v5 13/16] test: dm: add SCMI base protocol test

2023-10-01 Thread Simon Glass
e code for dynamically allocated vendor/agent names > v2 > * use helper functions, removing direct uses of ops > --- > test/dm/scmi.c | 111 +++++ > 1 file changed, 111 insertions(+) > Reviewed-by: Simon Glass

Re: [PATCH v5 04/16] test: dm: add protocol-specific channel test

2023-10-01 Thread Simon Glass
; arch/sandbox/dts/test.dts | 1 + > test/dm/scmi.c| 20 ++-- > 2 files changed, 19 insertions(+), 2 deletions(-) > Reviewed-by: Simon Glass

Re: [PATCH 2/2] image-host: increase path length when setting up the cipher.

2023-10-01 Thread Simon Glass
On Wed, 27 Sept 2023 at 06:24, Hugo Cornelis wrote: > > --- > tools/image-host.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass but please add commit message (always) > > diff --git a/tools/image-host.c b/tools/image-host.c > index 0

Re: [PATCH 4/4] test: dm: add SCMI power domain protocol test

2023-10-01 Thread Simon Glass
++- > 1 file changed, 106 insertions(+), 1 deletion(-) > Reviewed-by: Simon Glass

Re: [PATCH 3/4] sandbox: add SCMI power domain protocol support for testing

2023-10-01 Thread Simon Glass
+ > 5 files changed, 301 insertions(+), 1 deletion(-) Reviewed-by: Simon Glass nit below > > diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts/test.dts > index 36de6a37cf6d..38fcf42cd23d 100644 > --- a/arch/sandbox/dts/test.dts > +++ b/arch/sandbox/dts/test.dts > @@ -

Re: [PATCH 5/4] mkimage: update man page and -h output

2023-10-01 Thread Simon Glass
the header is of course at offset 0, which has all > possible alignments already.) > > Reported-by: Sean Anderson > Signed-off-by: Rasmus Villemoes > --- > doc/mkimage.1 | 6 -- > tools/mkimage.c | 2 +- > 2 files changed, 5 insertions(+), 3 deletions(-) Reviewed-by: Simon Glass Strange that your patch says 5/4

Re: [PATCH v5 11/16] firmware: scmi: add a check against availability of protocols

2023-10-01 Thread Simon Glass
> v3 > * new; import this patch from my followup patch set > --- > drivers/firmware/scmi/scmi_agent-uclass.c | 41 +-- > 1 file changed, 38 insertions(+), 3 deletions(-) > Reviewed-by: Simon Glass

Re: [PATCH v5 03/16] firmware: scmi: support dummy channels for sandbox agent

2023-10-01 Thread Simon Glass
--- > arch/sandbox/include/asm/scmi_test.h | 13 > drivers/firmware/scmi/sandbox-scmi_agent.c | 90 ++ > 2 files changed, 103 insertions(+) > Reviewed-by: Simon Glass

Re: [RFC PATCH v2 2/8] binman: ti-secure: Add support for firewalling entities

2023-10-01 Thread Simon Glass
Hi Manorit, On Tue, 26 Sept 2023 at 01:58, Manorit Chawdhry wrote: > > We can now firewall entities while loading them through our secure > entity TIFS, the required information should be present in the > certificate that is being parsed by TIFS. > > The following commit adds the support to

Re: [PATCH 12/15] cmd: blk_common: Stop using hard-coded block size for Sandbox operations

2023-10-01 Thread Simon Glass
k size for both > Sandbox host device and blkmap driver, let's stop using the hard-coded > block size. > > Signed-off-by: Bin Meng > --- > > cmd/blk_common.c | 20 ++-- > 1 file changed, 14 insertions(+), 6 deletions(-) > Reviewed-by: Simon Glass

Re: [PATCH 06/15] cmd: host: Print out the block size of the host device

2023-10-01 Thread Simon Glass
--- > 2 files changed, 14 insertions(+), 13 deletions(-) > Reviewed-by: Simon Glass

Re: [RFC PATCH v2 1/8] dtoc: openssl: Add GetHexOctet method

2023-10-01 Thread Simon Glass
Hi Manorit, On Tue, 26 Sept 2023 at 01:58, Manorit Chawdhry wrote: > > HexOctet format is used by openssl for FORMAT:HEX,OCT property in x509 > certificates. Add a helper function to extract the integer numbers in > HEX,OCT format to pass to openssl directly. > > Signed-off-by: Manorit Chawdhry

Re: [RFC PATCH v2 3/8] binman: ftest: Add test for ti-secure firewall node

2023-10-01 Thread Simon Glass
ure_firewall.dts | 28 > > 2 files changed, 40 insertions(+) > Reviewed-by: Simon Glass

Re: [PATCH 05/15] blk: host_dev: Sanity check on the size of host backing file

2023-10-01 Thread Simon Glass
On Tue, 26 Sept 2023 at 02:49, Bin Meng wrote: > > Since we are emulating a block device, its size should be multiple > of the configured block size. > > Signed-off-by: Bin Meng > --- > > drivers/block/host_dev.c | 5 + > 1 file changed, 5 insertions(+) > Reviewed-by: Simon Glass

Re: [PATCH 04/15] blk: host_dev: Make host_sb_detach_file() and host_sb_ops static

2023-10-01 Thread Simon Glass
On Tue, 26 Sept 2023 at 02:48, Bin Meng wrote: > > They are only used in drivers/block/host_dev.c. > > Signed-off-by: Bin Meng > --- > > drivers/block/host_dev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Simon Glass

Re: [PATCH 10/15] cmd: blk_common: Use macros for the return values

2023-10-01 Thread Simon Glass
Hi Bin, On Tue, 26 Sept 2023 at 02:54, Bin Meng wrote: > > Avoid using magic number 0/1 for the command result. > > Signed-off-by: Bin Meng > --- > > cmd/blk_common.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/cmd/blk_common.c b/cmd/blk_common.c >

Re: [PATCH 14/15] disk: part: Print out the unknown device uclass id

2023-10-01 Thread Simon Glass
On Tue, 26 Sept 2023 at 04:09, Bin Meng wrote: > > It's helpful to output the device uclass id for unknown devices > during the debugging process. > > Signed-off-by: Bin Meng > --- > > disk/part.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass

Re: [PATCH 01/15] blk: Use a macro for the typical block size

2023-10-01 Thread Simon Glass
mv.c| 3 ++- > drivers/ata/sata_sil.c | 3 ++- > drivers/block/blkmap.c | 2 +- > drivers/block/host_dev.c | 2 +- > drivers/mmc/mmc-uclass.c | 2 +- > drivers/nvme/nvme.c | 2 +- > include/blk.h| 2 ++ > 10 files changed, 16 insertions(+), 10 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH v2 1/2] binman: openssl: x509: ti_secure_rom: Add support for bootcore_opts

2023-10-01 Thread Simon Glass
Hi Neha, On Tue, 26 Sept 2023 at 22:08, Neha Malcom Francis wrote: > > According to the TRMs of K3 platform of devices, the ROM boot image > format specifies a "Core Options Field" that provides the capability to > set the boot core in lockstep when set to 0 or to split mode when set > to 2. Add

Re: [PATCH v3 4/4] malloc: Enable SYS_MALLOC_RUNTIME_INIT by default in SPL

2023-10-01 Thread Simon Glass
> least 16k of BSS. > > Signed-off-by: Sean Anderson > --- > > Changes in v3: > - Don't enable SPL_SYS_MALLOC_RUNTIME_INIT if we are short on BSS > > Kconfig | 11 +++ > 1 file changed, 11 insertions(+) > Reviewed-by: Simon Glass

Re: [PATCH 2/5] core: return FDT_ADDR_T_NONE from devfdt_get_addr_[size_]name() on errors

2023-10-01 Thread Simon Glass
U-Boot only check for FDT_ADDR_T_NONE; let's adjust the > error return to match the expectation. > > Signed-off-by: Matthias Schiffer > --- > drivers/core/fdtaddr.c | 4 ++-- > include/dm/fdtaddr.h | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > Reviewed-by: Simon Glass

Re: [PATCH 09/15] blk: blkmap: Support mapping to device of any block size

2023-10-01 Thread Simon Glass
gt; drivers/block/blkmap.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Simon Glass

Re: [PATCHv10 10/15] net/lwip: add lwIP configuration

2023-10-01 Thread Simon Glass
0644 net/lwip/lwipopts.h Reviewed-by: Simon Glass

Re: [PATCH 1/2] dm: serial: fix serial_post_probe()

2023-10-01 Thread Simon Glass
7d92753d4ca ("dm: Add a uclass for serial devices") > Signed-off-by: Heinrich Schuchardt > --- > drivers/serial/serial-uclass.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass

Re: [PATCH 2/2] stdio: fix stdio_deregister_dev()

2023-10-01 Thread Simon Glass
--- > include/stdio_dev.h | 3 ++- > 2 files changed, 5 insertions(+), 4 deletions(-) > Reviewed-by: Simon Glass

Re: [PATCH v2 2/3] dm: prepare rkmtd UCLASS

2023-10-01 Thread Simon Glass
Hi Johan, On Thu, 28 Sept 2023 at 12:51, Johan Jonker wrote: > > Prepare a rkmtd UCLASS in use for writing Rockchip boot blocks > in combination with existing userspace tools and rockusb command. > > Signed-off-by: Johan Jonker > Reviewed-by: Kever Yang > --- > disk/part.c| 4

Re: [PATCH v2 1/3] common: add prototype & rename populate_serial_number()

2023-10-01 Thread Simon Glass
gned-off-by: Artur Rojek > --- > > v2: - rename the function > - move function documentation from .c file to the prototype location > > cmd/tlv_eeprom.c | 14 +- > include/init.h | 14 ++ > 2 files changed, 15 insertions(+), 13 deletions(-) Reviewed-by: Simon Glass

Re: [PATCHv10 15/15] net/lwip: split net.h to net.h, arp.h and eth.h

2023-10-01 Thread Simon Glass
lude/net/arp.h > create mode 100644 include/net/eth.h Reviewed-by: Simon Glass Please void typedef [..] > -/** > - * struct eth_ops - functions of Ethernet MAC controllers > - * > - * start: Prepare the hardware to send and receive packets > - * send: Send the bytes passed

Re: [PATCH] linker_list: Fix ll_entry_get alignment

2023-10-01 Thread Simon Glass
Hi Sean, On Sat, 30 Sept 2023 at 09:23, Sean Anderson wrote: > > On 9/30/23 10:36, Sean Anderson wrote: > > When ll_entry_get is used on a list entry ll_entry_declare'd in the same > > file, the lack of alignment on the access will override the > > ll_entry_declare alignment. This causes GCC to

Re: bootstd: Scanning for USB bootflow will remove existing SCSI bootflow

2023-10-01 Thread Simon Glass
Hi Tony, On Tue, 26 Sept 2023 at 13:40, Tony Dinh wrote: > > Hi Simon, > > On Tue, Sep 26, 2023 at 4:37 AM Simon Glass wrote: > > > > Hi Tony, > > > > On Mon, 25 Sept 2023 at 14:02, Tony Dinh wrote: > > > > > > Hi Simon, > > > &

Re: [PATCHv10 12/15] net/lwip: update .gitignore with lwIP

2023-10-01 Thread Simon Glass
On Tue, 26 Sept 2023 at 03:45, Maxim Uvarov wrote: > > ignore lwIP library code and reused files from the lwIP. > > Signed-off-by: Maxim Uvarov > --- > net/lwip/.gitignore | 8 > 1 file changed, 8 insertions(+) > create mode 100644 net/lwip/.gitignore Reviewed-by: Simon Glass

Re: [PATCHv10 14/15] net/lwip: replace original net commands with lwip

2023-10-01 Thread Simon Glass
cmd/net.c | 86 + > cmd/pxe.c | 19 +- > include/net.h | 8 +++-- > include/net/ulwip.h | 64 + > 6 files changed, 113 insertions(+), 103 deletions(-) > create mode 100644 include/net/ulwip.h Reviewed-by: Simon Glas

Re: [PATCH v2] dm: core: Report bootph-pre-ram/sram node as pre-reloc after relocation : regression

2023-10-01 Thread Simon Glass
elocation phase. > > >>> Also update the ofnode_pre_reloc documentation to closer reflect the > > >>> binding and driver model documentation. > > >>> > > >>> This changes behavior of what nodes are bound in the U-Boot proper >

Re: [PATCH 5/5] treewide: use dev_read_addr_*_ptr() where appropriate

2023-10-01 Thread Simon Glass
> drivers/mailbox/k3-sec-proxy.c| 18 +- > drivers/phy/allwinner/phy-sun4i-usb.c | 12 ++-- > drivers/phy/phy-bcm-sr-pcie.c | 4 ++-- > drivers/ram/k3-am654-ddrss.c | 20 ++-- > drivers/ram/k3-ddrss/k3-ddrss.c | 23 ++- > drivers/soc/ti/k3-navss-ringacc.c | 12 ++-- > 9 files changed, 55 insertions(+), 59 deletions(-) > Reviewed-by: Simon Glass

Re: [PATCHv10 08/15] net/lwip: implement wget cmd

2023-10-01 Thread Simon Glass
ile > create mode 100644 net/lwip/apps/http/lwip-wget.c > Reviewed-by: Simon Glass

Re: [PATCHv10 06/15] net/lwip: implement dhcp cmd

2023-10-01 Thread Simon Glass
t; --- > include/net/lwip.h | 12 + > net/lwip/Makefile | 1 + > net/lwip/apps/dhcp/lwip-dhcp.c | 85 ++ > 3 files changed, 98 insertions(+) > create mode 100644 net/lwip/apps/dhcp/lwip-dhcp.c Reviewed-by: Simon Glass wit

Re: [PATCHv10 13/15] net/lwip: connection between cmd and lwip apps

2023-10-01 Thread Simon Glass
On Tue, 26 Sept 2023 at 03:45, Maxim Uvarov wrote: > > Signed-off-by: Maxim Uvarov > --- > cmd/Makefile | 1 + > cmd/net-lwip.c | 286 + > 2 files changed, 287 insertions(+) > create mode 100644 cmd/net-lwip.c > Reviewed-by: Simon Glass

Re: [PATCH] Revert "fs: ext4: check the minimal partition size to mount"

2023-10-01 Thread Simon Glass
-- > > fs/ext4/ext4_common.c | 4 > 1 file changed, 4 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH 13/15] dm: blk: Drop blk_{read,write}_devnum()

2023-10-01 Thread Simon Glass
ude/blk.h | 26 -- > 2 files changed, 55 deletions(-) > Reviewed-by: Simon Glass

Re: [PATCH 08/15] cmd: blkmap: Make map_handlers[] and its .fn static

2023-10-01 Thread Simon Glass
On Tue, 26 Sept 2023 at 02:52, Bin Meng wrote: > > These are only used in cmd/blkmap.c. > > Signed-off-by: Bin Meng > --- > > cmd/blkmap.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH 1/5] core: fix doc comments of dev_read_addr*() and related functions

2023-10-01 Thread Simon Glass
y: Matthias Schiffer > --- > include/dm/fdtaddr.h | 12 ++-- > include/dm/read.h| 6 +++--- > 2 files changed, 9 insertions(+), 9 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH] mkimage: allow internalization of data-position

2023-10-01 Thread Simon Glass
ze %x\n", len); > > - ret = fdt_setprop(fdt, node, "data", > - old_fdt + data_base + buf_ptr, len); > + ret = fdt_setprop(fdt, node, FIT_DATA_PROP, data, len); > + ret = fdt_delprop(fdt, node, ext_data_prop); > + > if (ret) { > debug("%s: Failed to write property: %s\n", __func__, > fdt_strerror(ret)); > -- > 2.34.1 > This bit: Reviewed-by: Simon Glass Can you add some docs about this, e.g. to mkimage.1 ? Regards, Simon

Re: [PATCH v3 0/4] malloc: Reduce size by initializing data at runtime

2023-10-01 Thread Simon Glass
Hi Sean, On Thu, 28 Sept 2023 at 08:45, Sean Anderson wrote: > > In my efforts to get SPL to fit into flash after some changes I made, I > noticed that av_ is one of the largest variables in SPL. As it turns > out, we can generate it at runtime, and the code is already there. This > has the

Re: [PATCH 15/15] disk: part: Handle blkmap device in print_part_header()

2023-10-01 Thread Simon Glass
On Tue, 26 Sept 2023 at 04:10, Bin Meng wrote: > > Print out the blkmap device type when showing partition header for > a blkmap device. > > Signed-off-by: Bin Meng > > --- > > disk/part.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Simon Glass

Re: [PATCH 11/15] dm: blk: Rename get_desc() and make it externally visible

2023-10-01 Thread Simon Glass
ude/blk.h | 12 > 2 files changed, 20 insertions(+), 18 deletions(-) > Reviewed-by: Simon Glass

Re: [PATCH 07/15] blk: blkmap: Make bind/unbind routines static

2023-10-01 Thread Simon Glass
On Tue, 26 Sept 2023 at 02:51, Bin Meng wrote: > > These 2 are only used in drivers/block/blkmap.c. > > Signed-off-by: Bin Meng > --- > > drivers/block/blkmap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Simon Glass

[PATCH 32/34] x86: coreboot: Add a command to check and update CMOS RAM

2023-10-01 Thread Simon Glass
Coreboot tables provide information about the CMOS-RAM checksum. Add a command which can check and update this. With this it is possible to adjust CMOS-RAM settings and tidy up the checksum afterwards. Signed-off-by: Simon Glass --- cmd/Kconfig | 11 +++ cmd/x86/Makefile

[PATCH 34/34] x86: Enable RTC command by default

2023-10-01 Thread Simon Glass
The real-time clock is needed for most X86 systems and it is useful to be able to read from it. Enable the rtc command by default. Signed-off-by: Simon Glass --- cmd/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/cmd/Kconfig b/cmd/Kconfig index e6977dc91bb2..080e104f9d76 100644

[PATCH 29/34] x86: coreboot: Add a test for cbsysinfo command

2023-10-01 Thread Simon Glass
Add a simple test for this command, checking that coreboot has the required features. Signed-off-by: Simon Glass --- test/cmd/Makefile | 1 + test/cmd/coreboot.c | 37 + 2 files changed, 38 insertions(+) create mode 100644 test/cmd/coreboot.c diff --git

[PATCH 31/34] x86: coreboot: Enable support for the configuration editor

2023-10-01 Thread Simon Glass
Enable cedit support along with required options and a simple style. Signed-off-by: Simon Glass --- arch/x86/dts/coreboot.dts| 7 +++ configs/coreboot64_defconfig | 2 ++ configs/coreboot_defconfig | 2 ++ 3 files changed, 11 insertions(+) diff --git a/arch/x86/dts/coreboot.dts b

[PATCH 28/34] x86: CI: Update coreboot

2023-10-01 Thread Simon Glass
Update to a newer version which supports settings in CMOS RAM. Signed-off-by: Simon Glass --- .azure-pipelines.yml | 2 +- .gitlab-ci.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.azure-pipelines.yml b/.azure-pipelines.yml index 421c5018b40b..83491e38f70c

[PATCH 33/34] x86: coreboot: Allow building an expo for editing CMOS config

2023-10-01 Thread Simon Glass
Coreboot provides the CMOS layout in the tables it passes to U-Boot. Use that to build an editor for the CMOS settings. Signed-off-by: Simon Glass --- boot/Makefile | 4 + boot/expo_build_cb.c| 244 cmd/cedit.c

[PATCH 30/34] x86: coreboot: Show the option table

2023-10-01 Thread Simon Glass
Update the cbsysinfo command to show the contents of the CMOS option table. While we are here, add some example output for this command, along with mention of what the unimplemented tags are. Signed-off-by: Simon Glass --- cmd/x86/cbsysinfo.c | 73 ++- doc

[PATCH 25/34] expo: Drop scene_title_set()

2023-10-01 Thread Simon Glass
This function is really just an assignment, so serves no useful purpose. Drop it. Signed-off-by: Simon Glass --- boot/expo_build.c | 4 ++-- boot/scene.c | 7 --- include/expo.h| 9 - test/boot/expo.c | 2 +- 4 files changed, 3 insertions(+), 19 deletions(-) diff --git

[PATCH 26/34] expo: Add forward declaration for udevice to cedit

2023-10-01 Thread Simon Glass
Some files may include this header file without first including dm.h so add a forward declaration. Signed-off-by: Simon Glass --- include/cedit.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/cedit.h b/include/cedit.h index f43cafa5aa24..f9a4a6d9e8eb 100644 --- a/include/cedit.h

[PATCH 27/34] x86: coreboot: Enable unit tests

2023-10-01 Thread Simon Glass
Enable unit tests so we can run command-line tests in coreboot. Enable console recording, with enough space for the 'cbsysinfo' command. Add to the pre-relocation malloc() space to make room for this. Signed-off-by: Simon Glass --- configs/coreboot_defconfig | 4 1 file changed, 4

[PATCH 23/34] expo: Support menu-item values in cedit

2023-10-01 Thread Simon Glass
Update the cedit read/write functions to support menu items with values. Signed-off-by: Simon Glass --- boot/cedit.c| 148 +--- boot/scene_menu.c | 2 +- doc/usage/cmd/cedit.rst | 15 +++- test/boot/cedit.c

[PATCH 24/34] expo: Drop unneceesary calls to expo_str()

2023-10-01 Thread Simon Glass
The scene_txt_str() function calls expo_str() so there is no need to call it beforehand. Drop this unnecessary code. Signed-off-by: Simon Glass --- boot/expo_build.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/boot/expo_build.c b/boot/expo_build.c

[PATCH 21/34] expo: Allow menu items to have values

2023-10-01 Thread Simon Glass
' property, then the normal sequence number will be used instead. Signed-off-by: Simon Glass --- arch/sandbox/dts/cedit.dtsi | 3 +++ boot/expo_build.c | 16 boot/scene_internal.h | 10 ++ boot/scene_menu.c | 17 + doc

[PATCH 16/34] video: Add a dark-grey console colour

2023-10-01 Thread Simon Glass
This is useful for highlighting something with a black background, as is needed with cedit when using a white-on-black console. Add this as a new colour. Signed-off-by: Simon Glass --- boot/scene.c | 2 +- drivers/video/video-uclass.c | 3 +++ include/video.h | 1

[PATCH 22/34] expo: Add a little more cedit CMOS logging

2023-10-01 Thread Simon Glass
Add some more logging in the CMOS read/write code. Tidy up a few comments while we are here. Signed-off-by: Simon Glass --- boot/cedit.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/boot/cedit.c b/boot/cedit.c index a53a4f289906..cc1d5b763577 100644 --- a/boot

[PATCH 20/34] expo: Use standard numbering for save and discard

2023-10-01 Thread Simon Glass
' to return failure when the user exits the expo without saving. Update the test for this change as well. Signed-off-by: Simon Glass --- boot/cedit.c | 24 +--- boot/expo.c| 2 +- doc/develop/cedit.rst | 7 ++- doc/develop/expo.rst | 12

[PATCH 13/34] video: Add a function to clear the display

2023-10-01 Thread Simon Glass
Move the code from the 'cls' command into the console file, so it can be called from elsewhere. Signed-off-by: Simon Glass --- cmd/cls.c | 25 +++-- common/console.c | 31 +++ include/console.h | 10 ++ 3 files changed, 44

[PATCH 19/34] expo: Set the initial next_id to 1

2023-10-01 Thread Simon Glass
If expo_set_dynamic_start() is never called, the first scene created will have an ID of 0, which is invalid. Correct this by setting a default value. Add a test to check this. Signed-off-by: Simon Glass --- boot/expo.c | 1 + test/boot/expo.c | 23 +-- 2 files

[PATCH 11/34] test: lmb: Move tests into the lib suite

2023-10-01 Thread Simon Glass
the lib_test_lmb_max_regions() macro inside the same #ifdef as its function, to avoid a build error if the condition is false. Signed-off-by: Simon Glass --- test/lib/lmb.c | 36 1 file changed, 12 insertions(+), 24 deletions(-) diff --git a/test/lib/lmb.c b/test/lib/lmb.c

[PATCH 09/34] test: font: Add dependencies on fonts

2023-10-01 Thread Simon Glass
The font test needs two fonts. If one is not available, skip out early, to avoid an error. Signed-off-by: Simon Glass --- test/cmd/font.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/test/cmd/font.c b/test/cmd/font.c index 40682e5ce495..1fe05c1ead51 100644

[PATCH 18/34] expo: Place menu items to the right of all labels

2023-10-01 Thread Simon Glass
. To implement this, add a new struct to containing arrangement information. Calculate it before doing the actual arrangement. Add a new style item which sets the amount of space from the right side of the labels to left side of the items. Signed-off-by: Simon Glass --- boot/cedit.c | 13

[PATCH 12/34] test: print: Skip test on x86

2023-10-01 Thread Simon Glass
These tests cannot work on x86 machines as memory at address zero is not writable. Add a condition to skip these. Signed-off-by: Simon Glass --- test/print_ut.c | 8 1 file changed, 8 insertions(+) diff --git a/test/print_ut.c b/test/print_ut.c index b26f6281b013..bb844d2542b7 100644

[PATCH 14/34] sandbox: Add a dummy booti command

2023-10-01 Thread Simon Glass
Add basic sandbox support for 'booti' so we can start to boot the test ARMbian image. This is helpful in checking that it is parsed correctly. Signed-off-by: Simon Glass --- arch/sandbox/lib/bootm.c | 7 +++ cmd/Kconfig | 2 +- cmd/booti.c | 2

[PATCH 10/34] test: event: Only run test_event_probe() on sandbox

2023-10-01 Thread Simon Glass
This needs test devices which are only present on sandbox. Add a check for this and skip just this test if running on a real board. Signed-off-by: Simon Glass --- test/common/event.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/common/event.c b/test/common/event.c index

[PATCH 17/34] video: Avoid starting a new line to close to the bottom

2023-10-01 Thread Simon Glass
processing a newline character, to avoid any problems. Add some comments to make things a little clearer. Signed-off-by: Simon Glass --- drivers/video/vidconsole-uclass.c | 4 +++- include/video.h | 3 ++- include/video_console.h | 8 3 files changed, 13

[PATCH 15/34] bootstd: Add a menu option to bootflow scan

2023-10-01 Thread Simon Glass
Allow showing a menu and automatically booting, with 'bootflow scan'. This is more convenient than using a script. Signed-off-by: Simon Glass --- cmd/bootflow.c | 27 +++-- doc/usage/cmd/bootflow.rst | 5 +++ test/boot/bootflow.c | 82

[PATCH 05/34] test: Run bootstd tests only on sandbox

2023-10-01 Thread Simon Glass
These make use of disk images which are not available on reak boards. Add a new Kconfig to ensure these tests only run where they are valid. Signed-off-by: Simon Glass --- test/Kconfig | 5 + test/Makefile | 2 +- test/cmd_ut.c | 2 +- 3 files changed, 7 insertions(+), 2 deletions

[PATCH 06/34] test: Handle use of stack pointer in bdinfo

2023-10-01 Thread Simon Glass
This test assumes that the stack pointer is the same across two calls to lmb_init_and_reserve() but this is not the case on x86, for example. Add a special case to handle this, along with a detailed comment. Signed-off-by: Simon Glass --- test/cmd/bdinfo.c | 12 1 file changed

[PATCH 08/34] test: fdt: Add a special case for real boards

2023-10-01 Thread Simon Glass
The error that this test checks for is only shown on sandbox. For real boards, there is normally no error. Add a special case to handle this. Signed-off-by: Simon Glass --- test/cmd/fdt.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/test/cmd/fdt.c b/test/cmd/fdt.c

[PATCH 04/34] test: Make UT_LIB_ASN1 depend on sandbox

2023-10-01 Thread Simon Glass
This doesn't seem to work on a real board, so use the test on sandbox only. Signed-off-by: Simon Glass --- test/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/test/Kconfig b/test/Kconfig index 830245b6f9a9..69d63a5ff7dd 100644 --- a/test/Kconfig +++ b/test/Kconfig @@ -31,6 +31,7

[PATCH 07/34] test: bdinfo: Add missing asserts

2023-10-01 Thread Simon Glass
Calling into sub-test functions should be done using ut_assertok() so that the test exits immediately on failure. Add those which are missing. Signed-off-by: Simon Glass --- test/cmd/bdinfo.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/test/cmd/bdinfo.c b

[PATCH 01/34] test: Run tests that don't need devices

2023-10-01 Thread Simon Glass
Tests without the UT_TESTF_SCAN_FDT flag are currently skipped unless OF_LIVE is enabled. Drop this condition, so that they can run on non-sandbox builds, which often don't have OF_LIVE enabled. Signed-off-by: Simon Glass --- test/test-main.c | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH 02/34] test: Add a new suite for commands

2023-10-01 Thread Simon Glass
Add a new suite for 'cmd' tests, used for testing commands. These are kept in the test/cmd directory. For now it is empty, but it will be used for coreboot-command tests. Signed-off-by: Simon Glass --- include/test/cmd.h| 15 +++ include/test/suites.h | 1 + test/cmd/Makefile

[PATCH 03/34] test: Add helper to skip to partial console line

2023-10-01 Thread Simon Glass
to the length of the provided string. Signed-off-by: Simon Glass --- include/test/ut.h | 30 ++ test/ut.c | 27 +++ 2 files changed, 57 insertions(+) diff --git a/include/test/ut.h b/include/test/ut.h index ea6ee95d7344..d3172af8083f 100644

[PATCH 00/34] x86: expo: Add support for editing coreboot CMOS RAM settings

2023-10-01 Thread Simon Glass
and improvements: - new -m flag for 'bootflow scan' so it can display a menu automatically - Fix for video-scrolling crash with Truetype - menu items can now have individual integer values - menu items are lined up according to the width of all menu labels Simon Glass (34): test: Run tests

[PATCH v3 08/12] video: Drop unnecessary truetype operations from SPL

2023-10-01 Thread Simon Glass
Saving and restoring entries is used for expo and for the command line, which we don't use in SPL. Drop these methods. Signed-off-by: Simon Glass --- Changes in v3: - Add new patch to drop unnecessary truetype operations from SPL drivers/video/console_truetype.c | 10 ++ 1 file

[PATCH v3 11/12] x86: qemu: Expand ROM size

2023-10-01 Thread Simon Glass
Expand the ROM for x86_64 to 2MB to make space for the font, as it is already on the edge. Signed-off-by: Simon Glass --- (no changes since v1) board/emulation/qemu-x86/Kconfig | 3 ++- configs/qemu-x86_64_defconfig| 6 +++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git

[PATCH v3 12/12] x86: qemu: Enable truetype fonts

2023-10-01 Thread Simon Glass
Enable this feature to provide a larger font choice and more attractive menus. Expand the ROM for x86_64 to 2MB to make space for the font. Signed-off-by: Simon Glass --- Changes in v3: - Add new patch to enable truetype fonts in qemu-x86 and qemu-x86_64 configs/qemu-x86_64_defconfig | 1

[PATCH v3 06/12] expo: Correct background colour

2023-10-01 Thread Simon Glass
Use the correct background colour when using white-on-black. Signed-off-by: Simon Glass --- (no changes since v1) boot/expo.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/boot/expo.c b/boot/expo.c index 139d684f8e6e..cadb6a0ad6e3 100644 --- a/boot/expo.c +++ b/boot

[PATCH v3 10/12] x86: coreboot: Enable truetype fonts

2023-10-01 Thread Simon Glass
Truetype fonts look better in the menu, so enable them. Signed-off-by: Simon Glass --- Changes in v3: - Add new patch to enable truetype fonts in coreboot arch/x86/dts/coreboot.dts| 10 ++ configs/coreboot64_defconfig | 3 ++- configs/coreboot_defconfig | 3 ++- 3 files

[PATCH v3 03/12] bootstd: Add a return code to bootflow menu

2023-10-01 Thread Simon Glass
Return an error when the user does not select an OS, so we know whether to boot or not. Move calling of bootflow_menu_run() into a separate function so we can call it from other places. Expand the test to cover these cases. Add some documentation also, while we are here. Signed-off-by: Simon

[PATCH v3 09/12] x86: Enable SSE in 64-bit mode

2023-10-01 Thread Simon Glass
This is needed to support Truetype fonts. In any case, the compiler expects SSE to be available in 64-bit mode. Enable it. Signed-off-by: Simon Glass Suggested-by: Bin Meng --- (no changes since v1) arch/x86/config.mk| 1 - arch/x86/cpu/x86_64/cpu.c | 11 +++ 2 files changed

[PATCH v3 04/12] x86: coreboot: Add a boot script

2023-10-01 Thread Simon Glass
Provide the user with a list of available boot options. Selecting one causes it to be booted. Pressing causes U-Boot to return to the command-line prompt. Signed-off-by: Simon Glass --- Changes in v3: - Clear the screen before booting Changes in v2: - Add new patch to add a coreboot boot

[PATCH v3 01/12] efi: Correct handling of frame buffer

2023-10-01 Thread Simon Glass
t;Things that are private to the uclass: don't use these in the driver") which is why this was missed when the VIDEO_COPY feature was added. Signed-off-by: Simon Glass Fixes: 8f661a5b662 ("efi_loader: gop: Expose fb when 32bpp") --- (no changes since v2) Changes in v2: - Rebase t

[PATCH v3 05/12] usb: Avoid unbinding devices in use by bootflows

2023-10-01 Thread Simon Glass
when booting a distro from USB. This was found using a device with 4 bootflows, the last of which was USB. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Add new patch to avoid unbinding devices in use by bootflows boot/bootm.c | 2 +- common/usb.c

<    13   14   15   16   17   18   19   20   21   22   >