Re: [PATCH v2 1/1] sandbox: fix building with CONFIG_SPL_TIMER=y

2023-03-01 Thread Simon Glass
cetree instead" > > Add a missing condition in the sandbox driver. > > Signed-off-by: Heinrich Schuchardt > --- > v2: > don't create U_BOOT_DRVINFO for DT_PLAT_C > (as requested in review comment by Simon) > --- > drivers/timer/sandbox_timer.

Re: [PATCH 1/1] sandbox: allow building sandbox_spl with CONFIG_DEBUG

2023-03-01 Thread Simon Glass
Hi Eugen, On Fri, 24 Feb 2023 at 06:59, Eugen Hristev wrote: > > On 2/21/23 21:35, Simon Glass wrote: > > On Sat, 18 Feb 2023 at 01:34, Heinrich Schuchardt > > wrote: > >> > >> Building sandbox_spl with CONFIG_DEBUG leads to errors due to missing > >>

Re: [PATCH] MAINTAINERS: assign sandbox drivers to SANDBOX

2023-03-01 Thread Simon Glass
On Sat, 18 Feb 2023 at 02:38, Heinrich Schuchardt wrote: > > Drivers should have a maintainer. > > Signed-off-by: Heinrich Schuchardt > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Simon Glass Applied to u-boot-dm, thanks!

Re: [PATCH] arm64: a37xx: pinctrl: probe after binding

2023-03-01 Thread Simon Glass
On Mon, Feb 13, 2023 at 12:36 AM Simon Glass wrote: > > Hi, > > On Thu, 19 Jan 2023 at 00:00, Stefan Roese wrote: > > > > On 1/17/23 15:08, Robert Marko wrote: > > > Currently, pinctrl drivers are getting probed during post-bind, however > > > that is b

Re: [PATCH 17/17] RFC: tools: Add a camel-case conversion script

2023-03-01 Thread Simon Glass
This is only for posterity, since once the conversion is done, the script is of no use. Signed-off-by: Simon Glass --- scripts/style.py | 180 +++ 1 file changed, 180 insertions(+) create mode 100755 scripts/style.py Applied to u-boot-dm, thanks!

Re: [PATCH] sandbox: Correctly define BITS_PER_LONG

2023-03-01 Thread Simon Glass
On Sun, Oct 23, 2022 at 09:56:29AM +0200, Heinrich Schuchardt wrote: > On 10/23/22 09:50, Michal Suchánek wrote: > > On Sat, Oct 22, 2022 at 11:52:29PM +0200, Heinrich Schuchardt wrote: > > > > > > > > > Am 22. Oktober 2022 23:22:01 MESZ schrieb Michal Suchanek > > > : > > > > SANDBOX_BITS_PER_LON

Re: u-boot crashes if mass-storage devices are connected via USB-C

2023-03-01 Thread Simon Glass
+Marek Vasut +Bin Meng +Mark Kettenis +Tom Rini On Wed, 1 Mar 2023 at 08:12, bluetail wrote: > > Hello. user kettenis aka "Mark Kettenis" guided me write my bug report > to this email. "bluetail: please report these usb bugs upstream; they're > almost certainly not hardware-specific" > > But befo

Re: [PATCH] image: Fix potentially uninitialized data variable

2023-03-01 Thread Simon Glass
arning > u32 *data; > ^ > = NULL > " > > Signed-off-by: Marek Vasut > --- > Cc: Heinrich Schuchardt > Cc: Michal Simek > Cc: Oleksandr Suvorov > Cc: Simon Glass > Cc: Stefan Roese > Cc: Tom Rini > --- > boot/image-board.c | 15 +++ > 1 file changed, 11 insertions(+), 4 deletions(-) > Reviewed-by: Simon Glass

Re: [PATCH 07/10] efi: Add another tranch of GUIDs

2023-03-01 Thread Simon Glass
Hi Ilias, On Wed, 1 Mar 2023 at 01:52, Ilias Apalodimas wrote: > > Hi Simon > > On Sun, 26 Feb 2023 at 03:33, Simon Glass wrote: > > > > Provide information about the GUIDs supplied by QEMU, so far as it is > > known. > > What the patch does is obvious.

Re: [PATCH 10/32] cmd: fdt: Add support for integer arrays in fdt get value with index

2023-03-01 Thread Simon Glass
> that code would work perfectly well with index -1 too. > > Signed-off-by: Marek Vasut > --- > Cc: Heinrich Schuchardt > Cc: Simon Glass > Cc: Tom Rini > --- > cmd/fdt.c | 14 ++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > Reviewed-by: Simon Glass

Re: [PATCH 14/32] test: cmd: fdt: Generate fuller DT internally and switch fdt get value to it

2023-03-01 Thread Simon Glass
reused by other tests. No functional change. > > Signed-off-by: Marek Vasut > --- > Cc: Heinrich Schuchardt > Cc: Simon Glass > Cc: Tom Rini > --- > test/cmd/fdt.c | 124 +++-- > 1 file changed, 111 insertions(+), 13 deletions(-) > Reviewed-by: Simon Glass

Re: [PATCH V7 04/15] iot2050: Migrate settings into board env file

2023-03-01 Thread Simon Glass
Hi Jan, On Tue, 28 Feb 2023 at 11:20, Jan Kiszka wrote: > > From: Jan Kiszka > > Anything that is not boot-env related is better kept there by now. > > At this chance, also drop a stale comment from iot2050.h > > Signed-off-by: Jan Kiszka > --- > board/siemens/iot2050/iot2050.env | 9

Re: [PATCH v2 3/5] doc: document read/write commands

2023-03-01 Thread Simon Glass
oc/usage/cmd/read.rst > Reviewed-by: Simon Glass Please add a commit msg > diff --git a/doc/usage/cmd/read.rst b/doc/usage/cmd/read.rst > new file mode 100644 > index 00..705d5a3e0c > --- /dev/null > +++ b/doc/usage/cmd/read.rst > @@ -0,0 +1,40 @@ > +.. SPDX-Li

Re: [PATCH v2 4/5] sandbox: enable CMD_WRITE

2023-03-01 Thread Simon Glass
On Wed, 1 Mar 2023 at 14:13, Rasmus Villemoes wrote: > > Signed-off-by: Rasmus Villemoes > --- > configs/sandbox64_defconfig | 1 + > configs/sandbox_defconfig | 1 + > 2 files changed, 2 insertions(+) Reviewed-by: Simon Glass

Re: [PATCH v2 5/5] test: add tests of 'read' and 'write' shell commands

2023-03-01 Thread Simon Glass
On Wed, 1 Mar 2023 at 14:13, Rasmus Villemoes wrote: > > Signed-off-by: Rasmus Villemoes > --- > test/cmd/Makefile | 1 + > test/cmd/rw.c | 104 ++ > 2 files changed, 105 insertions(+) > create mode 100644 test/cmd/rw.

Re: [PATCH v2 2/5] cmd: introduce 'write' command

2023-03-01 Thread Simon Glass
elf whether it > was invoked as "read" or "write". > > Signed-off-by: Rasmus Villemoes > --- > cmd/Kconfig | 5 + > cmd/Makefile | 1 + > cmd/read.c | 29 ++--- > 3 files changed, 28 insertions(+), 7 deletions(-) > Reviewed-by: Simon Glass

Re: [PATCH V7 15/15] iot2050: Add support for configuring M.2 connector

2023-03-01 Thread Simon Glass
Hi Jan, On Tue, 28 Feb 2023 at 11:23, Jan Kiszka wrote: > > From: Jan Kiszka > > The M.2 slots of the related IOT2050 variant need to be configured > according to the plugged cards. This tries to detect the card using the > M.2 configuration pins of the B-key slot. If that fails, a U-Boot > envi

Re: [PATCH V7 13/15] iot2050: Refresh defconfigs and activate CONFIG_EFI_SCROLL_ON_CLEAR_SCREEN

2023-03-01 Thread Simon Glass
s(+), 4 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH V7 12/15] board: siemens: iot2050: use the named gpio to control the user-button

2023-03-01 Thread Simon Glass
gt; to indicate the gpio resource. > > Signed-off-by: chao zeng > --- > board/siemens/iot2050/board.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Simon Glass You might consider having a board note with this sort of information, e.g. using sysinfo,

Re: [PATCH V7 02/15] arm: dts: iot2050: Use the auto generator nodes for fdt

2023-03-01 Thread Simon Glass
050/board.c| 3 ++ > configs/iot2050_pg1_defconfig| 1 + > configs/iot2050_pg2_defconfig| 1 + > 4 files changed, 12 insertions(+), 37 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH V7 07/15] arm: dts: iot2050: Allow verifying U-Boot proper by SPL

2023-03-01 Thread Simon Glass
+ > 1 file changed, 16 insertions(+) > Reviewed-by: Simon Glass

[PATCH v2 1/8] rockchip: Drop bootstage stash in TPL and SPL for rockpro64

2023-03-01 Thread Simon Glass
standard passage[1] which should not be too far away. For now, disable it in TPL and SPL. [1] https://patchwork.ozlabs.org/project/uboot/cover/ 20220117150428.1580273-1-...@chromium.org/ Signed-off-by: Simon Glass Tested-by: Vagrant Cascadian --- Changes in v2: - Fix 'accessible&

[PATCH v2 2/8] rockchip: Disable DISTRO_DEFAULTS for rk3399 boards

2023-03-01 Thread Simon Glass
These board have moved to standard boot but the old 'distro_bootcmd' command is still active. Disable DISTRO_DEFAULTS to fix this. Signed-off-by: Simon Glass Tested-by: Vagrant Cascadian --- (no changes since v1) arch/arm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH v2 3/8] bootstd: Enable BOOTSTD_DEFAULTS by default

2023-03-01 Thread Simon Glass
which have a very small environment. Disable BOOTSTD_DEFAULTS for smartweb since it is too close to its limit. Signed-off-by: Simon Glass --- (no changes since v1) boot/Kconfig | 1 + configs/bk4r1_defconfig | 1 + co

[PATCH v2 4/8] Move DISTRO_DEFAULTS into boot/

2023-03-01 Thread Simon Glass
This relates to booting so move it in to that Kconfig file, before changing it. Signed-off-by: Simon Glass --- Changes in v2: - Add new patch to move DISTRO_DEFAULTS into boot/ Kconfig | 27 --- boot/Kconfig | 28 +++- 2 files changed, 27

[PATCH v2 5/8] lmb: Enable LMB if SYS_BOOT_RAMDISK_HIGH

2023-03-01 Thread Simon Glass
Ramdisk relocation requires LMB, so enable it automatically to avoid build errors. Signed-off-by: Simon Glass --- (no changes since v1) boot/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/boot/Kconfig b/boot/Kconfig index 7815341ada7..da18d4738a7 100644 --- a/boot/Kconfig +++ b

[PATCH v2 8/8] bootstd: Relax the argument requirements for bootflow scan

2023-03-01 Thread Simon Glass
Currently this does not allow the -lb flags unless CMD_BOOTFLOW_FULL is enabled, which means that we need two separate boot commands. Relax this to make things easier. It is only a small amount of extra code. Signed-off-by: Simon Glass --- (no changes since v1) boot/Kconfig | 3 +-- cmd

[PATCH v2 7/8] rockchip: Move to standard boot

2023-03-01 Thread Simon Glass
Drop the distro-boot scripts and use standard boot instead. Signed-off-by: Simon Glass --- Changes in v2: - Add new patch to move rockchip to standard boot arch/arm/Kconfig | 1 - include/configs/px30_common.h | 4 +-- include/configs/rk3036_common.h | 5 +-- include

[PATCH] buildman: Correct CROSS_COMPILE output for sandbox

2023-03-02 Thread Simon Glass
At present, 'buildman -A sandbox' adds the path containing the toolchain at present. We can assume that this is in the path and we don't want to set CROSS_COMPILE=/bin/ so change this to align with what MakeEnvironment() does. Signed-off-by: Simon Glass --- tools/buildman/t

[PATCH v2 1/4] binman: Allow preserving the output dir when replacing

2023-03-02 Thread Simon Glass
Add these flags for the 'replace' subcommand too, to aid debugging. Signed-off-by: Simon Glass 44 2023 -0700 --- Changes in v2: - Add new patch to allow preserving the output dir when replacing tools/binman/binman.rst | 6 ++ tools/binman/cmdline.py | 16 ++-- to

[PATCH v2 2/4] binman: Handle missing bintools correctly in fit

2023-03-02 Thread Simon Glass
At present these are handled as if they are allowed to be missing, but this is only true if the -M flag is provided. Fix this and add a test. Signed-off-by: Simon Glass --- Changes in v2: - Add new patch to handle missing bintools correctly in fit tools/binman/etype/fit.py | 2 ++ tools

[PATCH v2 4/4] binman: Support generation of x509 certificates

2023-03-02 Thread Simon Glass
And a new entry type which supports generation of x509 certificates. This uses a new 'openssl' btool with just one operation so far. Signed-off-by: Simon Glass --- Changes in v2: - Add new patch to generate x509 certificates tools/binman/btool/openssl.py

[PATCH v2 3/4] binman: Support updating section contents

2023-03-02 Thread Simon Glass
Implement this feature since it is useful for updating FITs within an image. Signed-off-by: Simon Glass --- Changes in v2: - Update to support more replacement cases tools/binman/binman.rst | 16 ++ tools/binman/control.py | 2 + tools/binman

Re: [PATCH] binman: Support updating section contents

2023-03-02 Thread Simon Glass
Hi Quentin, On Mon, 6 Feb 2023 at 03:26, Quentin Schulz wrote: > > Hi Simon, > > On 2/4/23 23:24, Simon Glass wrote: > > Implement this feature since it is useful for updating FITs within an > > image. > > > > Signed-off-by: Simon Glass > > --- &g

Re: [PATCH v3 3/5] doc: document read/write commands

2023-03-06 Thread Simon Glass
s > --- > doc/usage/cmd/read.rst | 44 + > doc/usage/cmd/write.rst | 6 ++ > doc/usage/index.rst | 2 ++ > 3 files changed, 52 insertions(+) > create mode 100644 doc/usage/cmd/read.rst > create mode 100644 doc/usage/cmd/write.rst > Reviewed-by: Simon Glass

Re: [PATCH 23/32] test: cmd: fdt: Test fdt set

2023-03-06 Thread Simon Glass
On Wed, 1 Mar 2023 at 20:07, Marek Vasut wrote: > > On 3/1/23 16:02, Simon Glass wrote: > > Hi Marek, > > > > On Mon, 27 Feb 2023 at 12:55, Marek Vasut > > wrote: > >> > >> Add 'fdt set' test which works as follows: > >> - Crea

Re: [PATCH v2 02/32] cmd: fdt: Fix handling of empty properties for fdt get addr and fdt get size

2023-03-06 Thread Simon Glass
e still set the variable from 'fdt get addr/size' to > address of the property or size of the property, where the later > is 0. > > Signed-off-by: Marek Vasut > Reviewed-by: Simon Glass > --- > Cc: Heinrich Schuchardt > Cc: Simon Glass > Cc: Tom Rini &g

Re: [PATCH 1/2] test: Wrap assert macros in ({ ... }) and fix missing semicolons

2023-03-06 Thread Simon Glass
t; > Signed-off-by: Marek Vasut > --- > Cc: Heinrich Schuchardt > Cc: Simon Glass > Cc: Tom Rini > --- > include/test/ut.h | 152 ++--- > test/cmd/pwm.c | 4 +- > test/dm/acpigen.c | 2 +- > test/dm/misc.c | 4 +- &

Re: [PATCH v6 12/22] core: fdtaddr: add devfdt_get_addr_size_index_ptr function

2023-03-06 Thread Simon Glass
Hi Johan, On Thu, 2 Mar 2023 at 17:15, Johan Jonker wrote: > > Add devfdt_get_addr_size_index_ptr function with the same > functionality as devfdt_get_addr_size_index, but instead > a return pointer is given. > > Suggested-by: Michael Nazzareno Trimarchi > Signed-off-by: Johan Jonker > Reviewed

Re: [PATCH] nvedit: simplify do_env_indirect()

2023-03-06 Thread Simon Glass
o functional change. > > Signed-off-by: Rasmus Villemoes > --- > cmd/nvedit.c | 11 --- > 1 file changed, 4 insertions(+), 7 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH 1/1] doc: man-page for panic command

2023-03-06 Thread Simon Glass
insertions(+) > create mode 100644 doc/usage/cmd/panic.rst Reviewed-by: Simon Glass

Re: [PATCH 2/2] test: cmd: fdt: Drop new unneeded curly brackets

2023-03-06 Thread Simon Glass
On Wed, 1 Mar 2023 at 20:05, Marek Vasut wrote: > > Drop no longer needed { } around ut_assert*() functions in FDT test. > No functional change. > > Signed-off-by: Marek Vasut > --- > Cc: Heinrich Schuchardt > Cc: Simon Glass > Cc: Tom Rini > --- > test/c

Re: [PATCH] cmd: fdt: Drop the 0x prefix

2023-03-06 Thread Simon Glass
this > breaks anything. > > Signed-off-by: Marek Vasut > --- > Cc: Heinrich Schuchardt > Cc: Simon Glass > Cc: Tom Rini > --- > cmd/fdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/cmd/fdt.c b/cmd/fdt.c > index f38fe909c3e..04b664e652c

Re: [PATCH v6 17/22] drivers: use devfdt_get_addr_size_index_ptr when cast to pointer

2023-03-06 Thread Simon Glass
us files in the drivers directory that cast to > a pointer. > > Signed-off-by: Johan Jonker > Reviewed-by: Michael Trimarchi > --- > drivers/pci/pcie_dw_mvebu.c | 6 +++--- > drivers/spi/cadence_qspi.c | 3 +-- > 2 files changed, 4 insertions(+), 5 deletions(-) > Reviewed-by: Simon Glass

Re: [PATCH V7 04/15] iot2050: Migrate settings into board env file

2023-03-06 Thread Simon Glass
Hi Jan, On Wed, 1 Mar 2023 at 23:38, Jan Kiszka wrote: > > On 02.03.23 00:38, Simon Glass wrote: > > Hi Jan, > > > > On Tue, 28 Feb 2023 at 11:20, Jan Kiszka wrote: > >> > >> From: Jan Kiszka > >> > >> Anything that is not boot-env r

Re: [PATCH V7 09/15] iot2050: Add script for signing artifacts

2023-03-06 Thread Simon Glass
Hi Jan, On Tue, 28 Feb 2023 at 11:21, Jan Kiszka wrote: > > From: Jan Kiszka > > There are many ways to get a signed firmware for the IOT2050 devices, > namely for the parts under user-control. This script documents one way > of doing it, given a signing key. Augment the board documentation with

Re: [PATCH v5 32/44] x86: Fix up use of X86_32BIT_INIT and X86_64 options

2023-03-06 Thread Simon Glass
Hi Tom, On Fri, 3 Mar 2023 at 07:50, Tom Rini wrote: > > On Wed, Feb 22, 2023 at 09:34:13AM -0700, Simon Glass wrote: > > > Drop the invalid SPL_ in a CONFIG_IS_ENABLED() usage. Use the correct > > X86_64 option in msr.h since SPL may be 32-bit when U-Bout proper is > &

Re: [PATCH v6 15/22] drivers: use dev_read_addr_index_ptr when cast to pointer

2023-03-06 Thread Simon Glass
Hi Johan, On Thu, 2 Mar 2023 at 17:15, Johan Jonker wrote: > > The fdt_addr_t and phys_addr_t size have been decoupled. A 32bit CPU > can expect 64-bit data from the device tree parser, so use Why is that? It seems quite inefficient. > dev_read_addr_index_ptr instead of the dev_read_addr_index

Re: [PATCH v6 13/22] core: read: add dev_read_addr_index_ptr function

2023-03-06 Thread Simon Glass
nction. > > Signed-off-by: Johan Jonker > --- > > Changed V6: > use map_sysmem() > > Changed V5: > new patch > --- > drivers/core/read.c | 15 ++- > 1 file changed, 14 insertions(+), 1 deletion(-) Reviewed-by: Simon Glass

Re: [PATCH v5 00/44] More tidy-ups of Kconfig options

2023-03-06 Thread Simon Glass
Hi Tom, On Fri, 3 Mar 2023 at 16:43, Tom Rini wrote: > > On Wed, Feb 22, 2023 at 09:33:41AM -0700, Simon Glass wrote: > > > This series was split out of the old 'split config' splc series. It > > contains clean-up patches which do not depend on split config. >

Re: [PATCH] cmd: fdt: Drop the 0x prefix

2023-03-06 Thread Simon Glass
Hi Marek, On Mon, 6 Mar 2023 at 12:07, Marek Vasut wrote: > > On 3/6/23 18:53, Simon Glass wrote: > > Hi Marek, > > > > On Wed, 1 Mar 2023 at 20:04, Marek Vasut > > wrote: > >> > >> The 'fdt get addr' is always assumed to be hex value, d

Re: [PATCH 3/3] test: Add test for new command pci_mps

2023-03-08 Thread Simon Glass
Hi Stephen, On Tue, 7 Mar 2023 at 16:33, wrote: > > From: Stephen Carlson > > Adds a test for the new pci_mps command to ensure that it can set the > Maximum Payload Size (MPS) of all devices to 256 bytes in the sandbox > environment. Enables the pci_mps command in the sandbox environment so > t

Re: [PATCH v6 11/22] core: remap: convert regmap_init_mem_plat() input to phys_addr_t

2023-03-08 Thread Simon Glass
Hi Johan, On Wed, 8 Mar 2023 at 00:39, Johan Jonker wrote: > > > > On 3/3/23 01:14, Johan Jonker wrote: > > The fdt_addr_t and phys_addr_t size have been decoupled. > > A 32bit CPU can expect 64-bit data from the device tree parser, > > so convert regmap_init_mem_plat() input to phys_addr_t in fi

[PATCH v3 0/4] patman: Speed up some operations

2023-03-08 Thread Simon Glass
all_skips - Sort the set directly instead of converting it to a list first Changes in v2: - Fix 'uncorrect' typo in subject - Fix missing 'f' on format string Simon Glass (4): patman: Drop an incorrect comment about git am patman: Refactor MakeCcFile() into two fun

[PATCH v3 1/4] patman: Drop an incorrect comment about git am

2023-03-08 Thread Simon Glass
Patman does not do this anymore, as of this commit: 7428dc14b0f ("patman: Remove the -a option") Drop the comment. Signed-off-by: Simon Glass Reviewed-by: Douglas Anderson --- Changes in v3: - Mention the commit where the -a option was dropped Changes in v2: - Fix 'unc

[PATCH v3 2/4] patman: Refactor MakeCcFile() into two functions

2023-03-08 Thread Simon Glass
This function is quite long. Moving the handling of a commit into a separate function. This will make it easier to do the work in parallel. Update function comments while we are here. Signed-off-by: Simon Glass Reviewed-by: Douglas Anderson --- Changes in v3: - Reword comment for all_skips

[PATCH v3 3/4] patman: Run get_maintainer.pl in parallel

2023-03-08 Thread Simon Glass
This script can take ages on some series. Try to limit the time by using threads. If a few stubborn patches remain, show progress so the user has some idea what is going on. Signed-off-by: Simon Glass Reviewed-by: Douglas Anderson --- (no changes since v1) tools/patmanu/func_test.py | 2

[PATCH v3 4/4] patman: Check patches in parallel

2023-03-08 Thread Simon Glass
For large series this can take a while. Run checkpatch in parallel to try to reduce the time. The checkpatch information is still reported in sequential order, so a very slow patch at the start can still slow things down. But overall this gives good results. Signed-off-by: Simon Glass Reviewed

Re: [PATCH v3 3/4] patman: Run get_maintainer.pl in parallel

2023-03-08 Thread Simon Glass
This script can take ages on some series. Try to limit the time by using threads. If a few stubborn patches remain, show progress so the user has some idea what is going on. Signed-off-by: Simon Glass Reviewed-by: Douglas Anderson --- (no changes since v1) tools/patmanu/func_test.py | 2

Re: [PATCH v3 4/4] patman: Check patches in parallel

2023-03-08 Thread Simon Glass
For large series this can take a while. Run checkpatch in parallel to try to reduce the time. The checkpatch information is still reported in sequential order, so a very slow patch at the start can still slow things down. But overall this gives good results. Signed-off-by: Simon Glass Reviewed

Re: [PATCH v3 2/4] patman: Refactor MakeCcFile() into two functions

2023-03-08 Thread Simon Glass
This function is quite long. Moving the handling of a commit into a separate function. This will make it easier to do the work in parallel. Update function comments while we are here. Signed-off-by: Simon Glass Reviewed-by: Douglas Anderson --- Changes in v3: - Reword comment for all_skips

Re: [PATCH] buildman: Correct CROSS_COMPILE output for sandbox

2023-03-08 Thread Simon Glass
At present, 'buildman -A sandbox' adds the path containing the toolchain at present. We can assume that this is in the path and we don't want to set CROSS_COMPILE=/bin/ so change this to align with what MakeEnvironment() does. Signed-off-by: Simon Glass --- tools/buildman/t

Re: [PATCH v3 1/4] patman: Drop an incorrect comment about git am

2023-03-08 Thread Simon Glass
Patman does not do this anymore, as of this commit: 7428dc14b0f ("patman: Remove the -a option") Drop the comment. Signed-off-by: Simon Glass Reviewed-by: Douglas Anderson --- Changes in v3: - Mention the commit where the -a option was dropped Changes in v2: - Fix 'unc

Re: [PATCH v2 24/32] test: cmd: fdt: Test fdt mknode

2023-03-08 Thread Simon Glass
The test case can be triggered using: " ./u-boot -Dc 'ut fdt' " To dump the full output from commands used during test, add '-v' flag. Signed-off-by: Marek Vasut Reviewed-by: Simon Glass --- Cc: Heinrich Schuchardt Cc: Simon Glass Cc: Tom Rini --- V2: Ad

Re: [PATCH v2 27/32] test: cmd: fdt: Test fdt bootcpu

2023-03-08 Thread Simon Glass
: " ./u-boot -Dc 'ut fdt' " To dump the full output from commands used during test, add '-v' flag. Signed-off-by: Marek Vasut Reviewed-by: Simon Glass --- Cc: Heinrich Schuchardt Cc: Simon Glass Cc: Tom Rini --- V2: Add RB from Simon --- test/cmd/fdt.c | 33 +++

Re: [PATCH v2 32/32] test: cmd: fdt: Add list of remaining missing tests

2023-03-08 Thread Simon Glass
Add list of missing tests for the 'fdt' command, currently the missing sandbox tests are only 'fdt boardsetup' and 'fdt checksign' . Signed-off-by: Marek Vasut Reviewed-by: Simon Glass --- Cc: Heinrich Schuchardt Cc: Simon Glass Cc: Tom Rini --- V2: Add RB from

Re: [PATCH v2 23/32] test: cmd: fdt: Test fdt set

2023-03-08 Thread Simon Glass
lues using 'fdt get value' The test case can be triggered using: " ./u-boot -Dc 'ut fdt' " To dump the full output from commands used during test, add '-v' flag. Signed-off-by: Marek Vasut Reviewed-by: Simon Glass --- Cc: Heinrich Schuchardt Cc: Simon Glass

Re: [PATCH v2 20/32] test: cmd: fdt: Test fdt get name

2023-03-08 Thread Simon Glass
x27;-v' flag. Signed-off-by: Marek Vasut Reviewed-by: Simon Glass --- Cc: Heinrich Schuchardt Cc: Simon Glass Cc: Tom Rini --- V2: Add RB from Simon --- test/cmd/fdt.c | 79 ++ 1 file changed, 79 insertions(+) Applied to u-boot-dm/next, thanks!

Re: [PATCH v2 13/32] test: cmd: fdt: Rename fdt_test_get() to fdt_test_get_value()

2023-03-08 Thread Simon Glass
The 'fdt get' command has a 'get value' subcommand, rename the fdt_test_get() to fdt_test_get_value() to avoid confusion about what it is testing. There is currently no get 'get name', 'get addr', 'get size' subcommand test. Signed-off-by: Marek

Re: [PATCH v2 16/32] test: cmd: fdt: Test both string and integer arrays in 'fdt get value'

2023-03-08 Thread Simon Glass
-by: Simon Glass --- Cc: Heinrich Schuchardt Cc: Simon Glass Cc: Tom Rini --- V2: Add RB from Simon --- test/cmd/fdt.c | 58 -- 1 file changed, 42 insertions(+), 16 deletions(-) Applied to u-boot-dm/next, thanks!

Re: [PATCH v2 11/32] test: Add ut_assert_nextline_empty() empty line helper

2023-03-08 Thread Simon Glass
Add helper macro to test for empty lines, which is an inobvious wrapper around ut_assert_nextline("%s", "") . Signed-off-by: Marek Vasut Reviewed-by: Simon Glass --- Cc: Heinrich Schuchardt Cc: Simon Glass Cc: Tom Rini --- V2: Add RB from Simon --- include/test/ut.h | 4

Re: [PATCH v2 15/32] test: cmd: fdt: Test alias resolution in 'fdt get value'

2023-03-08 Thread Simon Glass
The 'fdt' command help contains the following note: " Dereference aliases by omitting the leading '/', e.g. fdt print ethernet0. " Add test for it. Signed-off-by: Marek Vasut Reviewed-by: Simon Glass --- Cc: Heinrich Schuchardt Cc: Simon Glass Cc: Tom Rini --- V

Re: [PATCH v2 09/32] cmd: fdt: Map address returned from fdt get addr to sysmem

2023-03-08 Thread Simon Glass
ddr var / compatible ; md $var' " Signed-off-by: Marek Vasut Reviewed-by: Simon Glass --- Cc: Heinrich Schuchardt Cc: Simon Glass Cc: Tom Rini --- V2: Add RB from Simon --- cmd/fdt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Applied to u-boot-dm/next, thanks!

Re: [PATCH v2 12/32] test: cmd: fdt: Rename fdt_test_resize() to fdt_test_addr_resize()

2023-03-08 Thread Simon Glass
The 'fdt' command has a 'resize' subcommand, rename the fdt_test_resize() to fdt_test_addr_resize() to avoid confusion about what it is testing. There is currently no resize test. Signed-off-by: Marek Vasut Reviewed-by: Simon Glass --- Cc: Heinrich Schuchardt Cc: Simon

Re: [PATCH v2 10/32] cmd: fdt: Add support for integer arrays in fdt get value with index

2023-03-08 Thread Simon Glass
t index is set to -1 instead of 0. This is OK, since the only place which checks for index to be less or equal zero is the string array handling code in fdt_value_env_set() and that code would work perfectly well with index -1 too. Signed-off-by: Marek Vasut Reviewed-by: Simon Glass --- Cc

Re: [PATCH v2 08/32] cmd: fdt: Handle 64bit pointers in fdt get addr

2023-03-08 Thread Simon Glass
The command assumed 32bit pointers so far, with 64bit pointer the command would overwrite a piece of stack. Fix it by extending the array size to cater for 64bit pointer, and use snprintf() to avoid writing past the end of the array ever again. Signed-off-by: Marek Vasut Reviewed-by: Simon Glass

Re: [PATCH v2 22/32] test: cmd: fdt: Test fdt get size

2023-03-08 Thread Simon Glass
the full output from commands used during test, add '-v' flag. Signed-off-by: Marek Vasut Reviewed-by: Simon Glass --- Cc: Heinrich Schuchardt Cc: Simon Glass Cc: Tom Rini --- V2: Add RB from Simon --- test/cmd/fdt.c | 87 ++ 1 file

Re: [PATCH v2 17/32] test: cmd: fdt: Test fdt move

2023-03-08 Thread Simon Glass
fdt' " To dump the full output from commands used during test, add '-v' flag. Signed-off-by: Marek Vasut Reviewed-by: Simon Glass --- Cc: Heinrich Schuchardt Cc: Simon Glass Cc: Tom Rini --- V2: Add RB from Simon --- test/cmd/fdt.c | 34 ++ 1

Re: [PATCH v2 14/32] test: cmd: fdt: Generate fuller DT internally and switch fdt get value to it

2023-03-08 Thread Simon Glass
eviewed-by: Simon Glass --- Cc: Heinrich Schuchardt Cc: Simon Glass Cc: Tom Rini --- V2: Add RB from Simon --- test/cmd/fdt.c | 124 +++-- 1 file changed, 111 insertions(+), 13 deletions(-) Applied to u-boot-dm/next, thanks!

Re: [PATCH v2 05/32] cmd: fdt: Check argc before accessing argv in fdt bootcpu

2023-03-08 Thread Simon Glass
On case 'fdt bootcpu' is invoked without parameters, argv[2] is not valid and this command would SEGFAULT in sandbox environment. Add missing argc test to avoid the crash and rather print usage help message. Signed-off-by: Marek Vasut Reviewed-by: Simon Glass --- Cc: Heinrich Schu

Re: [PATCH v2 25/32] test: cmd: fdt: Test fdt rm

2023-03-08 Thread Simon Glass
" To dump the full output from commands used during test, add '-v' flag. Signed-off-by: Marek Vasut Reviewed-by: Simon Glass --- Cc: Heinrich Schuchardt Cc: Simon Glass Cc: Tom Rini --- V2: Add RB from Simon --- test/cmd/fdt.c | 84 +

Re: [PATCH v2 07/32] cmd: fdt: Align checksign parameter names in help text

2023-03-08 Thread Simon Glass
The help text references 'addr' as an optional key start address, but the explanation references the same as 'start', make sure they both read as 'addr'. Also update the abbreviated 'addr' in the explanation to 'address'. Signed-off-by: Marek

Re: [PATCH v2 18/32] test: cmd: fdt: Test fdt resize

2023-03-08 Thread Simon Glass
dump the full output from commands used during test, add '-v' flag. Signed-off-by: Marek Vasut Reviewed-by: Simon Glass --- Cc: Heinrich Schuchardt Cc: Simon Glass Cc: Tom Rini --- V2: Add RB from Simon --- test/cmd/fdt.c | 24 1 file changed, 24 insertions(+) Applied to u-boot-dm/next, thanks!

Re: [PATCH v2 01/32] cmd: fdt: Import is_printable_string() from DTC to fix u32 misprint

2023-03-08 Thread Simon Glass
ai Pham Signed-off-by: Nam Nguyen Signed-off-by: Marek Vasut Reviewed-by: Simon Glass --- Cc: Heinrich Schuchardt Cc: Simon Glass Cc: Tom Rini --- V2: Add RB from Simon --- cmd/fdt.c | 36 ++-- 1 file changed, 14 insertions(+), 22 deletions(-) Applied to u-boot-dm/next, thanks!

Re: [PATCH v2 24/24] CI: Add a check for building tools for PyPi

2023-03-08 Thread Simon Glass
Add a simple check that the PyPi packages can be built. Signed-off-by: Simon Glass --- Changes in v2: - Update the cover letter .azure-pipelines.yml | 10 ++ .gitlab-ci.yml | 6 ++ 2 files changed, 16 insertions(+) Applied to u-boot-dm/next, thanks!

Re: [PATCH v2 21/24] binman: Add support for building a binmanu PyPi package

2023-03-08 Thread Simon Glass
Create the necessary files to build this new package. It is not actually clear whether this is useful, since buildman has no purpose outside U-Boot. Move the main program into a function so that it can easily be called by the PyPi-created script. Signed-off-by: Simon Glass --- (no changes

Re: [PATCH v2 02/32] cmd: fdt: Fix handling of empty properties for fdt get addr and fdt get size

2023-03-08 Thread Simon Glass
e still set the variable from 'fdt get addr/size' to > address of the property or size of the property, where the later > is 0. > > Signed-off-by: Marek Vasut > Reviewed-by: Simon Glass > --- > Cc: Heinrich Schuchardt > Cc: Simon Glass > Cc: Tom Rini &g

Re: [PATCH v2 22/24] test: Add concurrencytest to the requirements

2023-03-08 Thread Simon Glass
This allows tests to run in parallel and speeds up some tests markedly, particularly with binman. Add it to the requirements. Signed-off-by: Simon Glass --- (no changes since v1) test/py/requirements.txt | 1 + 1 file changed, 1 insertion(+) Applied to u-boot-dm/next, thanks!

Re: [PATCH v2 06/32] cmd: fdt: Check argc before accessing argv in fdt memory

2023-03-08 Thread Simon Glass
On case 'fdt memory' is invoked without parameters, argv[2]/argv[3] is not valid and this command would SEGFAULT in sandbox environment. Add missing argc test to avoid the crash and rather print usage help message. Signed-off-by: Marek Vasut Reviewed-by: Simon Glass --- Cc: Heinrich

Re: [PATCH v2 03/32] cmd: fdt: Fix fdt rm behavior on non-existent property and error message space

2023-03-08 Thread Simon Glass
ornously returns 'err' instead of CMD_RET_FAILURE, fix it. Furthermore, align the number of spaces past fdt_delprop() in error message with the rest of the code. Signed-off-by: Marek Vasut Reviewed-by: Simon Glass --- Cc: Heinrich Schuchardt Cc: Simon Glass Cc: Tom Rini --- V2: Add R

Re: [PATCH v2 23/24] doc: Add notes on how to install patman and binman

2023-03-08 Thread Simon Glass
These can be installed with 'pip' now. Add the details for those who are interested. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/binman.rst | 13 + tools/patman/patman.rst | 12 2 files changed, 25 insertions(+) Applied to u-boot-dm/next, thanks!

Re: [PATCH v2 20/24] binman: Use importlib to find the help

2023-03-08 Thread Simon Glass
Use this function so that the help can be found even when binman is running from a package. Signed-off-by: Simon Glass --- Changes in v2: - Add new patch to use importlib to find the help tools/binman/control.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Applied to u-boot-dm

Re: [PATCH v2 19/24] binman: Hide the 'test' command unless test code is available

2023-03-08 Thread Simon Glass
It doesn't make much sense to expose tests when dtoc is running outside of the U-Boot git checkout. Hide the option in this case. Fix a long line while we are here. Signed-off-by: Simon Glass --- Changes in v2: - Add a patch to hide the test options unless test code is available tools/b

Re: [PATCH v2 16/24] dtoc: Use pathlib to find the test directory

2023-03-08 Thread Simon Glass
Update this so that the directory being used is declared at the top of the file. Use pathlib as it seems to be more modern. Signed-off-by: Simon Glass --- (no changes since v1) tools/dtoc/test_dtoc.py | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) Applied to u-boot-dm/next

Re: [PATCH v2 18/24] binman: Move the main code into a function

2023-03-08 Thread Simon Glass
Put this code into a function so it is easy for it be run when packaged. Signed-off-by: Simon Glass --- Changes in v2: - Add patch to split out the main code into a function tools/binman/main.py | 12 1 file changed, 8 insertions(+), 4 deletions(-) Applied to u-boot-dm/next

Re: [PATCH v2 17/24] dtoc: Add support for building a dtoc PyPi package

2023-03-08 Thread Simon Glass
Create the necessary files to build this new package. This is needed for binman. Move the main program into a function so that it can easily be called by the PyPi-created script. Signed-off-by: Simon Glass --- (no changes since v1) Makefile | 1 + tools/dtoc/README.rst

Re: [PATCH v2 15/24] dtoc: Move the main code into a function

2023-03-08 Thread Simon Glass
Put this code into a function so it is easy for it be run when packaged. Signed-off-by: Simon Glass --- Changes in v2: - Add patch to split out the main code into a function tools/dtoc/main.py | 100 +++-- 1 file changed, 52 insertions(+), 48 deletions

Re: [PATCH v2 14/24] dtoc: Hide the test options unless test code is available

2023-03-08 Thread Simon Glass
It doesn't make much sense to expose tests when dtoc is running outside of the U-Boot git checkout. Hide the option in this case. Signed-off-by: Simon Glass --- Changes in v2: - Add a patch to hide the test options unless test code is available tools/dtoc/main.py | 19 +

Re: [PATCH v2 10/24] buildman: Hide the test options unless test code is available

2023-03-08 Thread Simon Glass
It doesn't make much sense to expose tests when buildman is running outside of the U-Boot git checkout. Hide the option in this case Signed-off-by: Simon Glass --- Changes in v2: - Add a patch to hide the test options unless test code is available tools/buildman/cmdline.py

Re: [PATCH v2 13/24] buildman: Add support for building a buildman PyPi package

2023-03-08 Thread Simon Glass
called by the PyPi-created script. Signed-off-by: Simon Glass --- (no changes since v1) Makefile | 1 + tools/buildman/pyproject.toml | 29 + 2 files changed, 30 insertions(+) create mode 100644 tools/buildman/pyproject.toml Applied to u-boot-dm

<    1   2   3   4   5   6   7   8   9   10   >