[PATCH v2 28/60] buildman: Move checking for make into run_builder()

This is not needed until the builder is run. Move it there to reduce the size of the do_buildman() function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/tools/buildman

[PATCH v2 29/60] buildman: Move getting the adjust_cfg into run_builder()

Move this into its own function to reduce the size of do_buildman(). Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 38 +++--- 1 file changed, 27 insertions(+), 11 deletions(-) diff --git a/tools/buildman/control.py b/tools

[PATCH v2 30/60] buildman: Use get_alow_missing() directly to avoid var

Avoid an unnecessary local variable by moving this code to a function. This fixes the pylint warning about too many local variables. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a

[PATCH v2 31/60] buildman: Create a function to get number of built commits

Move this code into a function. This removes the last pylint error in the control module. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 34 +- 1 file changed, 25 insertions(+), 9 deletions(-) diff --git a/tools/buildman

[PATCH v2 32/60] buildman: Convert camel case in cmdline.py

Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/cmdline.py | 2 +- tools/buildman/func_test.py | 2 +- tools/buildman/main.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a

[PATCH v2 33/60] buildman: Correct most pylint warnings in cmdline

Tidu up warnings in this file. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/cmdline.py | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/tools/buildman/cmdline.py b/tools/buildman/cmdline.py index 3066a0b38bbf..91571a5adb1d 100644

[PATCH v2 34/60] buildman: Add a test for --boards

Add a simple functional test for the --boards option. Fix the example in the docs while we are here. Also improve the docs for Builder.count so it is clearer what it contains. Signed-off-by: Simon Glass --- Changes in v2: - Use snake case for tests tools/buildman/builder.py | 3 ++- tools

[PATCH v2 36/60] buildman: Convert camel case in bsettings.py

Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/bsettings.py | 14 +++--- tools/buildman/control.py | 2 +- tools/buildman/func_test.py | 12 ++-- tools/buildman/main.py | 2

[PATCH v2 35/60] buildman: Convert to argparse

Use argparse to parse the arguments, since OptionParser is deprecated now. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/cmdline.py | 125 tools/buildman/control.py | 140 ++-- tools/buildman

[PATCH v2 38/60] buildman: Split parser creation in two

Split this into two functions to avoid a warning about too many statements. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/cmdline.py | 44 +-- 1 file changed, 33 insertions(+), 11 deletions(-) diff --git a/tools/buildman/cmdline.py b

[PATCH v2 39/60] buildman: Convert camel case in builderthread.py

Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builder.py | 8 +++--- tools/buildman/builderthread.py | 50 - 2 files changed, 29 insertions(+), 29 deletions(-) diff

[PATCH v2 37/60] buildman: Convert camel case in builder.py

Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builder.py | 228 tools/buildman/builderthread.py | 26 ++-- tools/buildman/control.py | 13 +- tools/buildman

[PATCH v2 40/60] buildman: Correct most pylint warnings in builderthread

Fix the easy warnings in this file. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 95 ++--- 1 file changed, 51 insertions(+), 44 deletions(-) diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py

[PATCH v2 41/60] buildman: Export _get_output_dir() to avoid warnings

Make this a public memory since it is used outside the class. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builder.py | 8 tools/buildman/builderthread.py | 2 +- tools/buildman/test.py | 2 +- 3 files changed, 6 insertions(+), 6 deletions

[PATCH v2 42/60] buildman: Correct invalid use of out_dir variable

This variable has a different meaning in the outer scrop. Use a different name to avoid confusion, or bugs. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/buildman

[PATCH v2 43/60] buildman: Drop unnecessary assignment of config_out

This is already set up earlier in the function, so drop the extra assignment. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py index

[PATCH v2 44/60] buildman: Start a function to set up the make arguments

Move some of this code into a new funciion, to help reduce the size of the run_commits() function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 38 - 1 file changed, 23 insertions(+), 15 deletions(-) diff --git a/tools

[PATCH v2 45/60] buildman: Move setting of toolchain arguments to _build_args()

Move a few more pieces to this new function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py index 47ebf4dcdd90

[PATCH v2 46/60] buildman: Move more things into _build_args()

Move more of the argument-building code into this function. Fix a missing assignment for out_rel_dir too. Rename the function since it now builds all the arguments. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 55 - 1

[PATCH v2 47/60] buildman: Convert config_out to string IO

This is probably a little more efficient and it allows passing the object to another function to write data. Convert config_out to use a string I/O device. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 9 + 1 file changed, 5 insertions(+), 4

[PATCH v2 48/60] buildman: Move reconfigure code into its own function

Split this into its own function so reduce the size of run_commit(). Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 41 - 1 file changed, 30 insertions(+), 11 deletions(-) diff --git a/tools/buildman/builderthread.py b

[PATCH v2 49/60] buildman: Move bulid code into its own function

Split this into its own function so reduce the size of run_commit(). Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 40 - 1 file changed, 30 insertions(+), 10 deletions(-) diff --git a/tools/buildman/builderthread.py b

[PATCH v2 50/60] buildman: Move reading of the done file into a function

Move this logic into its own function to reduce the size of the run_commt() function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 66 + 1 file changed, 42 insertions(+), 24 deletions(-) diff --git a/tools/buildman

[PATCH v2 51/60] buildman: Move code to remove old outputs

Put this in its own function to reduce the size of the run_commit() function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/tools/buildman/builderthread.py

[PATCH v2 52/60] buildman: Move code to decide output dirs

Put this in its own function to reduce the size of the run_commit() function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 34 - 1 file changed, 25 insertions(+), 9 deletions(-) diff --git a/tools/buildman

[PATCH v2 53/60] buildman: Move checkout code to a separate function

Put this in its own function to reduce the size of the run_commit() function Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 30 +- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/tools/buildman/builderthread.py

[PATCH v2 54/60] buildman: Create a function to handle config and build

Move this code into a _config_and_build() function, so reduce the size of run_commit(). Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 97 + 1 file changed, 61 insertions(+), 36 deletions(-) diff --git a/tools/buildman

[PATCH v2 55/60] buildman: Avoid passing result into _read_done_file()

Move the creating of the result object into the function which sets it up, to simplify the code. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/tools/buildman

[PATCH v2 56/60] buildman: Tidy up reporting of a toolchain error

Provide the text of the exception when something goes wrong. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 7 +-- tools/buildman/func_test.py | 6 -- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/tools/buildman

[PATCH v2 57/60] buildman: Tidy up some comments in builderthread

Make sure all functions have full argument documentation. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 66 ++--- 1 file changed, 36 insertions(+), 30 deletions(-) diff --git a/tools/buildman/builderthread.py b/tools

[PATCH v2 58/60] buildman: Move copy_files() out ot BuilderThread class

This does not need to be in the class. Move it out to avoid a pylint warning. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 47 + 1 file changed, 24 insertions(+), 23 deletions(-) diff --git a/tools/buildman

[PATCH v2 59/60] buildman: Add a way to print the architecture for a board

This is useful for some tools and is easily available for buildman. Add a new --print-arch option. Signed-off-by: Simon Glass --- Changes in v2: - Add new patch to print the architecture for a board tools/buildman/cmdline.py | 2 ++ tools/buildman/control.py | 24

[PATCH v2 60/60] buildman: Enable test coverage

Enable measuring test coverage for buildman so we can see the gaps. It is currently at 68%. Signed-off-by: Simon Glass --- Changes in v2: - Drop patch to move -A logic up a little (since it breaks it) tools/buildman/cmdline.py | 2 ++ tools/buildman/main.py | 15

Re: [PATCH] lzma: Fix decompression speed regression

DOG_RESET()") > Signed-off-by: Christophe Leroy > --- > lib/lzma/LzmaDec.c | 18 -- > 1 file changed, 4 insertions(+), 14 deletions(-) Reviewed-by: Simon Glass +Stefan Roese I wonder if we need a more general fix?

Re: [PATCHv3 1/3] net/lwip: add lwip-external submodule

Hi Maxim, On Wed, 5 Jul 2023 at 09:16, Maxim Uvarov wrote: > > This commit adds the lwip library as a git submodule. I think > there has to be advantages to compile lwip inside U-boot, > i.e. use the same compiler and flags as the main code. > One of them is LTO and the other is to enable additio

Re: [PATCH v2] fpga: add inline stub for fpga_load

Hi Eugen, On Wed, 5 Jul 2023 at 07:05, Eugen Hristev wrote: > > In case CC_OPTIMIZE_FOR_DEBUG is set, unused code will not be optimized out, > hence the reference to fpga_load will be compiled. > if DM_FPGA and SPL_FPGA are not set, the build will fail with : > > aarch64-none-linux-gnu-ld.bfd: co

Re: [PATCHv3 3/3] net/lwip: add doc/develop/net_lwip.rst

Hi Maxim, On Wed, 5 Jul 2023 at 09:17, Maxim Uvarov wrote: > > Just add inital doc. > > Signed-off-by: Maxim Uvarov > --- > doc/develop/index.rst| 1 + > doc/develop/net_lwip.rst | 59 > 2 files changed, 60 insertions(+) > create mode 100644 doc/de

Re: [PATCH] tpm: Add TPM2_GetTestResult command support

Hi Julia, On Wed, 5 Jul 2023 at 00:55, Julia Daxenberger wrote: > > Hi Simon, > > On Mon, 3 Jul 2023 at 15:31, Simon Glass wrote: > > > > Hi Julia, > > > > On Mon, 3 Jul 2023 at 14:03, Julia Daxenberger > > wrote: > > > > > > Add TP

Re: [PATCH v1 1/2] drivers: firmware: introduce Meson Secure Monitor driver

Hi Alexey, On Thu, 6 Jul 2023 at 14:16, Alexey Romanov wrote: > > At the moment, only smc API is a set of functions in > arch/arm/mach-meson/sm.c. This approach is hard to configure > and also doesn't contain any generic API for calling smc. > > This patch add Meson SM driver with generic API (st

Re: v2023.07-rc5 regression: Image overlaps SPL

Hi, On Wed, 5 Jul 2023 at 09:35, Tom Rini wrote: > > On Tue, Jul 04, 2023 at 02:13:01PM -0300, Fabio Estevam wrote: > > On 04/07/2023 14:04, Francesco Dolcini wrote: > > > > > The boards that do not check the return value might start to behave > > > wrongly without an obvious error to help the de

[PATCH] binman: Support templating with multiple images

Allow a template to appear in the top level description when using multiple images. Signed-off-by: Simon Glass --- tools/binman/control.py | 5 ++-- tools/binman/ftest.py| 12 ++ tools/binman/test/287_template_multi.dts | 29

Re: [PATCH 12/12] binman: Support simple templates

Hi Jan, On Fri, 7 Jul 2023 at 11:05, Jan Kiszka wrote: > > On 05.07.23 00:14, Simon Glass wrote: > > Hi Jan, > > > > On Mon, 3 Jul 2023 at 20:34, Jan Kiszka wrote: > >> > >> Hi Simon, > >> > >> On 28.06.23 13:41, Simon Glass wrote:

Re: [PATCH] binman: Support templating with multiple images

Hi Jan, On Fri, 7 Jul 2023 at 15:04, Jan Kiszka wrote: > > On 07.07.23 14:40, Simon Glass wrote: > > Allow a template to appear in the top level description when using > > multiple images. > > > > Signed-off-by: Simon Glass > > --- > > > >

Re: [PATCH 12/12] binman: Support simple templates

Hi Jan, On Fri, 7 Jul 2023 at 14:56, Jan Kiszka wrote: > > On 07.07.23 14:42, Simon Glass wrote: > > Hi Jan, > > > > On Fri, 7 Jul 2023 at 11:05, Jan Kiszka wrote: > >> > >> On 05.07.23 00:14, Simon Glass wrote: > >>> Hi Jan, >

Re: [PATCH v14 05/11] log: select physical address formatting in a generic way

Hi Abdellatif, On Fri, 7 Jul 2023 at 15:44, Abdellatif El Khlifi wrote: > > sets the log formatting according to the platform (64-bit vs 32-bit) > > Signed-off-by: Abdellatif El Khlifi > Cc: Simon Glass > --- > include/log.h | 8 > 1 file changed, 8 insert

Re: [PATCH v14 07/11] arm_ffa: introduce sandbox FF-A support

comms with emulated Secure World > - Provides test methods allowing to read the status of the inspected ABIs > > The sandbox FF-A emulator supports only 64-bit direct messaging. > > Signed-off-by: Abdellatif El Khlifi > Cc: Tom Rini > Cc: Simon Glass > Cc: Ilias Apalodima

Re: [PATCH v14 11/11] arm_ffa: efi: corstone1000: enable MM communication

Hi Abdellatif, On Fri, 7 Jul 2023 at 15:44, Abdellatif El Khlifi wrote: > > turn on EFI MM communication > > On corstone1000 platform MM communication between u-boot > and the secure world (Optee) is done using the FF-A bus. > > Signed-off-by: Abdellatif El Khlifi > C

Re: [PATCH v2 1/3] binman: Add support for externally encrypted blobs

Hi Christian, On Tue, 4 Jul 2023 at 10:03, wrote: > > From: Christian Taedcke > > This adds a new etype encrypted that is derived from collection. > > It creates a new cipher node in the related image similar to the > cipher node used by u-boot, see boot/image-cipher.c. > > Signed-off-by: Christ

Re: [PATCH v2 2/3] binman: Allow cipher node as special section

-- > > (no changes since v1) > > tools/binman/etype/section.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass Although this patch needs to change once rebased to u-boot-dm/mkim-working

Re: [PATCH v2 3/3] binman: Add tests for etype encrypted

Hi Christian, On Tue, 4 Jul 2023 at 10:03, wrote: > > From: Christian Taedcke > > Add tests to reach 100% code coverage for the added etype encrypted. > > Signed-off-by: Christian Taedcke > --- > > Changes in v2: > - adapt tests for changed entry implementation > > tools/binman/ftest.py

Re: [PATCH v2 01/11] binman: elf: Check for ELF_TOOLS availability and remove extra semicolon

Hi Lukas, On Thu, 6 Jul 2023 at 09:38, wrote: > > From: Lukas Funke > > Check if elf tools are available when running DecodeElf(). Also > remove superfuous semicolon at line ending. > > Signed-off-by: Lukas Funke > Reviewed-by: Simon Glass > --- > > (no ch

Re: [PATCH v2 10/11] binman: ftest: Add test for xilinx_fsbl_auth etype

Hi Lukas, On Thu, 6 Jul 2023 at 09:38, wrote: > > From: Lukas Funke > > Add test for the 'xilinx_fsbl_auth' etype > > Signed-off-by: Lukas Funke > > --- > > Changes in v2: > - Fixed typo in dts name > > tools/binman/ftest.py | 8 > tools/binman/test/280_xilinx_fs

Re: [PATCH v2 09/11] binman: btool: Add Xilinx Bootgen btool

Hi Lukas, On Thu, 6 Jul 2023 at 09:38, wrote: > > From: Lukas Funke > > Add the Xilinx Bootgen as bintool. Xilinx Bootgen is used to create > bootable SPL (FSBL in Xilinx terms) images for Zynq/ZynqMP devices. The > btool creates a signed version of the SPL. Additionally to signing the > key sou

Re: [PATCH v5 03/23] arm: dts: k3: Add support for packaging sysfw.itb and tiboot3.bin

tloader images common to all K3 devices. > > Signed-off-by: Neha Malcom Francis > --- > arch/arm/dts/k3-binman.dtsi | 116 > 1 file changed, 116 insertions(+) > create mode 100644 arch/arm/dts/k3-binman.dtsi > Reviewed-by: Simon Glass

Re: [PATCH v5 11/23] am64x: dts: binman: Package tiboot3.bin, tispl.bin u-boot.img

t; * sysfw > * board-cfg > * pm-cfg > * sec-cfg > * rm-cfg > > tispl.bin: > * ATF > * OPTEE > * A53 SPL > * A53 SPL dtbs > > u-boot.img: > * A53 U-Boot > * A53 U-Boot

Re: [PATCH v5 21/23] binman: Overwrite symlink if it already exists

Hi Neha, On Fri, 7 Jul 2023 at 13:37, Neha Malcom Francis wrote: > > From: Andrew Davis > > Without this re-building will fail with an error when trying to create > the symlink for the second time with an already exists error. > > Signed-off-by: Andrew Davis > Signed-off-by: Neha Malcom Francis

Re: [PATCH v5 18/23] arm: k3-am65x-iot2050: Use binman for tispl.bin for iot2050

-iot2050-boot-image.dtsi | 76 +++- > 1 file changed, 74 insertions(+), 2 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH 09/10] doc: cmd: add documentation for scmi

Hi, On Tue, 4 Jul 2023 at 03:05, AKASHI Takahiro wrote: > > Hi Simon, > > On Mon, Jul 03, 2023 at 02:30:55PM +0100, Simon Glass wrote: > > Hi , > > > > On Mon, 3 Jul 2023 at 02:19, AKASHI Takahiro > > wrote: > > > > > > On Thu, Jun 29, 2

Re: [PATCH 12/12] binman: Support simple templates

Hi Jan, On Fri, 7 Jul 2023 at 17:03, Jan Kiszka wrote: > > On 07.07.23 17:35, Simon Glass wrote: > > Hi Jan, > > > > On Fri, 7 Jul 2023 at 14:56, Jan Kiszka wrote: > >> > >> On 07.07.23 14:42, Simon Glass wrote: > >>> Hi Jan, >

Re: [PATCH v1 1/2] drivers: firmware: introduce Meson Secure Monitor driver

Hi Alexey, On Fri, 7 Jul 2023 at 09:43, Alexey Romanov wrote: > > Hello, Simon! > > On Thu, Jul 06, 2023 at 09:58:02AM -0600, Simon Glass wrote: > > Hi Alexey, > > > > On Thu, 6 Jul 2023 at 14:16, Alexey Romanov > > wrote: > > > > > >

Re: [PATCH v2 00/11] Sign Xilinx ZynqMP SPL/FSBL boot images using binman

Hi Lukas, On Thu, 6 Jul 2023 at 09:38, wrote: > > From: Lukas Funke > > > This series adds two etypes to create a verified boot chain for > Xilinx ZynqMP devices. The first etype 'xilinx_fsbl_auth' is used to > create a bootable, signed image for ZynqMP boards using the Xilinx > Bootgen tool. Th

Re: [PATCH v2 11/11] binman: etype: Add xilinx_fsbl_auth etype

Hi Lukas, On Thu, 6 Jul 2023 at 09:38, wrote: > > From: Lukas Funke > > This adds a new etype 'xilinx_fsbl_auth'. Using this etype it is possible > to created an authenticated SPL (FSBL in Xilinx terms) for ZynqMP boards. > > The etype uses Xilinx Bootgen tools in order to transform the SPL into

Re: [PATCH] env: Fix default environment saving issue

not present then > it should save in to primary env area. > > Fix the issue by making env_valid = ENV_INVALID when both the > environments are not present. > > Signed-off-by: Ashok Reddy Soma > --- > > env/common.c | 1 + > 1 file changed, 1 insertion(+) > Reviewe

Re: [PATCH 07/10] test: dm: add SCMI base protocol test

Hi, On Tue, 4 Jul 2023 at 03:35, AKASHI Takahiro wrote: > > Hi Simon, > > On Mon, Jul 03, 2023 at 02:30:57PM +0100, Simon Glass wrote: > > Hi, > > > > On Mon, 3 Jul 2023 at 01:57, AKASHI Takahiro > > wrote: > > > > > > On Thu, Jun 29, 2

Re: [PATCH v2] efi_driver: fix duplicate efiblk#0 issue

Hi Heinrich, On Tue, 4 Jul 2023 at 00:43, Heinrich Schuchardt wrote: > > On 03.07.23 15:30, Simon Glass wrote: > > Hi Masahisa, > > > > On Mon, 3 Jul 2023 at 07:09, Masahisa Kojima > > wrote: > >> > >> The devnum value of th

Re: [PATCH 08/10] cmd: add scmi command for SCMI firmware

Hi, On Tue, 4 Jul 2023 at 02:26, AKASHI Takahiro wrote: > > On Mon, Jul 03, 2023 at 02:30:54PM +0100, Simon Glass wrote: > > Hi, > > > > On Mon, 3 Jul 2023 at 01:55, AKASHI Takahiro > > wrote: > > > > > > On Thu, Jun 29, 2023 at 08:10:

Re: [PATCH 12/12] binman: Support simple templates

Hi Jan, On Fri, 7 Jul 2023 at 11:46, Jan Kiszka wrote: > > On 07.07.23 19:35, Simon Glass wrote: > > Hi Jan, > > > > On Fri, 7 Jul 2023 at 17:03, Jan Kiszka wrote: > >> > >> On 07.07.23 17:35, Simon Glass wrote: > >>> Hi Jan, >

Re: [PATCH v14 11/11] arm_ffa: efi: corstone1000: enable MM communication

Hi Tom, On Fri, 7 Jul 2023 at 11:44, Tom Rini wrote: > > On Fri, Jul 07, 2023 at 11:35:05AM -0600, Simon Glass wrote: > > Hi Abdellatif, > > > > On Fri, 7 Jul 2023 at 15:44, Abdellatif El Khlifi > > wrote: > > > > > > turn on EFI MM commu

Re: imx8mp: issues getting dtb with pcie enabled to boot

Hi, On Fri, 7 Jul 2023 at 14:34, Fabio Estevam wrote: > > Adding Marcel and Francesco. > > On Fri, Jul 7, 2023 at 5:30 PM Sahaj Sarup wrote: > > > > Hi, > > I am working on the imxmp-verdin platform. One of the quirks with > > this particular som is that it uses an internal pcie_phy clock instea

Re: [PATCH] tools/docker: Dockerfile: Don't specify dtc submodule

t; Signed-off-by: Tom Rini > --- > tools/docker/Dockerfile | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Simon Glass

Re: [PATCH] buildman: Switch ARC toolchain to the upstream version

to Tom for pointing to that left-over! > > Signed-off-by: Alexey Brodkin > Cc: Simon Glass > Cc: Tom Rini > --- > tools/buildman/bsettings.py | 1 - > tools/buildman/buildman.rst | 6 -- > tools/docker/Dockerfile | 3 +-- > 3 files changed, 1 insertion(+), 9 deletions(-) Nice! Reviewed-by: Simon Glass

Re: [PATCH 1/2] tools: Fix README file in pyproject.toml of u_boot_pylib.

On Fri, 7 Jul 2023 at 15:17, Maxim Cournoyer wrote: > > * tools/u_boot_pylib/pyproject.toml (readme): Replace README.md with > README.rst. > > Signed-off-by: Maxim Cournoyer > --- > > tools/u_boot_pylib/pyproject.toml | 2 +- > 1 file changed, 1 insertion(+), 1 dele

Re: [PATCH 2/2] tools: Fix package discovery in pyproject.toml of u_boot_pylib.

lib/pyproject.toml: New tool.setuptools.packages.find > section. > > Signed-off-by: Maxim Cournoyer > --- > > tools/u_boot_pylib/pyproject.toml | 4 > 1 file changed, 4 insertions(+) Reviewed-by: Simon Glass

[PATCH v3 00/19] binman: Simple templating feature and mkimage conversion

' and 'inserter' typos Marek Vasut (1): binman: Convert mkimage to Entry_section Simon Glass (18): binman: Correct coverage gap in control binman: Init align_default in entry_Section binman: Use GetEntries() to obtain section contents binman: Read _multiple_data_files in the

[PATCH v3 02/19] binman: Init align_default in entry_Section

This should be set up in the init function, to avoid a warning about a property not set up there. Fix it. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/etype/section.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/binman/etype/section.py b/tools/binman/etype

[PATCH v3 01/19] binman: Correct coverage gap in control

Add a pragma to deal with the code-coverage gap which drops binman down to 90% coverage. Fixes: de65b122a25 (tools: Fall back to importlib_resources on Python 3.6) Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/control.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH v3 04/19] binman: Read _multiple_data_files in the correct place

Move this to the ReadEntries() function where it belongs. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/etype/mkimage.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/binman/etype/mkimage.py b/tools/binman/etype/mkimage.py index e028c4407081

[PATCH v3 03/19] binman: Use GetEntries() to obtain section contents

Some section types don't have a simple _entries list. Use the GetEntries() method in GetEntryContents() and other places to handle this. This makes the behaviour more consistent. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/etype/section.py | 18 +---

[PATCH v3 05/19] binman: Allow disabling symbol writing

Some boards don't use symbol writing but do access the symbols in SPL. Provide an option to work around this. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/binman.rst | 7 ++ tools/binman/entry.py | 4 +++- tools/binman/

[PATCH v3 06/19] stm32mp15: Avoid writing symbols in SPL

;t support symbol writing. But with the upcoming conversion to a section, it will. So add a property to disable symbol writing. Signed-off-by: Simon Glass --- (no changes since v1) arch/arm/dts/stm32mp15-u-boot.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/dts/stm32mp15-u-boot.dt

[PATCH v3 08/19] binman: Add more detail on how ObtainContents() works

This area of binman can be a bit confusing. Add some more comments to help. Signed-off-by: Simon Glass --- Changes in v3: - Add new patch with more detail on how ObtainContents() works tools/binman/entry.py | 3 +++ tools/binman/etype/section.py | 32

[PATCH v3 07/19] binman: Update elf to return number of written symbols

Update the LookupAndWriteSymbols() function to return the number of symbols written. Also add some logging for when debugging is not enabled. Signed-off-by: Simon Glass --- Changes in v3: - Add new patch for elf to return number of written symbols tools/binman/elf.py | 13

[PATCH v3 10/19] binman: Provide a way to specify the fdt-list directly

to be used instead. Signed-off-by: Simon Glass --- Changes in v3: - Fix 'specific' typo tools/binman/entries.rst | 6 +++ tools/binman/etype/fit.py | 9 tools/binman/ftest.py | 14 ++- tools/binman/test/284_fit_fdt_lis

[PATCH v3 09/19] binman: Convert mkimage to Entry_section

From: Marek Vasut This is needed to handle mkimage with inner section located itself in a section. Signed-off-by: Marek Vasut Use BuildSectionData() instead of ObtainContents(), add tests and a few other minor fixes: Signed-off-by: Simon Glass --- Changes in v3: - Fix up some tests which now

[PATCH v3 11/19] binman: Drop __bss_size variable in bss_data.c

This is not needed since the linker script sets it up. Drop the variable to avoid confusion. Fix the prototype for main() while we are here. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/test/bss_data.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a

[PATCH v3 12/19] binman: Correct handling of zero bss size

Fix the check for the __bss_size symbol, since it may be 0. Unfortunately there was no test coverage for this. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/elf_test.py | 5 + tools/binman/etype/u_boot_spl_bss_pad.py | 2 +- tools/binman/etype

[PATCH v3 13/19] dtoc: Support copying the contents of a node into another

This permits implementation of a simple templating system, where a node can be reused as a base for others. For now this adds new subnodes after any existing ones. Signed-off-by: Simon Glass --- Changes in v3: - Add a new devicetree file especially for node copying - Correct logic for merging

[PATCH v3 14/19] dtoc: Allow inserting a list of nodes into another

Provide a way to specify a phandle list of nodes which are to be inserted into an existing node. Signed-off-by: Simon Glass --- Changes in v3: - Adjust to use the new example file tools/dtoc/fdt.py | 19 +++ tools/dtoc/test/dtoc_test_copy.dts | 13

[PATCH v3 15/19] binman: Support simple templates

f an image. Implement this mechanism. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Correct ordering of template nodes - Fix 'preseverd' and 'inserter' typos tools/binman/binman.rst| 82 ++ tools/bin

[PATCH v3 16/19] binman: Support templating with multiple images

Allow a template to appear in the top level description when using multiple images. Signed-off-by: Simon Glass --- Changes in v3: - Drop duplicate dts-v1 header tools/binman/control.py | 5 +++-- tools/binman/ftest.py| 12 +++ tools/binman/test

[PATCH v3 17/19] binman: Add a test for templating in a FIT

Add this as a separate test case. Signed-off-by: Simon Glass --- Changes in v3: - Add new test case for templating in a FIT tools/binman/ftest.py | 7 + tools/binman/test/288_template_fit.dts | 37 ++ 2 files changed, 44 insertions(+) create mode

[PATCH v3 18/19] binman: Support templates at any level

Allow templates to be used inside a section, not just in the top-level /binman node. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/control.py| 5 ++- tools/binman/ftest.py | 8 tools/binman/test/289_template_section.dts | 52

[PATCH v3 19/19] binman: Support writing symbols inside a mkimage image

Add support for writing symbols and determining the assumed position of binaries inside a mkimage image. This is useful as an example for other entry types which might want to do the same thing. Signed-off-by: Simon Glass --- Changes in v3: - Add new patch to support writing symbols inside a

Re: [PATCH u-boot 0/3] Revert broken Bootmenu commits

9:50:39AM +0200, Pali Rohár wrote: > > > > > On Saturday 24 June 2023 12:58:07 Tom Rini wrote: > > > > > > On Sat, Jun 24, 2023 at 10:50:41AM +0200, Pali Rohár wrote: > > > > > > > On Tuesday 20 June 2023 11:20:35 Simon Glass wrote: > > >

Re: [PATCH v14 05/11] log: select physical address formatting in a generic way

Hi Abdellatif, On Mon, 10 Jul 2023 at 06:15, Abdellatif El Khlifi wrote: > > Hi Simon, > > On Fri, Jul 07, 2023 at 06:34:14PM +0100, Simon Glass wrote: > > Hi Abdellatif, > > > > On Fri, 7 Jul 2023 at 15:44, Abdellatif El Khlifi > > wrote: > > > &

Re: [PATCH 0/6] nokia_nx51: Attempts to debug keyboard

Hi Pali, On Mon, 10 Jul 2023 at 08:08, Pali Rohár wrote: > > With this patch series applied, pressing DOWN key on UART prints this > "garbage" on the UART: > > [c=1b] > > [i=0 1] P/DOWN to move, ENTER to select, ESC to quit > > [c=5b] > > [i=0 2] > > [c=42] > > [i=e 0] > [got bkey 0] > > An

Re: [PATCH 2/6] nokia_rx51: Correct tstc() implementation

Hi Pali, On Mon, 10 Jul 2023 at 08:01, Pali Rohár wrote: > > On Saturday 17 June 2023 11:49:49 Simon Glass wrote: > > This returns false even when there are keys in the buffer. > > This is not truth. After scanning HW buffer it returns the correct > information if some key

Re: [PATCH] spl: Add function called after fpga image upload

Hi, On Mon, 10 Jul 2023 at 09:15, Taedcke, Christian wrote: > > > > Am 10.07.2023 um 15:44 schrieb Marek Vasut: > > On 7/10/23 15:02, Taedcke, Christian wrote: > >> Am 10.07.2023 um 13:41 schrieb Michal Simek: > >>> > >>> > >>> On 6/27/23 11:04, christian.taedcke-...@weidmueller.com wrote: >

Re: [PATCH v3 00/19] binman: Simple templating feature and mkimage conversion

Hi Jan, On Sun, 9 Jul 2023 at 23:21, Jan Kiszka wrote: > > On 10.07.23 04:40, Simon Glass wrote: > > This series converts the mkimage entry type to be a section, i.e. based on > > the entry_Section class. This makes it more consistent in its behaviour, > > e.g. all

Re: [PATCH 0/7] rockchip: veyron: Synchronize changes for veyron boards

| 4 +++ > arch/arm/mach-rockchip/rk3288/Kconfig | 6 > configs/chromebit_mickey_defconfig| 6 > configs/chromebook_jerry_defconfig| 1 + > configs/chromebook_minnie_defconfig | 6 +++- > configs/chromebook_speedy_defconfig | 7

<    3   4   5   6   7   8   9   10   11   12   >