Re: [PATCH] arch: mvebu: Disable by default unused peripherals in SPL

2022-07-21 Thread Stefan Roese
g @@ -50,6 +50,7 @@ config DM_USB config SPL_DM_USB bool "Enable driver model for USB host most in SPL" depends on SPL_DM && DM_USB + default n if ARCH_MVEBU default y config DM_USB_GADGET Viele Grüße, Stefan Roese -- DENX Software Engine

Re: [PATCH 2/2] arm: mvebu: a3720: Add NVMe to BOOT_TARGET_DEVICES list

2022-07-21 Thread Stefan Roese
(func, 1) \ BOOT_TARGET_DEVICES_MMC(func, 0) \ BOOT_TARGET_DEVICES_USB(func) \ + BOOT_TARGET_DEVICES_NVME(func) \ BOOT_TARGET_DEVICES_SCSI(func) \ BOOT_TARGET_DEVICES_PXE(func) \ BOOT_TARGET_DEVICES_DHCP(func) Viele Grüße, Stefan Roese -- DENX Software Engineer

Re: [PATCH 1/2] arm: mvebu: a3720: Set BOOT_TARGET_DEVICES list to enabled peripherals

2022-07-21 Thread Stefan Roese
PXE(func) \ + BOOT_TARGET_DEVICES_DHCP(func) #include Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de

Re: [PATCH v5 2/3] arm: mvebu: add support for Methode eDPU

2022-07-21 Thread Stefan Roese
CONFIG_CMD_SPI=y +CONFIG_CMD_USB=y +# CONFIG_CMD_SETEXPR is not set +CONFIG_CMD_TFTPPUT=y +CONFIG_CMD_CACHE=y +CONFIG_CMD_TIME=y +CONFIG_CMD_MVEBU_BUBT=y +CONFIG_CMD_EXT4_WRITE=y +CONFIG_MAC_PARTITION=y +CONFIG_ENV_OVERWRITE=y +CONFIG_ENV_IS_IN_SPI_FLASH=y +CONFIG_SYS_RELOC_GD_ENV_ADDR=y +CONFIG_ARP_TIMEOUT=200 +CONFI

Re: [PATCH v5 3/3] MAINTAINERS: add myself as Methode maintainer

2022-07-21 Thread Stefan Roese
Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de

Re: [PATCH v5 1/3] arm: mvebu: dts: sync DTS

2022-07-21 Thread Stefan Roese
sda-gpios = < 3 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; - nct375@48 { - status = "okay"; + temp-sensor@48 { compatible = "ti,tmp75c"; reg = <0x48>; }; - nct375@49 { - status = "okay"; + temp-

Re: [PATCH] arm64: mvebu: handle non-zero base address for RAM

2022-07-21 Thread Stefan Roese
M_SIZE) - return USABLE_RAM_SIZE; + unsigned long top = CONFIG_SYS_SDRAM_BASE + min(gd->ram_size, USABLE_RAM_SIZE); - return gd->ram_size; + return (gd->ram_top > top) ? top : gd->ram_top; } /* Viele Grüße, Stefan Roese -- DENX Soft

Re: [PATCH] board: turris: Find atsha device by atsha driver

2022-07-21 Thread Stefan Roese
*/ struct udevice *dev; - if (uclass_get_device_by_name(UCLASS_MISC, "crypto@64", )) { + if (uclass_get_device_by_driver(UCLASS_MISC, DM_DRIVER_GET(atsha204), )) { puts("Cannot find ATSHA204A on I2C bus!\n"); dev = NULL; } Viele

Re: [PATCH] arm: mvebu: turris_omnia: Set ETHPRIME to DT alias

2022-07-18 Thread Stefan Roese
Reviewed-by: Stefan Roese Thanks, Stefan --- arch/arm/dts/armada-385-turris-omnia.dts | 6 ++ configs/turris_omnia_defconfig | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/arm/dts/armada-385-turris-omnia.dts b/arch/arm/dts/armada-385-turris

Re: [PATCH] arm: mvebu: Avoid reading MVEBU_REG_PCIE_DEVID register too many times

2022-07-18 Thread Stefan Roese
MVEBU_REG_PCIE_DEVID register, but only once. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- arch/arm/mach-mvebu/cpu.c | 67 ++ arch/arm/mach-mvebu/dram.c | 18 +++ arch/arm/mach-mvebu/include/mach/cpu.h | 9 3

Re: [PATCH 4/4] MIPS: convert CONFIG_SYS_MIPS_TIMER_FREQ to Kconfig

2022-07-18 Thread Stefan Roese
On 10.07.22 17:15, Daniel Schwierzeck wrote: This converts the following to Kconfig: CONFIG_SYS_MIPS_TIMER_REQ Signed-off-by: Daniel Schwierzeck Reviewed-by: Stefan Roese Thanks, Stefan --- arch/mips/Kconfig | 18 ++ configs

Re: [PATCH 3/4] MIPS: mscc: remove unused CPU_CLOCK_RATE

2022-07-18 Thread Stefan Roese
On 10.07.22 17:15, Daniel Schwierzeck wrote: CPU_CLOCK_RATE is just used once for CONFIG_SYS_MIPS_TIMER_FREQ which is migrated to Kconfig in the next patch. Signed-off-by: Daniel Schwierzeck Reviewed-by: Stefan Roese Thanks, Stefan --- include/configs/vcoreiii.h | 4 +--- 1 file

Re: [PATCH 2/4] MIPS: remove CONFIG_SYS_MHZ

2022-07-18 Thread Stefan Roese
On 10.07.22 17:15, Daniel Schwierzeck wrote: Resolve all uses of CONFIG_SYS_MHZ with the currently defined value. Remove code which depends on CONFIG_SYS_MHZ but where no board configs actually use that code. Signed-off-by: Daniel Schwierzeck Reviewed-by: Stefan Roese Thanks, Stefan

Re: [PATCH 1/4] MIPS: remove deprecated TARGET_VCT option

2022-07-18 Thread Stefan Roese
On 10.07.22 17:15, Daniel Schwierzeck wrote: This board has been removed a long time ago. Signed-off-by: Daniel Schwierzeck Reviewed-by: Stefan Roese Thanks, Stefan --- arch/mips/Kconfig | 8 1 file changed, 8 deletions(-) diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig

Re: [PATCH] watchdog: add pulse support to gpio watchdog driver

2022-07-05 Thread Stefan Roese
DM_DRIVER_GET(wdt_gpio), _wdt)); + ut_assertok(uclass_get_device_by_name(UCLASS_WDT, + "wdt-gpio-toggle", _wdt)); ut_assertnonnull(gpio_wdt); ut_assertok(uclass_get_device_by_driver(UCLASS_WDT, DM_DRIVER_GET(wdt_sandbox), _wdt)); Looks good, so: Reviewed-by: Stefan Roese Thanks, Stefan

Re: [PATCH] pci: Add checks to prevent config space overflow

2022-07-04 Thread Stefan Roese
urn -ENOSYS; + } + if (offset < 0 || offset >= 4096) { + *valuep = pci_conv_32_to_size(0, offset, size); + return -EINVAL; + } How about introducing a macro for this 4096 max value instead? Other than this: Reviewed-by: Stefan Roese Thanks, Stefan

Re: [PATCH] serial: ns16550: Wait in debug_uart_init until tx buffer is empty

2022-07-01 Thread Stefan Roese
at the official coding style mentions to such constructs. Anyways: Reviewed-by: Stefan Roese Thanks, Stefan

Re: [PATCH v2] watchdog: add amlogic watchdog support

2022-06-24 Thread Stefan Roese
Hi Neil, On 21.06.22 11:17, Neil Armstrong wrote: Hi Stefan, On 20/06/2022 16:55, Stefan Roese wrote: On 13.06.22 16:00, Philippe Boos wrote: Add support for hardware watchdog timer for Amlogic SoCs. This driver has been heavily inspired by his Linux equivalent (meson_gxbb_wdt.c). Reviewed

Re: [PATCH v2] watchdog: add amlogic watchdog support

2022-06-20 Thread Stefan Roese
auto = sizeof(struct amlogic_wdt_priv), + .probe = amlogic_wdt_probe, + .ops = _wdt_ops, + .flags = DM_FLAG_PRE_RELOC, +}; Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de

Re: [PATCH 04/13] watchdog: designware: Make this depend on WDT

2022-06-20 Thread Stefan Roese
Tan Cc: Marek Vasut Cc: Siew Chin Lim Cc: Stefan Roese Cc: hee Hong Ang Signed-off-by: Tom Rini Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/watchdog/Kconfig | 4 ++-- drivers/watchdog/designware_wdt.c | 21 - include/configs

Re: [PATCH] watchdog: add amlogic watchdog support

2022-06-07 Thread Stefan Roese
ot;amlogic,meson-gxbb-wdt" }, + {} +}; + +U_BOOT_DRIVER(amlogic_wdt) = { + .name = "amlogic_wdt", + .id = UCLASS_WDT, + .of_match = amlogic_wdt_ids, + .priv_auto = sizeof(struct amlogic_wdt_priv), + .probe = amlogic_wdt_probe, + .ops = _wdt_ops, +

Please pull u-boot-watchdog/master

2022-06-07 Thread Stefan Roese
Hi Tom, please pull the following watchdog related fix: - Fix SPL build with watchdog disabled in asm files (Pali) Here the Azure build, without any issues:

Re: [PATCH] watchdog: Fix SPL build with watchdog disabled in asm files

2022-06-07 Thread Stefan Roese
bl watchdog_reset + #endif #else /* Don't require the watchdog to be enabled in SPL */ #if defined(CONFIG_SPL_BUILD) &&\ -- 2.20.1 Viele Grüße, Stefan Roese -- DENX Software Engineering Gm

Re: [PATCH 2/2] mvebu: uDPU: disable non-present peripherals

2022-06-07 Thread Stefan Roese
On 03.06.22 12:53, Robert Marko wrote: uDPU like eDPU does not expose SCSI based peripherals like SATA nor PCI and for sure it does not have the Intel E1000 PCI card. So, like for eDPU remove those from the defconfig. Signed-off-by: Robert Marko Reviewed-by: Stefan Roese Thanks, Stefan

Re: [PATCH 1/2] mvebu: eDPU: disable SCSI support

2022-06-07 Thread Stefan Roese
exposed. So, disable SCSI support in defconfig for eDPU. Signed-off-by: Robert Marko Reviewed-by: Stefan Roese Thanks, Stefan --- configs/eDPU_defconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configs/eDPU_defconfig b/configs/eDPU_defconfig index e2e593ad21

Re: [PATCH v5 2/3] arm: mvebu: add support for Methode eDPU

2022-06-03 Thread Stefan Roese
Lendavska ulica 16a 1 Zagreb, Croatia Email: robert.ma...@sartura.hr Web: www.sartura.hr Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)

Re: [PATCH u-boot-marvell 2/2] treewide: Fix Marek's name and change my e-mail address

2022-06-02 Thread Stefan Roese
On 01.06.22 17:17, Marek Behún wrote: Fix diacritics in some instances of my name and change my e-mail address to ka...@kernel.org. Add corresponding .mailmap entries. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- .mailmap

Re: [PATCH u-boot-marvell 1/2] board: turris: Fix MAINTAINERS and add Pali

2022-06-02 Thread Stefan Roese
On 01.06.22 17:17, Marek Behún wrote: From: Marek Behún Fix MAINTAINERS files for Turris devices, add missing files and add Pali as maintainer. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- MAINTAINERS | 8 board/CZ.NIC

Re: [PATCH 2/5] arm: mvebu: Move internal registers in arch_very_early_init() function

2022-06-01 Thread Stefan Roese
Hi Pali, On 01.06.22 12:27, Pali Rohár wrote: On Friday 06 May 2022 14:44:48 Pali Rohár wrote: On Friday 06 May 2022 14:35:55 Stefan Roese wrote: While doing this I noticed though, that kwboot UART booting only worked in roughly 1 out of 2 cases. With no progress after this line: Sending

Re: [PATCH] tlv_eeprom: Add missing CRC32 dependency

2022-05-30 Thread Stefan Roese
On 30.05.22 10:42, Pali Rohár wrote: tlv_eeprom uses crc32() function, so add dependency into Kconfig. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- cmd/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cmd/Kconfig b/cmd/Kconfig index 69c1814d24af

Re: [PATCH] arch: mvebu: Disable by default unused peripherals in SPL

2022-05-30 Thread Stefan Roese
On 30.05.22 08:31, Stefan Roese wrote: On 24.05.22 10:58, Pali Rohár wrote: SPL on mvebu loads proper U-Boot from custom Marvell kwbimage format and therefore support for other binary formats is not required to be present in SPL. Boot source of proper U-Boot is defined by compile time options

Re: [PATCH 3/3] arm: mvebu: Remove CONFIG_SPL_BOOT_DEVICE

2022-05-30 Thread Stefan Roese
Reviewed-by: Stefan Roese Thanks, Stefan --- include/configs/controlcenterdc.h | 11 --- include/configs/db-88f6820-amc.h | 12 include/configs/db-88f6820-gp.h | 11 --- scripts/config_whitelist.txt | 1 - 4 files changed, 35 deletions(-) diff --git

Re: [PATCH 2/3] Convert CONFIG_FIXED_SDHCI_ALIGNED_BUFFER to Kconfig

2022-05-30 Thread Stefan Roese
y: Chris Packham Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/mmc/Kconfig | 13 + include/configs/clearfog.h| 7 --- include/configs/controlcenterdc.h | 7 --- include/configs/db-88f6820-gp.h | 7 --- include/configs/h

Re: [PATCH 1/3] arm: mvebu: Use MVEBU_SPL_BOOT_DEVICE instead of SPL_BOOT_DEVICE

2022-05-30 Thread Stefan Roese
On 29.05.22 01:13, Chris Packham wrote: Update the way KWB_CFG_SEC_BOOT_DEV is determined to use CONFIG_MVEBU_SPL_BOOT_DEVICE_{SPI,MMC} instead of CONFIG_SPL_BOOT_DEVICE. Signed-off-by: Chris Packham Reviewed-by: Stefan Roese Thanks, Stefan --- arch/arm/mach-mvebu/Makefile | 10

Re: [PATCH] arch: mvebu: Disable by default unused peripherals in SPL

2022-05-30 Thread Stefan Roese
to enable all possible and unused peripherals in SPL by default. This change decrease size of SPL binaries. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- common/spl/Kconfig | 2 ++ disk/Kconfig| 2 ++ drivers/mmc/Kconfig | 1 + drivers/usb/Kconfig | 1 + 4

Re: [PATCH 2/2] arm: mvebu: a3720: Add NVMe to BOOT_TARGET_DEVICES list

2022-05-30 Thread Stefan Roese
On 23.05.22 11:14, Pali Rohár wrote: Enable NVMe booting on boards which have enabled NVMe drivers. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- include/configs/mvebu_armada-37xx.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/configs

Re: [PATCH 1/2] arm: mvebu: a3720: Set BOOT_TARGET_DEVICES list to enabled peripherals

2022-05-30 Thread Stefan Roese
On 23.05.22 11:14, Pali Rohár wrote: This allows to compile U-Boot without some boot option for some A3720 board which does not have that peripheral. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- include/configs/mvebu_armada-37xx.h | 42

Re: [PATCH] ubifs: Fix lockup/crash when reading files

2022-05-30 Thread Stefan Roese
Added Tom to Cc... On 23.05.22 11:25, Pali Rohár wrote: On Thursday 19 May 2022 10:04:31 Pali Rohár wrote: On Thursday 19 May 2022 07:01:19 Stefan Roese wrote: On 17.05.22 22:45, Pali Rohár wrote: Commit b1a14f8a1c2e ("UBIFS: Change ubifsload to not read beyond the requested size&qu

[PATCH 7/7] mips: octeon_nic23: Add PCIe FLR fixup via cyclic infrastructure

2022-05-25 Thread Stefan Roese
that this function gets called every 100us, which is needed to detect this FLR issue. Signed-off-by: Aaron Williams Signed-off-by: Stefan Roese --- board/Marvell/octeon_nic23/board.c | 197 + configs/octeon_nic23_defconfig | 3 + 2 files changed, 200 insertions(+) diff

[PATCH 6/7] sandbox: Add cyclic demo function

2022-05-25 Thread Stefan Roese
This patch enables the cyclic infrastructure on sandbox and also adds one simple example/demo functions using this cyclic functionality. Signed-off-by: Stefan Roese --- board/sandbox/sandbox.c | 15 +++ configs/sandbox_defconfig | 2 ++ 2 files changed, 17 insertions(+) diff

[PATCH 5/7] cyclic: Add 'cyclic list' command

2022-05-25 Thread Stefan Roese
.13 times/s As you can see, the cpu-time is accounted, so that cyclic functions that take too long might be discovered. Additionally the frequency is logged. Signed-off-by: Stefan Roese --- MAINTAINERS | 1 + cmd/Kconfig | 6 ++ cmd/Makefile | 1 + cmd/cyclic.c |

[PATCH 3/7] cyclic: Integrate cyclic infrastructure into WATCHDOG_RESET

2022-05-25 Thread Stefan Roese
periods. If CONFIG_WATCHDOG is not enabled, only cyclic_run() without calling watchdog_reset(). This guarantees that the cyclic functionality does not rely on CONFIG_WATCHDOG being enabled. Signed-off-by: Stefan Roese --- fs/cramfs/uncompress.c | 2 +- include/watchdog.h | 23

[PATCH 2/7] cyclic: Add basic support for cyclic function execution infrastruture

2022-05-25 Thread Stefan Roese
scheduled and executed at their configured periods. This cyclic infrastructure will be used by a board specific function on the NIC23 MIPS Octeon board, which needs to check periodically, if a PCIe FLR has occurred. Signed-off-by: Stefan Roese --- MAINTAINERS | 6 +++ common/Kconfig

[PATCH 4/7] cyclic: Integrate cyclic functionality at bootup in board_r/f

2022-05-25 Thread Stefan Roese
This patch adds a call to cyclic_init() to board_f/r.c, enabling the common cyclic infrastructure. After this it's possible to add cyclic functions via cyclic_register(). Signed-off-by: Stefan Roese --- common/board_f.c | 2 ++ common/board_r.c | 2 ++ 2 files changed, 4 insertions(+) diff

[PATCH 1/7] time: Import time_after64() and friends from Linux

2022-05-25 Thread Stefan Roese
. These macros were copied from include/linux/jiffies.h of Linux 5.18. Signed-off-by: Stefan Roese --- include/time.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/include/time.h b/include/time.h index 9deb2cf61cc4..3b2ba0912470 100644 --- a/include/time.h +++ b/include

[PATCH 0/7] Add support for cyclic function execution infrastruture

2022-05-25 Thread Stefan Roese
esting etc). Thanks, Stefan Aaron Williams (1): mips: octeon_nic23: Add PCIe FLR fixup via cyclic infrastructure Stefan Roese (6): time: Import time_after64() and friends from Linux cyclic: Add basic support for cyclic function execution infrastruture cyclic: Integrate cyclic infr

Re: [PATCH v5 2/3] arm: mvebu: add support for Methode eDPU

2022-05-20 Thread Stefan Roese
duplication, split the uDPU DTS into a common one. Signed-off-by: Robert Marko Reviewed-by: Stefan Roese Thanks, Stefan --- Changes in v4: * Remove CMD_PCI as PCI is disabled anyway Changes in v3: * Use DTS-es pending merge upstream * Re-enable SCSI as the Armada 37xx BOOT_TARGET_DEVICES

Re: [PATCH v5 1/3] arm: mvebu: dts: sync DTS

2022-05-20 Thread Stefan Roese
Reviewed-by: Stefan Roese Thanks, Stefan --- arch/arm/dts/armada-3720-uDPU.dts | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/arch/arm/dts/armada-3720-uDPU.dts b/arch/arm/dts/armada-3720-uDPU.dts index 1f534c0c65..f21a855fc6 100644 --- a/arch

Re: [PATCH v5 3/3] MAINTAINERS: add myself as Methode maintainer

2022-05-20 Thread Stefan Roese
On 20.05.22 13:46, Robert Marko wrote: I am currently maintaing the Methode uDPU and eDPU boards so add myself as the maintainer for them. Remove the old entry from board/Marvell/mvebu_armada-37xx/MAINTAINERS. Signed-off-by: Robert Marko Reviewed-by: Stefan Roese Thanks, Stefan

Re: [PATCH v4 3/3] MAINTAINERS: add myself as Methode maintainer

2022-05-20 Thread Stefan Roese
On 20.05.22 13:26, Robert Marko wrote: On Fri, May 20, 2022 at 1:17 PM Stefan Roese wrote: On 20.05.22 13:12, Robert Marko wrote: I am currently maintaing the Methode uDPU and eDPU boards so add myself as the maintainer for them. Signed-off-by: Robert Marko --- MAINTAINERS | 8

Re: [PATCH v4 3/3] MAINTAINERS: add myself as Methode maintainer

2022-05-20 Thread Stefan Roese
, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de

Re: [PATCH] board: turris: Find atsha device by atsha driver

2022-05-19 Thread Stefan Roese
: Reviewed-by: Stefan Roese Thanks, Stefan --- board/CZ.NIC/turris_atsha_otp.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/board/CZ.NIC/turris_atsha_otp.c b/board/CZ.NIC/turris_atsha_otp.c index 8c39f5e52414..e62b7ee2a49a 100644 --- a/board/CZ.NIC

Re: [PATCH] arm64: mvebu: handle non-zero base address for RAM

2022-05-19 Thread Stefan Roese
M_SIZE; + unsigned long top = CONFIG_SYS_SDRAM_BASE + min(gd->ram_size, USABLE_RAM_SIZE); - return gd->ram_size; + return (gd->ram_top > top) ? top : gd->ram_top; } Reviewed-by: Stefan Roese Thanks, Stefan

Re: [PATCH] pci: Handle failed calloc in decode_regions()

2022-05-19 Thread Stefan Roese
On 19.05.22 18:48, Pierre-Clément Tosi wrote: Add a check for calloc() failing to allocate the requested memory. Make decode_regions() return an error code. Cc: Bin Meng Cc: Simon Glass Cc: Stefan Roese Signed-off-by: Pierre-Clément Tosi Reviewed-by: Stefan Roese Thanks, Stefan

Re: [PATCH] ubifs: Fix lockup/crash when reading files

2022-05-18 Thread Stefan Roese
ENOENT. This patch fixes ubifsload on P2020. Fixes: b1a14f8a1c2e ("UBIFS: Change ubifsload to not read beyond the requested size") Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese --- Stefan, could you please look at this patch? Mentioned commit was introduced by you more tha

Please pull u-boot-marvell/master

2022-05-17 Thread Stefan Roese
Hi Tom, please pull this next batch of mostly Marvell related patches: - Misc Kconfig cleanups (Chris & Pali) - turris_omnia: Fix hangup in debug UART (this introduces TPL/SPL_DEBUG_UART_BASE) Pali - mvebu: uDPU: include

Re: [PATCH 1/2] pinctrl: probe pinctrl drivers during post-bind

2022-05-17 Thread Stefan Roese
nd.\n"); return -EINVAL; Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de

Re: [PATCH] mvebu: uDPU: include fixed-phy support

2022-05-17 Thread Stefan Roese
NFIG_PHY_FIXED=y CONFIG_PHY_GIGE=y CONFIG_E1000=y CONFIG_MVNETA=y Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de

Re: [PATCH] arm: mvebu: turris_{omnia,mox}: Enable CONFIG_NETCONSOLE

2022-05-17 Thread Stefan Roese
+68,7 @@ CONFIG_USE_ETHPRIME=y CONFIG_ETHPRIME="ethernet@34000" CONFIG_ARP_TIMEOUT=200 CONFIG_NET_RETRY_COUNT=50 +CONFIG_NETCONSOLE=y CONFIG_SPL_OF_TRANSLATE=y CONFIG_AHCI_PCI=y CONFIG_AHCI_MVEBU=y Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managin

Re: [PATCH 0/5] arm: mvebu: turris_omnia: Fix hangup in debug UART

2022-05-17 Thread Stefan Roese
On 06.05.22 11:05, Pali Rohár wrote: If proper U-Boot on Turris Omnia tries to print something on debug UART then CPU hangs. Reason is that debug UART in proper U-Boot for Turris Omnia has incorrect configuration of base register. Base register is different in SPL and also in different stages of

Re: [PATCH 7/5] serial: Add new config option TPL_DEBUG_UART_BASE

2022-05-17 Thread Stefan Roese
On 16.05.22 18:49, Pali Rohár wrote: TPL_DEBUG_UART_BASE is same as DEBUG_UART_BASE, but applies only for TPL. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/serial/Kconfig | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/serial

Re: [PATCH] cmd: mvebu: Hide bubt specific options when bubt is disabled

2022-05-17 Thread Stefan Roese
t;bubt" command if the source file name is omitted +endif + config CMD_MVEBU_COMPHY_RX_TRAINING bool "mvebu_comphy_rx_training" depends on ARMADA_8K Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich,

Re: [PATCH] arm: mvebu: Remove unused ARMADA_64BIT

2022-05-17 Thread Stefan Roese
SPL_SYS_NO_VECTOR_TABLE if SPL -config ARMADA_64BIT - bool - select ARM64 - # ARMv7 SoCs... config ARMADA_375 bool Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Re: [PATCH 0/5] arm: mvebu: turris_omnia: Fix hangup in debug UART

2022-05-16 Thread Stefan Roese
Hi Pali, On 06.05.22 11:05, Pali Rohár wrote: If proper U-Boot on Turris Omnia tries to print something on debug UART then CPU hangs. Reason is that debug UART in proper U-Boot for Turris Omnia has incorrect configuration of base register. Base register is different in SPL and also in different

Re: [PATCH] arm: mvebu: Espressobin: Add NVMe to boot targets

2022-05-16 Thread Stefan Roese
Hi Pali, On 03.05.22 11:01, Pali Rohár wrote: NVMe support is already enabled, so add it into boot targets. Signed-off-by: Pali Rohár --- include/configs/mvebu_armada-37xx.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/configs/mvebu_armada-37xx.h

Re: [PATCH 2/2] arm: mvebu: add support for Methode eDPU

2022-05-16 Thread Stefan Roese
On 16.05.22 10:52, Robert Marko wrote: On Mon, May 16, 2022 at 8:40 AM Stefan Roese wrote: On 06.05.22 20:01, Robert Marko wrote: Methode eDPU is an Armada 3720 power board based on the Methode uDPU. They feature the same CPU, RAM, and storage as well as the form factor. However, eDPU only

Re: [PATCH 2/2] arm: mvebu: add support for Methode eDPU

2022-05-16 Thread Stefan Roese
duplication, split the uDPU DTS into a common one. Signed-off-by: Robert Marko Reviewed-by: Stefan Roese Thanks, Stefan --- arch/arm/dts/armada-3720-eDPU-u-boot.dtsi | 45 ++ arch/arm/dts/armada-3720-eDPU.dts | 14 ++ arch/arm/dts/armada-3720-uDPU.dts | 153

Re: [PATCH 1/2] pinctrl: probe pinctrl drivers during post-bind

2022-05-16 Thread Stefan Roese
-off-by: Robert Marko Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/pinctrl/pinctrl-uclass.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/pinctrl/pinctrl-uclass.c b/drivers/pinctrl/pinctrl-uclass.c index 4462ed20e2..38ce2b5e0a 100644 --- a/drivers/pinctrl/pinctrl

Re: [PATCH 6/5] arm: mvebu: Fix DEBUG_UART_BASE for all 32-bit boards

2022-05-16 Thread Stefan Roese
Reviewed-by: Stefan Roese Thanks, Stefan --- configs/clearfog_defconfig | 3 ++- configs/controlcenterdc_defconfig | 3 ++- configs/db-88f6820-amc_defconfig| 3 ++- configs/db-88f6820-gp_defconfig | 3 ++- configs/db-mv784mp-gp_defconfig | 3 ++- configs

Re: [PATCH 5/5] arm: mvebu: turris_omnia: Fix DEBUG_UART_BASE

2022-05-16 Thread Stefan Roese
of proper U-Boot when it is trying to print something via debug UART. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- configs/turris_omnia_defconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configs/turris_omnia_defconfig b/configs

Re: [PATCH 4/5] serial: ns16550: Add support for SPL_DEBUG_UART_BASE

2022-05-16 Thread Stefan Roese
On 06.05.22 11:05, Pali Rohár wrote: Use CONFIG_VAL(DEBUG_UART_BASE) instead of CONFIG_DEBUG_UART_BASE, so proper config value (CONFIG_DEBUG_UART_BASE or CONFIG_SPL_DEBUG_UART_BASE) is used based on building target. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan

Re: [PATCH 3/5] serial: Add new config option SPL_DEBUG_UART_BASE

2022-05-16 Thread Stefan Roese
On 06.05.22 11:05, Pali Rohár wrote: SPL_DEBUG_UART_BASE is same as DEBUG_UART_BASE, but applies only for SPL. In some cases base address of UART is different in SPL and proper U-Boot. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/serial/Kconfig | 7

Re: [PATCH 2/5] arm: mvebu: Move internal registers in arch_very_early_init() function

2022-05-16 Thread Stefan Roese
of arch_cpu_init(). Movement is done in proper U-Boot, not in SPL. SPL may return to bootrom and bootrom requires internal registers at (old) expected location. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- arch/arm/mach-mvebu/Kconfig| 1 + arch/arm/mach-mvebu/Makefile

Re: [PATCH 1/5] arm: Add new config option ARCH_VERY_EARLY_INIT

2022-05-16 Thread Stefan Roese
Reviewed-by: Stefan Roese Thanks, Stefan --- arch/arm/Kconfig| 6 ++ arch/arm/lib/crt0.S | 5 + 2 files changed, 11 insertions(+) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 0afec5155b1b..9898c7d68e1b 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -401,6

[PATCH 1/2] watchdog: octeontx_wdt: Add MIPS Octeon support

2022-05-11 Thread Stefan Roese
port on the EBB7304 eval board. Signed-off-by: Stefan Roese Cc: Aaron Williams Cc: Chandrakala Chavva --- drivers/watchdog/Kconfig| 9 ++--- drivers/watchdog/octeontx_wdt.c | 67 - 2 files changed, 53 insertions(+), 23 deletions(-) diff --git a/drivers/watc

[PATCH 2/2] mips: octeon: octeon_ebb7304_defconfig: Enable watchdog support

2022-05-11 Thread Stefan Roese
This patch enables the recently added watchdog support on the MIPS Octeon EBB7304 eval board. Signed-off-by: Stefan Roese Cc: Aaron Williams Cc: Chandrakala Chavva Cc: Daniel Schwierzeck --- configs/octeon_ebb7304_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs

Re: [PATCH] net: fix phy_string_for_interface

2022-05-10 Thread Stefan Roese
d-off-by: Tim Harvey Cc: Marek Behún Cc: Stefan Roese Cc: Ramon Fried Cc: Vladimir Oltean Reviewed-by: Stefan Roese Thanks, Stefan --- include/phy_interface.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/phy_interface.h b/include/phy_interface.

Re: [PATCH v4 06/25] mips: mtmips: add two reference boards for mt7621

2022-05-10 Thread Stefan Roese
and SDXC is not available. Reviewed-by: Daniel Schwierzeck Signed-off-by: Weijie Gao Reviewed-by: Stefan Roese Thanks, Stefan --- v4 changes: Modify defconfig files for booting from flash v3 changes: none v2 changes: Add config file for mt7621-rfb boards --- arch/mips/dts/Makefile

Re: [PATCH] arm: mvebu: turris_{omnia,mox}: Enable CONFIG_NETCONSOLE

2022-05-09 Thread Stefan Roese
On 09.05.22 11:12, Pali Rohár wrote: This allows to use U-Boot console on Turris devices via network. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- configs/turris_mox_defconfig | 1 + configs/turris_omnia_defconfig | 1 + 2 files changed, 2 insertions

Re: [PATCH 2/5] arm: mvebu: Move internal registers in arch_very_early_init() function

2022-05-06 Thread Stefan Roese
On 06.05.22 14:16, Stefan Roese wrote: On 06.05.22 14:09, Pali Rohár wrote: On Friday 06 May 2022 14:04:53 Stefan Roese wrote: On 06.05.22 11:05, Pali Rohár wrote: Moving of internal registers from INTREG_BASE_ADDR_REG to SOC_REGS_PHY_BASE needs to be done very early, prior calling any

Re: [PATCH] mvebu: uDPU: include fixed-phy support

2022-05-06 Thread Stefan Roese
commit not enabling fixed-phy support in defconfig like it did for other boards. Fixes: 77fcf3cf1251 ("net: mvneta: Convert to use PHY_FIXED for fixed-link") Signed-off-by: Robert Marko Reviewed-by: Stefan Roese Thanks, Stefan --- configs/uDPU_defconfig | 1 + 1 file changed, 1 in

Re: [PATCH 5/5] arm: mvebu: turris_omnia: Fix DEBUG_UART_BASE

2022-05-06 Thread Stefan Roese
=y Isn't such a change now needed for all 32bit Armada MVEBU targets? Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de

Re: [PATCH 2/5] arm: mvebu: Move internal registers in arch_very_early_init() function

2022-05-06 Thread Stefan Roese
On 06.05.22 14:09, Pali Rohár wrote: On Friday 06 May 2022 14:04:53 Stefan Roese wrote: On 06.05.22 11:05, Pali Rohár wrote: Moving of internal registers from INTREG_BASE_ADDR_REG to SOC_REGS_PHY_BASE needs to be done very early, prior calling any function which may touch internal registers

Re: [PATCH 2/5] arm: mvebu: Move internal registers in arch_very_early_init() function

2022-05-06 Thread Stefan Roese
EGS_PHY_BASE */ + ldr r0, =SOC_REGS_PHY_BASE + ldr r1, =INTREG_BASE_ADDR_REG + str r0, [r1] + add r0, r0, #0xC000 + mcr p15, 4, r0, c15, c0 + + bx lr +ENDPROC(arch_very_early_init) Viele Grüße, Stefan Roese -- DENX Software Engineering Gmb

Re: [PATCH] watchdog: Add MAX6370 watchdog timer driver

2022-05-06 Thread Stefan Roese
t_reset, +}; + +static const struct udevice_id max6370_wdt_ids[] = { + { .compatible = "maxim,max6370" }, + {} +}; + +U_BOOT_DRIVER(max6370_wdt) = { + .name = "max6370_wdt", + .id = UCLASS_WDT, + .of_match = max6370_wdt_ids, + .probe = max6370_wdt_pro

Please pull u-boot-watchdog/master

2022-05-06 Thread Stefan Roese
Hi Tom, please pull the following watchdog related patch: - Add MAX6370 watchdog timer driver (Pali) Here the Azure build, without any issues:

Re: [PATCH] watchdog: Add MAX6370 watchdog timer driver

2022-05-05 Thread Stefan Roese
On 05.05.22 19:15, Pali Rohár wrote: On Thursday 05 May 2022 11:36:09 Pali Rohár wrote: On Tuesday 03 May 2022 07:16:34 Stefan Roese wrote: On 02.05.22 18:41, Pali Rohár wrote: MAX6370 watchdog is available e.g. on Freescale P1/P2 RDB-PC boards. Signed-off-by: Pali Rohár --- drivers

Re: [PATCH 04/12] cmd: tlv_eeprom: convert functions used by command to api functions

2022-05-04 Thread Stefan Roese
Hi Josua, On 03.05.22 21:09, Josua Mayer wrote: \o/ Am 03.05.22 um 13:54 schrieb Stefan Roese: Hi Josua, On 03.05.22 09:17, Josua Mayer wrote: Am 03.05.22 um 09:16 schrieb Stefan Roese: On 02.05.22 16:18, Josua Mayer wrote: - prog_eeprom: write_tlvinfo_tlv_eeprom - update_crc

Re: [PATCH] arm: mvebu: Remove unused ARMADA_64BIT

2022-05-04 Thread Stefan Roese
On 05.05.22 04:09, Chris Packham wrote: Nothing selects ARMADA_64BIT. Instead the 64-bit SoCs just select ARM64 directly. Remove the unused config item. Signed-off-by: Chris Packham Reviewed-by: Stefan Roese Thanks, Stefan --- arch/arm/mach-mvebu/Kconfig | 4 1 file changed, 4

Please pull u-boot-marvell/master

2022-05-04 Thread Stefan Roese
net: mvneta: Drop unneeded macro Stefan Roese (12): mips: octeon: Misc changes to existing headers for upcoming eth support mips: octeon: Misc changes to existing C files for upcoming eth support mips: octeon: Makefile: Enable building of the newly added C files mips: oc

Re: [PATCH u-boot-marvell 00/19] some mvneta changes, cleanups, fixes

2022-05-04 Thread Stefan Roese
On 27.04.22 12:41, Marek Behún wrote: From: Marek Behún Hello Stefan, here come some refactors, cleanups and fixed for the mvneta driver. Marek Behún (19): net: mvneta: Get rid of platdata net: mvneta: Fix 10Mbps speed net: mvneta: Use DM MDIO API for connecting PHY net: mvneta:

Re: [PATCH v2 00/52] mips: octeon: Add ethernet support

2022-05-04 Thread Stefan Roese
On 07.04.22 09:11, Stefan Roese wrote: This patchset adds the networking files and drivers including device helper headers and C files. Please excuse the massive amount of files in this patch series. Also the sometimes huge files (mostly headers with register definitions) that I needed

Re: [PATCH] Convert CONFIG_MTD_CONCAT to Kconfig

2022-05-03 Thread Stefan Roese
. Reviewed-by: Stefan Roese Thanks, Stefan configs/etamin_defconfig | 1 + drivers/mtd/Kconfig | 8 include/configs/etamin.h | 1 - include/configs/octeontx_common.h | 1 - scripts/config_whitelist.txt | 1 - 5 files changed, 9 insertions(+), 3

Re: [PATCH] cmd: mvebu: Hide bubt specific options when bubt is disabled

2022-05-03 Thread Stefan Roese
On 03.05.22 11:13, Pali Rohár wrote: CONFIG_MVEBU_NAND_BOOT, CONFIG_MVEBU_SPI_BOOT, CONFIG_MVEBU_MMC_BOOT and CONFIG_MVEBU_UBOOT_DFLT_NAME are unused when CONFIG_CMD_MVEBU_BUBT is not enabled. So hide them. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- cmd

Re: [PATCH] arm: mvebu: Espressobin: Add NVMe to boot targets

2022-05-03 Thread Stefan Roese
On 03.05.22 11:01, Pali Rohár wrote: NVMe support is already enabled, so add it into boot targets. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- include/configs/mvebu_armada-37xx.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/configs

Re: [PATCH 04/12] cmd: tlv_eeprom: convert functions used by command to api functions

2022-05-03 Thread Stefan Roese
Hi Josua, On 03.05.22 09:17, Josua Mayer wrote: Am 03.05.22 um 09:16 schrieb Stefan Roese: On 02.05.22 16:18, Josua Mayer wrote: - prog_eeprom: write_tlvinfo_tlv_eeprom - update_crc: tlvinfo_update_crc - is_valid_tlv: is_valid_tlvinfo_entry - is_checksum_valid: tlvinfo_check_crc So while

Re: [PATCH 04/12] cmd: tlv_eeprom: convert functions used by command to api functions

2022-05-03 Thread Stefan Roese
vided. + * 1. The type code is not reserved (0x00 or 0xFF) + */ +static inline bool is_valid_tlvinfo_entry(struct tlvinfo_tlv *tlv) +{ + return((tlv->type != 0x00) && (tlv->type != 0xFF)); +} + #endif /* __TLV_EEPROM_H_ */ Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de

Re: [PATCH 03/12] cmd: tlv_eeprom: do_tlv_eeprom: stop using non-api read_eeprom function

2022-05-03 Thread Stefan Roese
On 02.05.22 16:18, Josua Mayer wrote: IN the scope of do_tlv_eeprom, the error-checking provided by the Nitpicking: "In ..." read_eeprom function is not required. Instead use the API function read_tlv_eeprom. Signed-off-by: Josua Mayer Reviewed-by: Stefan Roese Than

Re: [PATCH 02/12] cmd: tlv_eeprom: remove use of global variable has_been_read

2022-05-03 Thread Stefan Roese
has_been_read = -1; You are not introducing this variable but still it would be "better" to change it to bool instead IMHO. Other than this: Reviewed-by: Stefan Roese Thanks, Stefan // If no arguments, read the EERPOM and display its contents if

Re: [PATCH 01/12] cmd: tlv_eeprom: remove use of global variable current_dev

2022-05-03 Thread Stefan Roese
that is). On 02.05.22 16:18, Josua Mayer wrote: Make tlv_eeprom command device selection an explicit parameter of all function calls. Signed-off-by: Josua Mayer Reviewed-by: Stefan Roese Thanks, Stefan --- cmd/tlv_eeprom.c | 50 ++-- include/tlv_eeprom.h | 3

<    4   5   6   7   8   9   10   11   12   13   >