Re: [PATCH 2/2] board: rpi: remove leftover CONFIG_HW_WATCHDOG block

2024-07-11 Thread Stefan Roese
x watchdog driver and its references), but this block was left behind. Another rpi watchdog driver has since been added, but that does not select HW_WATCHDOG, so this remains dead and unused. Remove it. Signed-off-by: Rasmus Villemoes Reviewed-by: Stefan Roese Thanks, Stefan --- board/r

Re: [PATCH v2 0/2] a little RPi watchdog cleanup

2024-07-14 Thread Stefan Roese
board: rpi: remove leftover CONFIG_HW_WATCHDOG block arch/arm/mach-bcm283x/reset.c | 7 ++- board/raspberrypi/rpi/rpi.c | 4 2 files changed, 2 insertions(+), 9 deletions(-) Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235

Re: [PATCH] arm: dts: mvebu: Migrate to upstream DT for Synology DS116 (Armada 385) board

2024-07-15 Thread Stefan Roese
ly one pin for UART1, as mpp20 is used by sata0 */ - uart1_pins: uart-pins-1 { - marvell,pins = "mpp19"; - marvell,function = "ua1"; - }; - - xhci0_vbus_pins: xhci0_vbus_pins { - marvell,pins = "mpp58"; -

Re: [PATCH v3] arm: mvebu: Enable bootstd and other modernization for Synology DS414 (Armada XP) board

2024-07-15 Thread Stefan Roese
HCD=y -CONFIG_USB_STORAGE=y diff --git a/include/configs/ds414.h b/include/configs/ds414.h index 6fbcec0898..9525657558 100644 --- a/include/configs/ds414.h +++ b/include/configs/ds414.h @@ -1,5 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0+ */ /* + * Copyright (C) 2024 Tony Dinh * Copyright (C) 2

Please pull u-boot-marvell/master

2024-07-15 Thread Stefan Roese
Hi Tom, please pull this small batch of Marvell related patches: - mvebu: Migrate to upstream DT for Synology DS116 (Armada 385) board (Tony) - mvebu: Enable bootstd and other modernization for Synology DS414 (Armada XP) board (To

Re: [PATCH v2 0/2] a little RPi watchdog cleanup

2024-07-15 Thread Stefan Roese
On 7/15/24 15:03, Rasmus Villemoes wrote: Stefan Roese writes: @Tom, I can't find these patches (and v1) in patchworks. Do you have an idea, why this is the case? Perhaps because they (v2) have already been merged to master via a PR from Peter? commit 1ca216522d4. Ah, I was not

Re: [PATCH v2] net: mv88e6xxx: fix missing SMI address initialization

2024-01-09 Thread Stefan Roese
return -EINVAL; + } + priv->smi_addr = smi_addr; + /* probe internal mdio bus */ ret = mv88e6xxx_probe_mdio(dev); if (ret) Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Ramon, this patch was assigned to me as an Marvell MVEBU patc

Re: [PATCH 1/2] arm: mvebu: clearfog gtr: add config option to select serdes0 interface

2024-01-09 Thread Stefan Roese
board_serdes_map[0].serdes_mode = PEX_ROOT_COMPLEX_X1; + } } else if (sr_product_is(&cf_tlv_data, "Clearfog Pro")) { /* handle recognized product as noop, no adjustment required */ } else if (sr_product_is(&cf_tlv_data, "Clear

Re: [PATCH v3 1/3] arm: mvebu: Espressobin: move FDT fixup into a separate function

2024-01-09 Thread Stefan Roese
separate function and call it if compatible matches, there should be no functional change. Signed-off-by: Robert Marko Reviewed-by: Stefan Roese Hi Stefan, Since 2024.01 was released, can this series be pulled in now? It's on my list. I actually already started with some CI build tests.

Re: [PATCH] arm: mvebu: AC5: Use finer grained memory map

2024-01-10 Thread Stefan Roese
, + .attrs = AC5_PTE_BLOCK_DEVICE, + }, + { + .phys = 0x8000, + .virt = 0x8000, + .size = SZ_2G, + .attrs = AC5_PTE_BLOCK_DEVICE, }, { 0, Viele Grüße, Stefan Roese -- DENX Software

Re: [PATCH v3 1/3] arm: mvebu: Espressobin: move FDT fixup into a separate function

2024-01-10 Thread Stefan Roese
no functional change. Signed-off-by: Robert Marko Reviewed-by: Stefan Roese Applied to u-boot-marvell/master Thanks, Stefan --- board/Marvell/mvebu_armada-37xx/board.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/board/Marvell/mvebu_armada-37xx

Re: [PATCH v3 2/3] arm: mvebu: Espressobin: move network setup into a separate function

2024-01-10 Thread Stefan Roese
be no functional change. Signed-off-by: Robert Marko Reviewed-by: Stefan Roese Applied to u-boot-marvell/master Thanks, Stefan --- Changes in v2: * Rebase on top of current master and resolve conflicts board/Marvell/mvebu_armada-37xx/board.c | 17 - 1 file changed, 12

Re: [PATCH v3 3/3] arm: mvebu: eDPU: support new board revision

2024-01-10 Thread Stefan Roese
U-Boot, so we disable both ports. Signed-off-by: Robert Marko Reviewed-by: Stefan Roese Applied to u-boot-marvell/master Thanks, Stefan --- Changes in v3: * Add check for DM_MDIO arch/arm/dts/armada-3720-eDPU-u-boot.dtsi | 13 ++- arch/arm/dts/armada-3720-eDPU.dts | 47

Please pull u-boot-marvell/master

2024-01-10 Thread Stefan Roese
Hi Tom, please pull this next batch of Marvell related patches: - AC5: Use finer grained memory map (Chris) - Espressobin: Misc improvements (Robert) - eDPU: Support new board revision (Robert) -

Re: [PATCH 3/3] arm: mvebu: helios-4: add defconfig for spi booting

2024-01-22 Thread Stefan Roese
Hi Josua, On 1/13/24 18:22, Tom Rini wrote: On Sat, Jan 13, 2024 at 05:36:57PM +0100, Josua Mayer wrote: Add a new defconfig based on existing helios4_config file to support booting from spi flash. Settings for environment location are based on vendor u-boot: https://github.com/kobol-io/u-boo

Re: [PATCH v2 0/2] board: solidrun: clearfog gtr: add serdes configuration

2024-01-22 Thread Stefan Roese
On 1/12/24 14:35, Josua Mayer wrote: Add missing configuration options for clearog gtr serdes: 1. select between sata and pci-e for serdes 0 2. configure serdes 2 for 2.5Gbps link with managed switch Signed-off-by: Josua Mayer --- Changes in v2: - change choice default logic to remove kconfig

Please pull u-boot-marvell/master

2024-01-22 Thread Stefan Roese
Hi Tom, please pull this next batch of Marvell related patches: - solidrun: clearfog gtr: add serdes configuration (Josua) Here the Azure build, without any issues:

Re: [PATCH V4 2/2] configs: andes: add watchdog support fot andes ae350

2024-01-24 Thread Stefan Roese
V # " CONFIG_CMD_IMLS=y CONFIG_CMD_MMC=y CONFIG_CMD_SF_TEST=y +CONFIG_CMD_WDT=y # CONFIG_CMD_SETEXPR is not set CONFIG_BOOTP_PREFER_SERVERIP=y CONFIG_CMD_CACHE=y @@ -50,3 +51,6 @@ CONFIG_BAUDRATE=38400 CONFIG_SYS_NS16550=y CONFIG_SPI=y CONFIG_ATCSPI200_SPI=y +# CONFIG_WATCHDOG_AUTOS

Re: [PATCH V4 2/2] configs: andes: add watchdog support fot andes ae350

2024-02-01 Thread Stefan Roese
Hi Randolph, On 1/31/24 07:30, Randolph Lin wrote: On Wed, Jan 24, 2024 at 09:37:41AM +0100, Stefan Roese wrote: Hi Stefan, Thank you for testing and reviewing. I have checked the error message and the relationship to my patch. The reason for the failure has nothing to do with my patch. Could

Re: [PATCH V4 1/2] drivers: watchdog: add andes atcwdt200 support

2024-02-01 Thread Stefan Roese
.stop = atcwdt_wdt_stop, + .expire_now = atcwdt_wdt_expire_now, +}; + +static const struct udevice_id atcwdt_wdt_ids[] = { + {.compatible = "andestech,atcwdt200"}, + {} +}; + +U_BOOT_DRIVER(atcwdt) = { + .name = "atcwdt200", + .id = UCLASS_WDT, + .probe =

Re: [PATCH V4 2/2] configs: andes: add watchdog support fot andes ae350

2024-02-01 Thread Stefan Roese
IG_BAUDRATE=38400 CONFIG_SYS_NS16550=y CONFIG_SPI=y CONFIG_ATCSPI200_SPI=y +# CONFIG_WATCHDOG_AUTOSTART is not set +CONFIG_WDT=y +CONFIG_WDT_ATCWDT200=y Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 G

Please pull u-boot-watchdog/master

2024-02-01 Thread Stefan Roese
Hi Tom, please pull the following watchdog related last minute fixes: - add andes atcwdt200 support (Randolph) Here the Azure build, without any issues: https://dev

Re: Error building PX30 Ringneck with WDT support

2023-11-16 Thread Stefan Roese
Hi Quentin, On 11/15/23 19:00, Quentin Schulz wrote: Hi all, I'm trying to add watchdog support to the PX30 Ringneck board but it fails to compile: """ diff --git a/configs/ringneck-px30_defconfig b/configs/ringneck-px30_defconfig index b314636b4d9..3dab0dab5d4 100644 --- a/configs/ringnec

Re: [PATCH v2 1/3] arm: mvebu: Espressobin: move FDT fixup into a separate function

2023-11-28 Thread Stefan Roese
separate function and call it if compatible matches, there should be no functional change. Signed-off-by: Robert Marko Reviewed-by: Stefan Roese Hi Stefan, Is there anything I can do to get this series merged? I just looked at it (again). My recollection was that something was missing here

Re: [PATCH v2 1/3] arm: mvebu: Espressobin: move FDT fixup into a separate function

2023-11-28 Thread Stefan Roese
Hi Robert, On 11/28/23 16:44, Stefan Roese wrote: Hi Robert, On 11/28/23 11:19, Robert Marko wrote: On Fri, Oct 20, 2023 at 12:21 PM Robert Marko wrote: Currently, Esspresobin FDT is being fixed up directly in ft_board_setup() which makes it hard to add support for any other board to be

Re: [PATCH] watchdog: Correct watchdog timeout print message

2023-11-30 Thread Stefan Roese
framework") Signed-off-by: Chanho Park Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/watchdog/wdt-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/wdt-uclass.c b/drivers/watchdog/wdt-uclass.c index ed329284decb..65a4bc1f90ed 1006

Re: [PATCH] watchdog: Correct watchdog timeout print message

2023-12-01 Thread Stefan Roese
On 12/1/23 08:37, Stefan Roese wrote: On 11/27/23 02:05, Chanho Park wrote: The wdt_start function takes timeout_ms as a parameter and starts the watchdog with this value. However, when you output the message, it shows the default timeout value for the watchdog device. So this patch fixes that

Re: [PATCH v2] watchdog: Correct watchdog timeout print message

2023-12-03 Thread Stefan Roese
framework") Signed-off-by: Chanho Park Reviewed-by: Stefan Roese Thanks, Stefan --- Change from v1: - Use lldiv to fix a build error of m68k arch drivers/watchdog/wdt-uclass.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/watchdog/wdt-uclass.c b/driv

Re: [PATCH] mmc: Poll CD in case cyclic framework is enabled

2023-12-03 Thread Stefan Roese
On 12/4/23 02:05, Marek Vasut wrote: On 12/4/23 01:44, Simon Glass wrote: Hi Marek, On Sun, 3 Dec 2023 at 14:01, Marek Vasut wrote: On 12/3/23 18:44, Simon Glass wrote: Hi Marek, On Sat, 2 Dec 2023 at 16:41, Marek Vasut wrote: In case the cyclic framework is enabled, poll the card detec

Re: [PATCH v2 1/5] cyclic: Add a symbol for SPL

2023-12-03 Thread Stefan Roese
point the #ifdefs from these files will likely be removed, so there is no benefit in going that way. Signed-off-by: Simon Glass Reviewed-by: Stefan Roese Thanks, Stefan --- Changes in v2: - Add an SPL_CYCLIC symbol - Add a lot more explanation about the header files common/Kconfig

Re: [PATCH 1/5] cyclic: Disable in SPL builds

2023-12-03 Thread Stefan Roese
.h:13, from tools/../lib/sha1.c:25, from tools/generated/lib/sha1.c:1: include/cyclic.h:47:22: error: missing binary operator before token "(" 47 | #if CONFIG_IS_ENABLED(CYCLIC) | ^ Regards, Simon Viele Grüße, St

Re: [PATCH v2] watchdog: Correct watchdog timeout print message

2023-12-04 Thread Stefan Roese
s, 1000)); } return ret; Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de

Please pull u-boot-watchdog/master

2023-12-04 Thread Stefan Roese
Hi Tom, please pull the following watchdog related fix: - Correct watchdog timeout print message (Chanho Park) Here the Azure build, without any issues: https://dev

Re: [PATCH 010/149] board: Marvell: Remove and add needed includes

2024-05-01 Thread Stefan Roese
On 5/1/24 04:40, Tom Rini wrote: Remove from this board vendor directory and when needed add missing include files directly. Signed-off-by: Tom Rini --- Cc: Stefan Roese Cc: Chris Packham Cc: Tony Dinh Cc: Jason Cooper Cc: Siddarth Gore Cc: Aaron Williams --- arch/arm/mach-kirkwood

Re: [PATCH u-boot-mvebu 10/10] arm: mvebu: turris_omnia: Support old DDR3 training, selectable via env var

2024-05-06 Thread Stefan Roese
ia.c index 3b7a71bdad..225c6f4bc5 100644 --- a/board/CZ.NIC/turris_omnia/turris_omnia.c +++ b/board/CZ.NIC/turris_omnia/turris_omnia.c @@ -465,7 +465,7 @@ static bool omnia_read_eeprom(struct omnia_eeprom *oep) return true; } -static int omnia_get_ram_size_gb(void) +int omnia_get_ram_si

Re: [PATCH 1/3] cyclic: stop strdup'ing name in cyclic_register()

2024-05-12 Thread Stefan Roese
as the cyclic_info is registered, so just make that a requirement. Signed-off-by: Rasmus Villemoes Reviewed-by: Stefan Roese Thanks, Stefan --- common/cyclic.c | 2 +- include/cyclic.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common/cyclic.c b/common/cycli

Re: [PATCH 2/3] wdt-uclass: prevent multiple cyclic_register calls

2024-05-13 Thread Stefan Roese
ATCHDOG) && priv->running) + cyclic_unregister(priv->cyclic); + priv->running = false; } Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de

Re: [PATCH 2/3] wdt-uclass: prevent multiple cyclic_register calls

2024-05-13 Thread Stefan Roese
Hi Rasmus, On 5/13/24 13:09, Rasmus Villemoes wrote: On 13/05/2024 12.40, Stefan Roese wrote: On 5/9/24 02:47, Rasmus Villemoes wrote: Currently, the cyclic_register() done in wdt_start() is not undone in wdt_stop(). Moreover, calling wdt_start multiple times (which is perfectly allowed on an

Re: [PATCH 1/3] firmware: zynqmp: Add support to access efuses

2024-05-14 Thread Stefan Roese
2 address, u32 *value); int zynqmp_mmio_write(const u32 address, const u32 mask, const u32 value); Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51

Re: [PATCH 3/3] drivers: misc: Add driver to access ZynqMP efuses

2024-05-14 Thread Stefan Roese
truct udevice_id zynqmp_efuse_match[] = { + { .compatible = "xlnx,zynqmp-nvmem-fw", }, + { /* sentinel */ }, +}; + +static const struct misc_ops zynqmp_efuse_ops = { + .read = zynqmp_nvmem_read, + .write = zynqmp_nvmem_write, +}; + +U_BOOT_DRIVER(zynqmp_efuse) = { + .n

Re: [PATCH u-boot-mvebu 10/10] arm: mvebu: turris_omnia: Support old DDR3 training, selectable via env var

2024-05-15 Thread Stefan Roese
Hi Marek, On 5/15/24 10:59, Marek Behún wrote: On Mon, 6 May 2024 12:03:55 +0200 Stefan Roese wrote: Hi Marek, On 4/15/24 18:30, Marek Behún wrote: Support old DDR3 training code on Turris Omnia, selectable by U-Boot enviroment variable. Users experiencing DDR3 initialization failures or

Re: [PATCH 3/3] drivers: misc: Add driver to access ZynqMP efuses

2024-05-15 Thread Stefan Roese
Hi Lukas, On 5/15/24 08:33, Lukas Funke wrote: Hi Stefan, On 15.05.2024 08:12, Stefan Roese wrote: Hi Lukas, On 5/14/24 16:04, lukas.funke-...@weidmueller.com wrote: From: Lukas Funke Add driver to access ZynqMP efuses. This is a u-boot port of [1]. [1] https://lore.kernel.org/all

Re: [PATCH u-boot-mvebu 10/10] arm: mvebu: turris_omnia: Support old DDR3 training, selectable via env var

2024-05-15 Thread Stefan Roese
On 5/15/24 11:24, Marek Behún wrote: On Wed, 15 May 2024 11:10:09 +0200 Stefan Roese wrote: Hi Marek, On 5/15/24 10:59, Marek Behún wrote: On Mon, 6 May 2024 12:03:55 +0200 Stefan Roese wrote: Hi Marek, On 4/15/24 18:30, Marek Behún wrote: Support old DDR3 training code on Turris

Re: [PATCH 07/11] watchdog: Add support for ADI SC5XX-family watchdog peripheral

2024-05-15 Thread Stefan Roese
/adi_wdt.c Reviewed-by: Stefan Roese Thanks, Stefan diff --git a/MAINTAINERS b/MAINTAINERS index c1685f0352..6feb7e540b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -618,6 +618,7 @@ F: drivers/pinctrl/pinctrl-adi-adsp.c F:drivers/serial/serial_adi_uart4.c F:drivers/timer

Re: [PATCH 3/3] cyclic: make clients embed a struct cyclic_info in their own data structure

2024-05-15 Thread Stefan Roese
6 files changed, 64 insertions(+), 72 deletions(-) I like this approach. And would like to pull this in as well, perhaps before leaving on a 2 week vacation mid of next week. Unfortunately this patch 3/3 does not apply on TOT any more. Could you please rebase and re-submit? Reviewed-by

Re: [PATCH v2 3/3] cyclic: make clients embed a struct cyclic_info in their own data structure

2024-05-18 Thread Stefan Roese
ompiler will see that (1) the callback is referenced, so not emit a warning for a maybe-unused function and (2) see that it can actually never be reached, so not emit any code for it. Reviewed-by: Stefan Roese Signed-off-by: Rasmus Villemoes --- board/Marvell/octeon_nic23/boa

Re: [PATCH v2 3/3] cyclic: make clients embed a struct cyclic_info in their own data structure

2024-05-20 Thread Stefan Roese
On 5/19/24 21:44, Rasmus Villemoes wrote: On 18/05/2024 09.34, Stefan Roese wrote: This introduces some problems when compiling e.g. sandbox: In file included from test/common/cyclic.c:10: test/common/cyclic.c: In function ‘dm_test_cyclic_running’: test/common/cyclic.c:25:42: warning: passing

Re: [PATCH v2 3/3] cyclic: make clients embed a struct cyclic_info in their own data structure

2024-05-21 Thread Stefan Roese
On 5/21/24 10:38, Rasmus Villemoes wrote: On 21/05/2024 08.57, Stefan Roese wrote: On 5/19/24 21:44, Rasmus Villemoes wrote: On 18/05/2024 09.34, Stefan Roese wrote: This introduces some problems when compiling e.g. sandbox: In file included from test/common/cyclic.c:10: test/common

Re: [PATCH v4 0/3] cyclic/watchdog patches

2024-05-21 Thread Stefan Roese
On 5/21/24 11:47, Rasmus Villemoes wrote: On 21/05/2024 10.46, Rasmus Villemoes wrote: A bit of a mixed bag. I've been wanting to submit something like 3/3 for a while. So when I stumbled on Marek's patch https://lore.kernel.org/u-boot/20240316201416.211480-1-marek.vasut+rene...@mailbox.org/ , I

Re: [PATCH v4 0/3] cyclic/watchdog patches

2024-05-21 Thread Stefan Roese
On 5/21/24 14:45, Rasmus Villemoes wrote: On 21/05/2024 13.54, Stefan Roese wrote: On 5/21/24 11:47, Rasmus Villemoes wrote: On 21/05/2024 10.46, Rasmus Villemoes wrote: A bit of a mixed bag. I've been wanting to submit something like 3/3 for a while. So when I stumbled on Marek's p

Re: [PATCH u-boot-mvebu v3 05/18] arm: mvebu: turris_omnia: Implement getting board information from MCU

2024-03-28 Thread Stefan Roese
On 3/28/24 12:17, Marek Behún wrote: On Thu, 28 Mar 2024 10:56:01 +0100 Stefan Roese wrote: On 3/27/24 17:23, Marek Behún wrote: Implement reading board serial number, first MAC address and board version from MCU. MCU supports board information if the FEAT_BOARD_INFO feature bit is set in

Re: [PATCH u-boot-mvebu v3 11/18] arm: mvebu: system-controller: Add support for SYSRESET

2024-03-28 Thread Stefan Roese
On 3/28/24 12:21, Marek Behún wrote: On Thu, 28 Mar 2024 11:04:45 +0100 Stefan Roese wrote: +static int mvebu_sysreset_request(struct udevice *dev, enum sysreset_t type) +{ + struct regmap *regmap = syscon_get_regmap(dev->parent); + uint bit; + + if (type != SYSRESET_C

Re: [PATCH u-boot-mvebu v3 00/18] Turris Omnia - New board revision support

2024-04-03 Thread Stefan Roese
create mode 100644 drivers/misc/turris_omnia_mcu.c create mode 100644 include/turris-omnia-mcu-interface.h Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de

Re: [PATCH u-boot-mvebu v4 00/18] Turris Omnia - New board revision support

2024-04-04 Thread Stefan Roese
On 4/4/24 09:50, Marek Behún wrote: changes since v3: - added missing files turris_common.c and turris_common.h to patch 05/18 - added comment to patch 11/18 before while (1); as discussed in v3 v1, v2 and v3 at: https://patchwork.ozlabs.org/project/uboot/cover/20240304152148.3847-1-ka...@ke

Re: [PATCH v3] arm: dts: kirkwood: Enable upstream DT on Kirkwood boards

2024-04-04 Thread Stefan Roese
PCIe bus. And the Zyxel NSA310S has an extensive overhaul in bindings and styles in upstream DTS version. Tested-by: Michael Walle # on lschv2 Acked-by: Sumit Garg Reviewed-by: Stefan Roese Signed-off-by: Tony Dinh Applied to u-boot-marvell/master Thanks, Stefan --- Changes in v3

Please pull u-boot-marvell/master

2024-04-04 Thread Stefan Roese
Hi Tom, please pull the first batch of mostly Marvell related patches: - kirkwood: Switch to using upstream dts/dtsi files (Tony) - mvebu: Turris Omnia - New board revision support (Marek) --

Re: [PATCH] arm: dts: kirkwood: Remove DTS files for Kirkwood boards

2024-04-04 Thread Stefan Roese
On 3/26/24 22:12, Tony Dinh wrote: Remove DTS and DTSI files for Kirkwood boards that have upstream supports. This patch depends on "arm: dts: kirkwood: Enable upstream DT on Kirkwood boards" https://patchwork.ozlabs.org/project/uboot/patch/20240322021747.14873-1-mibo...@gmail.com/ Signed-off-b

Re: [PATCH v3] rng: Add Turris Mox rTWM RNG driver

2024-02-07 Thread Stefan Roese
p; + struct turris_rwtm_rng_priv *priv = dev_get_priv(dev); + phys_addr_t phys = priv->buffer; - p = ((struct turris_rwtm_rng_priv *)dev_get_priv(dev))->buffer; - dma_free_coherent((void *)p); + dma_free_coherent((void *)phys); return 0; } Viele Grüße, Stefan Roese -- DE

Re: [PATCH v4] rng: Add Turris Mox rTWM RNG driver

2024-02-13 Thread Stefan Roese
Hi Max, mostly some nitpicking comments below. On 2/11/24 14:04, Max Resch wrote: A RNG driver for Armada 3720 boards running the Turris Mox rWTM firmware from CZ.NIC in the secure processor. Signed-off-by: Max Resch --- Changes in v4: - wrongful/missing git rebase Changes in v3: - More

Re: [PATCH v2] net: mv88e6xxx: fix missing SMI address initialization

2024-02-13 Thread Stefan Roese
Hi Ramon, On 1/9/24 10:37, Stefan Roese wrote: On 12/18/23 17:09, Marek Behún wrote: On Wed, 6 Dec 2023 15:35:56 +0100 Marek Mojík wrote: The mv88e6xxx driver does not currently initialize the smi_addr field, but instead keeps the default zero value. This leads to driver being unusable on

Re: [PATCH v5] rng: Add Turris Mox rTWM RNG driver

2024-02-16 Thread Stefan Roese
be, + .remove = turris_rwtm_rng_remove, + .priv_auto = sizeof(struct turris_rwtm_rng_priv), +}; Reviewed-by: Stefan Roese Thanks, Stefan

Re: [PATCH] arm: mvebu: Espressobin: Disable slot when emmc is not present

2020-12-22 Thread Stefan Roese
rd without soldered emmc, state of emmc hw should be same as if emmc was disabled in DTS. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- board/Marvell/mvebu_armada-37xx/board.c | 15 --- drivers/mmc/xenon_sdhci.c | 19 +++ 2 fil

Re: [PATCH v4 10/13] xhci: translate virtual addresses into the bus's address space

2020-12-22 Thread Stefan Roese
emory accesses incoming from its PCIe port. Introduce xhci_virt_to_bus() and xhci_bus_to_virt() to cater with these limitations, and make sure we don't break non DM users. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Simon Glass Reviewed-by: Stefan Roese Thanks, Stefan --- Change

Re: [PATCH v4 08/13] dm: Introduce dev_phys_to_bus()/dev_bus_to_phys()

2020-12-22 Thread Stefan Roese
o_bus()/bus_to_phys() implementations as some of its users are not integrated into the device model. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Simon Glass Reviewed-by: Stefan Roese Thanks, Stefan --- Changes since v2: - Use CONFIG_DM_DMA include/phys2bus.h | 16 1

Re: [PATCH] Revert "arm64: a37xx: pci: Assert PERST# signal when unloading driver"

2020-12-28 Thread Stefan Roese
4 and 4.19 kernels and also latest mainline kernels. Signed-off-by: Pali Rohár --- Stefan, please include this patch for U-Boot 2020.01 release. It fixes using PCIe cards on Espressobin with OpenWRT which Gérald reported to me and I was reproduced it. Will do. Reviewed-by: Stefan Roese Than

Please pull u-boot-marvell/master

2020-12-28 Thread Stefan Roese
a37xx: pci: Assert PERST# signal when unloading driver" (2020-12-28 09:42:06 +0100) Pali Rohár (1): Revert "arm64: a37xx: pci: Assert PERST# signal when unloading driver" Stefan Roese (2): arm: mvebu:

Re: [PATCH] usb: xhci: Use only 32-bit accesses in nvme_writeq/nvme_readq

2020-12-30 Thread Stefan Roese
analogous to commit 8e2ab05000ab ("usb: xhci: Use only 32-bit accesses in xhci_writeq/xhci_readq"). I see. This is where you cloned the patch subject line from then. ;) Please change the subject line and add my: Reviewed-by: Stefan Roese Thanks, Stefan Cc: Sylwester Nawrocki Cc: Zhi

Re: [PATCH 1/3] arm: mvebu: ds414: Config header mini-review

2021-01-05 Thread Stefan Roese
nnected to some RTL8111 and the default 8s timeout was often too short. Signed-off-by: Phil Sutter Reviewed-by: Stefan Roese Thanks, Stefan --- include/configs/ds414.h | 21 +++-- 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/include/configs/ds414.h b/

Re: [PATCH 2/3] pci: Make auto-config code a little more robust

2021-01-05 Thread Stefan Roese
e - 1); + if (!enum_only) bar_res = io; Reviewed-by: Stefan Roese Thanks, Stefan

Re: [PATCH 3/3] pci: pci_mvebu: Define an IO region as well

2021-01-05 Thread Stefan Roese
tgt/attr for IO window\n", pcie->name); + goto err; + } + /* Parse PCIe controller register base from DT */ ret = mvebu_pcie_port_parse_dt(dev_ofnode(dev), pcie); if (ret < 0) Reviewed-by: Stefan Roese Thanks, Stefan

Re: [PATCH] board: mediatek: disable watchdog on BananaPi R2

2021-01-07 Thread Stefan Roese
On 07.01.21 16:36, matthias@kernel.org wrote: From: Matthias Brugger Watchdog timeout comes in before we are able to load the kernel and reset the watchdog. Disable the watchdog late in the boot process to be able to boot the board. Can't you change the WDT reset timeout instead to a high

Re: [PATCH] board: mediatek: disable watchdog on BananaPi R2

2021-01-09 Thread Stefan Roese
On 09.01.21 03:32, Matthias Brugger wrote: On 08/01/2021 08:39, Stefan Roese wrote: On 07.01.21 16:36, matthias@kernel.org wrote: From: Matthias Brugger Watchdog timeout comes in before we are able to load the kernel and reset the watchdog. Disable the watchdog late in the boot process

Re: [PATCH] board: mediatek: disable watchdog on BananaPi R2

2021-01-10 Thread Stefan Roese
Added Heinrich to Cc. On 10.01.21 19:44, Matthias Brugger wrote: On 09/01/2021 15:57, Stefan Roese wrote: On 09.01.21 03:32, Matthias Brugger wrote: On 08/01/2021 08:39, Stefan Roese wrote: On 07.01.21 16:36, matthias@kernel.org wrote: From: Matthias Brugger Watchdog timeout comes in

Re: [PATCH] board: mediatek: disable watchdog on BananaPi R2

2021-01-10 Thread Stefan Roese
On 11.01.21 08:17, Heinrich Schuchardt wrote: Am 11. Januar 2021 08:02:12 MEZ schrieb Stefan Roese : Added Heinrich to Cc. On 10.01.21 19:44, Matthias Brugger wrote: On 09/01/2021 15:57, Stefan Roese wrote: On 09.01.21 03:32, Matthias Brugger wrote: On 08/01/2021 08:39, Stefan Roese

[PATCH] pci: Remove CONFIG_PCI_ENUM_ONLY as it's not used (any more)

2021-01-12 Thread Stefan Roese
file. Signed-off-by: Stefan Roese Cc: Simon Glass Cc: Bin Meng --- README | 7 --- drivers/pci/pci_auto.c | 104 ++- drivers/pci/pci_auto_old.c | 18 -- scripts/config_whitelist.txt | 1 - 4 files changed, 41 insertions(+

[PATCH] usb: xhci: Fix compare to use physical addresses in xhci_bulk_tx()

2021-01-14 Thread Stefan Roese
this case). Signed-off-by: Stefan Roese Cc: Aaron Williams Cc: Chandrakala Chavva Cc: Ran Wang Cc: Nicolas Saenz Julienne Cc: Marek Vasut Cc: Bin Meng --- drivers/usb/host/xhci-ring.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/driver

Re: [PATCH] usb: xhci: Fix compare to use physical addresses in xhci_bulk_tx()

2021-01-15 Thread Stefan Roese
Hi Bin, On 15.01.21 09:16, Bin Meng wrote: Hi Stefan, On Fri, Jan 15, 2021 at 3:53 PM Stefan Roese wrote: Testing with v2021.01 on MIPS Octeon has shown, that the latest patch for the "short packet event trb handling" did introduce a bug on platforms with virtual address != physic

Re: [PATCH] usb: xhci: Fix compare to use physical addresses in xhci_bulk_tx()

2021-01-15 Thread Stefan Roese
On 15.01.21 11:27, Nicolas Saenz Julienne wrote: On Fri, 2021-01-15 at 08:52 +0100, Stefan Roese wrote: Testing with v2021.01 on MIPS Octeon has shown, that the latest patch for the "short packet event trb handling" did introduce a bug on platforms with virtual address != physical add

Re: [PATCH u-boot-marvell] arm: mvebu: turris_mox: enable wdt command in defconfig

2021-01-15 Thread Stefan Roese
On 13.01.21 18:22, Marek Behún wrote: Enable wdt command in defconfig for Turris MOX. This is useful when doing debugging. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan

Re: [PATCH] serial: a3720: Implement pending method for output direction

2021-01-15 Thread Stefan Roese
On 14.01.21 15:46, Pali Rohár wrote: To check if some output characters are waiting either in Transmitter Holding Register or Transmitter Shift Register we need to look at TX_EMPTY bit of UART Status Register. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese BTW: How did you detect this

Re: [PATCH] usb: xhci-pci: Check for errors from dm_pci_map_bar()

2021-01-18 Thread Stefan Roese
Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/usb/host/xhci-pci.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c index 2b445f21b5..7f5be95f6c 100644 --- a/drivers/usb/host/xhci-pci.c

Re: [PATCH v2] usb: xhci-pci: Check for errors from dm_pci_map_bar()

2021-01-18 Thread Stefan Roese
Rohár Reviewed-by: Stefan Roese Thanks, Stefan

Re: [PATCH] arm64: a37xx: pci: Fix printing debug messages

2021-01-18 Thread Stefan Roese
ali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/pci/pci-aardvark.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/pci/pci-aardvark.c b/drivers/pci/pci-aardvark.c index 1534efb88e..8713b88461 100644 --- a/drivers/pci/pci-aardvark.c +++ b/driv

Re: [PATCH 1/3] PowerPC: dts: Pulled in kmcent2 dts files from Linux 5.10

2021-01-19 Thread Stefan Roese
moved from non SPDX to SPDX indentifiers? I would suggest to also submit these changes to the Linux kernel (if not done already). So that the files are identical in the next release revision. Is no license is changed: Reviewed-by: Stefan Roese Thanks, Stefan Signed-off-by: Niel Fourie Cc

Re: [PATCH 2/3] keymile: common: Fix pram variable radix

2021-01-19 Thread Stefan Roese
Hi Niel, On 08.01.21 11:53, Niel Fourie wrote: In set_km_env() the pram variable was set to an hexadecimal value, while initr_mem() expects an unsigned decimal. Set the pram variable to an unsigned decimal instead. Signed-off-by: Niel Fourie Cc: Holger Brunck Cc: Heiko Schocher Cc: Priyanka

Re: [PATCH 3/3] PowerPC: keymile: Add support for kmcent2 board

2021-01-19 Thread Stefan Roese
Hi Niel, On 08.01.21 11:53, Niel Fourie wrote: Add basic support for the Hitachi Power Grids kmcent2 board, based on the NXP QorIQ T1040 SoC. Signed-off-by: Valentin Longchamp Signed-off-by: Rainer Boschung Signed-off-by: Niel Fourie Cc: Holger Brunck Cc: Heiko Schocher Cc: Priyanka Jain

Re: [PATCH u-boot-marvell v2 2/2] arm: mvebu: turris_mox: enable setexpr command in defconfig

2021-01-19 Thread Stefan Roese
On 19.01.21 15:49, Marek Behún wrote: Enable setexpr command in defconfig for Turris MOX. We have found that this is sometimes useful in U-Boot scripts and there is enough space in NOR memory on MOX. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- configs

[PATCH v2 5/9] ram: octeon: Add MIPS Octeon3 DDR4 support (part 1/3)

2020-08-17 Thread Stefan Roese
based probing. Signed-off-by: Aaron Williams Signed-off-by: Stefan Roese --- Changes in v2: - Don't re-init after relocation - Some unsupported Octeon families removed (only Octeon 2 & 3 supported in general) drivers/ram/octeon/octeon_ddr.c | 2730 ++

[PATCH v2 9/9] mips: octeon: octeon_ebb7304: Add DDR4 support

2020-08-17 Thread Stefan Roese
; 16 GiB). Signed-off-by: Stefan Roese --- (no changes since v1) board/Marvell/octeon_ebb7304/board.c | 25 +- board/Marvell/octeon_ebb7304/board_ddr.h | 447 +++ configs/octeon_ebb7304_defconfig | 3 + include/configs/octeon_common.h | 11 +- 4 f

[PATCH v2 3/9] mips: octeon Add cvmx/cvmx-lmcx-defs.h header

2020-08-17 Thread Stefan Roese
From: Aaron Williams This header will be used by the DDR driver (lmc). Its ported from the 2013 Cavium / Marvell U-Boot repository. Signed-off-by: Aaron Williams Signed-off-by: Stefan Roese --- Changes in v2: - Some unsupported Octeon families removed (only Octeon 2 & 3 supported

[PATCH v1 2/8] usb: xhci: xhci_bulk_tx: Don't "BUG" when comparing addresses on Octeon

2020-08-17 Thread Stefan Roese
Octeon uses mapped addresses for virtual and physical memory. Its not that easy to calculate the resulting addresses here. So lets remove this BUG_ON() for Octeon in xhci_bulk_tx(). Signed-off-by: Stefan Roese Cc: Bin Meng Cc: Marek Vasut --- drivers/usb/host/xhci-ring.c | 7 +-- 1 file

[PATCH v1 1/8] usb: xhci: xhci-dwc3.c: Use dev_remap_addr() instead of dev_get_addr()

2020-08-17 Thread Stefan Roese
On MIPS platforms, mapping of the base address is needed. This patch switches from dev_get_addr() to dev_remap_addr() to get the mapped base address of the xHCI controller. Signed-off-by: Stefan Roese Cc: Bin Meng Cc: Marek Vasut --- drivers/usb/host/xhci-dwc3.c | 2 +- 1 file changed, 1

[PATCH v1 5/8] mips: octeon: Add mangle-port.h

2020-08-17 Thread Stefan Roese
Import platform specific mangle-port.h header, allowing a area specific swapping, which is needed on Octeon for USB & PCI areas. Imported from Linux v5.7. Signed-off-by: Stefan Roese --- arch/mips/mach-octeon/include/mangle-port.h | 58 + 1 file changed, 58 insert

[PATCH v1 0/8] mips/usb: Add Octeon xHCI USB support

2020-08-17 Thread Stefan Roese
(cache fixes, platform specific swapping based on address areas, DT & defcopnfig changes). Thanks, Stefan Stefan Roese (8): usb: xhci: xhci-dwc3.c: Use dev_remap_addr() instead of dev_get_addr() usb: xhci: xhci_bulk_tx: Don't "BUG" when comparing addresses on Octeon

[PATCH v1 4/8] mips: octeon: cpu.c: Add table for selective swapping

2020-08-17 Thread Stefan Roese
Import octeon_should_swizzle_table[] which is needed for the area specific swapping. It will be used by the platform specific mangle-port.h header. Imported from Linux v5.7. Signed-off-by: Stefan Roese --- arch/mips/mach-octeon/cpu.c | 21 + 1 file changed, 21 insertions

[PATCH v1 6/8] mips: octeon: cache.c: Flush all pending writes in flush_dcache_range()

2020-08-17 Thread Stefan Roese
As noticed while working on the USB xHCI support, Octeon needs to flush all pending writes so that the values are present in the memory. Add this "syncw" instruction (twice) to flush_dcache_range(). Signed-off-by: Stefan Roese --- arch/mips/mach-octeon/cache.c | 12 ++-- 1 fi

[PATCH v1 7/8] mips: octeon: Add USB DT nodes

2020-08-17 Thread Stefan Roese
Add the USB device tree nodes to the Octeon dts/dtsi files. Signed-off-by: Stefan Roese --- arch/mips/dts/mrvl,cn73xx.dtsi| 58 +++ arch/mips/dts/mrvl,octeon-ebb7304.dts | 22 ++ 2 files changed, 80 insertions(+) diff --git a/arch/mips/dts/mrvl

[PATCH v1 8/8] mips: octeon: octeon_ebb7304_defconfig: Enable USB support

2020-08-17 Thread Stefan Roese
This patch enables USB support with some helpful commands, like fs support. Signed-off-by: Stefan Roese --- configs/octeon_ebb7304_defconfig | 17 + 1 file changed, 17 insertions(+) diff --git a/configs/octeon_ebb7304_defconfig b/configs/octeon_ebb7304_defconfig index

[PATCH v1 3/8] usb: xhci: octeon: Add DWC3 glue layer for Octeon

2020-08-17 Thread Stefan Roese
This patch adds the glue layer for the MIPS Octeon SoCs. Its ported mainly from the Linux code. Signed-off-by: Stefan Roese Cc: Bin Meng Cc: Marek Vasut --- drivers/usb/host/Kconfig| 9 + drivers/usb/host/Makefile | 1 + drivers/usb/host/dwc3-octeon-glue.c | 396

Re: [PATCH] arm: mvebu: Espressobin: Enable CONFIG_MVNETA

2020-08-17 Thread Stefan Roese
On 17.08.20 17:13, Pali Rohár wrote: Espressobin uses mvneta ethernet driver. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- configs/mvebu_espressobin-88f3720_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/mvebu_espressobin

<    2   3   4   5   6   7   8   9   10   11   >