On Tue, Jan 10, 2012 at 5:42 AM, Liu Gang gang@freescale.com wrote:
There will be a confict if defined CONFIG_ENV_IS_NOWHERE and
CONFIG_ENV_IS_IN_FLASH.
This doesn't make any sense. How can the environment be nowhere *and*
also in flash, at the same time?
--
Timur Tabi
Linux kernel
On Tue, Jan 10, 2012 at 5:42 AM, Liu Gang gang@freescale.com wrote:
+#define CONFIG_SYS_QE_FMAN_FW_IN_REMOTE
+#define CONFIG_SYS_QE_FMAN_FW_ADDR 0
Where is CONFIG_SYS_QE_FMAN_FW_IN_REMOTE documented? And where is the
code that uses it?
--
Timur Tabi
Linux kernel developer at
On Tue, Jan 10, 2012 at 5:42 AM, Liu Gang gang@freescale.com wrote:
When boot from SRIO, slave's ucode can be stored in master's memory space,
then slave can fetch the ucode image through SRIO interface.
What kind of ucode is this? Fman or QE?
+
+ /* configure inbound window for
Liu Gang-B34182 wrote:
Where is CONFIG_SYS_QE_FMAN_FW_IN_REMOTE documented? And where is the code
that uses it?
[Liu Gang-B34182] Sorry I documented this definition in [PATCH 6/8]
powerpc/boot: Slave uploads ucode when boot from SRIO,
You need to update the README. That's where all the
On Thu, Jan 12, 2012 at 5:49 PM, Tabi Timur-B04825 b04...@freescale.com wrote:
Are you going to make another pull request before the window closes?
The reason I ask is that you're missing some of my patches.
http://patchwork.ozlabs.org/project/uboot/list/?submitter=timur
--
Timur Tabi
Linux
On Tue, Jan 17, 2012 at 1:12 AM, Simon Glass s...@chromium.org wrote:
From: Heiko Schocher h...@denx.de
This Patch introduce the new i2c_core file, which holds
the I2C core functions, for the rework of the multibus/
multiadapter support.
Also adds changes in i2c.h for the new I2C
On Mon, Feb 6, 2012 at 11:17 PM, Ramneek Mehresh
ramneek.mehr...@freescale.com wrote:
+ start_offset, compat_mph);
if (node_offset 0) {
- printf(WARNING: could not find compatible node %s: %s.\n,
- compat,
On Thu, Aug 23, 2012 at 12:24 PM, Andy Fleming aflem...@gmail.com wrote:
I'm guessing this change increased the amount of inlining. Sadly, the
subsequent patches, which were intended to shrink the SPL build, were
not enough to fix this problem.
Maybe there are places where we can use raw I/O
On Fri, Aug 17, 2012 at 1:20 PM, York Sun york...@freescale.com wrote:
+ * 8-19 CHIP_ID,2’b00 - SoC 1
+ * all others - reserved
+ * 20-24 CLUSTER_ID 5’b0 - CCM 1
+ * all others - reserved
+ * 25-26 CORE_CLUSTER_ID 2’b00 - cluster 1
+ *
Kim Phillips wrote:
Cryptography acceleration (SEC 5.0) at up to 40 Gbps SerDes
it's a SEC 5.2, but...
Ok.
Dual four channel
Support for hardware virtualization and partitioning enforcement
Extra privileged level for hypervisor support
QorIQ Trust Architecture 1.1
On Sat, Sep 15, 2012 at 9:36 AM, Jerry Van Baren gvb.ub...@gmail.com wrote:
Queued up 2 of 2 patches to the u-boot-fdt next branch. I'll issue a
pull request when the merge window opens.
I thought libfdt patches were suppose to go to dtc.git?
--
Timur Tabi
Linux kernel developer at
On Fri, Jun 22, 2012 at 2:41 PM, Troy Kisky
troy.ki...@boundarydevices.com wrote:
Correct and correct. If you need i2c working before relocation, you cannot
enable MULTI_BUS.
That sounds like a really strong limitation of MULTI_BUS. i2c is
necessary for SPD, which is needed to initialize DDR.
Nobuhiro Iwamatsu wrote:
diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
index eee41d7..7a3d16b 100644
--- a/drivers/net/fec_mxc.c
+++ b/drivers/net/fec_mxc.c
@@ -510,7 +510,12 @@ static int fec_open(struct eth_device *edev)
fec_eth_phy_config(edev);
if
Wolfgang Denk wrote:
This is a totally broken design then, when you have a growing data
structure where vital information fields get shifted. In such case,
the CRC should have been at the beginning, so it never changes
location. Or even better, you should not have used a binary data
Wolfgang Denk wrote:
My patch provides transparent updates to handle it. It will read broken
EEPROMs and verify the CRC in the old location, and if you have re-save
the EEPROM, it will put the CRC in the right place.
It will work by chance, accessing random data. This is crap.
It is not
sun york-R58495 wrote:
I agree it was a broken design. Now we are using all available space
and put CRC to the very end. It is not perfect but should work.
*sigh*
The design was never broken, the code was just wrong. The CRC has always
supposed to have been at the end.
--
Timur Tabi
Linux
Or Yoram-R56270 wrote:
1. Correct the v1 documentation to specify 23 MAC addresses and placing the
CRC at 0xCC.
2. Create a new code and documentation for v2, specifying 31 MAC addresses
and placing the CRC at 0xFC.
Both of these are unnecessary. My patch fixes the code to match the spec
On Wed, Nov 28, 2012 at 1:39 AM, Andy Fleming aflem...@freescale.com wrote:
Timur Tabi (5):
powerpc/85xx/p5040: add CONFIG_SYS_PPC64, del
CONFIG_SYS_FSL_ELBC_MULTIBIT_ECC
powerpc/85xx: add support for the Freescale P5040DS Superhydra
reference board
powerpc/85xx:
On Mon, Jan 7, 2013 at 4:39 PM, Wolfgang Denk w...@denx.de wrote:
This seems broken to me. Can we rather try8 and get rid of all this
bool stuff instead? It's just obfuscating the code...
Like Scott said, we sometimes copy code from Linux that uses 'bool',
so it's simpler if we just retain
On Thu, Jan 10, 2013 at 5:49 AM, Vakul Garg va...@freescale.com wrote:
If property 'fsl,sec-era' is already present, it is updated.
This property is required so that applications can ascertain which
descriptor commands are supported on a particular CAAM version.
Signed-off-by: Vakul Garg
On Mon, Jan 14, 2013 at 10:26 PM, Prabhakar Kushwaha
prabha...@freescale.com wrote:
#define SVR_9130 0x860001
#define SVR_9131 0x86
+#define SVR_9132 0x861000
+#define SVR_9132_E 0x861800
+#define SVR_9232 0x861400
Remove SVR_9132_E. See commit
On Thu, Jan 17, 2013 at 9:26 AM, Roy Zang tie-fei.z...@freescale.com wrote:
Signed-off-by: Roy Zang tie-fei.z...@freescale.com
---
Why? We don't need this for P5040 support.
--
Timur Tabi
Linux kernel developer at Freescale
___
U-Boot mailing list
Xie Shaohui-B21989 wrote:
[S.H] I thought one patch doing one thing even it's simple.
I'm fine with the merge if you insist.
Well, it is a matter of opinion. I don't insist, but I think it would be
easier for everyone if you did merge these patches. Each one is very
short, and they are all
Wolfgang Denk wrote:
Maybe this can be implemented in a largely CPU independent way? Try to
make it data-driven, so you can then for example just provide a
CPU-specific data sructure (array of names / addresses or whatever you
are checking).
I'm not sure this will work out that well, but I'll
On Dec 1, 2010, at 7:51 AM, Liu Dave-R63238 r63...@freescale.com wrote
Timur,
Any reason not to use in_be8?
The first version code is finished by me some months ago. at that time I used
the in_be8.
What first version code? Did you implement this feature, too?
Wolfgang Denk wrote:
In message1292368731-3819-1-git-send-email-ti...@freescale.com you wrote:
In some usages of inline assembly, hard-coded registers were specified
when a
scratch register should have been used instead.
Is this just a cosmetic improvement, or are you fixing any real
Jaggi Manish-B10520 wrote:
Most of the read/write functions do this way
0:+ int sw = set_mux_to_lbc();
1:+
2:+ ret = __raw_readl(addr);
3:+ if (sw)
4:+ set_mux_to_diu();
compiler might reorder 2 before 3 and 0, read / write wont have any
issue , right ?
On Jul 17, 2010, at 10:17 PM, Jerry Van Baren gvb.ub...@gmail.com wrote:
Signed-off-by: Timur Tabiti...@freescale.com
^
Need a space in your SOB line?
That's your mailer, not me. Check the archive -- my message is correct.
I assume this is a live patch, and
Detlev Zundel wrote:
Can't you come up with a scheme which does not destroy this valuable
property of our coordinates?
I'm only doing two things:
1) Exposing a feature of the existing code. Notice that I only had to change
two lines in the cmd_bmp code, not any of the core bitmap code,
On Aug 27, 2010, at 8:14 AM, Detlev Zundel d...@denx.de wrote:
We can discuss this once I see the code that makes virtual coordinates
If you can help me figure out how to get the boot text to appear below the
logo, I won't need to use virtual coordinates.
On Aug 27, 2010, at 9:10 AM, Reinhard Meyer u-b...@emk-elektronik.de wrote:
2. would it be possible to just manipulate the initial Y for text output?
I'll try this approach. It should be simple enough.
___
U-Boot mailing list
U-Boot@lists.denx.de
On Thu, Apr 26, 2012 at 8:57 AM, Dirk Eibach eib...@gdsys.de wrote:
Signed-off-by: Dirk Eibach eib...@gdsys.de
Cc: Timur Tabi ti...@freescale.com
---
Changes in v2:
- add Cc
- split up original patch series
board/freescale/p1022ds/p1022ds.c | 4 ++
board/freescale/p1022ds/tlb.c |
Scott Wood wrote:
Well, as with most of our boards, NOR is the default configuration. Also,
there's no NAND support upstream yet.
What isn't upstream, besides the muxing hack? Does it need the 4K page
hack?
There's no NAND support at all. However, I just tried the two SDK patches
that
On Jun 8, 2012, at 6:09 PM, Wood Scott-B07421 b07...@freescale.com wrote:
I have two questions:
1. Is there a plan that we submit Timur' tool to open source?
I hope so. If not, the RCW will have to be provided directly as a
hexdump/binary/etc.
Where do you think my compiler should go?
On Jun 12, 2012, at 7:54 PM, Wood Scott-B07421 b07...@freescale.com wrote:
You mean to replace this tool? There are other PBL things that may need
to be done, such as reconfiguring the SPI speed so it doesn't take
forever to read out the rest of the PBL image.
My tool builds and RCW
Kumar Gala wrote:
#ifdef CONFIG_QE
/* QE microcode/firmware address */
-#define CONFIG_SYS_QE_FW_ADDR0xefec
-#define CONFIG_SYS_QE_FW_LENGTH 0x1
+#define CONFIG_SYS_QE_FMAN_FW_IN_NOR
+#define CONFIG_SYS_QE_FMAN_FW_ADDR 0xefec
+#define
On Tue, Nov 22, 2011 at 2:51 AM, Shengzhou Liu
shengzhou@freescale.com wrote:
+#ifdef CONFIG_PHYS_64BIT
+ puts(36-bit Addressing\n);
+#endif
We're not doing this any more. The 'bdinfo' command will be updated
to display this information instead.
Since Kumar already applied this
On Wed, Dec 7, 2011 at 8:42 AM, Kumar Gala ga...@kernel.crashing.org wrote:
+ if (flag BOOTM_STATE_OS_PREP) {
+ boot_prep_linux(images);
return 0;
+ }
if (flag BOOTM_STATE_OS_GO) {
boot_jump_linux(images);
York Sun wrote:
From: york york...@freescale.com
You should fix this so that it includes your full name.
--
Timur Tabi
Linux kernel developer at Freescale
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Jerry,
Now that the merge window is open, could you please update libfdt?
The version in U-Boot hasn't been updated in over a year, and there
are new features that I need to have. Specifically, this commit:
http://git.jdl.com/gitweb/?p=dtc.git;a=commit;h=d75b33af676d0beac8398651a7f09037555a550b
Kumar Gala wrote:
Erratum SERDES-8 says that the clocks for bank 3 needs to be enabled if
bank 2 is enabled, but this was not being done for SERDES protocols 0xF
and 0x10. The bank reset that was being done for erratum SERDES4 (a
left-over work-around that was removed in powerpc/85xx: remove
Kumar Gala wrote:
Ok, Can you send a commit message for when I merge them or repost a merged
patch.
powerpc/85xx: remove SERDES4 soft-reset work-around
Some P4080 rev1 errata work-arounds, notably erratum SERDES4, required a
bank soft-reset after the bank was configured and enabled, even
The following URL doesn't show anything:
http://git.denx.de/?p=u-boot.gita=searchh=HEADst=authors=Timur+Tabi
No matter what I put after the s=, I get nothing. I think it should
work, because this URL, which has the same search string, does work:
Wolfgang Denk wrote:
Software cursor support should be split off into a separate patch.
And CONFIG_VIDEO_SW_CURSOR needs to be documented.
That feature is already in U-Boot. All I'm doing is adding a #define
CONFIG_VIDEO_SW_CURSOR to the header file. I thought it was already documented
Kumar Gala wrote:
I'll deal with merge issues, can you ack or provide feedback on this patch
My patch, [v3] powerpc: user 'video-mode' environment variable to configure
DIU (user should be use) should be applied instead.
--
Timur Tabi
Linux kernel developer
Kumar Gala wrote:
what about this patch?
I missed this one. Unfortunately, it conflicts with my patch. I'll have to
rewrite this one to make it work.
Plus, there were problems with it. For instance, I'm not crazy about the
setenv() calls (I NAK'd an earlier internal version of this patch
David Müller (ELSOFT AG) wrote:
Just out of curiosity -- do you have an example of a device tree with
an external UART?
Yes.
May I see it?
--
Timur Tabi
Linux kernel developer
___
U-Boot mailing list
U-Boot@lists.denx.de
On Thu, Apr 21, 2011 at 1:59 PM, Kumar Gala ga...@kernel.crashing.org wrote:
Introduce new CONFIG_SYS_FSL_TBCLK_DIV on 85xx platforms because
different SoCs have different divisor amounts. All the PQ3 parts are
/8, the P4080/P4080 is /16, and P2040/P3041/P5020 are /32.
Shouldn't there also be
Kumar Gala wrote:
The
work-around is to enable and then disable bank two after bank three is
disabled.
That should say, after bank three is enabled.
--
Timur Tabi
Linux kernel developer at Freescale
___
U-Boot mailing list
U-Boot@lists.denx.de
On Fri, Apr 22, 2011 at 8:26 AM, Kumar Gala ga...@kernel.crashing.org wrote:
Shouldn't there also be a README update to document this option?
I think its self evident what it is.
I have to disagree. Without reading the patch description, it's hard
to know what value to choose for this macro.
On Sun, Apr 24, 2011 at 6:50 PM, Wolfgang Denk w...@denx.de wrote:
And please add documentation for the new CONFIG_PRESERVE_LOCAL_MAC to
the README.
We have something similar already on Freescale parts, but it does
sometimes cause problems. If the environment ethaddr is already set,
it is
Anatolij,
Are you planning on making a pull request for u-boot-video soon? The
merge window closed last week, but I have some pending video patches
that I would like to see included.
___
U-Boot mailing list
U-Boot@lists.denx.de
On Wed, Apr 27, 2011 at 8:39 AM, Simon Schwarz
simonschwarz...@googlemail.com wrote:
So here is my question: Where do you see the most potential to optimize
u-boot?
I'm sure many of the timeouts could be optimized.
--
Timur Tabi
Linux kernel developer at Freescale
Anatolij Gustschin wrote:
it turns out that your patches broke DIU support on mpc5121. I need
to fix it first before sending a pull request. I'm planning to work
on fixes and hope to resolve the issue this week.
Anything I can do to help, please just let me know. We don't have any 5121s
here
On Thu, Apr 28, 2011 at 9:55 PM, Kumar Gala ga...@kernel.crashing.org wrote:
CONFIG_SYS_BOOTMAPSZ has been 64M on these boards for some time so we
should also allow the kernel image to be up to 64M decompressed. This
also matches what we pass to the OS based on the ePAPR specification.
Is
On Fri, Apr 29, 2011 at 10:34 AM, Kumar Gala ga...@kernel.crashing.org wrote:
Timur Tabi (7):
powerpc/86xx: remove empty board_early_init_f()
powerpc/fsl: add 'pixis_reset dump' command
powerpc/85xx: Implement work-around for P4080 erratum SERDES-A005
powerpc/85xx: Display
Wolfgang Denk wrote:
Why do we need this if at all? tolower() on a digit is a nop, so you
can omit the first branch.
Because cpu-name looks like one of two ways:
8578
or
P4080
In the case of 8578, we want to convert that to mpc8578. In the case of
P4080, we want to
Wolfgang Denk wrote:
This gets lost in the code.
That's why I added the comments:
/* MPC, where == 4-digit number */
If you keep the if / else, you have to add braces for the multiline
statements.
Ok.
--
Timur Tabi
Linux kernel developer at Freescale
Mike Frysinger wrote:
so implement this in your board file in misc_init_r or board_eth_init. have
the code do something like:
uchar enetaddr[6];
if (!eth_getenv_enetaddr(ethaddr, enetaddr)) {
/* ... read current MAC out of the driver's registers ... */
On Mon, May 2, 2011 at 10:00 AM, Kumar Gala ga...@kernel.crashing.org wrote:
I thought that was less of an issue because of our use of patchworks.
How? Patchwork uses the same subject line as the email. There's
still the problem of trying to correlate the actual commit to the
entry in
On Mon, May 2, 2011 at 8:51 PM, York Sun york...@freescale.com wrote:
- printf(The DIMM max tCKmin is %d ps,
+ printf(The combined minimum tCKmin is %d ps,
doesn't support the MCLK cycle %d ps\n,
That still needs some work, IMHO. I think you
On Fri, Mar 9, 2012 at 1:54 AM, chang-ming.hu...@freescale.com wrote:
-#define CONFIG_SATA_SIL3114
+#define CONFIG_SATA_SIL
This is not enabling SATA. This is choosing the correct driver.
You can only use the word enable if the feature was intentionally
disabled before, e.g. because the
On Sat, Mar 17, 2012 at 6:19 PM, Wolfgang Denk w...@denx.de wrote:
Doubling it is kind of aggressive strategy. You know exactly how much
free room needs to be guaranteed, so why don't you auto-adjust the
size?
-#define CONFIG_SYS_MALLOC_LEN (128 * 1024) /* Reserved for malloc
*/
On Tue, Sep 13, 2011 at 2:15 AM, Zhao Chenhui
chenhui.z...@freescale.com wrote:
From: chenhui zhao chenhui.z...@freescale.com
-Increase the size of malloc space.
-Enable e1000 network card.
-Change the location of env address.
-Use hwconfig to turn off ECC.
Please repost this patch with a
On Tue, Sep 13, 2011 at 2:15 AM, Zhao Chenhui
chenhui.z...@freescale.com wrote:
@@ -222,8 +222,8 @@ int checkboard (void)
printf(PCI1: %d bit, %s MHz, %s\n,
(pci1_32) ? 32 : 64,
- (pci1_speed == 3300) ? 33 :
- (pci1_speed == 6600) ?
On Mon, Oct 3, 2011 at 6:59 PM, Becky Bruce bec...@kernel.crashing.org wrote:
-#ifdef DEBUG
const char *step_string_tbl[] = {
STEP_GET_SPD,
STEP_COMPUTE_DIMM_PARMS,
@@ -153,7 +152,6 @@ const char * step_to_string(unsigned int step) {
return step_string_tbl[s];
}
On Mon, Oct 3, 2011 at 9:44 AM, Kumar Gala ga...@kernel.crashing.org wrote:
Timur Tabi (4):
powerpc/85xx: introduce and document CONFIG_SYS_CCSRBAR macros
powerpc/85xx: relocate CCSR before creating the initial RAM area
powerpc/mp: add support for discontiguous cores
Kumar Gala wrote:
Note: I'm not sure of my change to struct fm_mdio. It works, but it
doesn't
smell right.
What exactly is the concern?
Nothing specific, just a gut feeling.
--
Timur Tabi
Linux kernel developer at Freescale
___
U-Boot
On Sat, Oct 8, 2011 at 2:33 AM, Zhao Chenhui chenhui.z...@freescale.com wrote:
- Fix config according to system address map in the manual.
- Rework tlb and law tables.
- Remove unnecessary macros.
You're making a lot of changes here. The device tree needs to match
the U-Boot configuration.
On Sun, Oct 9, 2011 at 5:55 PM, Kumar Gala ga...@kernel.crashing.org wrote:
- Increase the size of malloc space.
- Enable e1000 network card.
- Show pci devices on startup.
- Change the location of env address.
- Use hwconfig to turn off ECC by default.
This patch is missing all of the
Kumar Gala wrote:
* The only things not explained is the env address change. I can see
it matches our other boards MPC8572DS, etc. So not exactly critical to
me.
There's no explanation for increasing the malloc size.
* If Wolfgang wants to remove CONFIG_PCI_SCAN_SHOW so be it, but as
long
On Mon, Oct 10, 2011 at 4:35 AM, Stefano Babic sba...@denx.de wrote:
New default, weak i2c_set_bus_num() function.
Signed-off-by: Stefano Babic sba...@denx.de
Cc: Heiko Schocher h...@denx.de
I would prefer to see a new set of I2C functions that take a bus
number as a parameter, so that we can
On Thu, Oct 6, 2011 at 4:23 PM, Wolfgang Denk w...@denx.de wrote:
Checkpatch says:
WARNING: static const char * array should probably be static const
char * const
#1511: FILE: board/freescale/p3060qds/p3060qds.c:84:
+ static const char *freq[] = {100, 125, Reserved,
Please
Kumar Gala wrote:
Rather than looking at tn2020_driver.uid lets just do something like:
if ((phydev-drv-uid phydev-drv-mask) == TN2020_UID)
And add a #define in phy.h:
#define TN2020_UID0x00a19410
I guess that makes more sense. I thought my original version was cooler,
though.
--
Kumar Gala wrote:
For the FSL boards, lets add 'bdinfo' to 'preboot' and enable CONFIG_PREBOOT
I don't think that's a good idea. bdinfo display about a dozen lines of
text, most of it is not generally useful. Plus, this would make preboot
unavailable for everyone else.
--
Timur Tabi
Linux
On Fri, Oct 14, 2011 at 2:34 AM, Kumar Gala ga...@kernel.crashing.org wrote:
The following changes since commit d8fffa057c9430fd0c5104ab6ff7db4cdb03db51:
Merge branch 'master' of git://git.denx.de/u-boot-mips (2011-10-12 22:47:15
+0200)
are available in the git repository at:
On Fri, Oct 14, 2011 at 4:32 PM, Wolfgang Denk w...@denx.de wrote:
These changes silently change the behaviour of the command. So far,
an argument line 24 would be parsed as hex number (i. e. result in
decimal value 36); with this change it suddenly becomes devcimal 24,
which is quite
On Tue, Jul 26, 2011 at 9:52 PM, Kumar Gala ga...@kernel.crashing.org wrote:
+/* CCSRBAR PHYSICAL Address */
+/* IN case of NAND bootloader relocate CCSRBAR in RAMboot code not in the 4k
+ SPL code*/
+#if defined(CONFIG_NAND_U_BOOT) defined(CONFIG_NAND_SPL)
+#define
On Fri, Jul 22, 2011 at 2:55 AM, Kumar Gala ga...@kernel.crashing.org wrote:
The following changes since commit 74fac70084bb040342fafc3b0d2ef50fbe35646f:
Merge branch 'master' of git://git.denx.de/u-boot-mmc (2011-07-19 22:27:07
+0200)
are available in the git repository at:
Kumar Gala wrote:
What changed in v2?
I fixed the problem on several boards where I wasn't setting the relocated
physical address properly. For instance, on the P2020DS, the original
code moved CCSR from ff7 to ffe, but my v1 patch left it at ff7 because I
didn't notice that the device tree
Kumar Gala wrote:
Why didn't we do in include/mpc85xx.h:
#ifndef CONFIG_SYS_CCSRBAR_PHYS_LOW
#define CONFIG_SYS_CCSRBAR_PHYS_LOW CONFIG_SYS_CCSRBAR
#endif
Thus removing that line from every board file?
That might make more sense, but that will break other boards where virtual
!=
Kumar Gala wrote:
ok. Sounds fine to leave as it, just wondering.
Also, I want people to specifically set the physical address in the board
header file if they want to relocate CCSR.
Anyway, I'll post a new version that reduces the merge conflicts.
--
Timur Tabi
Linux kernel developer at
York Sun wrote:
Change the help message to be more helpful. Print argument format.
Fix MAX_NUM_PORTS to comply with v1 NXID format.
Signed-off-by: York Sunyork...@freescale.com
Could you also fix the commands so that they take a number in decimal
instead of hex?
e.mac[index][i] =
York Sun wrote:
+/* Option parameter Structures */
+typedef struct {
+ const char *option_name;
+ size_t offset;
+ unsigned int size;
+ const char printHex;
+} options_strings_t;
Does it make sense for only printHex (which should be print_hex) and
option_name to be const,
York Sun wrote:
- e.mac_count = simple_strtoul(argv[2], NULL, 16);
+ e.mac_count = simple_strtoul(argv[2], NULL, 10);
You forgot the MAC address index. There's another use of strtoul in the
code that needs to be fixed.
Also, if you use 0 instead of 10, then it should
I see two calls to simple_stroul, and both have 16 in them.
--
Timur Tabi
Linux kernel developer at Freescale
From: sun york-R58495
Sent: Thursday, August 11, 2011 10:03 AM
To: Tabi Timur-B04825
Cc: u-boot@lists.denx.de
Subject: Re: [u-boot-release
On Thu, Aug 11, 2011 at 11:18 PM, Chunhe Lan chunhe@freescale.com wrote:
+/*
+ * Sets the specified node's status to the value contained in status.
+ * If the first character of the specified path is / then we use
+ * alias as a path. Otherwise, we look for an alias of that name.
+ */
On Mon, Aug 22, 2011 at 4:45 PM, Timur Tabi ti...@freescale.com wrote:
The Freescale QE and FMAN devices support uploading of firmware, and U-Boot
can locate that firmware on different types of storage media. However,
the current macros used for this code are inconsistent and poorly
On Thu, Aug 25, 2011 at 9:51 AM, Mike Frysinger vap...@gentoo.org wrote:
i feel like some (many?) #ifdef's in the tree could be done without ifdefs (by
relying on gcc's DCE) thus improving overall code quality
What's DCE?
--
Timur Tabi
Linux kernel developer at Freescale
On Mon, Aug 29, 2011 at 2:15 AM, Chunhe Lan chunhe@freescale.com wrote:
In the p1023rds, accessing exclusively nor flash or nand flash device by
BR0/OR0.
This is not an English sentence. I do not understand what you're saying.
--
Timur Tabi
Linux kernel developer at Freescale
On Wed, Aug 31, 2011 at 9:16 AM, Kumar Gala ga...@kernel.crashing.org wrote:
Signed-off-by: Kumar Gala ga...@kernel.crashing.org
---
Why are we enabling this?
--
Timur Tabi
Linux kernel developer at Freescale
___
U-Boot mailing list
Kumar Gala wrote:
On Aug 31, 2011, at 12:14 PM, Tabi Timur-B04825 wrote:
On Wed, Aug 31, 2011 at 9:16 AM, Kumar Galaga...@kernel.crashing.org
wrote:
Signed-off-by: Kumar Galaga...@kernel.crashing.org
---
Why are we enabling this?
because its a useful command that helps w/debugging
On Thu, Sep 1, 2011 at 6:40 AM, Dave Aldridge fovs...@gmail.com wrote:
#if !defined(CONFIG_SYS_NS16550_REG_SIZE) || (CONFIG_SYS_NS16550_REG_SIZE ==
0)
#error Please define NS16550 registers size.
+#elif defined(CONFIG_SYS_NS16550_MEM32)
+#define UART_REG(x) unsigned int x;
Shouldn't this
Kumar Gala wrote:
1. We reduce the amount printed in the default case
2. First choice should always be to have a command the print status info
3. Allow a board port to makes its own decision if it wants to do something
like enable CONFIG_PCI_SCAN_SHOW
Any concerns w/that proposal?
Are you
On Mon, Oct 31, 2011 at 1:19 AM, chang-ming.hu...@freescale.com wrote:
From: Jerry Huang chang-ming.hu...@freescale.com
When the resolution is set to 800x600 and 1024x768,
but, the driver will use 1280x1024 resolution to set the DIU register
Signed-off-by: Jerry Huang
On Mon, Oct 31, 2011 at 9:46 AM, Andy Fleming aflem...@freescale.com wrote:
We want to move everything to phylib, and we definitely don't want
new drivers using the miiphy infrastructure.
How about using gcc's deprecated function feature? Or is that too aggressive?
On Sun, Oct 30, 2011 at 7:54 PM, Mike Frysinger vap...@gentoo.org wrote:
-static void print_num(const char *, ulong);
+__maybe_unused
+static void print_num(const char *name, ulong value)
+{
+ printf(%-12s= 0x%08lX\n, name, value);
+}
Will the linker remove the functions from the
On Tue, Oct 18, 2011 at 4:05 PM, Kyle Moffett kyle.d.moff...@boeing.com wrote:
A followup patch will be adding a configurable feature to enable
programming of E1000 EEPROMs from the command line or via the generic
U-Boot SPI interface.
In order for it to work it needs access to certain
On Tue, Nov 1, 2011 at 9:08 PM, Huang Changming-R66093
r66...@freescale.com wrote:
Kim,
Since 2008, the boards shipped to customer are the new boards with 33.33MHz
oscillator and 512MB DDR.
How can I deal with the new board and old board?
Check the board revision at runtime.
--
Timur Tabi
On Wed, Oct 5, 2011 at 6:14 PM, Joe Hershberger joe.hershber...@ni.com wrote:
Signed-off-by: Joe Hershberger joe.hershber...@ni.com
Cc: Joe Hershberger joe.hershber...@gmail.com
Cc: Kim Phillips kim.phill...@freescale.com
---
Where's the patch description? You need to explain how this patch
1 - 100 of 112 matches
Mail list logo
