Re: imx8 regression: cyclic_register for watchdog@30280000 failed

2022-10-26 Thread Tim Harvey
On Wed, Oct 26, 2022 at 5:33 AM Rasmus Villemoes wrote: > > On 25/10/2022 18.32, Tim Harvey wrote: > > Greetings, > > > > I've noticed a regression since the merge of the cyclic framework use > > for watchdog on my imx8m boards: > > > > cycli

Re: [PATCH v7 7/8] net: add MV88E6xxx DSA driver

2022-10-26 Thread Tim Harvey
On Wed, Oct 26, 2022 at 12:55 PM Vladimir Oltean wrote: > > This patch looks much better to me. Only one comment. > > On Wed, Oct 26, 2022 at 09:28:58AM -0700, Tim Harvey wrote: > > +static int mv88e6xxx_port_enable(struct udevice *dev, int port, struct &

Re: imx8 regression: cyclic_register for watchdog@30280000 failed

2022-10-27 Thread Tim Harvey
On Wed, Oct 26, 2022 at 11:32 PM Stefan Roese wrote: > > Tim, > > On 26.10.22 21:06, Tim Harvey wrote: > > On Wed, Oct 26, 2022 at 5:33 AM Rasmus Villemoes > > wrote: > >> > >> On 25/10/2022 18.32, Tim Harvey wrote: > >>> Greetings, > &

[PATCH v8 2/8] net: dsa: move cpu port probe to dsa_post_probe

2022-10-27 Thread Tim Harvey
In order to ensure that a DSA driver probe gets called before dsa_ops->port_probe move the port_probe of the cpu_port to a post-probe function. Signed-off-by: Tim Harvey Reviewed-by: Ramon Fried Reviewed-by: Vladimir Oltean Reviewed-by: Fabio Estevam --- v8: - no changes v7: - no changes

[PATCH v8 1/8] net: mdio-uclass: scan for dm mdio children on post-bind

2022-10-27 Thread Tim Harvey
If a DM_MDIO driver is used we need to scan the subnodes as well. Signed-off-by: Tim Harvey Signed-off-by: Vladimir Oltean Reviewed-by: Ramon Fried Reviewed-by: Fabio Estevam --- v8: - no changes v7: - no changes v6: - no changes v5: - added Fabio's rb tag v4: - no changes v3:

[PATCH v8 0/8] Add MV88E6xxx DSA driver and use on gwventana

2022-10-27 Thread Tim Harvey
ngle port is active instead of mangling packets Tested on a Gateworks GW5904 which has a Marvell 88E6176 switch hanging off the IMX6 FEC. Best Regards, Tim Tim Harvey (8): net: mdio-uclass: scan for dm mdio children on post-bind net: dsa: move cpu port probe to dsa_post_probe net: dsa: en

[PATCH v8 3/8] net: dsa: ensure dsa driver has proper ops

2022-10-27 Thread Tim Harvey
Add a function to sanity check a dsa driver having proper ops. Suggested-by: Vladimir Oltean Signed-off-by: Tim Harvey Reviewed-by: Vladimir Oltean Reviewed-by: Fabio Estevam --- v8: - no changes v7: - no changes v6: - no changes v5: - added Fabio's rb tag v4: - no changes v3: -

[PATCH v8 5/8] net: ksz9477: remove unnecessary xmit and recv functions

2022-10-27 Thread Tim Harvey
Remove the unnecessary xmit and recv functions. Signed-off-by: Tim Harvey Reviewed-by: Vladimir Oltean Reviewed-by: Fabio Estevam --- v8: - no changes v7: - no changes v6: - no changes v5: - added Fabio's rb tag v4: - no changes v3: - added Vladimir's rb tag v2: new patch --

[PATCH v8 4/8] net: dsa: allow rcv() and xmit() to be optional

2022-10-27 Thread Tim Harvey
Allow rcv() and xmit() dsa driver ops to be optional in case a driver does not care to mangle a packet as in U-Boot only one network port is enabled at a time and thus no packet mangling is necessary. Suggested-by: Vladimir Oltean Signed-off-by: Tim Harvey Reviewed-by: Vladimir Oltean Reviewed

[PATCH v8 6/8] net: fec: add support for DM_MDIO

2022-10-27 Thread Tim Harvey
configuration necessary such as an mdio subnode, a phy-mode prop, and either a valid phy-handle prop or fixed-phy subnode which will cause dm_eth_phy_connect() to fail. Signed-off-by: Tim Harvey Reviewed-by: Fabio Estevam --- v8: - no changes v7: - no changes v6: - no changes v5: - added

[PATCH v8 7/8] net: add MV88E6xxx DSA driver

2022-10-27 Thread Tim Harvey
Add a DSA driver for the MV88E6xxx compatible Ethernet switches. Cc: Marek Behún Cc: Vladimir Oltean Signed-off-by: Tim Harvey Reviewed-by: Vladimir Oltean Reviewed-by: Fabio Estevam --- v8: - remove energy-detect low-power mode config v7: - rebase on master - update commit short msg (s

[PATCH v8 8/8] board: gw_ventana: enable MV88E61XX DSA support

2022-10-27 Thread Tim Harvey
weak override with board_phy_config support for register configuration that is outside the scope of the DSA driver Signed-off-by: Tim Harvey Reviewed-by: Fabio Estevam Reviewed-by: Vladimir Oltean --- v8: - added phy-mode = "internal" to phy ports v7: - added Vladimir's rb ta

Re: [PATCH v8 0/8] Add MV88E6xxx DSA driver and use on gwventana

2022-10-28 Thread Tim Harvey
On Fri, Oct 28, 2022 at 1:45 AM Vladimir Oltean wrote: > > On Thu, Oct 27, 2022 at 05:49:29PM -0700, Tim Harvey wrote: > > This series adds a DSA driver for the MV88E6xxx based on > > drivers/net/phy/mv88e61xx and uses it in the gwventana_gw5904_defconfig. > > Looks goo

Re: [PATCH 0/5] cyclic: get rid of (the need for) cyclic_init()

2022-10-28 Thread Tim Harvey
| 53 +++ > test/test-main.c | 3 +- > 8 files changed, 57 insertions(+), 100 deletions(-) > > -- > 2.37.2 Rasmus, Thanks, this does indeed resolve the SPL and U-Boot regressions introduced. I verified the watchdig is initaliz

[PATCH] drivers: net: aquantia: fix typos

2022-11-03 Thread Tim Harvey
Fix a couple of typos: - s/Acquantia/Aquantia/ - s/firmare/firmware/ Signed-off-by: Tim Harvey --- drivers/net/phy/aquantia.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/phy/aquantia.c b/drivers/net/phy/aquantia.c index 7e950fe0c2fe..79fbc115368a

[PATCH] board: gateworks: venice: remove redundance adjustment of thermal trip points

2022-11-04 Thread Tim Harvey
commit 0543a1ed2787 ("imx8m: fixup thermal trips") moved updating the thermal trip points to all IMX8M so we can remove it from our board specific dt config. Signed-off-by: Tim Harvey --- board/gateworks/venice/venice.c | 16 1 file changed, 16 deletions(-) diff --g

[PATCH] configs: imx8mn_venice: fix include header protection

2022-11-04 Thread Tim Harvey
Fix typo in the include header protection. Signed-off-by: Tim Harvey --- include/configs/imx8mn_venice.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/configs/imx8mn_venice.h b/include/configs/imx8mn_venice.h index c43c4da6fbf8..5fbfdf4602f2 100644 --- a

[PATCH] configs: imx8mn_venice.h: remove unused ifdef

2022-11-04 Thread Tim Harvey
remove unused ifdef left behind after commit ca3369df71d8 ("configs: drop CONFIG_SPL_ABORT_ON_RAW_IMAGE") Signed-off-by: Tim Harvey --- include/configs/imx8mm_venice.h | 2 -- include/configs/imx8mn_venice.h | 4 include/configs/imx8mp_venice.h | 4 3 files changed, 10

[PATCH] configs: imx8m{m, n}_venice: remove unneeded CONFIG_FEC_MXC_PHYADDR

2022-11-04 Thread Tim Harvey
400eebf10d9b ("configs: imx8m{m, n}_venice: remove unneeded CONFIG_FEC_MXC_PHYADDR") but got clobbered by commit 6889412ad5e7 ("Convert CONFIG_SYS_BARGSIZE to Kconfig") Signed-off-by: Tim Harvey --- include/configs/imx8mm_venice.h | 4 include/configs/imx8mn_venice

[PATCH] imx: imx8m{m,n,p}_venice: migrate to CONFIG_EXTRA_ENV_TEXT

2022-11-04 Thread Tim Harvey
Move the majority of the environment from the board headers to a separate text file. Signed-off-by: Tim Harvey --- board/gateworks/venice/venice.env | 34 ++ include/configs/imx8mm_venice.h | 47 ++- include/configs/imx8mn_venice.h | 47

[PATCH] configs: imx8m{m,n,p}_venice: disable autoload

2022-11-04 Thread Tim Harvey
disable network autoload Signed-off-by: Tim Harvey --- configs/imx8mm_venice_defconfig | 1 + configs/imx8mn_venice_defconfig | 1 + configs/imx8mp_venice_defconfig | 1 + 3 files changed, 3 insertions(+) diff --git a/configs/imx8mm_venice_defconfig b/configs/imx8mm_venice_defconfig index

[PATCH v2] imx8m{m,n}_venice: update env memory layout

2022-04-13 Thread Tim Harvey
- allows for 512KB script Signed-off-by: Tim Harvey Reviewed-by: Fabio Estevam --- v2: - rebase on imx/master - add Fabios rb tag --- configs/imx8mm_venice_defconfig | 2 +- configs/imx8mn_venice_defconfig | 2 +- include/configs/imx8mm_venice.h | 9 + include/configs/imx8mn_venice.h

[PATCH v2] configs: imx8m{m,n}_venice_defconfig: add usb support

2022-04-13 Thread Tim Harvey
Enable USB support for host controller and various USB ethernet devices. Example usage of USB Mass Storage (UMS) support: u-boot=> mmc list FSL_SDHC: 0 FSL_SDHC: 1 FSL_SDHC: 2 (eMMC) u-boot=> ums 0 mmc 2 UMS: LUN 0, dev mmc 2, hwpart 0, sector 0x0, count 0xe3 Signed-off-by: Tim

[PATCH v2] board: gateworks: venice: enable DM_SERIAL

2022-04-13 Thread Tim Harvey
Enable DM_SERIAL. Signed-off-by: Tim Harvey --- v2: rebase on imx/master --- configs/imx8mm_venice_defconfig | 2 ++ configs/imx8mn_venice_defconfig | 2 ++ 2 files changed, 4 insertions(+) diff --git a/configs/imx8mm_venice_defconfig b/configs/imx8mm_venice_defconfig index dd61ec9b70fb

[PATCH v2] board: gateworks: venice: use common GSC driver

2022-04-13 Thread Tim Harvey
Use the common GSC driver. This allows us to do some additional cleanup: - rename gsc{.c,.h} to eeprom{.c.h} for clarity - collapse eeprom_get_dev - remove unnecessary header files and alphabatize includes Signed-off-by: Tim Harvey --- v2: rebase on imx/master --- arch/arm/dts/imx8mm-venice

[PATCH v2] arm: dts: imx8m*-venice: add gpio hog support

2022-04-13 Thread Tim Harvey
may have been done by bootloader commands. - specify gpio names and initial config - enable GPIO_HOG Signed-off-by: Tim Harvey Acked-by: Peng Fan --- v2: - rebase on imx/master - add Peng's ack tag --- .../dts/imx8mm-venice-gw71xx-0x-u-boot.dtsi | 46 ++ .../dts/imx8mm-venice-gw72

[PATCH v2] imx8m{m,n}_venice_defconfig: add DT overlay support

2022-04-13 Thread Tim Harvey
enable CONFIG_OF_LIBFDT_OVERLAY to support applying dt overlays in U-Boot. Signed-off-by: Tim Harvey --- v2: rebase on imx/master --- configs/imx8mm_venice_defconfig | 1 + configs/imx8mn_venice_defconfig | 1 + 2 files changed, 2 insertions(+) diff --git a/configs/imx8mm_venice_defconfig b

Re: [PATCH v2] board: gateworks: venice: enable DM_SERIAL

2022-04-13 Thread Tim Harvey
On Wed, Apr 13, 2022 at 8:56 AM Michael Nazzareno Trimarchi wrote: > > Hi Tim > > On Wed, Apr 13, 2022 at 5:47 PM Tim Harvey wrote: > > > > Enable DM_SERIAL. > > > > Signed-off-by: Tim Harvey > > --- > > v2: rebase on imx/master > > --- &g

[PATCH v2] imx8m{m,n}-venice-gw7902: add support for GPY111 phy

2022-04-13 Thread Tim Harvey
The TI DP83867 phy has been replaced with the MaxLinear GPY111 phy due to part availability. Add support for it: - increase post-reset time to 300ms per datasheet - add tx-delay/rx-delay config Signed-off-by: Tim Harvey --- v2: rebase on imx/master --- arch/arm/dts/imx8mm-venice-gw7902-u

[PATCH] imx8m{m, n}_venice_defconfig: enable md5sum and crc32 commands

2022-04-13 Thread Tim Harvey
Enable the md5sum and crc32 commands. Signed-off-by: Tim Harvey --- configs/imx8mm_venice_defconfig | 4 +++- configs/imx8mn_venice_defconfig | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/configs/imx8mm_venice_defconfig b/configs/imx8mm_venice_defconfig index

[PATCH v2] board: gateworks: gw_ventana: use comomn GSC driver

2022-04-13 Thread Tim Harvey
(the EEPROM must be read in SPL before relocation, in SPL after relocation, and in U-Boot init. All subsequent uses can use the global structure) - remove unnecessary header files and alphabatize includes Signed-off-by: Tim Harvey --- v2: rebase on imx/master --- arch/arm/mach-imx/mx6

Re: Pull request: u-boot-imx u-boot-imx-20220412

2022-04-13 Thread Tim Harvey
On Wed, Apr 13, 2022 at 9:24 AM Tom Rini wrote: > > On Wed, Apr 13, 2022 at 11:41:45AM +0200, Stefano Babic wrote: > > > Hi Tom, > > > > please pull from u-boot-imx, thanks ! > > > > Note: I picked up Heinrich's patch for Renesas : > > ARM: renesas: reduce rcar3_salvator-x image size > > > >

[PATCH v2 1/2] board: gateworks: venice: add additional levels for dtb name match

2022-04-13 Thread Tim Harvey
Gateworks produces many products from a single PCB with subloaded components. Add an additional two levels of dtb name matching so that for example a GW7400-A matches the dtb name of gw74xx.dtb Signed-off-by: Tim Harvey --- v2: - rebase on imx/master --- board/gateworks/venice/eeprom.c | 8

[PATCH v2 2/2] board: gateworks: venice: add imx8mp-venice-gw740x support

2022-04-13 Thread Tim Harvey
M.2 Socket with USB2.0, PCIe, and dual-SIM - PMIC - Wide range DC input supply (8V to 60V DC) Do the following to add support for this and future imx8mp-venice boards: - add dts - add DRAM config - add PMIC config - add IMX8MP support in spl.c and venice.c Signed-off-by: Tim Harvey --- v2

Re: [PATCH 1/2] board: gateworks: venice: add additional levels for dtb name match

2022-04-13 Thread Tim Harvey
On Wed, Apr 13, 2022 at 1:21 AM Stefano Babic wrote: > > Hi Tim, > > (quite unrelated to this series): after applying tons of patches, there > are a list that are obsolete and need to be rebased. I applied several > of the patches you sent, some have open issues, some cannot be applied > (as this

[PATCH] pci: imx: use vpcie-supply if defined by device-tree

2022-04-13 Thread Tim Harvey
c: Ian Ray (maintainer:GE BX50V3 BOARD) Cc: Sebastian Reichel (maintainer:GE BX50V3 BOARD) Cc: Fabio Estevam (maintainer:MX6SABRESD BOARD) Cc: Marek Vasut (maintainer:NOVENA BOARD) Signed-off-by: Tim Harvey --- arch/arm/include/asm/arch-mx6/sys_proto.h | 2 +- drivers/pci/pcie_imx.c

[PATCH] pci: imx: remove weak overrides no longer used

2022-04-13 Thread Tim Harvey
There are no users of the imx6_pcie_toggle_power and imx6_pcie_toggle_reset weak overrides and as these functions are able to be handled now via dt properties lets remove these. Cc: Marek Vasut Signed-off-by: Tim Harvey --- arch/arm/include/asm/arch-mx6/sys_proto.h | 3 --- drivers/pci

Re: RFC: Updating i.MX8M CPU thermal trip-point at runtime

2022-04-14 Thread Tim Harvey
On Thu, Apr 14, 2022 at 3:58 AM Peng Fan (OSS) wrote: > > > > On 2022/4/14 16:37, Frieder Schrempf wrote: > > Hi Andrejs, > > > > +Cc: Jacky Bai > > > > Am 13.04.22 um 14:24 schrieb Andrejs Cainikovs: > >> [Sie erhalten nicht oft E-Mail von "andrejs.cainik...@toradex.com". > >> Weitere Information

Re: EXT: [PATCH] pci: imx: use vpcie-supply if defined by device-tree

2022-04-14 Thread Tim Harvey
On Thu, Apr 14, 2022 at 2:14 AM Ian Ray wrote: > > On Wed, Apr 13, 2022 at 03:54:37PM -0700, Tim Harvey wrote: > > > > If vpcie-supply is defined by device-tree use that if > > CONFIG_PCIE_IMX_POWER_GPIO is not defined. > > > > Note that after th

Re: [PATCH v2] board: gateworks: venice: enable DM_SERIAL

2022-04-14 Thread Tim Harvey
On Wed, Apr 13, 2022 at 10:21 AM Michael Nazzareno Trimarchi wrote: > > Hi > > On Wed, Apr 13, 2022 at 6:09 PM Tim Harvey wrote: > > > > On Wed, Apr 13, 2022 at 8:56 AM Michael Nazzareno Trimarchi > > wrote: > > > > > > Hi Tim > > >

Re: [PATCH V3 3/4] imx: imx8mn_evk: enable CONFIG_DM_SERIAL

2022-04-14 Thread Tim Harvey
On Tue, Apr 12, 2022 at 6:31 PM Peng Fan (OSS) wrote: > > From: Peng Fan > > Enable CONFIG_DM_SERIAL. uart2 and its pinmux was already > marked with u-boot,dm-spl. > > Signed-off-by: Peng Fan > --- > board/freescale/imx8mn_evk/spl.c | 12 ++-- > configs/imx8mn_ddr4_evk_defconfig | 1 +

Re: [PATCH V3 3/4] imx: imx8mn_evk: enable CONFIG_DM_SERIAL

2022-04-14 Thread Tim Harvey
On Thu, Apr 14, 2022 at 10:20 AM Tim Harvey wrote: > > On Tue, Apr 12, 2022 at 6:31 PM Peng Fan (OSS) wrote: > > > > From: Peng Fan > > > > Enable CONFIG_DM_SERIAL. uart2 and its pinmux was already > > marked with u-boot,dm-spl. > > > > Signe

Re: [PATCH v2] board: gateworks: venice: enable DM_SERIAL

2022-04-14 Thread Tim Harvey
On Thu, Apr 14, 2022 at 9:10 AM Tim Harvey wrote: > > On Wed, Apr 13, 2022 at 10:21 AM Michael Nazzareno Trimarchi > wrote: > > > > Hi > > > > On Wed, Apr 13, 2022 at 6:09 PM Tim Harvey wrote: > > > > > > On Wed, Apr 13, 2022

[PATCH v3] board: gateworks: venice: enable DM_SERIAL

2022-04-14 Thread Tim Harvey
UART pinmux now that it is no longer needed. Signed-off-by: Tim Harvey Cc: Michael Nazzareno Trimarchi --- v3: enable DM_SERIAL for SPL as well per Michael's suggestion v2: rebase on imx/master --- board/gateworks/venice/spl.c| 17 ++--- configs/imx8mm_venice_defc

Re: [PATCH v3] board: gateworks: venice: enable DM_SERIAL

2022-04-14 Thread Tim Harvey
On Thu, Apr 14, 2022 at 11:02 AM Michael Nazzareno Trimarchi wrote: > > HI Tim > > On Thu, Apr 14, 2022 at 7:53 PM Tim Harvey wrote: > > > > Enable DM_SERIAL for both U_Boot and the SPL. The uart2 and its pinmux > > are already marked with u-boot,dm-spl b

[PATCH v4] board: gateworks: venice: use common GSC driver

2022-04-14 Thread Tim Harvey
Use the common GSC driver. This allows us to do some additional cleanup: - rename gsc{.c,.h} to eeprom{.c.h} for clarity - collapse eeprom_get_dev - remove unnecessary header files and alphabatize includes - remove unnecessary check for clock-controller dt node Signed-off-by: Tim Harvey

[PATCH v3 1/2] board: gateworks: venice: add additional levels for dtb name match

2022-04-14 Thread Tim Harvey
Gateworks produces many products from a single PCB with subloaded components. Add an additional two levels of dtb name matching so that for example a GW7400-A matches the dtb name of gw74xx.dtb Signed-off-by: Tim Harvey --- v3: no changes - rebase --- board/gateworks/venice/eeprom.c | 8

[PATCH v3 2/2] board: gateworks: venice: add imx8mp-venice-gw740x support

2022-04-14 Thread Tim Harvey
M.2 Socket with USB2.0, PCIe, and dual-SIM - PMIC - Wide range DC input supply (8V to 60V DC) Do the following to add support for this and future imx8mp-venice boards: - add dts - add DRAM config - add PMIC config - add IMX8MP support in spl.c and venice.c Signed-off-by: Tim Harvey --- v3

Re: [PATCH 5/6] net: add MV88E61xx DSA driver

2022-04-14 Thread Tim Harvey
On Tue, Apr 12, 2022 at 7:13 AM Vladimir Oltean wrote: > > On Tue, Mar 29, 2022 at 03:52:39PM -0700, Tim Harvey wrote: > > Add a DSA driver for the MV88E61xx compatible GbE Ethernet switches. > > > > Signed-off-by: Tim Harvey > > --- > > drivers/net/Kconfig

[PATCH] arm: dts: imx8mp: add of-list support to common imx8mp-u-boot.dtsi

2022-04-15 Thread Tim Harvey
Add support for OF-LIST to common imx8mp-u-boot.dtsi so that it can be used with boards that have multiple DTB's. Signed-off-by: Tim Harvey Cc: Fabio Estevam Cc: NXP i.MX U-Boot Team Cc: Peng Fan Cc: Teresa Remmet Cc: Ying-Chun Liu (PaulLiu) Cc: Marcel Ziswiler --- arch/arm/dts/imx

Re: [PATCH v3 2/2] imx8mn/8mp: Allow booting via USB

2022-04-25 Thread Tim Harvey
On Thu, Apr 21, 2022 at 11:06 AM Fabio Estevam wrote: > > From: Fabio Estevam > > When trying to boot via USB on i.MX8MN it is necessary to specify > the U-Boot environment location, otherwise the boot process simply > hangs. > > Specify the environment location when booting from USB. > > Tested

Re: [PATCH V2 20/26] imx: dynamic setting mmcdev and mmcroot

2022-04-25 Thread Tim Harvey
On Tue, Apr 5, 2022 at 10:56 PM Peng Fan (OSS) wrote: > > From: Peng Fan > > Dynamic setting mmcdev and mmcroot. > Then when boot linux, we can have correct "root=/dev/mmcblk[x]p2" > > Signed-off-by: Peng Fan > --- > arch/arm/include/asm/mach-imx/sys_proto.h | 2 + > board/freescale/common/Mak

Re: [PATCH v3 2/2] imx8mn/8mp: Allow booting via USB

2022-04-25 Thread Tim Harvey
On Mon, Apr 25, 2022 at 3:47 PM Fabio Estevam wrote: > > Hi Tim, > > On 25/04/2022 16:41, Tim Harvey wrote: > > > Fabio, > > > > Thanks - this at least allows me to boot on imx8mp-venice-gw74xx > > without needing to enable CONFIG_ENV_IS_NOWHERE. >

[PATCH] imx8*_venice_defconfig: configure default MMC env device

2022-04-26 Thread Tim Harvey
works when botting from USB/SDP. Signed-off-by: Tim Harvey --- configs/imx8mm_venice_defconfig | 1 + configs/imx8mn_venice_defconfig | 1 + configs/imx8mp_venice_defconfig | 1 + 3 files changed, 3 insertions(+) diff --git a/configs/imx8mm_venice_defconfig b/configs/imx8mm_venice_defconfig index

Re: [PATCH] net: e1000: Depend on CONFIG_PCI

2022-04-26 Thread Tim Harvey
gt; help > This driver supports Intel(R) PRO/1000 gigabit ethernet family of > adapters. For more information on how to identify your adapter, go > -- > 2.35.1.1320.gc452695387.dirty > Makes sense, Reviewed-by: Tim Harvey Best Regards, Tim

[PATCH] board: gateworks: venice: add fixup for GW73xx-C+

2022-04-27 Thread Tim Harvey
revision boards. While we are at it, rename 'blob' to 'fdt' for clarity. Signed-off-by: Tim Harvey --- board/gateworks/venice/eeprom.c | 7 ++ board/gateworks/venice/eeprom.h | 3 +++ board/gateworks/venice/venice.c | 43 +++-- 3 files changed,

Re: U-Boot and ethernet regression on mx6cuboxi

2022-04-28 Thread Tim Harvey
On Thu, Apr 28, 2022 at 1:41 PM Tom Rini wrote: > > Hey, > > So my mx6cuboxi was out of my lab for a bit, and that's how this > regression got in mainline. With: > 4223fb0ee18d11462c55ac94198fdc2055f2c27c is the first bad commit > commit 4223fb0ee18d11462c55ac94198f

[PATCH] configs: imx8m{m, n}_venice: remove unneeded CONFIG_FEC_MXC_PHYADDR

2022-04-29 Thread Tim Harvey
The IMX8M based Venice boards all have device-tree fec nodes that use proper dt with a phy-handle pointing to a phy with reg assigned to the proper phy address. There is no need to keep using the CONFIG_FEC_MXC_PHYADDR hack when a proper dt is used - remove it. Signed-off-by: Tim Harvey

[PATCH] configs: imx8mp_venice: add FEC_QUIRK_ENET_MAC

2022-04-29 Thread Tim Harvey
The IMX8MP SoC FEC needs to have the FEC_QUIRK_ENET_MAC defined. Fixes: commit 2395625209cc ("board: gateworks: venice: add imx8mp-venice-gw740x support") Signed-off-by: Tim Harvey --- include/configs/imx8mp_venice.h | 4 1 file changed, 4 insertions(+) diff --git a/inclu

Re: [PATCH] configs: imx8mp_venice: add FEC_QUIRK_ENET_MAC

2022-04-29 Thread Tim Harvey
On Fri, Apr 29, 2022 at 10:08 AM Tim Harvey wrote: > > The IMX8MP SoC FEC needs to have the FEC_QUIRK_ENET_MAC defined. > > Fixes: commit 2395625209cc ("board: gateworks: venice: add > imx8mp-venice-gw740x support") > Signed-off-by: Tim Harvey > --- > i

[PATCH] configs: remove FEC_QUIRK_ENET_MAC from imx8m configs

2022-04-29 Thread Tim Harvey
FEC_QUIRK_ENET_MAC is defined in the imx-regs.h include file and thus does not need to be defined in the various board config includes. Signed-off-by: Tim Harvey --- include/configs/cgtqmx8.h | 1 - include/configs/imx8mm-cl-iot-gate.h| 1 - include/configs

[PATCH] board: gateworks: venice: enable SPL_DM_SERIAL

2022-04-29 Thread Tim Harvey
f the UART pinmux now that it is no longer needed. Signed-off-by: Tim Harvey --- board/gateworks/venice/spl.c| 23 ++- configs/imx8mm_venice_defconfig | 1 - configs/imx8mn_venice_defconfig | 1 - configs/imx8mp_venice_defconfig | 1 - 4 files changed, 2 insertions(+

[PATCH] board: gateworks: gw_ventana: add support for GPY111 PHY

2022-04-29 Thread Tim Harvey
The MaxLinear GPY111 PHY is being used on some boards due to part availability. Add support for this PHY which requires a longer reset post-delay and RGMII delay configuration. Signed-off-by: Tim Harvey --- arch/arm/dts/imx6qdl-gw51xx.dtsi| 2 +- arch/arm/dts/imx6qdl-gw52xx.dtsi

[PATCH] board: gateworks: gw_ventana: remove obsolete file

2022-04-29 Thread Tim Harvey
ove it now. Signed-off-by: Tim Harvey --- board/gateworks/gw_ventana/gsc.c | 471 --- 1 file changed, 471 deletions(-) delete mode 100644 board/gateworks/gw_ventana/gsc.c diff --git a/board/gateworks/gw_ventana/gsc.c b/board/gateworks/gw_ventana/gsc.c deleted file m

Re: [PATCH 02/15] imx: imx8m[m/n/p]_venice: Enable SPL_DM_SERIAL

2022-05-02 Thread Tim Harvey
ce.h b/include/configs/imx8mp_venice.h > index aa0396db8b8..5242b56ad8c 100644 > --- a/include/configs/imx8mp_venice.h > +++ b/include/configs/imx8mp_venice.h > @@ -97,9 +97,6 @@ > #define PHYS_SDRAM_SIZESZ_4G > #define CONFIG_SYS_BOOTM_LEN SZ_256M > > -/* UART */ > -#define CONFIG_MXC_UART_BASE UART2_BASE_ADDR > - > /* Monitor Command Prompt */ > #define CONFIG_SYS_CBSIZE SZ_2K > #define CONFIG_SYS_MAXARGS 64 > -- > 2.36.0 > Peng, Thanks for doing this. Acked-by: Tim Harvey It would be nice to get rid of the wdog pinmux as well... do you know if we can do that now as well? This

Re: [PATCH 1/4] configs: imx8m: use common imx8m.h for i.MX8MM

2022-05-03 Thread Tim Harvey
ne CONFIG_SPL_MAX_SIZE(148 * 1024) > -#define CONFIG_SYS_MONITOR_LEN SZ_512K > -#define CONFIG_SYS_UBOOT_BASE \ > - (QSPI0_AMBA_BASE + CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR * 512) > +#include > > #define CONFIG_SYS_BOOTM_LEN SZ_64M > > -#ifdef CONFIG_SPL_BUILD > -#define CONFIG_SPL_STACK 0x92 > -#define CONFIG_SPL_BSS_START_ADDR 0x91 > -#define CONFIG_SPL_BSS_MAX_SIZESZ_8K /* 8 KB */ > -#define CONFIG_SYS_SPL_MALLOC_START0x4220 > -#define CONFIG_SYS_SPL_MALLOC_SIZE SZ_512K /* 512 KB */ > - > -/* malloc f used before GD_FLG_FULL_MALLOC_INIT set */ > -#define CONFIG_MALLOC_F_ADDR 0x93 > -/* For RAW image gives a error info not panic */ > -#endif > - > #define MEM_LAYOUT_ENV_SETTINGS \ > "fdt_addr_r=0x4400\0" \ > "kernel_addr_r=0x4200\0" \ > -- > 2.36.0 > Peng, Great cleanup - thanks! This is a great start to getting rid of the remaining items in the config headers. Works great for Venice. I also tested venice with CONFIG_SYS_SPL_MALLOC_SIZE of SZ_512K and it worked fine so we can remove the re-define of that, but I will do that as a later patch so that this patch makes no code changes. Tested-by: Tim Harvey #imx8mm-venice-*

Re: [PATCH 2/4] configs: imx8m: use common imx8m.h for i.MX8MN

2022-05-03 Thread Tim Harvey
great start to getting rid of the remaining items in the config headers. If you do end up doing a 2nd version you can probably remove the comments on the sizes, for example 'SZ_8K /* 8 KB */'' as I think the comment is not needed. Works great for imx8mn-venice-*. Tested-by: Tim Harv

Re: [PATCH 3/4] configs: imx8m: use common imx8m.h for i.MX8MP

2022-05-03 Thread Tim Harvey
K 0x96 > -#define CONFIG_SPL_BSS_START_ADDR 0x0098fc00 > -#define CONFIG_SPL_BSS_MAX_SIZESZ_1K > -#define CONFIG_SYS_SPL_MALLOC_START0x4220 > -#define CONFIG_SYS_SPL_MALLOC_SIZE SZ_512K > - > /* malloc f used before GD_FLG_FULL_MALLOC_INIT set */ > #define CONFIG_MALLOC_F_ADDR 0x184000 > -/* For RAW image gives a error info not panic */ > > #define CONFIG_POWER_PCA9450 > > -- > 2.36.0 > Peng, Great cleanup - thanks! This is a great start to getting rid of the remaining items in the config headers. Same comment on the commit typo and eliminating the comments on the sizes. Works great for imx8mp-venice-* Tested-by: Tim Harvey #imx8mp-venice-* Best Regards, Tim

Re: [PATCH 09/17] imx: imx8mm/n/p-venice: enable pinctrl_wdog in SPL

2022-05-03 Thread Tim Harvey
timer_init(); > > /* Clear the BSS. */ > -- > 2.36.0 > Peng, Thanks for another great cleanup for imx8m! If you do another version of this series I would suggest changing the 2nd sentence of the commit logs from: set_wdog_reset function could be handled by imx_watchdog.c driver. to: The set_wdog_reset() function is not necessary as this is handled by the imx_watchdog.c driver due to the 'fsl,ext-reset-output' property being set. Tested By: Tim Harvey #imx8m{m,n,p}-venice-* Best Regards, Tim

Re: [PATCH] imx8mn_evk: Add the missing spl.bin entry

2022-05-03 Thread Tim Harvey
On Tue, May 3, 2022 at 12:03 PM Fabio Estevam wrote: > > From: Fabio Estevam > > The generated flash.bin does not boot the imx8mn evk LPDDR4 variant > as it misses the spl.bin description in binman. > > Add its entry to fix the boot on the imx8mn evk LPDDR4 variant. > > Signed-off-by: Fabio Estev

Re: i.MX8MP usb status

2022-05-05 Thread Tim Harvey
On Wed, May 4, 2022 at 6:54 PM Peng Fan (OSS) wrote: > > > > On 2022/5/4 20:53, Marek Vasut wrote: > > On 5/4/22 14:26, Peng Fan wrote: > >> Hi Marek, > > > > Hi, > > > >> Since you did some work on i.MX8MP USB, may I know the status? > >> Does host/device mode both supported in upstream? > > > >

Re: [PATCH] ARM: imx: imx8m: Adjust thermal trip points for Industrial parts

2022-05-05 Thread Tim Harvey
ive", type))) > + fdt_setprop_u32(blob, prop, "temperature", > (maxc - 10) * 1000); > + } > + } > +#endif > + > cleanup_nodes_for_efi(blob); > return 0; > } > -- > 2.25.1 > Adam, Reviewed-by: Tim Harvey Best Regards, Tim

[PATCH] RFC: net: fec: get rid of CONFIG_FEC_MXC_MDIO_BASE

2022-05-05 Thread Tim Harvey
should be the right solution for that. Signed-off-by: Tim Harvey Cc: Marcel Ziswiler (maintainer:Apalis iMX8) Cc: Oliver Graute (maintainer:i.MX8QM CGTQMX8 BOARD) Cc: Anatolij Gustschin (maintainer:CAPRICORN BOARD) Cc: Peng Fan (maintainer:i.MX8QM MEK BOARD) Cc: Fabio Estevam

Re: [PATCH 0/7] arm64: binman: use binman symbols for imx

2022-05-09 Thread Tim Harvey
Thank you for doing this, its something I've wanted to get in for a long time now. I can confirm this saves 39K in the IMX8M SPL. Tested-by: Tim Harvey #imx8mm-venice #imx8mn-venice #imx8mp-venice Best Regards, Tim

Re: [PATCH V2 5/7] ddr: imx8m: helper: load ddr firmware according to binman symbols

2022-05-09 Thread Tim Harvey
On Sat, May 7, 2022 at 3:22 AM Peng Fan (OSS) wrote: > > From: Peng Fan > > By reading binman symbols, we no need hard coded IMEM_LEN/DMEM_LEN after > we update the binman dtsi to drop 0x8000/0x4000 length for the firmware. > > And that could save binary size for many KBs. > > Signed-off-by: Peng

Re: [PATCH 1/2] net: dsa: fix phydev->speed being uninitialized for the CPU port fixed PHY

2022-03-25 Thread Tim Harvey
On Sat, Dec 4, 2021 at 3:01 PM Vladimir Oltean wrote: > > If the DSA API is going to allow drivers to do things such as: > > - phy_config in dsa_ops :: port_probe > - phy_startup in dsa_ops :: port_enable > > then it would actually be good if the ->port_probe() method would > actually be called in

Re: [PATCH 1/2] net: dsa: fix phydev->speed being uninitialized for the CPU port fixed PHY

2022-03-25 Thread Tim Harvey
On Fri, Mar 25, 2022 at 11:07 AM Vladimir Oltean wrote: > > Hi Tim, > > On Fri, Mar 25, 2022 at 09:53:20AM -0700, Tim Harvey wrote: > > Vladimir, > > > > I came across this while looking for the best place to configure cpu > > port interface mode (ie rgmii

Re: [PATCH] imx: ventana: enable ONFI detection to fix NAND chip configuration

2022-03-28 Thread Tim Harvey
On Tue, Mar 22, 2022 at 5:32 PM Fabio Estevam wrote: > > Hi Tim, > > On Tue, Mar 22, 2022 at 3:42 PM Tim Harvey wrote: > > > > Enable ONFI detection to fix NAND chip configuration. Without this > > the NAND oobsize will be wrong which leads to invalid ECC strengt

Re: [PATCH 19/23] video: Support showing the U-Boot logo

2022-03-28 Thread Tim Harvey
On Sun, Mar 27, 2022 at 11:36 PM Simon Glass wrote: > > Hi Tim, > > On Tue, 15 Mar 2022 at 10:14, Tim Harvey wrote: > > > > On Fri, Nov 19, 2021 at 12:28 PM Simon Glass wrote: > > > > > > Show the U-Boot logo by default. This is only 7KB in size so se

Re: [PATCH] board: gw_ventana: gsc: fix GSC read/write functions

2022-03-28 Thread Tim Harvey
On Thu, Mar 24, 2022 at 9:04 AM Tim Harvey wrote: > > On Thu, Mar 24, 2022 at 8:59 AM Fabio Estevam wrote: > > > > Hi Tim, > > > > On Thu, Mar 24, 2022 at 12:32 PM Tim Harvey wrote: > > > > > > commit 7c84319af9c7 ("dm: gpio: Correct use of -

Re: [PATCH] video: Do not show splash and U-Boot logo simultaneously

2022-03-28 Thread Tim Harvey
if (IS_ENABLED(CONFIG_VIDEO_LOGO) && > + !IS_ENABLED(CONFIG_SPLASH_SCREEN) && !plat->hide_logo) { > ret = show_splash(dev); > if (ret) { > log_debug("Cannot show splash screen\n"); > -

Re: [PATCH 1/2] net: dsa: fix phydev->speed being uninitialized for the CPU port fixed PHY

2022-03-28 Thread Tim Harvey
On Mon, Mar 28, 2022 at 2:26 AM Vladimir Oltean wrote: > > On Fri, Mar 25, 2022 at 02:03:56PM -0700, Tim Harvey wrote: > > On Fri, Mar 25, 2022 at 11:07 AM Vladimir Oltean > > wrote: > > > > > > Hi Tim, > > > > > > On Fri, Mar 25, 2022 a

Re: [PATCH] board: gw_ventana: gsc: fix GSC read/write functions

2022-03-29 Thread Tim Harvey
On Mon, Mar 28, 2022 at 12:53 PM Fabio Estevam wrote: > > Hi Tim, > > On Mon, Mar 28, 2022 at 4:24 PM Tim Harvey wrote: > > > Any other feedback on this? Regardless of if I2C drivers should return > > the same error code as Linux on a NAK, I would like to get this p

Re: [PATCH] mtd: nand: mxs_nand_spl: Remove the page aligned access

2022-03-29 Thread Tim Harvey
*nand_get_mtd(void) > -{ > - return mtd; > -} > - > int nand_default_bbt(struct mtd_info *mtd) > { > return 0; > -- > 2.7.4 > Ye Li, Tested-by: Tim Harvey #gw_ventana Note however that I use UBIFS to store the kernel/dtb's and do not use a FIT image Best Regards, Tim

Re: [PATCH 1/2] net: dsa: fix phydev->speed being uninitialized for the CPU port fixed PHY

2022-03-29 Thread Tim Harvey
On Mon, Mar 28, 2022 at 5:03 PM Vladimir Oltean wrote: > > On Mon, Mar 28, 2022 at 03:23:02PM -0700, Tim Harvey wrote: > > On Mon, Mar 28, 2022 at 2:26 AM Vladimir Oltean > > wrote: > > > > > > On Fri, Mar 25, 2022 at 02:03:56PM -0700, Tim Harvey wrote: >

[PATCH 1/6] net: mdio-uclass: scan for dm mdio children on post-bind

2022-03-29 Thread Tim Harvey
If a DM_MDIO driver is used we need to scan the subnodes as well. Signed-off-by: Tim Harvey Signed-off-by: Vladimir Oltean --- net/mdio-uclass.c | 4 1 file changed, 4 insertions(+) diff --git a/net/mdio-uclass.c b/net/mdio-uclass.c index e74e34f78f9c..190cb08b31d8 100644 --- a/net/mdio

[PATCH 0/6] Add MV88E61xx DSA driver and use on gwventana

2022-03-29 Thread Tim Harvey
gards, Tim Tim Harvey (6): net: mdio-uclass: scan for dm mdio children on post-bind net: dsa: move cpu port probe to dsa_post_probe net: mdio-uclass: add wrappers for read/write/reset operations net: fec: add support for DM_MDIO net: add MV88E61xx DSA driver board: gw_ventana: e

[PATCH 2/6] net: dsa: move cpu port probe to dsa_post_probe

2022-03-29 Thread Tim Harvey
In order to ensure that a DSA driver probe gets called before dsa_ops->port_probe move the port_probe of the cpu_port to a post-probe function. Signed-off-by: Tim Harvey --- net/dsa-uclass.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/net/dsa-uclass.

[PATCH 4/6] net: fec: add support for DM_MDIO

2022-03-29 Thread Tim Harvey
configuration necessary such as an mdio subnode, a phy-mode prop, and either a valid phy-handle prop or fixed-phy subnode. Signed-off-by: Tim Harvey --- drivers/net/fec_mxc.c | 113 ++ drivers/net/fec_mxc.h | 1 + 2 files changed, 104 insertions(+), 10 deletions

[PATCH 6/6] board: gw_ventana: enable MV88E61XX DSA support

2022-03-29 Thread Tim Harvey
that is outside the scope of the DSA driver Signed-off-by: Tim Harvey --- arch/arm/dts/imx6qdl-gw5904.dtsi| 35 + board/gateworks/gw_ventana/gw_ventana.c | 50 + configs/gwventana_gw5904_defconfig | 7 ++-- 3 files changed, 56 insertions(+), 36

[PATCH 3/6] net: mdio-uclass: add wrappers for read/write/reset operations

2022-03-29 Thread Tim Harvey
Add wrappers dm_mdio_read(), dm_mdio_write() and dm_mdio_reset() for DM MDIO's .read(), .write() and .reset() operations. Signed-off-by: Marek Behún Reviewed-by: Ramon Fried --- include/miiphy.h | 31 +++ net/mdio-uclass.c | 31 +++ 2 fil

[PATCH 5/6] net: add MV88E61xx DSA driver

2022-03-29 Thread Tim Harvey
Add a DSA driver for the MV88E61xx compatible GbE Ethernet switches. Signed-off-by: Tim Harvey --- drivers/net/Kconfig | 7 + drivers/net/Makefile| 1 + drivers/net/mv88e61xx.c | 982 3 files changed, 990 insertions(+) create mode 100644

Re: [PATCH 5/6] net: add MV88E61xx DSA driver

2022-03-30 Thread Tim Harvey
On Tue, Mar 29, 2022 at 4:22 PM Marek Behún wrote: > > On Tue, 29 Mar 2022 15:52:39 -0700 > Tim Harvey wrote: > > > Add a DSA driver for the MV88E61xx compatible GbE Ethernet switches. > > > > Signed-off-by: Tim Harvey > Marek, Thanks for looking at this. &g

Re: [PATCH 0/6] Add MV88E61xx DSA driver and use on gwventana

2022-03-30 Thread Tim Harvey
On Tue, Mar 29, 2022 at 3:52 PM Tim Harvey wrote: > > This series adds a DSA driver for the MV88E61xx based on > drivers/net/phy/mv88e61xx and uses in on the gwventana_gw5904_defconfig. > > The hope is that the other three boards that use the MV88E61xx driver > can move to this

[PATCH v2] board: gateworks: venice: determine dram size at runtime

2022-03-30 Thread Tim Harvey
The SPL does not update the memory node with the dram size from EEPROM but instead we can use get_ram_size which does a simple memory test to determine the available RAM. Update PHYS_SDRAM_SIZE to 4GiB as that is the max used on the Venice boards. Signed-off-by: Tim Harvey Reviewed-by: Fabio

[PATCH] imx8m{m,n}-venice-gw7902: add support for GPY111 phy

2022-03-30 Thread Tim Harvey
The TI DP83867 phy has been replaced with the MaxLinear GPY111 phy due to part availability. Add support for it: - increase post-reset time to 300ms per datasheet - add tx-delay/rx-delay config Signed-off-by: Tim Harvey --- arch/arm/dts/imx8mm-venice-gw7902-u-boot.dtsi | 2 +- arch/arm/dts

Re: [PATCH v2] board: gateworks: venice: determine dram size at runtime

2022-03-30 Thread Tim Harvey
On Wed, Mar 30, 2022 at 1:58 PM Fabio Estevam wrote: > > Hi Tim, > > On Wed, Mar 30, 2022 at 5:39 PM Tim Harvey wrote: > > > > The SPL does not update the memory node with the dram size from EEPROM > > but instead we can use get_ram_size which does a simple me

Re: [EXT] [PATCH] ARM: imx: romapi: Repair FlexSPI NOR boot offset

2022-03-31 Thread Tim Harvey
On Mon, Mar 28, 2022 at 7:55 AM Marek Vasut wrote: > > On 3/28/22 08:54, Ye Li wrote: > > Hi Marek, > > Hi, > > [...] > > >>> 2. Update the u-boot.itb offset in imx8mp-u-boot.dtsi, set the > >>> offset > >>> to 0x5f000. The previous offset 0x58000 is for SD, calculated by > >>> 0x6 - 0x8000 (

Re: [EXT] [PATCH] ARM: imx: romapi: Repair FlexSPI NOR boot offset

2022-03-31 Thread Tim Harvey
On Thu, Mar 31, 2022 at 8:26 AM Marek Vasut wrote: > > On 3/31/22 17:09, Tim Harvey wrote: > > On Mon, Mar 28, 2022 at 7:55 AM Marek Vasut wrote: > >> > >> On 3/28/22 08:54, Ye Li wrote: > >>> Hi Marek, > >> > >> Hi, > >>

Re: [PATCH 4/6] net: fec: add support for DM_MDIO

2022-03-31 Thread Tim Harvey
On Thu, Mar 31, 2022 at 10:01 AM Vladimir Oltean wrote: > > On Tue, Mar 29, 2022 at 03:52:38PM -0700, Tim Harvey wrote: > > Add support for DM_MDIO by registering a UCLASS_MDIO driver and > > attempting to use it. This is necessary if wanting to use a DSA > > driver for ex

<    2   3   4   5   6   7   8   9   10   11   >