[PATCH] CI: Update test/nokia_rx51_test.sh to use prebuilt images

2023-02-21 Thread Tom Rini
From: Pali Rohár Now that the Dockerfile creates images which have the binaries we require included, have CI make symlinks for them and update the existing script to support this. Signed-off-by: Tom Rini --- Pali, since you posted this in a thread as untested, can you please reply with a S-o-b

Re: [PATCHv4 4/5] fwu: meta-data: switch to management by common code

2023-02-21 Thread Tom Rini
On Sat, Feb 04, 2023 at 09:02:02PM -0600, jassisinghb...@gmail.com wrote: > From: Jassi Brar > > The common code can now read, verify and fix meta-data copies > while exposing one consistent structure to users. > Only the .read_mdata() and .write_mdata() callbacks of fwu_mdata_ops > are needed.

Re: [PATCHv4 0/5] FWU: Handle meta-data in common code

2023-02-21 Thread Tom Rini
On Sat, Feb 04, 2023 at 09:00:56PM -0600, jassisinghb...@gmail.com wrote: > From: Jassi Brar > > The patchset reduces ~400 lines of code, while keeping the functionality same > and making > meta-data operations much faster (by using cached structures). > > Issue: > meta-data copies (primary a

Re: [PATCH v3 11/95] Correct SPL use of PHY_CADENCE_SIERRA

2023-02-21 Thread Tom Rini
On Tue, Feb 21, 2023 at 12:35:41PM -0700, Simon Glass wrote: > Hi Tom, > > On Tue, 14 Feb 2023 at 09:31, Tom Rini wrote: > > > > On Sun, Feb 12, 2023 at 04:15:14PM -0700, Simon Glass wrote: > > > This converts 1 usage of this option to the non-SPL

Re: [PATCH 9/9] Makefile: Show binman missing blob message

2023-02-21 Thread Tom Rini
On Tue, Feb 21, 2023 at 12:41:52PM -0700, Simon Glass wrote: > Hi Jonas > > +Tom Rini > > On Sun, 19 Feb 2023 at 15:02, Jonas Karlman wrote: > > > > When binman is invoked during a build of U-Boot and an external blob is > > missing, the user is usually presen

Re: [PATCH v4 00/10] usb: dwc3: Refactor dwc3-generic and apply to dwc3-uniphier

2023-02-22 Thread Tom Rini
On Wed, Feb 22, 2023 at 04:27:54AM +0100, Marek Vasut wrote: > On 2/22/23 03:00, Kunihiko Hayashi wrote: > > Hi Marek, > > > > On 2023/02/21 0:53, Marek Vasut wrote: > > > On 2/20/23 06:50, Kunihiko Hayashi wrote: > > > > This series achieves refactoring of dwc3-generic. > > > > > > > > First, dw

Re: [PATCH v1 12/24] ringneck-px30: remove check for ENV_IS_NOWHERE, it is an SPL config

2023-02-22 Thread Tom Rini
On Wed, Feb 22, 2023 at 03:45:17PM +0100, Quentin Schulz wrote: > Hi Troy, > > On 2/22/23 02:38, Troy Kisky wrote: > > When IS_ENABLED(CONFIG_ENV_IS_NOWHERE) is converted to > > CONFIG_IS_ENABLED(ENV_IS_NOWHERE) this will give unwanted errors > > on spl builds. > > > > Signed-off-by: Troy Kisky

Re: [PATCH v1 19/24] arm: mach-imx: use CONFIG_$(SPL_)SATA instead of CONFIG_SATA

2023-02-22 Thread Tom Rini
On Tue, Feb 21, 2023 at 05:38:16PM -0800, Troy Kisky wrote: > This avoid an error with enable_sata_clock when > defined(CONFIG_SATA) is changed to CONFIG_IS_ENABLED(SATA). > > Signed-off-by: Troy Kisky > --- > > arch/arm/mach-imx/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v1 21/24] gateworks: venice: surround call of setup_fec with if IS_ENABLED(CONFIG_NET)

2023-02-22 Thread Tom Rini
On Tue, Feb 21, 2023 at 05:38:18PM -0800, Troy Kisky wrote: > This is the same as the definition is surrounded by. > It avoids an error in converting to CONFIG_IS_ENABLED(NET). > > Signed-off-by: Troy Kisky > --- > > board/gateworks/venice/venice.c | 4 +++- > 1 file changed, 3 insertions(+), 1

Re: [PATCH v1 18/24] solidrun: mx6cuboxi: use CONFIG_IS_ENABLED(SATA) instead of CONFIG_CMD_SATA

2023-02-22 Thread Tom Rini
On Tue, Feb 21, 2023 at 05:38:15PM -0800, Troy Kisky wrote: > setup_sata is linked with > obj-$(CONFIG_SATA) += sata.o > > So use SATA instead of CMD_SATA. > > Signed-off-by: Troy Kisky > --- > > board/solidrun/mx6cuboxi/mx6cuboxi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH v1 17/24] ns16550: match when to define bdf with uart code

2023-02-22 Thread Tom Rini
On Tue, Feb 21, 2023 at 05:38:14PM -0800, Troy Kisky wrote: > When switching defined(CONFIG_PCI) to CONFIG_IS_ENABLED(PCI) > bdf is no longer accessible. So change to preprocessor to avoid access. > > Signed-off-by: Troy Kisky > --- > > arch/x86/cpu/apollolake/uart.c | 6 +++--- > include/ns16

Re: [PATCH 2/3] rockchip: Disable DISTRO_DEFAULTS for rockpro64

2023-02-22 Thread Tom Rini
On Wed, Feb 22, 2023 at 10:19:03AM -0800, Vagrant Cascadian wrote: > On 2023-02-21, Vagrant Cascadian wrote: > > On 2023-02-21, Simon Glass wrote: > >> This board has moved to standard boot but the old 'distro_bootcmd' > >> command is still active. Disable DISTRO_DEFAULTS to fix this. > > > > Works

Re: [PULL] u-boot-usb/next

2023-02-22 Thread Tom Rini
On Wed, Feb 22, 2023 at 04:36:08PM +0100, Marek Vasut wrote: > The following changes since commit 4eb7c5030d3f3c707c02a64dc8ea90de3da89928: > > Merge tag 'efi-2023-04-rc3' of > https://source.denx.de/u-boot/custodians/u-boot-efi (2023-02-19 17:03:30 > -0500) > > are available in the Git reposi

Re: [PATCH 2/3] rockchip: Disable DISTRO_DEFAULTS for rockpro64

2023-02-22 Thread Tom Rini
On Wed, Feb 22, 2023 at 11:58:37AM -0700, Simon Glass wrote: > Hi, > > On Wed, 22 Feb 2023 at 11:56, Jonas Karlman wrote: > > > > On 2023-02-22 19:24, Tom Rini wrote: > > > On Wed, Feb 22, 2023 at 10:19:03AM -0800, Vagrant Cascadian wrote: > > >&

Re: [PATCH 2/3] rockchip: Disable DISTRO_DEFAULTS for rockpro64

2023-02-22 Thread Tom Rini
On Wed, Feb 22, 2023 at 12:03:58PM -0700, Simon Glass wrote: > Hi Tom, > > On Wed, 22 Feb 2023 at 12:01, Tom Rini wrote: > > > > On Wed, Feb 22, 2023 at 11:58:37AM -0700, Simon Glass wrote: > > > Hi, > > > > > > On Wed, 22 Feb 2023 at 11:56, Jonas

Re: [PATCH v3 68/95] socfpga: Use the correct condition for SYS_L2_PL310

2023-02-22 Thread Tom Rini
On Wed, Feb 22, 2023 at 12:16:53PM -0700, Simon Glass wrote: > Hi Tom, > > On Tue, 14 Feb 2023 at 09:38, Tom Rini wrote: > > > > On Sun, Feb 12, 2023 at 04:16:11PM -0700, Simon Glass wrote: > > > > > Update this to use the PPL condition instead, so that not

Re: [PATCH 9/9] Makefile: Show binman missing blob message

2023-02-22 Thread Tom Rini
On Wed, Feb 22, 2023 at 02:20:08PM -0700, Simon Glass wrote: > Hi Tom, > > On Tue, 21 Feb 2023 at 16:09, Tom Rini wrote: > > > > On Tue, Feb 21, 2023 at 12:41:52PM -0700, Simon Glass wrote: > > > Hi Jonas > > > > > > +Tom Rini > > >

Re: [PULL] u-boot-socfpga/master

2023-02-22 Thread Tom Rini
On Wed, Feb 22, 2023 at 02:04:43AM +0100, Marek Vasut wrote: > The following changes since commit 4eb7c5030d3f3c707c02a64dc8ea90de3da89928: > > Merge tag 'efi-2023-04-rc3' of > https://source.denx.de/u-boot/custodians/u-boot-efi (2023-02-19 17:03:30 > -0500) > > are available in the Git reposi

Re: [PULL] u-boot-usb/master

2023-02-22 Thread Tom Rini
On Wed, Feb 22, 2023 at 05:27:16PM +0100, Marek Vasut wrote: > The following changes since commit 4eb7c5030d3f3c707c02a64dc8ea90de3da89928: > > Merge tag 'efi-2023-04-rc3' of > https://source.denx.de/u-boot/custodians/u-boot-efi (2023-02-19 17:03:30 > -0500) > > are available in the Git reposi

Re: [PULL] u-boot-usb/next

2023-02-22 Thread Tom Rini
On Wed, Feb 22, 2023 at 11:09:00PM +0100, Marek Vasut wrote: > On 2/22/23 19:37, Tom Rini wrote: > > On Wed, Feb 22, 2023 at 04:36:08PM +0100, Marek Vasut wrote: > > > > > The following changes since commit > > > 4eb7c5030d3f3c707c02a64dc8ea90de3da89928: >

Re: [PATCH v1 1/1] tools: env: use /run to store lockfile

2023-02-22 Thread Tom Rini
> > -----Original Message- > From: Tom Rini > Sent: Friday, February 10, 2023 11:30 PM > To: Tim Lee > Cc: s...@chromium.org; CS20 CHLi30 ; u-boot@lists.denx.de > Subject: Re: [PATCH v1 1/1] tools: env: use /run to store lockfile > > On Fri, Feb 10, 2023 at 05:05:3

Re: [PATCH] lib: bzip2: remove inlining

2023-02-23 Thread Tom Rini
On Thu, Feb 23, 2023 at 08:15:25AM +0100, Heinrich Schuchardt wrote: > Compiling sandbox_defconfig with CONFIG_CC_OPTIMIZE_FOR_DEBUG=y and > gcc 12.2.0-14ubuntu1 leads to a build error: > > lib/bzip2/bzlib.c: In function 'BZ2_decompress': > lib/bzip2/bzlib.c:726:18: error: inlining failed

Re: [PATCH v2 1/2] env: mmc: Clean up macro usage

2023-02-23 Thread Tom Rini
; > > mix of ifdef. > > > > > > Signed-off-by: Marek Vasut > > > --- > > > Cc: Patrice Chotard > > > Cc: Patrick Delaunay > > > Cc: Tom Rini > > > --- > > > V2: Replace CONFIG_IS_ENABLED(PARTITION_TYPE_GUID) with

Re: [PATCH v2] usb: dwc3-uniphier: Select PHY

2023-02-23 Thread Tom Rini
On Thu, Feb 23, 2023 at 05:29:24PM +0100, Marek Vasut wrote: > Make sure the PHY subsystem is activated for the uniphier DWC3 glue > logic, as it depends on PHY implementation there. > > Signed-off-by: Marek Vasut Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signatu

Re: [PULL] u-boot-usb/next

2023-02-23 Thread Tom Rini
On Wed, Feb 22, 2023 at 11:09:00PM +0100, Marek Vasut wrote: > On 2/22/23 19:37, Tom Rini wrote: > > On Wed, Feb 22, 2023 at 04:36:08PM +0100, Marek Vasut wrote: > > > > > The following changes since commit > > > 4eb7c5030d3f3c707c02a64dc8ea90de3da89928: >

Re: [PATCH] lib: bzip2: remove inlining

2023-02-23 Thread Tom Rini
On Thu, Feb 23, 2023 at 05:39:08PM +0100, Heinrich Schuchardt wrote: > On 2/23/23 17:30, Tom Rini wrote: > > On Thu, Feb 23, 2023 at 08:15:25AM +0100, Heinrich Schuchardt wrote: > > > Compiling sandbox_defconfig with CONFIG_CC_OPTIMIZE_FOR_DEBUG=y and > > > gcc 12.2.0

Re: [PATCH] lib: bzip2: remove inlining

2023-02-23 Thread Tom Rini
On Thu, Feb 23, 2023 at 10:53:44PM +0100, Heinrich Schuchardt wrote: > > > On 2/23/23 17:40, Tom Rini wrote: > > On Thu, Feb 23, 2023 at 05:39:08PM +0100, Heinrich Schuchardt wrote: > > > On 2/23/23 17:30, Tom Rini wrote: > > > > On Thu, Feb 23, 2023 at 0

Re: [PATCH v1 19/24] arm: mach-imx: use CONFIG_$(SPL_)SATA instead of CONFIG_SATA

2023-02-23 Thread Tom Rini
On Thu, Feb 23, 2023 at 11:23:47AM -0800, Troy Kisky wrote: > On Wed, Feb 22, 2023 at 7:05 AM Tom Rini wrote: > > > On Tue, Feb 21, 2023 at 05:38:16PM -0800, Troy Kisky wrote: > > > > > This avoid an error with enable_sata_clock when > > > defined(CONFIG_S

Re: [PATCH v1] configs: j7200: Merge HS and non-HS defconfigs

2023-02-23 Thread Tom Rini
On Wed, Feb 22, 2023 at 09:02:12AM -0600, Andrew Davis wrote: > On 2/22/23 1:56 AM, Manorit Chawdhry wrote: > > K3 devices have runtime type board detection. Make the default defconfig > > include the secure configuration. Then remove the HS specific config. > > > > Non-HS devices will continue to

Re: [PATCH] lmb: Bump CONFIG_LMB_MAX_REGIONS

2023-02-23 Thread Tom Rini
On Thu, Feb 23, 2023 at 10:24:44AM +0100, Patrick DELAUNAY wrote: > Hi, > > On 2/17/23 10:28, Michal Suchánek wrote: > > Hello, > > > > On Sun, Feb 12, 2023 at 06:45:36PM -0500, Tom Rini wrote: > > > On Wed, Feb 08, 2023 at 02:50:16PM -0500, Tom Rini wrote: &

Re: [PATCH v1 0/3] fdt: Fix mtparts fixup

2023-02-23 Thread Tom Rini
On Thu, Feb 23, 2023 at 11:23:41AM +0100, Patrick DELAUNAY wrote: > Hi, > > On 1/23/23 21:01, Tom Rini wrote: > > On Mon, Jan 23, 2023 at 11:06:06AM +0100, Miquel Raynal wrote: > > > Hi Tom, > > > > > > tr...@konsulko.com wrote on Fri, 13 Jan 2023 14:

Re: Pull request for efi-2023-04-rc3-2

2023-02-24 Thread Tom Rini
On Fri, Feb 24, 2023 at 11:02:57AM +0100, Heinrich Schuchardt wrote: > The following changes since commit 8c3acb726ef083d3d5de12f20318ee0e5070: > > Merge branch 'master' of > https://source.denx.de/u-boot/custodians/u-boot-usb (2023-02-22 13:36:29 > -0500) > > are available in the Git repos

Re: [PATCH] fs: btrfs: limit the mapped length to the original length

2023-02-24 Thread Tom Rini
On Mon, Feb 13, 2023 at 08:37:59AM +0800, Qu Wenruo wrote: > [BUG] > There is a bug report that btrfs driver caused hang during file read: > > This breaks btrfs on the HiFive Unmatched. > > => pci enum > PCIE-0: Link up (Gen1-x8, Bus0) > => nvme scan > => load nvme 0:2 0x8c00 /boot

Re: [PATCH 1/2] Makefile: Link with -z noexectack

2023-02-24 Thread Tom Rini
On Tue, Feb 14, 2023 at 03:09:31PM -0500, Tom Rini wrote: > When moving to gcc-12.2 we started trying to quiet some of the new > linker warnings, that are not relevant to us. However, a > misunderstanding of the mechanics at play meant that I intentionally > omitted passing -z noexec

Re: [PATCH 2/2] x86: Pass -z execstack for EFI payload flags

2023-02-24 Thread Tom Rini
On Tue, Feb 14, 2023 at 03:09:32PM -0500, Tom Rini wrote: > To match how we link EFI executables elsewhere, and to silence a linker > warning, pass -z execstack here as well. > > Cc: Bin Meng > Cc: Heinrich Schuchardt > Signed-off-by: Tom Rini Applied to u-boot/master

Re: [PATCH v2 2/2] env: mmc: Apply GPT only on eMMC user HW partition

2023-02-24 Thread Tom Rini
HW partition. > > This fixes environment operation on systems where CONFIG_SYS_MMC_ENV_PART > is non-zero and CONFIG_SYS_REDUNDAND_ENVIRONMENT is set. > > Fixes: 80105d8fd52 ("env: mmc: select GPT env partition by type guid") > Signed-off-by: Marek Vasut > Reviewed-by:

Re: [PATCH] trace: Relax test requirements

2023-02-24 Thread Tom Rini
On Fri, Feb 17, 2023 at 03:45:16PM -0700, Simon Glass wrote: > We expect the profile and bootstage to agree on timing, but when > running on slow machines there can be a larger descrepency. Increase the > tolerance to fix this. > > Fixes: 9cea4797aeb ("trace: Add a test") > Signed-off-by: Simon G

Re: Pull request, u-boot-tegra/master

2023-02-24 Thread Tom Rini
On Thu, Feb 23, 2023 at 02:25:04PM -0700, Tom Warren wrote: > Tom, > > Please pull u-boot-tegra/master into U-Boot/master. Thanks. > It has passed 'buildman tegra' w/o error, and Thierry has tested it on his > Tegra boards. > > The following changes since commit 8c3acb726ef083d3d5de12f20318e

Re: Pull request for efi-2023-04-rc3-2

2023-02-24 Thread Tom Rini
On Fri, Feb 24, 2023 at 04:52:06PM +0200, Ilias Apalodimas wrote: > Hi all, > > Just to put some context > > On Fri, 24 Feb 2023 at 16:44, Heinrich Schuchardt > wrote: > > > > On 2/24/23 15:42, Tom Rini wrote: > > > On Fri, Feb 24, 2023 at 11:02:57AM +0100

Re: Pull request for efi-2023-04-rc3-2

2023-02-24 Thread Tom Rini
On Fri, Feb 24, 2023 at 03:44:19PM +0100, Heinrich Schuchardt wrote: > On 2/24/23 15:42, Tom Rini wrote: > > On Fri, Feb 24, 2023 at 11:02:57AM +0100, Heinrich Schuchardt wrote: > > > The following changes since commit > > > 8c3acb726ef083d3d5de12f20318ee0e5070: &

Re: [PATCH 1/1] Dockerfile: download binaries for Nokia RX-51

2023-02-25 Thread Tom Rini
On Fri, Jan 13, 2023 at 07:25:01PM +0100, Heinrich Schuchardt wrote: > Downloading files for a test may fail if the server is offline. > It is preferable to provide the files in our Docker image. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Simon Glass Applied to u-boot/next, thanks!

Re: [PATCH 1/1] Dockerfile: build qemu for Nokia n900

2023-02-25 Thread Tom Rini
On Fri, Jan 13, 2023 at 08:31:33PM +0100, Heinrich Schuchardt wrote: > Using a pre-built QEMU saves a lot of time when testing. > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] CI: Update test/nokia_rx51_test.sh to use prebuilt images

2023-02-25 Thread Tom Rini
On Tue, Feb 21, 2023 at 11:22:29AM -0500, Tom Rini wrote: > From: Pali Rohár > > Now that the Dockerfile creates images which have the binaries we > require included, have CI make symlinks for them and update the existing > script to support this. > > Signed-off-by: Tom

Re: [PATCH] CI: Update test/nokia_rx51_test.sh to use prebuilt images

2023-02-25 Thread Tom Rini
On Sat, Feb 25, 2023 at 07:35:28PM +0100, Pali Rohár wrote: > On Saturday 25 February 2023 13:23:33 Tom Rini wrote: > > On Tue, Feb 21, 2023 at 11:22:29AM -0500, Tom Rini wrote: > > > > > From: Pali Rohár > > > > > > Now that the Dockerfile

Re: [PATCH] kconfig: Proposed language extension for multiple builds

2023-02-26 Thread Tom Rini
On Sun, Feb 26, 2023 at 11:32:03PM +0900, Masahiro Yamada wrote: > On Sun, Feb 26, 2023 at 11:04 PM Simon Glass wrote: > > > > Hi Masahiro, > > > > On Sat, 25 Feb 2023 at 20:31, Masahiro Yamada wrote: > > > > > > On Sat, Feb 25, 2023 at 11:38 AM Simon Glass wrote: > > > > > > > > +Masahiro Yamad

Re: [PATCH v3 18/19] test/py: android: extend abootimg test

2023-02-27 Thread Tom Rini
On Mon, Feb 27, 2023 at 03:15:31PM +0100, Safae Ouajih wrote: > > On 07/02/2023 20:02, Tom Rini wrote: > > On Mon, Feb 06, 2023 at 12:50:20AM +0100, Safae Ouajih wrote: > > > > > test_abootimg is extended to include the testing of boot images > > &g

Re: Pull request for u-boot-nand-20230227

2023-02-27 Thread Tom Rini
On Mon, Feb 27, 2023 at 05:52:29PM +0100, Dario Binacchi wrote: > Hi Tom, > > The following changes since commit 0024e7f72b689f8c2df731a69e20f47b6f8dc5a7: > > Merge branch 'master' of > https://source.denx.de/u-boot/custodians/u-boot-tegra (2023-02-23 > 17:40:18 -0500) > > are available in th

Re: [PATCH] kconfig: Proposed language extension for multiple builds

2023-02-27 Thread Tom Rini
On Sun, Feb 26, 2023 at 12:23:00PM -0700, Simon Glass wrote: > Hi Masahiro, > > On Sun, 26 Feb 2023 at 10:36, Masahiro Yamada wrote: > > > > On Sun, Feb 26, 2023 at 11:44 PM Tom Rini wrote: > > > > > > On Sun, Feb 26, 2023 at 11:32:03PM +0900, Masahiro Yam

Re: [PATCH] kconfig: Proposed language extension for multiple builds

2023-02-27 Thread Tom Rini
> > > > > On Mon, Feb 27, 2023 at 4:23 AM Simon Glass wrote: > > > > > > > > Hi Masahiro, > > > > > > > > On Sun, 26 Feb 2023 at 10:36, Masahiro Yamada > > > > wrote: > > > > > > > > > > On Sun,

[PATCH 2/7] dlmalloc: Fix a warning with clang-15

2023-02-27 Thread Tom Rini
With clang-15 we now will get warnings such as: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] And it is easy enough to address this warning here, as we aren't concerned with re-syncing with an upstream. Signed-off-by: Tom

[PATCH 1/7] global: Disable deprecated-non-prototype warning with clang

2023-02-27 Thread Tom Rini
projects, and would like to re-sync with in the future. While the biggest example of this is the zlib code, there are other places as well. For now, we will silence this warning. Signed-off-by: Tom Rini --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index

[PATCH 4/7] zlib: trees.c: Fix a warning with clang-15

2023-02-27 Thread Tom Rini
ation. Signed-off-by: Tom Rini --- lib/zlib/trees.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/zlib/trees.c b/lib/zlib/trees.c index 970bc5dbc64e..e040617686a1 100644 --- a/lib/zlib/trees.c +++ b/lib/zlib/trees.c @@ -237,7 +237,7 @@ local void send_bits(s, value, l

[PATCH 3/7] libavb: Fix a warning with clang-15

2023-02-27 Thread Tom Rini
With clang-15 we now will get warnings such as: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes] And it is easy enough to address this warning here, as we aren't concerned with re-syncing with an upstream. Signed-off-by: Tom

[PATCH 5/7] imx8image: Remove unused cont_img_count variable

2023-02-27 Thread Tom Rini
With clang-15, it is now reported that cont_img_count is unused. This is true as the code will increment / reset this counter, but never functionally use it. Remove it. Signed-off-by: Tom Rini --- Cc: Peng Fan Cc: Mikhail Ilin Cc: Stefano Babic Cc: Fabio Estevam Cc: "NXP i.MX U-Boot

[PATCH 7/7] CI: Move to clang-15

2023-02-27 Thread Tom Rini
As this is now the stable release, move to using that now for our tests. Signed-off-by: Tom Rini --- .azure-pipelines.yml| 6 +++--- .gitlab-ci.yml | 4 ++-- tools/docker/Dockerfile | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.azure-pipelines.yml b

[PATCH 6/7] proftool: Remove unused variables in make_flame_tree

2023-02-27 Thread Tom Rini
With clang-15 we now get reported that in the make_flame_tree function, neither the missing_count nor depth variables are used, only incremenete/decremented. Remove these. Signed-off-by: Tom Rini --- Cc: Simon Glass --- tools/proftool.c | 15 +-- 1 file changed, 1 insertion(+), 14

[ANN] U-Boot v2023.04-rc3 released

2023-02-27 Thread Tom Rini
Hey all, It's the scheduled day for -rc3, and it's the end of my day, mainly because I got side-tracked. The delta between -rc2 and -rc3 is bigger than I'd have liked, but, I can accept it. I will be more stringent moving forward, and at this point the only "big" changes I'm expecting are the fixe

Re: [PATCH] CI: gitlab: Collect pytest artifacts

2023-02-27 Thread Tom Rini
nd debugging. > > Suggested-by: Simon Glass > Signed-off-by: Marek Vasut > --- > Cc: Simon Glass > Cc: Tom Rini > --- > .gitlab-ci.yml | 14 ++ > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml &g

Re: [PATCH v5 0/6] FWU: Handle meta-data in common code

2023-02-27 Thread Tom Rini
On Mon, Feb 27, 2023 at 06:51:35PM -0600, jassisinghb...@gmail.com wrote: > From: Jassi Brar > > The patchset reduces ~400 lines of code, while keeping the functionality same > and making > meta-data operations much faster (by using cached structures). > > Issue: > meta-data copies (primary a

Re: [PATCH v5 0/6] FWU: Handle meta-data in common code

2023-02-27 Thread Tom Rini
On Mon, Feb 27, 2023 at 07:00:10PM -0600, Jassi Brar wrote: > On Mon, 27 Feb 2023 at 18:58, Tom Rini wrote: > > > > On Mon, Feb 27, 2023 at 06:51:35PM -0600, jassisinghb...@gmail.com wrote: > > > > > From: Jassi Brar > > > > > > The patchs

Re: [PATCH 2/7] dlmalloc: Fix a warning with clang-15

2023-02-27 Thread Tom Rini
On Mon, Feb 27, 2023 at 05:35:30PM -0700, Simon Glass wrote: > Hi Tom, > > On Mon, 27 Feb 2023 at 15:08, Tom Rini wrote: > > > > With clang-15 we now will get warnings such as: > > > > warning: a function declaration without a prototype is deprecated in all >

Re: [PATCH 1/2] MAINTAINERS: Add entry for SPI NAND framework and drivers

2023-02-28 Thread Tom Rini
zIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=4HDR%2BwouzdpqPFWPdvnZWRXSyjc94T%2F0pPHaXTYNrsM%3D&reserved=0 > >> > >> Signed-off-by: Frieder Schrempf > >> Cc: Jagan Teki > >> Cc: Dario Binacchi > >> Cc: Michael Nazzareno Trimarch

Re: [PATCH 0/5] Convert the LS208xA RDB/QDS boards to DM_SERIAL

2023-02-28 Thread Tom Rini
On Tue, Feb 28, 2023 at 06:32:07PM +0200, Ioana Ciornei wrote: > This patch set converts the LS208xA based boards to DM_SERIAL. > > Since we don't want to introduce even more differences between the > U-Boot's and Linux's device trees the first 4 patches make the necessary > updates so that the se

Re: [PATCH 0/5] Convert the LS208xA RDB/QDS boards to DM_SERIAL

2023-02-28 Thread Tom Rini
On Tue, Feb 28, 2023 at 06:47:04PM +0200, Ioana Ciornei wrote: > On Tue, Feb 28, 2023 at 11:40:15AM -0500, Tom Rini wrote: > > On Tue, Feb 28, 2023 at 06:32:07PM +0200, Ioana Ciornei wrote: > > > This patch set converts the LS208xA based boards to DM_SERIAL. > > > &

Re: [PATCH] rpi: Use OF_BOARD rather than OF_EMBED

2023-02-28 Thread Tom Rini
On Tue, Feb 28, 2023 at 03:56:05PM +, Peter Robinson wrote: > The use of OF_EMBED isn't recommended for standard use and the OF_BOARD > is actually a better fit for the Raspberry Pi as the prior firmware > provides a DT that can be used by U-Boot and the subsequent OS too, but > it still allow

Re: Pull request for u-boot-nand-20230227

2023-02-28 Thread Tom Rini
On Mon, Feb 27, 2023 at 05:52:29PM +0100, Dario Binacchi wrote: > Hi Tom, > > The following changes since commit 0024e7f72b689f8c2df731a69e20f47b6f8dc5a7: > > Merge branch 'master' of > https://source.denx.de/u-boot/custodians/u-boot-tegra (2023-02-23 > 17:40:18 -0500) > > are available in th

Re: Pull request for tpm-next-28022023

2023-02-28 Thread Tom Rini
On Tue, Feb 28, 2023 at 11:28:24AM +0200, Ilias Apalodimas wrote: > Hi Tom, > > The following changes since commit 5b197eee334bdf75cc9e9148161299679a5251ea: > > Merge tag 'v2023.04-rc3' into next (2023-02-27 17:28:21 -0500) > > are available in the Git repository at: > > https://source.den

[PATCH 2/2] Azure CI: Be explicit about pytest cache directory

2023-02-28 Thread Tom Rini
The default pytest cache directory is in a read-only directory in Azure, which results in a warning on the build page. Use the pytest command line option to set the cache dir to somewhere writable. Signed-off-by: Tom Rini --- .azure-pipelines.yml | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 1/2] Azure CI: Save pytest output automatically

2023-02-28 Thread Tom Rini
Enable use of the python-azurepipelines package which provides automatic formatting and uploading of the pytest output. Signed-off-by: Tom Rini --- .azure-pipelines.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.azure-pipelines.yml b/.azure-pipelines.yml index

Re: [PULL] Please pull u-boot-coldfire/master

2023-02-28 Thread Tom Rini
On Tue, Feb 28, 2023 at 09:21:23PM +0100, Angelo Dureghello wrote: > The following changes since commit e8c80ac0f7a13bf0fc016ce324b870c0cff7a2b8: > > Prepare v2023.04-rc3 (2023-02-27 17:18:36 -0500) > > are available in the Git repository at: > > git://git.denx.de/u-boot-coldfire.git master

Re: [PULL] Please pull u-boot-coldfire/master

2023-02-28 Thread Tom Rini
On Tue, Feb 28, 2023 at 10:01:46PM +0100, Angelo Dureghello wrote: > Hi Tom, > > On 28/02/23 9:34 PM, Tom Rini wrote: > > On Tue, Feb 28, 2023 at 09:21:23PM +0100, Angelo Dureghello wrote: > > > > > The following changes since commit > > > e

Re: [PULL] u-boot-at91-fixes-2023.04-a

2023-03-01 Thread Tom Rini
On Wed, Mar 01, 2023 at 11:26:52AM +0200, Eugen Hristev wrote: > Hello Tom, > > Please pull tag u-boot-at91-fixes-2023.04-a , the first set of at91 > fixes for the cycle 2023.04 . > > This fixes set include one clock index fix for sama7g5 and two board > configuration alignments for pm9g45. > >

Re: Pull request: u-boot-rockchip-20230228

2023-03-01 Thread Tom Rini
On Wed, Mar 01, 2023 at 08:23:50AM +0800, Kever Yang wrote: > Hi Tom, > > Please pull the updates for rockchip platform: > - Add support for rk3588 soc; > - Add rk3588 Edgeble Neu6 board and Radxa ROCK5B board; > - Add rk3308 Radxa ROCK Pi S board; > - Add rk3568 Radxa ROCK 3 board, > - Add rk356

Re: [PATCH v2 02/26] cmd: nvedit: check for ENV_SUPPORT

2023-03-01 Thread Tom Rini
On Fri, Feb 24, 2023 at 10:10:23AM -0800, Troy Kisky wrote: > Avoid error messages when SPL,TPL,VPL build don't > have the environment options of the main build. > This is needed when defined(CONFIG_ENV_IS_IN_xxx) is changed > to CONFIG_IS_ENABLED(ENV_IS_IN_xxx). > > Signed-off-by: Troy Kisky > R

Re: [PATCH v2 03/26] lib: crc32: prepare for CONFIG_IS_ENABLED changes

2023-03-01 Thread Tom Rini
On Fri, Feb 24, 2023 at 10:10:24AM -0800, Troy Kisky wrote: > We need to include in order to include > files that use CONFIG_IS_ENABLED. TO prepare for that > be more direct with using defined(USE_HOSTCC). > > Signed-off-by: Troy Kisky > Reviewed-by: Simon Glass > --- > > Changes in v2: > - de

Re: [PATCH v2 08/26] tools: prevent CONFIG_IS_ENABLED errors by including linux/kconfig.h

2023-03-01 Thread Tom Rini
On Fri, Feb 24, 2023 at 10:10:29AM -0800, Troy Kisky wrote: > We need to include in order to include > files that use CONFIG_IS_ENABLED. > > Signed-off-by: Troy Kisky > Reviewed-by: Simon Glass Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 09/26] tools: Makefile: prepare for CONFIG_IS_ENABLED changes by adding CONFIG_TOOLS_xxx

2023-03-01 Thread Tom Rini
On Fri, Feb 24, 2023 at 10:10:30AM -0800, Troy Kisky wrote: > CONFIG_IS_ENABLED(FIT_SIGNATURE) will check for > CONFIG_TOOLS_FIT_SIGNATURE. So define it now in preparation. > > Signed-off-by: Troy Kisky > Reviewed-by: Simon Glass > --- > > (no changes since v1) > > tools/Makefile | 2 ++ > 1

Re: [PATCH v2 14/26] puma-rk3399: use IS_ENABLED_NOCHECK to avoid CI test failure for ENV_IS_NOWHERE

2023-03-01 Thread Tom Rini
On Fri, Feb 24, 2023 at 10:10:35AM -0800, Troy Kisky wrote: > When usage_of_is_enabled_check.sh is added, this will show a false > positive for IS_ENABLED(CONFIG_ENV_IS_NOWHERE). > Use IS_ENABLED_NOCHECK to avoid check and error on SPL builds. > > Signed-off-by: Troy Kisky > --- > > Changes in

Re: [PATCH v2 5/6] Kconfig: j721e: Change K3_MCU_SCRATCHPAD_BASE to non firewalled region

2023-03-01 Thread Tom Rini
Enable support for building > multiple dtbs into FIT") > > Signed-off-by: Manorit Chawdhry > [n-fran...@ti.com: SRAM allocation addressing diagram] > Signed-off-by: Neha Francis Reviewed-by: Tom Rini But can we please get that map information in something under doc/board/ti/ as a follow-up? -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 1/1] editorconfig: introduce .editorconfig

2023-03-01 Thread Tom Rini
On Wed, Mar 01, 2023 at 01:43:38PM +0300, Dzmitry Sankouski wrote: > Current process of sending patches includes running checkpatch.pl > script for each patch, and fixing found style problems. > EditorConfig may help to prevent some style related problems > (like spaces vs tab indentation) on the f

Re: [PATCH] image: Fix potentially uninitialized data variable

2023-03-01 Thread Tom Rini
; this warning > u32 *data; > ^ > = NULL > " > > Signed-off-by: Marek Vasut Reviewed-by: Tom Rini And can you please do a follow-up that adds sandbox64 + clang, after the sandbox + clang test in GitLab/Azure? -- Tom signature.asc Description: PGP signature

Re: Re-writing SMC91111 Ethernet driver

2023-03-01 Thread Tom Rini
On Sat, Feb 18, 2023 at 11:30:28PM +, Robert Catherall wrote: > Hi, > > The SMC9 Ethernet driver was removed in commit > > ecf1d2741d95f5f84e31dc1d0bef149d8ff1f0a3 > > because it had not been converted to DM_ETH. > > I would be interested in doing the conversion and re-instating the dri

Re: Please pull u-boot-marvell/next

2023-03-01 Thread Tom Rini
On Wed, Mar 01, 2023 at 04:49:01PM +0100, Stefan Roese wrote: > Hi Tom, > > please pull the following Marvell MVEBU related patches into next: > Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 1/1] editorconfig: introduce .editorconfig

2023-03-02 Thread Tom Rini
On Thu, Mar 02, 2023 at 06:00:43PM +0300, Dzmitry Sankouski wrote: > ср, 1 мар. 2023 г. в 18:58, Tom Rini : > > > > On Wed, Mar 01, 2023 at 01:43:38PM +0300, Dzmitry Sankouski wrote: > > > Current process of sending patches includes running checkpatch.pl > > >

Re: [PATCH v2 6/8] boot: Create a common BOOT_DEFAULTS for distro and bootstd

2023-03-02 Thread Tom Rini
On Wed, Mar 01, 2023 at 08:39:27PM -0700, Simon Glass wrote: > These two features use a lot of common options. Move them into a common > CONFIG to reduce duplication. > > Resync defconfigs since this makes a lot of changes. > > Signed-off-by: Simon Glass [snip] > diff --git a/boot/Kconfig b/boo

Re: [PATCH v2 2/8] rockchip: Disable DISTRO_DEFAULTS for rk3399 boards

2023-03-02 Thread Tom Rini
On Wed, Mar 01, 2023 at 08:39:23PM -0700, Simon Glass wrote: > These board have moved to standard boot but the old 'distro_bootcmd' > command is still active. Disable DISTRO_DEFAULTS to fix this. > > Signed-off-by: Simon Glass > Tested-by: Vagrant Cascadian > --- > > (no changes since v1) > >

Re: Please pull u-boot-dm

2023-03-02 Thread Tom Rini
On Wed, Mar 01, 2023 at 01:10:57PM -0700, Simon Glass wrote: > Hi Tom, > > https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/15430 > > The following changes since commit b0eda49bc9b00503366f2ec431be0178caf9e9b5: > > Merge tag 'u-boot-at91-fixes-2023.04-a' of > https://source.denx

Re: No such file or directory: lxdialog/dialog.h

2023-03-02 Thread Tom Rini
On Wed, Mar 01, 2023 at 08:19:24PM -0500, Nick Carraway wrote: > Hello! > > Apologies to bother y'all with this. I am at wit's end. I think this > is an issue that I've encountered before and figured out how to solve, > but I can't for the life of me figure out what to do this time around. > > W

Re: [PATCH v5 18/44] env: Avoid checking ENV_IS_IN when env disabled

2023-03-02 Thread Tom Rini
On Wed, Feb 22, 2023 at 09:33:59AM -0700, Simon Glass wrote: > This check is not needed when the environment is not enabled, e.g. in > SPL. Add a condition to handle this. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > cmd/nvedit.c | 2 ++ > 1 file changed, 2 insertions(+)

Re: [PATCH v2 09/26] tools: Makefile: prepare for CONFIG_IS_ENABLED changes by adding CONFIG_TOOLS_xxx

2023-03-02 Thread Tom Rini
On Thu, Mar 02, 2023 at 10:21:29AM -0800, Troy Kisky wrote: > On Wed, Mar 1, 2023 at 7:33 AM Tom Rini wrote: > > > On Fri, Feb 24, 2023 at 10:10:30AM -0800, Troy Kisky wrote: > > > CONFIG_IS_ENABLED(FIT_SIGNATURE) will check for > > > CONFIG_TOOLS_FIT_SIGNATURE. S

Re: [PATCH v5 44/44] command: Don't allow commands in SPL

2023-03-02 Thread Tom Rini
On Wed, Feb 22, 2023 at 09:34:25AM -0700, Simon Glass wrote: > At present we compile commands into U-Boot SPL even though they cannot > be used. This wastes space. Adjust the condition to avoid this. > > Signed-off-by: Simon Glass > --- > > Changes in v5: > - Drop FSL_ISBC_KEY_EXT patch as it c

Re: [PATCH v5 21/44] x86: Use string functions for all 32-bit builds

2023-03-02 Thread Tom Rini
On Wed, Feb 22, 2023 at 09:34:02AM -0700, Simon Glass wrote: > At present these are not included in SPL. They do add to code size but > are a bit faster, so adjust the setting to add them. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > arch/x86/include/asm/string.h | 2 +-

Re: [PATCH v5 38/44] freescale: Fix odd use of ESDHCI_QUIRK_BROKEN_TIMEOUT_VALUE

2023-03-02 Thread Tom Rini
On Wed, Feb 22, 2023 at 09:34:19AM -0700, Simon Glass wrote: > This is not a CONFIG option so we should not be using IS_ENABLED() on it, > particularly not when it is not defined to anything, so shows up as > calling IS_ENABLED() with no arguments. > > Just check it normally. > > For fsl_esdhc.c

Re: [PATCH v5 32/44] x86: Fix up use of X86_32BIT_INIT and X86_64 options

2023-03-03 Thread Tom Rini
On Wed, Feb 22, 2023 at 09:34:13AM -0700, Simon Glass wrote: > Drop the invalid SPL_ in a CONFIG_IS_ENABLED() usage. Use the correct > X86_64 option in msr.h since SPL may be 32-bit when U-Bout proper is > not. > > Signed-off-by: Simon Glass > --- > > (no changes since v4) > > Changes in v4: >

Re: [PATCH v3 3/4] Kconfig: j721e: Change K3_MCU_SCRATCHPAD_BASE to non firewalled region

2023-03-03 Thread Tom Rini
Enable support for building > multiple dtbs into FIT") > > Signed-off-by: Manorit Chawdhry > [n-fran...@ti.com: SRAM allocation addressing diagram] > Signed-off-by: Neha Francis > Reviewed-by: Tom Rini > --- > arch/arm/mach-k3/Kconfig | 3 ++- > configs/

Re: [PULL] u-boot-usb/next

2023-03-03 Thread Tom Rini
On Fri, Mar 03, 2023 at 01:05:10AM +0100, Marek Vasut wrote: > The following changes since commit 49cba67852f1fb5ef481bef3532b2cda96816e45: > > Merge branch 'next' of > https://source.denx.de/u-boot/custodians/u-boot-marvell into next > (2023-03-01 11:00:22 -0500) > > are available in the Git

Re: [PATCH 01/13] common/Kconfig: Reword text for BOARD_TYPES

2023-03-03 Thread Tom Rini
On Wed, Feb 15, 2023 at 10:36:47PM -0500, Tom Rini wrote: > While it is true that for some Samsung platforms, we call > get_board_type() the main usage of this CONFIG switch is to enable > board_types in global data, which is then used by various platforms. > > Signed-o

Re: [PATCH 02/13] arm: mvebu: Add select on ARCH_EARLY_INIT_R if ARM64

2023-03-03 Thread Tom Rini
On Wed, Feb 15, 2023 at 10:36:48PM -0500, Tom Rini wrote: > We need to be calling arch_early_init_r() on 64bit mvebu platforms, so > move this to a select. > > Cc: Stefan Roese > Signed-off-by: Tom Rini > Reviewed-by: Stefan Roese Applied to u-boot/next, thanks! -- T

Re: [PATCH 03/13] arm: zynq: Move to select'ing ARCH_EARLY_INIT_R if we have FPGA

2023-03-03 Thread Tom Rini
On Wed, Feb 15, 2023 at 10:36:49PM -0500, Tom Rini wrote: > The function arch_early_init_r only does anything on these platforms if > we have FPGA (or SPL and SPL_FPGA) enabled, so move the logic to select > based on that. > > Cc: Michal Simek > Signed-off-by: Tom Rini >

Re: [PATCH 04/13] arm: rk3368: Select ARCH_EARLY_INIT_R when used

2023-03-03 Thread Tom Rini
On Wed, Feb 15, 2023 at 10:36:50PM -0500, Tom Rini wrote: > On the lion and evb-px5 platforms, we need this function, so select it. > > Cc: Andy Yan > Cc: Quentin Schulz > Cc: Klaus Goger > Signed-off-by: Tom Rini > Reviewed-by: Simon Glass > Reviewed-by: Quentin Sc

  1   2   3   4   5   6   7   8   9   10   >