[U-Boot] [PATCH] Fix omap5 hyp mode for second cpu

2013-02-19 Thread Vincent Stehlé
Make it work on PandaBoard 5 with 5432 ES2 and Linux. Signed-off-by: Vincent Stehlé v-ste...@ti.com --- Hi, Here are some necessary adaptations for OMAP5 ES2, as magic value has changed. In the mean time, we make the secondary cpu routine a bit closer to what romcode does. Best regards, V

Re: [U-Boot] [PATCH 0/2] ARM: mmu: Set domain permissions to client access - build warnings!

2013-03-04 Thread Vincent Stehlé
On 03/02/2013 11:46 PM, Albert ARIBAUD wrote: (..) Basically, this means we need Vincent's series to be applied first, then we can apply Sricharan's. Hi, I think this is too much trouble for a one liner. Please feel free to squash. Best regards, V.

[U-Boot] [PATCH] README: align default commands with code

2013-06-20 Thread Vincent Stehlé
Align the list of default commands mentioned in the configuration options paragraph of the README with the actual definitions found in include/config_cmd_default.h Signed-off-by: Vincent Stehlé vincent.ste...@freescale.com --- README | 14 -- 1 file changed, 8 insertions(+), 6

[U-Boot] [PATCH] armv7: do not relocate _start twice

2013-03-15 Thread Vincent Stehlé
The _start symbol is already relocated, so do not add the relocation the second time in c_runtime_cpu_setup. This fixes e.g. the abort exception handling path, which ended in double fault due to bad address in VBAR. Signed-off-by: Vincent Stehlé v-ste...@ti.com Reported-by: Lubomir Popov lpo

[U-Boot] Patches to add some more omap24xx_i2c/twl6035 error handling

2012-12-03 Thread Vincent Stehlé
Hi, I am encountering the following i2c error on OMAP5 with mainline u-boot: OMAP5430 EVM # mmc rescan timed out in wait_for_bb: I2C_STAT=1410 It seems the first call to i2c_write for bus I2C1 will fail and will leave the bus with SCL stuck low, preventing further i2c operations. While

[U-Boot] [PATCH 1/2] omap24xx_i2c: Handle wait_for_bb error

2012-12-03 Thread Vincent Stehlé
We add a return code to wait_for_bb() to be able to report errors to the callers properly. We in turn handle this new error code in i2c_read, i2c_write and i2c_probe. Signed-off-by: Vincent Stehlé v-ste...@ti.com --- drivers/i2c/omap24xx_i2c.c | 20 ++-- 1 file changed, 14

[U-Boot] [PATCH 2/2] power: twl6035: complain on LDO9 error

2012-12-03 Thread Vincent Stehlé
We handle i2c_write return code and complain in case of error. We propagate the error, too, to allow better handling at the upper level in the future. Signed-off-by: Vincent Stehlé v-ste...@ti.com --- drivers/power/twl6035.c | 17 + include/twl6035.h |2 +- 2 files

[U-Boot] [PATCH] omap24xx_i2c: Handle OMAP5 like OMAP2,3,4

2012-12-03 Thread Vincent Stehlé
OMAP5 has 8b i2c data register field, like OMAP2, 3 and 4. Handle in the same way. This fixes the following error on OMAP5: OMAP5430 EVM # mmc rescan timed out in wait_for_bb: I2C_STAT=1410 twl6035: could not turn on LDO9. Signed-off-by: Vincent Stehlé v-ste...@ti.com --- drivers/i2c

[U-Boot] [PATCH v2] ARM: OMAP5: redefine arm_setup_identity_mapping

2012-12-11 Thread Vincent Stehlé
to avoid. Signed-off-by: Vincent Stehlé v-ste...@ti.com Cc: Tom Rini tr...@ti.com --- Changes for v2: - Fix missing page_table argument - Add extern definition to fix compilation warning arch/arm/cpu/armv7/omap5/Makefile |1 + arch/arm/cpu/armv7/omap5/cache-cp15.c | 46

Re: [U-Boot] [PATCH v2] ARM: OMAP5: redefine arm_setup_identity_mapping

2012-12-11 Thread Vincent Stehlé
Tom Rini: Lets put the extern in arch/arm/include/asm/cache.h and make both files #include asm/cache.h. Sure, here is an updated patches pair: [PATCH v3 1/2] ARM: cache: introduce weak arm_setup_identity_mapping [PATCH v3 2/2] ARM: OMAP5: redefine arm_setup_identity_mapping Thank you for

[U-Boot] [PATCH v3 1/2] ARM: cache: introduce weak arm_setup_identity_mapping

2012-12-11 Thread Vincent Stehlé
want to avoid. Signed-off-by: Vincent Stehlé v-ste...@ti.com Cc: Tom Rini tr...@ti.com --- Changes for v3: - Add definition of __arm_setup_identity_mapping() into asm/cache.h - Fix comments style arch/arm/include/asm/cache.h |1 + arch/arm/lib/cache-cp15.c| 22

[U-Boot] [PATCH v3 2/2] ARM: OMAP5: redefine arm_setup_identity_mapping

2012-12-11 Thread Vincent Stehlé
to avoid. Signed-off-by: Vincent Stehlé v-ste...@ti.com Cc: Tom Rini tr...@ti.com --- Changes for v3: - Use definition of __arm_setup_identity_mapping() from asm/cache.h Changes for v2: - Fix missing page_table argument - Add extern definition to fix compilation warning arch/arm/cpu/armv7

[U-Boot] Update OMAP5 unmap first page patch series

2013-01-07 Thread Vincent Stehlé
Hi, Here is a proposed updated patch series to unmap page 0 on OMAP5, rebased on denx/master: [PATCH v4 1/3] ARM: cache: declare set_section_dcache [PATCH v4 2/3] ARM: cache: introduce weak arm_setup_identity_mapping [PATCH v4 3/3] ARM: OMAP5: redefine arm_setup_identity_mapping Necessary

[U-Boot] [PATCH v4 1/3] ARM: cache: declare set_section_dcache

2013-01-07 Thread Vincent Stehlé
We declare the set_section_dcache function globally in the cache header, for later use by e.g. machine specific code. Signed-off-by: Vincent Stehlé v-ste...@ti.com Cc: Tom Rini tr...@ti.com --- arch/arm/include/asm/cache.h |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/include

[U-Boot] [PATCH v4 2/3] ARM: cache: introduce weak arm_setup_identity_mapping

2013-01-07 Thread Vincent Stehlé
want to avoid. Signed-off-by: Vincent Stehlé v-ste...@ti.com Cc: Tom Rini tr...@ti.com --- Changes for v4; - Use set_section_dcache() function - Remove page_table argument Changes for v3: - Add definition of __arm_setup_identity_mapping() into asm/cache.h - Fix comments style arch/arm

[U-Boot] [PATCH v4 3/3] ARM: OMAP5: redefine arm_setup_identity_mapping

2013-01-07 Thread Vincent Stehlé
to avoid. Signed-off-by: Vincent Stehlé v-ste...@ti.com Cc: Tom Rini tr...@ti.com --- Changes for v4: - Protect functions according to cache config - Remove page_table argument - Declare global data ptr and use it to retrieve page_table Changes for v3: - Use definition

Re: [U-Boot] [PATCH v4 3/3] ARM: OMAP5: redefine arm_setup_identity_mapping

2013-01-08 Thread Vincent Stehlé
-by: Vincent Stehlé v-ste...@ti.com Best regards, V. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [RFC, PATCH] omap: Invalidate first page to avoid speculation

2012-11-16 Thread Vincent Stehlé
to solve this? Best regards, V. Signed-off-by: Vincent Stehlé v-ste...@ti.com --- arch/arm/lib/cache-cp15.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/arch/arm/lib/cache-cp15.c b/arch/arm/lib/cache-cp15.c index 939de10..57e1974 100644 --- a/arch/arm/lib/cache

Re: [U-Boot] [RFC, PATCH v2] omap: Invalidate first page to avoid speculation

2012-11-19 Thread Vincent Stehlé
Albert Aribaud: To make this affect only some CPUs or even boards, you can define and use a weak function which would handle filling the page-table; the weak, default, function would fill table[0] like others, while OMAP5 would have a strong version which would clear table[0]. Hi Albert,

[U-Boot] [PATCH 1/2] ARM: cache: introduce weak arm_setup_identity_mapping

2012-11-19 Thread Vincent Stehlé
want to avoid. Signed-off-by: Vincent Stehlé v-ste...@ti.com --- arch/arm/lib/cache-cp15.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/arch/arm/lib/cache-cp15.c b/arch/arm/lib/cache-cp15.c index 939de10..886fe5c 100644 --- a/arch/arm/lib/cache-cp15.c

[U-Boot] [PATCH 2/2] ARM: OMAP5: redefine arm_setup_identity_mapping

2012-11-19 Thread Vincent Stehlé
to avoid. Signed-off-by: Vincent Stehlé v-ste...@ti.com --- arch/arm/cpu/armv7/omap5/Makefile |1 + arch/arm/cpu/armv7/omap5/cache-cp15.c | 40 + 2 files changed, 41 insertions(+) create mode 100644 arch/arm/cpu/armv7/omap5/cache-cp15.c diff --git a/arch/arm

[U-Boot] [RFC, PATCH v3] omap: Invalidate first page to avoid speculation

2012-11-20 Thread Vincent Stehlé
Tom Rini: Aside from that (and the comment to 1/2) I think we're good here, including the naming of the function. Thanks! Hi Tom, Thank you very much for your review. Here is v3 of the patch series with reworks for __weak and comments style: [PATCH 1/2] ARM: cache: introduce weak

[U-Boot] [PATCH 1/2] ARM: cache: introduce weak arm_setup_identity_mapping

2012-11-20 Thread Vincent Stehlé
want to avoid. Signed-off-by: Vincent Stehlé v-ste...@ti.com --- arch/arm/lib/cache-cp15.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/arch/arm/lib/cache-cp15.c b/arch/arm/lib/cache-cp15.c index 939de10..0b87d93 100644 --- a/arch/arm/lib/cache-cp15.c

[U-Boot] [PATCH 2/2] ARM: OMAP5: redefine arm_setup_identity_mapping

2012-11-20 Thread Vincent Stehlé
to avoid. Signed-off-by: Vincent Stehlé v-ste...@ti.com --- arch/arm/cpu/armv7/omap5/Makefile |1 + arch/arm/cpu/armv7/omap5/cache-cp15.c | 44 + 2 files changed, 45 insertions(+) create mode 100644 arch/arm/cpu/armv7/omap5/cache-cp15.c diff --git a/arch/arm

[U-Boot] [PATCH] .gitignore: ignore generated u-boot.lst

2012-11-21 Thread Vincent Stehlé
Signed-off-by: Vincent Stehlé v-ste...@ti.com --- .gitignore |1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 1ac43f2..3f728ca 100644 --- a/.gitignore +++ b/.gitignore @@ -55,6 +55,7 @@ /reloc_off /include/generated/ +/include/u-boot.lst asm-offsets.s

Re: [U-Boot] [PATCH] .gitignore: ignore generated u-boot.lst

2012-11-22 Thread Vincent Stehlé
On 11/21/2012 09:00 PM, Luka Perkov wrote: You should have also removed /u-boot.lst: Hi Luka, I think it is already ignored in denx/master (commit 178d0cc1a4c73c3341afbeb2a93b172de8c96bd1). Best regards, V. ___ U-Boot mailing list

[U-Boot] [PATCH] .gitignore: update path for generated u-boot.lst

2012-11-22 Thread Vincent Stehlé
Luka: (/u-boot.lst) It is ignored, but it does not need to be. The file is not in that location. Ah! Thanks for the clarification; here is an updated patch. Best regards, V. ---8--- Signed-off-by: Vincent Stehlé v-ste...@ti.com --- .gitignore |2 +- 1 file changed, 1 insertion(+), 1

Re: [U-Boot] Booting Wandboard through USB

2015-05-30 Thread Vincent Stehlé
On 05/30/2015 06:49 PM, Tom Rini wrote: .. The second would be trying to fake things such that for imx_usb_loader you can pass both SPL and u-boot.img, and SPL is run, inits memory and just exists and then u-boot.img is loaded and run, similar to how with the non-SPL case you can use the

[U-Boot] Booting Wandboard through USB

2015-05-30 Thread Vincent Stehlé
Hi, Is it still possible to boot u-boot on Wandboard through USB, please? U-boot has switched to SPL for Wandboard recently[1] and I wonder if it did not lose the possibility to boot the Wandboard through USB in the mean time. Granted, I can generate an u-boot-with-spl.imx suitable for boot

[U-Boot] [PATCH] mx6: repair sl and slx load addresses

2015-05-28 Thread Vincent Stehlé
. We allow to override LOADADDR from mx6_common.h and restore previous LOADADDR and SYS_TEXT_BASE for SL and SoloX based boards. This repairs the boot for i.MX6 SoloX Sabre SD, and should also repair SL EVK and Warp board. Signed-off-by: Vincent Stehlé vincent.ste...@laposte.net Cc: Peter Robinson

Re: [U-Boot] [PATCH v3] mx6_common: Fix LOADADDR and SYS_TEXT_BASE for MX6SL and MX6SX

2015-05-28 Thread Vincent Stehlé
SoloX Sabre SD. Tested-by: Vincent Stehlé vincent.ste...@laposte.net Best regards, V. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] mx6: invalidate D-cache only when booting from USB

2015-05-23 Thread Vincent Stehlé
with CONFIG_SKIP_LOWLEVEL_INIT defined, and is booted from another u-boot, which booted from SD card, for example. Signed-off-by: Vincent Stehlé vincent.ste...@freescale.com Cc: Stefano Babic sba...@denx.de Cc: Fabio Estevam fabio.este...@freescale.com Cc: Frank Li frank...@freescale.com Cc: Nitin Garg nitin.g

Re: [U-Boot] [PATCH] mx6: invalidate D-cache only when booting from USB

2015-05-23 Thread Vincent Stehlé
On 05/22/2015 05:15 PM, Li Frank-B20596 wrote: .. How about second uboot save in usb mass storage device? Hi Frank, I cannot test but I guess this will behave the same as without the patch, which means that it will probably not boot. Granted, the detection method in is_boot_from_usb() is an

[U-Boot] [PATCH] tools/proftool: fix use-after-free

2015-10-07 Thread Vincent Stehlé
The read_trace_config() can dereference the line pointer after freeing it on its error path. Avoid that. This was found by Coverity Scan. Signed-off-by: Vincent Stehlé <vincent.ste...@freescale.com> Cc: Simon Glass <s...@chromium.org> --- tools/proftool.c | 5 +++-- 1 file changed,

Re: [U-Boot] [PATCH] tools/proftool: fix use-after-free

2015-10-07 Thread Vincent Stehlé
On 10/07/2015 04:19 PM, Tom Rini wrote: .. > Were you in the Coverity talk too? :) Hi Tom, No, I was not following that talk, sorry. .. > free(line); > - return regex_report_error(>regex, err, > "compile", > + err =

[PATCH] efi_loader: check update capsule parameters

2021-06-11 Thread Vincent Stehlé
UpdateCapsule() must return EFI_INVALID_PARAMETER in a number of cases, listed by the UEFI specification and tested by the SCT. Add a common function to do that. This fixes SCT UpdateCapsule_Conf failures. Reviewed-by: Grant Likely Signed-off-by: Vincent Stehlé Cc: Heinrich Schuchardt Cc

Re: [PATCH 1/1] sandbox: fix sandbox_reset()

2021-05-12 Thread Vincent Stehlé
et after 2 second and test will be resumed after reboot.resetting ... Writing sandbox state qemu: uncaught target signal 11 (Segmentation fault) - core dumped With your patch I do not hit this segfault anymore. FWIW, feel free to add (or not): Tested-by: Vincent Stehlé Best regar

[PATCH] efi_loader: check query_variable_info attributes

2021-04-29 Thread Vincent Stehlé
QueryVariableInfo() must return EFI_INVALID_PARAMETER when an invalid combination of attribute bits is supplied. This fixes three SCT QueryVariableInfo_Conf failures. Signed-off-by: Vincent Stehlé Reviewed-by: Grant Likely Cc: Heinrich Schuchardt Cc: Alexander Graf Changes since v1

[PATCH] sandbox: dtsi: add rng

2021-03-10 Thread Vincent Stehlé
following `bootefi' error: Missing RNG device for EFI_RNG_PROTOCOL Signed-off-by: Vincent Stehlé Cc: Simon Glass --- arch/sandbox/dts/sandbox.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/sandbox/dts/sandbox.dtsi b/arch/sandbox/dts/sandbox.dtsi index dc933f3bfc7..43b9342c

[PATCH] virtio: fix off by one device id comparison

2021-02-15 Thread Vincent Stehlé
VIRTIO_ID_MAX_NUM is the largest device ID plus 1. Therefore a device id cannot be greater or equal to VIRTIO_ID_MAX_NUM. Fix the comparison accordingly. Fixes: 8fb49b4c7a82 ("dm: Add a new uclass driver for VirtIO transport devices") Signed-off-by: Vincent Stehlé Cc: Simon Glass Cc

[BUG] USB boot issue on ROCKPro64 with UEFI

2021-09-03 Thread Vincent Stehlé
the patch following this e-mail). I don't know enough about the RK3399 clock tree to fully understand what is going on here, and what would be a proper fix. Hopefully others will be able to continue from there. Best regards, Vincent Stehlé System Architect - Arm Vincent Stehlé (1): clk: rk3399: do n

[PATCH WORKAROUND] clk: rk3399: do not disable the USB2PHY clk

2021-09-03 Thread Vincent Stehlé
. Signed-off-by: Vincent Stehlé --- THIS IS A WORKAROUND PLEASE DO NOT APPLY! drivers/clk/rockchip/clk_rk3399.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/rockchip/clk_rk3399.c b/drivers/clk/rockchip/clk_rk3399.c

Re: [BUG] USB boot issue on ROCKPro64 with UEFI

2021-09-03 Thread Vincent Stehlé
; submission of this patch. Hi Arnaud, You are right, this patch solves the issue I am seeing on the ROCKPro64. Thanks for the pointer. Best regards, Vincent Stehlé System Architect - Arm

Re: [PATCH] efi_loader: Fix loaded image alignment

2021-10-12 Thread Vincent Stehlé
- Pine64 ROCKPro64 with U-Boot "near" v2021.07[1] - Lenovo Leez P710 with U-Boot v2021.07[2] - Compulab IOT-GATE-iMX8 with U-Boot "near" v2021.10-rc3[3] Feel free to add (or not): Tested-by: Vincent Stehlé Best regards, Vincent Stehlé System Architect - Arm [1]: https

[PATCH] qemu: common: Fix build with update capsule

2021-11-24 Thread Vincent Stehlé
c ("Revert "efi_capsule: Move signature from DTB to .rodata"") Signed-off-by: Vincent Stehlé Cc: Simon Glass --- board/emulation/common/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/board/emulation/common/Makefile b/board/emulation/common/Makefile index 7ed447a69dc..

[PATCH 2/2] efi: test/py: authenticate fit capsules

2022-05-31 Thread Vincent Stehlé
CONFIG_EFI_CAPSULE_AUTHENTICATE=y. Signed-off-by: Vincent Stehlé Cc: Heinrich Schuchardt --- lib/efi_loader/efi_firmware.c | 115 +++--- test/py/tests/test_efi_capsule/conftest.py| 21 +++- ...py => test_capsule_firmware_signed_fit.py} | 41 --- ..

[PATCH 1/2] test/py: efi_capsule: repair image authentication test

2022-05-31 Thread Vincent Stehlé
GUID typo introduced by commit 2e9c3c6965ba ("test: capsule: Modify the capsule tests to use GUID values for sandbox"). Signed-off-by: Vincent Stehlé Cc: Heinrich Schuchardt --- test/py/tests/test_efi_capsule/conftest.py | 4 ++-- .../tests/test_efi_capsule/test_capsul

[PATCH 2/2] efi: fix documentation warnings

2022-05-25 Thread Vincent Stehlé
: warning: Function parameter or member 'package_version_name' not described in 'efi_firmware_raw_get_image_info' Signed-off-by: Vincent Stehlé Cc: Heinrich Schuchardt --- lib/efi_loader/efi_firmware.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/efi_loader

[PATCH 1/2] doc/efi: add firmware management protocol to the documentation

2022-05-25 Thread Vincent Stehlé
The firmware management protocol can be used to manage device firmware. U-Boot can be configured to provide an implementation. Document the related functions in the API section. Signed-off-by: Vincent Stehlé Cc: Heinrich Schuchardt --- doc/api/efi.rst | 6 ++ 1 file changed, 6 insertions

[PATCH] efi: test/py: repair authenticated capsules tests

2022-06-27 Thread Vincent Stehlé
al size probing"). Add the same workaround to the UEFI authenticated capsules tests to repair them. This can be tested with sandbox_defconfig, sandbox64_defconfig or sandbox_flattree_defconfig, plus CONFIG_EFI_CAPSULE_AUTHENTICATE=y. Signed-off-by: Vincent Stehlé Cc: Heinrich Schuch

[PATCH v2] efi_selftest: add hii database protocol test cases

2023-01-06 Thread Vincent Stehlé
Add a couple of tests for the cases when the HII database protocol get_package_list_handle() function is called with invalid parameters. Signed-off-by: Vincent Stehlé Cc: Heinrich Schuchardt Cc: Ilias Apalodimas --- Hi, Thanks Heinrich for your review and feedbacks; here is v2 of this patch

[PATCH 0/2] efi: small hii set_keyboard_layout conformance improvement

2023-01-06 Thread Vincent Stehlé
. Vincent Stehlé (2): efi_loader: refine set_keyboard_layout() status efi_selftest: add hii set keyboard layout test case lib/efi_loader/efi_hii.c| 3 +++ lib/efi_selftest/efi_selftest_hii.c | 12 2 files changed, 15 insertions(+) -- 2.39.0

[PATCH 1/2] efi_loader: refine set_keyboard_layout() status

2023-01-06 Thread Vincent Stehlé
As per the EFI specification, the HII database protocol function set_keyboard_layout() must return EFI_INVALID_PARAMETER when it is called with a NULL key_guid argument. Modify the function accordingly to improve conformance. Signed-off-by: Vincent Stehlé Cc: Heinrich Schuchardt Cc: Ilias

[PATCH 2/2] efi_selftest: add hii set keyboard layout test case

2023-01-06 Thread Vincent Stehlé
Add a test for the case when the HII database protocol set_keyboard_layout() function is called with a NULL key_guid argument. Signed-off-by: Vincent Stehlé Cc: Heinrich Schuchardt Cc: Ilias Apalodimas --- lib/efi_selftest/efi_selftest_hii.c | 12 1 file changed, 12 insertions

[PATCH] efi: adjust ebbr to v2.1 in conformance profile

2022-12-16 Thread Vincent Stehlé
The EFI Conformance Profile Table entry for EBBR appears in v2.1.0 of the EBBR specification[1]. Update naming accordingly. While at it, update the EBBR version referenced in the documentation. [1]: https://github.com/ARM-software/ebbr/releases/tag/v2.1.0 Signed-off-by: Vincent Stehlé Cc

[PATCH 0/2] efi: small hii conformance fix

2022-12-14 Thread Vincent Stehlé
Hi, The following couple of patches fixes a small UEFI HII conformance issue and adds a selftest demonstrating the issue. This is sent in this order to avoid breaking `bootefi selftest' in the middle but feel free to apply in any order if preferred. Best regards, Vincent. Vincent Stehlé (2

[PATCH 1/2] efi_loader: fix get_package_list_handle() status

2022-12-14 Thread Vincent Stehlé
When the HII protocol function get_package_list_handle() is called with an invalid package list handle, it returns EFI_NOT_FOUND but this is not in its list of possible status codes as per the EFI specification. Return EFI_INVALID_PARAMETER instead to fix conformance. Signed-off-by: Vincent

[PATCH 2/2] efi_selftest: add hii database protocol test case

2022-12-14 Thread Vincent Stehlé
Add a test for the case when the HII database protocol get_package_list_handle() function is called with an invalid package list handle. Signed-off-by: Vincent Stehlé Cc: Heinrich Schuchardt Cc: Ilias Apalodimas --- lib/efi_selftest/efi_selftest_hii.c | 10 ++ 1 file changed, 10

Re: [PATCH 2/2] efi_selftest: add hii database protocol test case

2023-01-05 Thread Vincent Stehlé
On Thu, Dec 22, 2022 at 10:45:22AM +0100, Heinrich Schuchardt wrote: Hi Heinrich, Happy new year, and thank you for the reviews. More comments below. > On 12/13/22 22:39, Vincent Stehlé wrote: > > Add a test for the case when the HII database protocol > > get_package_list_ha

[PATCH] doc: uefi: fix links

2023-02-20 Thread Vincent Stehlé
Fix a couple of links so that they are rendered correctly with sphinx. Signed-off-by: Vincent Stehlé Cc: Heinrich Schuchardt Cc: Ilias Apalodimas --- doc/develop/uefi/fwu_updates.rst | 3 ++- doc/develop/uefi/uefi.rst| 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff

Re: [BUG] issues with new bootflow, uefi and virtio

2023-04-06 Thread Vincent Stehlé
On Thu, Apr 06, 2023 at 06:38:16AM +1200, Simon Glass wrote: (virtio device number 31 vs. blk index 0) > This is strange. Can you try 'dm uclass' to see the sequence number > for the virtio device? I would expect it to be 0, but I might not > fully understand virtio. Hi Simon, Thank you for

Re: [BUG] issues with new bootflow, uefi and virtio

2023-04-06 Thread Vincent Stehlé
On Thu, Apr 06, 2023 at 10:25:15AM +1000, Mathew McBride wrote: .. > I came across the exact same issue a few days ago. Below is a patch which I > believe fixes the problem, by using the devnum of blk uclass (virtio 0) > instead of the sequence number of the parent udevice (e.g virtio-blk#35). Hi

Re: [BUG] issues with new bootflow, uefi and virtio

2023-04-11 Thread Vincent Stehlé
On Fri, Apr 07, 2023 at 05:31:06PM +1200, Simon Glass wrote: .. > > When combined with the patch from Mathew[1], it does indeed repair the case > > of > > efi boot with two virtio disks, specifically when the first virtio disk is > > the > > one we want to boot from. > > FWIW, the system will

[BUG] issues with new bootflow, uefi and virtio

2023-04-05 Thread Vincent Stehlé
Hi, I am hitting an issue with the new bootflow when booting with UEFI from a virtio device on Qemu Arm. It seems the device number computation in efiload_read_file() does not work in the general virtio case, where it will pick the virtio device number instead of the block device index. On Qemu

[PATCH] trace: use dynamic string buffer in make_flamegraph()

2024-04-02 Thread Vincent Stehlé
, which we reallocate when needed. This fixes the following error: String too short (500 chars) While at it, fix a few typos in strings and comments. Signed-off-by: Vincent Stehlé Cc: Tom Rini Cc: Simon Glass Cc: Michal Simek --- Hi, This can be verified using the `test_trace.py' pytest

[PATCH] Fix references to trace doc

2024-04-11 Thread Vincent Stehlé
The README.trace has been moved and converted to rst in commit dce26c7d56ed ("doc: move README.trace to HTML documentation"); fix all the remaining references to this file. Signed-off-by: Vincent Stehlé Cc: Tom Rini Cc: Simon Glass Cc: Heinrich Schuchardt --- c