Re: [U-Boot] [PATCH] imx: serial: Wait for ongoing transmission to finish before serial reset

2017-10-09 Thread Łukasz Majewski
Hi Simon, Hi Lukasz, On 3 October 2017 at 03:16, Lukasz Majewski wrote: It may happen that the MXC serial IP block is performing some ongoing transmission (started at e.g. board_init()) when the "initr_serial" is called. As a result the serial port IP block is reset, so

Re: [U-Boot] [PATCH v1 2/3] disk: efi: correct the overlap check on GPT header and PTE

2017-10-09 Thread Łukasz Majewski
0a2-b9e5-4433-87c0-68b6b72699c7 type: data guid: b4b84b8a-04e3-4000-0036-aff5c9c495b1 And 0x22 = 34 LBA => offset = 0x4400 is accepted as expected Reviewed-by: Łukasz Majewski <lu...@denx.de> Signed-off-by: Patrick Delaunay <patrick.delau...@st.com> -

Re: [U-Boot] [PATCH] imx: serial: Wait for ongoing transmission to finish before serial reset

2017-10-04 Thread Łukasz Majewski
HI Lothar, Hi, On Tue, 3 Oct 2017 11:16:45 +0200 Lukasz Majewski wrote: It may happen that the MXC serial IP block is performing some ongoing transmission (started at e.g. board_init()) when the "initr_serial" is called. As a result the serial port IP block is reset, so transmitted data is

Re: [U-Boot] [PATCH] Kconfig: BOOTCOMMAND: Define default set of boot commands in Kconfig

2017-10-02 Thread Łukasz Majewski
On 10/01/2017 02:41 AM, Tom Rini wrote: On Sat, Sep 30, 2017 at 10:20:47PM +0200, Łukasz Majewski wrote: On 09/14/2017 04:55 PM, Tom Rini wrote: On Mon, Sep 11, 2017 at 10:53:51PM +0200, Łukasz Majewski wrote: On 09/11/2017 07:31 PM, Tom Rini wrote: On Sun, Sep 10, 2017 at 08:25:02PM +0200

Re: [U-Boot] fsl_esdhc driver is broken with DM

2017-10-01 Thread Łukasz Majewski
Hi Fabio, Hi Tom, On Sun, Oct 1, 2017 at 11:49 AM, Tom Rini wrote: Same regression is observed with mx7dsabresd board as well. It's likely to be all i.MX :( Only the i.MX configs with CONFIG_DM_MMC=y. Yes, I can confirm this. I'm using SPL + imx_usb (and boot to

Re: [U-Boot] [PATCH] Kconfig: BOOTCOMMAND: Define default set of boot commands in Kconfig

2017-09-30 Thread Łukasz Majewski
On 09/14/2017 04:55 PM, Tom Rini wrote: On Mon, Sep 11, 2017 at 10:53:51PM +0200, Łukasz Majewski wrote: On 09/11/2017 07:31 PM, Tom Rini wrote: On Sun, Sep 10, 2017 at 08:25:02PM +0200, Lukasz Majewski wrote: This patch gives an opportunity to override the defined CONFIG_BOOTCOMMAND

Re: [U-Boot] [PATCH v3 4/7] armv8: ls1043ardb: Use static DDR setting for SPL boot

2017-09-29 Thread Łukasz Majewski
Hi York, On 09/29/2017 12:44 AM, Łukasz Majewski wrote: Hi York, This board has soldered DDR chips. To reduce the SPL image size, use static DDR setting instead of dynamic DDR driver. I'm just wondering - since your board supports FIT in SPL, maybe it would be good to have a binary blob

Re: [U-Boot] Patman - Submitting to mailing list

2017-09-29 Thread Łukasz Majewski
On 09/28/2017 11:05 PM, Duncan Hare wrote: Get the following message from running tools/patman/pathan.py git: 'send-email' is not a git command. See 'git --help'. What do I need to do? Duncan Hare 714 931 7952 ___ U-Boot mailing list

Re: [U-Boot] [PATCH v3 5/7] armv8: layerscape: Enable falcon boot

2017-09-29 Thread Łukasz Majewski
nfo *spl_image) +{ + debug("Entering kernel arg pointer: 0x%p\n", spl_image->arg); + cleanup_before_linux(); + armv8_switch_to_el2((u64)spl_image->arg, 0, 0, 0, + spl_image->entry_point, ES_TO_AARCH64); +} +#else void __noreturn jump

Re: [U-Boot] [PATCH v3 4/7] armv8: ls1043ardb: Use static DDR setting for SPL boot

2017-09-29 Thread Łukasz Majewski
Hi York, This board has soldered DDR chips. To reduce the SPL image size, use static DDR setting instead of dynamic DDR driver. I'm just wondering - since your board supports FIT in SPL, maybe it would be good to have a binary blob with DDR RAM settings embedded into it? Then you would be

Re: [U-Boot] [PATCH v2] sf: bar: Clean BA24 Bank Address Register bit after read/write/erase operation

2017-09-27 Thread Łukasz Majewski
On 09/27/2017 10:04 AM, Jagan Teki wrote: On Mon, Sep 25, 2017 at 4:10 PM, Lukasz Majewski wrote: The content of Bank Address Register (BAR) is volatile. It is cleared after power cycle or reset command (RESET F0h). Some memories (like e.g. s25fl256s) use it to access memory

Re: [U-Boot] [PATCH v2] sf: bar: Clean BA24 Bank Address Register bit after read/write/erase operation

2017-09-27 Thread Łukasz Majewski
Hi Jagan, On Tue, Sep 26, 2017 at 12:37 PM, Łukasz Majewski <lu...@denx.de> wrote: On 09/26/2017 07:40 AM, Jagan Teki wrote: On Mon, Sep 25, 2017 at 4:10 PM, Lukasz Majewski <lu...@denx.de> wrote: The content of Bank Address Register (BAR) is volatile. It is cleared after

Re: [U-Boot] [PATCH v2] sf: bar: Clean BA24 Bank Address Register bit after read/write/erase operation

2017-09-26 Thread Łukasz Majewski
Hi Jagan, On 09/26/2017 07:40 AM, Jagan Teki wrote: On Mon, Sep 25, 2017 at 4:10 PM, Lukasz Majewski wrote: The content of Bank Address Register (BAR) is volatile. It is cleared after power cycle or reset command (RESET F0h). Some memories (like e.g. s25fl256s) use it to

Re: [U-Boot] [PATCH v2] sf: bar: Clean BA24 Bank Address Register bit after read/write/erase operation

2017-09-26 Thread Łukasz Majewski
On 09/26/2017 07:40 AM, Jagan Teki wrote: On Mon, Sep 25, 2017 at 4:10 PM, Lukasz Majewski wrote: The content of Bank Address Register (BAR) is volatile. It is cleared after power cycle or reset command (RESET F0h). Some memories (like e.g. s25fl256s) use it to access memory

Re: [U-Boot] [PATCH v2 5/7] armv8: layerscape: Eanble falcon boot

2017-09-25 Thread Łukasz Majewski
Hi York, If you don't mind, I would like to ask you for some help and clarification regarding your work. Add jump_to_image_linux() for arm64. Add "noreturn" flag to armv8_switch_to_el2(). Add hooks to fsl-layerscape to enable falcon boot. I'm trying to do the same on imx6q board (armv7).

Re: [U-Boot] [PATCH] sf: bar: Clean BA24 Bank Address Register bit after read/write/erase operation

2017-09-25 Thread Łukasz Majewski
Hi Jagan, On Wed, Sep 13, 2017 at 3:09 PM, Lukasz Majewski wrote: The content of Bank Address Register (BAR) is volatile. It is cleared after power cycle or reset command (RESET F0h). Some memories (like e.g. s25fl256s) use it to access memory larger than 0x100 (16 MiB).

Re: [U-Boot] Pull request: u-boot-spi/master

2017-09-25 Thread Łukasz Majewski
Hi Jagan, Hi Tom, Please pull this PR. Would you find some time and look into following patch: http://patchwork.ozlabs.org/patch/813266/ Thanks in advance, Łukasz thanks! Jagan. The following changes since commit 1f6049e2501b5c35c61435dbc05ba96743202674: tools/mkimage: Make the

Re: [U-Boot] [PATCH] GPT: fix memory leaks identified by Coverity

2017-09-25 Thread Łukasz Majewski
On 09/25/2017 02:37 AM, ali...@peloton-tech.com wrote: From: Alison Chaiken Create a common exit for most of the error handling code in do_rename_gpt_parts. Delete the list elements in disk_partitions before calling INIT_LIST_HEAD from get_gpt_info() a second time. The

Re: [U-Boot] Make Menuconfig Fails

2017-09-25 Thread Łukasz Majewski
Hi Duncan, make menuconfig HOSTCC scripts/kconfig/mconf.o In file included from scripts/kconfig/mconf.c:23:0: scripts/kconfig/lxdialog/dialog.h:26:20: fatal error: curses.h: No such file or directory #include CURSES_LOC It seems like you are missing ncurses5-dev package. Appears

Re: [U-Boot] [PATCH 0/5] Follow the Linux Kernel in building dtc as needed

2017-09-24 Thread Łukasz Majewski
Hi Tom, On Sun, Sep 24, 2017 at 06:50:01PM +0200, Marek Vasut wrote: On 09/24/2017 04:26 PM, Tom Rini wrote: The following series has been applied. I am posting this for the record. For the record, I do not believe that using git submodules is a good approach here. We have a small amount

Re: [U-Boot] Makefile: Update minimum dtc version to 1.4.3

2017-09-24 Thread Łukasz Majewski
Hi Marek, Tom, On 09/24/2017 01:36 PM, Tom Rini wrote: On Sun, Sep 24, 2017 at 10:28:18AM +0200, Marek Vasut wrote: On 09/24/2017 05:22 AM, Tom Rini wrote: On Sat, Sep 23, 2017 at 09:07:02PM -0500, Robert Nelson wrote: On Sat, Sep 23, 2017 at 8:49 PM, Bin Meng wrote:

Re: [U-Boot] Makefile: Update minimum dtc version to 1.4.3

2017-09-24 Thread Łukasz Majewski
On 09/24/2017 08:41 AM, Heinrich Schuchardt wrote: On 09/23/2017 07:53 PM, Tom Rini wrote: On Sat, Sep 23, 2017 at 07:43:09PM +0200, Marek Vasut wrote: On 09/23/2017 07:37 PM, Tom Rini wrote: On Sat, Sep 23, 2017 at 07:33:44PM +0200, Marek Vasut wrote: On 09/23/2017 07:05 PM, Tom Rini wrote:

Re: [U-Boot] [PATCH] sf: bar: Clean BA24 Bank Address Register bit after read/write/erase operation

2017-09-23 Thread Łukasz Majewski
Hi Fabio, Jagan, Hi Lukasz, On Wed, Sep 13, 2017 at 6:39 AM, Lukasz Majewski wrote: #ifdef CONFIG_SPI_FLASH_BAR +/* + * This "cleanup" is necessary in a situation when one was accessing + * spi flash memory > 16 MiB by using Bank Address Register's BA24 bit. + * + * After

Re: [U-Boot] [OE-core] [PATCH] u-boot: Upgrade to 2017.09

2017-09-18 Thread Łukasz Majewski
Hi Khem, On Sun, Sep 17, 2017 at 2:18 AM, Martin Jansa wrote: Is anyone seeing u-boot-fw-utils.do_install failure with this? I am seeing same failures too. havent yet dug into it. Please pay note to change in directory structure in u-boot envs (from 2017.09):

Re: [U-Boot] [PATCH] sf: bar: Clean BA24 Bank Address Register bit after read/write/erase operation

2017-09-13 Thread Łukasz Majewski
Hi Fabio, Hi Lukasz, On Wed, Sep 13, 2017 at 6:39 AM, Lukasz Majewski wrote: #ifdef CONFIG_SPI_FLASH_BAR +/* + * This "cleanup" is necessary in a situation when one was accessing + * spi flash memory > 16 MiB by using Bank Address Register's BA24 bit. + * + * After it the

Re: [U-Boot] [PATCH] fs/fat: fix fatbuf leak

2017-09-13 Thread Łukasz Majewski
urn ret; } @@ -1174,6 +1182,7 @@ int fat_readdir(struct fs_dir_stream *dirs, struct fs_dirent **dentp) void fat_closedir(struct fs_dir_stream *dirs) { fat_dir *dir = (fat_dir *)dirs; + free(dir->fsdata.fatbuf); free(dir); } Reviewed-by: Łukasz Majewski <lu.

[U-Boot] [GIT] Pull request: u-boot-dfu

2017-09-13 Thread Łukasz Majewski
://travis-ci.org/lmajewski/u-boot-dfu/builds/274945208 https://travis-ci.org/lmajewski/u-boot-dfu/builds/274965975 -- Best regards. Łukasz Majewski ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 14/14] sunxi: sina33: Sync the device tree with the kernel

2017-09-13 Thread Łukasz Majewski
On 09/12/2017 09:01 PM, Maxime Ripard wrote: The kernel DT of the SinA33 has evolved quite a bit. Make sure we sync it and its upstream DTSI to be able to use the OTG. The DTs were taken from the 4.13 kernel release. Reviewed-by: Simon Glass Signed-off-by: Maxime Ripard

Re: [U-Boot] [PATCH v2 12/14] sunxi: Register usb_ether

2017-09-13 Thread Łukasz Majewski
ons(+) diff --git a/board/sunxi/board.c b/board/sunxi/board.c index f9224360d758..610fa89056ef 100644 --- a/board/sunxi/board.c +++ b/board/sunxi/board.c @@ -737,6 +737,8 @@ int misc_init_r(void) return ret; #endif + usb_ether_init(); + return 0; } Reviewed-by: Łuk

Re: [U-Boot] [PATCH v2 11/14] musb: sunxi: switch to the device model

2017-09-13 Thread Łukasz Majewski
def CONFIG_USB_MUSB_HOST + .ops= _usb_ops, +#endif + .platdata_auto_alloc_size = sizeof(struct usb_platdata), + .priv_auto_alloc_size = sizeof(struct musb_host_data), +}; Reviewed-by: Łukasz Majewski <lu...@denx.de> -- Best regards, Lukasz Majewski -- DENX Software Engineering GmbH,

Re: [U-Boot] [PATCH v2 10/14] cmd: fastboot: Rework fastboot dependency

2017-09-13 Thread Łukasz Majewski
USB_GADGET=y CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments" CONFIG_USB_GADGET_VENDOR_NUM=0x0451 CONFIG_USB_GADGET_PRODUCT_NUM=0xd022 -CONFIG_USB_GADGET_DOWNLOAD=y CONFIG_OF_LIBFDT=y diff --git a/configs/tinker-rk3288_defconfig b/configs/tinker-rk3288_defconfig index 84fcd8979f20

Re: [U-Boot] [PATCH v2 09/14] sunxi: imply USB_GADGET

2017-09-13 Thread Łukasz Majewski
E=y -CONFIG_USB_GADGET=y CONFIG_USB_GADGET_DOWNLOAD=y Reviewed-by: Łukasz Majewski <lu...@denx.de> -- Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (

Re: [U-Boot] [PATCH v2 08/14] sunxi: provide default USB gadget setup

2017-09-13 Thread Łukasz Majewski
On 09/12/2017 09:01 PM, Maxime Ripard wrote: All the Allwinner boards use the same manufacturer, VID and PID for the gadgets. Make them the defaults to remove some boilerplate from our defconfigs. Reviewed-by: Łukasz Majewski <lu...@denx.de> Reviewed-by: Simon Glass <s...@chr

Re: [U-Boot] [PATCH v2 05/14] usb: gadget: usb_ether: Move the interfaces to Kconfig

2017-09-13 Thread Łukasz Majewski
On 09/12/2017 09:01 PM, Maxime Ripard wrote: We need to select an interface for the usb_ether gadget, and they haven't been converted to Kconfig yet. Add a choice to make sure we have an option selected, and convert all the users. Reviewed-by: Łukasz Majewski <lu...@denx.de> Sign

Re: [U-Boot] [PATCH v2 04/14] usb: gadget: Convert USB_ETHER to Kconfig

2017-09-13 Thread Łukasz Majewski
On 09/12/2017 09:01 PM, Maxime Ripard wrote: The USB Ethernet gadget option has not yet been moved to Kconfig, let's deal with that. Reviewed-by: Łukasz Majewski <lu...@denx.de> Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.com> --- configs/am335x_balt

Re: [U-Boot] [PATCH v2 03/14] usb: gadget: Move USBNET_HOST_ADDR to Kconfig

2017-09-13 Thread Łukasz Majewski
d:be:af:00:00" #define CONFIG_USBNET_DEV_ADDR"de:ad:be:af:00:01" #endif diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt index 9ce0c3f039ff..784e83c7c8a1 100644 --- a/scripts/config_whitelist.txt +++ b/scripts/config_whitelist.txt @@

Re: [U-Boot] [PATCH v2 01/14] usb: gadget: Move USBNET_DEVADDR option out of g_dnl

2017-09-13 Thread Łukasz Majewski
_DOWNLOAD - endif # USB_GADGET Acked-by: Łukasz Majewski <lu...@denx.de> -- Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989

Re: [U-Boot] [PATCH v2 02/14] usb: gadget: Document USBNET_DEVADDR

2017-09-13 Thread Łukasz Majewski
default "de:ad:be:ef:00:01" + help + Ethernet MAC address of the device-side (ie. local board's) MAC + address of the usb_ether interface endif # USB_GADGET Acked-by: Łukasz Majewski <lu...@denx.de> -- Best regards, Lukasz Majewski --

Re: [U-Boot] [U-Boot,V9,1/4] usb: rockchip: add the rockusb gadget

2017-09-12 Thread Łukasz Majewski
Hi Philipp, This patch series is waiting for opening new merge window. It is already applied to usb-next tree. this patch implement rockusb protocol on the device side. this is based on USB download gadget infrastructure. the rockusb function implements the rd, wl, rid commands. it can work

Re: [U-Boot] [PATCH] Kconfig: BOOTCOMMAND: Define default set of boot commands in Kconfig

2017-09-11 Thread Łukasz Majewski
On 09/11/2017 07:31 PM, Tom Rini wrote: On Sun, Sep 10, 2017 at 08:25:02PM +0200, Lukasz Majewski wrote: This patch gives an opportunity to override the defined CONFIG_BOOTCOMMAND (at files) with set of commands defined in board _defconfig file. Rationale: This change allows having two

Re: [U-Boot] [PATCH 05/13] usb: gadget: Make g_dnl USB settings common

2017-09-09 Thread Łukasz Majewski
Hi Maxime, The g_dnl USB settings for the vendor ID, product ID and manufacturer are actually common settings that can and should be shared by all the gadgets. Make them common by renaming them, and convert all the users. Reviewed-by: Lukasz Majewski Signed-off-by: Maxime

Re: [U-Boot] [PATCH 06/13] usb: gadget: usb_ether: Move settings to common

2017-09-08 Thread Łukasz Majewski
On 09/08/2017 07:34 PM, Maxime Ripard wrote: The usb_ether gadget duplicates the USB settings for the manufacturer, product ID and vendor ID. Make sure we use the common option so that we can expect a single VID/PID couple for a single device. Signed-off-by: Maxime Ripard

Re: [U-Boot] [PATCH v3 10/14] doc: overlays: Tweak documentation regarding overlays

2017-09-06 Thread Łukasz Majewski
guration. +This document focuses on specifically using overlays as part of a FIT image. +General information regarding overlays including its syntax and building it +can be found in doc/README.fdt-overlays + Configuration without overlays ------ Reviwed-b

Re: [U-Boot] [PATCH v3 09/14] doc: Document how to apply fdt overlays

2017-09-06 Thread Łukasz Majewski
base and overlays are going +to be invalidated, so keep copies to avoid reloading. + +Pantelis Antoniou +pantelis.anton...@konsulko.com +11/7/2017 Reviewed-by: Łukasz Majewski -- Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Muni

Re: [U-Boot] [PATCH v3 08/14] fit: fdt overlays doc

2017-09-06 Thread Łukasz Majewski
++ b/doc/uImage.FIT/source_file_format.txt @@ -235,7 +235,7 @@ o config@1 |- description = "configuration description" |- kernel = "kernel sub-node unit name" |- ramdisk = "ramdisk sub-node unit name" - |- fdt = "fdt sub-node unit-name" + |- fdt

Re: [U-Boot] [PATCH v3 1/1] usb: gadget: g_dnl: Sync internal SN variable with env

2017-09-05 Thread Łukasz Majewski
Hi Sam, On 4 September 2017 at 08:36, Heiko Schocher <h...@denx.de> wrote: Hello Lukasz, Am 02.09.2017 um 13:08 schrieb Łukasz Majewski: Hi Heiko, Would you find some time and run this patch through your test setup? Thanks in advance. Of course, as it is automated ;-) Okay,

Re: [U-Boot] [PATCH v2 1/8] fs/fat: split out helper to init fsdata

2017-09-03 Thread Łukasz Majewski
On 09/03/2017 05:47 PM, Rob Clark wrote: On Sun, Sep 3, 2017 at 10:52 AM, Łukasz Majewski <lu...@denx.de> wrote: On 09/02/2017 06:37 PM, Rob Clark wrote: Want to re-use this in fat dirent iterator in next patch. Signed-off-by: Rob Clark <robdcl...@gmail.com> Reviewed-by: Łuk

Re: [U-Boot] [PATCH 1/9] lib: Add CRC32-C

2017-09-03 Thread Łukasz Majewski
Hi Marek, This is needed for BTRFS. Signed-off-by: Marek Behun create mode 100644 lib/crc32c.c Excuse me my ignorance, but in u-boot we already have: ./lib/crc32.c is the crc32c algorithm a different one from venerable crc32? diff --git a/include/u-boot/crc.h

Re: [U-Boot] [RFC] toradex: imx6: Move g_dnl_bind_fixup() into common SPL code

2017-09-03 Thread Łukasz Majewski
On 09/03/2017 04:56 PM, Fabio Estevam wrote: From: Fabio Estevam <fabio.este...@nxp.com> Instead of having every board file to add its own g_dnl_bind_fixup() implementation, move it to the common imx6 SPL code. Reviewed-by: Łukasz Majewski <lu...@denx.de> Signed-off-by: F

Re: [U-Boot] [PATCH v2 8/8] fs/fat: fix case for FAT shortnames

2017-09-03 Thread Łukasz Majewski
On 09/02/2017 06:38 PM, Rob Clark wrote: Noticed when comparing our output to linux. There are some lcase bits which control whether filename and/or extension should be downcase'd. Reviewed-by: Łukasz Majewski <lu...@denx.de> Signed-off-by: Rob Clark <robdcl...@gmail.com>

Re: [U-Boot] [PATCH v2 7/8] fat/fs: move ls to generic implementation

2017-09-03 Thread Łukasz Majewski
On 09/02/2017 06:38 PM, Rob Clark wrote: Add a generic implementation of 'ls' using opendir/readdir/closedir, and replace fat's custom implementation. Other filesystems should move to the generic implementation after they add opendir/readdir/closedir support. Reviewed-by: Łukasz Majewski <

Re: [U-Boot] [PATCH v2 5/8] fs/fat: implement opendir/readdir/closedir

2017-09-03 Thread Łukasz Majewski
On 09/02/2017 06:38 PM, Rob Clark wrote: Implement the readdir interface using the directory iterators. Reviewed-by: Łukasz Majewski <lu...@denx.de> Signed-off-by: Rob Clark <robdcl...@gmail.com> --- fs/fat/fat.c | 56 +

Re: [U-Boot] [PATCH v2 4/8] fs: add fs_readdir()

2017-09-03 Thread Łukasz Majewski
is held in the FS_DIR "directory stream"), to avoid re-traversing of the directory structure at each step. The directory stream must be released with closedir() when it is no longer needed. Reviewed-by: Łukasz Majewski <lu...@denx.de> Signed-off-by: Rob Clark <robdcl...@gm

Re: [U-Boot] [PATCH v2 3/8] fat/fs: convert to directory iterators

2017-09-03 Thread Łukasz Majewski
On 09/02/2017 06:37 PM, Rob Clark wrote: And drop a whole lot of ugly code! +1 Reviewed-by: Łukasz Majewski <lu...@denx.de> Signed-off-by: Rob Clark <robdcl...@gmail.com> --- fs/fat/fat.c | 723 ++ include/fat.h | 6

Re: [U-Boot] [PATCH v2 2/8] fs/fat: introduce new director iterators

2017-09-03 Thread Łukasz Majewski
On 09/02/2017 06:37 PM, Rob Clark wrote: Untangle directory traversal into a simple iterator, to replace the existing multi-purpose do_fat_read_at() + get_dentfromdir(). Signed-off-by: Rob Clark <robdcl...@gmail.com> Reviewed-by: Łukasz Majewski <lu...@denx.de> --- fs/fat

Re: [U-Boot] [PATCH v2 1/8] fs/fat: split out helper to init fsdata

2017-09-03 Thread Łukasz Majewski
On 09/02/2017 06:37 PM, Rob Clark wrote: Want to re-use this in fat dirent iterator in next patch. Signed-off-by: Rob Clark <robdcl...@gmail.com> Reviewed-by: Łukasz Majewski <lu...@denx.de> --- fs/fat/fat.c | 73 +++ i

Re: [U-Boot] [PATCH v3 1/1] usb: gadget: g_dnl: Sync internal SN variable with env

2017-09-02 Thread Łukasz Majewski
Hi Heiko, Would you find some time and run this patch through your test setup? Thanks in advance. Best regards, Łukasz Since commit 842778a09104 ("usb: gadget: g_dnl: only set iSerialNumber if we have a serial#") "fastboot devices" stopped to show correct device serial number for TI boards,

Re: [U-Boot] [PATCH 1/1] usb: gadget: g_dnl: Use serial# variable to set g_dnl_serial

2017-09-01 Thread Łukasz Majewski
On 09/01/2017 11:51 AM, Marek Vasut wrote: On 09/01/2017 10:36 AM, Łukasz Majewski wrote: On 09/01/2017 10:19 AM, Marek Vasut wrote: On 08/31/2017 08:20 PM, Sam Protsenko wrote: Since 842778a09104 commit, "fastboot devices" stopped to show correct device serial number for TI board

Re: [U-Boot] [PATCH 1/1] usb: gadget: g_dnl: Use serial# variable to set g_dnl_serial

2017-09-01 Thread Łukasz Majewski
On 09/01/2017 10:19 AM, Marek Vasut wrote: On 08/31/2017 08:20 PM, Sam Protsenko wrote: Since 842778a09104 commit, "fastboot devices" stopped to show correct device serial number for TI boards, showing this line instead: fastboot This is because serial# env variable

Re: [U-Boot] [PATCH 1/1] usb: gadget: g_dnl: Use serial# variable to set g_dnl_serial

2017-08-31 Thread Łukasz Majewski
On 08/31/2017 08:45 PM, Sam Protsenko wrote: On 31 August 2017 at 21:20, Sam Protsenko wrote: Since 842778a09104 commit, "fastboot devices" stopped to show correct device serial number for TI boards, showing this line instead: fastboot This

Re: [U-Boot] [PATCH v2] dm: core: Add livetree documentation

2017-08-31 Thread Łukasz Majewski
d-by: Lukasz Majewski <lu...@denx.de> Reviewed-by: Łukasz Majewski <lu...@denx.de> (I hope this is OK, I just fixed the typos) Thanks :-) -- Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenst

Re: [U-Boot] am33xx ddr tests

2017-08-29 Thread Łukasz Majewski
On 08/27/2017 03:40 PM, Ryan wrote: Hello, I have 2 chips which are 512mb each connected to the AM33xx processor. I want to check if the base address is configured for each chip in u-boot or kernel. Could you be more specific here? In u-boot (SPL + u-boot.img) the DDRs are configured. When

Re: [U-Boot] [GIT] Pull request: u-boot-dfu

2017-08-28 Thread Łukasz Majewski
On 08/28/2017 10:32 PM, Marek Vasut wrote: On 08/28/2017 09:28 PM, Łukasz Majewski wrote: Dear Marek, Those patches are preferably for -next merge widow. The following changes since commit ae61b5353b48fa49c66376f273cc53cd3c06b656: usb: dwc3: fix Kconfig dependency to accept host driver

[U-Boot] [GIT] Pull request: u-boot-dfu

2017-08-28 Thread Łukasz Majewski
Dear Marek, Those patches are preferably for -next merge widow. The following changes since commit ae61b5353b48fa49c66376f273cc53cd3c06b656: usb: dwc3: fix Kconfig dependency to accept host driver in drivers/usb/dwc3 (2017-08-25 11:23:27 +0200) are available in the git repository at:

Re: [U-Boot] [PATCH] imx6: drop duplicated bss memset and board_init_r() call

2017-08-28 Thread Łukasz Majewski
Hi Anatolij, bss section is cleared in crt0.S. board_init_r() is also entered from crt0 code. Reviewed-by: Lukasz Majewski Signed-off-by: Anatolij Gustschin Cc: Christian Gmeiner Cc: Nikita Kiryanov Cc:

Re: [U-Boot] [RFC PATCH 0/4] usb: net: Migrate USB Ethernet to Kconfig

2017-08-28 Thread Łukasz Majewski
Hi Chris, I ran into a few problems running moveconfig.py mainly due to boards that include a common .h file. I'm not confident I've captured all the defconfigs that need CONFIG_USB_HOST_ETHER or one of the specific drivers. Is there a more fool-proof way of catching these cases? Needless to

Re: [U-Boot] [PATCH v2 5/6] rename GPT partitions to detect boot failure

2017-08-28 Thread Łukasz Majewski
On 08/28/2017 01:02 AM, Chaiken, Alison wrote: On 2017-05-31 01:12, Lukasz Majewski wrote: [ . . . ] And another request -> Could you consider adding tests for those new gpt commands to the 'sandbox' (sandbox_defconfig) ? Then you can 'mount' some gpt test image ('host' command) and use it

Re: [U-Boot] [PATCH] fix: fw_env: Prevent writing error message on special files, which don't support fsync

2017-08-27 Thread Łukasz Majewski
Hi Michael, Hi Lukasz, Am Sonntag, 27. August 2017, 13:46:22 CEST schrieb Lukasz Majewski: According to fsync specification [1] some special files (e.g., a pipe, FIFO, or socket) don't support synchronization and return either EROFS or EINVAL. On the linux side the sys_fsync -> do_fsync()

Re: [U-Boot] [PATCH v2 4/4] rockchip: enable rockusb for all rockchip SoCs

2017-08-26 Thread Łukasz Majewski
On 08/26/2017 02:46 PM, Tom Rini wrote: On Fri, Aug 25, 2017 at 01:06:55PM +0200, Łukasz Majewski wrote: Hi Philipp, Andy, Tom On 25 Aug 2017, at 03:51, Andy Yan <andys...@gmail.com> wrote: Hi Lukasz: 2017-08-22 18:05 GMT+08:00 Łukasz Majewski <lu...@denx.de <mailto:lu...@d

Re: [U-Boot] [PATCH v2 4/4] rockchip: enable rockusb for all rockchip SoCs

2017-08-26 Thread Łukasz Majewski
Dear All, Hi Philipp, Andy, Tom On 25 Aug 2017, at 03:51, Andy Yan <andys...@gmail.com> wrote: Hi Lukasz: 2017-08-22 18:05 GMT+08:00 Łukasz Majewski <lu...@denx.de <mailto:lu...@denx.de>>: Hi Kever, Philipp, I have no idea about the status of rockusb, it ha

Re: [U-Boot] [PATCH v2 4/4] rockchip: enable rockusb for all rockchip SoCs

2017-08-25 Thread Łukasz Majewski
Hi Philipp, Andy, Tom On 25 Aug 2017, at 03:51, Andy Yan <andys...@gmail.com> wrote: Hi Lukasz: 2017-08-22 18:05 GMT+08:00 Łukasz Majewski <lu...@denx.de <mailto:lu...@denx.de>>: Hi Kever, Philipp, I have no idea about the status of rockusb, it has been a lon

Re: [U-Boot] [PATCH] imx: imx6: Move gpr_init() function to soc.c

2017-08-24 Thread Łukasz Majewski
On 08/24/2017 03:02 PM, Stefano Babic wrote: Hi Breno, On 24/08/2017 15:00, Breno Lima wrote: Since the gpr_init() function is common for boards using MX6S, MX6DL, MX6D, MX6Q and MX6QP processors move it to the soc.c file. Fully agree ! I took a loog a couple of days ago and I saw how much

Re: [U-Boot] [PATCH 0/2] board: ti: am57xx: Add DT support for BeagleBoard-X15 revC

2017-08-23 Thread Łukasz Majewski
: Select dtb name for X15 revC arch/arm/dts/Makefile | 1 + board/ti/am57xx/board.c | 3 +++ configs/am57xx_evm_defconfig| 2 +- configs/am57xx_hs_evm_defconfig | 2 +- include/environment/ti/boot.h | 2 ++ 5 files changed, 8 insertions(+), 2 deletions(-) Reviewed-by: Łukasz

Re: [U-Boot] [PATCH v2 4/4] rockchip: enable rockusb for all rockchip SoCs

2017-08-22 Thread Łukasz Majewski
Hi Kever, Philipp, I have no idea about the status of rockusb, it has been a long time on the list. Maybe Eddie or Lukasz have an answer? I've asked Eddie to fix issues with breaking other boards when enabling USB gadget infrastructure on RK. No reply since then. I have to use

[U-Boot] [GIT] Pull request: u-boot-dfu

2017-08-21 Thread Łukasz Majewski
Dear Marek, The following changes since commit 5b70b1688cdf677563096063e4a48e4bed250a10: usb: ehci: Convert CONFIG_USB_EHCI_PCI to Kconfig (2017-08-09 10:50:08 +0200) are available in the git repository at: git://git.denx.de/u-boot-dfu.git/master for you to fetch changes up to

Re: [U-Boot] [PATCH] fb_mmc.c: Correct blk_dread() return value checks

2017-08-17 Thread Łukasz Majewski
mdisk_sector_start, ramdisk_sectors, ramdisk_buffer); - if (res == 0) { + if (res != ramdisk_sectors) { error("cannot read ramdisk from boot partition"); fastboot_fail("cannot read ramdisk from boot partition"); return -1; Rev

Re: [U-Boot] [PATCH v3 3/3] config: move USB_FUNCTION_MASS_STORAGE

2017-08-17 Thread Łukasz Majewski
Hi Philipp, On 26 July 2017 at 05:22, Philipp Tomsich wrote: With both an imply from CMD_USB to USB_FUNCTION_MASS_STORAGE and with USB_FUNCTION_MASS_STORAGE moved to Kconfig, we can now run moveconfig. Signed-off-by: Philipp Tomsich

Re: [U-Boot] [PATCH v2 2/8] usb: gadget: add SDP driver

2017-08-17 Thread Łukasz Majewski
On 08/17/2017 03:54 PM, Marek Vasut wrote: On 08/17/2017 03:49 PM, Stefano Babic wrote: On 16/08/2017 20:00, Stefan Agner wrote: From: Stefan Agner Add SDP (Serial Downloader Protocol) implementation for U-Boot. The protocol is used in NXP SoC's boot ROM and allows

Re: [U-Boot] [PATCH v3 18/19] dfu: fix spl build

2017-08-17 Thread Łukasz Majewski
]; struct mtd_device *mtd_dev; u8 part_num; @@ -220,6 +222,7 @@ int dfu_fill_entity_nand(struct dfu_entity *dfu, char *devstr, char *s) mtdparts_init(); ret = find_dev_and_part(mtd_id, _dev, _num, ); + I think that this blank line is not neede

Re: [U-Boot] [PATCH v2 7/8] apalis/colibri_imx6: use independent USB PID for SPL

2017-08-17 Thread Łukasz Majewski
On 08/16/2017 08:00 PM, Stefan Agner wrote: From: Stefan Agner <stefan.ag...@toradex.com> Use a completely independent USB Product ID for SPL. This allows to differentiate a SDP running in SPL and SDP running in a U-Boot which could not read the config block successfully. Reviewed-by:

Re: [U-Boot] [PATCH v2 6/8] doc: add Serial Download Protocol documentation

2017-08-17 Thread Łukasz Majewski
Hi Stefan, From: Stefan Agner <stefan.ag...@toradex.com> Document the U-Boot Serial Download Protocol implementation and some typical use cases. Thanks for providing the description :-) Reviewed-by: Łukasz Majewski <lu...@denx.de> Signed-off-by: Stefan Agner <stefan.ag

Re: [U-Boot] [PATCH v2 5/8] spl: add serial download protocol (SDP) support

2017-08-17 Thread Łukasz Majewski
On 08/16/2017 08:00 PM, Stefan Agner wrote: From: Stefan Agner <stefan.ag...@toradex.com> Add USB serial download protocol support to SPL. If the SoC started in recovery mode the SPL will immediately switch to SDP and wait for further downloads/commands from the host side. Reviewed-by:

Re: [U-Boot] [PATCH v2 2/8] usb: gadget: add SDP driver

2017-08-17 Thread Łukasz Majewski
isters and download complete Device Configuration Data (DCD) sets. This basic implementation supports downloading images with the imx header format reading and writing registers. Signed-off-by: Stefan Agner <stefan.ag...@toradex.com> Reviewed-by: Łukasz Majewski <lu...@denx.de>

Re: [U-Boot] [PATCH v1 4/7] cmd: add sdp command

2017-08-08 Thread Łukasz Majewski
+exit: + g_dnl_unregister(); + + return ret; +} + +U_BOOT_CMD(sdp, 2, 1, do_sdp, + "Serial Downloader Protocol", + "\n" + " - serial downloader protocol via \n" +); Reviewed-by: Łukasz Majewski <lu...@denx.de> -- Best regards, Lukasz Majew

Re: [U-Boot] [PATCH v1 3/7] usb: gadget: sdp: extend images compatible for jumps

2017-08-08 Thread Łukasz Majewski
e host in a third step. Signed-off-by: Stefan Agner <stefan.ag...@toradex.com> Reviewed-by: Łukasz Majewski <lu...@denx.de> --- drivers/usb/gadget/f_sdp.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/f_sdp.c b/drivers/

Re: [U-Boot] [PATCH v1 2/7] usb: gadget: add SDP driver

2017-08-08 Thread Łukasz Majewski
Hi Stefan, From: Stefan Agner Add SDP (Serial Downloader Protocol) implementation for U-Boot. The protocol is used in NXP SoC's boot ROM and allows to download program images. Beside that, it can also be used to read/write registers and download complete Device

Re: [U-Boot] [PATCH v1 0/7] imx: add USB Serial Download Protocol (SDP) support

2017-08-08 Thread Łukasz Majewski
Hi Stefan, From: Stefan Agner This series adds NXP's Serial Download Protocol (SDP) support via USB for SPL/U-Boot. It allows to download U-Boot via USB from a (recovered) SPL using the same tools used to download SPL itself (specifically imx_usb, but also sb_loader

Re: [U-Boot] [PATCH v1 1/7] imx: move imximage header to common location

2017-08-08 Thread Łukasz Majewski
e.h | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename {tools => include}/imximage.h (100%) diff --git a/tools/imximage.h b/include/imximage.h similarity index 100% rename from tools/imximage.h rename to include/imximage.h Reviewed-by: Łukasz Majewski <lu...@denx.de> -- Best r

Re: [U-Boot] [PATCH 3/3] dm: core: Add livetree documentation

2017-08-08 Thread Łukasz Majewski
iding such great documentation. Please find some word misspelled correction. Reviewed-by: Łukasz Majewski <lu...@denx.de> -- Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzel

Re: [U-Boot] [PATCH] usb: dwc2: Align size of invalidating dcache before starting DMA

2017-07-31 Thread Łukasz Majewski
ritel(DOEPT_SIZ_PKT_CNT(pktcnt) | DOEPT_SIZ_XFER_SIZE(length), Reviewed-by: Łukasz Majewski <lu...@denx.de> -- Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-669

Re: [U-Boot] [PATCH] Convert CONFIG_USB_ETHER et al to Kconfig

2017-07-28 Thread Łukasz Majewski
On 07/26/2017 07:05 PM, Adam Ford wrote: This converts the following to Kconfig: CONFIG_USB_ETHER CONFIG_USB_ETHER_RNDIS Signed-off-by: Adam Ford <aford...@gmail.com> Acked-by: Łukasz Majewski <lu...@denx.de> -- Best regards, Lukasz Majewski -- DENX Software Engi

Re: [U-Boot] [PATCH v3 1/3] usb: gadget: move USB_FUNCTION_MASS_STORAGE to Kconfig

2017-07-28 Thread Łukasz Majewski
Acked-by: Łukasz Majewski <lu...@denx.de> --- Changes in v3: None Changes in v2: - ran 'tabify' on newly added lines to fix a spaces vs. tabs issues drivers/usb/gadget/Kconfig | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig i

Re: [U-Boot] [PATCH v5 00/20] dm: tegra: Move nyan-big, jetson-tk1, beaver to livetree

2017-07-26 Thread Łukasz Majewski
Hi Simon This moves four entire boards to use a live device tree as an example of the impact. I've grepp'ed the ./doc directory and couldn't find any info regarding "livetree" feature. From patches, I guess that livetree is about preparing DM tree just after relocation. Am I right? If

Re: [U-Boot] [PATCH] zynq: fb_mmc: Correct cast of address to u32

2017-07-24 Thread Łukasz Majewski
On 07/24/2017 02:53 PM, Marek Vasut wrote: On 07/24/2017 02:47 PM, Tom Rini wrote: On Mon, Jul 24, 2017 at 02:09:56PM +0200, Marek Vasut wrote: On 07/23/2017 05:47 PM, Tom Rini wrote: On Sun, Jul 23, 2017 at 09:05:31AM -0600, Simon Glass wrote: This does not work on 64-bit machines. Update

Re: [U-Boot] [u-boot-denx-usb] Build break on current u-boot-usb master

2017-07-24 Thread Łukasz Majewski
On 07/24/2017 09:02 AM, Bin Meng wrote: On Mon, Jul 24, 2017 at 2:48 PM, Patrice CHOTARD <patrice.chot...@st.com> wrote: Hi Marek On 07/22/2017 08:36 PM, Marek Vasut wrote: On 07/22/2017 08:18 PM, Łukasz Majewski wrote: Hi Marek, When I was "cleaning up" my patchwork todo

Re: [U-Boot] [PATCH 00/52] Support OF_PLATDATA in TPL, enable RK3368 DRAM init and add RK3368-uQ7

2017-07-24 Thread Łukasz Majewski
On 07/24/2017 10:59 AM, Heiko Stübner wrote: Am Montag, 24. Juli 2017, 16:38:52 CEST schrieb Andy Yan: Hi Philipp: On 2017年07月21日 18:55, Dr. Philipp Tomsich wrote: On 21 Jul 2017, at 04:33, Andy Yan wrote: Hi: On 2017年07月19日 04:35, Philipp Tomsich wrote: Here's a

Re: [U-Boot] [u-boot-denx-usb] Build break on current u-boot-usb master

2017-07-22 Thread Łukasz Majewski
On 07/22/2017 08:36 PM, Marek Vasut wrote: On 07/22/2017 08:18 PM, Łukasz Majewski wrote: Hi Marek, When I was "cleaning up" my patchwork todo list I've found following problem (s): A lot of boards are broken with message: LD u-boot drivers/usb/host/built-in.o: I

[U-Boot] [u-boot-denx-usb] Build break on current u-boot-usb master

2017-07-22 Thread Łukasz Majewski
Hi Marek, When I was "cleaning up" my patchwork todo list I've found following problem (s): A lot of boards are broken with message: LD u-boot drivers/usb/host/built-in.o: In function `xhci_dwc3_remove': /home/lukma/work/embedded/u-boot-denx/drivers/usb/host/xhci-dwc3.c:161:

Re: [U-Boot] [GIT] Pull request: u-boot-dfu

2017-07-20 Thread Łukasz Majewski
Hi Marek, On 07/20/2017 12:03 PM, Łukasz Majewski wrote: Dear Marek, Hi, The following changes since commit 807598a60c5bf7fdf0eb1d78625eeeacfac3c6bc: usb: add static to local symbols (2017-07-14 20:45:20 +0200) are available in the git repository at: git://git.denx.de/u-boot-dfu.git

[U-Boot] [GIT] Pull request: u-boot-dfu

2017-07-20 Thread Łukasz Majewski
Dear Marek, The following changes since commit 807598a60c5bf7fdf0eb1d78625eeeacfac3c6bc: usb: add static to local symbols (2017-07-14 20:45:20 +0200) are available in the git repository at: git://git.denx.de/u-boot-dfu.git for you to fetch changes up to

  1   2   >