Re: [U-Boot] [PATCH v5 01/16] arm: ls102xa: Add Freescale LS102xA SoC support

2014-08-19 Thread AlisonWang
Hi, Mark, On Tue, Aug 19, 2014 at 03:54:50AM +0100, Alison Wang wrote: +int timer_init(void) +{ + struct sctr_regs *sctr = (struct sctr_regs *)SCTR_BASE_ADDR; + unsigned long ctrl, val, freq; + + /* Enable System Counter */ + writel(SYS_COUNTER_CTRL_ENABLE,

Re: [U-Boot] [PATCH v4 16/18] video: dcu: Add Sii9022A HDMI Transmitter support

2014-08-16 Thread AlisonWang
On 08/13/2014 11:45 PM, Alison Wang wrote: On LS1021ATWR, Silicon's Sii9022A HDMI Transmitter is used. This patch adds the common setting for this chip. Shouldn't this driver stay under driver/video? It is for the HDMI transmitter, not Freescale board specific, is it? [Alison Wang]

Re: [U-Boot] [PATCH v4 04/18] net: mdio: Add private MDIO read/write function

2014-08-16 Thread AlisonWang
On 08/13/2014 11:44 PM, Alison Wang wrote: As extra FPGA settings is needed for MDIO read/write on LS1021AQDS, private MDIO read/write functions are created. Signed-off-by: Alison Wang [hidden email] --- Change log: v4: No change. v3: Split from the

Re: [U-Boot] [PATCH v4 02/18] ls102xa: i2c: Add i2c support for LS102xA

2014-08-16 Thread AlisonWang
On 08/13/2014 11:44 PM, Alison Wang wrote: This patch is to add I2C 1,2,3 support for LS102xA. I think the commit message should say which existing I2C driver is compatible with the controller of LS201x. From the change, you are using the same driver for i.MX. But it is not clear if you

Re: [U-Boot] [PATCH v4 15/18] arm: ls102xa: Add LETECH support for LS1021AQDS/TWR board

2014-08-16 Thread AlisonWang
From: Wang Huan [hidden email] This patch is to add LETECH support for LS1021AQDS/TWR board. For LETECH, lpuart is used as console. I suggest you update README to add some information about this LETECH. I have no idea what it is until I dig into some internal documents. [Alison Wang]

Re: [U-Boot] [PATCH v2 09/10] arm: ls102xa: Add basic support for LS1021AQDS board

2014-08-11 Thread AlisonWang
Hi, York, On 07/03/2014 12:24 AM, Alison Wang wrote: diff --git a/lib/lmb.c b/lib/lmb.c index 081e418..0903222 100644 --- a/lib/lmb.c +++ b/lib/lmb.c @@ -295,7 +295,7 @@ phys_addr_t __lmb_alloc_base(struct lmb *lmb, phys_size_t size, ulong align, phy if (max_addr ==

Re: [U-Boot] [PATCH v2 0/9] arm: ls102xa: Add Freescale LS102xA SoC and LS1021AQDS/TWR board support

2014-08-11 Thread AlisonWang
Hi, York, On 07/03/2014 12:24 AM, Alison Wang wrote: This series contain the support for Freescale LS102xA SoC and LS1021AQDS/TWR board. Alison, Please respin your patches. It has been a while since you submitted them. For your convenience, I have rebased your patches to v2014.10-rc1 and

Re: [U-Boot] [PATCH v2 04/10] arm: ls102xa: Add etsec support for LS102xA

2014-08-11 Thread AlisonWang
On 07/03/2014 12:24 AM, Alison Wang wrote: Missing commit message here. [Alison Wang] Yes, I will add in v3. Signed-off-by: Alison Wang [hidden email] --- Change log: v2: Add private mdio read and write support. drivers/net/fsl_mdio.c | 24 +++-

Re: [U-Boot] [PATCH v2 05/10] arm: ls102xa: Add esdhc support for LS102xA

2014-08-11 Thread AlisonWang
On 07/03/2014 12:24 AM, Alison Wang wrote: Missing commit message here. You should explain why we need this change. It will help us search the log later. [Alison Wang] I will add commit message in v3. Signed-off-by: Alison Wang [hidden email] --- Best Regards, Alison Wang -- View this

Re: [U-Boot] [PATCH v2 0/9] arm: ls102xa: Add Freescale LS102xA SoC and LS1021AQDS/TWR board support

2014-07-03 Thread AlisonWang
Hi, Albert, On Thu, 3 Jul 2014 15:24:14 +0800, Alison Wang wrote: This series contain the support for Freescale LS102xA SoC and LS1021AQDS/TWR board. The numbering in the cover letter (0/9) does not match that in the individual patches (n/10). Is this normal? Sorry, it's my mistake. It