Re: [U-Boot] [PATCH V2 3/5] dm9000: Add struct eth_device * to SROM functions

2015-08-21 Thread Andrew Ruder
On Wed, Aug 12, 2015 at 02:07:20PM -0500, Joe Hershberger wrote: On Wed, Aug 12, 2015 at 12:24 PM, Andrew Ruder andrew.ru...@elecsyscorp.com wrote: /** function prototypes **/ #if !defined(CONFIG_DM9000_NO_SROM) -void dm9000_write_srom_word(int offset

Re: [U-Boot] [PATCH] i2c: adding driver for pxa27x, pxa3xx, pxa25x

2015-08-21 Thread Andrew Ruder
On Wed, Aug 12, 2015 at 09:34:14PM +0200, Marek Vasut wrote: On Wednesday, August 12, 2015 at 08:43:52 PM, Andrew Ruder wrote: +#if !defined(CONFIG_SYS_PXA_STD_I2C_SPEED) +#define CONFIG_SYS_PXA_STD_I2C_SPEED 10 +#endif + +#if !defined(CONFIG_SYS_PXA_STD_I2C_SLAVE) +#define

Re: [U-Boot] [PATCH] i2c: adding driver for pxa27x, pxa3xx, pxa25x

2015-08-12 Thread Andrew Ruder
On Aug 12, 2015, at 2:34 PM, Marek Vasut ma...@denx.de wrote: On Wednesday, August 12, 2015 at 08:43:52 PM, Andrew Ruder wrote: Commit message is missing :'-( I actually was going with subject being sufficient on this one. I'll fill in some more info on this as far as origin and what

[U-Boot] [PATCH V2 5/5] dm9000: rework dm9000 to support multiple devices

2015-08-12 Thread Andrew Ruder
: CONFIG_DM9000_BYTE_SWAPPED And the following has been removed entirely: CONFIG_DM9000_BASE (was only used in a single printf) Signed-off-by: Andrew Ruder andrew.ru...@elecsyscorp.com Cc: Joe Hershberger joe.hershber...@gmail.com --- drivers/net/dm9000x.c | 382

[U-Boot] [PATCH V2 4/5] dm9000: dm9000_initialize stub

2015-08-12 Thread Andrew Ruder
devices. Signed-off-by: Andrew Ruder andrew.ru...@elecsyscorp.com Cc: Joe Hershberger joe.hershber...@gmail.com --- board/altera/nios2-generic/nios2-generic.c| 3 +-- board/atmel/at91sam9261ek/at91sam9261ek.c | 2 +- board/davinci/dm355evm/dm355evm.c | 2 +- board/davinci

[U-Boot] [PATCH V2 1/5] dm9000: whitespace cleanups

2015-08-12 Thread Andrew Ruder
Signed-off-by: Andrew Ruder andrew.ru...@elecsyscorp.com Cc: Joe Hershberger joe.hershber...@gmail.com --- drivers/net/dm9000x.c | 108 -- 1 file changed, 52 insertions(+), 56 deletions(-) diff --git a/drivers/net/dm9000x.c b/drivers/net/dm9000x.c

[U-Boot] [PATCH V2 0/5] DM9000 support for multiple interfaces

2015-08-12 Thread Andrew Ruder
-tested the following: M5253DEMO ip04 I have board tested this on a yet-to-be-upstreamed port of a pxa270 board that reads an i2c eeprom to determine which (and how many) ethernet chips are enabled. Cc: Joe Hershberger joe.hershber...@gmail.com Andrew Ruder (5): dm9000: whitespace cleanups

Re: [U-Boot] [PATCH] arm: pxa: use common timer functions

2015-08-12 Thread Andrew Ruder
Tom, Just replying so you see this since apparently I should have used copy-paste on your e-mail address for the Cc: and not attempted to read after 45 cups of tea. - Andy ___ U-Boot mailing list U-Boot@lists.denx.de

[U-Boot] [PATCH] pxa: Fix boot hang by avoiding vector relocation

2015-08-12 Thread Andrew Ruder
to boot again. Cc: Marek Vasut ma...@denx.de Signed-off-by: Andrew Ruder andrew.ru...@elecsyscorp.com --- arch/arm/cpu/pxa/Makefile | 1 + arch/arm/cpu/pxa/relocate.S | 23 +++ 2 files changed, 24 insertions(+) create mode 100644 arch/arm/cpu/pxa/relocate.S diff --git a/arch

[U-Boot] [PATCH] i2c: adding driver for pxa27x, pxa3xx, pxa25x

2015-08-12 Thread Andrew Ruder
Cc: Marek Vasut ma...@denx.de Cc: Heiko Schocher h...@denx.de Signed-off-by: Andrew Ruder andrew.ru...@elecsyscorp.com --- This driver was written before the driver model stuff was really around (or at least based on a U-Boot version that only had very preliminary support) so there might be some

[U-Boot] [PATCH V2 3/5] dm9000: Add struct eth_device * to SROM functions

2015-08-12 Thread Andrew Ruder
Currently this argument is not used. To eventually support multiple DM9000's these public-facing functions will need a new argument - the ethernet device. Fix-up the one board using this part of the DM9000 API. Compile-tested only. Signed-off-by: Andrew Ruder andrew.ru...@elecsyscorp.com Cc

[U-Boot] [PATCH V2 2/5] dm9000: mark dump_regs() function as unused

2015-08-12 Thread Andrew Ruder
-by: Andrew Ruder andrew.ru...@elecsyscorp.com Cc: Joe Hershberger joe.hershber...@gmail.com --- drivers/net/dm9000x.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/dm9000x.c b/drivers/net/dm9000x.c index 415c4b7..258c8a3 100644 --- a/drivers/net/dm9000x.c +++ b

[U-Boot] [PATCH] arm: pxa: use common timer functions

2015-08-12 Thread Andrew Ruder
. If get_ticks() + tmo in __udelay() crossed the 32-bit boundary, the while condition became unconditionally true and locked the processor. Rather than patch the specific pxa issues, simply move everything over to the common code. Signed-off-by: Andrew Ruder andrew.ru...@elecsyscorp.com Cc: Marek

Re: [U-Boot] [PATCH V2 0/5] DM9000 support for multiple interfaces

2015-08-12 Thread Andrew Ruder
On 08/12/2015 12:24 PM, Andrew Ruder wrote: To maintain backwards compatibility with older board files, we add a new initialize function taking the io address, data address, and availability of a SROM chip. The old initialize function is now a shim around this new initialize function

Re: [U-Boot] [PATCH 3/3 V2] dm9000: rework dm9000 to support multiple devices

2015-08-11 Thread Andrew Ruder
On 08/11/2015 12:58 PM, Joe Hershberger wrote: What ever became of this series? I failed to ever email it in... I have a redone series, let me clean it up and give it a quick test and make sure it works on latest... Needed to rebase on about 10 months of upstream.

Re: [U-Boot] [PATCH] ubi: reset relevant globals in ubi_exit()

2014-11-14 Thread Andrew Ruder
On 11/14/2014 12:20 AM, Heiko Schocher wrote: Good catch, but wondering, why this not poped up in my tests, as I did such a test ... Are you on 2014.10? I don't think this issue existed on the 2014.07-rc3 I was using earlier. - Andy ___ U-Boot

[U-Boot] [PATCH] ubi: reset relevant globals in ubi_exit()

2014-11-13 Thread Andrew Ruder
UBI: attaching mtd1 to ubi0 UBI: scanning is finished UBI: attached mtd1 (name mtd=4, size 4 MiB) to ubi0 [...] UBI: available PEBs: 0, total reserved PEBs: 32, [...] $ Signed-off-by: Andrew Ruder andrew.ru...@elecsyscorp.com Cc: Heiko Schocher h...@denx.de Cc: Kyungmin Park kmp...@infradead.org

Re: [U-Boot] [PATCH 1/2] ubi: enable error reporting in initialization

2014-11-05 Thread Andrew Ruder
On Wed, Nov 05, 2014 at 07:57:27AM +0100, Heiko Schocher wrote: The problem is in generally enabling this feature in the size impact ... This should be discussed if we want this for all boards ... This change actually only triggers a few changes that affect whether or not ubi_init() returns

Re: [U-Boot] [PATCH v2] mtd, cfi, ubi: add missing writebufsize initialization

2014-11-05 Thread Andrew Ruder
On Fri, Oct 31, 2014 at 11:29:45AM +0100, Heiko Schocher wrote: diff --git a/drivers/mtd/cfi_mtd.c b/drivers/mtd/cfi_mtd.c index ac805ff..709a486 100644 --- a/drivers/mtd/cfi_mtd.c +++ b/drivers/mtd/cfi_mtd.c @@ -226,6 +226,7 @@ int cfi_mtd_init(void) mtd-flags =

Re: [U-Boot] [PATCH 2/2] mtd: nor: initialize writebufsize field

2014-11-05 Thread Andrew Ruder
On Wed, Nov 05, 2014 at 08:00:21AM +0100, Heiko Schocher wrote: diff --git a/drivers/mtd/cfi_mtd.c b/drivers/mtd/cfi_mtd.c index ac805ff..d4c9609 100644 --- a/drivers/mtd/cfi_mtd.c +++ b/drivers/mtd/cfi_mtd.c @@ -226,6 +226,7 @@ int cfi_mtd_init(void) mtd-flags =

[U-Boot] [PATCH v2] ubi: enable error reporting in initialization

2014-11-05 Thread Andrew Ruder
are building as a module. Signed-off-by: Andrew Ruder andrew.ru...@elecsyscorp.com Cc: Wolfgang Denk w...@denx.de Cc: Heiko Schocher h...@denx.de Cc: Kyungmin Park kmp...@infradead.org --- include/ubi_uboot.h | 8 1 file changed, 8 insertions(+) diff --git a/include/ubi_uboot.h b/include

Re: [U-Boot] [PATCH v2] mtd, cfi, ubi: add missing writebufsize initialization

2014-11-05 Thread Andrew Ruder
On Wed, Nov 05, 2014 at 01:20:00PM -0600, Andrew Ruder wrote: I'm just not sure it really matters. That being said: Acked-by: Andrew Ruder andrew.ru...@elecsyscorp.com Cheers :), Andy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de

[U-Boot] [PATCH 2/2] mtd: nor: initialize writebufsize field

2014-11-04 Thread Andrew Ruder
UBI drivers error out if writebufsize is not filled in correctly. Grab this information from the CFI flash_info struct. Signed-off-by: Andrew Ruder andrew.ru...@elecsyscorp.com Cc: Wolfgang Denk w...@denx.de Cc: Heiko Schocher h...@denx.de Cc: Stefan Roese s...@denx.de --- drivers/mtd/cfi_mtd.c

[U-Boot] [PATCH 1/2] ubi: enable error reporting in initialization

2014-11-04 Thread Andrew Ruder
are building as a module. Signed-off-by: Andrew Ruder andrew.ru...@elecsyscorp.com Cc: Wolfgang Denk w...@denx.de Cc: Heiko Schocher h...@denx.de Cc: Kyungmin Park kmp...@infradead.org --- include/ubi_uboot.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/ubi_uboot.h b/include/ubi_uboot.h

[U-Boot] Regression with ubifs initialization

2014-10-27 Thread Andrew Ruder
Hey all, It appears that 2014.10 has some issues with UBIFS initialization (details at bottom). git-bisect results in one of the following commits being broken. Surely it is the mtd one, but its parent commit (compat.h) does not compile. [ff94bc40af3] mtd, ubi, ubifs: resync with Linux-3.14

Re: [U-Boot] Regression with ubifs initialization

2014-10-27 Thread Andrew Ruder
On Mon, Oct 27, 2014 at 03:33:00PM +0100, Wolfgang Denk wrote: It appears that 2014.10 has some issues with UBIFS initialization (details at bottom). git-bisect results in one of the following commits being broken. Surely it is the mtd one, but its parent commit (compat.h) does not

Re: [U-Boot] Regression with ubifs initialization

2014-10-27 Thread Andrew Ruder
On Mon, Oct 27, 2014 at 09:45:16AM -0500, Andrew Ruder wrote: On Mon, Oct 27, 2014 at 03:33:00PM +0100, Wolfgang Denk wrote: It appears that 2014.10 has some issues with UBIFS initialization (details at bottom). git-bisect results in one of the following commits being broken. Surely

[U-Boot] [PATCH 0/3] DM9000 support for multiple interfaces

2014-10-20 Thread Andrew Ruder
compile-tested this on all the arm-based boards. Cc: Joe Hershberger joe.hershber...@gmail.com Andrew Ruder (3): dm9000: mark dump_regs() function as unused dm9000: Add struct eth_device * to SROM functions dm9000: rework dm9000 to support multiple devices board/trizepsiv/eeprom.c | 5

[U-Boot] [PATCH 2/3] dm9000: Add struct eth_device * to SROM functions

2014-10-20 Thread Andrew Ruder
Currently this argument is not used. To eventually support multiple DM9000's these public-facing functions will need a new argument - the ethernet device. Fix-up the one board using this part of the DM9000 API. Compile-tested only. Signed-off-by: Andrew Ruder andrew.ru...@elecsyscorp.com Cc

[U-Boot] [PATCH 1/3] dm9000: mark dump_regs() function as unused

2014-10-20 Thread Andrew Ruder
-by: Andrew Ruder andrew.ru...@elecsyscorp.com Cc: Joe Hershberger joe.hershber...@gmail.com --- drivers/net/dm9000x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dm9000x.c b/drivers/net/dm9000x.c index 4de9d41..50a36f3 100644 --- a/drivers/net/dm9000x.c +++ b

[U-Boot] [PATCH 3/3] dm9000: rework dm9000 to support multiple devices

2014-10-20 Thread Andrew Ruder
affecting all chips: CONFIG_DM9000_BYTE_SWAPPED And the following has been removed entirely: CONFIG_DM9000_BASE (was only used in a single printf) Signed-off-by: Andrew Ruder andrew.ru...@elecsyscorp.com Cc: Joe Hershberger joe.hershber...@gmail.com --- drivers/net/dm9000x.c | 378

Re: [U-Boot] [PATCH 3/3] dm9000: rework dm9000 to support multiple devices

2014-10-20 Thread Andrew Ruder
This one triggered a whole bunch of check-patch issues that I need to clean-up mostly due to dm9000x.c not originally meeting all of the coding conventions. I'll send a V2 of this momentarily. - Andy ___ U-Boot mailing list U-Boot@lists.denx.de

[U-Boot] [PATCH 3/3 V2] dm9000: rework dm9000 to support multiple devices

2014-10-20 Thread Andrew Ruder
affecting all chips: CONFIG_DM9000_BYTE_SWAPPED And the following has been removed entirely: CONFIG_DM9000_BASE (was only used in a single printf) Signed-off-by: Andrew Ruder andrew.ru...@elecsyscorp.com Cc: Joe Hershberger joe.hershber...@gmail.com --- Maybe a useful exercise anyway

Re: [U-Boot] [PATCH 2/3] dm9000: Add struct eth_device * to SROM functions

2014-10-20 Thread Andrew Ruder
On Mon, Oct 20, 2014 at 03:17:13PM -0400, Tom Rini wrote: You shouldn't have to add this to avoid a warning I think. And frankly, if it does for some reason since 3/3 makes use of dev, I'm OK with a bisect adding a trivial warning like this, rather than do compiler games. Fair enough, the

Re: [U-Boot] [PATCH 3/3 V2] dm9000: rework dm9000 to support multiple devices

2014-10-20 Thread Andrew Ruder
On 10/20/2014 03:00 PM, Tom Rini wrote: So, on new platforms we call dm9000_initialize with the right IO/DATA locations for the given device, yes? I think I'd rather update everyone else to call things the right and new way, rather than work-around supporting both. The expectation is that

[U-Boot] [PATCH v2] arm: pxa: use common timer functions

2014-10-09 Thread andrew . ruder
From: Andrew Ruder andrew.ru...@elecsyscorp.com This patch moves pxa to the common timer functions added in commit 8dfafdd - Introduce common timer functions Rob Herring The (removed) pxa timer code (specifically __udelay()) could deadlock at the 32-bit boundary of get_ticks(). get_ticks

[U-Boot] [PATCH v2] arm: pxa: use common timer functions

2014-10-09 Thread Andrew Ruder
. If get_ticks() + tmo in __udelay() crossed the 32-bit boundary, the while condition became unconditionally true and locked the processor. Rather than patch the specific pxa issues, simply move everything over to the common code. Signed-off-by: Andrew Ruder andrew.ru...@elecsyscorp.com Cc: Marek

Re: [U-Boot] [PATCH v2] arm: pxa: use common timer functions

2014-10-09 Thread Andrew Ruder
Please ignore this one as it has the messed up From: line without the author name. Sorry for the noise. - Andy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [U-Boot,1/3] arm: pxa: use common timer functions

2014-09-16 Thread Andrew Ruder
On 08/30/2014 10:13 AM, Tom Rini wrote: As it stands today this breaks building a number of PXA boards so it needs to be picked up and re-worked / build tested, thanks! I'm still planning on getting back to this and taking a look. At the time I was on a slightly older version of U-Boot

[U-Boot] [PATCH 2/3] arm: mx31: use common timer functions

2014-08-12 Thread andrew . ruder
From: Andrew Ruder andrew.ru...@elecsyscorp.com This patch moves mx31 to the common timer functions added in commit 8dfafdd - Introduce common timer functions Rob Herring The (removed) mx31 timer code (specifically __udelay()) could deadlock at the 32-bit boundary of get_ticks(). get_ticks

[U-Boot] [PATCH 1/3] arm: pxa: use common timer functions

2014-08-12 Thread andrew . ruder
From: Andrew Ruder andrew.ru...@elecsyscorp.com This patch moves pxa to the common timer functions added in commit 8dfafdd - Introduce common timer functions Rob Herring The (removed) pxa timer code (specifically __udelay()) could deadlock at the 32-bit boundary of get_ticks(). get_ticks

[U-Boot] [PATCH 0/3] Initial cleanup of arm port timer subsystem

2014-08-12 Thread andrew . ruder
From: Andrew Ruder andrew.ru...@elecsyscorp.com Hey all, Was tracking down an issue on a PXA270 based board where a long y-modem transfer would frequently deadlock the board in the middle of the transfer. Unfortunately I felt like I had opened pandora's box by looking around at other ports

[U-Boot] [PATCH 3/3] arm: mx35: use common timer functions

2014-08-12 Thread andrew . ruder
From: Andrew Ruder andrew.ru...@elecsyscorp.com This patch moves mx35 to the common timer functions added in commit 8dfafdd - Introduce common timer functions Rob Herring The (removed) mx35 timer code (specifically __udelay()) could deadlock at the 32-bit boundary of get_ticks(). get_ticks

[U-Boot] [PATCH v2] spi: soft_spi: Support NULL din/dout buffers

2014-04-25 Thread Andrew Ruder
== NULL case, the received data is simply not stored. In the dout == NULL case, zeroes are transmitted. Signed-off-by: Andrew Ruder andrew.ru...@elecsyscorp.com Cc: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com Cc: Jagan Teki jagannadh.t...@gmail.com --- Cleaned up errors/warnings from

[U-Boot] [PATCH RESEND-WITH-JUSTIFICATION] spi: soft_spi: Support NULL din/dout buffers

2014-04-10 Thread Andrew Ruder
== NULL case, the received data is simply not stored. In the dout == NULL case, zeroes are transmitted. Signed-off-by: Andrew Ruder andrew.ru...@elecsyscorp.com Cc: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com Cc: Jagan Teki jagannadh.t...@gmail.com --- So going through and cleaning up

Re: [U-Boot] [PATCH RESEND-WITH-JUSTIFICATION] spi: soft_spi: Support NULL din/dout buffers

2014-04-10 Thread Andrew Ruder
I further justify this with a list of drivers that depend on half-duplex SPI operation: drivers/mmc/mmc_spi.c: spi_xfer(spi, 2 * 8, tok, NULL, 0); drivers/mtd/spi/eeprom_m95xxx.c:if (spi_xfer(slave, 8, buf, NULL, SPI_XFER_BEGIN | SPI_XFER_END)) drivers/mtd/spi/sf_ops.c:

Re: [U-Boot] [PATCH RESEND-WITH-JUSTIFICATION] spi: soft_spi: Support NULL din/dout buffers

2014-04-10 Thread Andrew Ruder
On Fri, Apr 11, 2014 at 12:24:20AM +0530, Jagan Teki wrote: At-least from zynq_spi.c case - I wouldn't find that obscure case as you pointed and even with dout NULL which is status poll from (sf_ops.c). zynq_spi is correct, soft_spi is not. zynq_spi.c: int spi_xfer(struct spi_slave *slave,

Re: [U-Boot] [PATCH RESEND-WITH-JUSTIFICATION] spi: soft_spi: Support NULL din/dout buffers

2014-04-10 Thread Andrew Ruder
On Fri, Apr 11, 2014 at 12:33:45AM +0530, Jagan Teki wrote: It would be great if you mentioned issue scenario for status poll case drivers/mtd/spi/sf_ops.c: ret = spi_xfer(spi, 8, NULL, status, 0); OK - means issue only with soft_spi.c is it? Yes, and a couple other drivers.

Re: [U-Boot] ARM: interrupt_init before relocation, write fails

2013-10-24 Thread Andrew Ruder
On Wed, Oct 23, 2013 at 11:41:45AM -0600, Joe Kulikauskas wrote: If I revert that patch, I don't see that problem. FWIW, I am working on a PXA270 target, and have had to revert this patch as well. I hadn't gotten around to tracking down where and why I was crashing though so hadn't emailed in a

Re: [U-Boot] [PATCH] cmd_nvedit.c: Add env exists command

2013-10-23 Thread Andrew Ruder
On Wed, Oct 23, 2013 at 06:55:02AM -0700, James Chargin wrote: I have, more recently, been using scripting of the form if test X != X${var}; then echo defined else echo undefined fi Thanks for the feedback. I was attempting to do something

[U-Boot] [PATCH] net: tftpsrv: Get correct client MAC address

2013-10-22 Thread Andrew Ruder
with host ip address By clearing NetServerEther, we force a lookup of the host MAC address to go with the associated host IP. Signed-off-by: Andrew Ruder andrew.ru...@elecsyscorp.com --- net/tftp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/tftp.c b/net/tftp.c index 6d333d5..002052a

[U-Boot] [PATCH] cmd_nvedit.c: Add env exists command

2013-10-22 Thread Andrew Ruder
$ env exists testexists || echo no $ set testexists $ env exists testexists echo yes $ env exists testexists || echo no no $ Signed-off-by: Andrew Ruder andrew.ru...@elecsyscorp.com --- README | 1 + common/cmd_nvedit.c | 23 +++ 2 files changed, 24 insertions

[U-Boot] [PATCH] spi: soft_spi: Support NULL din/dout buffers

2013-10-22 Thread Andrew Ruder
== NULL case, the received data is simply not stored. In the dout == NULL case, zeroes are transmitted. Signed-off-by: Andrew Ruder andrew.ru...@elecsyscorp.com --- drivers/spi/soft_spi.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/spi

[U-Boot] [PATCH] net: dm9000: random mac address support

2013-10-22 Thread Andrew Ruder
until a real MAC address can be configured. Signed-off-by: Andrew Ruder andrew.ru...@elecsyscorp.com --- drivers/net/dm9000x.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/dm9000x.c b/drivers/net/dm9000x.c index f7170e0..b68d808 100644 --- a/drivers/net/dm9000x.c +++ b