Re: [PATCH 08/16] edison: Remove empty config header

2024-01-28 Thread Andy Shevchenko
On Mon, Jan 22, 2024 at 05:39:12PM -0500, Tom Rini wrote: > Now that we support having CONFIG_SYS_CONFIG_NAME be unset to indicate a > lack of board.h file, unset this on the edison platform and remove > the otherwise empty file. Acked-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko

Re: [PATCH v2 1/4] acpi: fix FADT table

2023-12-15 Thread Andy Shevchenko
field DSDT must be ignored. We should not fill > unused fields. ... > v2: > no change Have you seen my email? -- With Best Regards, Andy Shevchenko

Re: [PATCH 3/3] cmd: acpi: check HW reduced flag in acpi list

2023-12-15 Thread Andy Shevchenko
ects into account. But since it doesn't affect my area of interest in U-Boot, I won't prevent you from doing this way, it's up to the U-Boot maintainers how to proceed with it. -- With Best Regards, Andy Shevchenko

Re: [PATCH 1/3] acpi: fix FADT table

2023-12-15 Thread Andy Shevchenko
field DSDT must be ignored. We should not fill > unused fields. Is it dictated by the specifications? Please, put the reference here in the commit message (section X.Y.Z "Goo bar"). ... >From code perspective LGTM. -- With Best Regards, Andy Shevchenko

Re: Setting up boot chain ACPI on ARM with STM32MPU

2023-11-29 Thread Andy Shevchenko
On Wed, Nov 29, 2023 at 6:25 PM Andy Shevchenko wrote: > On Wed, Nov 29, 2023 at 5:29 PM Ba Gia Bao Phan > wrote: > > > > Hello everyone, > > > > I am a trainee at STMicroelectronics France. I am working on a project > > "Setting up a boot chain ACPI&qu

Re: Setting up boot chain ACPI on ARM with STM32MPU

2023-11-29 Thread Andy Shevchenko
> if it functioned or not. Did anyone here succeed in setting up ACPI on ARM by > U-boot? > > What are the differences between x86 and ARM platforms when enabling ACPI? > The architecture of my board STM32PMU is ARM so can I apply the technique > used on platform x86 for my board? -- With Best Regards, Andy Shevchenko

Re: [PATCH v1 1/1] Makefile.lib: Always rebuild DSDT

2023-11-29 Thread Andy Shevchenko
On Wed, Mar 30, 2022 at 12:21:25PM +0300, Andy Shevchenko wrote: > On Mon, Oct 25, 2021 at 09:52:45PM +0300, Andy Shevchenko wrote: > > On Mon, Oct 25, 2021 at 09:18:56AM -0600, Simon Glass wrote: > > > On Mon, 25 Oct 2021 at 01:34, Andy Shevchenko > > > wrote: > &g

Re: [PATCH v3 2/2] cmd: acpi: fix acpi list command

2023-11-20 Thread Andy Shevchenko
On Mon, Nov 20, 2023 at 01:34:22PM +0100, Heinrich Schuchardt wrote: > On 11/20/23 12:28, Andy Shevchenko wrote: > > On Sat, Nov 18, 2023 at 11:52:48PM +0100, Heinrich Schuchardt wrote: ... > > (Side question: Do you use --histogram when preparing patches? if no, try >

Re: [PATCH v3 2/2] cmd: acpi: fix acpi list command

2023-11-20 Thread Andy Shevchenko
tmp = rsdt->entry[i]; if (!tmp) break; hdr = map_sysmem(tmp, 0); -- With Best Regards, Andy Shevchenko

Re: [PATCH v2 1/2] Reland "x86: Move FACP table into separate functions""

2023-08-31 Thread Andy Shevchenko
> Signed-off-by: Simon Glass > Signed-off-by: Andy Shevchenko Not sure this is correct SoB chain. In kernel project we would do Co-developed-by: Andy Shevchenko Signed-off-by: Andy Shevchenko Signed-off-by: Simon Glass > --- > (Now fixed - thank you Andy!) Right, Tested-by: Andy Sh

Re: [PATCH v1 2/2] x86: Prevent from missing the FADT chaining

2023-08-25 Thread Andy Shevchenko
On Fri, Aug 25, 2023 at 04:51:41PM +0300, Andy Shevchenko wrote: ... > +static inline int acpi_add_fadt(struct acpi_ctx *ctx, struct acpi_fadt *fadt) > +{ > + acpi_add_table(ctx, fadt); > + acpi_inc(ctx, sizeof(struct acpi_fadt)); > + return 0; > +} Ideally

[PATCH v1 2/2] x86: Prevent from missing the FADT chaining

2023-08-25 Thread Andy Shevchenko
Recent approach with FADT writer shows that there is a room for subtle errors. Prevent this from happening again by introducing acpi_add_fadt() helper. Signed-off-by: Andy Shevchenko --- arch/x86/cpu/apollolake/acpi.c | 6 +- arch/x86/cpu/baytrail/acpi.c | 6 +- arch/x86/cpu/quark

[PATCH v1 1/2] TO BE FOLDED: x86: tangier: Add FADT to the chain

2023-08-25 Thread Andy Shevchenko
The Simon's patch missed the FADT to be added to the chain, hence all the issues on Intel Tangier. Signed-off-by: Andy Shevchenko --- arch/x86/cpu/tangier/acpi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/cpu/tangier/acpi.c b/arch/x86/cpu/tangier/acpi.c index 01b30553818c

Re: [PATCH 1/2] Reland "x86: Move FACP table into separate functions""

2023-08-25 Thread Andy Shevchenko
On Fri, Aug 25, 2023 at 04:25:29PM +0300, Andy Shevchenko wrote: > On Fri, Aug 25, 2023 at 04:17:58PM +0300, Andy Shevchenko wrote: > > On Fri, Aug 25, 2023 at 02:06:34PM +0300, Andy Shevchenko wrote: > > > On Thu, Aug 24, 2023 at 12:23:32PM -0600, Simon Glass wrote: > > &g

Re: [PATCH 1/2] Reland "x86: Move FACP table into separate functions""

2023-08-25 Thread Andy Shevchenko
On Fri, Aug 25, 2023 at 04:17:58PM +0300, Andy Shevchenko wrote: > On Fri, Aug 25, 2023 at 02:06:34PM +0300, Andy Shevchenko wrote: > > On Thu, Aug 24, 2023 at 12:23:32PM -0600, Simon Glass wrote: > > > Each board has its own way of creating this table. R

Re: [PATCH 1/2] Reland "x86: Move FACP table into separate functions""

2023-08-25 Thread Andy Shevchenko
On Fri, Aug 25, 2023 at 02:06:34PM +0300, Andy Shevchenko wrote: > On Thu, Aug 24, 2023 at 12:23:32PM -0600, Simon Glass wrote: > > Each board has its own way of creating this table. Rather than calling the > > acpi_create_fadt() function for each one from a common acpi_write_fadt

Re: [PATCH 1/2] Reland "x86: Move FACP table into separate functions""

2023-08-25 Thread Andy Shevchenko
On Fri, Aug 25, 2023 at 02:10:05PM +0300, Andy Shevchenko wrote: > On Fri, Aug 25, 2023 at 02:06:34PM +0300, Andy Shevchenko wrote: > > On Thu, Aug 24, 2023 at 12:23:32PM -0600, Simon Glass wrote: > > > Each board has its own way of creating this table. R

Re: [PATCH 1/2] Reland "x86: Move FACP table into separate functions""

2023-08-25 Thread Andy Shevchenko
On Fri, Aug 25, 2023 at 02:06:34PM +0300, Andy Shevchenko wrote: > On Thu, Aug 24, 2023 at 12:23:32PM -0600, Simon Glass wrote: > > Each board has its own way of creating this table. Rather than calling the > > acpi_create_fadt() function for each one from a common acpi_write_fadt

Re: [PATCH 1/2] Reland "x86: Move FACP table into separate functions""

2023-08-25 Thread Andy Shevchenko
ut I have a bit of time to debug more. -- With Best Regards, Andy Shevchenko

Re: [PATCH 00/22] x86: Move some boards to text environment

2023-08-07 Thread Andy Shevchenko
On Mon, Aug 07, 2023 at 03:30:25PM +0200, Michael Nazzareno Trimarchi wrote: > On Mon, Aug 7, 2023 at 3:04 PM Andy Shevchenko > wrote: > > On Mon, Aug 07, 2023 at 02:44:31PM +0200, Michael Nazzareno Trimarchi wrote: > > > Hi Pali > > > > > >

Re: [PATCH 00/22] x86: Move some boards to text environment

2023-08-07 Thread Andy Shevchenko
; > I can see the philosophy was that someone who touched the changed file > > > should be copied for review. > > > We certainly could argue that and just get the list solely from the > > > MAINTAINERS file. > > > > > > Regards, > > > Bin > > > > -- > Michael Nazzareno Trimarchi > Co-Founder & Chief Executive Officer > M. +39 347 913 2170 > mich...@amarulasolutions.com > __ > > Amarula Solutions BV > Joop Geesinkweg 125, 1114 AB, Amsterdam, NL > T. +31 (0)85 111 9172 > i...@amarulasolutions.com > www.amarulasolutions.com -- With Best Regards, Andy Shevchenko

Re: [PATCH 00/22] x86: Move some boards to text environment

2023-07-31 Thread Andy Shevchenko
eries. Patch wise it looks good to me Reviewed-by: Andy Shevchenko # Intel Edison Where can I read about this new edison.env file and what is expected to be there? > doc: Explain how to avoid the distro-boot scripts > env: Use include/env for text-environment includes > env: Explai

Re: [PATCH v2] IOMUX: Fix access past end of console_devices

2022-04-07 Thread Andy Shevchenko
but putting the > assignment in the loop condition allows us to ensure that i is checked > beforehand. This isn't a bug, but it does make valgrind stop complaining. Acked-by: Andy Shevchenko > Fixes: 400797cad3 ("IOMUX: Split out for_each_console_dev() helper macro") > Signed

Re: [PATCH] IOMUX: Fix access past end of console_devices

2022-03-31 Thread Andy Shevchenko
On Wed, Mar 30, 2022 at 01:25:59PM -0400, Sean Anderson wrote: > On 3/30/22 1:13 PM, Andy Shevchenko wrote: > > On Wed, Mar 30, 2022 at 7:49 PM Sean Anderson wrote: > > > > Also I don't like to have workarounds for the broken tools. > > But if you still want to have s

Re: [PATCH] IOMUX: Fix access past end of console_devices

2022-03-30 Thread Andy Shevchenko
\ i++, dev = console_devices[file][i]) ? -- With Best Regards, Andy Shevchenko

Re: [PATCH] IOMUX: Fix access past end of console_devices

2022-03-30 Thread Andy Shevchenko
On Wed, Mar 30, 2022 at 8:05 PM Sean Anderson wrote: > On 3/30/22 1:01 PM, Andy Shevchenko wrote: > > On Wed, Mar 30, 2022 at 7:49 PM Sean Anderson wrote: ... > >> #define for_each_console_dev(i, file, dev) \ > >> - for (i = 0, de

Re: [PATCH] IOMUX: Fix access past end of console_devices

2022-03-30 Thread Andy Shevchenko
On Wed, Mar 30, 2022 at 8:01 PM Andy Shevchenko wrote: > On Wed, Mar 30, 2022 at 7:49 PM Sean Anderson wrote: ... > > #define for_each_console_dev(i, file, dev) \ > > - for (i = 0, dev = console_devices[file][i]; \ > > When we enter the loop

Re: [PATCH] IOMUX: Fix access past end of console_devices

2022-03-30 Thread Andy Shevchenko
es[file][i]) > + for (i = 0; i < cd_count[file] && \ Not the case anymore. > + (dev = console_devices[file][i]); i++) -- With Best Regards, Andy Shevchenko

[PATCH v1 1/1] Revert "x86: Move FACP table into separate functions"

2022-03-30 Thread Andy Shevchenko
INTL 0 As a result Linux kernel can't find mandatory tables and fails to boot. Hence, revert it for good. This reverts commit 379d3c1fd6aa490b1ad5697525cfc89b615cf25a. BugLink: https://lore.kernel.org/all/20220131225930.GJ7515@bill-the-cat/ Signed-off-by: Andy Shevchenko --- arch/x86/cpu/apol

Re: [ANN] U-Boot v2022.04-rc1 released

2022-03-30 Thread Andy Shevchenko
On Sat, Feb 12, 2022 at 05:02:00PM +0200, Andy Shevchenko wrote: > On Fri, Feb 11, 2022 at 9:15 PM Andy Shevchenko > wrote: > > On Fri, Feb 11, 2022 at 8:46 PM Andy Shevchenko > > wrote: > > > On Fri, Feb 11, 2022 at 8:31 PM Andy Shevchenko > > > wrote: &

Re: [PATCH v1 1/2] hexdump: Introduce debug APIs

2022-03-30 Thread Andy Shevchenko
On Sat, Nov 13, 2021 at 11:14:28AM -0700, Simon Glass wrote: > On Tue, 9 Nov 2021 at 05:03, Andy Shevchenko > wrote: > > > > debug_hex_dump() and debug_hex_dump_bytes() conditionally print > > the dump based on DEBUG definition. > > > > Signed-off-by: A

[PATCH v1 1/1] Makefile.lib: Re-use $(UBOOTINCLUDE) in dtc_cpp_flags

2022-03-30 Thread Andy Shevchenko
As in ASL case use same basic set of the inclusions. Signed-off-by: Andy Shevchenko --- scripts/Makefile.lib | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index c14da10de780..2ff39d39dc8a 100644 --- a/scripts/Makefile.lib

Re: [ANN] U-Boot v2022.04-rc5 released

2022-03-30 Thread Andy Shevchenko
th 2022. > Thanks all! What is the status of the ACPI series that broke at least Edison at rc1 time? Simon never returned to me with answers to my questions. P.S. I'll re-test today rc5. -- With Best Regards, Andy Shevchenko

Re: [PATCH v1 1/1] Makefile.lib: Always rebuild DSDT

2022-03-30 Thread Andy Shevchenko
On Mon, Oct 25, 2021 at 09:52:45PM +0300, Andy Shevchenko wrote: > On Mon, Oct 25, 2021 at 09:18:56AM -0600, Simon Glass wrote: > > On Mon, 25 Oct 2021 at 01:34, Andy Shevchenko > > wrote: > > > On Sun, Oct 24, 2021 at 11:00 PM Simon Glass wrote: > > > >

Re: [ANN] U-Boot v2022.04-rc1 released

2022-03-30 Thread Andy Shevchenko
On Fri, Feb 11, 2022 at 09:54:38PM +0200, Andy Shevchenko wrote: > On Fri, Feb 11, 2022 at 09:47:52PM +0200, Andy Shevchenko wrote: > > On Fri, Feb 11, 2022 at 12:31:46PM -0700, Simon Glass wrote: > > > On Fri, 11 Feb 2022 at 12:29, Andy Shevchenko > > > wrote: > &

[PATCH v1 1/1] efi_loader: initrddump: Actually use the custom CFLAGS

2022-03-30 Thread Andy Shevchenko
: relocation in read-only section `.text.efi_main' ld.bfd: warning: creating DT_TEXTREL in a shared object Remove wrong 'exit' suffix from the custom CFLAGS variable. Fixes: 65ab48d69ddb ("efi_selftest: provide initrddump test tool") Signed-off-by: Andy Shevchenko --- lib/efi_loader/Makefile

Re: [ANN] U-Boot v2022.04-rc1 released

2022-02-12 Thread Andy Shevchenko
On Fri, Feb 11, 2022 at 9:15 PM Andy Shevchenko wrote: > On Fri, Feb 11, 2022 at 8:46 PM Andy Shevchenko > wrote: > > On Fri, Feb 11, 2022 at 8:31 PM Andy Shevchenko > > wrote: > > > On Mon, Jan 31, 2022 at 05:59:30PM -0500, Tom Rini wrot

Re: [ANN] U-Boot v2022.04-rc1 released

2022-02-11 Thread Andy Shevchenko
On Fri, Feb 11, 2022 at 09:47:52PM +0200, Andy Shevchenko wrote: > On Fri, Feb 11, 2022 at 12:31:46PM -0700, Simon Glass wrote: > > On Fri, 11 Feb 2022 at 12:29, Andy Shevchenko > > wrote: > > > On Fri, Feb 11, 2022 at 9:26 PM Simon Glass wrote: ... > > > To

Re: [ANN] U-Boot v2022.04-rc1 released

2022-02-11 Thread Andy Shevchenko
On Fri, Feb 11, 2022 at 09:47:52PM +0200, Andy Shevchenko wrote: > On Fri, Feb 11, 2022 at 12:31:46PM -0700, Simon Glass wrote: > > On Fri, 11 Feb 2022 at 12:29, Andy Shevchenko > > wrote: > > > On Fri, Feb 11, 2022 at 9:26 PM Simon Glass wrote: > > > >

Re: [ANN] U-Boot v2022.04-rc1 released

2022-02-11 Thread Andy Shevchenko
On Fri, Feb 11, 2022 at 12:31:46PM -0700, Simon Glass wrote: > On Fri, 11 Feb 2022 at 12:29, Andy Shevchenko > wrote: > > On Fri, Feb 11, 2022 at 9:26 PM Simon Glass wrote: > > > On Fri, 11 Feb 2022 at 11:28, Andy Shevchenko > > > wrote: > > > > On

Re: [ANN] U-Boot v2022.04-rc1 released

2022-02-11 Thread Andy Shevchenko
On Fri, Feb 11, 2022 at 9:26 PM Simon Glass wrote: > On Fri, 11 Feb 2022 at 11:28, Andy Shevchenko > wrote: > > On Mon, Jan 31, 2022 at 05:59:30PM -0500, Tom Rini wrote: ... > FWIW here is my tboot flash script for Edison: This is rather unbriking script, DFU (luckily) w

Re: [ANN] U-Boot v2022.04-rc1 released

2022-02-11 Thread Andy Shevchenko
On Fri, Feb 11, 2022 at 8:46 PM Andy Shevchenko wrote: > > On Fri, Feb 11, 2022 at 8:31 PM Andy Shevchenko > wrote: > > > > On Mon, Jan 31, 2022 at 05:59:30PM -0500, Tom Rini wrote: > > > Hey all, > > > > > > It's release day and so

Re: [ANN] U-Boot v2022.04-rc1 released

2022-02-11 Thread Andy Shevchenko
On Fri, Feb 11, 2022 at 8:31 PM Andy Shevchenko wrote: > > On Mon, Jan 31, 2022 at 05:59:30PM -0500, Tom Rini wrote: > > Hey all, > > > > It's release day and so here's v2022.04-rc1. While there's much in here > > that needed to come in, there's a few big

Re: [ANN] U-Boot v2022.04-rc1 released

2022-02-11 Thread Andy Shevchenko
ifield/BODEGA BAY, BIOS 542 2015.01.21:18.19.48 [0.857666] RIP: 0010:pci_read+0x47/0x80 ... Bisection started... Simon, can you prioritize setting up Edison to make it available for tests? -- With Best Regards, Andy Shevchenko

Re: [PATCH v3 1/2] binman: Do not pollute source tree when build with `make O=...`

2021-12-23 Thread Andy Shevchenko
is $(srctree), and creates cache just in the middle > > of the source tree. Move cache to the current directory. > > > > Signed-off-by: Andy Shevchenko > > --- > > v3: avoided crash (Simon), preserved tree hierarchy > > tools/binman/main.py | 13 - >

[PATCH v3 2/2] binman: Use less hard coded magic when inserting new PATH

2021-12-06 Thread Andy Shevchenko
Instead of joining hard coded '..' to the run-time path of the executable, take just a dirname out of it. Besides that, use $(srctree) where it makes sense. Signed-off-by: Andy Shevchenko --- v3: avoided crash (Simon), reused one level up folder variable tools/binman/main.py | 12

[PATCH v3 1/2] binman: Do not pollute source tree when build with `make O=...`

2021-12-06 Thread Andy Shevchenko
Importing libraries in Python caches the bytecode by default. Since we run scripts in source tree it ignores the current directory settings, which is $(srctree), and creates cache just in the middle of the source tree. Move cache to the current directory. Signed-off-by: Andy Shevchenko --- v3

Re: [PATCH v2 1/2] binman: Do not pollute source tree when build with `make O=...`

2021-12-06 Thread Andy Shevchenko
On Fri, Dec 03, 2021 at 10:29:10PM +0200, Andy Shevchenko wrote: > On Fri, Dec 03, 2021 at 01:13:12PM -0700, Simon Glass wrote: ... > Ah, you mean you run it manually and not via `make`. > > os.environ.get('srctree', '') > > should help I suppose. I haven't hear

Re: [PATCH v2 1/2] binman: Do not pollute source tree when build with `make O=...`

2021-12-03 Thread Andy Shevchenko
On Fri, Dec 03, 2021 at 01:13:12PM -0700, Simon Glass wrote: > On Fri, 3 Dec 2021 at 00:55, Andy Shevchenko > wrote: > > On Friday, December 3, 2021, Simon Glass wrote: > >> On Tue, 30 Nov 2021 at 12:04, Andy Shevchenko > >> wrote: ... > >> This loo

Re: [PATCH v2 1/2] binman: Do not pollute source tree when build with `make O=...`

2021-12-02 Thread Andy Shevchenko
On Friday, December 3, 2021, Simon Glass wrote: > Hi Andy, > > On Tue, 30 Nov 2021 at 12:04, Andy Shevchenko > wrote: > > > > Importing libraries in Python caches the bytecode by default. > > Since we run scripts in source tree it ignores the current directory &g

Re: [PATCH 00/40] RFC: rpi: Enable ACPI booting on ARM with Raspberry Pi 4

2021-12-01 Thread Andy Shevchenko
create mode 100644 board/raspberrypi/rpi/rpi4.dsc > create mode 100644 board/raspberrypi/rpi/sdhc.asl > create mode 100644 board/raspberrypi/rpi/spcrminiuart.aslc > create mode 100644 board/raspberrypi/rpi/spcrpl011.aslc > create mode 100644 board/raspberrypi/rpi/ssdtthermal.asl > create mode 100644 board/raspberrypi/rpi/uart.asl > create mode 100644 board/raspberrypi/rpi/xhci.asl > create mode 100644 doc/usage/acpi.rst > create mode 100644 lib/acpi/acpi_writer.c > create mode 100644 lib/acpi/base.c > create mode 100644 lib/acpi/csrt.c > create mode 100644 lib/acpi/dsdt.c > create mode 100644 lib/acpi/facs.c > create mode 100644 lib/acpi/ssdt.c > > -- > 2.34.0.rc2.393.gf8c9666880-goog > -- With Best Regards, Andy Shevchenko

Re: [PATCH 40/40] RFC: rpi: Enable booting with ACPI tables

2021-12-01 Thread Andy Shevchenko
pass `earlycon` to see if it gives anything. Nevertheless, I'm in favour of this series, thanks! For patches 21 and 27 (are they the only ones that touch tangier?) take my Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko

Re: [PATCH v1 1/1] binman: Do not pollute source tree when build with `make O=...`

2021-11-30 Thread Andy Shevchenko
On Tue, Nov 30, 2021 at 9:06 PM Tom Rini wrote: > On Tue, Nov 30, 2021 at 08:58:25PM +0200, Andy Shevchenko wrote: > > On Tue, Nov 30, 2021 at 8:52 PM Tom Rini wrote: > > > On Tue, Nov 30, 2021 at 09:42:04PM +0300, Andy Shevchenko wrote: > > > > +# > &g

[PATCH v2 1/2] binman: Do not pollute source tree when build with `make O=...`

2021-11-30 Thread Andy Shevchenko
Importing libraries in Python caches the bytecode by default. Since we run scripts in source tree it ignores the current directory settings, which is $(srctree), and creates cache just in the middle of the source tree. Move cache to the current directory. Signed-off-by: Andy Shevchenko --- v2

[PATCH v2 2/2] binman: Use less hard coded magic when inserting new PATH

2021-11-30 Thread Andy Shevchenko
Instead of joining hard coded '..' to the run-time path of the executable, take just a dirname out of it. Besides that, use $(srctree) where it makes sense. Signed-off-by: Andy Shevchenko --- v2: new patch tools/binman/main.py | 12 +++- 1 file changed, 7 insertions(+), 5 deletions

Re: [PATCH v1 1/1] binman: Do not pollute source tree when build with `make O=...`

2021-11-30 Thread Andy Shevchenko
On Tue, Nov 30, 2021 at 8:52 PM Tom Rini wrote: > On Tue, Nov 30, 2021 at 09:42:04PM +0300, Andy Shevchenko wrote: > > +# > > +# Do not pollute source tree with cache files: > > +# https://stackoverflow.com/a/60024195/2511795 > > +# https:/

[PATCH v1 1/1] binman: Do not pollute source tree when build with `make O=...`

2021-11-30 Thread Andy Shevchenko
Importing libraries in Python caches the bytecode by default. Since we run scripts in source tree it ignores the current directory settings, which is $(srctree), and creates cache just in the middle of the source tree. Move cache to the current directory. Signed-off-by: Andy Shevchenko

Re: ignore more files in Git?

2021-11-30 Thread Andy Shevchenko
On Tue, Nov 30, 2021 at 5:28 PM Andy Shevchenko wrote: > On Tue, Nov 30, 2021 at 3:23 PM Tom Rini wrote: > > On Tue, Nov 30, 2021 at 03:06:23PM +0200, Andy Shevchenko wrote: > > > > > Am I doing something wrong? > > > > > > $ git status --ignored >

Re: ignore more files in Git?

2021-11-30 Thread Andy Shevchenko
On Tue, Nov 30, 2021 at 3:23 PM Tom Rini wrote: > > On Tue, Nov 30, 2021 at 03:06:23PM +0200, Andy Shevchenko wrote: > > > Am I doing something wrong? > > > > $ git status --ignored > > On branch edison-acpi > > Your branch is up to date with 'gh-andy-s

ignore more files in Git?

2021-11-30 Thread Andy Shevchenko
tools/concurrencytest/__pycache__/ tools/dtoc/__pycache__/ tools/patman/__pycache__/ nothing to commit, working tree clean -- With Best Regards, Andy Shevchenko

Re: [PATCH v2 04/11] Convert CONFIG_PHYSMEM to Kconfig

2021-11-26 Thread Andy Shevchenko
On Thu, Nov 25, 2021 at 2:12 AM Simon Glass wrote: > On Wed, 24 Nov 2021 at 09:33, Andy Shevchenko > wrote: > > > > On Wed, Nov 24, 2021 at 6:28 PM Simon Glass wrote: > > > > > > This converts the following to Kconfig: > > >CONFIG_PHYSMEM >

Re: [PATCH v1 1/1] tools/netconsole: Add support for socat

2021-11-26 Thread Andy Shevchenko
On Fri, Nov 19, 2021 at 1:29 AM Ferry Toth wrote: > > Hi, > > Op 17-11-2021 om 18:15 schreef Andy Shevchenko: > > socat is a very powerful tool to work with socets (and not only) > > in UNIX systems. Let's add support for it in netconsole. > > > > Sign

Re: [PATCH v2 04/11] Convert CONFIG_PHYSMEM to Kconfig

2021-11-24 Thread Andy Shevchenko
t Regards, Andy Shevchenko

CONFIG_PHYSMEM subject to remove?

2021-11-19 Thread Andy Shevchenko
Hi! It seems that lib/physmem.c is either not used or used only by sandbox (not sure). Do we need CONFIG_PHYSMEM at all? Note x86 has its own implementation that is always present for all platforms. -- With Best Regards, Andy Shevchenko

[PATCH v1 1/1] tools/netconsole: Add support for socat

2021-11-17 Thread Andy Shevchenko
socat is a very powerful tool to work with socets (and not only) in UNIX systems. Let's add support for it in netconsole. Signed-off-by: Andy Shevchenko --- tools/netconsole | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/tools/netconsole b/tools/netconsole

Re: netconsole over USB net not working

2021-11-17 Thread Andy Shevchenko
On Wed, Nov 10, 2021 at 9:47 PM Andy Shevchenko wrote: > > Hi! > > What is the Best Known Method to enable NetConsole over USB ethernet > gadget on DWC3? Any insight anyone? v2022.01-rc2 behaves the same way. It was checked that in USB host mode and external card the netcons

Re: [PATCH v1 1/1] usb: doc: Fix spelling issues in README.usb

2021-11-12 Thread Andy Shevchenko
On Fri, Nov 12, 2021 at 5:44 PM Marek Vasut wrote: > On 11/12/21 4:37 PM, Andy Shevchenko wrote: > > Fix spelling issues in README.usb. > > I'll let Tom do expert review on this and pick it if that's fine. That will work for me, thanks! > btw as a separate patch, would you be

[PATCH v1 1/1] usb: doc: Fix spelling issues in README.usb

2021-11-12 Thread Andy Shevchenko
Fix spelling issues in README.usb. Signed-off-by: Andy Shevchenko --- doc/README.usb | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/doc/README.usb b/doc/README.usb index 05c62c3413c5..650a6daae0a5 100644 --- a/doc/README.usb +++ b/doc/README.usb

netconsole over USB net not working

2021-11-10 Thread Andy Shevchenko
serial function of the composite device. As of today not an option — it simply does not exist in the U-Boot. Anybody is working on that? -- With Best Regards, Andy Shevchenko

[PATCH v1 1/2] hexdump: Introduce debug APIs

2021-11-09 Thread Andy Shevchenko
debug_hex_dump() and debug_hex_dump_bytes() conditionally print the dump based on DEBUG definition. Signed-off-by: Andy Shevchenko --- include/hexdump.h | 4 lib/hexdump.c | 60 --- 2 files changed, 56 insertions(+), 8 deletions(-) diff

[PATCH v1 2/2] x86: scu: Add a few debug messages to the driver

2021-11-09 Thread Andy Shevchenko
For some devices that have slightly different firmware implementation it's good to see what's going on when communicating with the SCU. Add a few debug messages for that purpose. Signed-off-by: Andy Shevchenko --- arch/x86/lib/scu.c | 8 1 file changed, 8 insertions(+) diff --git

[PATCH v2 2/2] image: Explicitly declare do_bdinfo()

2021-11-08 Thread Andy Shevchenko
declaration to a header. Signed-off-by: Andy Shevchenko --- v2: dropped ifdeffery and extern (Simon), included header to the users common/image-board.c | 1 + common/image.c | 6 +- include/init.h | 2 ++ 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/common/image

[PATCH v2 1/2] image: Fix typo in boot_get_kbd()

2021-11-08 Thread Andy Shevchenko
[-Wreturn-type] 906 | } | ^ Fix obvious typo. Fixes: 4ed37abc49c2 ("image: Remove ifdefs around image_setup_linux() el at") Signed-off-by: Andy Shevchenko Reviewed-by: Simon Glass --- v2: added tag (Simon) common/image-board.c | 2 +- 1 file changed, 1 insertion(+), 1 del

Re: [PATCH v1 2/2] image: Explicitly declare do_bdinfo()

2021-11-08 Thread Andy Shevchenko
On Sun, Nov 7, 2021 at 6:43 PM Simon Glass wrote: > On Sat, 6 Nov 2021 at 01:59, Andy Shevchenko > wrote: > > On Saturday, November 6, 2021, Simon Glass wrote: > >> On Fri, 5 Nov 2021 at 14:10, Andy Shevchenko > >> wrote: > >> > > >> > Com

Re: [PATCH v1 2/2] image: Explicitly declare do_bdinfo()

2021-11-06 Thread Andy Shevchenko
On Saturday, November 6, 2021, Simon Glass wrote: > Hi Andy, > > On Fri, 5 Nov 2021 at 14:10, Andy Shevchenko > wrote: > > > > Compiler is not happy: > > > > common/image-board.c: In function ‘boot_get_kbd’: > > common/image-board.c:902:17: warning: imp

[PATCH v1 2/2] image: Explicitly declare do_bdinfo()

2021-11-05 Thread Andy Shevchenko
declaration to a header. Signed-off-by: Andy Shevchenko --- common/image.c | 5 - include/init.h | 5 + 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/common/image.c b/common/image.c index 3fa60b582796..57bf86278149 100644 --- a/common/image.c +++ b/common/image.c @@ -29,11

[PATCH v1 1/2] image: Fix typo in boot_get_kbd()

2021-11-05 Thread Andy Shevchenko
[-Wreturn-type] 906 | } | ^ Fix obvious typo. Fixes: 4ed37abc49c2 ("image: Remove ifdefs around image_setup_linux() el at") Signed-off-by: Andy Shevchenko Revert "image: Partially revert too aggressive ifdeferry removal" This reverts commit 84631af9d0454ff8252c1ae

[PATCH v1 1/2] x86: tangier: pinmux: Move is_protected assignment closer to its user

2021-10-27 Thread Andy Shevchenko
Move is_protected assignment closer to its user. This increases readability and makes maintenance easier. Signed-off-by: Andy Shevchenko --- arch/x86/cpu/tangier/pinmux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/x86/cpu/tangier/pinmux.c b/arch/x86/cpu/tangier

[PATCH v1 2/2] x86: tangier: pinmux: Move error message to the caller

2021-10-27 Thread Andy Shevchenko
Move error message to the caller of mrfld_pinconfig*() in order to unify them in the future. Signed-off-by: Andy Shevchenko --- arch/x86/cpu/tangier/pinmux.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/arch/x86/cpu/tangier/pinmux.c b/arch/x86/cpu/tangier

[PATCH v2 1/2] x86: tangier: Enable support for SD/SDIO family in the pinmux driver

2021-10-27 Thread Andy Shevchenko
We would need to quirk out the Card Detect case and for that we allow configuring the SD/SDIO family of pins. Signed-off-by: Andy Shevchenko Reviewed-by: Bin Meng --- v2: added tag, promised to deduplicate the code in the future (Bin) arch/x86/cpu/tangier/pinmux.c | 39

[PATCH v2 2/2] x86: edison: Don't take SD card detect pin into consideration

2021-10-27 Thread Andy Shevchenko
is always the same and inverted to what we are expecting in the code. BugLink: https://github.com/edison-fw/meta-intel-edison/issues/136 Signed-off-by: Andy Shevchenko Reviewed-by: Bin Meng --- v2: added tag, updated commit message and comments in DTS (Bin) arch/x86/dts/edison.dts | 17

Re: [PATCH v1 2/2] x86: edison: Don't take SD card detect pin into consideration

2021-10-27 Thread Andy Shevchenko
On Wed, Oct 27, 2021 at 06:10:59PM +0800, Bin Meng wrote: > On Wed, Oct 27, 2021 at 4:52 PM Andy Shevchenko > wrote: > > On Wed, Oct 27, 2021 at 5:57 AM Bin Meng wrote: > > > On Sat, Oct 16, 2021 at 1:27 AM Andy Shevchenko > > > wrote: ... > > > > +

Re: [PATCH v1 1/2] x86: tangier: Enable support for SD/SDIO family in the pinmux driver

2021-10-27 Thread Andy Shevchenko
On Wed, Oct 27, 2021 at 1:14 PM Bin Meng wrote: > On Wed, Oct 27, 2021 at 4:54 PM Andy Shevchenko > wrote: > > On Wed, Oct 27, 2021 at 5:49 AM Bin Meng wrote: > > > On Sat, Oct 16, 2021 at 1:27 AM Andy Shevchenko > > > wrote: ... > >

Re: [PATCH v1 1/2] x86: tangier: Enable support for SD/SDIO family in the pinmux driver

2021-10-27 Thread Andy Shevchenko
On Wed, Oct 27, 2021 at 5:49 AM Bin Meng wrote: > On Sat, Oct 16, 2021 at 1:27 AM Andy Shevchenko > wrote: > > > > We would need to quirk out Card Detect case and for that we allow > > configuring SD/SDIO family of pins. ... > > +static int mrfld_pinconfig(unsign

Re: [PATCH v1 2/2] x86: edison: Don't take SD card detect pin into consideration

2021-10-27 Thread Andy Shevchenko
On Wed, Oct 27, 2021 at 5:57 AM Bin Meng wrote: > On Sat, Oct 16, 2021 at 1:27 AM Andy Shevchenko > wrote: > > > > There are two PCB designs in the wild which use the opposite > > signaling for SD card detect. This makes U-Boot working in one case > > and failin

Re: [PATCH v1 1/1] Makefile.lib: Always rebuild DSDT

2021-10-25 Thread Andy Shevchenko
On Mon, Oct 25, 2021 at 09:18:56AM -0600, Simon Glass wrote: > On Mon, 25 Oct 2021 at 01:34, Andy Shevchenko > wrote: > > On Sun, Oct 24, 2021 at 11:00 PM Simon Glass wrote: > > > On Wed, 20 Oct 2021 at 06:37, Andy Shevchenko > > > wrote: > > > > &g

Re: [PATCH v1 1/1] Makefile.lib: Always rebuild DSDT

2021-10-25 Thread Andy Shevchenko
On Sun, Oct 24, 2021 at 11:00 PM Simon Glass wrote: > On Wed, 20 Oct 2021 at 06:37, Andy Shevchenko > wrote: > > > > The dsdt.asl is usually combined out of several files that are included > > in the main one. Whenever we change the content of any of such files, >

Re: [PATCH v1 2/2] x86: edison: Don't take SD card detect pin into consideration

2021-10-21 Thread Andy Shevchenko
On Thu, Oct 21, 2021 at 12:41 AM Ferry Toth wrote: > Op 15-10-2021 om 19:11 schreef Andy Shevchenko: > > There are two PCB designs in the wild which use the opposite > > signaling for SD card detect. This makes U-Boot working in one case > > and failing in the

[PATCH v1 1/1] x86: tangier: Replace Method() by Name() for _STA object

2021-10-20 Thread Andy Shevchenko
There is no point to use Method() for the constant. Replace it with Name() defined object. For the _STA case it saves 3 bytes per each entry. Before: 2881 After: 2833 Signed-off-by: Andy Shevchenko --- .../asm/arch-tangier/acpi/southcluster.asl| 81 --- 1 file changed, 17

[PATCH v1 1/1] Makefile.lib: Always rebuild DSDT

2021-10-20 Thread Andy Shevchenko
The dsdt.asl is usually combined out of several files that are included in the main one. Whenever we change the content of any of such files, build system is not able to recognize them. Hence the easiest way is to force DSDT rebuild each time we run make. Signed-off-by: Andy Shevchenko

[PATCH v1 1/2] x86: tangier: Enable support for SD/SDIO family in the pinmux driver

2021-10-15 Thread Andy Shevchenko
We would need to quirk out Card Detect case and for that we allow configuring SD/SDIO family of pins. Signed-off-by: Andy Shevchenko --- arch/x86/cpu/tangier/pinmux.c | 39 ++- 1 file changed, 34 insertions(+), 5 deletions(-) diff --git a/arch/x86/cpu/tangier

[PATCH v1 2/2] x86: edison: Don't take SD card detect pin into consideration

2021-10-15 Thread Andy Shevchenko
-edison/issues/136 Signed-off-by: Andy Shevchenko --- arch/x86/dts/edison.dts | 12 1 file changed, 12 insertions(+) diff --git a/arch/x86/dts/edison.dts b/arch/x86/dts/edison.dts index 2c8cf6c07102..04e8a4e457c8 100644 --- a/arch/x86/dts/edison.dts +++ b/arch/x86/dts/edison.dts @@ -94,6

[PATCH v3 1/1] x86: tangier: acpi: Add GPIO card detection to SDHCI #2

2021-09-11 Thread Andy Shevchenko
On Intel Tangier the SDHCI #2 provides SD card connection. Add GPIO card detection for it. Fixes: 39665beed6f7 ("x86: tangier: Enable ACPI support for Intel Tangier") BugLink: https://github.com/edison-fw/meta-intel-edison/issues/135 Signed-off-by: Andy Shevchenko Acked-by: Bin Me

Re: [PATCH v2 1/1] x86: tangier: acpi: Add GPIO card detection to SDHCI #2

2021-09-10 Thread Andy Shevchenko
On Fri, Sep 10, 2021 at 09:04:53PM +0300, Andy Shevchenko wrote: > On Intel Tangier the SDHCI #2 provides SD card connection. > Add GPIO card detection for it. > > Fixes: 39665beed6f7 ("x86: tangier: Enable ACPI support for Intel Tangier") > BugLink: https://github.com/ed

[PATCH v2 1/1] x86: tangier: acpi: Add GPIO card detection to SDHCI #2

2021-09-10 Thread Andy Shevchenko
On Intel Tangier the SDHCI #2 provides SD card connection. Add GPIO card detection for it. Fixes: 39665beed6f7 ("x86: tangier: Enable ACPI support for Intel Tangier") BugLink: https://github.com/edison-fw/meta-intel-edison/issues/135 Signed-off-by: Andy Shevchenko Acked-by: Bin Me

Re: [PATCH v1 1/1] x86: tangier: acpi: Add GPIO card detection to SDHCI #2

2021-09-10 Thread Andy Shevchenko
On Fri, Sep 10, 2021 at 7:16 PM Bin Meng wrote: > On Sat, Sep 11, 2021 at 12:07 AM Andy Shevchenko > wrote: > > On Fri, Sep 10, 2021 at 2:38 PM Bin Meng wrote: > > > On Fri, Sep 10, 2021 at 3:59 PM Andy Shevchenko > > > wrote: > > > > On Intel Tangie

Re: [PATCH v1 1/1] x86: tangier: acpi: Add GPIO card detection to SDHCI #2

2021-09-10 Thread Andy Shevchenko
On Fri, Sep 10, 2021 at 2:38 PM Bin Meng wrote: > > On Fri, Sep 10, 2021 at 3:59 PM Andy Shevchenko > wrote: > > > > On Intel Tangier the SDHCI #2 provides SD card connection. > > Add GPIO card detection for it. > > > > Fixes: 39665beed6f7 ("x86: ta

[PATCH v1 1/1] x86: tangier: acpi: Add GPIO card detection to SDHCI #2

2021-09-10 Thread Andy Shevchenko
On Intel Tangier the SDHCI #2 provides SD card connection. Add GPIO card detection for it. Fixes: 39665beed6f7 ("x86: tangier: Enable ACPI support for Intel Tangier") BugLink: https://github.com/edison-fw/meta-intel-edison/issues/135 Signed-off-by: Andy Shevchenko --- .../asm/arch-ta

[PATCH v1 1/1] x86: edison: Mark eMMC non-removable

2021-09-10 Thread Andy Shevchenko
eMMC is non-removable on Intel Edison board. Fix the DTS accordingly. Signed-off-by: Andy Shevchenko --- arch/x86/dts/edison.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/dts/edison.dts b/arch/x86/dts/edison.dts index 64b622836377..2c8cf6c07102 100644 --- a/arch/x86/dts

USB endpoints exclusion

2021-08-17 Thread Andy Shevchenko
Hi! It seems already some of the platforms are using USB endpoints for dedicated purposes (such as debugging). Those endpoints can't be used for anything else (sounds like hw wired). What is the solution in U-Boot (DTS + generic? code) to make this supported? -- With Best Regards, Andy

  1   2   3   4   5   6   7   8   9   10   >