Re: [PATCH v3 1/2] nvme: Enable FUA

2021-11-18 Thread Bin Meng
Hi Tom, On Fri, Nov 19, 2021 at 3:14 AM Tom Rini wrote: > > On Tue, Oct 19, 2021 at 10:40:53AM +0800, Jon Lin wrote: > > > Most NVME devcies maintain data in internal cache for an uncertain > > times, and u-boot has no method to force NVME to flush cache. > > So this patch adds FUA to avoid data

Re: [PATCH v1 4/5] net: macb: Compatible as per device tree

2021-11-11 Thread Bin Meng
On Thu, Nov 11, 2021 at 9:17 PM wrote: > > > I agree with Bin here. You shouldn't introduce a new compatible just for > > u-boot. If you need one, please to it first in linux and get an ACK there. > > Or at least there should be patches for it pending in linux and it should > > be likely, that

Re: [PATCH v1 4/5] net: macb: Compatible as per device tree

2021-11-11 Thread Bin Meng
Hi Padmarao, On Thu, Nov 11, 2021 at 2:11 PM wrote: > > Hi Bin, > > > > Do we need to upstream Linux kernel bindings for Microchip MACB compatible if > there is no change in Linux MACB driver? > > Are the Linux maintainers can approve this? Because the changes only in > U-Boot not Linux. > If

Re: [PATCH v1 4/5] net: macb: Compatible as per device tree

2021-11-02 Thread Bin Meng
Hi Padmarao, On Tue, Nov 2, 2021 at 7:03 PM Padmarao Begari wrote: > > Hi Bin, > > On Mon, Nov 1, 2021 at 2:15 PM Bin Meng wrote: >> >> On Fri, Oct 22, 2021 at 4:58 PM Padmarao Begari >> wrote: >> > >> > Update compatible as per M

Re: [PATCH 1/1] board: sifive: unmatched: enlarge CONFIG_SYS_SPL_MALLOC_SIZE

2021-11-01 Thread Bin Meng
Hi Rick, On Mon, Oct 25, 2021 at 10:24 AM Rick Chen wrote: > > Hi, Bin > > > Hi Rick, > > > > On Mon, Oct 25, 2021 at 9:49 AM Rick Chen wrote: > > > > > > Hi Bin, > > > > > > > From: Bin Meng > > > > Sent: Tuesd

Re: [PATCH v1 5/5] doc: board: Update Microchip MPFS Icicle Kit doc

2021-11-01 Thread Bin Meng
age. > > sudo dd if= of=/dev/sdX2 bs=512 > > -You should see the U-Boot prompt on UART0. > +You should see the U-Boot prompt on UART1. > +(Note: UART0 is reserved for HSS) > > GUID type > ~ Otherwise, Reviewed-by: Bin Meng Regards, Bin

Re: [PATCH v1 4/5] net: macb: Compatible as per device tree

2021-11-01 Thread Bin Meng
On Fri, Oct 22, 2021 at 4:58 PM Padmarao Begari wrote: > > Update compatible as per Microchip PolarFire SoC ethernet > device node. > > Signed-off-by: Padmarao Begari > --- > drivers/net/macb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/macb.c

Re: [PATCH v1 2/5] riscv: Update Microchip MPFS Icicle Kit support

2021-11-01 Thread Bin Meng
On Fri, Oct 22, 2021 at 4:58 PM Padmarao Begari wrote: > > This patch updates Microchip MPFS Icicle Kit support. For now, > add Microchip I2C driver, set environment variables for > mac addesses and default build for SBI_V02. > > Signed-off-by: Padmarao Begari > --- >

Re: [PATCH v1 1/5] riscv: dts: Split Microchip device tree

2021-11-01 Thread Bin Meng
Hi Padmarao, On Fri, Oct 22, 2021 at 4:58 PM Padmarao Begari wrote: > > The device tree split into .dtsi and .dts files, common > device node for eMMC/SD, enable I2C1, UART1 for console > instead of UART0, enable the DDR 2GB memory and in > that 288MB memory is reserved for fabric buffer. > >

Re: [PATCH] riscv: ae350: Use #if defined instead of CONFIG_IS_ENABLED

2021-11-01 Thread Bin Meng
Hi Leo, On Mon, Nov 1, 2021 at 3:49 PM Leo Liang wrote: > > Hi Bin, > On Mon, Nov 01, 2021 at 02:04:48PM +0800, Bin Meng wrote: > > Hi Leo, > > > > On Wed, Oct 27, 2021 at 4:59 PM Leo Yu-Chi Liang > > wrote: > > > > > > According to ./includ

[PATCH v2 3/3] net: tsec: Make redundant_init() static

2021-11-01 Thread Bin Meng
redundant_init() is only called in the tsec driver. Make it static. Signed-off-by: Bin Meng Reviewed-by: Vladimir Oltean Reviewed-by: Ramon Fried --- (no changes since v1) drivers/net/tsec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/tsec.c b/drivers

[PATCH v2 2/3] net: fec_mxc: Declare 'promisc' as bool

2021-11-01 Thread Bin Meng
priv->promisc is used as the parameter of the set_promisc() call which accepts a bool type instead of char. Signed-off-by: Bin Meng Reviewed-by: Vladimir Oltean Reviewed-by: Ramon Fried --- (no changes since v1) drivers/net/fec_mxc.h | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH v2 1/3] net: dsa: Use true instead of 1 in the set_promisc() call

2021-11-01 Thread Bin Meng
set_promisc() call accepts the parameter of a bool type. Make it clear by using true instead of 1. Signed-off-by: Bin Meng Reviewed-by: Vladimir Oltean Reviewed-by: Ramon Fried --- Changes in v2: - rebase on u-boot-net/next net/dsa-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] riscv: ae350: Use #if defined instead of CONFIG_IS_ENABLED

2021-11-01 Thread Bin Meng
Hi Leo, On Wed, Oct 27, 2021 at 4:59 PM Leo Yu-Chi Liang wrote: > > According to ./include/linux/kconfig.h, > CONFIG_IS_ENABLED(OF_BOARD) expands to 0 > when CONFIG_SPL_BUILD is defined because > there is no CONFIG_SPL_OF_BOARD. Why is the change? > > Use #if defined instead. > >

Please pull u-boot-x86

2021-10-31 Thread Bin Meng
detect pin into consideration x86: tangier: pinmux: Move is_protected assignment closer to its user x86: tangier: pinmux: Move error message to the caller Bin Meng (1): docs: uefi: Update stale U-Boot on EFI doc Zhaofeng Li (2): pxe_utils: Fix arguments to x86 zboot

Re: [PATCH] Azure: Move to windows-2019

2021-10-31 Thread Bin Meng
ded here, hence the tag naming scheme change). > > Signed-off-by: Tom Rini > --- > .azure-pipelines.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng

Re: [PATCH v1 2/2] x86: tangier: pinmux: Move error message to the caller

2021-10-31 Thread Bin Meng
On Mon, Nov 1, 2021 at 10:18 AM Bin Meng wrote: > > On Wed, Oct 27, 2021 at 10:23 PM Andy Shevchenko > wrote: > > > > Move error message to the caller of mrfld_pinconfig*() in order > > to unify them in the future. > > > > Signed-off-by: Andy Shevch

Re: [PATCH v1 2/2] x86: tangier: pinmux: Move error message to the caller

2021-10-31 Thread Bin Meng
sertions(+), 7 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v1 1/2] x86: tangier: pinmux: Move is_protected assignment closer to its user

2021-10-31 Thread Bin Meng
On Mon, Nov 1, 2021 at 10:05 AM Bin Meng wrote: > > On Wed, Oct 27, 2021 at 10:23 PM Andy Shevchenko > wrote: > > > > Move is_protected assignment closer to its user. > > This increases readability and makes maintenance easier. > > > > Signed-off-by: And

Re: [PATCH v1 1/2] x86: tangier: pinmux: Move is_protected assignment closer to its user

2021-10-31 Thread Bin Meng
nsertion(+), 2 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH 1/3] net: dsa: Use true instead of 1 in the set_promisc() call

2021-10-30 Thread Bin Meng
; > > > On Thu, Oct 28, 2021 at 7:53 AM Ramon Fried wrote: > > > > > > > > On Wed, Oct 27, 2021 at 5:19 AM Bin Meng wrote: > > > > > > > > > > On Sun, Oct 17, 2021 at 2:26 AM Ramon Fried > > > > > wrote: > > >

Re: an off-by-one error in dm_test_rtc_set_get()?

2021-10-27 Thread Bin Meng
On Wed, Oct 27, 2021 at 9:22 PM Tom Rini wrote: > > On Wed, Oct 27, 2021 at 12:43:38PM +0800, Bin Meng wrote: > > Hi Simon, > > > > gitlab reported the following test error below: > > > >

Re: [PATCH] Fix syntax error

2021-10-27 Thread Bin Meng
On Wed, Oct 27, 2021 at 5:01 PM Leo Yu-Chi Liang wrote: > > This statement has an unmatched parentheses, fix it. > > Signed-off-by: Leo Yu-Chi Liang > --- > common/image-board.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng

Re: [PATCH v3 1/2] nvme: Enable FUA

2021-10-27 Thread Bin Meng
Hi Jon, On Tue, Oct 19, 2021 at 10:41 AM Jon Lin wrote: > > Most NVME devcies maintain data in internal cache for an uncertain > times, and u-boot has no method to force NVME to flush cache. > So this patch adds FUA to avoid data loss caused by power off after data > programming. > >

Re: [PATCH v2 2/2] x86: edison: Don't take SD card detect pin into consideration

2021-10-27 Thread Bin Meng
in from the PCB by switching > it to mode 3. In the disconnected state the read value is always > the same and inverted to what we are expecting in the code. > > BugLink: https://github.com/edison-fw/meta-intel-edison/issues/136 > Signed-off-by: Andy Shevchenko > Reviewed-by: Bin Men

Re: [PATCH v2 1/2] x86: tangier: Enable support for SD/SDIO family in the pinmux driver

2021-10-27 Thread Bin Meng
On Wed, Oct 27, 2021 at 7:28 PM Andy Shevchenko wrote: > > We would need to quirk out the Card Detect case and for that we allow > configuring the SD/SDIO family of pins. > > Signed-off-by: Andy Shevchenko > Reviewed-by: Bin Meng > --- > v2: added tag, promised

Re: [PATCH v1 1/2] x86: tangier: Enable support for SD/SDIO family in the pinmux driver

2021-10-27 Thread Bin Meng
On Wed, Oct 27, 2021 at 4:54 PM Andy Shevchenko wrote: > > On Wed, Oct 27, 2021 at 5:49 AM Bin Meng wrote: > > On Sat, Oct 16, 2021 at 1:27 AM Andy Shevchenko > > wrote: > > > > > > We would need to quirk out Card Detect case and for that we allow >

Re: [PATCH v1 2/2] x86: edison: Don't take SD card detect pin into consideration

2021-10-27 Thread Bin Meng
On Wed, Oct 27, 2021 at 4:52 PM Andy Shevchenko wrote: > > On Wed, Oct 27, 2021 at 5:57 AM Bin Meng wrote: > > On Sat, Oct 16, 2021 at 1:27 AM Andy Shevchenko > > wrote: > > > > > > There are two PCB designs in the wild which use the opposite > > &g

an off-by-one error in dm_test_rtc_set_get()?

2021-10-26 Thread Bin Meng
Hi Simon, gitlab reported the following test error below: === FAILURES === __ test_ut[ut_dm_rtc_set_get] __ test/py/tests/test_ut.py:43: in test_ut assert output.endswith('Failures:

Re: [PATCH v2] usb: xhci-brcm: Include header file needed for dev_err

2021-10-26 Thread Bin Meng
fan Agner > --- > > Changes in v2: > - Correctly place include > Reviewed-by: Bin Meng

Re: [PATCH] x86: Fix i8254 ifdef include guard

2021-10-26 Thread Bin Meng
On Wed, Oct 27, 2021 at 11:08 AM Bin Meng wrote: > > On Thu, Oct 21, 2021 at 5:31 AM Alistair Delva wrote: > > > > When building U-Boot with clang, it notices that the i8254.h include > > guard does not work correctly due to a typo. Fix it. > > > > Signed-o

Re: [PATCH] x86: chromebook_coral: fix C block comment

2021-10-26 Thread Bin Meng
On Wed, Oct 27, 2021 at 11:07 AM Bin Meng wrote: > > On Thu, Oct 21, 2021 at 5:31 AM Alistair Delva wrote: > > > > Fix a warning seen when compiling this dts file. > > > > Signed-off-by: Alistair Delva > > Cc: Simon Glass > > Cc: Bin Meng > >

Re: [PATCH v1 1/1] x86: tangier: Replace Method() by Name() for _STA object

2021-10-26 Thread Bin Meng
On Wed, Oct 27, 2021 at 11:05 AM Bin Meng wrote: > > On Wed, Oct 20, 2021 at 8:51 PM Andy Shevchenko > wrote: > > > > There is no point to use Method() for the constant. > > Replace it with Name() defined object. For the _STA > > case it saves 3 bytes per

Re: [PATCH v2 0/2] pxe_utils: Fix arguments to x86 zboot

2021-10-26 Thread Bin Meng
On Wed, Oct 20, 2021 at 3:18 PM Zhaofeng Li wrote: > > Hi Simon, > > Thanks for your review! I have added a second patch to perform the > cleanup that you mentioned in the review, so the actual "fix" patch > stays minimal and easy to review. > > I agree that calling the bootm and zboot code

Re: [PATCH] x86: Fix i8254 ifdef include guard

2021-10-26 Thread Bin Meng
On Thu, Oct 21, 2021 at 5:31 AM Alistair Delva wrote: > > When building U-Boot with clang, it notices that the i8254.h include > guard does not work correctly due to a typo. Fix it. > > Signed-off-by: Alistair Delva > Cc: Simon Glass > Cc: Bin Meng > --- > arch/

Re: [PATCH] x86: chromebook_coral: fix C block comment

2021-10-26 Thread Bin Meng
On Thu, Oct 21, 2021 at 5:31 AM Alistair Delva wrote: > > Fix a warning seen when compiling this dts file. > > Signed-off-by: Alistair Delva > Cc: Simon Glass > Cc: Bin Meng > --- > arch/x86/dts/chromebook_coral.dts | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Bin Meng

Re: [PATCH v1 1/1] x86: tangier: Replace Method() by Name() for _STA object

2021-10-26 Thread Bin Meng
enko > --- > .../asm/arch-tangier/acpi/southcluster.asl| 81 --- > 1 file changed, 17 insertions(+), 64 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v1 2/2] x86: edison: Don't take SD card detect pin into consideration

2021-10-26 Thread Bin Meng
Hi Andy, On Sat, Oct 16, 2021 at 1:27 AM Andy Shevchenko wrote: > > There are two PCB designs in the wild which use the opposite > signaling for SD card detect. This makes U-Boot working in one case > and failing in the other. Quirk this out by disconnecting SD card > detect pin from the PCB by

Re: [PATCH v1 1/2] x86: tangier: Enable support for SD/SDIO family in the pinmux driver

2021-10-26 Thread Bin Meng
Hi Andy, On Sat, Oct 16, 2021 at 1:27 AM Andy Shevchenko wrote: > > We would need to quirk out Card Detect case and for that we allow > configuring SD/SDIO family of pins. > > Signed-off-by: Andy Shevchenko > --- > arch/x86/cpu/tangier/pinmux.c | 39 ++- > 1

Re: [PATCH 1/3] net: dsa: Use true instead of 1 in the set_promisc() call

2021-10-26 Thread Bin Meng
On Sun, Oct 17, 2021 at 2:26 AM Ramon Fried wrote: > > On Wed, Sep 29, 2021 at 4:32 PM Vladimir Oltean > wrote: > > > > On Wed, Sep 29, 2021 at 01:50:44PM +0800, Bin Meng wrote: > > > set_promisc() call accepts the parameter of a bool type. Make it > >

Re: [PATCH 1/1] board: sifive: unmatched: enlarge CONFIG_SYS_SPL_MALLOC_SIZE

2021-10-24 Thread Bin Meng
Hi Rick, On Mon, Oct 25, 2021 at 9:49 AM Rick Chen wrote: > > Hi Bin, > > > From: Bin Meng > > Sent: Tuesday, October 19, 2021 4:55 PM > > To: Alexandre Ghiti > > Cc: Heinrich Schuchardt ; Tom Rini > > ; Leo Yu-Chi Liang(梁育齊) ; Rick > > Jian-Zhi C

Re: [PATCH] riscv: Avoid io read/write cause wrong result

2021-10-19 Thread Bin Meng
> 1 file changed, 9 insertions(+), 9 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH 1/1] board: sifive: unmatched: enlarge CONFIG_SYS_SPL_MALLOC_SIZE

2021-10-19 Thread Bin Meng
On Tue, Oct 19, 2021 at 4:32 PM Alexandre Ghiti wrote: > > Hi, > > On Fri, Oct 1, 2021 at 5:35 PM Bin Meng wrote: > > > > Hi Heinrich, > > > > On Fri, Oct 1, 2021 at 7:37 PM Heinrich Schuchardt > > wrote: > > > > > > Avoid an error li

Re: [PATCH 00/16] fdt: Make OF_BOARD a boolean option

2021-10-12 Thread Bin Meng
Hi Simon, On Wed, Oct 13, 2021 at 9:01 AM Simon Glass wrote: > > With Ilias' efforts we have dropped OF_PRIOR_STAGE and OF_HOSTFILE so > there are only three ways to obtain a devicetree: > >- OF_SEPARATE - the normal way, where the devicetree is built and > appended to U-Boot >-

Re: [PATCH] tools: Stop re-defining -std= when building tools

2021-10-10 Thread Bin Meng
On Mon, Oct 11, 2021 at 3:23 AM Tom Rini wrote: > > While we intentionally set -std=gnu11 for building host tools, and have > for quite some time, we never dropped -std=gnu99 from tools/Makefile. > This resulted in passing -std=gnu11 ... -std=gnu99 when building, and > gnu99 would win. This in

Re: [PATCH 1/9] cache: sifive: Fix -Wint-to-pointer-cast warning

2021-10-10 Thread Bin Meng
On Wed, Sep 15, 2021 at 11:40 AM Leo Liang wrote: > > On Sun, Sep 12, 2021 at 11:15:08AM +0800, Bin Meng wrote: > > The following warning is seen in cache-sifive-ccache.c in a 32-bit build: > > > > warning: cast to pointer from integer of different size > > [-Win

Re: [PATCH v2] board: sifive: Fix a potential build warning in board_fdt_blob_setup()

2021-10-10 Thread Bin Meng
On Fri, Sep 17, 2021 at 2:52 PM Rick Chen wrote: > > > From: Bin Meng > > Sent: Saturday, September 11, 2021 10:31 PM > > To: Zong Li ; Leo Yu-Chi Liang(梁育齊) > > ; Rick Jian-Zhi Chen(陳建志) ; > > u-boot@lists.denx.de > > Subject: [PATCH v2] board

Re: [PATCH] mtd: Add SPI Nor Flash chip GD25LQ256D ID

2021-10-08 Thread Bin Meng
HI Jagan, On Fri, Oct 8, 2021 at 8:58 PM Jagan Teki wrote: > > On Thu, Sep 30, 2021 at 4:24 PM wrote: > > > > From: "yanhong.wang" > > > > Signed-off-by: yanhong.wang > > --- > > Applied to u-boot-spi/master Did you address my comments when applying? Regards, Bin

Re: [PATCH 2/2] riscv: Enable SYS_CLK_FREQ config

2021-10-02 Thread Bin Meng
On Thu, Sep 30, 2021 at 8:07 PM wrote: > > From: TekkamanV > > Signed-off-by: TekkamanV > --- > common/Kconfig.boot | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/common/Kconfig.boot b/common/Kconfig.boot > index 902a5b8fbe..4f29cc2d56 100644 > ---

Re: [PATCH 1/2] riscv: Enable SYS_MALLOC_LEN config

2021-10-02 Thread Bin Meng
On Thu, Sep 30, 2021 at 8:07 PM wrote: > > From: TekkamanV > Please add a commit message. > Signed-off-by: TekkamanV > --- > Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Kconfig b/Kconfig > index a6c42b902f..7f63929c60 100644 > --- a/Kconfig > +++

Re: [PATCH] mtd: Add SPI Nor Flash chip GD25LQ256D ID

2021-10-02 Thread Bin Meng
, 0xc86019, 0, 64 * 1024, 512, > + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | > + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) > + }, > #endif > #ifdef CONFIG_SPI_FLASH_ISSI /* ISSI */ > /* ISSI */ Otherwise LGTM: Reviewed-by: Bin Meng

Re: [PATCH] riscv: add #define in asm/io.h for some device drivers

2021-10-02 Thread Bin Meng
) > + > #define dmb() mb() > #define __iormb() rmb() > #define __iowmb() wmb() Otherwise, LGTM: Reviewed-by: Bin Meng Regards, Bin

Re: [PATCH 1/1] board: sifive: unmatched: enlarge CONFIG_SYS_SPL_MALLOC_SIZE

2021-10-01 Thread Bin Meng
Hi Heinrich, On Fri, Oct 1, 2021 at 7:37 PM Heinrich Schuchardt wrote: > > Avoid an error like > > Could not get FIT buffer of 1725952 bytes > check CONFIG_SYS_SPL_MALLOC_SIZE > No device tree specified in SPL image > ### ERROR ### Please RESET the board ### > >

Re: Driver model at UEFI runtime

2021-09-30 Thread Bin Meng
On Thu, Sep 30, 2021 at 2:23 PM François Ozog wrote: > > > Le jeu. 30 sept. 2021 à 07:12, Bin Meng a écrit : > >> Hi Heinrich, >> >> On Thu, Sep 9, 2021 at 7:16 PM Heinrich Schuchardt >> wrote: >> > >> > Hello Simon, >> > >>

Re: Driver model at UEFI runtime

2021-09-29 Thread Bin Meng
Hi Heinrich, On Thu, Sep 9, 2021 at 7:16 PM Heinrich Schuchardt wrote: > > Hello Simon, > > The EBBR specification requires that the UEFI SystemReset() runtime > service is available to the operating system. > > Up to now this has been implemented by overriding function > efi_reset_system()

Re: [PATCH v2 04/10] net: introduce a helper to determine whether to use in-band autoneg

2021-09-29 Thread Bin Meng
in Linux, introduce parsing support for this property in U-Boot too. > > Signed-off-by: Vladimir Oltean > Reviewed-by: Ramon Fried > --- > v1->v2: none > > drivers/core/of_extra.c | 12 > include/dm/of_extra.h | 14 ++ > 2 files changed, 26 insertions(+) > Reviewed-by: Bin Meng

Re: [PATCH v2] board: sifive: Fix a potential build warning in board_fdt_blob_setup()

2021-09-29 Thread Bin Meng
Hi Ilias, On Wed, Sep 29, 2021 at 9:07 PM Ilias Apalodimas wrote: > > Hi Bin > > There's a similar discussion in a cleanup series I've sent [1] > On Sat, Sep 11, 2021 at 10:31:23PM +0800, Bin Meng wrote: > > Commit 47d73ba4f4a4 ("board: sifive: overwrite board_fdt

[PATCH 3/3] net: tsec: Make redundant_init() static

2021-09-28 Thread Bin Meng
redundant_init() is only called in the tsec driver. Make it static. Signed-off-by: Bin Meng --- drivers/net/tsec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c index ee820aae15..b433e411bd 100644 --- a/drivers/net/tsec.c +++ b

[PATCH 2/3] net: fec_mxc: Declare 'promisc' as bool

2021-09-28 Thread Bin Meng
priv->promisc is used as the parameter of the set_promisc() call which accepts a bool type instead of char. Signed-off-by: Bin Meng --- drivers/net/fec_mxc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/fec_mxc.h b/drivers/net/fec_mxc.h index 62b55ef

[PATCH 1/3] net: dsa: Use true instead of 1 in the set_promisc() call

2021-09-28 Thread Bin Meng
set_promisc() call accepts the parameter of a bool type. Make it clear by using true instead of 1. Signed-off-by: Bin Meng --- net/dsa-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/dsa-uclass.c b/net/dsa-uclass.c index 694664d81b..dcefec03f4 100644 --- a/net

Re: [PATCH v2 1/2] nvme: Enable FUA

2021-09-28 Thread Bin Meng
On Mon, Sep 27, 2021 at 9:22 PM Jon Lin wrote: > > Most NVME devcies maintain data in internal cache for an uncertain typo: devices > times, and u-boot has no method to force NVME to flush cache. > So this patch adds FUA to avoid data loss caused by power off after data > programming. > >

Re: [PATCH 9/9] configs: ls1021a-tsn: enable the generation of random Ethernet MAC addresses

2021-09-28 Thread Bin Meng
es changed, 2 insertions(+) > Reviewed-by: Bin Meng

Re: [PATCH 8/9] configs: ls1021a-tsn: enable sja1105 switch driver

2021-09-28 Thread Bin Meng
g | 2 ++ > configs/ls1021atsn_sdcard_defconfig | 2 ++ > 2 files changed, 4 insertions(+) > Reviewed-by: Bin Meng

Re: [PATCH 4/9] net: introduce a helper to determine whether to use in-band autoneg

2021-09-28 Thread Bin Meng
in Linux, introduce parsing support for this property in U-Boot too. > > Signed-off-by: Vladimir Oltean > --- > drivers/core/of_extra.c | 12 > include/dm/of_extra.h | 14 ++++++ > 2 files changed, 26 insertions(+) > Reviewed-by: Bin Meng

Re: [PATCH 2/9] include: import if_vlan.h from Linux

2021-09-28 Thread Bin Meng
include/linux/if_vlan.h > Reviewed-by: Bin Meng

Re: [PATCH 1/9] net: tsec: add support for promiscuous mode

2021-09-28 Thread Bin Meng
that the setting > we applied in eth_ops :: set_promisc sticks. > > Signed-off-by: Vladimir Oltean > --- > drivers/net/tsec.c | 20 > include/tsec.h | 2 ++ > 2 files changed, 18 insertions(+), 4 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH] configs: ls1028a: ensure Ethernet is enabled

2021-09-28 Thread Bin Meng
configs/ls1028aqds_tfa_lpuart_defconfig | 1 + > configs/ls1028ardb_tfa_SECURE_BOOT_defconfig | 1 + > configs/ls1028ardb_tfa_defconfig | 1 + > 6 files changed, 6 insertions(+) > Reviewed-by: Bin Meng

Re: [PATCH v7 8/8] drivers: net: macb: add fu740 support

2021-09-27 Thread Bin Meng
t; by PLL is 125.125 MHz and out of VSC8541XMV-02 spec. > > Signed-off-by: David Abdurachmanov > Signed-off-by: Green Wan > Reviewed-by: Ramon Fried > Reviewed-by: Bin Meng > --- > drivers/net/macb.c | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) >

Re: [PATCH] Makelfile: clean target should remove itb*

2021-09-23 Thread Bin Meng
Hi Heinrich, On Thu, Sep 23, 2021 at 6:12 PM Heinrich Schuchardt wrote: > > In the U-Boot directory files itb.fit.fit, itb.fit.itb, itb.map are > created (e.g. for sifive_unmatched_defconfig). These should be removed by > the clean target. > > Signed-off-by: Heinrich Schuchardt > --- >

Re: USB 3.1 support

2021-09-22 Thread Bin Meng
HI Aaron, On Thu, Sep 23, 2021 at 9:24 AM Aaron Williams wrote: > > Hi all, > > You can ignore my previous email. It looks like it's being added as I type > this. > > Best Regards, > > -Aaron Williams > > On Wednesday, September 22, 2021 6:22:00 PM PDT Aaron Williams wrote: > > Hi Bin, Stefan, >

Re: [PATCH] MAINTAINERS: remove SPEAR entry

2021-09-22 Thread Bin Meng
rm: Remove spear600 boards and the rest of SPEAr > support") > Signed-off-by: Patrick Delaunay > --- > > MAINTAINERS | 7 --- > 1 file changed, 7 deletions(-) > Reviewed-by: Bin Meng

Please pull u-boot-x86

2021-09-22 Thread Bin Meng
Hi Tom, This PR includes the following x86 changes for v2021.10 release: - Small fixes to eMMC and SDHCI for Intel Edison Azure results: PASS https://dev.azure.com/bmeng/GitHub/_build/results?buildId=457=results The following changes since commit cfb573d22dac1089b5c792bc8529dd76acfa68fc:

Re: [PATCH 1/5] arm: apple: Add initial support for Apple's M1 SoC

2021-09-21 Thread Bin Meng
On Tue, Sep 21, 2021 at 8:42 PM Tom Rini wrote: > > On Sun, Sep 19, 2021 at 10:33:25PM +0200, Mark Kettenis wrote: > > > From: Bin Meng > > > Date: Sun, 19 Sep 2021 09:17:07 +0800 > > > > > > Hi Mark, > > > > > > On Sun, Sep

Re: [PATCH] usb: xhci-dwc3: Add support for USB 3.1 controllers

2021-09-20 Thread Bin Meng
On Mon, Sep 20, 2021 at 6:44 AM Marek Vasut wrote: > > On 9/19/21 10:40 AM, Bin Meng wrote: > > Hi Marek, > > > > On Thu, Sep 16, 2021 at 10:08 PM Bin Meng wrote: > >> > >> On Thu, Sep 16, 2021 at 10:00 PM Mark Kettenis > >> wrote: > >

Re: [PATCH] usb: xhci-dwc3: Add support for USB 3.1 controllers

2021-09-19 Thread Bin Meng
Hi Marek, On Thu, Sep 16, 2021 at 10:08 PM Bin Meng wrote: > > On Thu, Sep 16, 2021 at 10:00 PM Mark Kettenis wrote: > > > > This adds support for the DWC_sub31 controllers such as those > > found on Apple's M1 SoC. This version of the controller > > seems to work

Re: [PATCH v3 1/1] x86: tangier: acpi: Add GPIO card detection to SDHCI #2

2021-09-19 Thread Bin Meng
-fw/meta-intel-edison/issues/135 > Signed-off-by: Andy Shevchenko > Acked-by: Bin Meng > --- > v3: basically returned to the content of v2 (pull bias back to none) > since there is nothing special about the signal which is supposed > to be triggered by both edges > >

Re: [PATCH v1 1/1] x86: edison: Mark eMMC non-removable

2021-09-19 Thread Bin Meng
On Fri, Sep 10, 2021 at 7:35 PM Bin Meng wrote: > > On Fri, Sep 10, 2021 at 3:59 PM Andy Shevchenko > wrote: > > > > eMMC is non-removable on Intel Edison board. Fix the DTS accordingly. > > > > Signed-off-by: Andy Shevchenko > > --- > > arch/x8

Re: [PATCH 2/2] net: tsec: read the phy-mode property as fallback to phy-connection-type

2021-09-19 Thread Bin Meng
le changed, 2 insertions(+) > Reviewed-by: Bin Meng Tested-by: Bin Meng

Re: [PATCH 1/2] net: tsec: only call tsec_get_interface as fallback to DT-specified PHY mode

2021-09-19 Thread Bin Meng
nly if phy-connection-type happens to not be defined in > the device tree. > > Signed-off-by: Vladimir Oltean > --- > drivers/net/tsec.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > Reviewed-by: Bin Meng Tested-by: Bin Meng

Re: [PATCH 5/5] doc: board: apple: Add Apple M1 documentation

2021-09-18 Thread Bin Meng
ard/apple/m1.rst| 56 +++ > doc/board/index.rst | 1 + > 3 files changed, 66 insertions(+) > create mode 100644 doc/board/apple/index.rst > create mode 100644 doc/board/apple/m1.rst > Reviewed-by: Bin Meng

Re: [PATCH 1/5] arm: apple: Add initial support for Apple's M1 SoC

2021-09-18 Thread Bin Meng
Hi Mark, On Sun, Sep 19, 2021 at 9:04 AM Bin Meng wrote: > > Hi Mark, > > On Sat, Sep 18, 2021 at 9:55 PM Mark Kettenis wrote: > > > > Add support for Apple's M1 SoC that is used in "Apple Silicon" > > Macs. This builds a basic U-Boot that can be used a

Re: [PATCH 2/5] serial: s5p: Add Apple M1 support

2021-09-18 Thread Bin Meng
Hi Mark, On Sat, Sep 18, 2021 at 9:55 PM Mark Kettenis wrote: > > Apple M1 SoCs include an S5L UART which is a variant of the S5P > UART. Add support for this variant and enable it by default > on Apple SoCs. > > Signed-off-by: Mark Kettenis > --- > arch/arm/include/asm/arch-m1/clk.h | 11

Re: [PATCH 1/5] arm: apple: Add initial support for Apple's M1 SoC

2021-09-18 Thread Bin Meng
Hi Mark, On Sat, Sep 18, 2021 at 9:55 PM Mark Kettenis wrote: > > Add support for Apple's M1 SoC that is used in "Apple Silicon" > Macs. This builds a basic U-Boot that can be used as a payload > for the m1n1 boot loader being developed by the Asahi Linux > project. > > Signed-off-by: Mark

Re: [PATCH] net: phy: genphy_init can be static

2021-09-18 Thread Bin Meng
rivers/net/phy/phy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng

[PATCH] fdt_support.h: Remove duplicated declarations

2021-09-18 Thread Bin Meng
There are two duplicated declarations for ft_cpu_setup() and ft_pci_setup(). Signed-off-by: Bin Meng --- include/fdt_support.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/fdt_support.h b/include/fdt_support.h index f6f46bb8e9..72a5b90c97 100644 --- a/include/fdt_support.h

Re: [PATCH 11/11] pci: pcie_layerscape_fixup_common: lx2_board_fix_fdt can be static

2021-09-18 Thread Bin Meng
> 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng

Re: [PATCH 10/11] pci: pcie_layerscape_fixup_common: include fdt_support.h for ft_pci_setup

2021-09-18 Thread Bin Meng
insertion(+) > Reviewed-by: Bin Meng

Re: [PATCH 09/11] pci: layerscape: ls_pcie_conf_address can be static

2021-09-18 Thread Bin Meng
> 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH 08/11] pci: _dm_pci_phys_to_bus can be static

2021-09-18 Thread Bin Meng
le changed, 3 insertions(+), 3 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH 07/11] pci: pci_read_config can be static

2021-09-18 Thread Bin Meng
nged, 2 insertions(+), 2 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH 06/11] pci: pci_write_config can be static

2021-09-18 Thread Bin Meng
nged, 2 insertions(+), 2 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH 05/11] pci: pciinfo_header can be static

2021-09-18 Thread Bin Meng
insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng

Re: [PATCH 04/11] pci: pci_header_show can be static

2021-09-18 Thread Bin Meng
insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng

Re: [PATCH 03/11] pci: pci_bar_show can be static

2021-09-18 Thread Bin Meng
insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng

Re: [PATCH 02/11] pci: include pci_internal.h inside pci_auto.c

2021-09-18 Thread Bin Meng
t; --- > drivers/pci/pci_auto.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Bin Meng

Re: [PATCH 01/11] pci: provide prototype for pci_skip_dev outside of #if defined(CONFIG_DM_PCI_COMPAT)

2021-09-18 Thread Bin Meng
e is not available due to it being under CONFIG_DM_PCI_COMPAT, > so move it outside of that preprocessor block. > > Signed-off-by: Vladimir Oltean > --- > include/pci.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng

Re: [PATCH] usb: xhci-dwc3: Add support for USB 3.1 controllers

2021-09-16 Thread Bin Meng
ers/usb/host/xhci-dwc3.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Reviewed-by: Bin Meng

Re: [PATCH] clk: sunxi: Move header out of arch directory

2021-09-12 Thread Bin Meng
| 2 +- > .../include/asm/arch-sunxi/ccu.h => include/clk/sunxi.h | 8 +++- > 15 files changed, 17 insertions(+), 19 deletions(-) > rename arch/arm/include/asm/arch-sunxi/ccu.h => include/clk/sunxi.h (94%) > Reviewed-by: Bin Meng

Re: [PATCH] riscv: Fix setting no-map in reserved memory nodes

2021-09-12 Thread Bin Meng
a ("riscv: Provide a mechanism to fix DT for reserved > memory") > Signed-off-by: Samuel Holland > --- > > arch/riscv/lib/fdt_fixup.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH] serial: Add a debug console using the RISC-V SBI interface

2021-09-12 Thread Bin Meng
te mode 100644 drivers/serial/serial_sbi.c > Reviewed-by: Bin Meng

  1   2   3   4   5   6   7   8   9   10   >