Re: [PATCH] cmd: test: Add operators to deal with hexadecimal numbers.

2020-03-12 Thread Christoph Müllner
Hi Michal, On 3/12/20 8:38 AM, Michal Simek wrote: > On 11. 03. 20 23:46, Christoph Muellner wrote: >> The DLUG states the following: >> Almost all U-Boot commands expect numbers to be entered in hexadecimal >> input format. >> >> Besides this fact, also most commands output hex values. >> >>

[PATCH] optee: Replace uninitialized return variable by proper one.

2020-01-27 Thread Christoph Müllner
As hinted by GCC 9, there is a return statement that returns an uninitialized variable in optee_copy_firmware_node(). This patch addresses this. Signed-off-by: Christoph Müllner --- lib/optee/optee.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/optee/optee.c b/lib

Re: [U-Boot] [PATCH] rockchip: make_fit_atf.py: fix loadables property set error【请注意,邮件由mark.kette...@sibelius.xs4all.nl代发】

2019-07-06 Thread Christoph Müllner
On 7/6/19 5:02 PM, Kever Yang wrote: > Hi Mark, > > > On 07/05/2019 08:03 PM, Mark Kettenis wrote: >>> From: Kever Yang >>> Date: Fri, 5 Jul 2019 19:38:42 +0800 >>> >>> Hi Christoph, >>> >>> >>> On 07/05/201

Re: [U-Boot] [PATCH] rockchip: make_fit_atf.py: fix loadables property set error

2019-07-05 Thread Christoph Müllner
Hi Andy, On 05.07.19 12:06, Andy Yan wrote: > Hi  Christoph: > > On 2019/7/5 下午5:15, Christoph Müllner wrote: >> >> On 04.07.19 11:44, Andy Yan wrote: >>> Commit b238e4b00ced ("rockchip: Cleanup of make_fit_atf.py.") set >>> firmware

Re: [U-Boot] [PATCH] rockchip: make_fit_atf.py: fix loadables property set error

2019-07-05 Thread Christoph Müllner
On 04.07.19 11:44, Andy Yan wrote: > Commit b238e4b00ced ("rockchip: Cleanup of make_fit_atf.py.") set > firmware = "atf_1"; > loadables = "uboot","atf_1","atf_2"; > > Actually it should be: > firmware = "atf_1"; > loadables = "uboot","atf_2","atf_3"; Does "atf_1" not need to be among

Re: [U-Boot] [PATCH] rockchip: rk3399-puma: Reduce SPL size.

2019-05-28 Thread Christoph Müllner
On 28.05.19 15:06, Kever Yang wrote: > Hi Christoph, > >     This patch need re-base upon latest mainline tree. > >     And see below commons. > > > On 05/07/2019 04:42 PM, Christoph Muellner wrote: >> This commit reduces the SPL size by fixing typos in the removed property >> string list,

Re: [U-Boot] [PATCH] rockchip: rk3399-puma: Re-disable SPL_ATF_NO_PLATFORM_PARAM

2019-05-28 Thread Christoph Müllner
y to work on them. If you want we can wait for the complete series. But, as I said, the commit is ready for mainline now and would just be merged later. Thanks, Christoph > > > Thanks, > - Kever > On 05/07/2019 05:18 PM, Christoph Müllner wrote: >> Hi Mark, >> >&

Re: [U-Boot] [PATCH v2 1/3] board_f: Add mach specific DMA address check function.

2019-05-23 Thread Christoph Müllner
On 23.05.19 00:57, Simon Glass wrote: > Hi Heiko, > > On Wed, 22 May 2019 at 05:29, Heiko Stuebner wrote: >> >> Hi Simon, >> >> Am Samstag, 18. Mai 2019, 18:08:58 CEST schrieb Simon Glass: >>> On Tue, 7 May 2019 at 09:59, Christoph Muellner >

Re: [U-Boot] [PATCH v1] dm: pinctrl: Remove obsolete function pinctrl_decode_pin_config_dm().

2019-05-16 Thread Christoph Müllner
> Thanks, > - Kever > On 05/09/2019 11:52 AM, Simon Glass wrote: >> Hi, >> >> On Fri, 5 Apr 2019 at 05:43, Christoph Müllner >> wrote: >>> Hi Simon, >>> >>> any plans to get this merged? >> Yes, Kever should do it. >>

Re: [U-Boot] [PATCH] bouncebuf: add feature to support buffer only available in DRAM

2019-05-08 Thread Christoph Müllner
On 08.05.19 12:52, Marek Vasut wrote: > On 5/8/19 7:26 AM, Peng Fan wrote: >> Hi Kever, >> >>> Subject: [PATCH] bouncebuf: add feature to support buffer only available in >>> DRAM >>> >>> Some DMA which inside peripheral controller can only access space in DRAM >>> area, the target address

Re: [U-Boot] [PATCH 2/3] bouncebuf: Add DMA validation check to addr_aligned().

2019-05-07 Thread Christoph Müllner
On 07.05.19 17:56, Marek Vasut wrote: > On 5/7/19 5:22 PM, Christoph Müllner wrote: >> >> >> On 07.05.19 17:04, Marek Vasut wrote: >>> On 5/7/19 4:01 PM, Christoph Müllner wrote: >>>> >>>> >>>> On 07.05.19 15:53, M

Re: [U-Boot] [PATCH 2/3] bouncebuf: Add DMA validation check to addr_aligned().

2019-05-07 Thread Christoph Müllner
On 07.05.19 17:04, Marek Vasut wrote: > On 5/7/19 4:01 PM, Christoph Müllner wrote: >> >> >> On 07.05.19 15:53, Marek Vasut wrote: >>> On 5/7/19 3:52 PM, Christoph Müllner wrote: >>>> >>>> >>>> On 5/7/19 3:48 PM, Christoph Mül

Re: [U-Boot] [PATCH] bouncebuf: add feature to support buffer only available in DRAM

2019-05-07 Thread Christoph Müllner
On 07.05.19 15:51, Kever Yang wrote: > Some DMA which inside peripheral controller can only access space in > DRAM area, the target address outside DRAM is not available. > eg. Rockchip MMC contrller's internal DMA can only access DRAM area. > > Add Kconfig option and driver for people who need

Re: [U-Boot] [PATCH 1/2] bouncebuf: Add static buffer allocation method for SPL.

2019-05-07 Thread Christoph Müllner
On 07.05.19 16:16, Simon Goldschmidt wrote: > On Tue, May 7, 2019 at 4:11 PM Christoph Müllner > wrote: >> >> >> >> On 07.05.19 15:55, Marek Vasut wrote: >>> On 5/7/19 3:55 PM, Christoph Müllner wrote: >>>> >>>> >>>&g

Re: [U-Boot] [PATCH 1/2] bouncebuf: Add static buffer allocation method for SPL.

2019-05-07 Thread Christoph Müllner
On 07.05.19 15:55, Marek Vasut wrote: > On 5/7/19 3:55 PM, Christoph Müllner wrote: >> >> >> On 07.05.19 15:52, Marek Vasut wrote: >>> On 5/7/19 3:45 PM, Christoph Müllner wrote: >>>> >>>> >>>> On 07.05.19 15:06, Marek Vasut wrote

Re: [U-Boot] [PATCH 2/3] bouncebuf: Add DMA validation check to addr_aligned().

2019-05-07 Thread Christoph Müllner
On 07.05.19 15:53, Marek Vasut wrote: > On 5/7/19 3:52 PM, Christoph Müllner wrote: >> >> >> On 5/7/19 3:48 PM, Christoph Müllner wrote: >>> >>> >>> On 07.05.19 15:05, Marek Vasut wrote: >>>> On 5/7/19 11:05 AM, Christoph Muellner

Re: [U-Boot] [PATCH 1/2] bouncebuf: Add static buffer allocation method for SPL.

2019-05-07 Thread Christoph Müllner
On 07.05.19 15:52, Marek Vasut wrote: > On 5/7/19 3:45 PM, Christoph Müllner wrote: >> >> >> On 07.05.19 15:06, Marek Vasut wrote: >>> On 5/7/19 11:09 AM, Christoph Muellner wrote: >>>> If we are using malloc-simple, we get into the problem, that >&g

Re: [U-Boot] [PATCH 2/3] bouncebuf: Add DMA validation check to addr_aligned().

2019-05-07 Thread Christoph Müllner
On 07.05.19 15:05, Marek Vasut wrote: > On 5/7/19 11:05 AM, Christoph Muellner wrote: >> Currently addr_aligned() performs an alignment and a length check >> to validate the DMA address. However, some machines have stricter >> restrictions of DMA-able addresses. >> >> This patch adds a call to

Re: [U-Boot] [PATCH 2/3] bouncebuf: Add DMA validation check to addr_aligned().

2019-05-07 Thread Christoph Müllner
On 5/7/19 3:48 PM, Christoph Müllner wrote: > > > On 07.05.19 15:05, Marek Vasut wrote: >> On 5/7/19 11:05 AM, Christoph Muellner wrote: >>> Currently addr_aligned() performs an alignment and a length check >>> to validate the DMA address. However, some machin

Re: [U-Boot] [PATCH 1/2] bouncebuf: Add static buffer allocation method for SPL.

2019-05-07 Thread Christoph Müllner
On 07.05.19 15:06, Marek Vasut wrote: > On 5/7/19 11:09 AM, Christoph Muellner wrote: >> If we are using malloc-simple, we get into the problem, that >> calls to free() won't free any memory. When using bouncebuf >> in SPL with malloc-simple this means, that every allocated buffer >> is lost.

Re: [U-Boot] [PATCH] rockchip: rk3399-puma: Re-disable SPL_ATF_NO_PLATFORM_PARAM

2019-05-07 Thread Christoph Müllner
Hi Mark, On 07.05.19 10:57, Mark Kettenis wrote: >> From: Christoph Muellner >> Date: Tue, 7 May 2019 10:39:54 +0200 >> >> This reverts commit c869d63f2785ccde22582f96cf40cb8809f838ba. >> >> Mainline ATF already supports fdt-parsing, which allows us to >> pass rk3399-puma specific data to setup

Re: [U-Boot] [PATCH 3/3] common: bouncebuf: handle address in sram for rockchip platform

2019-04-30 Thread Christoph Müllner
Hi Kever, On 4/2/19 10:46 AM, Kever Yang wrote: > Rockchip SOC's mmc controller does not support read data > from mmc to sram, we need a bounce buffer(in sdram), and then > copy to sram. what exactly is the limitation here? I mean a DMA engine does not care where it is copying to. Additionally

Re: [U-Boot] [PATCH v1] dm: pinctrl: Remove obsolete function pinctrl_decode_pin_config_dm().

2019-04-05 Thread Christoph Müllner
Hi Simon, any plans to get this merged? Thanks, Christoph > On 14.02.2019, at 02:54, Simon Glass wrote: > > On Tue, 12 Feb 2019 at 18:29, Christoph Muellner > wrote: >> >> This reverts commit 5ff776889212c080e3d1a33634ac904405ed6845. >> >> As noted in the comment, the function

Re: [U-Boot] [PATCH v3 5/8] rockchip: rk3399: Add improved pinctrl driver.

2018-12-27 Thread Christoph Müllner
Hi David, On 12/27/18 1:49 PM, David Wu wrote: > Hi Christoph, > > I once submitted a series of patches that they can support all Socs' > Pinctrl and how do you feel about using them. Thank's for pointing to that. Your driver looks good, but I don't like the huge amount of duplication in it

Re: [U-Boot] [PATCH v3 5/8] rockchip: rk3399: Add improved pinctrl driver.

2018-12-25 Thread Christoph Müllner
Hi Simon, On 12/20/18 10:17 PM, Simon Glass wrote: > On Mon, 17 Dec 2018 at 06:30, Christoph Muellner > wrote: >> >> The current pinctrl driver for the RK3399 has a range of qulity issues. >> E.g. it only implements the .set_state_simple() callback, it >> does not parse the available pinctrl

Re: [U-Boot] [PATCH v3 4/8] dm: pinctrl: Add pinctrl_decode_pin_config_dm().

2018-12-25 Thread Christoph Müllner
On 12/20/18 10:16 PM, Simon Glass wrote: > Hi Christoph, > > On Mon, 17 Dec 2018 at 06:30, Christoph Muellner > wrote: >> >> pinctrl_decode_pin_config_dm() is basically a feature-equivalent >> implementation of pinctrl_decode_pin_config(), which operates >> on struct udevice devices and uses the

Re: [U-Boot] [PATCH v2 5/6] rockchip: rk3399: Add improved pinctrl driver.

2018-12-17 Thread Christoph Müllner
> On 13.12.2018, at 23:26, Philipp Tomsich > wrote: > >> On 12.12.2018, at 01:57, Christoph Muellner >> wrote: >> >> The current pinctrl driver for the RK3399 has a range of qulity issues. >> E.g. it only implements the .set_state_simple() callback, it >> does not parse the available

Re: [U-Boot] [PATCH v2 4/6] dm: pinctrl: Add pinctrl_decode_pin_config_dm().

2018-12-17 Thread Christoph Müllner
> On 13.12.2018, at 23:33, Philipp Tomsich > wrote: >> On 12.12.2018, at 01:57, Christoph Muellner >> wrote: >> >> pinctrl_decode_pin_config_dm() is basically a feature-equivalent >> implementation of pinctrl_decode_pin_config(), which operates >> on struct udevice devices and uses the

Re: [U-Boot] [PATCH 4/4] rockchip: puma-rk3399: Enable vdd-log during bootup.

2018-12-06 Thread Christoph Müllner
> On 06.12.2018, at 14:40, Philipp Tomsich > wrote: > > > >> On 06.12.2018, at 12:25, Christoph Muellner >> wrote: >> >> On the RK3399-Q7 "Puma" module VDD_LOG is generated by an external >> regulator, which sets the voltage level to 900 mV, which is within >> the allowed range and which

Re: [U-Boot] [PATCH] rockchip: rk3399: Initialize CPU B clock.

2018-11-30 Thread Christoph Müllner
> On 30.11.2018, at 19:37, Mark Kettenis wrote: > >> From: Christoph Muellner >> Date: Mon, 19 Nov 2018 14:44:13 +0100 >> >> This patch sets the PLL of CPU cluster B (BPLL) to 600 MHz. >> This decreases the boot time of Linux 4.19 by about 8%. >> >> The 600 MHz are inspired by the 600 MHz

Re: [U-Boot] [PATCH v2 1/2] arm: make arm926ejs startup code thumb compatible

2018-04-21 Thread Christoph Müllner
> On 21 Apr 2018, at 15:10, Måns Rullgård wrote: > > Klaus Goger > writes: > >> When building the mxs platform in thumb mode gcc generates code using >> the intra procedure call scratch register

Re: [U-Boot] [PATCH v2 2/2] arm: Make arch specific memcpy thumb-safe.

2018-04-21 Thread Christoph Müllner
> On 21 Apr 2018, at 19:00, Måns Rullgård <m...@mansr.com> wrote: > > Christoph Müllner <christoph.muell...@theobroma-systems.com > <mailto:christoph.muell...@theobroma-systems.com>> writes: > >>> On 21 Apr 2018, at 15:24, Måns Rullgård <m...@man

Re: [U-Boot] [PATCH v2 2/2] arm: Make arch specific memcpy thumb-safe.

2018-04-21 Thread Christoph Müllner
> On 21 Apr 2018, at 15:24, Måns Rullgård wrote: > > Klaus Goger writes: > >> The current arch implementation of memcpy cannot be called >> from thumb code, because it does not use bx instructions on return. >> This patch addresses that.

Re: [U-Boot] [PATCH v1] arm: mxs: make startup code thumb compatible

2018-04-19 Thread Christoph Müllner
> On 19.04.2018, at 10:33, Marek Vasut wrote: > > On 04/19/2018 10:02 AM, klaus.go...@theobroma-systems.com wrote: >> >>> On 18.04.2018, at 22:02, Marek Vasut wrote: >>> >>> On 04/18/2018 06:25 PM, Klaus Goger wrote: When building the mxs platform in thumb