Re: [PATCH] mmc: sdhci: Rework SDHCI_QUIRK_BROKEN_R1B

Hi Sean, Tested on odroid-u2 (exynos4412-odroid) on top of 2024.01-rc1, still works fine, so feel free to add: Tested-by: Henrik Grimler Best regards, Henrik Grimler On Fri, Oct 27, 2023 at 04:57:03PM -0400, Sean Anderson wrote: > As noted in commit 3a6383207be ("mmc: sdhci: add t

[RESEND PATCH v2 1/2] Revert "mmc: s5p_sdhci: unset the SDHCI_QUIRK_BROKEN_R1B"

<...> Loading Environment from MMC... sdhci_send_command: Timeout for status update! mmc fail to send stop cmd <...> Re-add the quirk to allow booting from sdcards again. Signed-off-by: Henrik Grimler --- drivers/mmc/s5p_sdhci.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[RESEND PATCH v2 2/2] samsung: common: do not reset if cros-ec uclass is missing

ailure -96 Please reset with Power+Refresh Cannot init cros-ec device resetting ... Issue started after commit e44d7e73fe0d ("dm: core: Switch uclass_*_device_err to use uclass_*_device_check"). Signed-off-by: Henrik Grimler Reviewed-by: Simon Glass Reviewed-by: Minkyu

[RESEND PATCH v2 0/2] odroid: fix boot issues on u2, xu4 and siblings

-March/445243.html [3] https://lists.denx.de/pipermail/u-boot/2023-January/504115.html [4] https://lists.denx.de/pipermail/u-boot/2023-January/505551.html Henrik Grimler (2): Revert "mmc: s5p_sdhci: unset the SDHCI_QUIRK_BROKEN_R1B" samsung: common: do not reset if cros-ec uclass is missi

Re: [PATCH 1/2] Revert "mmc: s5p_sdhci: unset the SDHCI_QUIRK_BROKEN_R1B"

ing to find db410c board. > I found its board, so I will try to check with/without its patch. > > After checked, I will reply again ASAP. Did you find an opportunity to experiment with the db410c board? Do you think it could be possible to get this in, and revert it again in the future i

Re: [PATCH 1/2] Revert "mmc: s5p_sdhci: unset the SDHCI_QUIRK_BROKEN_R1B"

Hi Jaehoon, On Fri, Feb 10, 2023 at 09:00:33AM +0900, Jaehoon Chung wrote: > Hi, > > > -Original Message- > > From: U-Boot On Behalf Of Henrik Grimler > > Sent: Thursday, February 9, 2023 4:04 AM > > To: jo...@diskos.nl; jh80.ch...@gmail.com; andy...@so

Re: [PATCH] samsung: common: ignore if CROS EC is not supported

ists.denx.de/pipermail/u-boot/2023-February/508929.html. Best regards, Henrik Grimler > Signed-off-by: Stefan Agner > --- > board/samsung/common/board.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/board/samsung/common/board.c b/board/samsung/com

[PATCH v2 1/2] Revert "mmc: s5p_sdhci: unset the SDHCI_QUIRK_BROKEN_R1B"

<...> Loading Environment from MMC... sdhci_send_command: Timeout for status update! mmc fail to send stop cmd <...> Re-add the quirk to allow booting from sdcards again. Signed-off-by: Henrik Grimler --- drivers/mmc/s5p_sdhci.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH v2 2/2] samsung: common: do not reset if cros-ec uclass is missing

ailure -96 Please reset with Power+Refresh Cannot init cros-ec device resetting ... Issue started after commit e44d7e73fe0d ("dm: core: Switch uclass_*_device_err to use uclass_*_device_check"). Signed-off-by: Henrik Grimler --- board/samsung/common/board.c | 2 +- 1

[PATCH v2 0/2] odroid: fix boot issues on u2, xu4 and siblings

://lists.denx.de/pipermail/u-boot/2023-January/504115.html [4] https://lists.denx.de/pipermail/u-boot/2023-January/505551.html Henrik Grimler (2): Revert "mmc: s5p_sdhci: unset the SDHCI_QUIRK_BROKEN_R1B" samsung: common: do not reset if cros-ec uclass is missing board/samsung/common/b

Re: [PATCH 1/2] Revert "mmc: s5p_sdhci: unset the SDHCI_QUIRK_BROKEN_R1B"

Hi Jaehoon, On Fri, 2023-02-10 at 09:00 +0900, Jaehoon Chung wrote: > Hi, > > > -Original Message- > > From: U-Boot On Behalf Of Henrik > > Grimler > > Sent: Thursday, February 9, 2023 4:04 AM > > To: jo...@diskos.nl; jh80.ch...@gmail.com; andy

Re: [PATCH 2/2] samsung: common: only load CROS_EC if enabled in config

Hi Simon, On Wed, 2023-02-08 at 18:08 -0700, Simon Glass wrote: > On Wed, 8 Feb 2023 at 12:04, Henrik Grimler > wrote: > > > > Otherwise non-ChromeOS samsung devices, like the odroid boards, are > > stuck in a bootloop if CONFIG_CROS_EC is not enabled: > > >

Re: [PATCH 0/2] odroid: fix boot issues on u2, xu4 and siblings

I missed CC:ing MMC maintainer Peng Fan (CC:ed here), apologies for this. Best regards, Henrik Grimler On Wed, Feb 08, 2023 at 08:04:19PM +0100, Henrik Grimler wrote: > Hi, > > Patch 1 fixes issue reported in [1], which happens on odroid-u2 and > probably other devices in that

[PATCH 2/2] samsung: common: only load CROS_EC if enabled in config

ailure -96 Please reset with Power+Refresh Cannot init cros-ec device resetting ... Issue started after commit e44d7e73fe0d ("dm: core: Switch uclass_*_device_err to use uclass_*_device_check"). Signed-off-by: Henrik Grimler --- board/samsung/com

[PATCH 1/2] Revert "mmc: s5p_sdhci: unset the SDHCI_QUIRK_BROKEN_R1B"

<...> Loading Environment from MMC... sdhci_send_command: Timeout for status update! mmc fail to send stop cmd <...> Re-add the quirk to allow booting from sdcards again. Signed-off-by: Henrik Grimler --- drivers/mmc/s5p_sdhci.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH 0/2] odroid: fix boot issues on u2, xu4 and siblings

://lists.denx.de/pipermail/u-boot/2023-January/504116.html [2] https://lists.denx.de/pipermail/u-boot/2021-March/445243.html [3] https://lists.denx.de/pipermail/u-boot/2023-January/504115.html [4] https://lists.denx.de/pipermail/u-boot/2023-January/505551.html Henrik Grimler (2): Revert "mmc: s5p_

Re: [PATCH] odroid: add CROS_EC to odroid_defconfig

u4 has the same issue, and the proposed solutions fixes the issue there as well. I also think the alternative `#if IS_ENABLED(CONFIG_CROS_EC)`-solution would be better. Thanks for reporting the issue! Best regards, Henrik Grimler

[PATCH v2 2/2] doc: board: avoid ambiguous names for axy17lte

Model names are SM-A{3,5,7}20, just SM-{3,5,7}20 could also refer to SM-J{3,5,7}20 or SM-T{3,5,7}20. Also fix a5y17lte->a7y17lte for SM-A720. Fixes: 3e2095e960b4 ("board: samsung: add support for Galaxy A series of 2017 (a5y17lte)") Signed-off-by: Henrik Grimler Reviewed-by: Dzmi

[PATCH v2 1/2] board: samsung: fix menu entries for a{3,7}y17lte

Signed-off-by: Henrik Grimler Reviewed-by: Dzmitry Sankouski --- Changes since v1: none, added Dzmitry's reviewed-by tag. --- arch/arm/mach-exynos/Kconfig | 6 +++--- board/samsung/axy17lte/Kconfig | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach-exynos/Kconfig

[PATCH 2/2] doc: board: avoid ambiguous names for axy17lte

Model names are SM-A{3,5,7}20, just SM-{3,5,7}20 could also refer to SM-J{3,5,7}20 or SM-T{3,5,7}20. Fixes: 3e2095e960b4 ("board: samsung: add support for Galaxy A series of 2017 (a5y17lte)") Signed-off-by: Henrik Grimler --- doc/board/samsung/axy17lte.rst | 6 +++--- 1 file

[PATCH 1/2] board: samsung: fix menu entries for a{3,7}y17lte

Signed-off-by: Henrik Grimler --- arch/arm/mach-exynos/Kconfig | 6 +++--- board/samsung/axy17lte/Kconfig | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig index 7f3aee571290..32b81728c389 100644 --- a/arch/arm/mach-exyn