Re: [PATCH 1/4] arm: mvebu: armada-3720-uDPU.dts: Change back to phy-mode "2500base-x"

2021-04-27 Thread Jakov Petrina 

Hi Stefan,

On 27/04/2021 11:48, Stefan Roese wrote:

With commit 8678776df6f5 (arm: mvebu: armada-3720-uDPU: fix PHY mode
definition to sgmii-2500) the PHY mode was switch to "sgmii-2500", even
when this is functionally incorrect since "2500base-x" was not supported
in U-Boot at that time. As this mode is now supported (at least present
in the headers), this patch moves back to the orinal version.



thanks, great to hear that the "2500base-x" PHY mode is now supported in 
U-Boot.



Signed-off-by: Stefan Roese 
Cc: Jakov Petrina 
Cc: Vladimir Vid 
Cc: Luka Perkov 
---
Jakov, Vladimir: This is completely untested. Could you please review
and let me know, if this works for you?



Unfortunately, I don't have the required hardware with me so I am not 
able to test the change.


Regards,

Jakov


Thanks,
Stefan

  arch/arm/dts/armada-3720-uDPU.dts | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/dts/armada-3720-uDPU.dts 
b/arch/arm/dts/armada-3720-uDPU.dts
index 4b30f3cea8c7..4bf6d2eac798 100644
--- a/arch/arm/dts/armada-3720-uDPU.dts
+++ b/arch/arm/dts/armada-3720-uDPU.dts
@@ -126,14 +126,14 @@
   {
pinctrl-0 = <_pins>;
status = "okay";
-   phy-mode = "sgmii-2500";
+   phy-mode = "2500base-x";
managed = "in-band-status";
phy = <>;
  };
  
   {

status = "okay";
-   phy-mode = "sgmii-2500";
+   phy-mode = "2500base-x";
managed = "in-band-status";
phy = <>;
  };

Re: [PATCH] arch: arm: uDPU: fix PHY mode definition to sgmii-2500

2020-05-23 Thread Jakov Petrina 

On 12/05/2020 12:02, Jakov Petrina wrote:

Commit f49ac7e1c4 switched the default PHY speed to 3.125Gbit to resolve
issues with SFP modules. However, U-Boot does not have a "2500base-x"
phy-mode.

Resolve this by using "sgmii-2500" instead.

Signed-off-by: Jakov Petrina 
Signed-off-by: Vladimir Vid 
Cc: Luka Perkov 
Cc: Stefan Roese 
---
  arch/arm/dts/armada-3720-uDPU.dts | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)



Hi Stefan,

I'm curious if there are any feedback or blockers on this patch?

Thanks,
Jakov


diff --git a/arch/arm/dts/armada-3720-uDPU.dts 
b/arch/arm/dts/armada-3720-uDPU.dts
index 07c7b91175..7f4b8222f4 100644
--- a/arch/arm/dts/armada-3720-uDPU.dts
+++ b/arch/arm/dts/armada-3720-uDPU.dts
@@ -125,14 +125,14 @@
   {
pinctrl-0 = <_pins>;
status = "okay";
-   phy-mode = "2500base-x";
+   phy-mode = "sgmii-2500";
managed = "in-band-status";
phy = <>;
  };
  
   {

status = "okay";
-   phy-mode = "2500base-x";
+   phy-mode = "sgmii-2500";
managed = "in-band-status";
phy = <>;
  };




--
Jakov Petrina

[PATCH] arch: arm: uDPU: fix PHY mode definition to sgmii-2500

2020-05-12 Thread Jakov Petrina 
Commit f49ac7e1c4 switched the default PHY speed to 3.125Gbit to resolve
issues with SFP modules. However, U-Boot does not have a "2500base-x"
phy-mode.

Resolve this by using "sgmii-2500" instead.

Signed-off-by: Jakov Petrina 
Signed-off-by: Vladimir Vid 
Cc: Luka Perkov 
Cc: Stefan Roese 
---
 arch/arm/dts/armada-3720-uDPU.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/dts/armada-3720-uDPU.dts 
b/arch/arm/dts/armada-3720-uDPU.dts
index 07c7b91175..7f4b8222f4 100644
--- a/arch/arm/dts/armada-3720-uDPU.dts
+++ b/arch/arm/dts/armada-3720-uDPU.dts
@@ -125,14 +125,14 @@
  {
pinctrl-0 = <_pins>;
status = "okay";
-   phy-mode = "2500base-x";
+   phy-mode = "sgmii-2500";
managed = "in-band-status";
phy = <>;
 };
 
  {
status = "okay";
-   phy-mode = "2500base-x";
+   phy-mode = "sgmii-2500";
managed = "in-band-status";
phy = <>;
 };
-- 
2.26.2

[PATCH v2] arm: dts: uDPU: switch default PHY speed to 3.125Gbit

2020-04-24 Thread Jakov Petrina 
This resolves issues with certain SFP modules.

Signed-off-by: Jakov Petrina 
Signed-off-by: Vladimir Vid 
---

v2:
- changed PHY mode as well

 arch/arm/dts/armada-3720-uDPU.dts | 18 ++
 1 file changed, 6 insertions(+), 12 deletions(-)

diff --git a/arch/arm/dts/armada-3720-uDPU.dts 
b/arch/arm/dts/armada-3720-uDPU.dts
index 683dac2a7c..07c7b91175 100644
--- a/arch/arm/dts/armada-3720-uDPU.dts
+++ b/arch/arm/dts/armada-3720-uDPU.dts
@@ -109,11 +109,11 @@
  {
phy0 {
phy-type = ;
-   phy-speed = ;
+   phy-speed = ;
};
 phy1 {
 phy-type = ;
-phy-speed = ;
+phy-speed = ;
 };
 
 phy2 {
@@ -125,22 +125,16 @@
  {
pinctrl-0 = <_pins>;
status = "okay";
-   phy-mode = "sgmii";
+   phy-mode = "2500base-x";
+   managed = "in-band-status";
phy = <>;
-   fixed-link {
-   speed = <1000>;
-   full-duplex;
-   };
 };
 
  {
status = "okay";
-   phy-mode = "sgmii";
+   phy-mode = "2500base-x";
+   managed = "in-band-status";
phy = <>;
-   fixed-link {
-   speed = <1000>;
-   full-duplex;
-   };
 };
 
  {
-- 
2.24.1

[PATCH] arm: dts: uDPU: switch default PHY speed to 3.125Gbit

2020-04-22 Thread Jakov Petrina 
This resolves issues with certain SFP modules.

Signed-off-by: Jakov Petrina 
Signed-off-by: Vladimir Vid 
---
 arch/arm/dts/armada-3720-uDPU.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/dts/armada-3720-uDPU.dts 
b/arch/arm/dts/armada-3720-uDPU.dts
index 683dac2a7c..d528f07ec0 100644
--- a/arch/arm/dts/armada-3720-uDPU.dts
+++ b/arch/arm/dts/armada-3720-uDPU.dts
@@ -109,11 +109,11 @@
  {
phy0 {
phy-type = ;
-   phy-speed = ;
+   phy-speed = ;
};
 phy1 {
 phy-type = ;
-phy-speed = ;
+phy-speed = ;
 };
 
 phy2 {
-- 
2.24.1