Re: [PATCH v2 2/2] rockchip: spl-boot-order: show DT path for missing device

2024-03-14 Thread Philipp Tomsich
an Simic > Signed-off-by: Christopher Obbard Reviewed-by: Philipp Tomsich

Re: [PATCH 13/17] mmc: rockchip_sdhci: Add support for RK3588

2023-04-03 Thread Philipp Tomsich
On Mon, 3 Apr 2023 at 22:48, Jonas Karlman wrote: > > Add support for RK3588 to the sdhci driver. RK3588 has the inverter flag > in TXCLK reg instead of RXCLK and also make use of a new CMDOUT reg. > Add and use a quirks field to support such quirks. > > Signed-off-by: Jonas Karlman > --- >

Re: [PATCH] rockchip: rk3328: Set VOP QoS to high priority

2023-01-04 Thread Philipp Tomsich
On Sat, 23 Jul 2022 at 13:29, Nicolas Frattaroli wrote: > > The default priority for the quality of service for the video > output results in unsightly glitches on the output whenever there > is memory pressure on the system, which happens a lot. > > This sets the VOP QoS to high priority, which

Re: [PATCH 2/2] rockchip: mkimage: make RC4 key const

2022-11-18 Thread Philipp Tomsich
On Fri, 18 Nov 2022 at 17:13, John Keeping wrote: > > This is read-only data, so mark it as such. > > Signed-off-by: John Keeping Reviewed-by: Philipp Tomsich

Re: [PATCH 1/2] rc4: mark key as const

2022-11-18 Thread Philipp Tomsich
On Fri, 18 Nov 2022 at 17:13, John Keeping wrote: > > Key data is never written so the parameter can be const, which allows > putting fixed keys in .rodata. > > Signed-off-by: John Keeping Reviewed-by: Philipp Tomsich

Re: [RFC PATCH 4/8] rockchip: pad u-boot-rockchip.bin correctly

2022-07-15 Thread Philipp Tomsich
On Fri, 15 Jul 2022 at 17:37, Quentin Schulz wrote: > > From: Quentin Schulz > > On MMC storage media, the TPL/SPL needs to be flashed at offset 32KB. > Instead of requesting the user to put the input the appropriate offsets, > let's create u-boot-rockchip.bin with the padding already added.

Re: [PATCH] rockchip: rk3308: fix same-as-spl boot order

2022-07-14 Thread Philipp Tomsich
On Thu, 14 Jul 2022 at 16:18, John Keeping wrote: > > Rockchip SoCs need the boot_devices array defined in order to map the > bootloader's value to a U-Boot device. Implement this for rk3308. > > Signed-off-by: John Keeping Reviewed-by: Philipp Tomsich

Re: [PATCH 2/2] rockchip: rk3399: fix incorrect ifdef check on SPL_GPIO

2022-07-12 Thread Philipp Tomsich
On Tue, 12 Jul 2022 at 17:38, Quentin Schulz wrote: > > From: Quentin Schulz > > The check to perform is on CONFIG_SPL_GPIO and not SPL_GPIO. > Because this was never compiled in, it missed an include of cru.h that > was not detected before. Let's include it too. > > Fixes: 07586ee4322a

Re: [PATCH 1/2] rockchip: rk3399: fix incorrect ifdef check on SPL_DM_REGULATOR

2022-07-12 Thread Philipp Tomsich
On Tue, 12 Jul 2022 at 17:38, Quentin Schulz wrote: > > From: Quentin Schulz > > The check to perform is on CONFIG_SPL_DM_REGULATOR and not > SPL_DM_REGULATOR. > > Fixes: 07586ee4322a ("rockchip: rk3399: Support common spl_board_init") > Cc: Quentin Schulz > Signed-off-by: Quentin Schulz > ---

Re: [PATCH V4 6/6] arm: set cntfrq_el0 if CONFIG_COUNTER_FREQUENCY is valid

2022-04-13 Thread Philipp Tomsich
On Wed, 13 Apr 2022 at 11:07, Peng Fan (OSS) wrote: > > From: Peng Fan > > Since COUNTER_FREQUENCY is obselete, so set cntfrq_el0 if > CONFIG_COUNTER_FREQUENCY is valid > > Signed-off-by: Peng Fan Reviewed-by: Philipp Tomsich

Re: [PATCH v1 06/11] rockchip: handle bootrom recovery mode in spl

2022-03-14 Thread Philipp Tomsich
On Tue, 22 Feb 2022 at 02:31, Peter Geis wrote: > > Fixup the bootrom recovery mode code to function in spl, so we can > handle recovery mode in case u-boot loading is broken. > > Signed-off-by: Peter Geis > --- > arch/arm/mach-rockchip/Makefile| 6 +++--- >

Re: No u-boot-rockchip pull request sent or merged for v2022.04

2022-03-11 Thread Philipp Tomsich
On Fri, 11 Mar 2022 at 19:15, Alper Nebi Yasak wrote: > > On 11/03/2022 18:43, Tom Rini wrote: > > On Fri, Mar 11, 2022 at 12:05:42AM +0300, Alper Nebi Yasak wrote: > >> I have a few Rockchip-related series [1] that I was expecting to land > >> for v2022.04 (including improvements for

Re: [PATCH v2] rockchip: puma/lion: update MAINTAINERS file

2022-01-03 Thread Philipp Tomsich
On Mon, 3 Jan 2022 at 13:04, wrote: > > From: Quentin Schulz > > Philipp does not work at Theobroma Systems anymore so let's swap > Philipp's address with mine. > > Cc: Philipp Tomsich > Cc: Quentin Schulz > Signed-off-by: Quentin Schulz Reviewed-by: Philipp Tomsich

Re: [PATCH 4/4] rk3399: Don't enable the debug UART if there is no driver

2021-11-03 Thread Philipp Tomsich
On Wed, 3 Nov 2021 at 14:16, Simon Glass wrote: > > Some boards do not enable SPL_SERIAL so cannot use the debug UART. Add > this condition to the code and drop use of the preprocessor while we are > here. > > Signed-off-by: Simon Glass Reviewed-by: Philipp Tomsich

Re: [PATCH v2 3/3] rockchip: rk3568: add arch_cpu_init()

2021-10-25 Thread Philipp Tomsich
On Mon, 25 Oct 2021 at 08:34, Nico Cheng wrote: > > We configured the drive strength and security of EMMC in > arch_cpu_init(). > > Signed-off-by: Nico Cheng > --- > > Changes in v2: > We use the rk_clrreg function instead of the writel to set eMMC sdmmc0 to > secure. > Modify comments to make

Re: [PATCH v2 2/3] arm: dts: rockchip: rk3568: Enable sdhci and sdmmc0 node

2021-10-25 Thread Philipp Tomsich
On Mon, 25 Oct 2021 at 08:34, Nico Cheng wrote: > > Enable sdhci and sdmmc0 node in rk3568-u-boot.dtsi > > Signed-off-by: Nico Cheng Reviewed-by: Philipp Tomsich

Re: [PATCH v2 1/3] rockchip: Kconfig: Enable SPL support for rk3568

2021-10-25 Thread Philipp Tomsich
On Mon, 25 Oct 2021 at 08:34, Nico Cheng wrote: > > Enable SPL support in Kconfig and add some related option in > rk3568_common.h > > Signed-off-by: Nico Cheng > Signed-off-by: Jason Zhu Acked-by: Philipp Tomsich

Re: [PATCH v1 3/3] rockchip: rk3568: add arch_cpu_init()

2021-10-08 Thread Philipp Tomsich
On Fri, 8 Oct 2021 at 04:01, Nico Cheng wrote: > > We configured the drive strength and security of EMMC in > arch_cpu_init(). Could you point me to a public version of the TRM (and ideally also of the datasheet), so I can review this series? Thanks, Philipp. > > Signed-off-by: Nico Cheng >

Re: [PATCH v7 6/6] rockchip: px30: Support configure SFC

2021-08-11 Thread Philipp Tomsich
On Thu, 5 Aug 2021 at 10:28, Jon Lin wrote: > > Make px30 SFC clock configurable > > Signed-off-by: Jon Lin Reviewed-by: Philipp Tomsich

Re: [PATCH v7 4/6] mtd: spi-nor-ids: Add XTX XT25F128B

2021-08-11 Thread Philipp Tomsich
ame > manufacturer/ID. > > Signed-off-by: Chris Morgan > Signed-off-by: Jon Lin Reviewed-by: Philipp Tomsich

Re: [PATCH v7 1/6] spi: rockchip_sfc: add support for Rockchip SFC

2021-08-11 Thread Philipp Tomsich
f used, must also be disabled in SPL > mode when using A-TF anyway. > > Signed-off-by: Chris Morgan > Signed-off-by: Jon Lin Reviewed-by: Philipp Tomsich

Re: [PATCH v3 2/3] mmc: rockchip_sdhci: Add support for RK3568

2021-08-11 Thread Philipp Tomsich
On Tue, 29 Jun 2021 at 10:24, Yifeng Zhao wrote: > > This patch adds support for the RK3568 platform to this driver. > > Signed-off-by: Yifeng Zhao I thought I had raised an objection to this patch previously, but did not see a discussion... So here we go again. In 2017, we decided to split

Re: [PATCH v3 3/3] rockchip: config: evb-rk3399: add hs400 and SDMA support

2021-08-11 Thread Philipp Tomsich
On Tue, 29 Jun 2021 at 10:25, Yifeng Zhao wrote: > > This enable hs400 and SDMA support for emmc on evb-rk3399. > > Signed-off-by: Yifeng Zhao Reviewed-by: Philipp Tomsich

Re: [PATCH] rk3399: Add basic support for helios64

2021-07-22 Thread Philipp Tomsich
On Thu, 22 Jul 2021 at 01:14, Dennis Gilmore wrote: > > From: Dennis Gilmore > > This is a stripped down version of the vendor U-Boot patch by Aditya > Prayoga found in the armbian repository. This patch is enough to have > the 1G ethernet port, the micro SD card, eMMC, PCIe and UART. It sets >

Re: [PATCH v2 0/3]

2021-06-28 Thread Philipp Tomsich
I had attempted to merge HDMI using this approach in 2017, but after some discussions with Simon, we used a 'mini-drivers' approach. I would like to see a similar approach taken here. See

Re: [PATCH v2 3/3] rockchip: config: evb-rk3399: add hs200 and hs400 support

2021-06-28 Thread Philipp Tomsich
On Mon, 28 Jun 2021 at 11:20, Yifeng Zhao wrote: > > This enable hs200 and hs400 support for emmc on evb-rk3399. > > Signed-off-by: Yifeng Zhao Reviewed-by: Philipp Tomsich

Re: [PATCH 0/4] Use just one DTS file for all Espressobin variants

2020-12-02 Thread Philipp Tomsich
> On 02.12.2020, at 13:37, Andre Heider wrote: > > On 02/12/2020 11:35, Stefan Roese wrote: >> On 02.12.20 10:12, Pali Rohár wrote: >>> On Wednesday 02 December 2020 09:09:15 Stefan Roese wrote: On 02.12.20 01:33, Pali Rohár wrote: > On Wednesday 25 November 2020 19:20:06 Pali Rohár

Re: [PATCH 3/3] patman: fix project-defaults not propagating into parsers

2020-11-26 Thread Philipp Tomsich
Simon, On Wed, 25 Nov 2020 at 16:30, Simon Glass wrote: > Here is a pointer to the docs I saw: > > https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.set_defaults > > "Parser-level defaults can be particularly useful when working with > multiple parsers. See the

Re: [PATCH 3/3] patman: fix project-defaults not propagating into parsers

2020-11-26 Thread Philipp Tomsich
Simon, On Wed, 25 Nov 2020 at 00:41, Simon Glass wrote: > According to the Python documentation and my testing, it should > propagate. Do you know what is going wrong here? If there is a > problem, we should update the comment. I don't see any code for propagating this in the argparse module:

Re: [PATCH 3/3] patman: fix project-defaults not propagating into parsers

2020-11-26 Thread Philipp Tomsich
t; > for the gcc project) are settings from subparsers, these would still > > require an explicit commandline option mirroring the (ignored) default. > > > > This change ensures that defaults are updated in all parsers. > > > > Signed-off-by: Philipp Tomsich >

[PATCH 2/3] patman: Add project-default for 'gcc'

2020-11-24 Thread Philipp Tomsich
Add defaults for FSF/GNU projects, such as gcc, that provide sensible settings for those projects. Signed-off-by: Philipp Tomsich --- tools/patman/settings.py | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tools/patman/settings.py b/tools/patman/settings.py index

[PATCH 1/3] patman: Add --no-signoff to suppress adding signoffs

2020-11-24 Thread Philipp Tomsich
To enable use of patman with FSF/GNU projects, such as GCC or Binutils, no Signed-off-by may be added. This adds a command line flag '--no-signoff' to suppress adding signoffs in patman when processing commits. Signed-off-by: Philipp Tomsich --- tools/patman/control.py | 6 +++--- tools

[PATCH 3/3] patman: fix project-defaults not propagating into parsers

2020-11-24 Thread Philipp Tomsich
commandline option mirroring the (ignored) default. This change ensures that defaults are updated in all parsers. Signed-off-by: Philipp Tomsich --- tools/patman/settings.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/patman/settings.py b/tools/patman/settings.py index

Re: [PATCH] ram: rockchip: px30: add a config-based ddr selection

2020-10-30 Thread Philipp Tomsich
gt; or LPDDR2/3 initialized would require a code modification. > > So add Kconfig options similar to RK3399 to allow selecting the DDR4 > and LPDDR2/3 options instead, while DDR3 stays the default as before. > > Signed-off-by: Heiko Stuebner Reviewed-by: Philipp Tomsich

Re: [PATCH] clk: rockchip: rk3399: implement getting wdt/alive clocks

2020-09-17 Thread Philipp Tomsich
> On 17.09.2020, at 11:42, Jack Mitchell wrote: > > In order to correctly calculate the designware watchdog > timeouts, the watchdog clock is required. Implement required > clocks to facilitate this. > > Signed-off-by: Jack Mitchell Reviewed-by: Philipp Tomsich

Re: [PATCH] pci: rockchip: Mark inline functions as static inline

2020-07-02 Thread Philipp Tomsich
> On 01.07.2020, at 17:47, Tom Rini wrote: > > Unless we mark the function as 'static inline' it may end up being > non-inlined by the compiled and result in duplicate functions. > > Cc: Jagan Teki > Cc: Kever Yang > Signed-off-by: Tom Rini Reviewed-by: Philipp Tomsich

Re: [PATCH 1/2] net: phy: mscc: make clock-output configurable on vsc85xx

2020-06-09 Thread Philipp Tomsich
is follows a similar change introduced into the Linux kernel at > https://lore.kernel.org/netdev/20200609133140.1421109-2-he...@sntech.de > > Signed-off-by: Heiko Stuebner Reviewed-by: Philipp Tomsich

Re: [PATCH 2/2] net: phy: mscc: sync rx/tx delay settings with Linux on vsc85xx

2020-06-09 Thread Philipp Tomsich
y delay values like now, mimic this behaviour. > > The behaviour is the same for all of vsc8530/8531/8540/8541 so move that > to a shared function while at it. > > Signed-off-by: Heiko Stuebner Reviewed-by: Philipp Tomsich

Re: [PATCH v3 7/8] rockchip: puma: drop special handling of usb host regulator

2020-06-05 Thread Philipp Tomsich
d with mass-storage and usb-ethernet on both usb3 and usb2 ports. > > Signed-off-by: Heiko Stuebner > Reviewed-by: Kever Yang Reviewed-by: Philipp Tomsich

Re: [PATCH v3 2/8] arm64: dts: rk3399-puma: fix gpio levels for vcc5v0-host regulator

2020-06-05 Thread Philipp Tomsich
nging them in sync again. > > This mimics the upstream Linux change found on: > http://lore.kernel.org/r/20200604091239.424318-1-he...@sntech.de > > Signed-off-by: Heiko Stuebner > Reviewed-by: Kever Yang Reviewed-by: Philipp Tomsich

Re: [PATCH v3 1/4] Makefile: Drop to handle rkspi image type

2020-06-04 Thread Philipp Tomsich
> On 04.06.2020, at 16:51, Jagan Teki wrote: > > On rockchip platforms, SPI boot image creation is not > straightforward like MMC boot image creation where former > requires to specify tpl, spl in multimage format in mkimage, > and later simply do a concatenate mkimaged-tpl with spl. > > On

Re: [PATCH v2 8/8] rockchip: puma: enable new usb config options

2020-06-04 Thread Philipp Tomsich
: Heiko Stuebner Reviewed-by: Philipp Tomsich

Re: [PATCH 6/6] board: puma: remove separate fit generator

2020-06-03 Thread Philipp Tomsich
were done. > > And even then, if changes need to be made, this can very well also > happen in the atf context itself, so there is no real need to > diverge from the established build procedure and we can just go > back to using the main make_fit_atf.py script. > > Signed-off-by: Heiko Stuebner Reviewed-by: Philipp Tomsich

Re: [PATCH 1/6] arm64: dts: rk3399-puma: fix gpio levels for gmac reset pin

2020-06-03 Thread Philipp Tomsich
upstream Linus commit found on > https://lore.kernel.org/r/20200603132836.362519-1-he...@sntech.de > > Signed-off-by: Heiko Stuebner Reviewed-by: Philipp Tomsich

Re: [PATCH 2/6] board: puma: fix indentation for -u-boot.dtsi

2020-06-03 Thread Philipp Tomsich
> On 03.06.2020, at 16:59, Heiko Stuebner wrote: > > From: Heiko Stuebner > > Tabs not spaces, so transform it to the common styling. > > Signed-off-by: Heiko Stuebner Reviewed-by: Philipp Tomsich

Re: [PATCH 4/6] board: puma: fix indentation of misc_init_r

2020-06-03 Thread Philipp Tomsich
e rockchip_* helpers to setup cpuid and > macaddr") > Signed-off-by: Heiko Stuebner Reviewed-by: Philipp Tomsich

Re: [PATCH 5/6] board: puma: allow building with TPL as well

2020-06-03 Thread Philipp Tomsich
SPL_TEXT_BASE it is easy > to enable a TPL build as well. Only obstacle is the usb-specific handling > for the puma regulator, so make this conditional on actual usb options > being enabled in SPL and U-Boot proper. > > Signed-off-by: Heiko Stuebner Reviewed-by: Philipp Tomsich

Re: [PATCH 3/6] board: puma: reorganize devicetrees to actually work and match upstream

2020-06-03 Thread Philipp Tomsich
e sd-slot, uarts, etc. > > So to untagle this and bring the whole thing more in line with mainline > Linux, bring the rk3399-puma-haikou.dts over as well, drop the separate > DDR-option devicetrees and instead replace them with a puma Kconfig option > to select and include the needed DDR variant. > > Signed-off-by: Heiko Stuebner Reviewed-by: Philipp Tomsich

Re: [PATCH v2 2/2] spl: add fixed memory node in target fdt also when loading ATF

2020-05-25 Thread Philipp Tomsich
he > ATF path as well. > > Signed-off-by: Heiko Stuebner > Reviewed-by: Kever Yang Reviewed-by: Philipp Tomsich

Re: [PATCH v5 4/8] lib: rsa: fix allocated size for rr and rrtmp in rsa_gen_key_prop()

2020-05-25 Thread Philipp Tomsich
; increased in the future. > > Signed-off-by: Heiko Stuebner Reviewed-by: Philipp Tomsich

Re: [PATCH v4 5/8] lib: rsa: free local arrays after use in rsa_gen_key_prop()

2020-05-22 Thread Philipp Tomsich
t used anymore > when returning from the function and should of course be freed. > > Signed-off-by: Heiko Stuebner Reviewed-by: Philipp Tomsich

Re: [PATCH v4 6/8] lib: rsa: add documentation to padding_pss_verify to document limitations

2020-05-22 Thread Philipp Tomsich
issible value), which makes > verifications of signatures with that saltlen fail. > > Until this gets implemented at least document this behaviour. > > Signed-off-by: Heiko Stuebner Reviewed-by: Philipp Tomsich

Re: [PATCH v4 2/8] lib: rsa: take spl/non-spl into account when building rsa_verify_with_pkey()

2020-05-22 Thread Philipp Tomsich
led for SPL, for example to > verify u-boot proper from spl. > > So fix this by using the existing helpers to distinguis between > build-steps. > > Signed-off-by: Heiko Stuebner Reviewed-by: Philipp Tomsich

Re: [PATCH v4 3/8] lib: rsa: bring exp_len in line when generating a key_prop

2020-05-22 Thread Philipp Tomsich
the established code. > > Signed-off-by: Heiko Stuebner Reviewed-by: Philipp Tomsich

Re: [PATCH v3 1/4] lib: rsa: distinguish between tpl and spl for CONFIG_RSA_VERIFY

2020-05-18 Thread Philipp Tomsich
to $(SPL_TPL_) to distinguish > between both. If someone really needs FIT signature checking in > TPL as well, a new TPL_RSA_VERIFY config symbol needs to be added. > > Signed-off-by: Heiko Stuebner > Reviewed-by: Philipp Tomsich > Reviewed-by: Kever Yang > --- > changes in v2:

Re: [PATCH] rsa: fix alignment issue when getting public exponent

2020-05-03 Thread Philipp Tomsich
> conversion from the dt's big-endian to the needed uint64 value. > > Fixes: fc2f4246b4b3 ("rsa: Split the rsa-verify to separate the modular > exponentiation") > Signed-off-by: Heiko Stuebner Reviewed-by: Philipp Tomsich

Re: [PATCH 1/7] spl: fit: select SPL_HASH_SUPPORT for SPL_FIT_SIGNATURE

2020-04-17 Thread Philipp Tomsich
; > So similar to the main FIT_SIGNATURE entry selects HASH, > select SPL_HASH_SUPPORT for SPL_FIT_SIGNATURE. > > Cc: Heinrich Schuchardt > Signed-off-by: Heiko Stuebner Reviewed-by: Philipp Tomsich

Re: [PATCH 5/7] spl: fit: enable signing a generated u-boot.itb

2020-04-17 Thread Philipp Tomsich
ey to get included. > > Signed-off-by: Heiko Stuebner Reviewed-by: Philipp Tomsich

Re: [PATCH 2/7] spl: fit: select SPL_CRYPTO_SUPPORT for SPL_FIT_SIGNATURE

2020-04-17 Thread Philipp Tomsich
gt; option to not end up in compile errors like: > >u-boot/lib/rsa/rsa-verify.c:328: undefined reference to `rsa_mod_exp' > > So select SPL_CRYPTO_SUPPORT in SPL_FIT_SIGNATURE. > > Signed-off-by: Heiko Stuebner Reviewed-by: Philipp Tomsich

Re: [PATCH 3/7] lib: rsa: distinguish between tpl and spl for CONFIG_RSA_VERIFY

2020-04-17 Thread Philipp Tomsich
is nit: distinguis -> distinguish > between both. If someone really needs FIT signature checking in > TPL as well, a new TPL_RSA_VERIFY config symbol needs to be added. > > Signed-off-by: Heiko Stuebner Reviewed-by: Philipp Tomsich

Re: [PATCH 6/7] spl: fit: add Kconfig option to specify key-hint for fit_generator

2020-04-17 Thread Philipp Tomsich
FIG_SPL_FIT_GENERATOR. > > In the script-case it will need to know what key to include for the > key-hint and specified algorithm, so add an option for that key-name. > > Signed-off-by: Heiko Stuebner Reviewed-by: Philipp Tomsich

Re: [PATCH] rockchip: rk3399: enable spl-fifo-mode for sdmmc

2020-04-15 Thread Philipp Tomsich
> On 15.04.2020, at 05:25, Deepak Das wrote: > > adapting commit fa2047c47310 ("rockchip: rk3328: enable spl-fifo-mode > for emmc and sdmmc") for rk3399. > Since mmc to sram can't do dma, add patch to prevent aborts transferring > TF-A parts. > > Signed-off-by: Deepak Das > --- >

Re: [PATCH 1/6] rockchip: efuse: Add support for rk3288 efuse

2020-03-02 Thread Philipp Tomsich
> On 20.02.2020, at 04:10, Finley Xiao wrote: > > This adds the necessary data for handling eFuse on the rk3288. > > Signed-off-by: Finley Xiao Reviewed-by: Philipp Tomsich Major rework required: see below. > --- > drivers/misc/

Re: [PATCH 1/2] Revert "rockchip: spi: fix off-by-one in chunk size computation"

2019-12-11 Thread Philipp Tomsich
> On 11.12.2019, at 14:26, Jagan Teki wrote: > > The maximum transfer length (in a single transaction) for the Rockchip > SPI controller is 64Kframes (i.e. 0x1 frames) of 8bit or 16bit > frames and is encoded as (num_frames - 1) in CTRLR1. > > So the 0x1 is offset value for 64K but

Re: [U-Boot] [PATCH 2/2] rockchip: px30: Add support for using UART3 as debug UART

2019-11-28 Thread Philipp Tomsich
Heiko, > On 28.11.2019, at 10:44, Heiko Stuebner > wrote: > > On 27.11.19 11:12, Paul Kocialkowski wrote: >> Some generic PX30 SoMs found in the wild use UART3 as their debug output >> instead of UART2 (used for MMC) and UART5. >> >> Make it possible to use UART3 as early debug output, with

Re: [U-Boot] [PATCH 3/4] rockchip: px5: enable spl-fifo-mode for emmc for px5-evb

2019-11-26 Thread Philipp Tomsich
> On 26.11.2019, at 14:15, Andy Yan wrote: > > We need load some parts of ATF to sram, but rockchip > dwmmc controllers can't do dma to non-ddr addresses > space, so set the mmc controller into fifo mode in spl. > > Signed-off-by: Andy Yan Reviewe

Re: [U-Boot] [PATCH v2 2/2] rockchip: px30: enable spl-fifo-mode for both emmc and sdmmc on evb

2019-11-20 Thread Philipp Tomsich
ot correctly > put both mmc controllers into fifo-mode, which also circumvents the > issue for now. > > Signed-off-by: Heiko Stuebner Reviewed-by: Philipp Tomsich ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 1/2] rockchip: dwmmc: add handling for u-boot, spl-fifo-mode

2019-11-20 Thread Philipp Tomsich
Sorry, I was confused and meant... > On 20.11.2019, at 12:09, Philipp Tomsich > wrote: > > > >> On 19.11.2019, at 12:04, Heiko Stuebner wrote: >> >> From: Heiko Stuebner >> >> Rockchips dwmmc controllers can't do dma to non-ddr address

Re: [U-Boot] [PATCH v2 1/2] rockchip: dwmmc: add handling for u-boot, spl-fifo-mode

2019-11-20 Thread Philipp Tomsich
IT image. > > So add handling for a u-boot,spl-fifo-mode to not put the mmc > controllers into fifo mode for all time. > > The regular fifo-mode property still takes precedent and only > if not set do we check for the spl-specific property. > > Suggested-by: Philipp Tomsich

Re: [U-Boot] [PATCH] rockchip: px30: enable fifo mode for both emmc and sdmmc on evb

2019-11-19 Thread Philipp Tomsich
Heiko, > On 19.11.2019, at 11:03, Heiko Stuebner wrote: > > From: Heiko Stuebner > > As part of loading trustedfirmware, the SPL is required to place portions > of code into the socs sram but the mmc controllers can only do dma > transfers into the regular memory, not sram. > > The results

Re: [U-Boot] [PATCH v0] rockchip: adding the missing "/" in entries of boot_devices

2019-10-17 Thread Philipp Tomsich
refix. > Therefore add the missing ones in other boards. Good catch. One can thus tell what platform I originally tested this on ;-) > Signed-off-by: Levin Du Reviewed-by: Philipp Tomsich ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] rockchip: misc: read the correct number of bytes from the efuse

2019-09-25 Thread Philipp Tomsich
ive ethaddr from cpuid") > Signed-off-by: Heiko Stuebner Reviewed-by: Philipp Tomsich ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Should I create a new UCLASS for Bootstate or Add new Ops to UCLASS_BOOTCOUNT ??

2019-09-09 Thread Philipp Tomsich
Joel, > On 10.09.2019, at 01:07, Simon Glass wrote: > > Hi Joel, > > On Sat, 7 Sep 2019 at 18:34, Joel Peshkin wrote: >> >> >> Hi Simon, >> >> I need to create and upstream driver for a set of functions that manage >> volatile information that persist across reboots. These are simple

Re: [U-Boot] [PATCH v2 2/7] rockchip: ram: add full feature rk3328 DRAM driver

2019-08-05 Thread Philipp Tomsich
Kever, > On 02.08.2019, at 09:39, Matwey V. Kornilov wrote: > > From: Kever Yang > > This driver supports DDR3/LPDDR3/DDR4 SDRAM initialization. How is the unified driver for the Designware DRAM controller coming along? We’ve had that discussion over a year ago and it seems as if we’re still

Re: [U-Boot] [PATCH v3 3/3] board: puma: Use rockchip_* helpers to setup cpuid and macaddr【请注意,邮件由u-boot-boun...@lists.denx.de代发】 setup cpuid and macaddr

2019-07-25 Thread Philipp Tomsich
> On 25.07.2019, at 18:39, Rohan Garg wrote: > > Hey > On Wednesday, 24 July 2019 14:26:44 CEST Kever Yang wrote: >> Hi Rohan, >> >> On 2019/7/24 下午7:09, Rohan Garg wrote: >>> We should use the shared helpers to setup the necessary parts >>> >>> Signed-off-by: Rohan Garg >>> --- >>> >>>

Re: [U-Boot] [PATCH 1/1] rockchip: video: rk3288_hdmi: Add missing call to dw_hdmi_enable()

2019-07-15 Thread Philipp Tomsich
> On 14.07.2019, at 12:40, Niklas Schulze wrote: > > The RK3288 HDMI driver's rk3288_hdmi_enable() currently lacks a call to > dw_hdmi_enable(). Thus, the HDMI output never gets enabled. > > Signed-off-by: Niklas Schulze > Cc: Philipp Tomsich Reviewe

Re: [U-Boot] [PATCH 3/3] board: puma: Use rockchip_* helpers to setup cpuid and macaddr

2019-07-11 Thread Philipp Tomsich
> On 11.07.2019, at 18:28, Rohan Garg wrote: > > Signed-off-by: Rohan Garg Your commit message is empty on this one. Please revise. Thanks, Philipp. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH V2 41/51] spl: pass args to board_return_to_bootrom

2019-07-10 Thread Philipp Tomsich
> On 08.07.2019, at 03:40, Peng Fan wrote: > > Pass spl_image and bootdev to board_return_bootrom. > i.MX8MN needs the args to let ROM to load images > > Cc: Simon Glass > Cc: Philipp Tomsich > Cc: Kever Yang > Signed-off-by: Peng Fan R

Re: [U-Boot] [PATCH 4/4] rockchip: remove redundant pinctrl header including

2019-07-09 Thread Philipp Tomsich
> On 09.07.2019, at 15:55, Kever Yang wrote: > > No code is using this header file, remove it. You are not removing the header file, but are simply not including it. Thanks, Phil. ___ U-Boot mailing list U-Boot@lists.denx.de

Re: [U-Boot] [PATCH 00/92] ram: rk3399: Add LPDDR4 support

2019-06-12 Thread Philipp Tomsich
> On 12.06.2019, at 17:30, Jagan Teki wrote: > > On Tue, Jun 11, 2019 at 8:36 PM Philipp Tomsich > <mailto:philipp.toms...@theobroma-systems.com>> wrote: >> >> >> >>> On 11.06.2019, at 17:03, Jagan Teki wrote: >>> >&

Re: [U-Boot] [PATCH 00/92] ram: rk3399: Add LPDDR4 support

2019-06-11 Thread Philipp Tomsich
> On 11.06.2019, at 16:50, Jagan Teki wrote: > > Yes, it can be possible to break this series into multiple sub series > but idea here is to mark all the required changes to support LPDDR4 > in rk3399 in one set. if required we can break it from next versions. > > This is the initial set for

Re: [U-Boot] [PATCH 00/92] ram: rk3399: Add LPDDR4 support

2019-06-11 Thread Philipp Tomsich
> On 11.06.2019, at 17:03, Jagan Teki wrote: > > On Tue, Jun 11, 2019 at 8:23 PM Philipp Tomsich > wrote: >> >> >> >>> On 11.06.2019, at 16:50, Jagan Teki wrote: >>> >>> Yes, it can be possible to break this series into multiple

Re: [U-Boot] Bring tinker-rk3288 back into SPL size limit?

2019-06-10 Thread Philipp Tomsich
+Kever. > On 08.06.2019, at 20:05, Tom Rini wrote: > > Hey, > > With Heinrich's series to enforce a size limit on SPL and Simon > Goldschmidt's enhancements on top of that, we're now seeing that > tinker-rk3288 has an SPL that is too large to function. And it's now > also causing the build to

Re: [U-Boot] [RESEND PATCH v7 00/11] rockchip: Add new rk3399 boards

2019-05-09 Thread Philipp Tomsich
Jagan, > On 09.05.2019, at 14:36, Jagan Teki wrote: > > On Thu, May 9, 2019 at 6:01 PM Paul Kocialkowski > mailto:paul.kocialkow...@bootlin.com>> wrote: >> >> Hi, >> >> On Thu, 2019-05-09 at 16:15 +0530, Jagan Teki wrote: >>> Hi Paul, >>> >>> On Thu, May 9, 2019 at 12:38 PM Paul Kocialkowski

[U-Boot] [PULL, RESEND] Please pull u-boot-rockchip/tags/rockchip-for-2019.07

2019-05-03 Thread Philipp Tomsich
() to rk322x.c rockchip: rk3288: use grf structure to access soc_con2 rockchip: rk3288: add board_debug_uart_init() rockchip: rk3368: move board_debug_uart_init() to rk3368.c rockchip: rk3399: use grf structure to access reg rockchip: rk3399: add board_debug_uart_init() Philipp

Re: [U-Boot] [PATCH 1/3] rockchip: arm: use 'arch-rockchip' for common header

2019-05-01 Thread Philipp Tomsich
> rockchip platform header file is in 'arch-rockchip' > instead of arch-$(SOC) for all SoCs. > > Signed-off-by: Kever Yang > Reviewed-by: Philipp Tomsich > --- > > arch/arm/cpu/armv8/start.S | 4 > arch/arm/include/asm/gpio.h | 2 +- > arch/arm/lib/vecto

Re: [U-Boot] [PATCH 2/3] rockchip: use 'arch-rockchip' as header file path

2019-05-01 Thread Philipp Tomsich
> Rockchip use 'arch-rockchip' instead of arch-$(SOC) as common > header file path, so that we can get the correct path directly. > > Signed-off-by: Kever Yang > Reviewed-by: Philipp Tomsich > --- > > .../include/asm/arch-rockchip/ddr_rk3188.h| 2 +- > arc

Re: [U-Boot] [PATCH 3/3] rockchip: correct ARCH_SOC name

2019-05-01 Thread Philipp Tomsich
> The ARCH_SOC name default as 'rockchip' and we put all the > header file in 'arch/arm/include/asm/arch-rockchip/', but > the 'rockchip' is not the SOC name, let's correct it after > we update all the source file. > > Signed-off-by: Kever Yang > Reviewed-by: Philipp Tomsiich > --- > >

Re: [U-Boot] [PATCH v2 09/10] rockchip: rk3399: use grf structure to access reg

2019-05-01 Thread Philipp Tomsich
> Prefer to use structure to access register if we could. > > Signed-off-by: Kever Yang > Reviewed-by: Philipp Tomsich > Tested-by: Andy Yan > --- > > arch/arm/mach-rockchip/rk3399/rk3399.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > Appl

Re: [U-Boot] [PATCH v2 07/10] rockchip: rk3288: add board_debug_uart_init()

2019-05-01 Thread Philipp Tomsich
> Use board_debug_uart_init() for UART iomux init instead of > do it in board_init_f, and move the function to soc file so > that we can find all the soc/board setting in soc file and > use a common board file for all rockchip SoCs later. > > Signed-off-by: Kever Yang >

Re: [U-Boot] [PATCH v2 03/10] rockchip: rk3036: add board_debug_uart_init()

2019-05-01 Thread Philipp Tomsich
> Use board_debug_uart_init() for UART iomux init instead of > do it in board_init_f, and move the function to soc file so > that we can find all the soc/board setting in soc file and > use a common board file. > > Signed-off-by: Kever Yang > Reviewed-by: Philipp Tomsich

Re: [U-Boot] [PATCH v2 10/10] rockchip: rk3399: add board_debug_uart_init()

2019-05-01 Thread Philipp Tomsich
> Use board_debug_uart_init() for UART iomux init instead of > do it in board_init_f, and move the function to soc file so > that we can find all the soc/board setting in soc file and > use a common board file for all rockchip SoCs later. > > Signed-off-by: Kever Yang >

Re: [U-Boot] [PATCH v2 08/10] rockchip: rk3368: move board_debug_uart_init() to rk3368.c

2019-05-01 Thread Philipp Tomsich
> Move the function to soc file so > that we can find all the soc/board setting in soc file and > use a common board file later for all rockchip SoCs. > > Signed-off-by: Kever Yang > Reviewed-by: Philipp Tomsich > Tested-by: Andy Yan > --- > > arch/arm/mach-ro

Re: [U-Boot] [PATCH v2 06/10] rockchip: rk3288: use grf structure to access soc_con2

2019-05-01 Thread Philipp Tomsich
> Prefer to use structure to access register if we can. > > Signed-off-by: Kever Yang > Reviewed-by: Philipp Tomsich > --- > > arch/arm/mach-rockchip/rk3288/rk3288.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > Applied

Re: [U-Boot] [PATCH v2 05/10] rockchip: rk322x: move board_debug_uart_init() to rk322x.c

2019-05-01 Thread Philipp Tomsich
> Move the function to soc file so > that we can find all the soc/board setting in soc file and > use a common board file later for all rockchip SoCs. > > Signed-off-by: Kever Yang > Reviewed-by: Philipp Tomsich > --- > > arch/arm/mach-rockc

Re: [U-Boot] [PATCH v2 04/10] rockchip: rk3188: add board_debug_uart_init()

2019-05-01 Thread Philipp Tomsich
> Use board_debug_uart_init() for UART iomux init instead of > do it in board_init_f, and move the function to soc file so > that we can find all the soc/board setting in soc file and > use a common board file. > > Signed-off-by: Kever Yang > Reviewed-by: Philipp Tomsich

Re: [U-Boot] [PATCH v2 02/10] rockchip; kylin-rk3036: enabl DEBUG UART

2019-05-01 Thread Philipp Tomsich
> Enable debug uart for kylin board in defconfig. > > Signed-off-by: Kever Yang > Reviewed-by: Philipp Tomsich > --- > > configs/kylin-rk3036_defconfig | 4 > 1 file changed, 4 insertions(+) > Applied to u-boot-rockchip, thanks! ___

Re: [U-Boot] [PATCH v2 01/10] rockchip: enable DEBUG_UART_BOARD_INIT by default

2019-05-01 Thread Philipp Tomsich
> All Rockchip SoCs use DEBUG_UART_BOARD_INIT to init per board > UART IOMUX, enable it by default. > > Signed-off-by: Kever Yang > Reviewed-by: Philipp Tomsich > --- > > arch/arm/Kconfig | 1 + > arch/arm/mach-rockchip/Kconfig | 4 > 2 fi

Re: [U-Boot] [PATCH 2/3] rockchip: use 'arch-rockchip' as header file path

2019-04-28 Thread Philipp Tomsich
h | 2 +- > include/configs/rk322x_common.h | 2 +- > include/configs/rk3288_common.h | 2 +- > include/configs/rk3368_common.h | 2 +- > include/configs/rv1108_common.h | 2 +- > 100 files changed, 288 insertions(+), 290 deletions(-) > Reviewed-by: Philipp Tomsich ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 06/10] rockchip: rk3288: use grf structure to access soc_con2

2019-04-28 Thread Philipp Tomsich
> Prefer to use structure to access register if we can. > > Signed-off-by: Kever Yang > --- > > arch/arm/mach-rockchip/rk3288/rk3288.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > Reviewed-by: Philipp Tomsich __

  1   2   3   4   5   6   7   8   9   10   >