Re: [U-Boot] [PATCH] efi_loader: initialise partition_signature memory

arisons. > > Corrects a problem where the loaded image protocol would not return a > device path with MEDIA_DEVICE causing the OpenBSD bootloader to fail > on rpi_3 and other targets. > > Signed-off-by: Jonathan Gray <j...@jsg.id.au> Reviewed-by: Rob Clark <robdcl...@gmail.com

[U-Boot] [PATCH] efi_loader: add missing breaks

Otherwise with GUID partition types you would end up with things like: .../HD(Part0,Sig6252c819-4624-4995-8d16-abc9cd5d4130)/HD(Part0,MBRType=02,SigType=02) Signed-off-by: Rob Clark <robdcl...@gmail.com> --- Reported by 'ykaukab' on IRC. Not sure if someone already sent a similar

Re: [U-Boot] [PATCH v2 01/18] efi_loader: efi_bootmgr: do not make hidden assignments

On Fri, Nov 17, 2017 at 12:46 PM, Heinrich Schuchardt <xypron.g...@gmx.de> wrote: > On 11/17/2017 03:04 PM, Rob Clark wrote: >> >> On Sun, Nov 12, 2017 at 9:02 AM, Heinrich Schuchardt <xypron.g...@gmx.de> >> wrote: >>> >>> Assignments should not b

Re: [U-Boot] [PATCH v2 01/18] efi_loader: efi_bootmgr: do not make hidden assignments

On Sun, Nov 12, 2017 at 9:02 AM, Heinrich Schuchardt wrote: > Assignments should not be made in the middle of nowhere. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > Call efi_dp_str in debug mode only. > --- > lib/efi_loader/efi_bootmgr.c | 6

Re: [U-Boot] [RFC] efi_loader: frame buffers in EFI GOP and DM_VIDEO

On Wed, Oct 25, 2017 at 3:45 PM, Heinrich Schuchardt wrote: > Hello Alex, hello Simon, > > I have just been reading through efi_gop and video_uclass.c and there seems > to be something missing in the support of video modes. > > U-Boot configuration knows the following color

Re: [U-Boot] [PATCH] efi_loader: Disable env_save() call on boot

rsistence and instead > implement it properly for the next one. > Acked-by: Rob Clark <robdcl...@gmail.com> > Reported-by: Heinrich Schuchardt <xypron.g...@gmx.de> > Fixes: ad644e7c182 ("efi_loader: efi variable support") > Signed-off-by: Alexander Graf <

Re: [U-Boot] [PATCH 3/3] efi_loader: Do not enable it by default for sunxi

On Thu, Oct 19, 2017 at 7:43 AM, Maxime Ripard wrote: > On Thu, Oct 19, 2017 at 10:12:36AM +0100, Peter Robinson wrote: >> On Thu, Oct 19, 2017 at 10:06 AM, Peter Robinson >> wrote: >> > On Thu, Oct 19, 2017 at 10:01 AM, Maxime Ripard >> >

Re: [U-Boot] Unexpected saving of all environment variables during EFI boot

On Thu, Oct 19, 2017 at 5:05 PM, Alexander Graf wrote: > > > On 19.10.17 22:40, Heinrich Schuchardt wrote: >> This was merged as >> ad644e7c18238026fecc647f62584d87d2c5b0a3 >> efi_loader: efi variable support >> >>> diff --git a/lib/efi_loader/efi_boottime.c

Re: [U-Boot] [PATCH 1/1] efi_loader: use named constant for memory type

On Tue, Oct 17, 2017 at 12:53 PM, Heinrich Schuchardt wrote: > When we call an EFI image from memory a memory device path > is created. The memory type should use a named constant. > > Fixes: bf19273e81e efi_loader: Add mem-mapped for fallback > Signed-off-by: Heinrich

Re: [U-Boot] [PATCH 07/11] efi_loader: fix events

On Fri, Oct 13, 2017 at 1:24 AM, Heinrich Schuchardt <xypron.g...@gmx.de> wrote: > > > On 10/10/2017 02:23 PM, Rob Clark wrote: >> >> An event can be created with type==0, Shell.efi does this for an event >> that is set when Ctrl-C is typed. So our current

Re: [U-Boot] [PATCH 06/11] efi_loader: Decouple EFI input/output from stdin/stdout

On Thu, Oct 12, 2017 at 7:48 PM, Heinrich Schuchardt <xypron.g...@gmx.de> wrote: > On 10/12/2017 11:26 PM, Rob Clark wrote: >> On Thu, Oct 12, 2017 at 6:38 PM, Heinrich Schuchardt <xypron.g...@gmx.de> >> wrote: >>> On 10/12/2017 04:28 PM, Rob Clark wrote:

Re: [U-Boot] [PATCH 06/11] efi_loader: Decouple EFI input/output from stdin/stdout

On Thu, Oct 12, 2017 at 6:38 PM, Heinrich Schuchardt <xypron.g...@gmx.de> wrote: > On 10/12/2017 04:28 PM, Rob Clark wrote: >> On Thu, Oct 12, 2017 at 9:50 AM, Alexander Graf <ag...@suse.de> wrote: >>> On 10/12/2017 03:40 PM, Rob Clark wrote: >>>> >

Re: [U-Boot] [PATCH 06/11] efi_loader: Decouple EFI input/output from stdin/stdout

On Thu, Oct 12, 2017 at 9:50 AM, Alexander Graf <ag...@suse.de> wrote: > On 10/12/2017 03:40 PM, Rob Clark wrote: >> >> On Thu, Oct 12, 2017 at 9:05 AM, Heinrich Schuchardt <xypron.g...@gmx.de> >> wrote: >>> >>> >>> On 10/12/2017 02:48 PM

Re: [U-Boot] [PATCH 06/11] efi_loader: Decouple EFI input/output from stdin/stdout

On Thu, Oct 12, 2017 at 9:44 AM, Mark Kettenis <mark.kette...@xs4all.nl> wrote: >> From: Rob Clark <robdcl...@gmail.com> >> Date: Thu, 12 Oct 2017 08:48:39 -0400 >> >> On Thu, Oct 12, 2017 at 3:15 AM, Alexander Graf <ag...@suse.de> wrote: >>

Re: [U-Boot] [PATCH 06/11] efi_loader: Decouple EFI input/output from stdin/stdout

On Thu, Oct 12, 2017 at 9:11 AM, Alexander Graf <ag...@suse.de> wrote: > On 10/12/2017 02:48 PM, Rob Clark wrote: >> >> On Thu, Oct 12, 2017 at 3:15 AM, Alexander Graf <ag...@suse.de> wrote: >>> >>> >>> On 12.10.17 00:07, Rob Clark wrote: >

Re: [U-Boot] [PATCH 06/11] efi_loader: Decouple EFI input/output from stdin/stdout

On Thu, Oct 12, 2017 at 9:05 AM, Heinrich Schuchardt <xypron.g...@gmx.de> wrote: > > > On 10/12/2017 02:48 PM, Rob Clark wrote: >> >> On Thu, Oct 12, 2017 at 3:15 AM, Alexander Graf <ag...@suse.de> wrote: >>> >>> >>> >>> On 12.

Re: [U-Boot] [PATCH 06/11] efi_loader: Decouple EFI input/output from stdin/stdout

On Thu, Oct 12, 2017 at 3:15 AM, Alexander Graf <ag...@suse.de> wrote: > > > On 12.10.17 00:07, Rob Clark wrote: >> On Wed, Oct 11, 2017 at 10:45 AM, Alexander Graf <ag...@suse.de> wrote: >>> >>> >>> On 10.10.17 14:23, Rob Clark wrote: >&

Re: [U-Boot] [PATCH 02/11] efi_loader: Initial HII protocols

On Thu, Oct 12, 2017 at 3:13 AM, Alexander Graf <ag...@suse.de> wrote: > > > On 12.10.17 00:02, Rob Clark wrote: >> On Wed, Oct 11, 2017 at 10:30 AM, Alexander Graf <ag...@suse.de> wrote: >>> >>> >>> On 10.10.17 14:22, Rob Clark wro

Re: [U-Boot] efi_loader query

On Wed, Oct 11, 2017 at 12:13 PM, Suneel Garapati wrote: > Hi Rob, > > I am enlisted on u-boot mailing list and currently trying to use efi > loader to launch ubuntu distro. > > Appreciate your great efforts on this, would definitely help a lot. > > I tried to boot grub

Re: [U-Boot] [PATCH 10/11] efi_loader: Add mem-mapped for fallback

On Wed, Oct 11, 2017 at 10:59 AM, Alexander Graf <ag...@suse.de> wrote: > > > On 10.10.17 14:23, Rob Clark wrote: >> When we don't have a real device/image path, such as 'bootefi hello', >> construct a mem-mapped device-path. >> >> This fixes 'boot

Re: [U-Boot] [PATCH 07/11] efi_loader: fix events

On Wed, Oct 11, 2017 at 10:49 AM, Alexander Graf <ag...@suse.de> wrote: > > > On 10.10.17 14:23, Rob Clark wrote: >> An event can be created with type==0, Shell.efi does this for an event >> that is set when Ctrl-C is typed. So our current approach of having a

Re: [U-Boot] [PATCH 06/11] efi_loader: Decouple EFI input/output from stdin/stdout

On Wed, Oct 11, 2017 at 10:45 AM, Alexander Graf <ag...@suse.de> wrote: > > > On 10.10.17 14:23, Rob Clark wrote: >> In some cases, it is quite useful to have (for example) EFI on screen >> but u-boot on serial port. >> >> This adds two new optional env

Re: [U-Boot] [PATCH 02/11] efi_loader: Initial HII protocols

On Wed, Oct 11, 2017 at 10:30 AM, Alexander Graf <ag...@suse.de> wrote: > > > On 10.10.17 14:22, Rob Clark wrote: >> From: Leif Lindholm <leif.lindh...@linaro.org> >> >> Enough implementation of the following protocols to run Shell.efi and >> SCT

Re: [U-Boot] [PATCH 01/11] efi_loader: Initial EFI_DEVICE_PATH_UTILITIES_PROTOCOL

On Wed, Oct 11, 2017 at 10:07 AM, Alexander Graf <ag...@suse.de> wrote: > > > On 10.10.17 14:22, Rob Clark wrote: >> From: Leif Lindholm <leif.lindh...@linaro.org> >> >> Not complete, but enough for Shell.efi and SCT.efi. We'll implement the >> rest a

Re: [U-Boot] [PATCH 03/11] efi_loader: Initial EFI_UNICODE_COLLATION_PROTOCOL

On Wed, Oct 11, 2017 at 10:36 AM, Alexander Graf <ag...@suse.de> wrote: > > > On 10.10.17 14:22, Rob Clark wrote: >> From: Leif Lindholm <leif.lindh...@linaro.org> >> >> Not complete, but enough for Shell.efi and SCT.efi. >> >> Initial skeleton

Re: [U-Boot] [PATCH 11/11] efi_loader: exclude openrd devices

On Tue, Oct 10, 2017 at 6:28 PM, Heinrich Schuchardt <xypron.g...@gmx.de> wrote: > On 10/10/2017 02:23 PM, Rob Clark wrote: >> >> These devices have small image size limits, so exclude EFI_LOADER to >> help avoid exceeding limits. >> >> Signed

[U-Boot] [PATCH 09/11] efi_loader: Fix disk dp's for pre-DM/legacy devices

This fixes an issue with OpenBSD's bootloader, and I think should also fix a similar issue with grub2 on legacy devices. In the legacy case we were creating disk objects for the partitions, but not also the parent device. Reported-by: Jonathan Gray <j...@jsg.id.au> Signed-off-by: Rob

[U-Boot] [PATCH 05/11] efi_loader: console support for color attributes

olors to the best of the device’s capabilities". Signed-off-by: Rob Clark <robdcl...@gmail.com> --- include/efi_api.h| 33 + lib/efi_loader/efi_console.c | 27 +-- 2 files changed, 58 insertions(+), 2 deletions(-) diff

[U-Boot] [PATCH 04/11] efi_loader: SIMPLE_TEXT_INPUT_EX plus wire up objects properly

We need the _EX version for SCT.. and we need to wire up the corresponding objects in the systab properly, as well as dealing with the console_in object advertising multiple protocols. Signed-off-by: Rob Clark <robdcl...@gmail.com> --- include/efi_api.h | 61 +- i

[U-Boot] [PATCH 07/11] efi_loader: fix events

implementation of SIMPLE_TEXT_INPUT_EX protocol), Ctrl-C works in Shell.efi. Signed-off-by: Rob Clark <robdcl...@gmail.com> --- include/efi_loader.h | 1 + lib/efi_loader/efi_boottime.c | 217 +- 2 files changed, 111 insertions(+), 107 deletions(-)

[U-Boot] [PATCH 11/11] efi_loader: exclude openrd devices

These devices have small image size limits, so exclude EFI_LOADER to help avoid exceeding limits. Signed-off-by: Rob Clark <robdcl...@gmail.com> --- lib/efi_loader/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig

[U-Boot] [PATCH 08/11] efi_loader: implement SetWatchdogTimer

From: Heinrich Schuchardt The watchdog is initialized with a 5 minute timeout period. It can be reset by SetWatchdogTimer. It is stopped by ExitBoottimeServices. Signed-off-by: Heinrich Schuchardt --- cmd/bootefi.c | 1 +

[U-Boot] [PATCH 06/11] efi_loader: Decouple EFI input/output from stdin/stdout

console will default to stdin/ stdout as before. Signed-off-by: Rob Clark <robdcl...@gmail.com> --- As mentioned yesterday, this triggers some problems w/ qemu + 'bootefi hello' since puts() != fputs(stdout). So you can hold off applying this one for now if you want until we figure out a sol

[U-Boot] [PATCH 10/11] efi_loader: Add mem-mapped for fallback

When we don't have a real device/image path, such as 'bootefi hello', construct a mem-mapped device-path. This fixes 'bootefi hello' after devicepath refactoring. Fixes: 95c5553ea2 ("efi_loader: refactor boot device and loaded_image handling") Signed-off-by: Rob Clark <robdcl

[U-Boot] [PATCH 02/11] efi_loader: Initial HII protocols

lidate the implementation against the conformance test suite. Initial skeleton written by Leif, and then implementation by myself. Cc: Leif Lindholm <leif.lindh...@linaro.org> Signed-off-by: Rob Clark <robdcl...@gmail.com> --- include/efi_api.h | 261 ++ in

[U-Boot] [PATCH 03/11] efi_loader: Initial EFI_UNICODE_COLLATION_PROTOCOL

From: Leif Lindholm <leif.lindh...@linaro.org> Not complete, but enough for Shell.efi and SCT.efi. Initial skeleton written by Leif, and then implementation by myself. Cc: Leif Lindholm <leif.lindh...@linaro.org> Signed-off-by: Rob Clark <robdcl...@gmail.com> ---

[U-Boot] [PATCH 01/11] efi_loader: Initial EFI_DEVICE_PATH_UTILITIES_PROTOCOL

y Leif, and then implementation by myself. Cc: Leif Lindholm <leif.lindh...@linaro.org> Signed-off-by: Rob Clark <robdcl...@gmail.com> --- include/efi_api.h | 34 +++- include/efi_loader.h | 2 + lib/efi_loader/Makefile

[U-Boot] [PATCH 00/11] efi_loader: patches for Shell.efi

efi_loader: Initial HII protocols efi_loader: Initial EFI_UNICODE_COLLATION_PROTOCOL Rob Clark (7): efi_loader: SIMPLE_TEXT_INPUT_EX plus wire up objects properly efi_loader: console support for color attributes efi_loader: Decouple EFI input/output from stdin/stdout efi_loader: fix events

Re: [U-Boot] [PATCH] efi_loader: Decouple EFI input/output from stdin/stdout

On Mon, Sep 11, 2017 at 10:04 AM, Rob Clark <robdcl...@gmail.com> wrote: > In some cases, it is quite useful to have (for example) EFI on screen > but u-boot on serial port. > > Signed-off-by: Rob Clark <robdcl...@gmail.com> > --- > Applies on top of my previous

Re: [U-Boot] [PATCH] efi_loader: Fix disk dp's for pre-DM/legacy devices

On Mon, Oct 9, 2017 at 1:48 PM, Jonathan Gray <j...@jsg.id.au> wrote: > On Mon, Oct 09, 2017 at 01:06:26PM -0400, Rob Clark wrote: >> On Mon, Oct 9, 2017 at 12:41 PM, Jonathan Gray <j...@jsg.id.au> wrote: >> > On Mon, Oct 09, 2017 at 12:06:24PM -0400, Rob Clark wr

Re: [U-Boot] [PATCH] efi_loader: Fix disk dp's for pre-DM/legacy devices

On Mon, Oct 9, 2017 at 12:41 PM, Jonathan Gray <j...@jsg.id.au> wrote: > On Mon, Oct 09, 2017 at 12:06:24PM -0400, Rob Clark wrote: >> On Mon, Oct 9, 2017 at 11:35 AM, Jonathan Gray <j...@jsg.id.au> wrote: >> > On Mon, Oct 09, 2017 at 10:17:18AM -0400, Rob Clark wr

Re: [U-Boot] [PATCH] efi_loader: Fix disk dp's for pre-DM/legacy devices

On Mon, Oct 9, 2017 at 12:22 PM, Heinrich Schuchardt <xypron.g...@gmx.de> wrote: > On 10/09/2017 06:06 PM, Rob Clark wrote: >> On Mon, Oct 9, 2017 at 11:35 AM, Jonathan Gray <j...@jsg.id.au> wrote: >>> On Mon, Oct 09, 2017 at 10:17:18AM -0400, Rob Clark wrote: >&

Re: [U-Boot] [PATCH] efi_loader: Fix disk dp's for pre-DM/legacy devices

On Mon, Oct 9, 2017 at 11:35 AM, Jonathan Gray <j...@jsg.id.au> wrote: > On Mon, Oct 09, 2017 at 10:17:18AM -0400, Rob Clark wrote: >> On Mon, Oct 9, 2017 at 8:25 AM, Jonathan Gray <j...@jsg.id.au> wrote: >> > On Mon, Oct 09, 2017 at 06:52:18AM -0400, Rob Clark wr

Re: [U-Boot] [PATCH] efi_loader: Fix disk dp's for pre-DM/legacy devices

On Mon, Oct 9, 2017 at 8:25 AM, Jonathan Gray <j...@jsg.id.au> wrote: > On Mon, Oct 09, 2017 at 06:52:18AM -0400, Rob Clark wrote: >> On Sun, Oct 8, 2017 at 11:33 PM, Jonathan Gray <j...@jsg.id.au> wrote: >> > On Sun, Oct 08, 2017 at 11:33:08AM -0400, Rob Clark wr

Re: [U-Boot] efi_loader: enough-uefi-for-shell: [PATCH 06/11] efi_loader: implement SetWatchdogTimer

On Sun, Oct 8, 2017 at 6:14 PM, Heinrich Schuchardt wrote: > On 10/08/2017 06:57 AM, Heinrich Schuchardt wrote: >> The watchdog is initialized with a 5 minute timeout period. >> It can be reset by SetWatchdogTimer. >> It is stopped by ExitBoottimeServices. >> >> Signed-off-by:

Re: [U-Boot] [PATCH] efi_loader: Fix disk dp's for pre-DM/legacy devices

On Sun, Oct 8, 2017 at 11:33 PM, Jonathan Gray <j...@jsg.id.au> wrote: > On Sun, Oct 08, 2017 at 11:33:08AM -0400, Rob Clark wrote: >> This fixes an issue with OpenBSD's bootloader, and I think should also >> fix a similar issue with grub2 on legacy devices. In the legacy cas

Re: [U-Boot] [PATCH 1/1] efi_loader: use type bool for event states

On Sun, Oct 8, 2017 at 12:41 PM, Alexander Graf <ag...@suse.de> wrote: > > >> Am 08.10.2017 um 17:54 schrieb Rob Clark <robdcl...@gmail.com>: >> >>> On Wed, Oct 4, 2017 at 12:02 PM, Heinrich Schuchardt <xypron.g...@gmx.de> >>> wrote: >>&

Re: [U-Boot] [PATCH 1/1] efi_loader: use type bool for event states

On Wed, Oct 4, 2017 at 12:02 PM, Heinrich Schuchardt wrote: > Patch efi_loader: add stub HII protocols uses UINTN heavily. In a recent > comment Simon remarked that types should not be uppercase. So I was > planning to replace all occurences of UINTN by size_t in an upcoming

[U-Boot] [PATCH] efi_loader: Fix disk dp's for pre-DM/legacy devices

This fixes an issue with OpenBSD's bootloader, and I think should also fix a similar issue with grub2 on legacy devices. In the legacy case we were creating disk objects for the partitions, but not also the parent device. Reported-by: Jonathan Gray <j...@jsg.id.au> Signed-off-by: Rob

Re: [U-Boot] [PATCH] disk: part_dos: Use the original allocation scheme for the SPL case

On Fri, Oct 6, 2017 at 10:08 PM, Jonathan Gray <j...@jsg.id.au> wrote: > On Fri, Oct 06, 2017 at 08:21:26AM -0400, Rob Clark wrote: >> On Fri, Oct 6, 2017 at 12:35 AM, Jonathan Gray <j...@jsg.id.au> wrote: >> > On Thu, Oct 05, 2017 at 05:05:49AM -0400, Rob Clark wr

Re: [U-Boot] [PATCH] disk: part_dos: Use the original allocation scheme for the SPL case

On Fri, Oct 6, 2017 at 8:21 AM, Rob Clark <robdcl...@gmail.com> wrote: > On Fri, Oct 6, 2017 at 12:35 AM, Jonathan Gray <j...@jsg.id.au> wrote: >> On Thu, Oct 05, 2017 at 05:05:49AM -0400, Rob Clark wrote: >>> On Thu, Oct 5, 2017 at 12:36 AM, Jonathan Gray <j...@js

Re: [U-Boot] [PATCH] disk: part_dos: Use the original allocation scheme for the SPL case

On Fri, Oct 6, 2017 at 12:35 AM, Jonathan Gray <j...@jsg.id.au> wrote: > On Thu, Oct 05, 2017 at 05:05:49AM -0400, Rob Clark wrote: >> On Thu, Oct 5, 2017 at 12:36 AM, Jonathan Gray <j...@jsg.id.au> wrote: >> > On Wed, Oct 04, 2017 at 01:12:48PM -0400, Rob Clark wr

Re: [U-Boot] [PATCH] usb: kbd: Fix dangling pointers on probe fail

On Thu, Oct 5, 2017 at 7:48 PM, Bin Meng <bmeng...@gmail.com> wrote: > Hi Rob, > > On Wed, Oct 4, 2017 at 1:31 AM, Rob Clark <robdcl...@gmail.com> wrote: >> If probe fails, we should unregister the stdio device, else we leave >> dangling pointers to the parent 'str

Re: [U-Boot] [PATCH] distro: load FDT from any partition on boot device

On Thu, Oct 5, 2017 at 8:39 AM, Alexander Graf <ag...@suse.de> wrote: > > > On 04.10.17 22:16, Rob Clark wrote: >> >> In the EFI_LOADER boot path, we were only checking the FAT partition >> containing the EFI payload for dtb files. But this is some

Re: [U-Boot] [PATCH] disk: part_dos: Use the original allocation scheme for the SPL case

On Thu, Oct 5, 2017 at 12:36 AM, Jonathan Gray <j...@jsg.id.au> wrote: > On Wed, Oct 04, 2017 at 01:12:48PM -0400, Rob Clark wrote: >> On Wed, Oct 4, 2017 at 12:29 PM, Fabio Estevam <fabio.este...@nxp.com> wrote: >> > Since commit ff98cb90514d ("part: ex

Re: [U-Boot] [PATCH v1 08/12] efi_loader: console support for color attributes

On Wed, Oct 4, 2017 at 8:00 PM, Rob Clark <robdcl...@gmail.com> wrote: > On Wed, Oct 4, 2017 at 7:53 PM, Heinrich Schuchardt <xypron.g...@gmx.de> > wrote: >> On 10/05/2017 01:19 AM, Rob Clark wrote: >>> On Wed, Oct 4, 2017 at 6:01 PM, Heinrich Schuchard

Re: [U-Boot] [PATCH v1 08/12] efi_loader: console support for color attributes

On Wed, Oct 4, 2017 at 7:53 PM, Heinrich Schuchardt <xypron.g...@gmx.de> wrote: > On 10/05/2017 01:19 AM, Rob Clark wrote: >> On Wed, Oct 4, 2017 at 6:01 PM, Heinrich Schuchardt <xypron.g...@gmx.de> >> wrote: >>> On 10/04/2017 10:54 PM, Rob Clark wrote:

Re: [U-Boot] [PATCH v1 08/12] efi_loader: console support for color attributes

On Wed, Oct 4, 2017 at 6:01 PM, Heinrich Schuchardt <xypron.g...@gmx.de> wrote: > On 10/04/2017 10:54 PM, Rob Clark wrote: >> On Wed, Oct 4, 2017 at 2:53 PM, Heinrich Schuchardt <xypron.g...@gmx.de> >> wrote: >>> On 09/10/2017 03:22 PM, Rob Clark wrote: >

Re: [U-Boot] [PATCH v1 08/12] efi_loader: console support for color attributes

On Wed, Oct 4, 2017 at 2:53 PM, Heinrich Schuchardt <xypron.g...@gmx.de> wrote: > On 09/10/2017 03:22 PM, Rob Clark wrote: >> Shell.efi uses this, and supporting color attributes makes things look >> nicer. Map the EFI fg/bg color attributes to ANSI escape sequences. &

[U-Boot] [PATCH] distro: load FDT from any partition on boot device

'devicetree' command to load the correct FDT). The other option is somehow passing the ${fdtfile} to grub so that it can load the FDT based on selected kernel version location (which grub knows) and SoC/board specific ${fdtfile} (which grub does not know). Signed-off-by: Rob Clark <robdcl...@gmail.

Re: [U-Boot] [PATCH v1 03/12] efi_loader: add EFI_UNICODE_COLLATION_PROTOCOL stub

On Wed, Oct 4, 2017 at 1:57 PM, Heinrich Schuchardt <xypron.g...@gmx.de> wrote: > On 09/10/2017 03:22 PM, Rob Clark wrote: >> From: Leif Lindholm <leif.lindh...@linaro.org> > > The commit message is missing. > > Fix all issues reported by checkpatch. >

Re: [U-Boot] [PATCH] disk: part_dos: Use the original allocation scheme for the SPL case

> I do not have time this week to further investigate and narrow down > this problem. > > Using the old allocation scheme fixes the mx6 SPL boot problem. > Hi Tom, if you are ok with this as a temporary fix, then this is: Acked-by: Rob Clark <robdcl...@gmail.com> I'm getting

Re: [U-Boot] [PATCH 1/1] efi_loader: use type bool for event states

On Wed, Oct 4, 2017 at 12:29 PM, Heinrich Schuchardt <xypron.g...@gmx.de> wrote: > On 10/04/2017 05:25 PM, Alexander Graf wrote: >> >> >> On 04.10.17 16:57, Rob Clark wrote: >>> On Wed, Oct 4, 2017 at 10:46 AM, Heinrich Schuchardt >>> <xypron.g...

Re: [U-Boot] [PATCH 1/1] efi_loader: use type bool for event states

On Wed, Oct 4, 2017 at 12:02 PM, Heinrich Schuchardt <xypron.g...@gmx.de> wrote: > On 10/04/2017 04:57 PM, Rob Clark wrote: >> On Wed, Oct 4, 2017 at 10:46 AM, Heinrich Schuchardt <xypron.g...@gmx.de> >> wrote: >>> On 10/04/2017 04:14 PM, Rob Clark wrote:

Re: [U-Boot] [PATCH 1/1] efi_loader: use type bool for event states

On Wed, Oct 4, 2017 at 10:46 AM, Heinrich Schuchardt <xypron.g...@gmx.de> wrote: > On 10/04/2017 04:14 PM, Rob Clark wrote: >> On Wed, Oct 4, 2017 at 9:03 AM, Heinrich Schuchardt <xypron.g...@gmx.de> >> wrote: >>> Queued and signaled describe boolean states o

Re: [U-Boot] [PATCH] disk: Don't assume blksz > legacy_mbr

On Wed, Oct 4, 2017 at 10:27 AM, Fabio Estevam <feste...@gmail.com> wrote: > Hi Rob, > > On Wed, Oct 4, 2017 at 11:11 AM, Rob Clark <robdcl...@gmail.com> wrote: > >> btw, I'm still hoping someone can get me some logs so I can see what >> blksz is, etc, on thes

Re: [U-Boot] [PATCH 1/1] efi_loader: use type bool for event states

s_signaled. Reviewed-by: Rob Clark <robdcl...@gmail.com> It would be kinda nice to merge my efi_event fixes and rework to use an arbitrary sized list of events before making too many more efi_event changes, since that is kind of annoying to keep rebasing ;-) BR, -R > Reported-by: Simon Glas

Re: [U-Boot] [PATCH] disk: Don't assume blksz > legacy_mbr

On Tue, Oct 3, 2017 at 12:32 PM, Rob Clark <robdcl...@gmail.com> wrote: > On Tue, Oct 3, 2017 at 12:04 PM, Fabio Estevam <feste...@gmail.com> wrote: >> On Tue, Oct 3, 2017 at 12:30 PM, Rob Clark <robdcl...@gmail.com> wrote: >>> On some devices, this does not

[U-Boot] [PATCH] usb: kbd: Fix dangling pointers on probe fail

If probe fails, we should unregister the stdio device, else we leave dangling pointers to the parent 'struct usb_device'. Signed-off-by: Rob Clark <robdcl...@gmail.com> --- I finally got around to debugging why things explode so badly without fixing usb_kbd vs. iomux[1] (which this patch a

Re: [U-Boot] [PATCH] disk: Don't assume blksz > legacy_mbr

On Tue, Oct 3, 2017 at 12:04 PM, Fabio Estevam <feste...@gmail.com> wrote: > On Tue, Oct 3, 2017 at 12:30 PM, Rob Clark <robdcl...@gmail.com> wrote: >> On some devices, this does not appear to be a valid assumption. So >> figure out the number of blocks we actually nee

[U-Boot] [PATCH] disk: Don't assume blksz > legacy_mbr

On some devices, this does not appear to be a valid assumption. So figure out the number of blocks we actually need to read. Signed-off-by: Rob Clark <robdcl...@gmail.com> --- Sorry, took a bit longer to get to a point of testing this.. somehow himport_r() of the default_envir

Re: [U-Boot] [RFC] disk: part_dos: Fix part_test_dos() regression

On Tue, Oct 3, 2017 at 7:04 AM, Fabio Estevam <feste...@gmail.com> wrote: > On Tue, Oct 3, 2017 at 7:57 AM, Rob Clark <robdcl...@gmail.com> wrote: > >> btw, if I had to take a guess, I'd say that perhaps blksz is smaller >> than 'legacy_mbr', so maybe rather than

Re: [U-Boot] [RFC] disk: part_dos: Fix part_test_dos() regression

On Tue, Oct 3, 2017 at 6:47 AM, Rob Clark <robdcl...@gmail.com> wrote: > personally I think we should try to figure out what is wrong on imx6 > rather than blindly reverting.. without this change MBR partitioned > disks might not generate unique device-paths for EFI boot. > >

Re: [U-Boot] [PATCH v3 02/21] part: extract MBR signature from partitions

On Mon, Oct 2, 2017 at 2:17 PM, Fabio Estevam <feste...@gmail.com> wrote: > On Wed, Sep 13, 2017 at 7:05 PM, Rob Clark <robdcl...@gmail.com> wrote: >> From: Peter Jones <pjo...@redhat.com> >> >> EFI client programs need the signature information from the p

Re: [U-Boot] [PATCH] dm: video: make ANSI escape sequence support optional

On Sat, Sep 30, 2017 at 4:19 AM, Anatolij Gustschin wrote: > As mentioned in review comments for ANSI escape sequence > support patches, this should be optional to reduce code > size. Disable escape sequence support when CONFIG_VIDEO_ANSI > is not enabled. Assuming the later

Re: [U-Boot] [PATCH 0/3] dm: video: enhancements for Shell.efi

On Thu, Sep 28, 2017 at 8:17 AM, Simon Glass <s...@chromium.org> wrote: > Hi Rob, > > On 13 September 2017 at 16:12, Rob Clark <robdcl...@gmail.com> wrote: >> >> Split out of earlier efi_loader patchset, and updated with some >> comments, use of sim

[U-Boot] [PATCH] usb: kbd: Don't fail with iomux

on dragonboard410c with distro- bootcmd, where stdin is not set (so stdinname is null). Signed-off-by: Rob Clark <robdcl...@gmail.com> --- Somehow this patch was dropped on the floor. I don't remember which version # this is up to, search the list if you care. But this is the latest.

[U-Boot] [PATCH 1/2] video: test: Helper for writing strings

I'll need some more of this, let's not just copy-pasta the vidconsole_put_char() loop. Named to match vidconsole_put_char() in case that is ever useful outside of the tests. Signed-off-by: Rob Clark <robdcl...@gmail.com> --- test/dm/video.c | 24 1 file chang

Re: [U-Boot] [PATCH 3/3] fs-test: Add test for a filename using '..' to go back to the root

On Sun, Sep 24, 2017 at 5:38 PM, Tom Rini wrote: > On Mon, Sep 25, 2017 at 12:07:36AM +0300, Tuomas Tynkkynen wrote: > >> The previous commit fixed a problem in FAT code where going back to the >> root directory using '..' wouldn't work correctly on FAT12 or FAT16. >> Add a

Re: [U-Boot] [PATCH 1/3] fs-test: Add FAT16 support

On Sun, Sep 24, 2017 at 5:07 PM, Tuomas Tynkkynen wrote: > Currently we can only test FAT32 which is the default FAT version that > mkfs.vfat creates by default. Instead make it explicitly create either a > FAT16 or a FAT32 volume. This allows us to exercise more code,

Re: [U-Boot] FAT filesystems and mtools-created filesystems

On Sat, Sep 23, 2017 at 6:51 AM, Tuomas Tynkkynen wrote: > On 09/23/2017 01:26 PM, Tuomas Tynkkynen wrote: >> >> Hi, >> >> FAT file systems created by GNU mtools have a problem that mtools doesn't >> initialize the first cluster field of the '.' and '..' directory

Re: [U-Boot] [PATCH v3 15/21] efi_loader: add bootmgr

On Thu, Sep 21, 2017 at 12:58 AM, Simon Glass <s...@chromium.org> wrote: > Hi, > > On 20 September 2017 at 08:09, Rob Clark <robdcl...@gmail.com> wrote: >> On Wed, Sep 20, 2017 at 5:08 AM, Alexander Graf <ag...@suse.de> wrote: >>> >>> >&g

[U-Boot] [PATCH] efi_loader: fix efi_exit

efi_exit() already restores gd, so we shouldn't EFI_EXIT() on the otherside of the longjmp(). Signed-off-by: Rob Clark <robdcl...@gmail.com> --- cmd/bootefi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/cmd/bootefi.c b/cmd/bootefi.c index fdfed1be05..a049e5f64d 100644 --- a/cmd/boo

Re: [U-Boot] [PATCH v2 1/1] efi_loader: reenable selftest

efi_loader: refactor boot device and loaded_image handling > Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> > --- > v2 > completely initialize loaded_image_info lgtm, thanks Reviewed-by: Rob Clark <robdcl...@gmail.com> > --- > cmd/bootefi.c

Re: [U-Boot] [PATCH 1/1] efi_loader: reenable selftest

On Wed, Sep 20, 2017 at 3:46 PM, Heinrich Schuchardt wrote: > ad503ffe9c6 efi_loader: refactor boot device and loaded_image handling > leads to an error when building with CONFIG_CMD_BOOTEFI_SELFTEST=y > This patch fixes the problem. > > Fixes: ad503ffe9c6 efi_loader: refactor

Re: [U-Boot] cmd/bootefi.c:285:3: error: ‘loaded_image_info’ undeclared

On Wed, Sep 20, 2017 at 2:42 PM, Heinrich Schuchardt wrote: > Hello Rob, hello Alex, > > when I try to compile efi-next I get > > CC cmd/bootefi.o > cmd/bootefi.c: In function ‘do_bootefi’: > cmd/bootefi.c:285:3: error: ‘loaded_image_info’ undeclared (first use in >

Re: [U-Boot] [PATCH 16/23] efi_loader: implement DisconnectController

On Wed, Sep 20, 2017 at 9:49 AM, Simon Glass wrote: > Hi Heinrich, > > On 15 September 2017 at 00:35, Heinrich Schuchardt wrote: >> On 08/31/2017 02:52 PM, Simon Glass wrote: >>> On 27 August 2017 at 06:53, Heinrich Schuchardt wrote:

Re: [U-Boot] [PATCH v3 05/21] efi_loader: add device-path utils

On Wed, Sep 20, 2017 at 4:31 AM, Alexander Graf <ag...@suse.de> wrote: > > > On 14.09.17 00:05, Rob Clark wrote: >> >> Helpers to construct device-paths from devices, partitions, files, and >> for parsing and manipulating device-paths. >> >> For non-

Re: [U-Boot] [PATCH v3 15/21] efi_loader: add bootmgr

On Wed, Sep 20, 2017 at 5:08 AM, Alexander Graf <ag...@suse.de> wrote: > > > On 14.09.17 00:05, Rob Clark wrote: >> >> Similar to a "real" UEFI implementation, the bootmgr looks at the >> BootOrder and Boot variables to try to find an EFI payload t

Re: [U-Boot] [PATCH 08/16] sandbox: Add a setjmp() implementation

On Mon, Sep 18, 2017 at 2:01 AM, Heinrich Schuchardt wrote: > On 09/18/2017 12:59 AM, Simon Glass wrote: >> Add an implementation of setjmp() and longjmp() which rely on the >> underlying host C library. Since we cannot know how large the jump buffer >> needs to be, pick

Re: [U-Boot] [PATCH] efi_loader: EFI entry point should be EFIAPI

On Mon, Sep 18, 2017 at 1:47 PM, Rob Clark <robdcl...@gmail.com> wrote: > This is needed to run 'bootefi' from sandbox. I suspect StartImage() > must have been broken too on x86. > > Signed-off-by: Rob Clark <robdcl...@gmail.com> > --- > cmd/bootefi.c

[U-Boot] [PATCH] efi_loader: EFI entry point should be EFIAPI

This is needed to run 'bootefi' from sandbox. I suspect StartImage() must have been broken too on x86. Signed-off-by: Rob Clark <robdcl...@gmail.com> --- cmd/bootefi.c | 2 +- include/efi.h | 2 +- lib/efi_loader/efi_boottime.c | 2 +- 3 files chan

Re: [U-Boot] [PATCH 00/16] efi: Enable basic sandbox support for EFI loader

On Mon, Sep 18, 2017 at 11:07 AM, Rob Clark <robdcl...@gmail.com> wrote: > On Mon, Sep 18, 2017 at 10:30 AM, Rob Clark <robdcl...@gmail.com> wrote: >> On Mon, Sep 18, 2017 at 9:31 AM, Rob Clark <robdcl...@gmail.com> wrote: >>> On Mon, Sep 18, 2017 at 9:18 AM, R

Re: [U-Boot] [PATCH 00/16] efi: Enable basic sandbox support for EFI loader

On Mon, Sep 18, 2017 at 10:30 AM, Rob Clark <robdcl...@gmail.com> wrote: > On Mon, Sep 18, 2017 at 9:31 AM, Rob Clark <robdcl...@gmail.com> wrote: >> On Mon, Sep 18, 2017 at 9:18 AM, Rob Clark <robdcl...@gmail.com> wrote: >>> On Sun, Sep 17, 2017 at 11:48 P

Re: [U-Boot] [PATCH 00/16] efi: Enable basic sandbox support for EFI loader

On Mon, Sep 18, 2017 at 9:31 AM, Rob Clark <robdcl...@gmail.com> wrote: > On Mon, Sep 18, 2017 at 9:18 AM, Rob Clark <robdcl...@gmail.com> wrote: >> On Sun, Sep 17, 2017 at 11:48 PM, Heinrich Schuchardt >> <xypron.g...@gmx.de> wrote: >>> On 09/18/2017 12:5

Re: [U-Boot] [PATCH 00/16] efi: Enable basic sandbox support for EFI loader

On Mon, Sep 18, 2017 at 9:18 AM, Rob Clark <robdcl...@gmail.com> wrote: > On Sun, Sep 17, 2017 at 11:48 PM, Heinrich Schuchardt > <xypron.g...@gmx.de> wrote: >> On 09/18/2017 12:59 AM, Simon Glass wrote: >>> A limitation of the EFI loader at present is that i

Re: [U-Boot] [PATCH 00/16] efi: Enable basic sandbox support for EFI loader

On Sun, Sep 17, 2017 at 11:48 PM, Heinrich Schuchardt wrote: > On 09/18/2017 12:59 AM, Simon Glass wrote: >> A limitation of the EFI loader at present is that it does not build with >> sandbox. This makes it hard to write tests, since sandbox is used for most >> testing in

Re: [U-Boot] [PATCH 2/3] dm: video: Add basic ANSI escape sequence support

On Sun, Sep 17, 2017 at 3:30 PM, Simon Glass <s...@chromium.org> wrote: > Hi Rob, > > On 17 September 2017 at 13:26, Rob Clark <robdcl...@gmail.com> wrote: >> On Sun, Sep 17, 2017 at 1:55 PM, Simon Glass <s...@chromium.org> wrote: >>> On 13 September 201

Re: [U-Boot] [PATCH 00/10] efi_loader: event services & API test

On Sun, Sep 17, 2017 at 1:58 PM, Simon Glass wrote: > Hi Heinrich, > > On 15 September 2017 at 02:06, Heinrich Schuchardt wrote: >> This patch series provides: >> * corrections for the EFI event services >> * a test framework to check the EFI API

Re: [U-Boot] [PATCH 2/3] dm: video: Add basic ANSI escape sequence support

On Sun, Sep 17, 2017 at 1:55 PM, Simon Glass <s...@chromium.org> wrote: > On 13 September 2017 at 16:12, Rob Clark <robdcl...@gmail.com> wrote: >> Really just the subset that is needed by efi_console. Perhaps more will >> be added later, for example color support w

  1   2   3   4   5   6   >