Re: [U-Boot] [PATCH 3/7] cmd: bootimg: Add bootimg command

2019-09-24 Thread Sam Protsenko
Hi Igor, On Mon, Sep 23, 2019 at 11:36 PM Igor Opaniuk wrote: > > Hi Simon, > > On Fri, Sep 20, 2019 at 8:45 PM Simon Glass wrote: > > > > Hi, > > > > On Thu, 19 Sep 2019 at 12:28, Sam Protsenko > > wrote: > > > > > > This c

[U-Boot] [PATCH 3/7] cmd: bootimg: Add bootimg command

2019-09-19 Thread Sam Protsenko
rsed using 'dtimg' command and merged into dtb file (for non-A/B devices only, see [1,2] for details). [1] https://source.android.com/devices/bootloader/boot-image-header [2] https://source.android.com/devices/architecture/dto/partitions Signed-off-by: Sam Protsenko --- cmd/Kconfig | 8 +++ cm

[U-Boot] [PATCH 7/7] arm: ti: boot: Use correct dtb and dtbo on Android boot

2019-09-19 Thread Sam Protsenko
Read correct dtb file from boot.img/recovery.img and apply correct dtbo files from dtbo partition. Signed-off-by: Sam Protsenko --- include/configs/ti_armv7_common.h | 7 + include/environment/ti/boot.h | 44 --- 2 files changed, 48 insertions(+), 3

[U-Boot] [PATCH 6/7] env: ti: boot: Boot Android with dynamic partitions

2019-09-19 Thread Sam Protsenko
partition. Signed-off-by: Sam Protsenko --- include/environment/ti/boot.h | 105 +- 1 file changed, 41 insertions(+), 64 deletions(-) diff --git a/include/environment/ti/boot.h b/include/environment/ti/boot.h index da99215fbd..a7644a5874 100644 --- a/include/envi

[U-Boot] [PATCH 5/7] env: ti: boot: Respect slot_suffix in AVB commands

2019-09-19 Thread Sam Protsenko
Signed-off-by: Sam Protsenko --- include/environment/ti/boot.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/environment/ti/boot.h b/include/environment/ti/boot.h index 684a744f31..da99215fbd 100644 --- a/include/environment/ti/boot.h +++ b/include/environment/ti

[U-Boot] [PATCH 4/7] configs: am57xx_evm: Enable Android commands

2019-09-19 Thread Sam Protsenko
- CONFIG_AVB_VERIFY=y - CONFIG_CMD_AVB=y While at it, resync defconfig files with "make savedefconfig". Signed-off-by: Sam Protsenko --- configs/am57xx_evm_defconfig| 8 +++- configs/am57xx_hs_evm_defconfig | 6 ++ configs/am57xx_hs_evm_usb_defconfig | 8 +++- 3 fil

[U-Boot] [PATCH 1/7] image: android: Add functions for handling dtb field

2019-09-19 Thread Sam Protsenko
t; command - pass resulting dtb file into bootm command in order to boot the Android kernel with Android ramdisk from boot image Signed-off-by: Sam Protsenko --- common/Makefile| 2 +- common/image-android.c | 191 + include/image.h|

[U-Boot] [PATCH 2/7] image: android: Add routine to get dtbo params

2019-09-19 Thread Sam Protsenko
age-header [2] https://source.android.com/devices/architecture/dto/partitions Signed-off-by: Sam Protsenko --- common/image-android.c | 54 ++ include/image.h| 2 ++ 2 files changed, 56 insertions(+) diff --git a/common/image-android.c b/common/i

[U-Boot] [PATCH 0/7] am57xx: Implement Android 10 boot flow

2019-09-19 Thread Sam Protsenko
Android 10 brings a lot of new requirements for bootloaders: [1]. This patch series attempts to implement such a boot process on BeagleBoard X15 platform. Some common code is added too, which can be reused later for other platforms. [1] https://source.android.com/devices/bootloader Sam

Re: [U-Boot] [PATCH v2 1/2] Revert "configs: Remove am335x_boneblack_defconfig"

2019-09-17 Thread Sam Protsenko
On Tue, Sep 17, 2019 at 7:50 AM Lokesh Vutla wrote: > > > > On 16/09/19 4:53 PM, Sam Protsenko wrote: > > Hi Lokesh, > > > > On Mon, Sep 16, 2019 at 11:34 AM Lokesh Vutla wrote: > >> > >> > >> > >> On 12/09/19 11:20 PM

Re: [U-Boot] [PATCH] watchdog: omap_wdt: Fix WDT target reset when booted from emmc

2019-09-16 Thread Sam Protsenko
aces in the driver to driver's probe. > Tested on Beaglebone Black. > > Cc: Grygorii Strashko > Fixes: 7659ea32 ("watchdog: omap_wdt: Convert watchdog driver to use DT and > DM") > Reported-by: Sam Protsenko > Signed-off-by: Suniel Mahesh > --- Can you please pul

Re: [U-Boot] [PATCH] watchdog: omap_wdt: Fix WDT target reset when booted from emmc

2019-09-16 Thread Sam Protsenko
driver to driver's probe. > Tested on Beaglebone Black. > > Cc: Grygorii Strashko > Fixes: 7659ea32 ("watchdog: omap_wdt: Convert watchdog driver to use DT and > DM") > Reported-by: Sam Protsenko > Signed-off-by: Suniel Mahesh > --- Reviewed-by: Sam Protsen

Re: [U-Boot] [PATCH v2 1/2] Revert "configs: Remove am335x_boneblack_defconfig"

2019-09-16 Thread Sam Protsenko
Hi Lokesh, On Mon, Sep 16, 2019 at 11:34 AM Lokesh Vutla wrote: > > > > On 12/09/19 11:20 PM, Sam Protsenko wrote: > > Commit 8fa7f65dd02c ("configs: Remove am335x_boneblack_defconfig") > > removes defconfig for BeagleBone Black board, and it's advised to us

Re: [U-Boot] OMAP watchdog timer reset on BBB

2019-09-16 Thread Sam Protsenko
, Sep 16, 2019 at 11:43 AM Grygorii Strashko wrote: > > > > On 16/09/2019 10:05, Suniel Mahesh wrote: > > Hi all, > > > > On 14/09/19 12:55, Sam Protsenko wrote: > >> Hi Grygorii, > >> > >> On Fri, Sep 13, 2019 at 8:58 PM Grygorii Strashko

Re: [U-Boot] OMAP watchdog timer reset on BBB

2019-09-14 Thread Sam Protsenko
Hi Grygorii, On Fri, Sep 13, 2019 at 8:58 PM Grygorii Strashko wrote: > > > > On 12/09/2019 19:33, Sam Protsenko wrote: > > Hi Stefan, > > > > On Thu, Sep 12, 2019 at 5:38 PM Stefan Roese wrote: > >> > >> Hi Sam, > >> >

Re: [U-Boot] [PATCH v2 1/2] Revert "configs: Remove am335x_boneblack_defconfig"

2019-09-12 Thread Sam Protsenko
Hi Tom, On Thu, Sep 12, 2019 at 8:50 PM Sam Protsenko wrote: > > Commit 8fa7f65dd02c ("configs: Remove am335x_boneblack_defconfig") > removes defconfig for BeagleBone Black board, and it's advised to use > am335x_evm_defconfig for all AM335x boards. But it's impossible

Re: [U-Boot] [PATCH 1/2] Revert "configs: Remove am335x_boneblack_defconfig"

2019-09-12 Thread Sam Protsenko
On Thu, Sep 12, 2019 at 6:23 PM Sam Protsenko wrote: > > Commit 8fa7f65dd02c ("configs: Remove am335x_boneblack_defconfig") > removes defconfig for BeagleBone Black board, and it's advised to use > am335x_evm_defconfig for all AM335x boards. But it's impossible to use

[U-Boot] [PATCH v2 2/2] configs: am335x_boneblack: Sync with am335x_evm

2019-09-12 Thread Sam Protsenko
ot; Fixes: 8fa7f65dd02c ("configs: Remove am335x_boneblack_defconfig") Signed-off-by: Sam Protsenko --- Changes in v2: - improve commit message - keep log level at default value (4) configs/am335x_boneblack_defconfig | 36 -- 1 file changed, 29 insertions(+),

[U-Boot] [PATCH v2 1/2] Revert "configs: Remove am335x_boneblack_defconfig"

2019-09-12 Thread Sam Protsenko
ther patch will update this defconfig by enabling Driver Model and pulling some other useful options from am335x_evm_defconfig. Fixes: 8fa7f65dd02c ("configs: Remove am335x_boneblack_defconfig") Signed-off-by: Sam Protsenko --- Changes in v2: - improve commit message by saying explicitly abou

Re: [U-Boot] OMAP watchdog timer reset on BBB

2019-09-12 Thread Sam Protsenko
Hi Stefan, On Thu, Sep 12, 2019 at 5:38 PM Stefan Roese wrote: > > Hi Sam, > > On 12.09.19 15:45, Sam Protsenko wrote: > > Hi Suniel, > > > > After transition to DM WDT, watchdog timer on BeagleBone Black resets > > the board after 1 minute or so.

Re: [U-Boot] [PATCH 1/2] Revert "configs: Remove am335x_boneblack_defconfig"

2019-09-12 Thread Sam Protsenko
k_defconfig to am335x_evm_mmc_defconfig, but it doesn't change the fact it should be done. If somebody sees another way around, please do tell. Thanks! On Thu, Sep 12, 2019 at 6:43 PM Andre Heider wrote: > > Hi, > > On 9/12/19 5:23 PM, Sam Protsenko wrote: > > Commit

[U-Boot] [PATCH 2/2] configs: am335x_boneblack: Sync with am335x_evm

2019-09-12 Thread Sam Protsenko
t;) Signed-off-by: Sam Protsenko --- configs/am335x_boneblack_defconfig | 37 -- 1 file changed, 30 insertions(+), 7 deletions(-) diff --git a/configs/am335x_boneblack_defconfig b/configs/am335x_boneblack_defconfig index 439d0cba05..2b9dfdb5fc 100644 ---

[U-Boot] [PATCH 1/2] Revert "configs: Remove am335x_boneblack_defconfig"

2019-09-12 Thread Sam Protsenko
ther patch will update this defconfig by enabling Driver Model and pulling some other useful options from am335x_evm_defconfig. Fixes: 8fa7f65dd02c ("configs: Remove am335x_boneblack_defconfig") Signed-off-by: Sam Protsenko --- configs/am335x_boneblack_defconfig | 50 ++

[U-Boot] OMAP watchdog timer reset on BBB

2019-09-12 Thread Sam Protsenko
Hi Suniel, After transition to DM WDT, watchdog timer on BeagleBone Black resets the board after 1 minute or so. I'm using this defconfig: [1]. After disabling CONFIG_WDT and CONFIG_WATCHDOG options the board doesn't reset. I guess it might be happening on other boards using CONFIG_WDT_OMAP3 as

Re: [U-Boot] [PATCH 1/2] mmc: Fix timeout values passed to mmc_wait_dat0()

2019-08-29 Thread Sam Protsenko
; mmc_wait_dat0() > > > > when passing incorrect timeout from __mmc_switch() to mmc_wait_dat0(). > > > > Fixes: bb98b8c5c06a ("mmc: During a switch, poll on dat0 if available and > > check the final status") > > Signed-off-by: Sam Protsenko > > Ap

Re: [U-Boot] [PATCH 1/2] libavb: Update libavb to current AOSP master

2019-08-16 Thread Sam Protsenko
Hi Eugeniu, On Fri, Aug 16, 2019 at 1:36 PM Eugeniu Rosca wrote: > > Hi Sam, > > On Thu, Aug 15, 2019 at 11:04:02PM +0300, Sam Protsenko wrote: > > Update libavb to commit 5fbb42a189aa in AOSP/master, because new version > > has support for super partition [1], which

[U-Boot] [PATCH 2/2] libavb: Fix build warnings after updating the lib

2019-08-15 Thread Sam Protsenko
uninitialized in this function [-Wmaybe-uninitialized] AvbSlotVerifyResult ret; ^~~ Fix those by providing default return values to affected functions. Signed-off-by: Sam Protsenko --- lib/libavb/avb_cmdline.c

[U-Boot] [PATCH 1/2] libavb: Update libavb to current AOSP master

2019-08-15 Thread Sam Protsenko
test_android/test_avb.py ss..s. [1] https://android.googlesource.com/platform/external/avb/+/49936b4c0109411fdd38bd4ba3a32a01c40439a9 Signed-off-by: Sam Protsenko --- lib/libavb/avb_cmdline.c | 52 ++- lib/libavb/avb_cmdline.h | 4 +- lib/libavb/avb_descriptor.c

Re: [U-Boot] [PATCH] cmd: avb: Fix requested partitions list

2019-08-15 Thread Sam Protsenko
Hi Eugeniu, On Tue, Aug 13, 2019 at 7:59 PM Eugeniu Rosca wrote: > > Hi Sam, > > On Fri, Aug 09, 2019 at 07:16:03PM +0300, Sam Protsenko wrote: > > The requested_partitions[] array should contain only boot partitions. > > Usually it's only 'boot' partition, as can be

[U-Boot] [PATCH v2] cmd: avb: Fix requested partitions list

2019-08-15 Thread Sam Protsenko
/platform/external/avb/+/5fbb42a189aa/libavb/avb_slot_verify.c#1461 Signed-off-by: Sam Protsenko --- Changes in v2: - fix links in commit message (suggested by Eugeniu Rosca) cmd/avb.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/cmd/avb.c b/cmd/avb.c index a8a95034ca

Re: [U-Boot] [PATCH] cmd: avb: Fix requested partitions list

2019-08-15 Thread Sam Protsenko
Hi Eugeniu, On Mon, Aug 12, 2019 at 4:57 PM Eugeniu Rosca wrote: > > Hi all, > > On Mon, Aug 12, 2019 at 02:13:55PM +0300, Igor Opaniuk wrote: > [..] > > Current snapshot of libavb in U-boot is a bit out-dated (~2 years) and > > before introducing patches that can leverage new features from the

Re: [U-Boot] kernel-doc vs Doxygen

2019-08-15 Thread Sam Protsenko
On Thu, Aug 15, 2019 at 4:51 PM Tom Rini wrote: > > On Wed, Aug 14, 2019 at 09:16:40PM +0300, Sam Protsenko wrote: > > > Hi everyone, > > > > Quick question: which comment style is allowed in U-Boot, kernel-doc > > or Doxygen one? I have noticed that both are

[U-Boot] [PATCH] image: android: Support boot image v1 and v2

2019-08-15 Thread Sam Protsenko
e seen e.g. in "iminfo" command This commit doesn't add the means for working with new payloads in v1 and v2 images (it will be done in further commits), it only updates existing functions w.r.t. changes in boot image v1/v2. Signed-off-by: Sam Protsenko --- common/

[U-Boot] [PATCH 2/2] mmc: Rename timeout parameters for clarification

2019-08-14 Thread Sam Protsenko
at it, add time units info as comments to struct mmc fields. This commit doesn't change the behavior, only renames parameters names. Buildman should report no changes at all. Signed-off-by: Sam Protsenko --- drivers/mmc/mmc-uclass.c | 8 drivers/mmc/mmc.c | 24

[U-Boot] [PATCH 1/2] mmc: Fix timeout values passed to mmc_wait_dat0()

2019-08-14 Thread Sam Protsenko
() -> mmc_switch_part() -> __mmc_switch() -> mmc_wait_dat0() when passing incorrect timeout from __mmc_switch() to mmc_wait_dat0(). Fixes: bb98b8c5c06a ("mmc: During a switch, poll on dat0 if available and check the final status") Signed-off-by: Sam Protsenko --- drivers/mm

[U-Boot] kernel-doc vs Doxygen

2019-08-14 Thread Sam Protsenko
Hi everyone, Quick question: which comment style is allowed in U-Boot, kernel-doc or Doxygen one? I have noticed that both are used currently (and I've sent some patches with doxy comments myself). Please tell me if somebody is actually running either kernel-doc or Doxygen to generate the U-Boot

[U-Boot] [PATCH] cmd: avb: Fix requested partitions list

2019-08-09 Thread Sam Protsenko
/platform/external/avb/+/master/libavb/avb_slot_verify.c#1461 Signed-off-by: Sam Protsenko --- cmd/avb.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/cmd/avb.c b/cmd/avb.c index d1942d6605..8f2bb85fce 100644 --- a/cmd/avb.c +++ b/cmd/avb.c @@ -14,11 +14,6 @@ #define

[U-Boot] [PATCH] cmd: avb: Support A/B slots

2019-08-09 Thread Sam Protsenko
Add optional parameter to 'avb verify' sub-command, so that user is able to specify which slot to use, in case when user's partitions are slotted. If that parameter is omitted, the behavior of 'avb verify' will be the same as before, so user API is content. Signed-off-by: Sam Protsenko --- cmd

[U-Boot] [PATCH] image: android: Fix possible build errors

2019-08-09 Thread Sam Protsenko
*/ Include required headers for data types used. While at it, remove typedef struct, which is prohibited by kernel coding style, and fix the comment. Signed-off-by: Sam Protsenko --- include/android_image.h | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/include

Re: [U-Boot] [PATCH] test/py: avb: Move AVB test to android dir

2019-08-07 Thread Sam Protsenko
Hi Tom, On Thu, Jul 25, 2019 at 6:13 PM Tom Rini wrote: > > On Thu, Jul 25, 2019 at 04:33:21PM +0300, Sam Protsenko wrote: > > Hi Simon, > > > > On Sat, Jul 6, 2019 at 7:53 PM Simon Glass wrote: > > > > > > Hi, > > > > > &

Re: [U-Boot] [PATCH 1/2] avb: Fix build when CONFIG_OPTEE_TA_AVB is disabled

2019-08-07 Thread Sam Protsenko
Hi Tom, On Thu, Aug 1, 2019 at 2:15 PM Igor Opaniuk wrote: > > Hi, > > On Wed, Jul 31, 2019 at 7:59 PM Sam Protsenko > wrote: > > > > When having only these AVB related configs enabled: > > > > CONFIG_AVB_VERIFY=y > > CONFIG_CMD_AVB=

Re: [U-Boot] [PATCH] Update include/android_image.h from AOSP

2019-08-06 Thread Sam Protsenko
ks for submitting this, Alex. Reviewed-by: Sam Protsenko Tom, can this be applied for -rc2? It shouldn't break anything, as all fields are preserved (patch only adds new ones), and header size is page_size everywhere anyway. I can send another patch on top of this one, to change associated routine

Re: [U-Boot] [RFC PATCH] cmd: avb: Support A/B slots

2019-08-06 Thread Sam Protsenko
Hi Igor, On Tue, Aug 6, 2019 at 4:07 PM Igor Opaniuk wrote: > > Hi Sam, > > Sorry for the late reply, > > On Fri, Aug 2, 2019 at 9:57 PM Sam Protsenko > wrote: > > > > Hi Igor, Jens, > > > > Can you please comments on next topics: > > 1.

[U-Boot] [PATCH] common: image-android-dt: Fix logic in print fdt info routine

2019-08-05 Thread Sam Protsenko
Do not attempt to print fdt info if root node wasn't found. Signed-off-by: Sam Protsenko --- common/image-android-dt.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/common/image-android-dt.c b/common/image-android-dt.c index 6916826179..a2d52df4a2 100644

[U-Boot] [RFC PATCH] cmd: avb: Support A/B slots

2019-08-02 Thread Sam Protsenko
t this? Which would be the best course of action to fix both issues (1) and (2)? Thanks. Signed-off-by: Sam Protsenko --- cmd/avb.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/cmd/avb.c b/cmd/avb.c index 3f6fd763a0..d1942d6605 100644 --- a/cmd/avb.c ++

[U-Boot] [PATCH 2/2] cmd: avb: Fix compiler warnings

2019-07-31 Thread Sam Protsenko
'long int', but argument 2 has type '__kernel_size_t' {aka 'unsigned int'} [-Wformat=] printf("Wrote %ld bytes\n", strlen(value) + 1); ~~^ ~ %d Fix those by using "%zu" specified.

[U-Boot] [PATCH 1/2] avb: Fix build when CONFIG_OPTEE_TA_AVB is disabled

2019-07-31 Thread Sam Protsenko
(as those are only used in that case) to fix the build with mentioned configuration. Signed-off-by: Sam Protsenko --- common/avb_verify.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/common/avb_verify.c b/common/avb_verify.c index 32034d927c..36898a610f 100644 --- a/common/avb_verify.c

Re: [U-Boot] [GIT] Pull request: u-boot-dfu (22.07.2019)

2019-07-26 Thread Sam Protsenko
On Thu, Jul 25, 2019 at 6:41 PM Marek Vasut wrote: > > On 7/25/19 3:27 PM, Sam Protsenko wrote: > > Hi Marek, Lukasz, > > > > On Mon, Jul 22, 2019 at 7:17 PM Lukasz Majewski wrote: > >> > >> Dear Marek, > >> > >> Repo: g...@gitlab.

Re: [U-Boot] [PATCH 1/2] configs: am57xx_evm_defconfig: Enable 'bcb' command

2019-07-25 Thread Sam Protsenko
On Thu, Jul 25, 2019 at 4:17 PM Sam Protsenko wrote: > > It is essential to have an access to BCB area of 'misc' partition on > Android devices [1]. For BeagleBoard X15 the 'bcb' command will be > further used for reboot reason implementation and booting to recovery. > It c

[U-Boot] [PATCH v2 2/2] configs: am57xx_evm_defconfig: Enable 'dtimg' command

2019-07-25 Thread Sam Protsenko
We are going to implement DTBO partition for BeagleBoard X15 further. To support this, 'dtimg' command must be enabled. Signed-off-by: Sam Protsenko --- Changes in v2: - Handle HS defconfigs configs/am57xx_evm_defconfig| 1 + configs/am57xx_hs_evm_defconfig | 1 + configs

[U-Boot] [PATCH v2 1/2] configs: am57xx_evm_defconfig: Enable 'bcb' command

2019-07-25 Thread Sam Protsenko
. [1] doc/android/bcb.txt Signed-off-by: Sam Protsenko --- Changes in v2: - Handle HS defconfigs configs/am57xx_evm_defconfig| 1 + configs/am57xx_hs_evm_defconfig | 1 + configs/am57xx_hs_evm_usb_defconfig | 1 + 3 files changed, 3 insertions(+) diff --git a/configs

Re: [U-Boot] [PATCH] board: ti: am57xx: Correct the fastboot product var

2019-07-25 Thread Sam Protsenko
On Thu, Jul 25, 2019 at 7:28 PM Sam Protsenko wrote: > > On Thu, Jul 25, 2019 at 6:03 PM Andrew F. Davis wrote: > > > > On 7/25/19 10:43 AM, Sam Protsenko wrote: > > > On Thu, Jul 25, 2019 at 5:05 PM Andrew F. Davis wrote: > > >> > > >> On 7/25

[U-Boot] [PATCH v2] omap: Correct the fastboot product var

2019-07-25 Thread Sam Protsenko
7xx boards we can use to device/ti/beagle_x15/board-info.txt file This way requirements check in "fastboot flashall" will work as expected, verifying that user tries to flash images to the board which those images were built for. Signed-off-by: Sam Protsenko --- Changes in v2:

Re: [U-Boot] [PATCH] board: ti: am57xx: Correct the fastboot product var

2019-07-25 Thread Sam Protsenko
On Thu, Jul 25, 2019 at 6:03 PM Andrew F. Davis wrote: > > On 7/25/19 10:43 AM, Sam Protsenko wrote: > > On Thu, Jul 25, 2019 at 5:05 PM Andrew F. Davis wrote: > >> > >> On 7/25/19 9:22 AM, Sam Protsenko wrote: > >>> "fast

Re: [U-Boot] [PATCH] board: ti: am57xx: Correct the fastboot product var

2019-07-25 Thread Sam Protsenko
On Thu, Jul 25, 2019 at 5:05 PM Andrew F. Davis wrote: > > On 7/25/19 9:22 AM, Sam Protsenko wrote: > > "fastboot flashall" expects "fastboot getvar product" to be > > "beagle_x15board". Instead, "am57xx" is returned, as it's set in $b

Re: [U-Boot] [PATCH] test/py: avb: Move AVB test to android dir

2019-07-25 Thread Sam Protsenko
Hi Simon, On Sat, Jul 6, 2019 at 7:53 PM Simon Glass wrote: > > Hi, > > On Tue, 2 Jul 2019 at 12:18, Sam Protsenko wrote: > > > > Signed-off-by: Sam Protsenko > > --- > > test/py/tests/{ => test_android}/test_avb.py | 0 > > 1 file changed, 0 inse

Re: [U-Boot] [GIT] Pull request: u-boot-dfu (22.07.2019)

2019-07-25 Thread Sam Protsenko
bootloader-version" variable (2019-07-22 12:48:47 > +0200) > > > Marek Szyprowski (1): > thor: fix crash after usb initialization failure > > Ralph Siemsen (1): > usb: gadget: f_dfu.c: fix memory l

[U-Boot] [PATCH] board: ti: am57xx: Correct the fastboot product var

2019-07-25 Thread Sam Protsenko
to fix "fastboot flashall". Signed-off-by: Sam Protsenko --- board/ti/am57xx/board.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/board/ti/am57xx/board.c b/board/ti/am57xx/board.c index 1a903f13a6..c8eac4edde 100644 --- a/board/ti/am57xx/board.c +++ b/board/ti/am57xx/board.c

Re: [U-Boot] [PATCH v2] env: ti: boot: Handle reboot reason from BCB

2019-07-25 Thread Sam Protsenko
On Fri, Jul 12, 2019 at 8:35 PM Sam Protsenko wrote: > > In case of Android boot, reboot reason can be written into BCB (usually > it's an area in 'misc' partition). U-Boot then can obtain that reboot > reason from BCB and handle it accordingly to achieve correct Android >

[U-Boot] [PATCH v3] env: ti: boot: Handle reboot reason from BCB

2019-07-25 Thread Sam Protsenko
tps://marc.info/?l=u-boot=152508418909737=2 Signed-off-by: Sam Protsenko --- Changes in v3: - clear BCB on boot-recovery for now, as it's not implemented yet Changes in v2: - use CONTROL_PARTITION instead of "misc" to avoid hard code - add proper indentation incl

[U-Boot] [PATCH 2/2] configs: am57xx_evm_defconfig: Enable 'dtimg' command

2019-07-25 Thread Sam Protsenko
We are going to implement DTBO partition for BeagleBoard X15 further. To support this, 'dtimg' command must be enabled. Signed-off-by: Sam Protsenko --- configs/am57xx_evm_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/am57xx_evm_defconfig b/configs/am57xx_evm_defconfig

[U-Boot] [PATCH 1/2] configs: am57xx_evm_defconfig: Enable 'bcb' command

2019-07-25 Thread Sam Protsenko
. [1] doc/android/bcb.txt Signed-off-by: Sam Protsenko --- configs/am57xx_evm_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/am57xx_evm_defconfig b/configs/am57xx_evm_defconfig index a3de7a4ec4..a1b8d2d988 100644 --- a/configs/am57xx_evm_defconfig +++ b/configs

Re: [U-Boot] [PATCH 1/2] env: ti: Increase boot partition

2019-07-25 Thread Sam Protsenko
On Tue, Jul 2, 2019 at 8:56 PM Sam Protsenko wrote: > > linux-mainline with multi_v7_defconfig + Android configs takes more > space than regular TI Android kernel. Let's increase boot partition > twice, so that boot_fit.img (with new zImage in it) can fit into "boot" >

Re: [U-Boot] [PATCH] doc: Move fastboot protocol doc to android dir

2019-07-20 Thread Sam Protsenko
On Sat, Jul 20, 2019 at 12:45 AM Eugeniu Rosca wrote: > > On Fri, Jul 19, 2019 at 05:36:14PM +0300, Sam Protsenko wrote: > > > You can check my android-next branch [1] to check all patches I > > collected for sending (and my current work on top of it). > > > >

Re: [U-Boot] [PATCH] doc: Move fastboot protocol doc to android dir

2019-07-19 Thread Sam Protsenko
Hi Eugeniu, On Fri, Jul 19, 2019 at 12:12 PM Eugeniu Rosca wrote: > > Hi Sam, > > On Thu, Jul 18, 2019 at 07:57:45PM -0400, Tom Rini wrote: > > On Tue, Jul 02, 2019 at 09:14:57PM +0300, Sam Protsenko wrote: > > > > > Signed-off-by: Sam Protsenko > &g

Re: [U-Boot] [PATCH] env: ti: boot: Use ttyS2 instead of ttyO2

2019-07-16 Thread Sam Protsenko
Hi Andrew, On Mon, Jul 15, 2019 at 10:15 PM Andrew F. Davis wrote: > > On 7/12/19 1:38 PM, Sam Protsenko wrote: > > ttyO2 console enables legacy CONFIG_SERIAL_OMAP driver in kernel. > > Nowadays it's preferred to use the generic CONFIG_SERIAL_8250_OMAP > > driver, which

[U-Boot] [PATCH] env: ti: boot: Use ttyS2 instead of ttyO2

2019-07-12 Thread Sam Protsenko
iki.ti.com/index.php/Sitara_Linux_UART_-_Switching_to_8250_Driver Signed-off-by: Sam Protsenko --- Changes in v2: - use ttyS also in AM57x EVM and in DRA7xx EVM configs include/configs/am57xx_evm.h | 2 +- include/configs/dra7xx_evm.h | 4 ++-- include/environment/ti/boot.h | 2 +- 3 files changed

Re: [U-Boot] [PATCH] env: ti: boot: Use ttyS2 instead of ttyO2

2019-07-12 Thread Sam Protsenko
Superseded by v2. On Tue, Jul 9, 2019 at 5:54 PM Sam Protsenko wrote: > > + Dan Rue > > On Tue, Jul 9, 2019 at 5:49 PM Sam Protsenko > wrote: > > > > ttyO2 console enables legacy CONFIG_SERIAL_OMAP driver in kernel. > > Nowadays it's preferred to use th

[U-Boot] [PATCH v2] env: ti: boot: Handle reboot reason from BCB

2019-07-12 Thread Sam Protsenko
tps://marc.info/?l=u-boot=152508418909737=2 Signed-off-by: Sam Protsenko --- Changes in v2: - use CONTROL_PARTITION instead of "misc" to avoid hard code - add proper indentation include/environment/ti/boot.h | 28 ++-- 1 file changed, 26 insertions(+), 2 dele

Re: [U-Boot] [PATCH] env: ti: boot: Handle reboot reason from BCB

2019-07-12 Thread Sam Protsenko
Superseded by v2. On Tue, Jul 9, 2019 at 5:45 PM Sam Protsenko wrote: > > In case of Android boot, reboot reason can be written into BCB (usually > it's an area in 'misc' partition). U-Boot then can obtain that reboot > reason from BCB and handle it accordingly to achieve correct An

Re: [U-Boot] [PATCH v2 3/5] cmd: bcb: Fix duplicated handling in two case-branches

2019-07-12 Thread Sam Protsenko
On Fri, Jul 12, 2019 at 6:49 PM Eugeniu Rosca wrote: > > On Fri, Jul 12, 2019 at 05:01:09PM +0300, Sam Protsenko wrote: > > > > diff --git a/cmd/bcb.c b/cmd/bcb.c > > > > index 2bd5a744deb5..3b1c7434e287 100644 > > > > --- a/cmd/bcb.c > > > >

Re: [U-Boot] [PATCH v2 3/5] cmd: bcb: Fix duplicated handling in two case-branches

2019-07-12 Thread Sam Protsenko
On Fri, Jul 12, 2019 at 4:37 PM Sam Protsenko wrote: > > On Fri, Jul 12, 2019 at 3:50 PM Eugeniu Rosca wrote: > > > > Fix warning V1037 reported by PVS-Studio Static Analyzer: > > Two or more case-branches perform the same actions. Check lines: 49, 53 > > > >

Re: [U-Boot] [PATCH v2 5/5] cmd: bcb: Apply non-functional refinements

2019-07-12 Thread Sam Protsenko
mmand to read/modify/write BCB fields") > Reported-by: Simon Glass > Signed-off-by: Eugeniu Rosca > --- > v2: > - [Igor Opaniuk] Enriched the patch description > - Fixed inconsistent {field,size} variable rename > > v1: > -

Re: [U-Boot] [PATCH v2 4/5] cmd: bcb: Use strcmp() instead of strncmp() for string literals

2019-07-12 Thread Sam Protsenko
-strcmp.o > > So, overall, I agree to use strcmp() whenever variables are compared > with string literals. > --8<--- > > Fixes: db7b7a05b267 ("cmd: Add 'bcb' command to read/modify/write BCB fields") > Reported-by: Simon Glass > Signed-off-by: Eugeniu Rosca > -

Re: [U-Boot] [PATCH v2 3/5] cmd: bcb: Fix duplicated handling in two case-branches

2019-07-12 Thread Sam Protsenko
> Signed-off-by: Eugeniu Rosca > Reviewed-by: Igor Opaniuk > --- > v2: > - Added 'Reviewed-by: Igor Opaniuk' from v1 > > v1: > - https://patchwork.ozlabs.org/patch/1131301/ > --- Reviewed-by: Sam Protsenko > cmd/bcb.c | 3 --- > 1 file changed, 3 d

Re: [U-Boot] [PATCH v2 2/5] treewide: Fix stale references of Android docs

2019-07-12 Thread Sam Protsenko
ork.ozlabs.org/patch/1104245/#2208134 > > Fixes: 9bdf0e8fef86 ("doc: relocate/rename Android README and add BCB > overview") > Reported-by: Sam Protsenko > Suggested-by: Sam Protsenko > Signed-off-by: Eugeniu Rosca > Reviewed-by: Igor Opaniuk > --- > v2:

Re: [U-Boot] [PATCH v2 1/5] doc: Move README.android-fastboot-protocol to doc/android/

2019-07-12 Thread Sam Protsenko
Reviewed-by: Sam Protsenko On Fri, Jul 12, 2019 at 3:50 PM Eugeniu Rosca wrote: > > Commit 9bdf0e8fef86 ("doc: relocate/rename Android README and add BCB > overview") missed relocating README.android-fastboot-protocol. Fix it. > > Fixes: 9bdf0e8fef86 ("doc:

Re: [U-Boot] [PATCH 2/5] treewide: Fix stale references of Android docs

2019-07-12 Thread Sam Protsenko
> > > > This has been pointed out by Sam (thanks!) in: > > https://patchwork.ozlabs.org/patch/1104245/#2208134 > > > > Fixes: 9bdf0e8fef86 ("doc: relocate/rename Android README and add BCB > > overview") > > Reported-by: Sam Protsenko >

Re: [U-Boot] [PATCH 1/5] doc: Move README.android-fastboot-protocol to doc/android/

2019-07-12 Thread Sam Protsenko
y index 100% > > rename from doc/README.android-fastboot-protocol > > rename to doc/android/fastboot-protocol.txt > > -- > > 2.22.0 > > > > Reviewed-by: Igor Opaniuk > Reviewed-by: Sam Protsenko > -- > Best regards -

Re: [U-Boot] [PATCH v4 0/4] Add 'bcb' command to read/modify/write Android BCB

2019-07-12 Thread Sam Protsenko
Hi Eugeniu, On Fri, Jul 12, 2019 at 12:20 PM Eugeniu Rosca wrote: > > Hi Sam, > > On Tue, Jul 09, 2019 at 03:20:01PM +0300, Sam Protsenko wrote: > > Tom, Simon, > > > > Can we please handle this series and apply it to master? A lot of > > Android-relat

Re: [U-Boot] [PATCH] env: ti: boot: Handle reboot reason from BCB

2019-07-12 Thread Sam Protsenko
Hi Eugeniu, On Fri, Jul 12, 2019 at 12:39 AM Eugeniu Rosca wrote: > > Hi Sam, > > On Tue, Jul 09, 2019 at 05:45:43PM +0300, Sam Protsenko wrote: > > "emmc_android_boot=" \ > > + "if bcb load " __str

Re: [U-Boot] [RFC PATCH] fastboot: Implement fetching uboot env variables via fastboot getvar

2019-07-11 Thread Sam Protsenko
Hi Priit, On Wed, Jul 10, 2019 at 11:42 AM Eugeniu Rosca wrote: > > Hi Priit, > > On Tue, Jul 09, 2019 at 02:52:56PM +0300, Priit Laes wrote: > > From: Priit Laes > > > > Add u-boot specific getvar "extension" to fetch u-boot environment > > variables via `fastboot getvar uboot:var`. This

Re: [U-Boot] [PATCH] env: ti: boot: Use ttyS2 instead of ttyO2

2019-07-09 Thread Sam Protsenko
+ Dan Rue On Tue, Jul 9, 2019 at 5:49 PM Sam Protsenko wrote: > > ttyO2 console enables legacy CONFIG_SERIAL_OMAP driver in kernel. > Nowadays it's preferred to use the generic CONFIG_SERIAL_8250_OMAP > driver, which being enabled via ttyS2 console. Both drivers

[U-Boot] [PATCH] env: ti: boot: Use ttyS2 instead of ttyO2

2019-07-09 Thread Sam Protsenko
iki.ti.com/index.php/Sitara_Linux_UART_-_Switching_to_8250_Driver Signed-off-by: Sam Protsenko --- include/environment/ti/boot.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/environment/ti/boot.h b/include/environment/ti/boot.h index e37004af46..d69ba3a7a6 100644 --- a/include/e

[U-Boot] [PATCH] env: ti: boot: Handle reboot reason from BCB

2019-07-09 Thread Sam Protsenko
tps://marc.info/?l=u-boot=152508418909737=2 Signed-off-by: Sam Protsenko --- include/environment/ti/boot.h | 28 ++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/include/environment/ti/boot.h b/include/environment/ti/boot.h index 54e9b2de4d..e37004af46

Re: [U-Boot] [PATCH v4 0/4] Add 'bcb' command to read/modify/write Android BCB

2019-07-09 Thread Sam Protsenko
> The third patch relocates the Android README to doc/android. > The fourth patch describes the motivation and foreseeable use-cases > behind the 'bcb' command in the newly created doc/android/bcb.txt. > > v4: > - [Simon Glass] Non-functional refinements in cmd/bcb.c >

Re: [U-Boot] [PATCH] test/py: avb: Move AVB test to android dir

2019-07-08 Thread Sam Protsenko
On Sat, Jul 6, 2019 at 11:32 PM Sam Protsenko wrote: > > Hi Simon, > > On Sat, Jul 6, 2019 at 7:53 PM Simon Glass wrote: > > > > Hi, > > > > On Tue, 2 Jul 2019 at 12:18, Sam Protsenko > > wrote: > > > > > > Signed-off-by: Sam

Re: [U-Boot] [PATCH] test/py: avb: Move AVB test to android dir

2019-07-06 Thread Sam Protsenko
Hi Simon, On Sat, Jul 6, 2019 at 7:53 PM Simon Glass wrote: > > Hi, > > On Tue, 2 Jul 2019 at 12:18, Sam Protsenko wrote: > > > > Signed-off-by: Sam Protsenko > > --- > > test/py/tests/{ => test_android}/test_avb.py | 0 > > 1 file changed, 0 inse

Re: [U-Boot] [PATCH v5 6/6] env: am57xx: Implement A/B boot process

2019-07-06 Thread Sam Protsenko
Hi Eugeniu, On Fri, Jul 5, 2019 at 9:52 PM Eugeniu Rosca wrote: > > Hi Igor, > > On Fri, Jul 05, 2019 at 03:37:36PM +0300, Igor Opaniuk wrote: > [..] > > include/environment/ti/boot.h | 58 +++ > [..] > > - "name=boot,size=20M,uuid=${uuid_gpt_boot};" \ > >

Re: [U-Boot] [RFC] env: ti: Handle reboot reason from BCB

2019-07-04 Thread Sam Protsenko
Hi Eugeniu, On Sun, Jun 30, 2019 at 9:49 PM Eugeniu Rosca wrote: > > Hi Sam, > > All below is my 2 cents and FWIW, so feel free to just skip it. > > On Fri, Jun 21, 2019 at 12:25:44AM +0300, Sam Protsenko wrote: > > *** PLEASE DO NOT MERGE. > > *** This is only R

Re: [U-Boot] [PATCH] env: ti: Improve "fastboot reboot bootloader" handling

2019-07-04 Thread Sam Protsenko
nts to get into fastboot mode. > > Signed-off-by: Sam Protsenko > --- > include/environment/ti/boot.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/environment/ti/boot.h b/include/environment/ti/boot.h > index a6b245b1c7..8ddb0416c4 100

Re: [U-Boot] [PATCH] test/py: gpt: Use long options for sgdisk

2019-07-03 Thread Sam Protsenko
Hi Stephen, On Tue, Jul 2, 2019 at 9:35 PM Stephen Warren wrote: > > On 7/2/19 12:20 PM, Sam Protsenko wrote: > > sgdisk 0.8.10.2 from AOSP doesn't support short options, failing with > > errors like this: > > > > sgdisk: invalid option -- 'U' > > > &g

Re: [U-Boot] [PATCH] fastboot: Remove "bootloader-version" variable

2019-07-03 Thread Sam Protsenko
Hi Eugeniu, On Wed, Jun 26, 2019 at 1:12 AM Eugeniu Rosca wrote: > > Hi Sam, > > On Thu, Jun 20, 2019 at 05:00:01PM +0300, Sam Protsenko wrote: > > As per [1], there is no such fastboot variable as "bootloader-version". > > Only "version-

[U-Boot] [PATCH v2] fastboot: Remove "bootloader-version" variable

2019-07-03 Thread Sam Protsenko
ixes: 3aab70afc531d1 ("usb/gadget: add the fastboot gadget") Signed-off-by: Sam Protsenko --- Changes in v2: - add "Fixes:" tag - use fixed link (tag instead of branch) - remove section in link (which may be changed in future) - fixed bootloader version in doc (to not conf

[U-Boot] [PATCH v2] fastboot: getvar: Add "is-userspace" variable

2019-07-03 Thread Sam Protsenko
ot/README.md Signed-off-by: Sam Protsenko --- Changes in v2: - use the fixed link for tag instead of floating one for master branch - add "getvar:" in the commit title to be more specific drivers/fastboot/fb_getvar.c | 9 + 1 file changed, 9 insertions(+) diff --git a/

Re: [U-Boot] [PATCH] fastboot: Add "is-userspace" variable

2019-07-03 Thread Sam Protsenko
Hi Eugeniu, On Fri, Jun 21, 2019 at 5:16 PM Eugeniu Rosca wrote: > > Hi Sam, > > Two nits as input for future patches. No real concerns. Thanks! > > On Thu, Jun 20, 2019 at 04:40:26PM +0300, Sam Protsenko wrote: > > As per documentation [1], Android-Q requires f

[U-Boot] [PATCH] test/py: gpt: Use long options for sgdisk

2019-07-02 Thread Sam Protsenko
sgdisk 0.8.10.2 from AOSP doesn't support short options, failing with errors like this: sgdisk: invalid option -- 'U' Test fails due to that error. Let's use long options to make the test work with any sgdisk version. Signed-off-by: Sam Protsenko --- test/py/tests/test_gpt.py | 11

[U-Boot] [PATCH] test/py: avb: Move AVB test to android dir

2019-07-02 Thread Sam Protsenko
Signed-off-by: Sam Protsenko --- test/py/tests/{ => test_android}/test_avb.py | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename test/py/tests/{ => test_android}/test_avb.py (100%) diff --git a/test/py/tests/test_avb.py b/test/py/tests/test_android/test_avb.py similarity ind

[U-Boot] [PATCH] doc: Move fastboot protocol doc to android dir

2019-07-02 Thread Sam Protsenko
Signed-off-by: Sam Protsenko --- .../fastboot-protocol.txt}| 0 doc/android/fastboot.txt | 4 ++-- 2 files changed, 2 insertions(+), 2 deletions(-) rename doc/{README.android-fastboot-protocol => android/fastb

Re: [U-Boot] [PATCH v3 3/3] doc: relocate/rename Android README and add BCB overview

2019-07-02 Thread Sam Protsenko
Hi Eugeniu, On Thu, May 23, 2019 at 6:33 PM Eugeniu Rosca wrote: > > Rename: > - doc/{README.avb2 => android/avb2.txt} > - doc/{README.android-fastboot => android/fastboot.txt} > > Add a new file documenting the 'bcb' command: > - doc/android/bcb.txt > > The new directory structure has been

  1   2   3   4   5   >