Re: [PATCH v6 0/6] FUSB302 USB-C controller support

2024-09-18 Thread Sebastian Reichel
Hi Jonas, On Wed, Sep 18, 2024 at 09:56:35AM GMT, Jonas Karlman wrote: > On 2024-09-05 17:08, Sebastian Reichel wrote: > > On ROCK 5B power is usually supplied via it's USB-C port. This port has the > > data lines connected to RK3588, VBUS connected to the input regul

[PATCH v6 5/6] rockchip: rock5b-rk3588: Enable USB-C PD support

2024-09-05 Thread Sebastian Reichel
Now that all code has been prepared update the default configuration to make use of it. Reviewed-by: Kever Yang Tested-by: Soeren Moch Signed-off-by: Sebastian Reichel --- configs/rock5b-rk3588_defconfig | 4 1 file changed, 4 insertions(+) diff --git a/configs/rock5b-rk3588_defconfig b

[PATCH v6 2/6] usb: tcpm: fusb302: add driver

2024-09-05 Thread Sebastian Reichel
-by: Sebastian Reichel --- drivers/usb/tcpm/Kconfig |8 + drivers/usb/tcpm/Makefile |1 + drivers/usb/tcpm/fusb302.c | 1323 drivers/usb/tcpm/fusb302_reg.h | 177 + 4 files changed, 1509 insertions(+) create mode 100644 drivers/usb/tcpm

[PATCH v6 6/6] MAINTAINERS: add TCPM section

2024-09-05 Thread Sebastian Reichel
Add new section for USB TypeC Port Manager (TCPM) support, which is needed to figure out cable orientation of USB-C plus and to do USB PD communication. Signed-off-by: Sebastian Reichel --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index

[PATCH v6 1/6] usb: tcpm: add core framework

2024-09-05 Thread Sebastian Reichel
assuming a serial adapter is connected). This also includes a 'tcpm' command, which can be used to get information about the current state and the negotiated voltage and current. Co-developed-by: Wang Jie Signed-off-by: Wang Jie Tested-by: Soeren Moch Signed-off-by: Sebastian Re

[PATCH v6 0/6] FUSB302 USB-C controller support

2024-09-05 Thread Sebastian Reichel
b302: move fusb302_poll_event() to avoid forward defintion * fusb302: drop probe function * fusb302: drop unused LOG_BUFFER defines * roughly 20% of all lines of the series changed between v1 and v2, so I did not collect the Tested-by from Soeren Moch Greetings, -- Sebastian Sebastian R

[PATCH v6 4/6] rockchip: rk3588-rock-5b: Add USB-C controller to u-boot.dtsi

2024-09-05 Thread Sebastian Reichel
lt with early USB-PD initialization. Until the Kernel DT has the node, let's add it in U-Boot to get things going. Reviewed-by: Kever Yang Tested-by: Soeren Moch Signed-off-by: Sebastian Reichel --- arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 28 + 1 file changed, 28 inserti

[PATCH v6 3/6] board: rock5b-rk3588: enable USB-C in operating system

2024-09-05 Thread Sebastian Reichel
ated USB PD. Currently existing upstream kernel DTs do not yet have the USB-C controller at all, so we ignore any failures. Reviewed-by: Kever Yang Tested-by: Soeren Moch Signed-off-by: Sebastian Reichel --- board/radxa/rock5b-rk3588/Makefile| 6 ++ board/radxa/rock5b-rk3588/rock5b

Re: [PATCH v5 0/6] FUSB302 USB-C controller support

2024-09-03 Thread Sebastian Reichel
Hi Soeren, On Wed, Sep 04, 2024 at 12:26:43AM GMT, Soeren Moch wrote: > > * non PD capable (reports 5V 0A) > > With a dumb power supply (actually 12V w/o USB-PD) I see a error message > (not really sure if that makes sense, but no strong opinion from my side) > and 5V/1.5A reported with 'tcpm in

[PATCH v5 5/6] rockchip: rock5b-rk3588: Enable USB-C PD support

2024-09-03 Thread Sebastian Reichel
Now that all code has been prepared update the default configuration to make use of it. Reviewed-by: Kever Yang Signed-off-by: Sebastian Reichel --- configs/rock5b-rk3588_defconfig | 4 1 file changed, 4 insertions(+) diff --git a/configs/rock5b-rk3588_defconfig b/configs/rock5b

[PATCH v5 6/6] MAINTAINERS: add TCPM section

2024-09-03 Thread Sebastian Reichel
Add new section for USB TypeC Port Manager (TCPM) support, which is needed to figure out cable orientation of USB-C plus and to do USB PD communication. Signed-off-by: Sebastian Reichel --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index

[PATCH v5 3/6] board: rock5b-rk3588: enable USB-C in operating system

2024-09-03 Thread Sebastian Reichel
ated USB PD. Currently existing upstream kernel DTs do not yet have the USB-C controller at all, so we ignore any failures. Reviewed-by: Kever Yang Signed-off-by: Sebastian Reichel --- board/radxa/rock5b-rk3588/Makefile| 6 ++ board/radxa/rock5b-rk3588/rock5b-rk3588.c | 16

[PATCH v5 0/6] FUSB302 USB-C controller support

2024-09-03 Thread Sebastian Reichel
* roughly 20% of all lines of the series changed between v1 and v2, so I did not collect the Tested-by from Soeren Moch Greetings, -- Sebastian Sebastian Reichel (6): usb: tcpm: add core framework usb: tcpm: fusb302: add driver board: rock5b-rk3588: enable USB-C in operating system roc

[PATCH v5 1/6] usb: tcpm: add core framework

2024-09-03 Thread Sebastian Reichel
assuming a serial adapter is connected). This also includes a 'tcpm' command, which can be used to get information about the current state and the negotiated voltage and current. Co-developed-by: Wang Jie Signed-off-by: Wang Jie Signed-off-by: Sebastian Reichel --- Makefile

[PATCH v5 2/6] usb: tcpm: fusb302: add driver

2024-09-03 Thread Sebastian Reichel
used to control a mux for connecting the right USB3 lane pair to the USB3 controller. The driver is originally from the Linux kernel, but has been adapted to the requirements of U-Boot and its TCPM framework. Co-developed-by: Wang Jie Signed-off-by: Wang Jie Signed-off-by: Sebastian Reichel

[PATCH v5 4/6] rockchip: rk3588-rock-5b: Add USB-C controller to u-boot.dtsi

2024-09-03 Thread Sebastian Reichel
lt with early USB-PD initialization. Until the Kernel DT has the node, let's add it in U-Boot to get things going. Reviewed-by: Kever Yang Signed-off-by: Sebastian Reichel --- arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 28 + 1 file changed, 28 insertions(+) diff --git a/arch

Re: [PATCH v4 0/6] FUSB302 USB-C controller support

2024-09-03 Thread Sebastian Reichel
Hi, On Tue, Sep 03, 2024 at 03:42:51PM GMT, Sören Moch wrote: > On 03.09.24 13:00, Soeren Moch wrote: > > Hi Sebastian, > > > > On 31.08.24 15:36, Soeren Moch wrote: > > [...] > > > Unfortunately I see the same problem as in v3: boot loop when powering > > > the board from my notebook (ThinkPad X

[PATCH v4 1/6] usb: tcpm: add core framework

2024-08-30 Thread Sebastian Reichel
assuming a serial adapter is connected). This also includes a 'tcpm' command, which can be used to get information about the current state and the negotiated voltage and current. Co-developed-by: Wang Jie Signed-off-by: Wang Jie Signed-off-by: Sebastian Reichel --- Makefile

[PATCH v4 6/6] MAINTAINERS: add TCPM section

2024-08-30 Thread Sebastian Reichel
Add new section for USB TypeC Port Manager (TCPM) support, which is needed to figure out cable orientation of USB-C plus and to do USB PD communication. Signed-off-by: Sebastian Reichel --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index

[PATCH v4 2/6] usb: tcpm: fusb302: add driver

2024-08-30 Thread Sebastian Reichel
used to control a mux for connecting the right USB3 lane pair to the USB3 controller. The driver is originally from the Linux kernel, but has been adapted to the requirements of U-Boot and its TCPM framework. Co-developed-by: Wang Jie Signed-off-by: Wang Jie Signed-off-by: Sebastian Reichel

[PATCH v4 5/6] rockchip: rock5b-rk3588: Enable USB-C PD support

2024-08-30 Thread Sebastian Reichel
Now that all code has been prepared update the default configuration to make use of it. Reviewed-by: Kever Yang Signed-off-by: Sebastian Reichel --- configs/rock5b-rk3588_defconfig | 4 1 file changed, 4 insertions(+) diff --git a/configs/rock5b-rk3588_defconfig b/configs/rock5b

[PATCH v4 0/6] FUSB302 USB-C controller support

2024-08-30 Thread Sebastian Reichel
sb302: drop unused LOG_BUFFER defines * roughly 20% of all lines of the series changed between v1 and v2, so I did not collect the Tested-by from Soeren Moch Greetings, -- Sebastian Sebastian Reichel (6): usb: tcpm: add core framework usb: tcpm: fusb302: add driver board: rock5b-rk3588:

[PATCH v4 4/6] rockchip: rk3588-rock-5b: Add USB-C controller to u-boot.dtsi

2024-08-30 Thread Sebastian Reichel
lt with early USB-PD initialization. Until the Kernel DT has the node, let's add it in U-Boot to get things going. Reviewed-by: Kever Yang Signed-off-by: Sebastian Reichel --- arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 28 + 1 file changed, 28 insertions(+) diff --git a/arch

[PATCH v4 3/6] board: rock5b-rk3588: enable USB-C in operating system

2024-08-30 Thread Sebastian Reichel
ated USB PD. Currently existing upstream kernel DTs do not yet have the USB-C controller at all, so we ignore any failures. Reviewed-by: Kever Yang Signed-off-by: Sebastian Reichel --- board/radxa/rock5b-rk3588/Makefile| 6 ++ board/radxa/rock5b-rk3588/rock5b-rk3588.c | 16

Re: [PATCH v3 0/7] FUSB302 USB-C controller support

2024-08-19 Thread Sebastian Reichel
Hi, On Mon, Aug 19, 2024 at 07:08:37PM GMT, Marek Vasut wrote: > On 8/18/24 11:43 PM, Jonas Karlman wrote: > > > > On ROCK 5B power is usually supplied via it's USB-C port. This port has > > > > the > > > > data lines connected to RK3588, VBUS connected to the input regulator > > > > and > > > >

Re: [PATCH v3 0/7] FUSB302 USB-C controller support

2024-08-19 Thread Sebastian Reichel
Hi, On Sun, Aug 18, 2024 at 11:43:36PM GMT, Jonas Karlman wrote: > Hi Marek and Sebastian, > > On 2024-08-18 22:35, Marek Vasut wrote: > > On 8/2/24 7:59 PM, Sebastian Reichel wrote: > >> Hi, > > > > Hello everyone, > > > >> On ROCK 5B power

Re: [PATCH v3 3/7] board: rock5b-rk3588: add USB-C controller support

2024-08-03 Thread Sebastian Reichel
Hi Jonas, On Fri, Aug 02, 2024 at 10:42:56PM GMT, Jonas Karlman wrote: > On 2024-08-02 19:59, Sebastian Reichel wrote: > > Enable support for the fusb302 USB Type-C controller. > > > > This will do early USB PD (power deliver) negotiation, which must happen > > withi

Re: [PATCH v3 4/7] board: rock5b-rk3588: enable USB-C in operating system

2024-08-03 Thread Sebastian Reichel
Hi Jonas, On Fri, Aug 02, 2024 at 11:04:05PM GMT, Jonas Karlman wrote: > Hi Sebastian, > > On 2024-08-02 19:59, Sebastian Reichel wrote: > > Since older U-Boot releases do not negotiate USB PD, the kernel > > DT may not enable the USB-C controller by default to avoid a >

[PATCH v3 7/7] MAINTAINERS: add TCPM section

2024-08-02 Thread Sebastian Reichel
Add new section for USB TypeC Port Manager (TCPM) support, which is needed to figure out cable orientation of USB-C plus and to do USB PD communication. Signed-off-by: Sebastian Reichel --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index

[PATCH v3 6/7] rockchip: rock5b-rk3588: Enable USB-C PD support

2024-08-02 Thread Sebastian Reichel
Now that all code has been prepared update the default configuration to make use of it. Signed-off-by: Sebastian Reichel --- configs/rock5b-rk3588_defconfig | 5 + 1 file changed, 5 insertions(+) diff --git a/configs/rock5b-rk3588_defconfig b/configs/rock5b-rk3588_defconfig index

[PATCH v3 5/7] rockchip: rk3588-rock-5b: Add USB-C controller to u-boot.dtsi

2024-08-02 Thread Sebastian Reichel
lt with early USB-PD initialization. Until the Kernel DT has the node, let's add it in U-Boot to get things going. Signed-off-by: Sebastian Reichel --- arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 28 + 1 file changed, 28 insertions(+) diff --git a/arch/arm/dts/rk3588-rock-5b-u-

[PATCH v3 4/7] board: rock5b-rk3588: enable USB-C in operating system

2024-08-02 Thread Sebastian Reichel
ated USB PD. Currently existing upstream kernel DTs do not yet have the USB-C controller at all, so we ignore any failures. Signed-off-by: Sebastian Reichel --- board/radxa/rock5b-rk3588/rock5b-rk3588.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/board/radxa/rock5b-rk35

[PATCH v3 1/7] usb: tcpm: add core framework

2024-08-02 Thread Sebastian Reichel
assuming a serial adapter is connected). This also includes a 'tcpm' command, which can be used to get information about the current state and the negotiated voltage and current. Co-developed-by: Wang Jie Signed-off-by: Wang Jie Signed-off-by: Sebastian Reichel --- Makefile

[PATCH v3 2/7] usb: tcpm: fusb302: add driver

2024-08-02 Thread Sebastian Reichel
used to control a mux for connecting the right USB3 lane pair to the USB3 controller. The driver is originally from the Linux kernel, but has been adapted to the requirements of U-Boot and its TCPM framework. Co-developed-by: Wang Jie Signed-off-by: Wang Jie Signed-off-by: Sebastian Reichel

[PATCH v3 3/7] board: rock5b-rk3588: add USB-C controller support

2024-08-02 Thread Sebastian Reichel
loose its power-supply and reset. By initializing PD in U-Boot, this can be avoided. Signed-off-by: Sebastian Reichel --- board/radxa/rock5b-rk3588/Makefile| 6 board/radxa/rock5b-rk3588/rock5b-rk3588.c | 35 +++ 2 files changed, 41 insertions(+) create mode

[PATCH v3 0/7] FUSB302 USB-C controller support

2024-08-02 Thread Sebastian Reichel
d forward defintion * fusb302: drop probe function * fusb302: drop unused LOG_BUFFER defines * roughly 20% of all lines of the series changed between v1 and v2, so I did not collect the Tested-by from Soeren Moch Greetings, -- Sebastian Sebastian Reichel (7): usb: tcpm: add core framew

[PATCH v2 5/5] MAINTAINERS: add TCPM section

2024-06-04 Thread Sebastian Reichel
Add new section for USB TypeC Port Manager (TCPM) support, which is needed to figure out cable orientation of USB-C plus and to do USB PD communication. Signed-off-by: Sebastian Reichel --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index

[PATCH v2 1/5] usb: tcpm: add core framework

2024-06-04 Thread Sebastian Reichel
assuming a serial adapter is connected). This also includes a 'tcpm' command, which can be used to get information about the current state and the negotiated voltage and current. Co-developed-by: Wang Jie Signed-off-by: Wang Jie Signed-off-by: Sebastian Reichel --- Makefile

[PATCH v2 2/5] usb: tcpm: fusb302: add driver

2024-06-04 Thread Sebastian Reichel
used to control a mux for connecting the right USB3 lane pair to the USB3 controller. The driver is originally from the Linux kernel, but has been adapted to the requirements of U-Boot and its TCPM framework. Co-developed-by: Wang Jie Signed-off-by: Wang Jie Signed-off-by: Sebastian Reichel

[PATCH v2 4/5] board: rock5b-rk3588: enable USB-C in operating system

2024-06-04 Thread Sebastian Reichel
Since older U-Boot releases do not negotiate USB PD, the kernel DT may not enable the USB-C controller by default to avoid a regression. The plan is to upstream it with 'status = "fail";' instead. U-Boot should then mark it as 'status = "okay";' if it nego

[PATCH v2 3/5] board: rock5b-rk3588: add USB-C controller support

2024-06-04 Thread Sebastian Reichel
U-Boot first. Signed-off-by: Sebastian Reichel --- arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 28 +++ board/radxa/rock5b-rk3588/Makefile| 6 + board/radxa/rock5b-rk3588/rock5b-rk3588.c | 22 ++ configs/rock5b-rk3588_defconfig | 4

[PATCH v2 0/5] FUSB302 USB-C controller support

2024-06-04 Thread Sebastian Reichel
hly 20% of all lines of the series changed between v1 and v2, so I did not collect the Tested-by from Soeren Moch Greetings, -- Sebastian Sebastian Reichel (5): usb: tcpm: add core framework usb: tcpm: fusb302: add driver board: rock5b-rk3588: add USB-C controller support boar

Re: [PATCH v1 0/5] FUSB302 USB-C controller support

2024-06-03 Thread Sebastian Reichel
Hello Jonas, On Mon, Jun 03, 2024 at 11:58:07AM +0200, Jonas Karlman wrote: > Some initial quick feedback is that the tcpm uclass and driver should > probably take more advantage of the u-boot driver model. > > Few quick thoughts: > - Split out uclass/driver api parts into tcpm-uclass.c > - Take

[PATCH v1 2/5] usb: tcpm: fusb302: add driver

2024-05-31 Thread Sebastian Reichel
used to control a mux for connecting the right USB3 lane pair to the USB3 controller. The driver is originally from the Linux kernel, but has been adapted to the requirements of U-Boot and its TCPM framework. Co-developed-by: Wang Jie Signed-off-by: Wang Jie Signed-off-by: Sebastian Reichel

[PATCH v1 5/5] MAINTAINERS: add TCPM section

2024-05-31 Thread Sebastian Reichel
Add new section for USB TypeC Port Manager (TCPM) support, which is needed to figure out cable orientation of USB-C plus and to do USB PD communication. Signed-off-by: Sebastian Reichel --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index

[PATCH v1 4/5] board: rock5b-rk3588: enable USB-C in operating system

2024-05-31 Thread Sebastian Reichel
Since older U-Boot releases do not negotiate USB PD, the kernel DT may not enable the USB-C controller by default to avoid a regression. The plan is to upstream it with 'status = "fail";' instead. U-Boot should then mark it as 'status = "okay";' if it nego

[PATCH v1 1/5] usb: tcpm: add core framework

2024-05-31 Thread Sebastian Reichel
assuming a serial adapter is connected). This also includes a 'tcpm' command, which can be used to get information about the current state and the negotiated voltage and current. Co-developed-by: Wang Jie Signed-off-by: Wang Jie Signed-off-by: Sebastian Reichel --- Makefile

[PATCH v1 0/5] FUSB302 USB-C controller support

2024-05-31 Thread Sebastian Reichel
reads. For this I used a priorly ported version from Rockchip, removed their hacks and any states not necessary in U-Boot (e.g. audio accessory support). Greetings, -- Sebastian Sebastian Reichel (5): usb: tcpm: add core framework usb: tcpm: fusb302: add driver board: rock5b-rk3588: add USB-C

[PATCH v1 3/5] board: rock5b-rk3588: add USB-C controller support

2024-05-31 Thread Sebastian Reichel
U-Boot first. Signed-off-by: Sebastian Reichel --- arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 28 +++ board/radxa/rock5b-rk3588/Makefile| 6 + board/radxa/rock5b-rk3588/rock5b-rk3588.c | 22 ++ configs/rock5b-rk3588_defconfig | 4

Re: [PATCH v2 5/7] net: dwc_eth_qos_rockchip: Add support for RK3588

2023-10-01 Thread Sebastian Reichel
c support for rk3588") > 88619e77b33d ("net: stmmac: rk3588: Allow multiple gmac controller") > > Signed-off-by: Jonas Karlman > Reviewed-by: Kever Yang > --- > Cc: David Wu > Cc: Sebastian Reichel > Cc: Benjamin Gaignard > --- Looks like I've send my R-b to

Re: [PATCH 5/7] net: dwc_eth_qos_rockchip: Add support for RK3588

2023-10-01 Thread Sebastian Reichel
b60a0ec28 ("net: ethernet: stmmac: dwmac-rk: Add gmac support for > > rk3588") > > 88619e77b33d ("net: stmmac: rk3588: Allow multiple gmac controller") > > > > Signed-off-by: Jonas Karlman > Reviewed-by: Kever Yang FWIW it's also Reviewed-b

Re: [PATCH v2 0/7] rockchip: rk3568: Fix use of PCIe bifurcation

2023-10-01 Thread Sebastian Reichel
Hi, On Wed, Sep 27, 2023 at 06:07:59PM +, Jonas Karlman wrote: > Above works with this series in U-Boot and also in mainline linux. Not > sure the RK3588 bifurcation part of driver have been verified on real HW, > rk3588 boards available for testing have typicality not used bifurcation. Upstr

Re: U-Boot video output for rk3588

2023-08-02 Thread Sebastian Reichel
Hi, On Wed, Aug 02, 2023 at 03:19:04PM -0600, Simon Glass wrote: > On Wed, 2 Aug 2023 at 15:03, Simon Glass wrote: > > Does anyone know how to enable HDMI output on this device in U-Boot, > > e.g. on rock5b? Upstream kernel does not yet support RK3588 HDMI output, but Cristian Ciocaltea (added i

Re: [PATCH 2/2] reset: rockchip: implement rk3588 lookup table

2023-04-14 Thread Sebastian Reichel
Hi Kever, On Fri, Apr 14, 2023 at 12:03:00PM +0300, Eugen Hristev wrote: > On 4/14/23 10:02, Kever Yang wrote: > > On 2023/4/13 19:36, Eugen Hristev wrote: > > > The current DT bindings for the rk3588 clock use a different ID than the > > > one that is supposed to be written to the hardware regist

Re: [PATCH] Taking over responsibility for GE boards from Sebastian

2021-09-21 Thread Sebastian Reichel
Hi, On Tue, Sep 21, 2021 at 05:35:06PM +0100, Martyn Welch wrote: > I am taking over responsibility for the GE board from Sebastian Reichel. > Updating the MAINTAINERS files to reflect this. > > Signed-off-by: Martyn Welch Acked-by: Sebastian Reichel -- Sebastian > --- >

[PATCH] board: ge: bx50v3: Add PCIe reset to DT

2021-08-04 Thread Sebastian Reichel
Add PCIe reset gpio to the Bx50v3 devicetree and get get rid of CONFIG_PCIE_IMX_PERST_GPIO. Signed-off-by: Sebastian Reichel --- arch/arm/dts/imx6q-bx50v3-uboot.dtsi | 10 ++ include/configs/ge_bx50v3.h | 1 - 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/arch

[PATCHv2 0/2] Introduce mcp230xx support

2021-07-15 Thread Sebastian Reichel
for local variables in mcp230xx_set_flags() * Add Reviewed-by from Simon Glass -- Sebastian Sebastian Reichel (2): i2c: add dm_i2c_reg_clrset gpio: mcp230xx: Introduce new driver drivers/gpio/Kconfig | 10 ++ drivers/gpio/Makefile| 1 + drivers/gpio/mcp230xx_gpio.c | 235

[PATCHv2 2/2] gpio: mcp230xx: Introduce new driver

2021-07-15 Thread Sebastian Reichel
Introduce driver for I2C based MCP230xx GPIO chips, which are quite common and already well supported by the Linux kernel. Reviewed-by: Simon Glass Signed-off-by: Sebastian Reichel --- drivers/gpio/Kconfig | 10 ++ drivers/gpio/Makefile| 1 + drivers/gpio/mcp230xx_gpio.c

[PATCHv2 1/2] i2c: add dm_i2c_reg_clrset

2021-07-15 Thread Sebastian Reichel
Add function to apply a bitmask to an i2c register, so that specific bits can be cleared and/or set. Suggested-by: Simon Glass Signed-off-by: Sebastian Reichel --- drivers/i2c/i2c-uclass.c | 15 +++ include/i2c.h| 14 ++ test/dm/i2c.c| 29

Re: [PATCHv2 1/4] ge_bx50v3: Remove unused USB related defines

2021-07-13 Thread Sebastian Reichel
Hi, On Fri, Jul 09, 2021 at 10:11:53AM -0400, Tom Rini wrote: > These USB defines do not change the build as there is no USB support > enabled currently. > > Cc: Ian Ray > Cc: Sebastian Reichel > Signed-off-by: Tom Rini > --- Reviewed-by: Sebastian Reichel -- Sebas

[PATCH] gpio: mcp230xx: Introduce new driver

2021-07-06 Thread Sebastian Reichel
Introduce driver for I2C based MCP230xx GPIO chips, which are quite common and already well supported by the Linux kernel. Signed-off-by: Sebastian Reichel --- drivers/gpio/Kconfig | 10 ++ drivers/gpio/Makefile| 1 + drivers/gpio/mcp230xx_gpio.c | 235

[PATCH 7/7] include: configs: ge: avoid shell on boot failure

2021-04-23 Thread Sebastian Reichel
From: Ian Ray Prevent shell access on boot failure by entering an infinite loop. Signed-off-by: Ian Ray Signed-off-by: Sebastian Reichel --- include/configs/ge_bx50v3.h | 3 ++- include/configs/mx53ppd.h | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/include

[PATCH 6/7] include: configs: ge: simplify default boot command

2021-04-23 Thread Sebastian Reichel
From: Ian Ray Minor cosmetic changes to unify `CONFIG_EXTRA_ENV_SETTINGS' indentation between Bx50v3 and PPD to make comparison and review easier and simplify the default boot command. Signed-off-by: Ian Ray Ian Ray Signed-off-by: Sebastian Reichel --- include/configs/ge_bx50v3.h

[PATCH 2/7] board: ge: bx50v3: add phy reset GPIO

2021-04-23 Thread Sebastian Reichel
sters correctly after resetting the PHY and thus must not reset it. Signed-off-by: Sebastian Reichel --- arch/arm/dts/imx6q-bx50v3-uboot.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/dts/imx6q-bx50v3-uboot.dtsi b/arch/arm/dts/imx6q-bx50v3-uboot.dtsi index 2de3b85

[PATCH 5/7] include: configs: ge: bx50v3: drop USB boot

2021-04-23 Thread Sebastian Reichel
From: Ian Ray Remove unsupported USB boot. Signed-off-by: Ian Ray Signed-off-by: Sebastian Reichel --- include/configs/ge_bx50v3.h | 5 - 1 file changed, 5 deletions(-) diff --git a/include/configs/ge_bx50v3.h b/include/configs/ge_bx50v3.h index 2d854af9a06d..f1e0ec553ce6 100644 --- a

[PATCH 3/7] configs: ge: bx50v3: adjust watchdog period

2021-04-23 Thread Sebastian Reichel
From: Ian Ray Increase watchdog period, in order to accomodate recent kernel size and configuration changes. Signed-off-by: Ian Ray Signed-off-by: Sebastian Reichel --- configs/ge_bx50v3_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configs/ge_bx50v3_defconfig

[PATCH 4/7] configs: ge: use non-persistent environment

2021-04-23 Thread Sebastian Reichel
From: Ian Ray Disable the unused persistent environment. Signed-off-by: Ian Ray Signed-off-by: Sebastian Reichel --- configs/ge_bx50v3_defconfig | 2 +- configs/mx53ppd_defconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configs/ge_bx50v3_defconfig b/configs

[PATCH 0/7] GE Board fixes and cleanups

2021-04-23 Thread Sebastian Reichel
: ge: avoid shell on boot failure Sebastian Reichel (2): board: ge: bx50v3: fix crystal bit board: ge: bx50v3: add phy reset GPIO arch/arm/dts/imx6q-bx50v3-uboot.dtsi | 12 board/ge/bx50v3/bx50v3.c | 26 ++ configs/ge_bx50v3_defconfig

[PATCH 1/7] board: ge: bx50v3: fix crystal bit

2021-04-23 Thread Sebastian Reichel
The DA9063 enables the CRYSTAL bit by default, but there is no crystal populated on the BA16 system on module. Without explicitly clearing the CRYSTAL bit the system runs unstable and sometimes reboots unexpectedly. Signed-off-by: Sebastian Reichel --- board/ge/bx50v3/bx50v3.c | 26

Re: [PATCHv2 3/5] image: support board_fit_config_name_match

2021-01-05 Thread Sebastian Reichel
Hi Stefano, On Mon, Jan 04, 2021 at 08:41:33PM +0100, Stefano Babic wrote: > > I'm about to send PATCHv3 dropping the OF_LIBFDT_OVERLAY related > > cleanup. > > Thanks ! > > > > So I applied the patches related to the board, but I left this > > > out. > > > > Not applying this patch results in

[PATCHv3 2/2] image: support board_fit_config_name_match

2021-01-04 Thread Sebastian Reichel
Support reusing board_fit_config_name_match() to automatically select a sensible default configuration for booting fitImages using 'bootm'. Reviewed-by: Simon Glass Signed-off-by: Sebastian Reichel --- common/image-fit.c | 19 +-- 1 file changed, 13 insertions(+), 6

[PATCHv3 0/2] Support automatic fitImage config selection

2021-01-04 Thread Sebastian Reichel
OF_LIBFDT_OVERLAY ifdef removal from PATCH 1, this change requires more work -- Sebastian Sebastian Reichel (2): image: cleanup pre-processor usage image: support board_fit_config_name_match common/image-fit.c | 65 +++--- include/image.h| 4 +++ 2 files

[PATCHv3 1/2] image: cleanup pre-processor usage

2021-01-04 Thread Sebastian Reichel
Replace most #ifdef checks for USE_HOSTCC and CONFIG_* with normal if instructions. Reviewed-by: Simon Glass Signed-off-by: Sebastian Reichel --- common/image-fit.c | 46 -- include/image.h| 4 2 files changed, 24 insertions(+), 26

Re: [PATCHv2 3/5] image: support board_fit_config_name_match

2021-01-04 Thread Sebastian Reichel
Hi, On Mon, Dec 28, 2020 at 12:39:57PM +0100, Stefano Babic wrote: > On 15.12.20 00:41, Sebastian Reichel wrote: > > Support reusing board_fit_config_name_match() to automatically > > select a sensible default configuration for booting fitImages > > using 'bootm'. &

[PATCHv2 2/5] image: cleanup pre-processor usage

2020-12-14 Thread Sebastian Reichel
Replace most #ifdef checks for USE_HOSTCC and CONFIG_* with normal if instructions. Signed-off-by: Sebastian Reichel --- common/image-fit.c | 193 + include/image.h| 4 + 2 files changed, 96 insertions(+), 101 deletions(-) diff --git a/common

[PATCHv2 5/5] board: ge: bx50v3: cleanup phy config

2020-12-14 Thread Sebastian Reichel
oard's PHY rework code. Signed-off-by: Sebastian Reichel --- arch/arm/dts/imx6q-ba16.dtsi | 11 +++ board/ge/bx50v3/bx50v3.c | 35 --- 2 files changed, 23 insertions(+), 23 deletions(-) diff --git a/arch/arm/dts/imx6q-ba16.dtsi b/arch/arm/dts/imx6q-

[PATCHv2 4/5] board: ge: bx50v3: remove confidx magic numbers

2020-12-14 Thread Sebastian Reichel
Instead of hardcoding index magic numbers in the board code, also rely on board_fit_config_name_match choosing the right config for the fitImage containing the kernel. Signed-off-by: Sebastian Reichel --- board/ge/bx50v3/bx50v3.c| 16 ++-- include/configs/ge_bx50v3.h | 4

[PATCHv2 3/5] image: support board_fit_config_name_match

2020-12-14 Thread Sebastian Reichel
Support reusing board_fit_config_name_match() to automatically select a sensible default configuration for booting fitImages using 'bootm'. Signed-off-by: Sebastian Reichel --- common/image-fit.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --gi

[PATCHv2 1/5] compiler.h: add host_build()

2020-12-14 Thread Sebastian Reichel
_code(); This improves code readability and test coverage and compiler will eleminate this unreachable code. Signed-off-by: Sebastian Reichel --- include/compiler.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/compiler.h b/include/compiler.h index 90b7afae5376..27b9843497a4 1

[PATCHv2 0/5] GE Bx50v3 cleanups

2020-12-14 Thread Sebastian Reichel
: rely on PHY driver as much as possible Changes since PATCHv1: * introduce patch 1 & 2 * update patch 3 to avoid #if -- Sebastian Sebastian Reichel (5): compiler.h: add host_build() image: cleanup pre-processor usage image: support board_fit_config_name_match board: ge: bx50v3: re

Re: [PATCH 1/3] image: support board_fit_config_name_match

2020-12-12 Thread Sebastian Reichel
Hello Simon, On Sat, Dec 12, 2020 at 08:39:45AM -0700, Simon Glass wrote: > > +#if !defined(USE_HOSTCC) && defined(CONFIG_MULTI_DTB_FIT) > > Is there a way to use 'if IS_ENABLED() 'instead? Here Perhaps we need > a new host_build() function in a suitable header file that returns the > value of US

[PATCH 3/3] board: ge: bx50v3: cleanup phy config

2020-12-08 Thread Sebastian Reichel
oard's PHY rework code. Signed-off-by: Sebastian Reichel --- arch/arm/dts/imx6q-ba16.dtsi | 11 +++ board/ge/bx50v3/bx50v3.c | 35 --- 2 files changed, 23 insertions(+), 23 deletions(-) diff --git a/arch/arm/dts/imx6q-ba16.dtsi b/arch/arm/dts/imx6q-

[PATCH 0/3] GE Bx50v3 cleanups

2020-12-08 Thread Sebastian Reichel
Here are some more cleanups for the GE Bx50v3 board(s): PATCH 1+2: replace magic numbers by analyzing name string from the fitImage config node PATCH 3: rely on PHY driver as much as possible -- Sebastian Sebastian Reichel (3): image: support board_fit_config_name_match board

[PATCH 2/3] board: ge: bx50v3: remove confidx magic numbers

2020-12-08 Thread Sebastian Reichel
Instead of hardcoding index magic numbers in the board code, also rely on board_fit_config_name_match choosing the right config for the fitImage containing the kernel. Signed-off-by: Sebastian Reichel --- board/ge/bx50v3/bx50v3.c| 16 ++-- include/configs/ge_bx50v3.h | 4

[PATCH 1/3] image: support board_fit_config_name_match

2020-12-08 Thread Sebastian Reichel
Support reusing board_fit_config_name_match() to automatically select a sensible default configuration for booting fitImages using 'bootm'. Signed-off-by: Sebastian Reichel --- common/image-fit.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/common/image-fit.c b/common/i

[PATCH] net: e1000: implement eth_write_hwaddr for DM_ETH

2020-11-04 Thread Sebastian Reichel
From: Ian Ray Implement programming MAC address to the hardware also for device model configuration. Fixes: b565b18a294f ("board: ge: bx50v3: Enable DM for PCI and ethernet") Signed-off-by: Ian Ray Signed-off-by: Sebastian Reichel --- drivers/net/e1000.c | 17 ++-

[PATCH 9/9] board: ge: bx50v3: check b850v3 power management watchdog

2020-11-04 Thread Sebastian Reichel
From: Ian Ray Set `bootcause' from b850v3 power management watchdog status. Boot cause "REVERT" is no longer used, remove it. Signed-off-by: Ian Ray Signed-off-by: Sebastian Reichel --- board/ge/bx50v3/bx50v3.c| 17 + include/configs/ge_bx50v3.h |

[PATCH 7/9] board: ge: bx50v3: reduce magic numbers

2020-11-04 Thread Sebastian Reichel
Use VPD product ID instead of confidx, so that we can easily reuse the product ID defines and avoid some magic numbers. Signed-off-by: Sebastian Reichel --- board/ge/bx50v3/bx50v3.c | 28 +++- 1 file changed, 7 insertions(+), 21 deletions(-) diff --git a/board/ge/bx50v3

[PATCH 4/9] board: ge: common: vpd: fix name

2020-11-04 Thread Sebastian Reichel
Commit f692b479f02d changed the VPD partition name from "vpd" to "vpd@0". Fix the VPD reader code to use the new name, so that the VPD code keeps working. Fixes: f692b479f02d ("i2c: eeprom: Use reg property instead of offset and size") Signed-off-by: Sebastian

[PATCH 0/9] GE Board cleanups

2020-11-04 Thread Sebastian Reichel
: reduce VPD EEPROM partition size board: ge: bx50v3: check b850v3 power management watchdog Sebastian Reichel (6): board: ge: bx50v3: Update MAINTAINERS board: ge: ppd: Update MAINTAINERS board: ge: b1x5v2: Add MAINTAINERS board: ge: common: vpd: fix name board: ge: bx50v3: drop unused

[PATCH 3/9] board: ge: b1x5v2: Add MAINTAINERS

2020-11-04 Thread Sebastian Reichel
Introduce maintainers file for the GE B1x5 board. Cc: Huan 'Kitty' Wang Cc: Ian Ray Signed-off-by: Sebastian Reichel --- board/ge/b1x5v2/MAINTAINERS | 9 + 1 file changed, 9 insertions(+) create mode 100644 board/ge/b1x5v2/MAINTAINERS diff --git a/board/ge/b1x5v2/MAINTAINE

[PATCH 5/9] board: ge: bx50v3: correct CONFIG_CMD_NFS

2020-11-04 Thread Sebastian Reichel
From: Ian Ray Fix typo in NFS command configuration check. Signed-off-by: Ian Ray Signed-off-by: Sebastian Reichel --- include/configs/ge_bx50v3.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/configs/ge_bx50v3.h b/include/configs/ge_bx50v3.h index

[PATCH 6/9] board: ge: bx50v3: drop unused pinmux defines

2020-11-04 Thread Sebastian Reichel
Remove pinmux defines, that are no longer used after converting the code to devicetree. Signed-off-by: Sebastian Reichel --- board/ge/bx50v3/bx50v3.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/board/ge/bx50v3/bx50v3.c b/board/ge/bx50v3/bx50v3.c index 8a38ac5d4e4c

[PATCH 8/9] board: ge: reduce VPD EEPROM partition size

2020-11-04 Thread Sebastian Reichel
From: Ian Ray Reduce vital product data size to match the latest specification. Signed-off-by: Ian Ray Signed-off-by: Sebastian Reichel --- arch/arm/dts/imx53-ppd-uboot.dtsi| 2 +- arch/arm/dts/imx6q-bx50v3-uboot.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH 2/9] board: ge: ppd: Update MAINTAINERS

2020-11-04 Thread Sebastian Reichel
alphabetically * Add board specific device tree files to the file list Cc: Martyn Welch Cc: Ian Ray Signed-off-by: Sebastian Reichel --- board/ge/mx53ppd/MAINTAINERS | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/board/ge/mx53ppd/MAINTAINERS b/board/ge/mx53ppd

[PATCH 1/9] board: ge: bx50v3: Update MAINTAINERS

2020-11-04 Thread Sebastian Reichel
This updates the Bx50v3 MAINTAINERS file, so that it also catches changes to the related device tree files. Additionally the list of files has been sorted alphabetically and I added myself as maintainer. Signed-off-by: Sebastian Reichel --- board/ge/bx50v3/MAINTAINERS | 11 --- 1 file

[PATCHv4 7/9] board: ge: common: add config option for RTC and VPD feature

2020-09-02 Thread Sebastian Reichel
While this code is being used by all GE platforms its useful to have it behind a config option for hardware bringup of new platforms. Signed-off-by: Sebastian Reichel --- board/ge/bx50v3/Kconfig | 2 ++ board/ge/common/Kconfig | 7 +++ board/ge/common/Makefile | 3 ++- board/ge/mx53ppd

[PATCHv4 9/9] board: ge: b1x5v2: Add GE B1x5v2 and B1x5Pv2

2020-09-02 Thread Sebastian Reichel
'ge_b1x5v2_defconfig' and the combined image u-boot-with-spi.imx can be flashed directly to 1024 byte offset to /dev/mtdblock0. Alternatively SPL and u-boot.imx can be loaded separately via USB-OTG using e.g. imx_usb. Signed-off-by: Sebastian Reichel --- arch/arm/dts/Makefile | 1 +

[PATCHv4 8/9] board: ge: common: vpd: separate I2C specific code

2020-09-02 Thread Sebastian Reichel
This separates the I2C specific code from the generic GE vital product data code, so that the generic parts can be used on hardware with VPD stored in SPI flash memory. Signed-off-by: Sebastian Reichel --- board/ge/bx50v3/bx50v3.c | 2 +- board/ge/common/vpd_reader.c | 12

[PATCHv4 5/9] sysreset: Add poweroff-gpio driver

2020-09-02 Thread Sebastian Reichel
Add GPIO poweroff driver, which is based on the Linux driver and uses the same DT binding. Reviewed-by: Simon Glass Signed-off-by: Sebastian Reichel --- drivers/sysreset/Kconfig | 7 +++ drivers/sysreset/Makefile| 1 + drivers/sysreset/poweroff_gpio.c | 92

  1   2   >