Re: [PATCHv10 14/15] net/lwip: replace original net commands with lwip

2023-10-04 Thread Simon Goldschmidt
Am 4. Oktober 2023 10:29:54 MESZ schrieb Maxim Uvarov : >On Wed, 4 Oct 2023 at 08:12, Simon Glass wrote: > >> Hi Sean, >> >> On Tue, 3 Oct 2023 at 11:58, Sean Edmond >> wrote: >> > >> > >> > On 2023-09-26 2:41 a.m., Maxim Uvarov wrote: >> > > Replace original commands: ping, tftp, dhcp and wge

Re: [PATCHv9 01/15] submodule: add lwIP as git submodule

2023-09-22 Thread Simon Goldschmidt
On 21.09.2023 09:09, Maxim Uvarov wrote: On Thu, 21 Sept 2023 at 07:06, Simon Glass wrote: Hi Maxim, On Thu, 14 Sept 2023 at 10:20, Maxim Uvarov wrote: add external lwIP library as a git submodule. Oh dear...what is the motivation for using a submodule? Our current stack is nicely in

Re: [PATCHv8 00/15] net/lwip: add lwip library for the network stack

2023-09-22 Thread Simon Goldschmidt
On 21.09.2023 18:29, Simon Glass wrote: Hi, On Wed, 13 Sept 2023 at 07:35, Maxim Uvarov wrote: On Wed, 13 Sept 2023 at 19:14, Tom Rini wrote: On Wed, Sep 13, 2023 at 11:06:13AM +0100, Peter Robinson wrote: Then if for development you need to pull he history of lwip, you can do it w

Re: [PATCHv8 00/15] net/lwip: add lwip library for the network stack

2023-09-13 Thread Simon Goldschmidt
On 13.09.2023 09:53, Ilias Apalodimas wrote: Hi Maxim, On Wed, 13 Sept 2023 at 10:32, Maxim Uvarov wrote: On Wed, 13 Sept 2023 at 01:27, Simon Glass wrote: Hi Maxim, On Tue, 12 Sept 2023 at 05:42, Maxim Uvarov wrote: On Fri, 8 Sept 2023 at 19:59, Tom Rini wrote: On Fri, Sep 08,

Re: [PATCHv8 05/15] net/lwip: implement tftp cmd

2023-09-13 Thread Simon Goldschmidt
On 13.09.2023 08:15, Ilias Apalodimas wrote: + +/* + * (C) Copyright 2023 Linaro Ltd. + */ + +#include +#include +#include +#include + +#include "tftp_client.h" +#include "tftp_server.h" +#include + +#include + +#include + +static ulong daddr; +static ulong size; + +static void *tftp_o

Re: [PATCHv8 04/15] net/lwip: implement dhcp cmd

2023-09-13 Thread Simon Goldschmidt
On 13.09.2023 08:07, Ilias Apalodimas wrote: On Fri, Sep 08, 2023 at 07:53:09PM +0600, Maxim Uvarov wrote: + +#include +#include +#include + +#include +#include +#include "lwip/timeouts.h" + +#include +#include + +#define DHCP_WAIT_MS 2000 Is this the time we wait for a dhcp reply? I

Re: [PATCHv8 03/15] net/lwip: implement dns cmd

2023-09-13 Thread Simon Goldschmidt
On 13.09.2023 07:56, Ilias Apalodimas wrote: On Fri, Sep 08, 2023 at 07:53:08PM +0600, Maxim Uvarov wrote: U-Boot recently got support for an alternative network stack using LWIP. Replace dns command with the LWIP variant while keeping the output and error messages identical. Signed-off-by:

Re: [PATCHv6 09/14] net/lwip: implement lwIP port to U-Boot

2023-08-18 Thread Simon Goldschmidt
Hi all, could you please remove the lwip-devel list from CC? I am interested in these mails, but the more you dive into U-Boot specific things here, the less people on our lwip list will be interested in this topic. Thanks, Simon Am 18. August 2023 14:53:43 MESZ schrieb Maxim Uvarov : >On Wed

Re: [PATCHv5 05/13] net/lwip: implement tftp cmd

2023-08-10 Thread Simon Goldschmidt
On 10.08.2023 13:28, Maxim Uvarov wrote: On Thu, 3 Aug 2023 at 12:42, Ilias Apalodimas wrote: On Wed, Aug 02, 2023 at 08:06:50PM +0600, Maxim Uvarov wrote: Signed-off-by: Maxim Uvarov --- lib/lwip/Makefile | 1 + lib/lwip/apps/tftp/Makefile| 16 + lib/lwip/apps

Re: [lwip-devel] [RFC PATCH 0/5] LWIP stack integration

2023-05-24 Thread Simon Goldschmidt
Hi Maxim, Tom, On 24.05.2023 16:05, Maxim Uvarov wrote: On Tue, 23 May 2023 at 03:23, Tom Rini wrote: On Mon, May 22, 2023 at 12:40:49PM -0400, Maxim Uvarov wrote: On Mon, 22 May 2023 at 10:20, Tom Rini wrote: On Mon, May 22, 2023 at 04:33:57PM +0300, Ilias Apalodimas wrote: Hi Maxim On

Re: [PATCH V2 1/7] env: Warn on force access if ENV_ACCESS_IGNORE_FORCE set

2020-10-23 Thread Simon Goldschmidt
Am 23.10.2020 um 11:52 schrieb Marek Vasut: > On 10/23/20 10:58 AM, Simon Goldschmidt wrote: >> Am 31.07.2020 um 23:40 schrieb Tom Rini: >>> On Tue, Jul 07, 2020 at 08:51:33PM +0200, Marek Vasut wrote: >>> >>>> If the ENV_ACCESS_IGNORE_FORCE is set, infor

Re: [PATCH V2 1/7] env: Warn on force access if ENV_ACCESS_IGNORE_FORCE set

2020-10-23 Thread Simon Goldschmidt
Am 31.07.2020 um 23:40 schrieb Tom Rini: > On Tue, Jul 07, 2020 at 08:51:33PM +0200, Marek Vasut wrote: > >> If the ENV_ACCESS_IGNORE_FORCE is set, inform user that the variable >> cannot be force-set if such attempt happens. >> >> Signed-off-by: Marek Vasut >> Reviewed-by: Tom Rini > > Applied

Re: [PATCH v1 00/16] Enable ARM Trusted Firmware for U-Boot

2020-08-16 Thread Simon Goldschmidt
Chee Hong Ang schrieb am Mo., 17. Aug. 2020, 06:34: > Repost of the following patchs: > https://lists.denx.de/pipermail/u-boot/2020-March/402705.html If this is a repost, please send as such instead of sending as a new series v1. Regards, Simon > > New U-boot flow with ARM Trusted Firmware (

Re: [PATCH v2] Makefile: socfpga: Generate spl/u-boot-splx4.sfp with 4 SPL images

2020-08-11 Thread Simon Goldschmidt
Am 11.08.2020 um 16:21 schrieb Tom Rini: > On Tue, Aug 11, 2020 at 03:14:39PM +0200, Marek Vasut wrote: >> On 8/11/20 3:06 PM, Tom Rini wrote: >>> On Tue, Aug 11, 2020 at 04:01:10PM +0800, Chee Hong Ang wrote: >>> Generate spl/u-boot-splx4.sfp which consist of 4 SPL images required for bo

Re: [PATCH v2] configs: socfpga: add kernel parameter for immediate reboot

2020-08-07 Thread Simon Goldschmidt
Tan, Ley Foon schrieb am Fr., 7. Aug. 2020, 09:25: > > > Ooi, Joyce wrote: > > From: Joyce Ooi > > > > Add Linux kernel line parameters for socfpga soc64 U-Boot. The "panic=-1" > > indicates the reset should occur immediately (without a delay). > > > > Signed-off-by: Joyce Ooi > > --- > > v2: f

Re: [PATCH] arm: socfpga: gen5: Enable cache driver in SPL

2020-06-05 Thread Simon Goldschmidt
Marek Vasut schrieb am Fr., 5. Juni 2020, 14:52: > On 6/5/20 10:20 AM, Ley Foon Tan wrote: > > Adding "u-boot,dm-pre-reloc" and enable CONFIG_SPL_CACHE > > to enable cache driver in SPL. > > > > This fixed error below in SPL: > > cache controller driver NOT found! > What's the size impact of thi

Re: [PATCH v2 21/22] Use __ASSEMBLY__ as the assembly macros

2020-04-14 Thread Simon Goldschmidt
Am 14.04.2020 um 23:04 schrieb Tom Rini: > On Tue, Apr 14, 2020 at 10:38:47PM +0200, Simon Goldschmidt wrote: >> Masahiro Yamada schrieb am Di., 14. Apr. 2020, 17:34: >> >>> Hi Simon, >>> >>> On Tue, Apr 14, 2020 at 11:41 PM Simon Glass wrote: >>&g

Re: [PATCH v2 21/22] Use __ASSEMBLY__ as the assembly macros

2020-04-14 Thread Simon Goldschmidt
Masahiro Yamada schrieb am Di., 14. Apr. 2020, 17:34: > Hi Simon, > > On Tue, Apr 14, 2020 at 11:41 PM Simon Glass wrote: > > > > Hi Masahiro, > > > > On Mon, 13 Apr 2020 at 11:10, Masahiro Yamada > wrote: > > > > > > On Fri, Apr 10, 2020 at 5:18 AM Simon Glass wrote: > > > > > > > > Some plac

Re: [PATCH 22/26 v6] spl: spl_legacy: Add cache flush after reading U-Boot image

2020-04-09 Thread Simon Goldschmidt
Am 09.04.2020 um 09:43 schrieb Stefan Roese: > On 09.04.20 09:29, Simon Goldschmidt wrote: >> Am 08.04.2020 um 10:09 schrieb Stefan Roese: >>> From: Weijie Gao >>> >>> Flush the cache after reading of the U-Boot proper into SDRAM so that >>> it c

Re: [PATCH 22/26 v6] spl: spl_legacy: Add cache flush after reading U-Boot image

2020-04-09 Thread Simon Goldschmidt
ese > Cc: Weijie Gao > Cc: Simon Goldschmidt > --- > Changes in v6: > - New patch > > common/spl/spl_legacy.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/common/spl/spl_legacy.c b/common/spl/spl_legacy.c > index 2cd2a74a4c..e3202060

Re: [PATCH 19/26 v6] spl: spl_nor: Copy image header to local struct

2020-04-09 Thread Simon Goldschmidt
> Signed-off-by: Stefan Roese > Cc: Weijie Gao > Cc: Simon Goldschmidt Reviewed-by: Simon Goldschmidt > --- > Changes in v6: > - New patch > > common/spl/spl_nor.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/common/spl/spl_no

Re: [PATCH v2 1/3] arm: dts: arria10: Move uboot specific properties to u-boot.dtsi

2020-04-07 Thread Simon Goldschmidt
On Tue, Apr 7, 2020 at 9:43 AM Ley Foon Tan wrote: > > Move Uboot specific properties to *u-boot.dtsi files. > Preparation to sync Arria 10 device tree from Linux. > > Signed-off-by: Ley Foon Tan Reviewed-by: Simon Goldschmidt > --- > arch/arm/dts/socfpga_arria10-u

Re: [PATCH v2 2/3] arm: dts: arria10: Update dtsi/dts from Linux

2020-04-07 Thread Simon Goldschmidt
socfpga_arria10.dtsi: > - Add clkmgr label, so that can reference to it in u-boot.dtsi. > > Change in socfpga_arria10-u-boot.dtsi: > - Add compatible and altr,sysmgr-syscon for uboot. > > Signed-off-by: Ley Foon Tan Reviewed-by: Simon Goldschmidt > > --- > v2: Update

Re: [PATCH v2 3/3] arm: socfpga: arria10: Enable cache driver in SPL

2020-04-07 Thread Simon Goldschmidt
On Tue, Apr 7, 2020 at 9:43 AM Ley Foon Tan wrote: > > Adding "u-boot,dm-pre-reloc" and enable CONFIG_SPL_CACHE > to enable cache driver in SPL. > > This fixed error below in SPL: > cache controller driver NOT found! > > Signed-off-by: Ley Foon Tan Reviewed-by

Re: [PATCH 3/3] arm: socfpga: arria10: Enable cache driver in SPL

2020-04-06 Thread Simon Goldschmidt
Am 06.04.2020 um 11:18 schrieb Ley Foon Tan: > Adding "u-boot,dm-pre-reloc" and enable CONFIG_SPL_CACHE > to enable cache driver in SPL. > > This fixed error below in SPL: > cache controller driver NOT found! > > Signed-off-by: Ley Foon Tan > --- > arch/arm/dts/socfpga_arria10-u-boot.dtsi | 4 +

Re: [PATCH v1 1/2] clk: socfpga: Read the clock parent's register base in probe function

2020-04-02 Thread Simon Goldschmidt
On 02.04.2020 21:54, Marek Vasut wrote: On 4/2/20 9:53 PM, Simon Goldschmidt wrote: On 02.04.2020 21:49, Simon Glass wrote: Hi Marek, On Thu, 2 Apr 2020 at 13:45, Marek Vasut wrote: On 4/2/20 8:50 PM, Simon Glass wrote: Hi. Hi, [...] I suspect we could change this, so that

Re: [PATCH v1 1/2] clk: socfpga: Read the clock parent's register base in probe function

2020-04-02 Thread Simon Goldschmidt
On 02.04.2020 21:49, Simon Glass wrote: Hi Marek, On Thu, 2 Apr 2020 at 13:45, Marek Vasut wrote: On 4/2/20 8:50 PM, Simon Glass wrote: Hi. Hi, [...] I suspect we could change this, so that device_ofdata_to_platdata() first calls itself on its parent. I can think of various reasons

Re: [U-Boot] [PATCH] ARM: socfpga: Remove socfpga_sdram_apply_static_cfg()

2020-03-16 Thread Simon Goldschmidt
Am 16.03.2020 um 20:55 schrieb Dalon L Westergreen: > > > On Mon, 2020-03-16 at 20:06 +0100, Marek Vasut wrote: >> On 3/16/20 8:04 PM, Simon Goldschmidt wrote: >>> Am 16.03.2020 um 19:04 schrieb Dalon L Westergreen: >>>> >>>> On Thu, 2020-03-12 at

Re: [U-Boot] [PATCH] ARM: socfpga: Remove socfpga_sdram_apply_static_cfg()

2020-03-16 Thread Simon Goldschmidt
Am 16.03.2020 um 20:06 schrieb Marek Vasut: > On 3/16/20 8:04 PM, Simon Goldschmidt wrote: >> Am 16.03.2020 um 19:04 schrieb Dalon L Westergreen: >>> >>> >>> On Thu, 2020-03-12 at 16:57 +0100, Marek Vasut wrote: >>>> On 3/12/20 4:54 PM, Dalon L Wes

Re: [U-Boot] [PATCH] ARM: socfpga: Remove socfpga_sdram_apply_static_cfg()

2020-03-16 Thread Simon Goldschmidt
Am 16.03.2020 um 19:04 schrieb Dalon L Westergreen: > > > On Thu, 2020-03-12 at 16:57 +0100, Marek Vasut wrote: >> On 3/12/20 4:54 PM, Dalon L Westergreen wrote: >> [...] >> >> (thanks for fixing your mailer :)) >> The problem was that this was causing weird sporadic hangs on Ge

Re: [PATCH 1/1] fit: check return value of fit_image_get_data_size()

2020-03-11 Thread Simon Goldschmidt
(). > > Fixes: c3c863880479 ("add FIT data-position & data-offset property support") > Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Goldschmidt > --- > common/image-fit.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/commo

Re: [PATCH v6 1/5] dm: clk: add stub when CONFIG_CLK is deactivated

2020-03-10 Thread Simon Goldschmidt
ndefined reference to > `clk_disable_bulk') for code: > clk_disable_bulk(&priv->clks); > clk_release_bulk(&priv->clks); > > Signed-off-by: Patrick Delaunay Reviewed-by: Simon Goldschmidt > --- > > Changes in v6: > - return success

Re: [PATCH v6 4/5] usb: host: dwc2: force reset assert

2020-03-10 Thread Simon Goldschmidt
o execute > the usb start command). > > Signed-off-by: Patrick Delaunay Reviewed-by: Simon Goldschmidt > --- > > Changes in v6: None > Changes in v5: None > Changes in v4: None > Changes in v3: None > Changes in v2: > - add clk_disable_bulk in dwc2_usb_remove &g

Re: [PATCH v4 11/21] misc: altera_sysmgr: Add Altera System Manager driver

2020-03-10 Thread Simon Goldschmidt
Am 10.03.2020 um 17:42 schrieb Ang, Chee Hong: >> -Original Message- >> From: Simon Goldschmidt >> Sent: Wednesday, March 11, 2020 12:17 AM >> To: Ang, Chee Hong >> Cc: u-boot@lists.denx.de; Marek Vasut ; See, Chin Liang >> ; Tan, Ley Foon ; &

Re: [PATCH v4 14/21] arch: arm: socfpga: Add 'altr, sysmgr-syscon' for MMC node in device tree

2020-03-10 Thread Simon Goldschmidt
Am 09.03.2020 um 10:07 schrieb chee.hong@intel.com: > From: Chee Hong Ang > > In device tree for all socfpga platforms, a phandle to System Manager > ('altr,sysmgr-syscon') is needed for MMC node to enable the MMC driver > to configure the SDMMC's clock phase shift via System Manager driver >

Re: [PATCH v4 12/21] arch: arm: socfpga: Enable driver model for misc drivers.

2020-03-10 Thread Simon Goldschmidt
Am 09.03.2020 um 10:07 schrieb chee.hong@intel.com: > From: Chee Hong Ang > > Enable this misc driver model for 'altera_sysmgr' driver for > socfpga platforms. > > Signed-off-by: Chee Hong Ang > --- > arch/arm/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/Kco

Re: [PATCH v4 00/21] Enable ARM Trusted Firmware for U-Boot

2020-03-10 Thread Simon Goldschmidt
Am 09.03.2020 um 10:07 schrieb chee.hong@intel.com: > From: "Ang, Chee Hong" > > v4 changes: > [PATCH v4 11/21] misc: altera_sysmgr: Add Altera System Manager > - Add System Manager driver (UCLASS_MISC) to handle secure access for SoC64 > > [PATCH v4 13/21] mmc: dwmmc: socfpga: MMC driver ac

Re: [PATCH v4 11/21] misc: altera_sysmgr: Add Altera System Manager driver

2020-03-10 Thread Simon Goldschmidt
Am 10.03.2020 um 17:42 schrieb Ang, Chee Hong: >> -Original Message- >> From: Simon Goldschmidt >> Sent: Wednesday, March 11, 2020 12:17 AM >> To: Ang, Chee Hong >> Cc: u-boot@lists.denx.de; Marek Vasut ; See, Chin Liang >> ; Tan, Ley Foon ; &

Re: [PATCH v4 11/21] misc: altera_sysmgr: Add Altera System Manager driver

2020-03-10 Thread Simon Goldschmidt
Am 09.03.2020 um 10:07 schrieb chee.hong@intel.com: > From: Chee Hong Ang > > This driver (misc uclass) handle the read/write access to > System Manager. For 64 bits platforms, processor needs to be > in secure mode to has write access to most of the System Manager's > registers (except boot

Re: [U-Boot] [PATCH] ARM: socfpga: Remove socfpga_sdram_apply_static_cfg()

2020-03-09 Thread Simon Goldschmidt
On Mon, Mar 9, 2020 at 3:15 PM Marek Vasut wrote: > > On 3/9/20 3:10 PM, Simon Goldschmidt wrote: > > On Mon, Mar 9, 2020 at 1:57 PM Marek Vasut wrote: > >> > >> On 3/9/20 9:50 AM, Ley Foon Tan wrote: > >>> On Thu, Feb 13, 2020 at 2:52 AM Dalon L We

Re: [U-Boot] [PATCH] ARM: socfpga: Remove socfpga_sdram_apply_static_cfg()

2020-03-09 Thread Simon Goldschmidt
On Mon, Mar 9, 2020 at 1:57 PM Marek Vasut wrote: > > On 3/9/20 9:50 AM, Ley Foon Tan wrote: > > On Thu, Feb 13, 2020 at 2:52 AM Dalon L Westergreen > > wrote: > >> > >> I am reading through this thread, and want to point out that it is not > >> that the > >> FPGA bridge need be actively used in

Re: [PATCH v5 1/5] dm: clk: add stub when CONFIG_CLK is deactivated

2020-03-06 Thread Simon Goldschmidt
On Fri, Mar 6, 2020 at 11:01 AM Patrick Delaunay wrote: > > Add stub for functions clk_...() when CONFIG_CLK is deactivated. > > This patch avoids compilation issues for driver using these API > without protection (#if CONFIG_IS_ENABLED(CLK)) > > For example, before this patch we have undefined re

Re: [PATCH] net: phy: Fix overlong PHY timeout

2020-03-04 Thread Simon Goldschmidt
on by that factor of 50 to bring the > >> timeout back to the intended value. > >> > >> Signed-off-by: Andre Przywara A "Fixes:" tag would have been nice... Anyway: Tested-by: Simon Goldschmidt > > > > I tested this on RPi4 with the genet patche

Re: [PATCH] net: phy: fix autoneg timeout

2020-03-04 Thread Simon Goldschmidt
On Thu, Mar 5, 2020 at 5:40 AM Stefan Roese wrote: > > Hi Simon, > > On 04.03.20 21:12, Simon Goldschmidt wrote: > > Recently, genphy_update_link() has been changed to use a 50ms polling > > interval instead of the previous 1ms. However, the timeout to give up > &g

Re: [PATCH 1/8] malloc: implement USE_DL_PREFIX via inline functions

2020-03-04 Thread Simon Goldschmidt
Am 20.02.2020 um 04:05 schrieb Simon Glass: > On Wed, 19 Feb 2020 at 12:39, Simon Goldschmidt > wrote: >> >> Commit cfda60f99ae2 ("sandbox: Use a prefix for all allocation functions") >> introduced preprocessor macros for malloc/free etc. >> >> This

Re: [PATCH 2/8] Revert "mtd: Rename free() to rfree()"

2020-03-04 Thread Simon Goldschmidt
Am 19.02.2020 um 21:04 schrieb Fabio Estevam: > On Wed, Feb 19, 2020 at 4:40 PM Simon Goldschmidt > wrote: >> >> This reverts commit 8d38a8459b0de45f5ff41f3e11c278a5cf395fd0. > > You missed to explain the reason for the revert. Yes, I'll fix that in v2. Regards, Simon

[PATCH] net: phy: fix autoneg timeout

2020-03-04 Thread Simon Goldschmidt
st to be a number of milliseconds. Fix this by dividing PHY_ANEG_TIMEOUT by 50 in this loop. This gets us back to a 4 seconds timeout for the default value (instead of 200s). Fixes: net: phy: Increase link up delay in genphy_update_link() ("27c3f70f3b50") Signed-off-by: Simon Goldschmidt

Re: [PATCH v4 0/5] usb: host: dwc2: use driver model for PHY and CLOCK

2020-03-04 Thread Simon Goldschmidt
Am 19.02.2020 um 08:27 schrieb Simon Goldschmidt: > On Tue, Feb 18, 2020 at 6:53 PM Marek Vasut wrote: >> >> On 2/18/20 9:34 AM, Patrick Delaunay wrote: >>> >>> In this serie I update the DWC2 host driver to use the device tree >>> information and the

Re: [PATCH v4 3/5] usb: host: dwc2: add clk support

2020-03-04 Thread Simon Goldschmidt
Am 18.02.2020 um 09:35 schrieb Patrick Delaunay: > Add support for clock with driver model. > > This patch don't added dependency because when CONFIG_CLK > is not activated the clk function are stubbed. > > Signed-off-by: Patrick Delaunay Reviewed-by: Simon Goldschmidt

Re: [PATCH v4 2/5] usb: host: dwc2: add phy support

2020-03-04 Thread Simon Goldschmidt
; > + } > + > + return 0; > +} > + > +static int dwc2_shutdown_phy(struct udevice *dev) > +{ > + struct dwc2_priv *priv = dev_get_priv(dev); > + int ret; > + > + if (!generic_phy_valid(&priv->phy)) A comment saying that this is fo

Re: [PATCH v4 1/5] dm: clk: add stub when CONFIG_CLK is desactivated

2020-03-04 Thread Simon Goldschmidt
Am 18.02.2020 um 09:34 schrieb Patrick Delaunay: > Add stub for functions clk_...() when CONFIG_CLK is desactivated. > > This patch avoids compilation issues for driver using these API > without protection (#if CONFIG_IS_ENABLED(CLK)) > > For example, before this patch we have undefined reference

Re: DE1-SoC Board Config

2020-03-02 Thread Simon Goldschmidt
Am 02.03.2020 um 01:39 schrieb Jack Frye: > I am trying to build uboot-socfpga for Terasic DE1-SoC board (Cyclone V), > booting from SDMMC. I am unable to get u-boot to program the FPGA. First question: which version of U-Boot are you using? Upstream sources or Altera sources? > I am following t

Re: [PATCH v2 10/21] arm: socfpga: Add secure register access helper functions for SoC 64bits

2020-02-27 Thread Simon Goldschmidt
Ang, Chee Hong schrieb am Fr., 28. Feb. 2020, 03:53: > > > On 2/24/20 3:21 AM, Ang, Chee Hong wrote: > > > [...] > > > > > > > Currently, we have like 20+ secure registers allowed access by > > > > drivers running in non-secure mode (U-Boot proper / Linux). > > > > I don't think we wa

Re: [PATCH] spi: cadence-qspi: Move ref clock calculation to probe

2020-02-25 Thread Simon Goldschmidt
; > > Acked-by: Vignesh Raghavendra > Fine by me. I actually moved it there after someone requested me to :-) I first had it in the set_rate function... Acked-by: Simon Goldschmidt > > Regards > Vignesh > > > Signed-off-by: Pratyush Yadav > > --- > > d

Re: [PATCH v2 11/21] arm: socfpga: Secure register access for clock manager (SoC 64bits)

2020-02-24 Thread Simon Goldschmidt
Ang, Chee Hong schrieb am Mo., 24. Feb. 2020, 10:12: > > > > > *From:* Ang, Chee Hong > *Sent:* Saturday, February 22, 2020 6:00 PM > *To:* Simon Goldschmidt > *Cc:* U-Boot Mailing List ; Marek Vasut < > ma...@denx.de>; See, Chin Liang ; Tan, Ley Foon > ;

Re: [PATCH v2 11/21] arm: socfpga: Secure register access for clock manager (SoC 64bits)

2020-02-21 Thread Simon Goldschmidt
Ang, Chee Hong schrieb am Sa., 22. Feb. 2020, 06:30: > > From: Chee Hong Ang > > > > Allow clock manager driver to access the System Manager's Boot Scratch > > Register 0 in non-secure mode (EL2) on SoC 64bits platform. > > > > Signed-off-by: Chee Hong Ang > > --- > > arch/arm/mach-socfpga/clo

Re: [PATCH v2 06/21] configs: socfpga: Enable FIT image loading with ATF support

2020-02-20 Thread Simon Goldschmidt
Am 20.02.2020 um 17:45 schrieb Marek Vasut: > On 2/20/20 3:15 AM, Ang, Chee Hong wrote: >>> On 2/19/20 1:25 PM, chee.hong@intel.com wrote: From: Chee Hong Ang SPL now loads ATF (BL31), U-Boot proper and DTB from FIT image. The new boot flow with ATF support is as follow: >>

[PATCH 8/8] Revert "mailbox: Rename free() to rfree()"

2020-02-19 Thread Simon Goldschmidt
This reverts commit cc92c3cc68a9053f53b2814e9233d86553cc998e. Signed-off-by: Simon Goldschmidt --- drivers/mailbox/k3-sec-proxy.c | 2 +- drivers/mailbox/mailbox-uclass.c | 4 ++-- drivers/mailbox/sandbox-mbox.c | 2 +- drivers/mailbox/stm32-ipcc.c | 2 +- drivers/mailbox/tegra-hsp.c

[PATCH 6/8] Revert "reset: Rename free() to rfree()"

2020-02-19 Thread Simon Goldschmidt
This reverts commit 94474b25c3a60a746bf641a975c3db239dae29b9. Signed-off-by: Simon Goldschmidt --- drivers/reset/reset-bcm6345.c | 2 +- drivers/reset/reset-hisilicon.c | 2 +- drivers/reset/reset-hsdk.c | 2 +- drivers/reset/reset-imx7.c | 2 +- drivers/reset/reset-mediatek.c | 2

[PATCH 5/8] Revert "gpio: Rename free() to rfree()"

2020-02-19 Thread Simon Goldschmidt
This reverts commit 093152f275e036e54d48b3d9fc0adbc1ca4cc5b0. Signed-off-by: Simon Goldschmidt --- drivers/gpio/gpio-rcar.c | 2 +- drivers/gpio/gpio-uclass.c | 8 include/asm-generic/gpio.h | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpio/gpio

[PATCH 2/8] Revert "mtd: Rename free() to rfree()"

2020-02-19 Thread Simon Goldschmidt
This reverts commit 8d38a8459b0de45f5ff41f3e11c278a5cf395fd0. Signed-off-by: Simon Goldschmidt --- drivers/mtd/mtdcore.c | 4 ++-- drivers/mtd/nand/raw/denali.c | 2 +- drivers/mtd/nand/spi/core.c | 2 +- drivers/mtd/nand/spi/gigadevice.c | 2 +- drivers/mtd/nand/spi

[PATCH 3/8] Revert "dma: Rename free() to rfree()"

2020-02-19 Thread Simon Goldschmidt
This reverts commit aae95882232a24ee49c89d0356febf3685a87c8a. Signed-off-by: Simon Goldschmidt --- drivers/dma/dma-uclass.c | 4 ++-- drivers/dma/sandbox-dma-test.c | 4 ++-- drivers/dma/ti/k3-udma.c | 4 ++-- include/dma-uclass.h | 4 ++-- 4 files changed, 8 insertions

[PATCH 7/8] Revert "power-domain: Rename free() to rfree()"

2020-02-19 Thread Simon Goldschmidt
This reverts commit 4f51188e47921b17e6b3ce9606c8e71234c9f2df. Signed-off-by: Simon Goldschmidt --- drivers/power/domain/bcm6328-power-domain.c | 2 +- drivers/power/domain/imx8-power-domain-legacy.c | 2 +- drivers/power/domain/imx8-power-domain.c| 2 +- drivers/power/domain/imx8m

[PATCH 4/8] Revert "clk: Rename free() to rfree()"

2020-02-19 Thread Simon Goldschmidt
This reverts commit fb8c0d595f1ad83bee5dd398b59b0ee16d8d15a9. Signed-off-by: Simon Goldschmidt --- drivers/clk/clk-ti-sci.c | 2 +- drivers/clk/clk-uclass.c | 4 ++-- drivers/clk/clk_sandbox.c | 2 +- drivers/clk/tegra/tegra-car-clk.c | 2 +- include/clk-uclass.h

[PATCH 1/8] malloc: implement USE_DL_PREFIX via inline functions

2020-02-19 Thread Simon Goldschmidt
etter solution is to define the allocation functions as 'static inline'. As a side effect, exports.h must not export malloc/free for sandbox. Signed-off-by: Simon Goldschmidt --- A side-effect is that exports.h may not declare malloc/free. I'm not really sure if this is correct, but

[PATCH 0/8] malloc: implement USE_DL_PREFIX using inline functions

2020-02-19 Thread Simon Goldschmidt
etter solution is to define the allocation functions as 'static inline'. This should go in before the release, as it's a regression not seen before the last release. A side-effect is that exports.h may not declare malloc/free. I'm not really sure if this is correct, but for sa

Re: [PATCH v4 0/5] usb: host: dwc2: use driver model for PHY and CLOCK

2020-02-18 Thread Simon Goldschmidt
On Tue, Feb 18, 2020 at 6:53 PM Marek Vasut wrote: > > On 2/18/20 9:34 AM, Patrick Delaunay wrote: > > > > In this serie I update the DWC2 host driver to use the device tree > > information and the associated PHY and CLOCK drivers when they are > > availables. > > > > The V4 is rebased on latest m

Re: [PATCH V2 1/2] ARM: socfpga: Permit overriding the default timer frequency

2020-02-17 Thread Simon Goldschmidt
> Signed-off-by: Marek Vasut > Cc: Ley Foon Tan > Cc: Simon Goldschmidt Reviewed-by: Simon Goldschmidt > --- > V2: Drop misleading comment > --- > include/configs/socfpga_common.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/

Re: [PATCH 1/2] ARM: socfpga: Permit overriding the default timer frequency

2020-02-17 Thread Simon Goldschmidt
On Sat, Feb 15, 2020 at 10:40 PM Marek Vasut wrote: > > On 2/15/20 8:39 PM, Simon Goldschmidt wrote: > > Am 15.02.2020 um 15:02 schrieb Marek Vasut: > >> The default timer rate may be different than 25 MHz, permit overriding > >> the default rate in board configu

Re: [PATCH 1/2] ARM: socfpga: Permit overriding the default timer frequency

2020-02-15 Thread Simon Goldschmidt
yes, I still haven't found the time to fight those size problems I have... :-( > > Signed-off-by: Marek Vasut > Cc: Ley Foon Tan > Cc: Simon Goldschmidt > --- > include/configs/socfpga_common.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/c

Re: [PATCH 10/33] mtd: Rename free() to rfree()

2020-02-13 Thread Simon Goldschmidt
On Wed, Feb 12, 2020 at 6:14 PM Simon Glass wrote: > > Hi Masahiro, > > On Wed, 12 Feb 2020 at 06:14, Masahiro Yamada wrote: > > > > On Mon, Jan 13, 2020 at 4:08 AM Simon Glass wrote: > > > > > > This function name conflicts with our desire to #define free() to > > > something else on sandbox. S

Re: [PATCH v5 00/20] Refactor the architecture parts of mt7628

2020-02-13 Thread Simon Goldschmidt
On Thu, Feb 13, 2020 at 9:42 AM Weijie Gao wrote: > > On Thu, 2020-02-13 at 08:48 +0100, Simon Goldschmidt wrote: > > On Wed, Feb 12, 2020 at 10:43 AM Weijie Gao wrote: > > > > > > This patch series are divided into two parts: > > > > > > The mai

Re: [PATCH v4 17/20] spl: nor: add lzma decompression support for legacy image

2020-02-13 Thread Simon Goldschmidt
On Thu, Feb 13, 2020 at 8:53 AM Stefan wrote: > > Hi Simon, > > On 13.02.20 08:40, Simon Goldschmidt wrote: > > Sorry if it seems I ignored this mail yesterday, I just found it now :) > > > > On Wed, Feb 12, 2020 at 10:05 AM Stefan Roese wrote: > >> &

Re: [PATCH v5 17/20] spl: nor: add lzma decompression support for legacy image

2020-02-12 Thread Simon Goldschmidt
On Wed, Feb 12, 2020 at 10:46 AM Weijie Gao wrote: > > This patch adds support for decompressing LZMA compressed u-boot payload in > legacy uImage format. > > Using this patch together with u-boot-lzma.img is useful for NOR flashes as > they can reduce the size and load time of u-boot payload. > >

Re: [PATCH v5 00/20] Refactor the architecture parts of mt7628

2020-02-12 Thread Simon Goldschmidt
On Wed, Feb 12, 2020 at 10:43 AM Weijie Gao wrote: > > This patch series are divided into two parts: > > The main part is to rewrite the whole architecture code of mt7628: > * Lock parts of the d-cache for initial stack so the rest of the code can > be reimplemented in C. > * Memory controller &

Re: [PATCH v4 17/20] spl: nor: add lzma decompression support for legacy image

2020-02-12 Thread Simon Goldschmidt
On Thu, Feb 13, 2020 at 3:53 AM Weijie Gao wrote: > > On Wed, 2020-02-12 at 11:18 +0100, Simon Goldschmidt wrote: > > On Wed, Feb 12, 2020 at 9:57 AM Weijie Gao wrote: > > > > > > On Wed, 2020-02-12 at 09:22 +0100, Simon Goldschmidt wrote: > > > >

Re: [PATCH v4 17/20] spl: nor: add lzma decompression support for legacy image

2020-02-12 Thread Simon Goldschmidt
Sorry if it seems I ignored this mail yesterday, I just found it now :) On Wed, Feb 12, 2020 at 10:05 AM Stefan Roese wrote: > > On 12.02.20 09:57, Weijie Gao wrote: > > > > >> And more general: why do we need to code this in every loader? I think it > >> would > >> be preferrable to have the l

Re: [PATCH v4 17/20] spl: nor: add lzma decompression support for legacy image

2020-02-12 Thread Simon Goldschmidt
On Wed, Feb 12, 2020 at 9:57 AM Weijie Gao wrote: > > On Wed, 2020-02-12 at 09:22 +0100, Simon Goldschmidt wrote: > > On Wed, Feb 12, 2020 at 8:49 AM Weijie Gao wrote: > > > > > > This patch adds support for decompressing LZMA compressed u-boot payload >

Re: [PATCH v4 17/20] spl: nor: add lzma decompression support for legacy image

2020-02-12 Thread Simon Goldschmidt
On Wed, Feb 12, 2020 at 8:49 AM Weijie Gao wrote: > > This patch adds support for decompressing LZMA compressed u-boot payload in > legacy uImage format. > > Using this patch together with u-boot-lzma.img is useful for NOR flashes as > they can reduce the size and load time of u-boot payload. > >

Re: [PATCH v2 06/10] mmc: am654_sdhci: Implement workaround for card detect

2020-02-10 Thread Simon Goldschmidt
+Simon Glass for the xxx_get_ops() functions in DM On Mon, Feb 10, 2020 at 10:46 AM Faiz Abbas wrote: > > Simon, > > On 29/01/20 7:48 pm, Simon Goldschmidt wrote: > > On Fri, Jan 24, 2020 at 12:52 PM Faiz Abbas wrote: > >> > >> The 4 bit MMC controllers ha

Re: [U-Boot] [PATCH] ARM: socfpga: Remove socfpga_sdram_apply_static_cfg()

2020-02-07 Thread Simon Goldschmidt
On Fri, Feb 7, 2020 at 1:27 PM Marek Vasut wrote: > > On 2/7/20 1:09 PM, Simon Goldschmidt wrote: > > On Fri, Feb 7, 2020 at 8:56 AM Marek Vasut wrote: > >> > >> On 2/6/20 3:57 PM, Simon Goldschmidt wrote: > >>> On Thu, Feb 6, 2020 at 3:41 PM N

Re: [U-Boot] [PATCH] ARM: socfpga: Remove socfpga_sdram_apply_static_cfg()

2020-02-07 Thread Simon Goldschmidt
On Fri, Feb 7, 2020 at 8:56 AM Marek Vasut wrote: > > On 2/6/20 3:57 PM, Simon Goldschmidt wrote: > > On Thu, Feb 6, 2020 at 3:41 PM Nico Becker > > wrote: > >> > >> Am 06.02.2020 um 14:00 schrieb Marek Vasut: > >>> On 2/6/20 1:57 PM, Nico Bec

Re: [U-Boot] [PATCH] ARM: socfpga: Remove socfpga_sdram_apply_static_cfg()

2020-02-06 Thread Simon Goldschmidt
On Thu, Feb 6, 2020 at 3:41 PM Nico Becker wrote: > > Am 06.02.2020 um 14:00 schrieb Marek Vasut: > > On 2/6/20 1:57 PM, Nico Becker wrote: > >> Am 06.02.2020 um 12:53 schrieb Marek Vasut: > >>> On 2/6/20 11:50 AM, Nico Becker wrote: > Hello, > >>> > >>> Hi, > >>> > after removing the fu

Re: [PATCH v2 04/10] mmc: sdhci: Expose sdhci_init() as non-static

2020-01-30 Thread Simon Goldschmidt
Am 30.01.2020 um 23:21 schrieb Jaehoon Chung: Hi Simon, On 1/29/20 11:16 PM, Simon Goldschmidt wrote: On Wed, Jan 29, 2020 at 12:00 AM Jaehoon Chung wrote: On 1/24/20 8:52 PM, Faiz Abbas wrote: Expose sdhci_init() as non-static. Does it need to change to non-static? And even if it

Re: [U-Boot] [PATCH v2 2/3] env: Tidy up some of the env code

2020-01-30 Thread Simon Goldschmidt
Am 30.01.2020 um 21:33 schrieb Wolfgang Denk: Dear James, In message <0102016eac3ac1a7-8a163dd4-aa1a-4331-a266-e9f461a07db8-000...@eu-west-1.amazonses.com> you wrote: As I said in my commit log comment, there are two key arguments against this: - The fact that the 'data' member of 'struct e

Re: [PATCH v2 02/10] mmc: Add init() API

2020-01-30 Thread Simon Goldschmidt
n 30. 01. 20 16:03, Faiz Abbas wrote: > > >>> Hi, > > >>> > > >>> +Lokesh, Tom > > >>> > > >>> On 29/01/20 1:37 pm, Simon Goldschmidt wrote: > > >>>> Forgot to ask: why isn't the subsystem maintainer on CC? > >

Re: [PATCH v2 02/10] mmc: Add init() API

2020-01-30 Thread Simon Goldschmidt
Faiz Abbas schrieb am Do., 30. Jan. 2020, 16:01: > Hi, > > +Lokesh, Tom > > On 29/01/20 1:37 pm, Simon Goldschmidt wrote: > > Forgot to ask: why isn't the subsystem maintainer on CC? > > If you would use patman to send patches or at least the get_maintainer

Re: [PATCH v2 3/4] mtd: rawnand: denali_dt: use UCLASS_MTD instead of UCLASS_MISC

2020-01-29 Thread Simon Goldschmidt
Am 29.01.2020 um 16:55 schrieb Masahiro Yamada: UCLASS_MTD is a better fit for NAND drivers. Make NAND_DENALI_DT depend on DM_MTD, which is needed to compile drivers/mtd/mtd-uclass.c Also, make ARCH_SOCFPGA and ARCH_UNIPHIER select DM_MTD because they use this driver. Signed-off-by: Masahiro Y

Re: [PATCH v2 06/10] mmc: am654_sdhci: Implement workaround for card detect

2020-01-29 Thread Simon Goldschmidt
On Fri, Jan 24, 2020 at 12:52 PM Faiz Abbas wrote: > > The 4 bit MMC controllers have an internal debounce for the SDCD line > with a debounce delay of 1 second. Therefore, after clocks to the IP are > enabled, software has to wait for this time before it can power on the > controller. > > Add an

Re: [PATCH v2 04/10] mmc: sdhci: Expose sdhci_init() as non-static

2020-01-29 Thread Simon Goldschmidt
On Wed, Jan 29, 2020 at 12:00 AM Jaehoon Chung wrote: > > On 1/24/20 8:52 PM, Faiz Abbas wrote: > > Expose sdhci_init() as non-static. > > Does it need to change to non-static? And even if it needs to, can we have a reason *why* in the commit message? Thanks, Simon > > Best Regards, > Jaehoon C

Re: [PATCH v2 02/10] mmc: Add init() API

2020-01-29 Thread Simon Goldschmidt
Forgot to ask: why isn't the subsystem maintainer on CC? If you would use patman to send patches or at least the get_maintainer script, he would have been... Regards, Simon On Wed, Jan 29, 2020 at 9:03 AM Simon Goldschmidt wrote: > > On Fri, Jan 24, 2020 at 12:52 PM Faiz A

Re: [PATCH v2 02/10] mmc: Add init() API

2020-01-29 Thread Simon Goldschmidt
On Fri, Jan 24, 2020 at 12:52 PM Faiz Abbas wrote: > > Add an init() API for platform specific init() operations. Could you describe why this cannot be done in the probe callback? It's not easily visible as the function you changed (mmc_get_op_cond) doesn't even have a comment to describe what it

Re: [GIT PULL] TI changes for 2020.04-rc1

2020-01-28 Thread Simon Goldschmidt
On Wed, Jan 29, 2020 at 8:48 AM Lokesh Vutla wrote: > > Hi Simon, > > On 29/01/20 12:40 PM, Simon Goldschmidt wrote: > > On Wed, Jan 29, 2020 at 6:00 AM Lokesh Vutla wrote: > >> > >> Hi Tom, > >> > >> Please find the pull request for v2020.

Re: [GIT PULL] TI changes for 2020.04-rc1

2020-01-28 Thread Simon Goldschmidt
On Wed, Jan 29, 2020 at 6:00 AM Lokesh Vutla wrote: > > Hi Tom, > > Please find the pull request for v2020.04-rc1 containing TI specific changes. > This PR brings in multiple features and should have sent before rc1 is > tagged. Due to multiple reviews, this is being sent a bit late. For > detaile

Re: [RFC] azure: Move to vs2017-win2016 platform build host

2020-01-27 Thread Simon Goldschmidt
Tom Rini schrieb am Mo., 27. Jan. 2020, 22:23: > Azure is moving to remove the vs2015-win2012r2 platform build host. The > two suggested new platforms to use are vs2017-win2016 and windows-2019. > For now, move up to vs2017-win2016. > > Cc: Bin Meng > Signed-off-by: Tom Rini > --- > I'm sendin

Re: [PATCH] common: fix regression on block cache init

2020-01-27 Thread Simon Goldschmidt
On Sun, Jan 26, 2020 at 7:30 PM Angelo Dureghello wrote: > > From: Angelo Durgehello > > m68k needs block cache list initialized after relocation. > Other architectures must not be involved. > > Fixing regression related to: > > commit 1526bcce0f7285087621e16e6720636d01839da8 > ("common:

Re: [PATCHv3] cmd/gpt: Address error cases during gpt rename more correctly

2020-01-21 Thread Simon Goldschmidt
could happen. Rework the unwinding such that we don't need a helper > function now and free what we may have allocated. > > Fixes: 18030d04d25d ("GPT: fix memory leaks identified by Coverity") > Reported-by: Coverity (CID: 275475, 275476) > Cc: Alison Chaiken > Cc:

Re: [PATCHv2] cmd/gpt: Address error cases during gpt rename more correctly

2020-01-20 Thread Simon Goldschmidt
could happen. Rework the unwinding such that we don't need a helper > function now and free what we may have allocated. > > Fixes: 18030d04d25d ("GPT: fix memory leaks identified by Coverity") > Reported-by: Coverity (CID: 275475, 275476) > Cc: Alison Chaiken > Cc:

Re: Double free vulnerability in do_rename_gpt_parts

2020-01-17 Thread Simon Goldschmidt
Am 17.01.2020 um 17:31 schrieb Tom Rini: On Fri, Jan 17, 2020 at 04:29:52PM +0100, Simon Goldschmidt wrote: + Some contributors of this file On Fri, Jan 17, 2020 at 1:03 PM Jordy wrote: Hello U-Boot lists! I think I found a double free bug in U-Boot, in /cmp/gpt.c in the function

Re: [U-Boot] [PATCH] cmd/gpt: Address error cases during gpt rename more correctly

2020-01-17 Thread Simon Goldschmidt
+ Jordy, who just found a bug here... Am 08.11.2019 um 17:24 schrieb Tom Rini: New analysis by the tool has shown that we have some cases where we weren't handling the error exit condition correctly. When we ran into the ENOMEM case we wouldn't exit the function and thus incorrect things could

  1   2   3   4   5   6   7   8   9   10   >