Re: [U-Boot] [EXT] Re: [PATCH 1/6] spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms

2019-10-23 Thread Stefan Roese
On 23.10.19 12:34, Schrempf Frieder wrote: BTW: Using the "spi-mem" driver version from Ashish with the fix suggested by Frieder to clear the DDR bit in TDH (reset to 00) still works without any problems. There is some cleanup work that needs to be done (e.g. [1]). After that I will send an

Re: [U-Boot] [PATCH] ARM: mvebu: don't dereference null bd pointer

2019-10-23 Thread Stefan Roese
On 23.10.19 09:48, Chris Packham wrote: On Wed, Oct 23, 2019 at 1:15 AM Stefan Roese wrote: Hi Chris, On 22.10.19 09:05, Chris Packham wrote: As mentioned in doc/README.arm-relocation gd->bd is not available in dram_init() so we shouldn't attempt to access it. Signed-off-by: Chris Pack

Re: [U-Boot] [PATCH 3/3] mtd: spi: Clean up usage of CONFIG_SPI_FLASH_MTD

2019-10-23 Thread Stefan Roese
def CONFIG_SPI_FLASH_MTD and #if CONFIG_IS_ENABLED(SPI_FLASH_MTD) is the same This is not correct. CONFIG_IS_ENABLED(SPI_FLASH_MTD) also handles CONFIG_SPL_SPI_FLASH_MTD & CONFIG_TPL_SPI_FLASH_MTD. Reviewed-by: Stefan Roese Thanks, Stefan ___ U-Boot

Re: [U-Boot] [PATCH v2 3/6] arm: dts: k3-j721e-mcu-wakeup: Add HyperBus Controller node

2019-10-22 Thread Stefan Roese
Hi Vignesh, On 10.10.19 07:52, Vignesh Raghavendra wrote: Add DT node for HyperBus Memory Controller in the FSS. On J721e, its not possible to use OSPI0 and HBMC simultaneously as they are muxed within the Flash Subsystem hence disable HBMC by default as keep OSPI enabled. Bootloader will fixup

Re: [U-Boot] [EXT] Re: [PATCH 1/6] spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms

2019-10-22 Thread Stefan Roese
Hi Frieder, On 22.10.19 16:24, Schrempf Frieder wrote: On 22.10.19 15:55, Frieder Schrempf wrote: Hi Stefan, On 22.10.19 15:18, Stefan Roese wrote: Hi Frieder, Hi Ashish, Hi Ye Li, Hi Fabio, On 18.09.19 09:42, Stefan Roese wrote: Hi Frieder, On 18.09.19 09:08, Schrempf Frieder wrote

Re: [U-Boot] [EXT] Re: [PATCH 1/6] spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms

2019-10-22 Thread Stefan Roese
Hi Frieder, On 22.10.19 15:55, Schrempf Frieder wrote: Hi Stefan, On 22.10.19 15:18, Stefan Roese wrote: Hi Frieder, Hi Ashish, Hi Ye Li, Hi Fabio, On 18.09.19 09:42, Stefan Roese wrote: Hi Frieder, On 18.09.19 09:08, Schrempf Frieder wrote: One further update on this QSPI driver

Re: [U-Boot] [EXT] Re: [PATCH 1/6] spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms

2019-10-22 Thread Stefan Roese
Hi Frieder, Hi Ashish, Hi Ye Li, Hi Fabio, On 18.09.19 09:42, Stefan Roese wrote: Hi Frieder, On 18.09.19 09:08, Schrempf Frieder wrote: One further update on this QSPI driver. This driver only works when loaded via "imx_usb" on the i.MX6ULL EVK. When programmed into QSPI and b

Re: [U-Boot] [PATCH v2 02/10] tiny-printf: Add print_grouped_ull()

2019-10-22 Thread Stefan Roese
char *fmt, ...) return ret; } + +void print_grouped_ull(unsigned long long int_val, int digits) +{ + /* Don't try to ptint the upper 32-bits */ s/ptint/print ? + printf("%ld ", (ulong)int_val); +} Other than that: Reviewed-by: Stefan Roese Than

Re: [U-Boot] [PATCH] ARM: mvebu: don't dereference null bd pointer

2019-10-22 Thread Stefan Roese
Hi Chris, On 22.10.19 09:05, Chris Packham wrote: As mentioned in doc/README.arm-relocation gd->bd is not available in dram_init() so we shouldn't attempt to access it. Signed-off-by: Chris Packham --- arch/arm/mach-mvebu/dram.c | 10 -- 1 file changed, 10 deletions(-) diff --git

Re: [U-Boot] [PATCH] MIPS: remove Micronas VCT boards

2019-10-21 Thread Stefan Roese
should be scheduled for removal. Signed-off-by: Daniel Schwierzeck It makes me a little bit sad to see this board / platform being removed. But I also don't see any active users any more, so: Acked-by: Stefan Roese Thanks, Stefan ___ U-Boot mailing list

Re: [U-Boot] [PATCH v2 2/6] mtd: Add TI HyperBus Memory Controller driver

2019-10-10 Thread Stefan Roese
access and probes HyperFlash child node. Signed-off-by: Vignesh Raghavendra --- v2: No change Reviewed-by: Stefan Roese Thanks, Stefan ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 1/6] mtd: cfi_flash: Use CONFIG_SYS_MONITOR_BASE only when defined

2019-10-10 Thread Stefan Roese
On 10.10.19 07:52, Vignesh Raghavendra wrote: Make use of CONFIG_SYS_MONITOR_BASE only when available to avoid build error when CONFIG_SYS_MONITOR_BASE is not defined. Signed-off-by: Vignesh Raghavendra --- v2: Make macro check consistent as pointed out by Stefan Reviewed-by: Stefan Roese

Re: [U-Boot] [PATCH 1/6] mtd: cfi_flash: Use CONFIG_SYS_MONITOR_BASE only when defined

2019-10-09 Thread Stefan Roese
Hi Vignesh, sorry for the late review. On 10.09.19 07:10, Vignesh Raghavendra wrote: Make use of CONFIG_SYS_MONITOR_BASE only when available to avoid build error when CONFIG_SYS_MONITOR_BASE is not defined. Signed-off-by: Vignesh Raghavendra --- drivers/mtd/cfi_flash.c | 5 - 1 file

[U-Boot] Please pull u-boot-marvell/master (watchdog related)

2019-10-08 Thread Stefan Roese
Hi Tom, please pull the following watchdog related patches: - Move WATCHDOG_TIMEOUT_MSECS to Kconfig (Heiko) Here the Travis build, without any issues:

Re: [U-Boot] [PATCH v2] watchdog: move WATCHDOG_TIMEOUT_MSECS to Kconfig

2019-10-08 Thread Stefan Roese
On 30.09.19 09:33, Heiko Schocher wrote: move WATCHDOG_TIMEOUT_MSECS to Kconfig and fix all board defconfigs. Signed-off-by: Heiko Schocher Reviewed-by: Stefan Roese Acked-by: Lukasz Majewski Acked-by: Martyn Welch --- Patchseries build fine on travis see: https://travis-ci.org/hsdenx/u

[U-Boot] [PATCH] net: phy: Increase link up delay in genphy_update_link()

2019-09-30 Thread Stefan Roese
register read fixes this issue, resulting in a stable ethernet traffic, even after initial link autonogotiation. Signed-off-by: Stefan Roese Cc: Weijie Gao Cc: Joe Hershberger --- drivers/net/phy/phy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/phy.c b

Re: [U-Boot] [PATCH v3 00/28] Add and update drivers for MediaTek MT76x8 SoCs

2019-09-30 Thread Stefan Roese
sted-by for the Gardena boards ;) Okay, here we go (for the whole series): Reviewed-by: Stefan Roese Tested-by: Stefan Roese Thanks, Stefan ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [EXT] Re: [RFC 1/3] scsi: ata: Add DM SCSI interface to support None AHCI sata driver

2019-09-29 Thread Stefan Roese
Hi Peng, On 30.09.19 04:42, Peng Ma wrote: Hi Stefan, Thanks for your opinion. -Original Message- From: Stefan Roese Sent: 2019年9月29日 19:46 To: Peng Ma ; s...@chromium.org; Prabhakar X ; ja...@openedev.com; bmeng...@gmail.com; Andy Tang Cc: michal.si...@xilinx.com; andre.przyw

Re: [U-Boot] [RFC 1/3] scsi: ata: Add DM SCSI interface to support None AHCI sata driver

2019-09-29 Thread Stefan Roese
Hi Peng, On 25.09.19 11:54, Peng Ma wrote: In driver/ata. If the sata driver support AHCI mode, there will provides a complete set of SCSI interface. If the sata is not support AHCI mode(NONE_AHCI) there will not provides the SCSI interface. This patch is to support SCSI interface for None

Re: [U-Boot] [PATCH v3 00/28] Add and update drivers for MediaTek MT76x8 SoCs

2019-09-29 Thread Stefan Roese
Hi Daniel, On 25.09.19 13:09, Daniel Schwierzeck wrote: Am 25.09.19 um 11:45 schrieb Weijie Gao: This patch series have the following changes: - Add pinctrl(both pinmux and pinconf) driver, reset controller driver and clock driver for mt7628. - Add mt7628 platform to mtk-sd driver. -

[U-Boot] [PATCH 2/3] ARM: imx: arch/arm/mach-imx/spl_qspi.cfg

2019-09-20 Thread Stefan Roese
Similar to "spl_sd.cfg", this patch introduces "spl_qspi.cfg" so that all i.MX6 based boards can use it, when they use SPL and QSPI boot mode. Signed-off-by: Stefan Roese Cc: Fabio Estevam Cc: Stefano Babic --- arch/arm/mach-imx/spl_qspi.cfg | 17 +

[U-Boot] [PATCH 3/3] Kconfig: Set default BUILD_TARGET for ARCH_MX6 with SPL

2019-09-20 Thread Stefan Roese
Use BUILD_TARGET to automatically build "u-boot-with-spl.imx" on MX6 targets with SPL. Signed-off-by: Stefan Roese Cc: Fabio Estevam Cc: Stefano Babic --- Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/Kconfig b/Kconfig index 1f0904f704..66b059f749 100644 --- a/Kco

[U-Boot] [PATCH 1/3] ARM: imx: Add QSPI boot mode for i.MX6UL/ULL

2019-09-20 Thread Stefan Roese
This patch adds the missing boot mode detection for QSPI boot on i.MX6UL/ULL. Without it, booting with SPL from QSPI NOR does not work. Signed-off-by: Stefan Roese Cc: Fabio Estevam Cc: Stefano Babic --- arch/arm/mach-imx/spl.c | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm

Re: [U-Boot] [PATCH] cmd: mtd: solve bad block support in erase command

2019-09-20 Thread Stefan Roese
Hi Patrick, On 20.09.19 09:20, Patrick Delaunay wrote: This patch modify the loop in mtd erase command to erase one by one the blocks in the requested area. It solves issue on "mtd erase" command on nand with existing bad block, the command is interrupted on the first bad block with the trace:

Re: [U-Boot] [PATCH 2/6] spl: spi: introduce spl_spi_get_uboot_raw_sector

2019-09-20 Thread Stefan Roese
Hi Peng, On 20.09.19 05:27, Peng Fan wrote: Introduce a weak function spl_spi_get_uboot_raw_sector, then platform could have their own implementation. Signed-off-by: Peng Fan Cc: Simon Goldschmidt Cc: Tien Fong Chee Cc: Marek Vasut Cc: Andreas Dannenberg Cc: Alex Kiernan Cc: Stefan Roese

Re: [U-Boot] [PATCH v3 0/3] env: Add CONFIG_ENV_FULL_SUPPORT

2019-09-20 Thread Stefan Roese
Hi Patrick, On 18.09.19 11:29, Patrick Delaunay wrote: This patchset is a the 3rd version of http://patchwork.ozlabs.org/project/uboot/list/?series=129339 "env: Add CONFIG_ENV_SUPPORT" The first patch of the serie only solves the regression introduced by commit 7d4776545b0f ("env: solve

Re: [U-Boot] Question about device tree usage and ranges

2019-09-19 Thread Stefan Roese
Hi Aaron, On 19.09.19 13:35, Aaron Williams wrote: Hi, In my device tree I need to translate some address via ranges but I'm running into some issues. If I use ofnode_get_addr_size() it is not using the #address-cells and #size-cells nor is it performing the ranges translation. It always

Re: [U-Boot] [EXT] Re: [PATCH 1/6] spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms

2019-09-18 Thread Stefan Roese
Hi Frieder, On 18.09.19 09:08, Schrempf Frieder wrote: One further update on this QSPI driver. This driver only works when loaded via "imx_usb" on the i.MX6ULL EVK. When programmed into QSPI and booted from QSPI this driver does not detect the SPI NOR flash: => sf probe unrecognized JEDEC

Re: [U-Boot] [EXT] Re: [PATCH 1/6] spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms

2019-09-17 Thread Stefan Roese
Hi Ashish, On 13.09.19 15:11, Stefan Roese wrote: On 12.09.19 14:36, Stefan Roese wrote: The spi-mem version is still under debug, I could make it working for ls1088rdb, ls1046rdb, but it is failing for ls1012ardb and ls2088ardb and untested for i.mx and other Layerscape silicon/boards

[U-Boot] [PATCH v2 3/3] ubi: Add "skipcheck" command to set/clear this bit in the UBI volume hdr

2019-09-17 Thread Stefan Roese
ed target with 128MiB of SPI NAND. Signed-off-by: Stefan Roese Reviewed-by: Heiko Schocher Cc: Quentin Schulz Cc: Boris Brezillon Cc: Heiko Schocher Cc: Andreas Dannenberg --- v2: - Add documentation to doc/README.ubi as suggested by Andreas cmd/ubi.c | 34 ++

Re: [U-Boot] [PATCH 3/3] ubi: Add "skipcheck" command to set/clear this bit in the UBI volume hdr

2019-09-16 Thread Stefan Roese
Hi Heiko, On 17.09.19 07:45, Heiko Schocher wrote: Hello Stefan, Am 12.09.2019 um 16:41 schrieb Stefan Roese: U-Boot now supports the "skip_check" flag to optionally skip the CRC check at open time. Currently its only possible to set this bit upon UBI volume creation. But it mig

Re: [U-Boot] U-Boot on ppc405gp, slow ethernet

2019-09-16 Thread Stefan Roese
Hi Carlo, On 16.09.19 02:06, Carlo Pisani wrote: hi I am trying to use the board "dht-walnut", and I get this on the attempt to tftpboot PHY speed read failed, assuming 10bT PHY duplex read failed, assuming half-duplex Using ppc_4xx_eth0 device The ppc405GP board is connected to a router

Re: [U-Boot] [PATCH 3/3] mtd: spi: Clean up usage of CONFIG_SPI_FLASH_MTD

2019-09-16 Thread Stefan Roese
Reviewed-by: Stefan Roese Thanks, Stefan ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] arm: at91: gardena-smart-gateway-at91sam: Enable CONFIG_SYS_NAND_USE_FLASH_BBT

2019-09-13 Thread Stefan Roese
Hi Alex, On 13.09.19 15:09, Alexander Dahl wrote: Am Dienstag, 27. August 2019, 08:14:50 CEST schrieb Stefan Roese: This patch enables the BBT in NAND on the AT91SAM based GARDENA smart Gateway. This is especially important, since the Linux driver also enables this option and uses the BBT

Re: [U-Boot] [EXT] Re: [PATCH 1/6] spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms

2019-09-13 Thread Stefan Roese
Hi Ashish, On 12.09.19 14:36, Stefan Roese wrote: The spi-mem version is still under debug, I could make it working for ls1088rdb, ls1046rdb, but it is failing for ls1012ardb and ls2088ardb and untested for i.mx and other Layerscape silicon/boards . It is derived from work done by Frieder

Re: [U-Boot] OMAP watchdog timer reset on BBB

2019-09-13 Thread Stefan Roese
Hi Sam, On 12.09.19 18:33, Sam Protsenko wrote: Hi Stefan, On Thu, Sep 12, 2019 at 5:38 PM Stefan Roese wrote: Hi Sam, On 12.09.19 15:45, Sam Protsenko wrote: Hi Suniel, After transition to DM WDT, watchdog timer on BeagleBone Black resets the board after 1 minute or so. I'm using

[U-Boot] [PATCH 3/3] ubi: Add "skipcheck" command to set/clear this bit in the UBI volume hdr

2019-09-12 Thread Stefan Roese
ed target with 128MiB of SPI NAND. Signed-off-by: Stefan Roese Cc: Quentin Schulz Cc: Boris Brezillon Cc: Heiko Schocher --- cmd/ubi.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/cmd/ubi.c b/cmd/ubi.c index c857f07d93..42b5641b32 100644 --- a/cmd/ubi.c

[U-Boot] [PATCH 2/3] ubi: Print skip_check in ubi_dump_vol_info()

2019-09-12 Thread Stefan Roese
It might be interesting, if "skip_check" is set of not, so lets print this flag in ubi_dump_vol_info() as well. Signed-off-by: Stefan Roese Cc: Quentin Schulz Cc: Boris Brezillon Cc: Heiko Schocher --- drivers/mtd/ubi/debug.c | 1 + 1 file changed, 1 insertion(+) diff --git a/d

[U-Boot] [PATCH 1/3] ubi: provide a way to skip CRC checks

2019-09-12 Thread Stefan Roese
of the block device but this time at the block granularity instead of verifying the whole volume. Skipping this test drastically improves the boot-time. Adapted to U-Boot by Stefan Roese. Signed-off-by: Quentin Schulz Signed-off-by: Stefan Roese Cc: Quentin Schulz Cc: Boris Brezillon Cc: Heiko Schocher

Re: [U-Boot] OMAP watchdog timer reset on BBB

2019-09-12 Thread Stefan Roese
Hi Sam, On 12.09.19 15:45, Sam Protsenko wrote: Hi Suniel, After transition to DM WDT, watchdog timer on BeagleBone Black resets the board after 1 minute or so. I'm using this defconfig: [1]. After disabling CONFIG_WDT and CONFIG_WATCHDOG options the board doesn't reset. I guess it might be

Re: [U-Boot] [EXT] Re: [PATCH 1/6] spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms

2019-09-12 Thread Stefan Roese
Hi Ashish, On 12.09.19 07:03, Ashish Kumar wrote: Please suggest way forward. How to correct this issue? The first thigh would be to make sure the Linux driver works for all platforms and then do the porting to U-Boot. I will be out of office for 10 days. After that I can try to work on

Re: [U-Boot] [PATCH] arm: at91: gardena-smart-gateway-at91sam: Enable CONFIG_SYS_NAND_USE_FLASH_BBT

2019-09-12 Thread Stefan Roese
to re-use these pages again (e.g. UBI). Signed-off-by: Stefan Roese Cc: Eugen Hristev Cc: Tom Rini --- Eugen, I would advise you to double-check, if your AT91 based boards using NAND also have this BBT option enabled in Linux. If yes, its definitely necessary to enable it in U-Boot as well

Re: [U-Boot] [PATCH] arm: at91: gardena-smart-gateway-at91sam: Enable CONFIG_SYS_NAND_USE_FLASH_BBT

2019-09-11 Thread Stefan Roese
Hi Eugen, On 27.08.19 09:54, eugen.hris...@microchip.com wrote: On 27.08.2019 09:14, Stefan Roese wrote: This patch enables the BBT in NAND on the AT91SAM based GARDENA smart Gateway. This is especially important, since the Linux driver also enables this option and uses the BBT table pages

Re: [U-Boot] [EXT] Re: [PATCH 1/6] spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms

2019-09-10 Thread Stefan Roese
Hi Ashish, Hi Frieder, On 09.09.19 10:10, Schrempf Frieder wrote: Hi Ashish, On 27.08.19 11:56, Ashish Kumar wrote: -Original Message- From: Schrempf Frieder Sent: Wednesday, August 14, 2019 5:41 PM To: Ashish Kumar ; Ye Li ; ja...@amarulasolutions.com Cc: Fabio Estevam ;

Re: [U-Boot] [PATCH v2 5/5] imx: add i.MX6ULZ board

2019-09-10 Thread Stefan Roese
Hi Peng, Hi Fabio, On 06.09.19 09:43, Peng Fan wrote: Subject: Re: [U-Boot] [PATCH v2 5/5] imx: add i.MX6ULZ board Hi Stefan, On Thu, Sep 5, 2019 at 5:59 AM Stefan Roese wrote: a) Why is SPL not used in the mainline i.MX6ULL/ULZ port? The i.MX6UL (14x14) does use SPL. Yes, I think

Re: [U-Boot] [PATCH v2 5/5] imx: add i.MX6ULZ board

2019-09-05 Thread Stefan Roese
Hi Peng, Hi Fabio, On 08.08.19 11:55, Peng Fan wrote: Add i.MX6ULZ board support. the i.MX6ULZ is SW compatible with i.MX6ULL. so most code of i.MX6ULL can be reused by i.MX6ULZ. Signed-off-by: Peng Fan --- V2: Add entry in MAINTAINERS arch/arm/dts/imx6ulz-14x14-evk.dts| 22

Re: [U-Boot] [PATCH 25/26] configs: mtmips: change all boards to use mtk high-speed uart driver

2019-08-28 Thread Stefan Roese
On 28.08.19 08:38, Weijie Gao wrote: This patch changes all defconfig files of mtmips to use mtk high-speed uart driver. This driver is compatible with ns16550a when baudrate <= 115200. Signed-off-by: Weijie Gao As already suggested by Daniel, please move this change into a Kconfig "select"

Re: [U-Boot] [PATCH 24/26] dts: mtmips: add default pinctrl to eth nodes for all boards

2019-08-28 Thread Stefan Roese
than one ports Signed-off-by: Weijie Gao Again my comment about staying in sync with the Linux DT bindings. It might be that case, that Linux is still missing some defines for the pinctrl (like this IOT one). Reviewed-by: Stefan Roese Thanks, Stefan --- arch/mips/dts/gardena-smart-gateway

Re: [U-Boot] [PATCH 23/26] dts: mtmips: add default pinctrl for gardena-smart-gateway-mt7688

2019-08-28 Thread Stefan Roese
with the Linux DT bindings here. Other than that: Reviewed-by: Stefan Roese Thanks, Stefan ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 20/26] mmc: mtk-sd: add support for MediaTek MT7620/MT7628 SoCs

2019-08-28 Thread Stefan Roese
On 28.08.19 08:38, Weijie Gao wrote: This patch adds mmc support for MediaTek MT7620/MT7628 SoCs. Signed-off-by: Weijie Gao --- drivers/mmc/Kconfig | 2 +- drivers/mmc/mtk-sd.c | 23 --- 2 files changed, 21 insertions(+), 4 deletions(-) diff --git

Re: [U-Boot] [PATCH 19/26] dts: mtmips: enable eth port0 led function for all boards

2019-08-28 Thread Stefan Roese
On 28.08.19 08:38, Weijie Gao wrote: This patch adds default p0led status for all boards. Signed-off-by: Weijie Gao Reviewed-by: Stefan Roese Thanks, Stefan ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 18/26] net: mt7628-eth: add support to isolate LAN/WAN ports

2019-08-28 Thread Stefan Roese
On 28.08.19 08:38, Weijie Gao wrote: This patch add support for mt7628-eth to isolate LAN/WAN ports mainly to Nitpicking: s/add/adds prevent LAN devices from getting IP address from WAN. Signed-off-by: Weijie Gao --- drivers/net/mt7628-eth.c | 32 1

Re: [U-Boot] [PATCH 17/26] net: mt7628-eth: free rx descriptor on receiving failure

2019-08-28 Thread Stefan Roese
. This patch adds a call to mt7628_eth_free_pkt() after received an invalid packet length. Signed-off-by: Weijie Gao Good catch. Reviewed-by: Stefan Roese Thanks, Stefan ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u

Re: [U-Boot] [PATCH 26/26] configs: mtmips: add necessary drivers for mtmips boards

2019-08-28 Thread Stefan Roese
On 28.08.19 15:35, Daniel Schwierzeck wrote: Am 28.08.19 um 08:38 schrieb Weijie Gao: This patch adds pinctrl driver, clock gate driver and reset controller support for defconfig files of mtmips boards. Signed-off-by: Weijie Gao --- configs/gardena-smart-gateway-mt7688_defconfig | 6

Re: [U-Boot] [PATCH 16/26] net: mt7628-eth: remove phy link up detection

2019-08-28 Thread Stefan Roese
On 28.08.19 08:38, Weijie Gao wrote: The mt7628 has an embedded ethernet switch (5 phy ports + 1 cpu port). Although in IOT mode only port0 is usable, the phy0 is still connected to the switch, not the ethernet gmac directly. This patch removes these codes as we should not check only the status

Re: [U-Boot] [PATCH 15/26] net: mt7628-eth: remove hardcoded gpio settings and regmap-based phy reset

2019-08-28 Thread Stefan Roese
+++- 1 file changed, 8 insertions(+), 37 deletions(-) Very nice diffstat with this patch. :) Reviewed-by: Stefan Roese Thanks, Stefan diff --git a/drivers/net/mt7628-eth.c b/drivers/net/mt7628-eth.c index 7833b2f47a..4675b0f003 100644 --- a/drivers/net/mt7628-eth.c +++ b/drivers

Re: [U-Boot] [PATCH 11/26] dts: mtmips: update reset controller node for mt7628

2019-08-28 Thread Stefan Roese
On 28.08.19 08:37, Weijie Gao wrote: This patch updates reset controller node for mt7628 Signed-off-by: Weijie Gao --- arch/mips/dts/mt7628a.dtsi | 36 1 file changed, 24 insertions(+), 12 deletions(-) diff --git a/arch/mips/dts/mt7628a.dtsi

Re: [U-Boot] [PATCH 07/26] pinctrl: add support for MediaTek MT7628

2019-08-28 Thread Stefan Roese
On 28.08.19 14:26, Stefan Roese wrote: On 28.08.19 08:37, Weijie Gao wrote: This patch adds pinctrl support for mt7628, with a file for common pinmux functions and a file for mt7628 which has additional support for pinconf. Signed-off-by: Weijie Gao --- drivers/pinctrl/Kconfig

Re: [U-Boot] [PATCH 07/26] pinctrl: add support for MediaTek MT7628

2019-08-28 Thread Stefan Roese
On 28.08.19 08:37, Weijie Gao wrote: This patch adds pinctrl support for mt7628, with a file for common pinmux functions and a file for mt7628 which has additional support for pinconf. Signed-off-by: Weijie Gao --- drivers/pinctrl/Kconfig | 1 +

Re: [U-Boot] [PATCH 06/26] spi: mt7621-spi: restore default register value after each xfer

2019-08-28 Thread Stefan Roese
ssumptions about prior register setup. So the driver you are referring to should configure all registers correctly for its setup. But I don't object to this patch, so if this is really needed for some of your customers, please go ahead: Reviewed-by: Stefan Roese Thanks, Stefan Signed-off-by:

Re: [U-Boot] [PATCH 05/26] spi: mt7621-spi: remove data cache and rewrite its xfer function

2019-08-28 Thread Stefan Roese
. But one thing different between OPADDR and DIDO registers is OPADDR has a reversed byte order. With this patch, any amount of data can be read/written in a single xfer function call. Signed-off-by: Weijie Gao Very nice, thanks for all your work here. Reviewed-by: Stefan Roese Thanks, Stefan

Re: [U-Boot] [PATCH 04/26] dts: mtmips: enable high-speed UART support for mt7628

2019-08-28 Thread Stefan Roese
ver is built in. Signed-off-by: Weijie Gao Reviewed-by: Stefan Roese Thanks, Stefan ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 03/26] dts: mtmips: move uart property clock-frequency into mt7628an.dtsi

2019-08-28 Thread Stefan Roese
On 28.08.19 08:37, Weijie Gao wrote: The UART of MT7628 has fixed 40MHz input clock so there is no need to put clock-frequency in every dts files. Just put it into the common dtsi file. Signed-off-by: Weijie Gao Reviewed-by: Stefan Roese Thanks, Stefan

[U-Boot] [PATCH] arm: at91: gardena-smart-gateway-at91sam: Enable CONFIG_SYS_NAND_USE_FLASH_BBT

2019-08-27 Thread Stefan Roese
This patch enables the BBT in NAND on the AT91SAM based GARDENA smart Gateway. This is especially important, since the Linux driver also enables this option and uses the BBT table pages. Without setting this option, U-Boot will try to re-use these pages again (e.g. UBI). Signed-off-by: Stefan

Re: [U-Boot] [PATCH v1] watchdog: move WATCHDOG_TIMEOUT_MSECS to Kconfig

2019-08-26 Thread Stefan Roese
Hi Heiko, On 12.06.19 10:22, Heiko Schocher wrote: move WATCHDOG_TIMEOUT_MSECS to Kconfig and fix all board defconfigs. Signed-off-by: Heiko Schocher --- Patchseries build fine on travis see: https://travis-ci.org/hsdenx/u-boot-test/builds/544546490 Based on mainline commit: 68b90e57bc:

[U-Boot] [PATCH] net: macb: Fix rx buffer cache handling

2019-08-26 Thread Stefan Roese
functions, as these also use this macro. This patch now fixes this by calculating the rx buffer size correctly again in those functions. With this change, ethernet works again reliably on my AT91SAM board. Signed-off-by: Stefan Roese Fixes: c6d07bf440bc ("net/macb: increase RX buffer si

[U-Boot] [PATCH v2] net: macb: Fix rx buffer cache handling

2019-08-23 Thread Stefan Roese
functions, as these also use this macro. This patch now fixes this by calculating the rx buffer size correctly again in those functions. With this change, ethernet works again reliably on my AT91SAM board. Signed-off-by: Stefan Roese Cc: Ramon Fried Cc: Eugen Hristev Cc: Anup Patel Cc: Bin Men

Re: [U-Boot] [PATCH] net: macb: Fix rx buffer cache handling

2019-08-23 Thread Stefan Roese
Hi Bin, On 23.08.19 11:22, Bin Meng wrote: On Fri, Aug 23, 2019 at 5:17 PM Bin Meng wrote: Hi Stefan, On Fri, Aug 23, 2019 at 5:02 PM Stefan Roese wrote: With commit c6d07bf440bc ("net/macb: increase RX buffer size for GEM") ethernet support does not work any more with d-cac

[U-Boot] [PATCH] net: macb: Fix rx buffer cache handling

2019-08-23 Thread Stefan Roese
functions, as these also use this macro. This patch now fixes this by calculating the rx buffer size correctly again in those functions. With this change, ethernet works again reliably on my AT91SAM board. Signed-off-by: Stefan Roese Cc: Ramon Fried Cc: Eugen Hristev Cc: Anup Patel Cc: Bin Men

Re: [U-Boot] [PATCH v2] net/macb: increase RX buffer size for GEM

2019-08-23 Thread Stefan Roese
On 23.08.19 07:54, Ramon Fried wrote: BTW: When I disable the dcache (dcache off), tftp also works fine with this patch. So its definitely something cache / dma related. Thanks for letting me know, I'll be next to a PC tomorrow, I'll look into it. I did look into this patch a bit and did

Re: [U-Boot] [PATCH v2] net/macb: increase RX buffer size for GEM

2019-08-22 Thread Stefan Roese
Hi Ramon, On 22.08.19 13:15, Ramon Fried wrote: On August 22, 2019 12:38:08 PM GMT+03:00, Stefan Roese wrote: Hi Ramon, On 14.07.19 17:25, Ramon Fried wrote: Macb Ethernet controller requires a RX buffer of 128 bytes. It is highly sub-optimal for Gigabit-capable GEM that is able to use

[U-Boot] [PATCH] mtd: nand: raw: Move CONFIG_SYS_NAND_USE_FLASH_BBT to Kconfig

2019-08-22 Thread Stefan Roese
with CONFIG_NAND_ATMEL will have BBT enabled. Which is what I also need on my GARDENA AT91SAM based board. Signed-off-by: Stefan Roese Cc: Eugen Hristev Cc: Miquel Raynal Cc: Gregory CLEMENT --- configs/colibri-imx6ull_defconfig| 1 + configs/da850evm_nand_defconfig | 1 + configs/db

Re: [U-Boot] [PATCH v2] net/macb: increase RX buffer size for GEM

2019-08-22 Thread Stefan Roese
Hi Ramon, On 14.07.19 17:25, Ramon Fried wrote: Macb Ethernet controller requires a RX buffer of 128 bytes. It is highly sub-optimal for Gigabit-capable GEM that is able to use a bigger DMA buffer. Change this constant and associated macros with data stored in the private structure. RX DMA

[U-Boot] [PATCH 1/2] x86: Remove x86 specific GD flags as they are not referenced at all

2019-08-16 Thread Stefan Roese
code. Signed-off-by: Stefan Roese Cc: Bin Meng Cc: Simon Glass Cc: Tom Rini Cc: Simon Goldschmidt --- arch/x86/cpu/coreboot/coreboot.c | 3 --- arch/x86/cpu/start.S | 9 + arch/x86/cpu/start16.S | 3 --- arch/x86/include/asm/global_data.h | 6 -- 4 f

[U-Boot] [PATCH 2/2] global_data: Remove comment of reserved arch-specific GD flags

2019-08-16 Thread Stefan Roese
using more than 16 bits for common GD flags (with the addition of GD_FLG_WDT_READY). Signed-off-by: Stefan Roese Cc: Bin Meng Cc: Simon Glass Cc: Tom Rini Cc: Simon Goldschmidt --- include/asm-generic/global_data.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include

Re: [U-Boot] [PATCH 1/4 v5] watchdog: Implement generic watchdog_reset() version

2019-08-15 Thread Stefan Roese
Hi Bin, On 15.08.19 16:19, Bin Meng wrote: Hi Stefan, On Thu, Aug 15, 2019 at 2:07 PM Stefan Roese wrote: Hi Simon, On 14.08.19 21:35, Simon Glass wrote: Hi, On Wed, 14 Aug 2019 at 00:22, Stefan Roese wrote: Hi Simon, (added Simon Glass and Bin to Cc) On 13.08.19 22:16, Simon

Re: [U-Boot] [PATCH] global_data: Move x86 specific GD flags into common flags

2019-08-15 Thread Stefan Roese
Hi Simon, On 15.08.19 09:35, Simon Goldschmidt wrote: Hi Stefan, On Thu, Aug 15, 2019 at 9:05 AM Stefan Roese wrote: Currently the upper 16 bits of the GD flags are reserved for architecture specific flags. But only x86 uses 2 bits of these 16 bits and sprinkling those flags in multiple

[U-Boot] [PATCH] global_data: Move x86 specific GD flags into common flags

2019-08-15 Thread Stefan Roese
about the reservation of the upper 16 bits. Signed-off-by: Stefan Roese Cc: Bin Meng Cc: Simon Glass Cc: Tom Rini Cc: Simon Goldschmidt --- arch/x86/include/asm/global_data.h | 6 -- include/asm-generic/global_data.h | 6 +- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git

Re: [U-Boot] [PATCH 1/4 v5] watchdog: Implement generic watchdog_reset() version

2019-08-15 Thread Stefan Roese
Hi Simon, On 14.08.19 21:35, Simon Glass wrote: Hi, On Wed, 14 Aug 2019 at 00:22, Stefan Roese wrote: Hi Simon, (added Simon Glass and Bin to Cc) On 13.08.19 22:16, Simon Goldschmidt wrote: Am 25.04.2019 um 09:17 schrieb Stefan Roese: This patch tries to implement a generic

Re: [U-Boot] [PATCH 1/4 v5] watchdog: Implement generic watchdog_reset() version

2019-08-14 Thread Stefan Roese
Hi Simon, (added Simon Glass and Bin to Cc) On 13.08.19 22:16, Simon Goldschmidt wrote: Am 25.04.2019 um 09:17 schrieb Stefan Roese: This patch tries to implement a generic watchdog_reset() function that can be used by all boards that want to service the watchdog device in U-Boot

Re: [U-Boot] [PATCH v2 1/3] spl: mmc: support uboot image offset on main partition

2019-08-13 Thread Stefan Roese
Hi Baruch, On 12.08.19 16:25, Baruch Siach wrote: Hi Stefan, On Mon, Aug 12, 2019 at 03:13:58PM +0200, Stefan Roese wrote: On 06.08.19 08:15, Stefan Roese wrote: On 29.07.19 09:12, Baruch Siach wrote: On Armada 38x platforms the ROM code loads SPL from offset 0 of eMMC hardware boot

Re: [U-Boot] [PATCH v2 2/3] arm: mvebu: clearfog: set uboot image SD card offset

2019-08-12 Thread Stefan Roese
Hi Baruch, On 06.08.19 08:20, Stefan Roese wrote: On 29.07.19 09:12, Baruch Siach wrote: Armada 38x ROM skips the first SD card offset when loading SPL. This affects the location of the main U-Boot image. SPL MMC code now supports U-Boot image offset based on run-time detection of the boot

Re: [U-Boot] [PATCH v2 1/3] spl: mmc: support uboot image offset on main partition

2019-08-12 Thread Stefan Roese
Hi Baruch, On 06.08.19 08:15, Stefan Roese wrote: On 29.07.19 09:12, Baruch Siach wrote: On Armada 38x platforms the ROM code loads SPL from offset 0 of eMMC hardware boot partitions. When there are no boot partitions (i.e. SD card) the ROM skips the first sector that usually contains

[U-Boot] Please pull u-boot-marvell/master

2019-08-12 Thread Stefan Roese
Hi Tom, please pull the first Marvell patches in this merge window with the following changes: - Various improvements to Keymile boards - mostly DT conversation (Pascal & Holger) - Removal of now unsupported Keymile boards

Re: [U-Boot] [PATCH u-boot-marvell 1/1] pci: pci_mvebu: set BAR0 after memory space is set

2019-08-12 Thread Stefan Roese
not depend on how U-Boot does things, but for some strange reason it does and this seems to be the simplest solution. Fix it since it caused regressions on Omnia. Signed-off-by: Marek Behún Cc: Stefan Roese Cc: Dirk Eibach Cc: Mario Six Cc: Chris Packham Cc: Phil Sutter Cc: VlaoMao Applied to: u

Re: [U-Boot] [PATCH u-boot-marvell 1/1] arm: mvebu: turris_omnia: update defconfig

2019-08-12 Thread Stefan Roese
On 16.07.19 15:50, Marek Behún wrote: Add Macronis SPI flash support - some Omnia routers are shipped with this SPI flash chip. Also add the memtest command to defconfig. Signed-off-by: Marek Behún Applied to: u-boot-marvell/master. Thanks, Stefan

Re: [U-Boot] [PATCH] ARM: configs: Enable DM_ETH for SBx81LIFKW and SBx81LIFXCAT

2019-08-12 Thread Stefan Roese
On 10.07.19 11:00, Chris Packham wrote: The mvgbe driver supports DM_ETH so switch these boards to using it. Signed-off-by: Chris Packham Applied to: u-boot-marvell/master. Thanks, Stefan ___ U-Boot mailing list U-Boot@lists.denx.de

Re: [U-Boot] [PATCH 0/9] km: Kconfig and driver model implementations

2019-08-12 Thread Stefan Roese
On 09.07.19 09:28, Pascal Linder wrote: This series of patches contains the driver model implementation for the UART and Ethernet interface on KM Kirkwood boards. Moreover, the conversion from header files to Kconfig has been advanced. Finally, three now unmaintained boards are removed in order

Re: [U-Boot] [PATCH u-boot-marvell 1/1] pci: pci_mvebu: set BAR0 after memory space is set

2019-08-09 Thread Stefan Roese
not depend on how U-Boot does things, but for some strange reason it does and this seems to be the simplest solution. Fix it since it caused regressions on Omnia. Signed-off-by: Marek Behún Cc: Stefan Roese Cc: Dirk Eibach Cc: Mario Six Cc: Chris Packham Cc: Phil Sutter Cc: VlaoMao Reviewed

Re: [U-Boot] [PATCH u-boot-marvell 1/1] arm: mvebu: turris_omnia: update defconfig

2019-08-06 Thread Stefan Roese
On 16.07.19 15:50, Marek Behún wrote: Add Macronis SPI flash support - some Omnia routers are shipped with this SPI flash chip. Also add the memtest command to defconfig. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan ___ U

Re: [U-Boot] [PATCH v2 3/3] arm: mvebu: clearfog: update eMMC documentation

2019-08-06 Thread Stefan Roese
-Boot from -the correct location. - To make SPL load the main U-Boot image from the eMMC boot partition enable eMMC boot acknowledgement and boot partition with the following U-Boot command: Reviewed-by: Stefan Roese Thanks, Stefan ___ U-Boot mailing l

Re: [U-Boot] [PATCH v2 2/3] arm: mvebu: clearfog: set uboot image SD card offset

2019-08-06 Thread Stefan Roese
On 29.07.19 09:12, Baruch Siach wrote: Armada 38x ROM skips the first SD card offset when loading SPL. This affects the location of the main U-Boot image. SPL MMC code now supports U-Boot image offset based on run-time detection of the boot partition. Use this feature to make the same generated

Re: [U-Boot] [PATCH v2 1/3] spl: mmc: support uboot image offset on main partition

2019-08-06 Thread Stefan Roese
On 29.07.19 09:12, Baruch Siach wrote: On Armada 38x platforms the ROM code loads SPL from offset 0 of eMMC hardware boot partitions. When there are no boot partitions (i.e. SD card) the ROM skips the first sector that usually contains the (logical) partition table. Since the generated .kwb

[U-Boot] Please pull u-boot-marvell/master (watchdog related)

2019-08-05 Thread Stefan Roese
at: g...@gitlab.denx.de:u-boot/custodians/u-boot-marvell.git for you to fetch changes up to c07f68dd66f305baf930c660493c4db4e2a50ff2: watchdog: mtk_wdt: Cosmetic cleanup of latest changes (2019-08-05 11:50:11 +0200) Stefan

Re: [U-Boot] [PATCH u-boot-spi v2 1/1] spi: mvebu_a3700_spi: Fix clock prescale computation

2019-08-05 Thread Stefan Roese
else if (prescale > 0xf) + if (prescale > 0xf) prescale = 0x10 + (prescale + 1) / 2; + prescale = min(prescale, 0x1fu); data &= ~MVEBU_SPI_A3700_CLK_PRESCALE_MASK; data |= prescale & MVEBU_SPI_A3700_CLK_PRESCALE_MASK; Reviewed-by: Stefan

Re: [U-Boot] [PATCH u-boot-spi 1/1] spi: mvebu_a3700_spi: Fix clock prescale computation

2019-07-17 Thread Stefan Roese
On 17.07.19 16:58, Marek Behún wrote: The prescaler value computation can yield wrong result if given 0x1f at the beginning: the value is computed to be 0x20, but the maximum value the register can hold 0x1f, so the actual stored value in this case is 0, which is obviously wrong. The first

[U-Boot] Please pull u-boot-marvell/master

2019-07-11 Thread Stefan Roese
Hi Tom, please pull the following Marvell related patches: - SPL SATA enhancements to allow booting from RAW SATA device needed for Clearfog (Baruch) - Enable SATA booting on Clearfog (Baruch) - Misc changes to Turris Omnia

Re: [U-Boot] [PATCH 4/9] spl: sata: support U-Boot load from raw sata disk

2019-07-11 Thread Stefan Roese
Hi Baruch, On 16.05.19 12:03, Baruch Siach wrote: Support load of the U-Boot image from raw SATA disk sector. This is equivalent to load from MMC raw sector. Signed-off-by: Baruch Siach This patch breaks cm_t54: $ ./tools/buildman/buildman cm_t54 Building current source for 1 boards (1

Re: [U-Boot] [PATCH 1/1 v1] arm: mvebu: crs305-1g-4s: Enable CMD_BOOTZ and increase SYS_BOOTM_LEN

2019-07-10 Thread Stefan Roese
On 10.07.19 22:24, Luka Kovacic wrote: On 2019-06-26 07:17, Stefan Roese wrote: On 25.06.19 13:57, Luka Kovacic wrote: This change enables CMD_BOOTZ and increases SYS_BOOTM_LEN to make it easier to work with kernel images. Signed-off-by: Luka Kovacic Reviewed-by: Stefan Roese Thanks

Re: [U-Boot] [PATCH] ARM: configs: Enable DM_ETH for SBx81LIFKW and SBx81LIFXCAT

2019-07-10 Thread Stefan Roese
On 10.07.19 11:00, Chris Packham wrote: The mvgbe driver supports DM_ETH so switch these boards to using it. Signed-off-by: Chris Packham Reviewed-by: Stefan Roese Thanks, Stefan --- configs/SBx81LIFKW_defconfig | 3 +++ configs/SBx81LIFXCAT_defconfig | 3 +++ 2 files changed, 6

  1   2   3   4   5   6   7   8   9   10   >