Re: [PATCH v2] spl: fit: Report fdt error for loading u-boot

2023-04-11 Thread Su, Bao Cheng
2 at 08:08, Mark Kettenis > > wrote: > > > > > > > From: Simon Glass > > > > Date: Wed, 19 Oct 2022 07:18:10 -0600 > > > > > > > > Hi, > > > > > > > > On Mon, 17 Oct 2022 at 05:53, Su, Bao Cheng > > > >

Re: [PATCH v2] spl: fit: Report fdt error for loading u-boot

2022-10-17 Thread Su, Bao Cheng
Hi Simon, On Sat, 2022-07-30 at 19:27 -0600, Simon Glass wrote: > Hi Bao Cheng, > > On Sat, 30 Jul 2022 at 03:05, Su, Bao Cheng wrote: > > > > Commit 71551055cbdb ("spl: fit: Load devicetree when a Linux payload is > > found") made a change to not repor

[PATCH v2] spl: fit: Report fdt error for loading u-boot

2022-07-31 Thread Su, Bao Cheng
Commit 71551055cbdb ("spl: fit: Load devicetree when a Linux payload is found") made a change to not report the spl_fit_append_fdt error at all if next-stage image is u-boot. However for u-boot image without CONFIG_OF_EMBED, the error should be reported to uplevel caller. Otherwise, uplevel

[PATCH] spl: fit: Report fdt error for loading u-boot

2022-07-31 Thread Su, Bao Cheng
Commit 71551055cbdb ("spl: fit: Load devicetree when a Linux payload is found") made a change to not report the spl_fit_append_fdt error at all if next-stage image is u-boot. However for u-boot image without CONFIG_OF_EMBED, the error should be reported to uplevel caller. Otherwise, uplevel

[PATCH v2] efi_loader: PE hashing for image with gap between sections

2022-07-07 Thread Su, Bao Cheng
Some PE image has gap between sections. These gaps could be kernel symbol table that does not belong to any sections. For such kind of image, after the last section is added into the hashing, the bytes_hashed is less than the (PE file size - Size of AttributeCertificateTable). According to Step

Re: [PATCH] efi_loader: Allow overlapped extra data for PE hashing

2022-07-06 Thread Su, Bao Cheng
On Mon, 2022-06-27 at 16:32 +0200, Heinrich Schuchardt wrote: > On 6/24/22 07:32, Su, Bao Cheng wrote: > > During PE hashing, when holes exists between sections, the extra > > data > > calculated could be a dupulicated region of the last section. > > > > Such PE

Re: [PATCH] efi_loader: Allow overlapped extra data for PE hashing

2022-06-27 Thread Su, Bao Cheng
On Fri, 2022-06-24 at 11:44 +0200, Jan Kiszka wrote: > On 24.06.22 10:53, Heinrich Schuchardt wrote: > > On 6/24/22 07:32, Su, Bao Cheng wrote: > > > During PE hashing, when holes exists between sections, the extra > > > data > > > calculated could be a du

Re: [PATCH] efi_loader: Allow overlapped extra data for PE hashing

2022-06-27 Thread Su, Bao Cheng
On Mon, 2022-06-27 at 06:55 +0200, Heinrich Schuchardt wrote: > On 6/27/22 05:43, Su, Bao Cheng wrote: > > On Fri, 2022-06-24 at 11:44 +0200, Jan Kiszka wrote: > > > On 24.06.22 10:53, Heinrich Schuchardt wrote: > > > > On 6/24/22 07:32, Su, Bao Cheng wrote: > >

[PATCH] efi_loader: Allow overlapped extra data for PE hashing

2022-06-24 Thread Su, Bao Cheng
During PE hashing, when holes exists between sections, the extra data calculated could be a dupulicated region of the last section. Such PE image with holes existing between sections may contain the symbol table for the kernel, for example. The Authenticode_PE spec does not rule how to deal with