Re: [PATCH] mkimage: clarify error message for empty input files

On Sun, Aug 1, 2021 at 3:23 PM Thomas Hebb wrote: > > Currently, an empty imput file causes `mmap()` to fail, and you get an Whoops, s/imput/input/. Didn't catch this before sending it out. > error like "mkimage: Can't read file.img: Invalid argument", which is > extremely unintuitive and hard

Re: [PATCH 1/2] mmc: update guard for legacy part_init() call

On Mon, Feb 10, 2020, 19:13 Tom Rini wrote: > On Sat, Feb 01, 2020 at 11:35:37AM -0800, Thomas Hebb wrote: > > > commit eef05fd3ba68 ("mmc: bring back partition init for non-DM MMC > > drivers") added this call to support drivers not yet migrated to driver > > model. Slightly previously,

Re: [PATCH v2] cosmetic: Fix spelling and whitespace errors

On Thu, Dec 12, 2019 at 7:26 PM Kever Yang wrote: > > Hi Thomas, > > Could you add commit message for patch and split the patch into > multi patches > > base on the module? > Hi Kever, I think this already got merged, didn't it? -Tom > > Thanks, > > - Kever > > On 2019/11/14 上午10:18,

Re: [U-Boot] [PATCH 1/2] rockchip: allow DRAM init in SPL and fix ordering

Thank you for the review! I will split the patch and send a v2. On Thu, Nov 14, 2019, 17:17 Kever Yang wrote: > Hi Thomas, > On 2019/11/15 上午12:09, Tom Hebb wrote: > > Hi Kever, > > On Thu, Nov 14, 2019 at 1:25 AM Kever Yang > wrote: > >> Hi Thomas, >> &

Re: [U-Boot] [PATCH 1/2] rockchip: allow DRAM init in SPL and fix ordering

Hi Kever, On Thu, Nov 14, 2019 at 1:25 AM Kever Yang wrote: > Hi Thomas, > > On 2019/11/11 上午12:25, Thomas Hebb wrote: > > b7abef2ecbcc ("rockchip: rk3399: Migrate to use common spl board file") > > removed SoC-specific code for RK3399's SPL and in the process introduced > > two regressions: >