ine setup_fec and setup_eqos
Drop arm: cpu: armv7: ls102xa: fdt: remove eth_device support
Simon's patches took care of these
Add to todo list, these new questionable uses that snuck into the code.
PARTITION_TYPE_GUID
PHY_ATHEROS
RTC_SANDBOX
(no change
test/usage_of_is_enabled_commit.sh
to convert to suggested usage of CONFIG_IS_ENABLED/IS_ENABLED
or run test/usage_of_is_enabled_check.sh to
see which configs are still todo.
Reviewed-by: Simon Glass
Signed-off-by: Troy Kisky
---
(no changes since v1)
.azure-pipelines.yml| 11
On Wed, Sep 27, 2023 at 11:14 AM Troy Kisky
wrote:
>
>
> On Mon, Jun 19, 2023 at 4:07 PM Troy Kisky
> wrote:
>
>> Add script usage_of_is_enabled_check to print any configs that
>> use CONFIG_IS_ENABLED instead of IS_ENABLED and vice versa.
>>
>> Add us
On Mon, Jun 19, 2023 at 4:07 PM Troy Kisky
wrote:
> Add script usage_of_is_enabled_check to print any configs that
> use CONFIG_IS_ENABLED instead of IS_ENABLED and vice versa.
>
> Add usage_of_is_enabled_commit.sh to generate commits to fix the above
> issues.
>
> You ca
test/usage_of_is_enabled_commit.sh
to convert to suggested usage of CONFIG_IS_ENABLED/IS_ENABLED
or run test/usage_of_is_enabled_check.sh to
see which configs are still todo.
Reviewed-by: Simon Glass
Signed-off-by: Troy Kisky
---
(no changes since v1)
.azure-pipelines.yml| 11
_eqos
Drop arm: cpu: armv7: ls102xa: fdt: remove eth_device support
Simon's patches took care of these
Add to todo list, these new questionable uses that snuck into the code.
PARTITION_TYPE_GUID
PHY_ATHEROS
RTC_SANDBOX
(no changes since v1)
Troy Kisky
Hi Tom,
You are looking at an old patch, here's the new.
commit c969bedb9cb6029360e6fe7e25a331680fabe3ee
Author: Troy Kisky
Date: Thu Feb 23 08:01:46 2023 -0800
ns16550: match when to define bdf with uart code
When switching defined(CONFIG_PCI) to CONFIG_IS_ENABLED(PCI)
b
d by Simon
- changed condition of when to include field bdf
- added protection to another instance of bdf in uart.c
- Thanks to Simon for getting this corrected
- use normal if, not preprocessor
- new in series
- use an accessor function gd_set_pci_ram_top
Troy Kisky (23):
kconfig: add IS_ENABL
This avoid an error with enable_sata_clock when
defined(CONFIG_SATA) is changed to CONFIG_IS_ENABLED(SATA).
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
---
(no changes since v1)
arch/arm/mach-imx/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm
test/usage_of_is_enabled_commit.sh
to convert to suggested usage of CONFIG_IS_ENABLED/IS_ENABLED
or run test/usage_of_is_enabled_check.sh to
see which configs are still todo.
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
---
(no changes since v1)
.azure-pipelines.yml| 11
This avoids an error when ifdef CONFIG_PCI is changed to
if CONFIG_IS_ENABLED(PCI)
Signed-off-by: Troy Kisky
---
(no changes since v2)
Changes in v2:
- use an accessor function gd_set_pci_ram_top
arch/x86/cpu/i386/cpu.c | 2 +-
include/asm-generic/global_data.h | 6 ++
2 files
This avoids an error in converting to CONFIG_IS_ENABLED(DM_PMIC).
Many boards SPL code needs these definitions to compile, even if
the functions are not linked.
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
---
(no changes since v1)
include/power/pmic.h | 2 +-
1 file changed, 1
Prepare for linking setup_sata only when CONFIG_SATA/CONFIG_SPL_SATA
is defined.
Signed-off-by: Troy Kisky
---
(no changes since v2)
Changes in v2:
- new in series
board/wandboard/wandboard.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/board/wandboard/wandboard.c
Prepare for linking setup_sata only when CONFIG_SATA/CONFIG_SPL_SATA
is defined.
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
---
Changes in v3:
- Rebase on Simon's s/CMD_SATA/SATA/ change
- commit message updated
Changes in v2:
- use normal if, not preprocessor
board/sol
When switching defined(CONFIG_PCI) to CONFIG_IS_ENABLED(PCI)
bdf is no longer accessible. So add preprocessor protection
to avoid access.
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
---
(no changes since v2)
Changes in v2:
- changed condition of when to include field bdf
- added
pfuze_mode_init calls pmic_reg_read which is only available from
obj-$(CONFIG_$(SPL_TPL_)DM_PMIC) += pmic-uclass.o
Prepare for conversion of defined(CONFIG_DM_PMIC) to
CONFIG_IS_ENABLED(DM_PMIC).
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
---
(no changes since v1)
board/freescale
SPL code wants fdt_fixup_mtdparts defined as a NOP
when the function isn't linked in.
Prepare for ifdef CONFIG_OF_LIBFDT being converted to
if CONFIG_IS_ENABLED(OF_LIBFDT)
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
---
(no changes since v1)
include/fdt_support.h
The function ft_board_setup calls do_fixup_by_path_string
which is only available on CONFIG_IS_ENABLED(OF_LIBFDT).
This prepares for the conversion.
ft_board_setup is only called from image-fdt which is linked by
obj-$(CONFIG_$(SPL_TPL_)OF_LIBFDT) += image-fdt.o
Signed-off-by: Troy Kisky
With the use of CONFIG_IS_ENABLED in code, instead of at the preprocessor
level, these defines are still needed if OF_CONTROL is enabled.
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
---
(no changes since v1)
include/fdt_support.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion
SPL environments don't need commands that they can never use.
Avoid errors with CONFIG_IS_ENABLED conversions by skipping them now.
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
---
(no changes since v1)
include/config_distro_bootcmd.h | 23 +++
1 file change
CONFIG_IS_ENABLED(SPL_X86_32BIT_INIT)
would check for CONFIG_SPL_SPL_X86_32BIT_INIT for SPL builds
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
---
(no changes since v1)
arch/x86/cpu/qemu/qemu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/cpu/qemu
We need to include in order to include
files that use CONFIG_IS_ENABLED.
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
Reviewed-by: Tom Rini
---
(no changes since v2)
Changes in v2:
- include linux/kconfig.h from tools/Makefile
- as suggested by Simon
tools/Makefile | 1 +
1 file
CONFIG_IS_ENABLED(FIT_SIGNATURE) will check for
CONFIG_TOOLS_FIT_SIGNATURE. So define it now in preparation.
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
---
(no changes since v1)
tools/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/Makefile b/tools/Makefile
index
defined(CONFIG_HW_WATCHDOG) || defined(CONFIG_WATCHDOG)
is a common pattern. Create an new config symbol
HAS_WATCHDOG_RUNNING to express it.
Signed-off-by: Troy Kisky
---
Changes in v3:
new patch to address Tom's concerns
arch/arm/mach-omap2/boot-common.c | 5 ++---
arch/m68
We need to include in order to include
files that use CONFIG_IS_ENABLED. TO prepare for that
don't pet the watchdog when USE_HOSTCC is defined.
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
---
(no changes since v2)
Changes in v2:
- delay include of linux/kconfig.h to do from Mak
We need to include in order to include
files that use CONFIG_IS_ENABLED. TO prepare for that
don't pet the watchdog when USE_HOSTCC is defined.
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
---
(no changes since v2)
Changes in v2:
- delay include of linux/kconfig.h to do from Mak
We need to include in order to include
files that use CONFIG_IS_ENABLED. TO prepare for that
don't pet the watchdog when USE_HOSTCC is defined.
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
---
(no changes since v2)
Changes in v2:
- delay include of linux/kconfig.h to do from Mak
We need to include in order to include
files that use CONFIG_IS_ENABLED. TO prepare for that
don't pet the watchdog when USE_HOSTCC is defined.
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
---
(no changes since v2)
Changes in v2:
- delay include of linux/kconfig.h to do from Mak
Avoid error messages when SPL,TPL,VPL build don't
have the environment options of the main build.
This is needed when defined(CONFIG_ENV_IS_IN_xxx) is changed
to CONFIG_IS_ENABLED(ENV_IS_IN_xxx).
Signed-off-by: Troy Kisky
---
Changes in v3:
remove error entirely and prevent with Kc
We need to include in order to include
files that use CONFIG_IS_ENABLED. TO prepare for that
be more direct with using defined(USE_HOSTCC).
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
---
(no changes since v2)
Changes in v2:
- delay include of linux/kconfig.h to do from Makefile
- as
This is for use when a config with an SPL version needs to always
check the non-spl verion of the config. It avoids error messages
from CI test script usage_of_is_enabled_check.sh
Signed-off-by: Troy Kisky
---
(no changes since v2)
Changes in v2:
- new patch
include/linux/kconfig.h | 5
On Thu, Mar 9, 2023 at 11:36 AM Tom Rini wrote:
> On Thu, Mar 09, 2023 at 11:20:33AM -0800, Troy Kisky wrote:
> > On Wed, Mar 1, 2023 at 7:33 AM Tom Rini wrote:
> >
> > > On Fri, Feb 24, 2023 at 10:10:23AM -0800, Troy Kisky wrote:
> > > > Avoid error m
On Wed, Mar 1, 2023 at 9:39 AM Quentin Schulz wrote:
> From: Quentin Schulz
>
> Instead of letting the compiler error out if CONFIG_ENV_IS_NOWHERE is
> not selected by the user, let's just enforce it when the user builds for
> Ringneck PX30 so that no check needs to be performed by the compiler
On Wed, Mar 1, 2023 at 7:33 AM Tom Rini wrote:
> On Fri, Feb 24, 2023 at 10:10:23AM -0800, Troy Kisky wrote:
> > Avoid error messages when SPL,TPL,VPL build don't
> > have the environment options of the main build.
> > This is needed when defined(CONFIG_ENV_IS
On Wed, Mar 1, 2023 at 7:33 AM Tom Rini wrote:
> On Fri, Feb 24, 2023 at 10:10:30AM -0800, Troy Kisky wrote:
> > CONFIG_IS_ENABLED(FIT_SIGNATURE) will check for
> > CONFIG_TOOLS_FIT_SIGNATURE. So define it now in preparation.
> >
> > Signed-off-by: Troy Kisky
&
- Always define function instead of using same protection
Troy Kisky (26):
kconfig: add IS_ENABLED_NOCHECK to bypass usage_of_is_enabled_check
cmd: nvedit: check for ENV_SUPPORT
lib: crc32: prepare for CONFIG_IS_ENABLED changes
lib: md5: prepare for CONFIG_IS_ENABLED changes
lib: sha1
The compiler will optimize away base on IS_ENABLED(CONFIG_FEC_MXC).
It avoids an error in converting to CONFIG_IS_ENABLED(NET).
Signed-off-by: Troy Kisky
---
Changes in v2:
- Always define function instead of using same protection
board/gateworks/venice/venice.c | 2 +-
1 file changed, 1
setup_sata is linked with
obj-$(CONFIG_SATA) += sata.o
So use SATA instead of CMD_SATA.
Signed-off-by: Troy Kisky
---
Changes in v2:
- use normal if, not preprocessor
board/solidrun/mx6cuboxi/mx6cuboxi.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/board/solidrun
This avoids an error in converting to CONFIG_IS_ENABLED(DM_PMIC).
Many boards SPL code needs these definitions to compile, even if
the functions are not linked.
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
---
(no changes since v1)
include/power/pmic.h | 2 +-
1 file changed, 1
When usage_of_is_enabled_check.sh is added, this will show a false
positive for IS_ENABLED(CONFIG_ENV_IS_NOWHERE).
Use IS_ENABLED_NOCHECK to avoid check and error on SPL builds.
Signed-off-by: Troy Kisky
---
Changes in v2:
- keep #error, but change condition to use IS_ENABLED_NOCHECK
board
With the use of CONFIG_IS_ENABLED in code, instead of at the preprocessor
level, these defines are still needed if OF_CONTROL is enabled.
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
---
(no changes since v1)
include/fdt_support.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion
This avoid an error with enable_sata_clock when
defined(CONFIG_SATA) is changed to CONFIG_IS_ENABLED(SATA).
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
---
(no changes since v1)
arch/arm/mach-imx/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm
SPL code wants fdt_fixup_mtdparts defined as a NOP
when the function isn't linked in.
Prepare for ifdef CONFIG_OF_LIBFDT being converted to
if CONFIG_IS_ENABLED(OF_LIBFDT)
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
---
(no changes since v1)
include/fdt_support.h
CONFIG_IS_ENABLED(SPL_X86_32BIT_INIT)
would check for CONFIG_SPL_SPL_X86_32BIT_INIT for SPL builds
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
---
(no changes since v1)
arch/x86/cpu/qemu/qemu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/cpu/qemu
When switching defined(CONFIG_PCI) to CONFIG_IS_ENABLED(PCI)
bdf is no longer accessible. So add preprocessor protection
to avoid access.
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
---
Changes in v2:
- changed condition of when to include field bdf
- added protection to another
test/usage_of_is_enabled_commit.sh
to convert to suggested usage of CONFIG_IS_ENABLED/IS_ENABLED
or run test/usage_of_is_enabled_check.sh to
see which configs are still todo.
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
---
(no changes since v1)
.azure-pipelines.yml| 11
commit e524f3a449f5 ("net: Remove eth_legacy.c")
removed struct eth_device
This prevents errors in the conversion to CONFIG_IS_ENABLED(DM_ETH).
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
---
(no changes since v1)
arch/arm/cpu/armv7/ls102xa/fdt.c | 12
1 file c
This avoids an error when ifdef CONFIG_PCI is changed to
if CONFIG_IS_ENABLED(PCI)
Signed-off-by: Troy Kisky
---
Changes in v2:
- use an accessor function gd_set_pci_ram_top
arch/x86/cpu/i386/cpu.c | 2 +-
include/asm-generic/global_data.h | 6 ++
2 files changed, 7 insertions
pfuze_mode_init calls pmic_reg_read which is only available from
obj-$(CONFIG_$(SPL_TPL_)DM_PMIC) += pmic-uclass.o
Prepare for conversion of defined(CONFIG_DM_PMIC) to
CONFIG_IS_ENABLED(DM_PMIC).
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
---
(no changes since v1)
board/freescale
The function ft_board_setup calls do_fixup_by_path_string
which is only available on CONFIG_IS_ENABLED(OF_LIBFDT).
This prepares for the conversion.
ft_board_setup is only called from image-fdt which is linked by
obj-$(CONFIG_$(SPL_TPL_)OF_LIBFDT) += image-fdt.o
Signed-off-by: Troy Kisky
When usage_of_is_enabled_check.sh is added, this will show a false
positive for IS_ENABLED(CONFIG_ENV_IS_NOWHERE).
Use IS_ENABLED_NOCHECK to avoid check and error on SPL builds.
Signed-off-by: Troy Kisky
---
Changes in v2:
- keep #error, but change condition to use IS_ENABLED_NOCHECK
board
Prepare for linking setup_sata only when CONFIG_SATA/CONFIG_SPL_SATA
is defined.
Signed-off-by: Troy Kisky
---
Changes in v2:
- new in series
board/wandboard/wandboard.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/board/wandboard/wandboard.c b/board/wandboard
SPL environments don't need commands that they can never use.
Avoid errors with CONFIG_IS_ENABLED conversions by skipping them now.
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
---
(no changes since v1)
include/config_distro_bootcmd.h | 23 +++
1 file change
CONFIG_IS_ENABLED(FIT_SIGNATURE) will check for
CONFIG_TOOLS_FIT_SIGNATURE. So define it now in preparation.
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
---
(no changes since v1)
tools/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/Makefile b/tools/Makefile
index
We need to include in order to include
files that use CONFIG_IS_ENABLED.
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
---
Changes in v2:
- include linux/kconfig.h from tools/Makefile
- as suggested by Simon
tools/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools
We need to include in order to include
files that use CONFIG_IS_ENABLED. TO prepare for that
don't pet the watchdog when USE_HOSTCC is defined.
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
---
Changes in v2:
- delay include of linux/kconfig.h to do from Makefile
- as suggested by
We need to include in order to include
files that use CONFIG_IS_ENABLED. TO prepare for that
don't pet the watchdog when USE_HOSTCC is defined.
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
---
Changes in v2:
- delay include of linux/kconfig.h to do from Makefile
- as suggested by
We need to include in order to include
files that use CONFIG_IS_ENABLED. TO prepare for that
don't pet the watchdog when USE_HOSTCC is defined.
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
---
Changes in v2:
- delay include of linux/kconfig.h to do from Makefile
- as suggested by
We need to include in order to include
files that use CONFIG_IS_ENABLED. TO prepare for that
don't pet the watchdog when USE_HOSTCC is defined.
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
---
Changes in v2:
- delay include of linux/kconfig.h to do from Makefile
- as suggested by
We need to include in order to include
files that use CONFIG_IS_ENABLED. TO prepare for that
be more direct with using defined(USE_HOSTCC).
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
---
Changes in v2:
- delay include of linux/kconfig.h to do from Makefile
- as suggested by Simon
Avoid error messages when SPL,TPL,VPL build don't
have the environment options of the main build.
This is needed when defined(CONFIG_ENV_IS_IN_xxx) is changed
to CONFIG_IS_ENABLED(ENV_IS_IN_xxx).
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
---
(no changes since v1)
cmd/nvedit.
This is for use when a config with an SPL version needs to always
check the non-spl verion of the config. It avoids error messages
from CI test script usage_of_is_enabled_check.sh
Signed-off-by: Troy Kisky
---
Changes in v2:
- new patch
include/linux/kconfig.h | 5 +
1 file changed, 5
On Wed, Feb 22, 2023 at 10:13 AM Troy Kisky
wrote:
> On Wed, Feb 22, 2023 at 8:59 AM Tom Rini wrote:
>
>> On Tue, Feb 21, 2023 at 05:38:15PM -0800, Troy Kisky wrote:
>>
>> > setup_sata is linked with
>> > obj-$(CONFIG_SATA) += sata.o
>> >
>>
On Wed, Feb 22, 2023 at 7:05 AM Tom Rini wrote:
> On Tue, Feb 21, 2023 at 05:38:16PM -0800, Troy Kisky wrote:
>
> > This avoid an error with enable_sata_clock when
> > defined(CONFIG_SATA) is changed to CONFIG_IS_ENABLED(SATA).
> >
> > Signed-off-by: Troy Kisky
OK, I'll try that.
BR
Troy
On Wed, Feb 22, 2023 at 1:20 PM Simon Glass wrote:
> On Tue, 21 Feb 2023 at 18:38, Troy Kisky
> wrote:
> >
> > We need to include in order to include
> > files that use CONFIG_IS_ENABLED. TO prepare for that
> > don't pet
On Wed, Feb 22, 2023 at 12:41 PM Troy Kisky
wrote:
>
>
>
>> How does this look ?
>>
>> diff --git a/arch/x86/cpu/apollolake/uart.c
>> b/arch/x86/cpu/apollolake/uart.c
>> index a9362436000..da184638cb9 100644
>> --- a/arch/x86/cpu/apollolake/u
On Wed, Feb 22, 2023 at 11:39 AM Troy Kisky
wrote:
>
> On Wed, Feb 22, 2023 at 10:42 AM Troy Kisky
> wrote:
>
>> On Wed, Feb 22, 2023 at 10:18 AM Tom Rini wrote:
>>
>>> On Tue, Feb 21, 2023 at 05:38:14PM -0800, Troy Kisky wrote:
>>>
>>> > W
On Wed, Feb 22, 2023 at 10:42 AM Troy Kisky
wrote:
> On Wed, Feb 22, 2023 at 10:18 AM Tom Rini wrote:
>
>> On Tue, Feb 21, 2023 at 05:38:14PM -0800, Troy Kisky wrote:
>>
>> > When switching defined(CONFIG_PCI) to CONFIG_IS_ENABLED(PCI)
>> > bdf is no longer a
On Wed, Feb 22, 2023 at 10:18 AM Tom Rini wrote:
> On Tue, Feb 21, 2023 at 05:38:14PM -0800, Troy Kisky wrote:
>
> > When switching defined(CONFIG_PCI) to CONFIG_IS_ENABLED(PCI)
> > bdf is no longer accessible. So change to preprocessor to avoid access.
> >
>
On Wed, Feb 22, 2023 at 8:59 AM Tom Rini wrote:
> On Tue, Feb 21, 2023 at 05:38:15PM -0800, Troy Kisky wrote:
>
> > setup_sata is linked with
> > obj-$(CONFIG_SATA) += sata.o
> >
> > So use SATA instead of CMD_SATA.
> >
> > Signed-off-by: Troy Kisky
commit e524f3a449f5 ("net: Remove eth_legacy.c")
removed struct eth_device
This prevents errors in the conversion to CONFIG_IS_ENABLED(DM_ETH).
Signed-off-by: Troy Kisky
---
arch/arm/cpu/armv7/ls102xa/fdt.c | 12
1 file changed, 12 deletions(-)
diff --git a/arch/arm
CONFIG_IS_ENABLED/IS_ENABLED and is added
to .azure-pipelines.yml, and
.gitlab-ci.yml
Troy Kisky (24):
cmd: nvedit: check for ENV_SUPPORT
lib: crc32: prepare for CONFIG_IS_ENABLED changes
lib: md5: prepare for CONFIG_IS_ENABLED changes
lib: sha1: prepare for CONFIG_IS_ENABLED changes
lib: sha256
test/usage_of_is_enabled_commit.sh
to convert to suggested usage of CONFIG_IS_ENABLED/IS_ENABLED
or run test/usage_of_is_enabled_check.sh to
see which configs are still todo.
Signed-off-by: Troy Kisky
---
.azure-pipelines.yml| 11 ++
.gitlab-ci.yml | 5
This avoids an error in converting to CONFIG_IS_ENABLED(DM_PMIC).
Many boards SPL code needs these definitions to compile, even if
the functions are not linked.
Signed-off-by: Troy Kisky
---
include/power/pmic.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/power
This avoids an error when ifdef CONFIG_PCI is changed to
if CONFIG_IS_ENABLED(PCI)
Signed-off-by: Troy Kisky
---
arch/x86/cpu/i386/cpu.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/x86/cpu/i386/cpu.c b/arch/x86/cpu/i386/cpu.c
index c7f6c5a013e..07a73f79768 100644
--- a/arch/x86
This avoid an error with enable_sata_clock when
defined(CONFIG_SATA) is changed to CONFIG_IS_ENABLED(SATA).
Signed-off-by: Troy Kisky
---
arch/arm/mach-imx/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-imx/Makefile b/arch/arm/mach-imx/Makefile
index
This is the same as the definition is surrounded by.
It avoids an error in converting to CONFIG_IS_ENABLED(NET).
Signed-off-by: Troy Kisky
---
board/gateworks/venice/venice.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/board/gateworks/venice/venice.c b/board
pfuze_mode_init calls pmic_reg_read which is only available from
obj-$(CONFIG_$(SPL_TPL_)DM_PMIC) += pmic-uclass.o
Prepare for conversion of defined(CONFIG_DM_PMIC) to
CONFIG_IS_ENABLED(DM_PMIC).
Signed-off-by: Troy Kisky
---
board/freescale/common/pfuze.c | 2 +-
1 file changed, 1 insertion
When switching defined(CONFIG_PCI) to CONFIG_IS_ENABLED(PCI)
bdf is no longer accessible. So change to preprocessor to avoid access.
Signed-off-by: Troy Kisky
---
arch/x86/cpu/apollolake/uart.c | 6 +++---
include/ns16550.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions
The function ft_board_setup calls do_fixup_by_path_string
which is only available on CONFIG_IS_ENABLED(OF_LIBFDT).
This prepares for the conversion.
ft_board_setup is only called from image-fdt which is linked by
obj-$(CONFIG_$(SPL_TPL_)OF_LIBFDT) += image-fdt.o
Signed-off-by: Troy Kisky
setup_sata is linked with
obj-$(CONFIG_SATA) += sata.o
So use SATA instead of CMD_SATA.
Signed-off-by: Troy Kisky
---
board/solidrun/mx6cuboxi/mx6cuboxi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/solidrun/mx6cuboxi/mx6cuboxi.c
b/board/solidrun/mx6cuboxi
When IS_ENABLED(CONFIG_ENV_IS_NOWHERE) is converted to
CONFIG_IS_ENABLED(ENV_IS_NOWHERE) this will give unwanted errors
on spl builds.
Signed-off-by: Troy Kisky
---
board/theobroma-systems/puma_rk3399/puma-rk3399.c | 4
1 file changed, 4 deletions(-)
diff --git a/board/theobroma-systems
SPL code wants fdt_fixup_mtdparts defined as a NOP
when the function isn't linked in.
Prepare for ifdef CONFIG_OF_LIBFDT being converted to
if CONFIG_IS_ENABLED(OF_LIBFDT)
Signed-off-by: Troy Kisky
---
include/fdt_support.h | 23 +--
1 file changed, 13 insertions(+
When IS_ENABLED(CONFIG_ENV_IS_NOWHERE) is converted to
CONFIG_IS_ENABLED(ENV_IS_NOWHERE) this will give unwanted errors
on spl builds.
Signed-off-by: Troy Kisky
---
board/theobroma-systems/ringneck_px30/ringneck-px30.c | 4
1 file changed, 4 deletions(-)
diff --git a/board/theobroma
CONFIG_IS_ENABLED(SPL_X86_32BIT_INIT)
would check for CONFIG_SPL_SPL_X86_32BIT_INIT for SPL builds
Signed-off-by: Troy Kisky
---
arch/x86/cpu/qemu/qemu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/cpu/qemu/qemu.c b/arch/x86/cpu/qemu/qemu.c
index e54082df7f9
With the use of CONFIG_IS_ENABLED in code, instead of at the preprocessor
level, these defines are still needed if OF_CONTROL is enabled.
Signed-off-by: Troy Kisky
---
include/fdt_support.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/fdt_support.h b/include
SPL environments don't need command that they can never use.
Avoid errors with CONFIG_IS_ENABLED conversions by skipping them now.
Signed-off-by: Troy Kisky
---
include/config_distro_bootcmd.h | 23 +++
1 file changed, 23 insertions(+)
diff --git a/in
CONFIG_IS_ENABLED(FIT_SIGNATURE) will check for
CONFIG_TOOLS_FIT_SIGNATURE. So define it now in preparation.
Signed-off-by: Troy Kisky
---
tools/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/Makefile b/tools/Makefile
index e13effbb66a..2670c77b2cb 100644
--- a/tools
We need to include in order to include
files that use CONFIG_IS_ENABLED.
Signed-off-by: Troy Kisky
---
boot/fdt_region.c | 1 +
lib/fdtdec_common.c | 1 +
lib/hash-checksum.c | 1 +
tools/env/fw_env.c | 1 +
tools/fdt_host.h| 1 +
tools/mkimage.h | 1 +
6 files changed, 6
We need to include in order to include
files that use CONFIG_IS_ENABLED. TO prepare for that
don't pet the watchdog when USE_HOSTCC is defined.
Signed-off-by: Troy Kisky
---
lib/sha256.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/lib/sha256.c b/lib/sha
We need to include in order to include
files that use CONFIG_IS_ENABLED. TO prepare for that
don't pet the watchdog when USE_HOSTCC is defined.
Signed-off-by: Troy Kisky
---
lib/sha512.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/lib/sha512.c b/lib/s
We need to include in order to include
files that use CONFIG_IS_ENABLED. TO prepare for that
don't pet the watchdog when USE_HOSTCC is defined.
Signed-off-by: Troy Kisky
---
lib/sha1.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/lib/sha1.c b/lib/sha1.c
We need to include in order to include
files that use CONFIG_IS_ENABLED. TO prepare for that
be more direct with using defined(USE_HOSTCC).
Signed-off-by: Troy Kisky
---
lib/crc32.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/lib/crc32.c b/lib/crc32.c
We need to include in order to include
files that use CONFIG_IS_ENABLED. TO prepare for that
don't pet the watchdog when USE_HOSTCC is defined.
Signed-off-by: Troy Kisky
---
lib/md5.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/lib/md5.c b/lib/md5.c
Avoid error messages when SPL,TPL,VPL build don't
have the environment options of the main build.
This is needed when defined(CONFIG_ENV_IS_IN_xxx) is changed
to CONFIG_IS_ENABLED(ENV_IS_IN_xxx).
Signed-off-by: Troy Kisky
---
cmd/nvedit.c | 5 -
1 file changed, 4 insertions(+), 1 del
Hi Guys
My recent CI runs for my is_enabled branch have failed
Run tests for Nokia RX-51 (aka N900) with
2023-02-07T17:38:08.1393984Z --2023-02-07 17:38:08-- (try:20)
http://repository.maemo.org/pool/maemo5.0/free/b/busybox/busybox_1.10.2.legal-1osso30+0m5_armel.deb
2023-02-07T17:40:17.4031492Z
Hi Simon
On Wed, Feb 1, 2023 at 12:21 PM Simon Glass wrote:
> Hi Troy,
>
> On Tue, 31 Jan 2023 at 12:57, Troy Kisky
> wrote:
> >
> > Add script usage_of_is_enabled_check to print any configs that
> > use CONFIG_IS_ENABLED instead of IS_ENABL
Add script usage_of_is_enabled_check to print any configs that
use CONFIG_IS_ENABLED instead of IS_ENABLED and vice versa.
Add usage_of_is_enabled_commit.sh to generate commits to fix the above
issues.
Signed-off-by: Troy Kisky
---
.azure-pipelines.yml | 11
.gitlab
On Mon, Jan 30, 2023 at 11:44 AM Tom Rini wrote:
> On Mon, Jan 30, 2023 at 10:51:03AM -0800, Troy Kisky wrote:
> > Hi Tom
> >
> >
> > On Mon, Jan 30, 2023 at 9:18 AM Tom Rini wrote:
> >
> > > On Sat, Jan 28, 2023 at 09:25:54AM -0800, Troy Kisky wr
Hi Tom
On Mon, Jan 30, 2023 at 9:18 AM Tom Rini wrote:
> On Sat, Jan 28, 2023 at 09:25:54AM -0800, Troy Kisky wrote:
> > Thanks Tom,
> >
> > I cleaned up the PR based on the CI results. Here's my current changes.
> >
> > Author: Troy Kisky
>
1 - 100 of 749 matches
Mail list logo
