Re: [U-Boot] [PATCH v3 0/9] NXP LS1021A-TSN Board

2019-08-14 Thread Vladimir Oltean
Hi Prabhakar, On Wed, 14 Aug 2019 at 12:37, Prabhakar Kushwaha wrote: > > Dear Joe, > > > -Original Message- > > From: Joe Hershberger > > Sent: Thursday, July 25, 2019 12:26 AM > > To: Vladimir Oltean > > Cc: Joseph Hershberger ; Prabhakar >

Re: [U-Boot] Pull request: u-boot-net.git master

2019-07-25 Thread Vladimir Oltean
On 5/15/19 5:58 PM, Tom Rini wrote: > On Fri, May 10, 2019 at 09:50:45PM +, Joe Hershberger wrote: >> Hi Vladimir and Tom, >> >> On Thu, May 9, 2019 at 7:51 AM Vladimir Oltean >> wrote: >>> >>> On 09.05.2019 02:05, Vladimir Oltean wrote: >>

Re: [U-Boot] Add support for the NXP LS1021A-TSN board

2019-07-25 Thread Vladimir Oltean
On Thu, 25 Jul 2019 at 21:50, Joe Hershberger wrote: > > Hi Vladimir, > > https://patchwork.ozlabs.org/patch/1133867/ was applied to > http://git.denx.de/?p=u-boot/u-boot-net.git > > Thanks! > -Joe Thanks a lot, Joe! -Vladimir ___ U-Boot mailing list

Re: [U-Boot] [PATCH v3 0/9] NXP LS1021A-TSN Board

2019-07-24 Thread Vladimir Oltean
On Wed, 24 Jul 2019 at 21:56, Joe Hershberger wrote: > > On Wed, Jul 24, 2019 at 10:38 AM Vladimir Oltean wrote: > > > > On Tue, 23 Jul 2019 at 10:38, Joe Hershberger > > wrote: > > > > > > On Tue, Jul 23, 2019 at 1:08 AM Vladimir Oltean wrote: >

Re: [U-Boot] [PATCH v3 0/9] NXP LS1021A-TSN Board

2019-07-24 Thread Vladimir Oltean
On Tue, 23 Jul 2019 at 10:38, Joe Hershberger wrote: > > On Tue, Jul 23, 2019 at 1:08 AM Vladimir Oltean wrote: > > > > Hi Joe, > > > > On Tue, 23 Jul 2019 at 03:15, Joe Hershberger > > wrote: > > > > > > On Thu, Jul 18, 2019 at 4:33 PM

Re: [U-Boot] [PATCH v3 0/9] NXP LS1021A-TSN Board

2019-07-23 Thread Vladimir Oltean
Hi Joe, On Tue, 23 Jul 2019 at 03:15, Joe Hershberger wrote: > > On Thu, Jul 18, 2019 at 4:33 PM Vladimir Oltean wrote: > > > > This patchset adds initial support for the NXP LS1021A-TSN board, > > an evaluation platform built in partnership with VVDN/Argonboards >

[U-Boot] [PATCH v3 7/9] arm: ls1021atwr: Convert to use driver model TSEC driver

2019-07-18 Thread Vladimir Oltean
From: Bin Meng Now that we have added driver model support to the TSEC driver, convert ls1021atwr board to use it. This depends on previous DM series for ls1021atwr: http://patchwork.ozlabs.org/patch/561855/ Signed-off-by: Bin Meng Signed-off-by: Vladimir Oltean Acked-by: Joe Hershberger

[U-Boot] [PATCH v3 8/9] configs: ls1021atwr: Fix distro_bootcmd for QSPI boot

2019-07-18 Thread Vladimir Oltean
Due to a typo, "run qspi_bootcmd" and "env exists secureboot" got concatenated instead of being separated by a semicolon. Signed-off-by: Vladimir Oltean Reviewed-by: Bin Meng --- Changes from v2: None. Changes from v1: None. include/configs/ls1021atwr.h | 2 +- 1 file

[U-Boot] [PATCH v3 6/9] net: tsec: Change compatible strings to match Linux

2019-07-18 Thread Vladimir Oltean
ndings: Describe Freescale TSEC ethernet controller") Signed-off-by: Vladimir Oltean Reviewed-by: Bin Meng --- Changes from v2: None. Changes from v1: Patch is new. doc/device-tree-bindings/net/fsl-tsec-phy.txt | 4 ++-- drivers/net/tsec.c| 2 +- 2 files

[U-Boot] [PATCH v3 5/9] net: tsec: Common handling of MAC station address for DM_ETH

2019-07-18 Thread Vladimir Oltean
In tsec_init, the MAC address is retrieved from 2 different structures depending on whether DM_ETH is enabled or not. But since the field name is the same inside both structures, we can conditionally define the structure of the correct type and simplify the assignments. Signed-off-by: Vladimir

[U-Boot] [PATCH v3 9/9] Add support for the NXP LS1021A-TSN board

2019-07-18 Thread Vladimir Oltean
Signed-off-by: Changming Huang Signed-off-by: Vladimir Oltean [Vladimir] Code taken from https://github.com/openil/u-boot (which itself is mostly copied from ls1021a-iot) and adapted with the following changes: - Add a008850 errata workaround - Converted eTSEC, MMC to DM to avoid all build

[U-Boot] [PATCH v3 3/9] net: tsec: Reverse Christmas tree notation

2019-07-18 Thread Vladimir Oltean
This is a cosmetic patch that reorders variable definitions in the inverse order of their line length, where possible. Signed-off-by: Vladimir Oltean Acked-by: Joe Hershberger Reviewed-by: Bin Meng --- Changes from v2: None. Changes from v1: None. drivers/net/tsec.c | 10 +- 1

[U-Boot] [PATCH v3 2/9] net: tsec: Fix offset of MDIO registers for DM_ETH

2019-07-18 Thread Vladimir Oltean
, MDIO_MIIMADD, MDIO_MIIMCON, MDIO_MIIMSTAT) which start at the 0x520 offset. So shift the DT-defined register map by the offset of MDIO_MIIMCFG when mapping the MDIO bus registers. Signed-off-by: Vladimir Oltean Acked-by: Joe Hershberger --- Changes from v2: None. Changes from v1: None. drivers

[U-Boot] [PATCH v3 1/9] net: tsec: Refactor the readout of the tbi-handle property

2019-07-18 Thread Vladimir Oltean
The point of this patch is to eliminate the use of the locally-defined "reg" variable (which interferes with next patch) and simplify the fallback to the default CONFIG_SYS_TBIPA_VALUE in case "tbi-handle" is missing. Signed-off-by: Vladimir Oltean Acked-by: Joe Hershberg

[U-Boot] [PATCH v3 0/9] NXP LS1021A-TSN Board

2019-07-18 Thread Vladimir Oltean
eng (1): arm: ls1021atwr: Convert to use driver model TSEC driver Jianchao Wang (1): Add support for the NXP LS1021A-TSN board Vladimir Oltean (7): net: tsec: Refactor the readout of the tbi-handle property net: tsec: Fix offset of MDIO registers for DM_ETH net: tsec: Reverse Christmas tree no

[U-Boot] [PATCH v3 4/9] net: tsec: Make errors visible

2019-07-18 Thread Vladimir Oltean
This replaces debug() calls with printf() so that it is immediately obvious from the console that something is wrong. Signed-off-by: Vladimir Oltean Acked-by: Joe Hershberger Reviewed-by: Bin Meng --- Changes from v2: None. Changes from v1: None. drivers/net/tsec.c | 8 1 file

Re: [U-Boot] [PATCH 2/8] net: tsec: Fix offset of MDIO registers for DM_ETH

2019-07-16 Thread Vladimir Oltean
Hi Bin, On Tue, 16 Jul 2019 at 04:19, Bin Meng wrote: > > Hi Vladimir, > > On Tue, Jul 16, 2019 at 6:00 AM Vladimir Oltean wrote: > > > > Hi Joe, > > > > On Mon, 15 Jul 2019 at 21:00, Joe Hershberger > > wrote: > > > > > > On

Re: [U-Boot] [PATCH 8/8] Add support for the NXP LS1021A-TSN board

2019-07-15 Thread Vladimir Oltean
On Tue, 16 Jul 2019 at 01:20, Joe Hershberger wrote: > > On Mon, Jul 15, 2019 at 4:57 PM Vladimir Oltean wrote: > > > > Hi Joe, > > > > On Mon, 15 Jul 2019 at 22:17, Joe Hershberger > > wrote: > > > > > > On Sun, Jun 23, 2019 at 12:53

Re: [U-Boot] [PATCH 2/8] net: tsec: Fix offset of MDIO registers for DM_ETH

2019-07-15 Thread Vladimir Oltean
Hi Joe, On Mon, 15 Jul 2019 at 21:00, Joe Hershberger wrote: > > On Sun, Jun 23, 2019 at 12:51 PM Vladimir Oltean wrote: > > > > By convention, the eTSEC MDIO controller nodes are defined in DT at > > 0x2d24000 and 0x2d5, but actually U-boot does not touch t

Re: [U-Boot] [PATCH 8/8] Add support for the NXP LS1021A-TSN board

2019-07-15 Thread Vladimir Oltean
Hi Joe, On Mon, 15 Jul 2019 at 22:17, Joe Hershberger wrote: > > On Sun, Jun 23, 2019 at 12:53 PM Vladimir Oltean wrote: > > > > From: Jianchao Wang > > > > The LS1021A-TSN is a development board built by VVDN/Argonboards in > > partnership with NXP.

Re: [U-Boot] [PATCH 8/8] Add support for the NXP LS1021A-TSN board

2019-07-15 Thread Vladimir Oltean
On Mon, 15 Jul 2019 at 05:18, Bin Meng wrote: > > Hi Vladimir, > > On Mon, Jul 15, 2019 at 4:04 AM Vladimir Oltean wrote: > > > > Hi Bin, > > > > On Sat, 13 Jul 2019 at 08:05, Bin Meng wrote: > > > > > > Hi Vladimir, > > &g

Re: [U-Boot] [PATCH 8/8] Add support for the NXP LS1021A-TSN board

2019-07-14 Thread Vladimir Oltean
Hi Bin, On Sat, 13 Jul 2019 at 08:05, Bin Meng wrote: > > Hi Vladimir, > > On Mon, Jun 24, 2019 at 1:50 AM Vladimir Oltean wrote: > > > > From: Jianchao Wang > > > > The LS1021A-TSN is a development board built by VVDN/Argonboards in > > partnership

Re: [U-Boot] [PATCH 6/8] arm: ls1021atwr: Convert to use driver model TSEC driver

2019-07-14 Thread Vladimir Oltean
On Sun, 14 Jul 2019 at 04:55, Bin Meng wrote: > > Hi Vladimir, > > On Sat, Jul 13, 2019 at 5:39 PM Vladimir Oltean wrote: > > > > Hi Joe, > > > > On Fri, 12 Jul 2019 at 23:46, Joe Hershberger > > wrote: > > > > > > On

[U-Boot] [PATCH v2 6/9] net: tsec: Change compatible strings to match Linux

2019-07-13 Thread Vladimir Oltean
ndings: Describe Freescale TSEC ethernet controller") Signed-off-by: Vladimir Oltean --- Changes from v1: Patch is new. doc/device-tree-bindings/net/fsl-tsec-phy.txt | 4 ++-- drivers/net/tsec.c| 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --

[U-Boot] [PATCH v2 8/9] configs: ls1021atwr: Fix distro_bootcmd for QSPI boot

2019-07-13 Thread Vladimir Oltean
Due to a typo, "run qspi_bootcmd" and "env exists secureboot" got concatenated instead of being separated by a semicolon. Signed-off-by: Vladimir Oltean Reviewed-by: Bin Meng --- Changes from v1: None. include/configs/ls1021atwr.h | 2 +- 1 file changed, 1 insertion(+),

[U-Boot] [PATCH v2 4/9] net: tsec: Make errors visible

2019-07-13 Thread Vladimir Oltean
This replaces debug() calls with printf() so that it is immediately obvious from the console that something is wrong. Signed-off-by: Vladimir Oltean Acked-by: Joe Hershberger Reviewed-by: Bin Meng --- Changes from v1: None. drivers/net/tsec.c | 8 1 file changed, 4 insertions(+), 4

[U-Boot] [PATCH v2 7/9] arm: ls1021atwr: Convert to use driver model TSEC driver

2019-07-13 Thread Vladimir Oltean
From: Bin Meng Now that we have added driver model support to the TSEC driver, convert ls1021atwr board to use it. This depends on previous DM series for ls1021atwr: http://patchwork.ozlabs.org/patch/561855/ Signed-off-by: Bin Meng Signed-off-by: Vladimir Oltean [Vladimir] Made

[U-Boot] [PATCH v2 9/9] Add support for the NXP LS1021A-TSN board

2019-07-13 Thread Vladimir Oltean
Signed-off-by: Changming Huang Signed-off-by: Vladimir Oltean [Vladimir] Code taken from https://github.com/openil/u-boot (which itself is mostly copied from ls1021a-iot) and adapted with the following changes: - Add a008850 errata workaround - Converted eTSEC, MMC to DM to avoid all build

[U-Boot] [PATCH v2 5/9] net: tsec: Common handling of MAC station address for DM_ETH

2019-07-13 Thread Vladimir Oltean
In tsec_init, the MAC address is retrieved from 2 different structures depending on whether DM_ETH is enabled or not. But since the field name is the same inside both structures, we can conditionally define the structure of the correct type and simplify the assignments. Signed-off-by: Vladimir

[U-Boot] [PATCH v2 2/9] net: tsec: Fix offset of MDIO registers for DM_ETH

2019-07-13 Thread Vladimir Oltean
, MDIO_MIIMADD, MDIO_MIIMCON, MDIO_MIIMSTAT) which start at the 0x520 offset. So shift the DT-defined register map by the offset of MDIO_MIIMCFG when mapping the MDIO bus registers. Signed-off-by: Vladimir Oltean --- Changes from v1: None. drivers/net/tsec.c | 13 +++-- include/tsec.h

[U-Boot] [PATCH v2 3/9] net: tsec: Reverse Christmas tree notation

2019-07-13 Thread Vladimir Oltean
This is a cosmetic patch that reorders variable definitions in the inverse order of their line length, where possible. Signed-off-by: Vladimir Oltean Acked-by: Joe Hershberger Reviewed-by: Bin Meng --- Changes from v1: None. drivers/net/tsec.c | 10 +- 1 file changed, 5 insertions

[U-Boot] [PATCH v2 0/9] NXP LS1021A-TSN Board

2019-07-13 Thread Vladimir Oltean
eng (1): arm: ls1021atwr: Convert to use driver model TSEC driver Jianchao Wang (1): Add support for the NXP LS1021A-TSN board Vladimir Oltean (7): net: tsec: Refactor the readout of the tbi-handle property net: tsec: Fix offset of MDIO registers for DM_ETH net: tsec: Reverse Christmas tree no

[U-Boot] [PATCH v2 1/9] net: tsec: Refactor the readout of the tbi-handle property

2019-07-13 Thread Vladimir Oltean
The point of this patch is to eliminate the use of the locally-defined "reg" variable (which interferes with next patch) and simplify the fallback to the default CONFIG_SYS_TBIPA_VALUE in case "tbi-handle" is missing. Signed-off-by: Vladimir Oltean Acked-by: Joe Hershberg

Re: [U-Boot] [PATCH] cmd: mdio: prevent data abort when no mdio bus is found

2019-07-13 Thread Vladimir Oltean
On Fri, 12 Jul 2019 at 21:58, Simon Goldschmidt wrote: > > Calling 'mdio read ...' currently leads to a data abort when no mdio > bus is found. > > To fix this, check if 'bus' is a valid pointer before accessing it. > > Signed-off-by: Simon Goldschmidt > --- Tested-by: V

Re: [U-Boot] [PATCH 2/8] net: tsec: Fix offset of MDIO registers for DM_ETH

2019-07-13 Thread Vladimir Oltean
Hi Bin, On Sat, 13 Jul 2019 at 07:55, Bin Meng wrote: > > Hi Vladimir, > > On Mon, Jun 24, 2019 at 1:50 AM Vladimir Oltean wrote: > > > > By convention, the eTSEC MDIO controller nodes are defined in DT at > > 0x2d24000 and 0x2d5, but actually U-boot does

Re: [U-Boot] [PATCH 6/8] arm: ls1021atwr: Convert to use driver model TSEC driver

2019-07-13 Thread Vladimir Oltean
Hi Joe, On Fri, 12 Jul 2019 at 23:46, Joe Hershberger wrote: > > On Sun, Jun 23, 2019 at 12:53 PM Vladimir Oltean wrote: > > > > From: Bin Meng > > > > Now that we have added driver model support to the TSEC driver, > > convert ls1021atwr board to use it.

[U-Boot] [PATCH 4/8] net: tsec: Make errors visible

2019-06-23 Thread Vladimir Oltean
This replaces debug() calls with printf() so that it is immediately obvious from the console that something is wrong. Signed-off-by: Vladimir Oltean --- drivers/net/tsec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c index

[U-Boot] [PATCH 6/8] arm: ls1021atwr: Convert to use driver model TSEC driver

2019-06-23 Thread Vladimir Oltean
= "disabled";' for all Ethernet ports in ls1021a.dtsi - Fixed the confusion between the SGMII/TBI PCS for enet0 and enet1 - a mistake ported over from Linux. Each SGMII PCS lies on the private MDIO bus of the interface (and the RGMII enet2 has no SGMII PCS). Signed-off-by: Vladimir Oltean

[U-Boot] [PATCH 5/8] net: tsec: Common handling of MAC station address for DM_ETH

2019-06-23 Thread Vladimir Oltean
In tsec_init, the MAC address is retrieved from 2 different structures depending on whether DM_ETH is enabled or not. But since the field name is the same inside both structures, we can conditionally define the structure of the correct type and simplify the assignments. Signed-off-by: Vladimir

[U-Boot] [PATCH 7/8] configs: ls1021atwr: Fix distro_bootcmd for QSPI boot

2019-06-23 Thread Vladimir Oltean
Due to a typo, "run qspi_bootcmd" and "env exists secureboot" got concatenated instead of being separated by a semicolon. Signed-off-by: Vladimir Oltean --- include/configs/ls1021atwr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/configs/ls

[U-Boot] [PATCH 3/8] net: tsec: Reverse Christmas tree notation

2019-06-23 Thread Vladimir Oltean
This is a cosmetic patch that reorders variable definitions in the inverse order of their line length, where possible. Signed-off-by: Vladimir Oltean --- drivers/net/tsec.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c

[U-Boot] [PATCH 8/8] Add support for the NXP LS1021A-TSN board

2019-06-23 Thread Vladimir Oltean
feature, including support for extlinux.conf - Added defconfig for QSPI boot - Added the board/freescale/ls1021atsn/README.rst for initial setup Signed-off-by: Vladimir Oltean --- arch/arm/Kconfig | 14 + arch/arm/dts/Makefile | 2 +- arch/arm

[U-Boot] [PATCH 2/8] net: tsec: Fix offset of MDIO registers for DM_ETH

2019-06-23 Thread Vladimir Oltean
, MDIO_MIIMADD, MDIO_MIIMCON, MDIO_MIIMSTAT) which start at the 0x520 offset. So shift the DT-defined register map by the offset of MDIO_MIIMCFG when mapping the MDIO bus registers. Signed-off-by: Vladimir Oltean --- drivers/net/tsec.c | 13 +++-- include/tsec.h | 4 +++- 2 files changed

[U-Boot] [PATCH 0/8] NXP LS1021A-TSN Board

2019-06-23 Thread Vladimir Oltean
eng (1): arm: ls1021atwr: Convert to use driver model TSEC driver Jianchao Wang (1): Add support for the NXP LS1021A-TSN board Vladimir Oltean (6): net: tsec: Refactor the readout of the tbi-handle property net: tsec: Fix offset of MDIO registers for DM_ETH net: tsec: Reverse Christmas tree no

[U-Boot] [PATCH 1/8] net: tsec: Refactor the readout of the tbi-handle property

2019-06-23 Thread Vladimir Oltean
The point of this patch is to eliminate the use of the locally-defined "reg" variable (which interferes with next patch) and simplify the fallback to the default CONFIG_SYS_TBIPA_VALUE in case "tbi-handle" is missing. Signed-off-by: Vladimir Oltean --- drivers/net/tsec.c | 1

Re: [U-Boot] Default environment file

2019-06-12 Thread Vladimir Oltean
On Wed, 12 Jun 2019 at 19:30, Stefano Babic wrote: > > Hi Tom, > > Hi everybody, > > On 12/06/19 16:16, Tom Rini wrote: > > On Wed, Jun 12, 2019 at 10:43:26AM +0200, Stefano Babic wrote: > >> Hi Pascal, > >> > >> On 12/06/19 10:20, Linder Pascal wrote: > >>> Hi everyone, > >>> > >>> > >>> I am

[U-Boot] [PATCH] cmd: mdio: Fix access to arbitrary PHY addresses

2019-05-29 Thread Vladimir Oltean
ble for them, but at least they will be accessible again without crashing the system. Fixes: e55047ec51a6 ("cmd: mdio: Switch to generic helpers when accessing the registers") Reported-by: Alex Marginean Signed-off-by: Vladimir Oltean --- cmd/mdio.c | 9 +++-- 1 file changed, 7 insertions(

Re: [U-Boot] Reading from an arbitrary address over MDIO no longer works

2019-05-29 Thread Vladimir Oltean
On 29.05.2019 18:00, Alex Marginean wrote: > On 5/29/2019 5:19 PM, Vladimir Oltean wrote: >> On 29.05.2019 15:27, Alex Marginean wrote: >>> >>> Hi Carlo, everyone, >>> >>> I'm doing some MDIO work on a freescale/NXP platform and I bumped into >>&g

Re: [U-Boot] Reading from an arbitrary address over MDIO no longer works

2019-05-29 Thread Vladimir Oltean
On 29.05.2019 15:27, Alex Marginean wrote: > > Hi Carlo, everyone, > > I'm doing some MDIO work on a freescale/NXP platform and I bumped into > errors with this command: > => mdio r emdio#3 5 3 > Reading from bus emdio#3 > "Synchronous Abort" handler, esr 0x860e > elr: 862b8000 lr :

Re: [U-Boot] Pull request: u-boot-net.git master

2019-05-09 Thread Vladimir Oltean
On 09.05.2019 02:05, Vladimir Oltean wrote: > On 5/9/19 1:55 AM, Tom Rini wrote: >> On Wed, May 08, 2019 at 10:52:28PM +, Vladimir Oltean wrote: >>> On 5/9/19 1:48 AM, Tom Rini wrote: >>>> On Wed, May 08, 2019 at 10:45:50PM +, Vladimir Oltean wrote: >>&

Re: [U-Boot] Pull request: u-boot-net.git master

2019-05-08 Thread Vladimir Oltean
On 5/9/19 1:55 AM, Tom Rini wrote: > On Wed, May 08, 2019 at 10:52:28PM +0000, Vladimir Oltean wrote: >> On 5/9/19 1:48 AM, Tom Rini wrote: >>> On Wed, May 08, 2019 at 10:45:50PM +0000, Vladimir Oltean wrote: >>>> On 5/9/19 1:42 AM, Tom Rini wrote: >>>>

Re: [U-Boot] Pull request: u-boot-net.git master

2019-05-08 Thread Vladimir Oltean
On 5/9/19 1:48 AM, Tom Rini wrote: > On Wed, May 08, 2019 at 10:45:50PM +0000, Vladimir Oltean wrote: >> On 5/9/19 1:42 AM, Tom Rini wrote: >>> On Wed, May 08, 2019 at 10:40:57PM +0000, Vladimir Oltean wrote: >>>> On 5/9/19 1:24 AM, Joe Hershberger wrote: >>&g

Re: [U-Boot] [EXT] Re: Pull request: u-boot-net.git master

2019-05-08 Thread Vladimir Oltean
RM: k2g-ice: Add pinmux support for rgmii interface >> >> Pankaj Bansal (1): >>drivers: net: ldpaa_eth: fix resource leak >> >> Siva Durga Prasad Paladugu (2): >> net: phy: Reloc next and prev pointers inside phy_drivers >>net: phy: Fix

Re: [U-Boot] Pull request: u-boot-net.git master

2019-05-08 Thread Vladimir Oltean
On 5/9/19 1:42 AM, Tom Rini wrote: > On Wed, May 08, 2019 at 10:40:57PM +0000, Vladimir Oltean wrote: >> On 5/9/19 1:24 AM, Joe Hershberger wrote: >>> On Tue, May 7, 2019 at 5:15 PM Joe Hershberger >>> wrote: >>>> >>>> H

Re: [U-Boot] [PATCH v5 3/3] cmd: mdio: Switch to generic helpers when accessing the registers

2019-02-15 Thread Vladimir Oltean
On 2/12/19 2:20 PM, Vladimir Oltean wrote: > On 08.02.2019 19:26, Carlo Caione wrote: >> Switch to use the generic helpers to access the MMD registers so that we >> can used the same command also for C45 PHYs, C22 PHYs with direct and >> indirect access and PHYs implementing a

Re: [U-Boot] [PATCH v5 3/3] cmd: mdio: Switch to generic helpers when accessing the registers

2019-02-12 Thread Vladimir Oltean
On 08.02.2019 19:26, Carlo Caione wrote: > Switch to use the generic helpers to access the MMD registers so that we > can used the same command also for C45 PHYs, C22 PHYs with direct and > indirect access and PHYs implementing a custom way to access the > registers. > > Signed-off-by: Carlo

Re: [U-Boot] [PATCH v4 3/3] cmd: mdio: Add new parameter to access MMD PHY registers

2019-02-06 Thread Vladimir Oltean
ave a few boards with various C45 PHYs that I can volunteer to test your v5 patchset on, and report back if I see any glaring problems. > -- > Carlo Caione > On 2/6/19 5:31 AM, Joe Hershberger wrote: > On Tue, Feb 5, 2019 at 7:37 PM Vladimir Oltean wrote: >> Just my 2c. Eithe

Re: [U-Boot] [PATCH v4 3/3] cmd: mdio: Add new parameter to access MMD PHY registers

2019-02-05 Thread Vladimir Oltean
On 2/6/19 12:10 AM, Joe Hershberger wrote: > On Tue, Feb 5, 2019 at 9:20 AM Carlo Caione wrote: >> >> On 05/02/2019 00:15, Joe Hershberger wrote: >>> On Mon, Feb 4, 2019 at 5:39 PM Vladimir Oltean >>> wrote: >> >> /cut >>>> Which b

Re: [U-Boot] [PATCH v4 3/3] cmd: mdio: Add new parameter to access MMD PHY registers

2019-02-04 Thread Vladimir Oltean
On 2/5/19 1:28 AM, Joe Hershberger wrote: > On Fri, Jan 25, 2019 at 7:12 AM Vladimir Oltean > wrote: >> >> On 25.01.2019 12:12, Carlo Caione wrote: >>> On 24/01/2019 20:48, Vladimir Oltean wrote: >>>> On 1/24/19 10:19 PM, Carlo Caione wrote: >>&

[U-Boot] [PATCH v3 6/6] net: phy: ar803x: Clarify the intention of ar8021_config

2019-01-25 Thread Vladimir Oltean
-by: Vladimir Oltean --- Changes in v3: * Patch added in this version. Addresses the previous comments on patch 3/3 from v2. drivers/net/phy/atheros.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c index

[U-Boot] [PATCH v3 4/6] net: phy: ar803x: Explicitly disable RGMII delays

2019-01-25 Thread Vladimir Oltean
To eliminate any doubts about the out-of-reset value of the PHY, that the driver previously relied on. Signed-off-by: Vladimir Oltean --- Changes in v3: * Patch added in this version. drivers/net/phy/atheros.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/phy

[U-Boot] [PATCH v3 5/6] net: phy: ar803x: Clarify the configuration of the CLK_25M output pin

2019-01-25 Thread Vladimir Oltean
Also take the opportunity to use the phy_read_mmd and phy_write_mmd convenience functions. Signed-off-by: Vladimir Oltean --- Changes in v3: * Patch added in this version. Partially squashed with patch 1/3 from v2, since addressing the comments on that patch gave its commit message a new

[U-Boot] [PATCH v3 2/6] net: phy: ar803x: Make RGMII Tx delays actually configurable for AR8035

2019-01-25 Thread Vladimir Oltean
ter this patch, only those who define the interface as RGMII_TXID or RGMII_ID will. This is to be expected, but will nonetheless break the setups of those who didn't know they rely on Tx delay implicitly. Signed-off-by: Vladimir Oltean --- Changes in v3: * Patch added in this version. drivers/n

[U-Boot] [PATCH v3 3/6] net: phy: ar803x: Use common functions for RGMII internal delays

2019-01-25 Thread Vladimir Oltean
Signed-off-by: Vladimir Oltean --- Changes in v3: * Removed access to magic register 0x5 which turned out to be duplicated code with unwanted consequences. Broke that out into separate patch (2/6). drivers/net/phy/atheros.c | 69 --- 1 file

[U-Boot] [PATCH v3 1/6] net: phy: ar803x: Address packet drops at low traffic rate due to SmartEEE feature

2019-01-25 Thread Vladimir Oltean
% packet loss, time 146378ms Signed-off-by: Vladimir Oltean Acked-by: Joe Hershberger --- Changes in v3: * Got rid of magic numbers. drivers/net/phy/Kconfig | 21 + drivers/net/phy/atheros.c | 26 ++ 2 files changed, 47 insertions(+) diff --git

[U-Boot] [PATCH v3 0/6] net: phy: Allow disabling SmartEEE for Atheros PHYs

2019-01-25 Thread Vladimir Oltean
tions" into new "net: phy: ar803x: Clarify the configuration of the CLK_25M output pin" patch * Fixed unconditional enabling of RGMII TxID for AR8035 Vladimir Oltean (6): net: phy: ar803x: Address packet drops at low traffic rate due to SmartEEE feature net: phy: ar803x:

Re: [U-Boot] [PATCH v4 3/3] cmd: mdio: Add new parameter to access MMD PHY registers

2019-01-25 Thread Vladimir Oltean
On 25.01.2019 12:12, Carlo Caione wrote: > On 24/01/2019 20:48, Vladimir Oltean wrote: >> On 1/24/19 10:19 PM, Carlo Caione wrote: >>> On 24/01/2019 20:12, Vladimir Oltean wrote: >>>> >> >> I can't completely answer that, TBH I don't even know w

Re: [U-Boot] [PATCH v2 1/3] net: phy: ar803x: Use phy_read_mmd and phy_write_mmd functions

2019-01-24 Thread Vladimir Oltean
On 1/24/19 8:16 AM, Joe Hershberger wrote: > On Wed, Jan 23, 2019 at 5:46 PM Vladimir Oltean > wrote: >> >> Signed-off-by: Vladimir Oltean >> --- >> Changes in v2: >> * Patch added in this version. >> >> drivers/net/phy/atheros.c | 8

Re: [U-Boot] [PATCH v2 3/3] net: phy: ar803x: Use common functions for RGMII internal delays

2019-01-24 Thread Vladimir Oltean
On 1/24/19 8:20 AM, Joe Hershberger wrote: > On Wed, Jan 23, 2019 at 5:47 PM Vladimir Oltean > wrote: >> static int ar8021_config(struct phy_device *phydev) >> { >> phy_write(phydev, MDIO_DEVAD_NONE, 0x00, 0x1200); >> - phy_write(phyde

Re: [U-Boot] [PATCH v4 3/3] cmd: mdio: Add new parameter to access MMD PHY registers

2019-01-24 Thread Vladimir Oltean
On 1/24/19 10:01 PM, Carlo Caione wrote: > On 24/01/2019 19:56, Vladimir Oltean wrote: >> On 1/24/19 10:56 AM, Carlo Caione wrote: > >> It works for me, but I do have a question. >> Is there any limitation preventing you to add this functionality via the >> st

Re: [U-Boot] [PATCH v4 3/3] cmd: mdio: Add new parameter to access MMD PHY registers

2019-01-24 Thread Vladimir Oltean
On 1/24/19 10:08 PM, Carlo Caione wrote: > On 24/01/2019 20:04, Vladimir Oltean wrote: >> On 1/24/19 10:01 PM, Carlo Caione wrote: >>> On 24/01/2019 19:56, Vladimir Oltean wrote: >>>> On 1/24/19 10:56 AM, Carlo Caione wrote: >> >> No, I mean instead of

Re: [U-Boot] [PATCH v4 3/3] cmd: mdio: Add new parameter to access MMD PHY registers

2019-01-24 Thread Vladimir Oltean
On 1/24/19 10:19 PM, Carlo Caione wrote: > On 24/01/2019 20:12, Vladimir Oltean wrote: >> >> I still think I haven't successfully made my point. >> If "mdio read 3.1" is a C45-only thing, "mdio read 1" is a C22-only >> thing, then why do y

Re: [U-Boot] [PATCH v4 3/3] cmd: mdio: Add new parameter to access MMD PHY registers

2019-01-24 Thread Vladimir Oltean
On 1/24/19 10:56 AM, Carlo Caione wrote: > Two new parameters (rmmd and wmmd) are added to allow the `mdio` command > to access the content of the MMD PHY registers. > > Signed-off-by: Carlo Caione > Acked-by: Joe Hershberger > --- > cmd/mdio.c | 52

[U-Boot] [PATCH v2 3/3] net: phy: ar803x: Use common functions for RGMII internal delays

2019-01-23 Thread Vladimir Oltean
Signed-off-by: Vladimir Oltean --- Changes in v2: * Patch added in this version. drivers/net/phy/atheros.c | 76 --- 1 file changed, 45 insertions(+), 31 deletions(-) diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c index 750c11b

[U-Boot] [PATCH v2 1/3] net: phy: ar803x: Use phy_read_mmd and phy_write_mmd functions

2019-01-23 Thread Vladimir Oltean
Signed-off-by: Vladimir Oltean --- Changes in v2: * Patch added in this version. drivers/net/phy/atheros.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c index 3783d15..b4066e3 100644 --- a/drivers/net/phy

[U-Boot] [PATCH v2 0/3] net: phy: allow disabling SmartEEE for Atheros PHYs

2019-01-23 Thread Vladimir Oltean
Changes in v2: * Removed patch 1/2 (promote phy_{read,write}_mmd_indirect from ti.c to generic code) * Adapted to PHY API changes introduced by Carlo Caione * Cleaned up Atheros PHY driver to remove duplicated code and use macros where possible Vladimir Oltean (3): net: phy: ar803x: Use

[U-Boot] [PATCH v2 2/3] net: phy: ar803x: Address packet drops at low traffic rate due to SmartEEE feature

2019-01-23 Thread Vladimir Oltean
, 144 received, 0% packet loss, time 146378ms Signed-off-by: Vladimir Oltean Acked-by: Joe Hershberger --- Changes in v2: * Adapted to use phy_read_mmd and phy_write_mmd functions. drivers/net/phy/Kconfig | 21 + drivers/net/phy/atheros.c | 26 ++ 2

Re: [U-Boot] [PATCH u-boot 1/2] net: phy: Add support for accessing MMD PHY registers

2019-01-23 Thread Vladimir Oltean
On 23.01.2019 11:59, Carlo Caione wrote: > On 23/01/19 00:04, Joe Hershberger wrote: >> >> If we have to override the access then probably so. Maybe it would >> make more sense to have a v2 from you that removes the duplicate code >> from the ti phy driver and then have Vlad's smartEEE patch be

[U-Boot] [PATCH 1/2] net: phy: promote phy_{read, write}_mmd_indirect from ti.c to generic code

2018-12-18 Thread Vladimir Oltean
* These are convenience functions for accessing PHY MMD registers through clause 22 (indirectly through registers 0xD and 0xE), and are exported in the Linux phylib as well. Signed-off-by: Vladimir Oltean --- drivers/net/phy/phy.c | 68 + drivers

[U-Boot] [PATCH 0/2] net: phy: allow disabling SmartEEE for Atheros PHYs

2018-12-18 Thread Vladimir Oltean
The first patch moves the implementations of phy_read_mmd_indirect and phy_write_mmd_indirect from the TI PHY driver into the core PHY driver code, and the second patch makes use of these functions to allow users to disable SmartEEE. Vladimir Oltean (2): net: phy: promote phy_{read,write

[U-Boot] [PATCH 2/2] net: phy: at803x: Address packet drops at low traffic rate due to SmartEEE feature

2018-12-18 Thread Vladimir Oltean
, 144 received, 0% packet loss, time 146378ms Signed-off-by: Vladimir Oltean --- drivers/net/phy/Kconfig | 21 + drivers/net/phy/atheros.c | 28 2 files changed, 49 insertions(+) diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig