Re: [PATCH v10 3/9] env: Allow U-Boot scripts to be placed in a .env file

2021-10-22 Thread Wolfgang Denk
ve line should actually set the environment variable "maximum\+" to "value". Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax:

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-22 Thread Wolfgang Denk
e character. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Q: How many IBM CPU's does it tak

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-22 Thread Wolfgang Denk
ike spaces before the = though. It doesn't match the 'print' > output (which has no space) and it is confusing: env print also does not add any spaces after the '='. > I think we need strict rules so it is easy for people to get exactly > the env they want. Strict rules, proper documentati

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-21 Thread Wolfgang Denk
oils down that the file format should be properly defined and have a clear syntax description. Apparently the "=\0" format as used in U-Boot persistent storage should not be taken literally here. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolf

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-21 Thread Wolfgang Denk
ables". In which way is it worse? For esthetic reasons? I confirm that '+=' looks better. But '+=" is technically broken. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell,

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-21 Thread Wolfgang Denk
uot; instead of "+=" as append operator do not require such restictions. Thus, and only for the restictions on variable names: Naked-by: Wolfgang Denk Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirc

Re: [PATCH v8 4/8] env: Allow U-Boot scripts to be placed in a .env file

2021-10-21 Thread Wolfgang Denk
n which way is "+=" easier to parse than "=+"? The only extension you have to make is for the "=[^+]" case to check the first charater of the value: if it is a backslash, then ignore it. This has zero influence on doing this manually or automatic. Best regards, Wol

Re: [PATCH v8 4/8] env: Allow U-Boot scripts to be placed in a .env file

2021-10-21 Thread Wolfgang Denk
s / side-effects / position in parsing. I fully agree that "+=" would be nicer. But it has issues, which "=+" does not have. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 G

Re: [PATCH v8 4/8] env: Allow U-Boot scripts to be placed in a .env file

2021-10-21 Thread Wolfgang Denk
mewhat reasonable way, and it does not need to place new restrictions on variable names. > is very confusing. Is it? > Since people will be converting their out-of-tree scripts anyway, they > can check for this sort of madness at the time. There should be no > problem. Agreed. There shoul

Re: [PATCH v8 4/8] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Wolfgang Denk
escape rules, for example: var=fredassigns var=+fred appends "fred" var=\+fred assignes the value "+fred" var=++fred appends "+fred" Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Man

Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Wolfgang Denk
a -> gcc -E bar.c # 0 "bar.c" # 0 "" # 0 "" # 1 "/usr/include/stdc-predef.h" 1 3 4 # 0 "" 2 # 1 "bar.c" fred\+=aaa I do not see this problem... Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Directo

Re: [PATCH v8 4/8] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Wolfgang Denk
ld be also more allowing for variations in white space, so that "=" could also be written as " = ". which in turn would allow for foo+ = bar vs. foo += bar . Just my 2ยข... Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managi

Re: [PATCH v8 4/8] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Wolfgang Denk
alid > environment variables, if this was written in Python say, would we have > this problem? A classic tool would be lex ... Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenz

Re: [PATCH v8 4/8] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Wolfgang Denk
ould omit this as it does not provide any relevant information here, and in addition it is misleading as it could be interpreted that such characters are only legal at the start of the variable name. But you can do: => setenv .-^-. foo => printenv .-^-. .-^-.=foo Best regards, Wolfga

Re: [PATCH v8 0/8] env: Allow environment in text files

2021-10-19 Thread Wolfgang Denk
sing. This should be board//.env , right? But that's only the cover letter... Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142

Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Wolfgang Denk
etting the env you want > using #define > > My current motivation is to complete the CONFIG migration, now in its 8th > year. I fully understand your motivation and appreciate your efforts. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfga

Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Wolfgang Denk
yes, your awk script cannot handle this situation, but I tend to belive the fix is in a better parser than in placing restrictions on the input data. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82

Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-19 Thread Wolfgang Denk
r, baz+, etc, in their variable names, maybe we just document > that's not valid and move on? We cannot know what people have been using in their environemnts. Even for those boards that are in mainline, the environment settings used in real life are often totally different. Best regards, Wolfgang Denk -- DENX

Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-18 Thread Wolfgang Denk
right now but did I not also read about other restrictions to variable names, like they must noch begin with '_' when using this new tool? I feel it is wrong to place new restrictions on something that was constant for 21 years, just because our parser cannot parse it... Best regards, Wolfgang

Re: [PATCH v7 5/7] doc: Mention CONFIG_DEFAULT_ENV_FILE

2021-10-18 Thread Wolfgang Denk
uot;No prams or dogs or food being eaten!" I mean eating dogs is bad enough, but eating prams? ? ? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-669

Re: [PATCH v7 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-18 Thread Wolfgang Denk
ed in the commit message, not only in the code. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Command,

Re: [PATCH v7 0/7] env: Allow environment in text files

2021-10-18 Thread Wolfgang Denk
oard//.env , right? Reviewed-by: Wolfgang Denk Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de READ T

Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-18 Thread Wolfgang Denk
o\+=bar or foo+ = bar ? And please see also my comments about changing the autostart functionality for the user. > I haven't seen any positive comments to this series yet... Maybe many long-term users of U-Boot don't see the current situation as such a big problem? I have no idea. Best

Re: [PATCH v6 7/7] bootm: Tidy up use of autostart env var

2021-10-15 Thread Wolfgang Denk
d-off-by: Simon Glass > Suggested-by: Wolfgang Denk It should be noted that this commit changes the behaviour of U-Boot for "autostart" users, thus it has the potential of breaking existent systems. The problematic cases are in do_bootelf() [cmd/elf.c] and do_bootm_standalone() [commo

Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-15 Thread Wolfgang Denk
le in a board//env > directory called .env (or common.env if you want the same > environment for all boards). Argh... did you bother to read my comments? Apparently not. Thus: NAKed by: Wolfgang Denk I really think your fixed filename proposal does not work well in reality. The file name

Re: [PATCH v5 08/10] include/configs: apalis-imx8/verdin-imx8mm: rename kernel image variable

2021-10-09 Thread Wolfgang Denk
ting with modern scripts and does not break working > of earlier versions of boot.scr. Same comment as before: please document all changes, i. e. the FDT related changes. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, O

Re: [PATCH v4 08/10] include/configs: apalis-imx8/verdin-imx8mm: rename kernel image variable

2021-10-09 Thread Wolfgang Denk
ting with modern scripts and does not break working > of earlier versions of boot.scr. The patch also changes FST handling without mentioning it in the description. Please fix. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235

Re: [PATCH v5 3/5] env: Allow U-Boot scripts to be placed in a .env file

2021-10-06 Thread Wolfgang Denk
" does not fit either, as we have two "common" files. I wonder if there should rather be a Kconfig option so each board can select it's env file name; default would be ".env". what do you think? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director:

Re: [ANN] U-Boot v2021.10 released

2021-10-06 Thread Wolfgang Denk
ce.denx.de all te time, I just didn't look at the right place. See https://source.denx.de/u-boot/gitdm Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-669

Re: [PATCH v5 3/5] env: Allow U-Boot scripts to be placed in a .env file

2021-10-05 Thread Wolfgang Denk
t;#include board//env/common.env" in my .env files, your logic would trigger on the existence of the common.env file and ignore the .env files. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groe

Re: [ANN] U-Boot v2021.10 released

2021-10-05 Thread Wolfgang Denk
ver. It was not moved to source.denx.de I will fix this ASAP... Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w

Re: [ANN] U-Boot v2021.10 released

2021-10-05 Thread Wolfgang Denk
3 (1.6%) Intel3 (1.6%) ... Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-814

Re: [PATCH v5 4/5] env: Allow environment files to use the C preprocessor

2021-10-04 Thread Wolfgang Denk
he NUL characters. Adding artificial restrictions now just to enable your custom notation for appending seems not acceptable to me. You might want to chose a different notation or implement a proper parser instead. Thanks. Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director:

Re: [PATCH v5 3/5] env: Allow U-Boot scripts to be placed in a .env file

2021-10-04 Thread Wolfgang Denk
on.env if you want the same > environment for all boards). This should be no exclusive "or" here. If a common.env exists, it should be used for all boards, and if additionally one ore more .env files exist, these should ALSO be applied to the respective boards. Best regards, W

Re: [PATCH v5 2/5] doc: Move environment documentation to rST

2021-10-04 Thread Wolfgang Denk
gt; +When set to a value < 4095 the traffic over > +Ethernet is encapsulated/received over 802.1q > +VLAN tagged frames. Really? I can't see where "vlan" is actually used in the code. [I looked for it because I could not remember if the values is interpreted as decimal or

Re: [PATCH v2] cmd: ubi: add a command to swap volumes

2021-09-28 Thread Wolfgang Denk
ate. So if you think to use this for example for reliable software updates, then you have a big problem here. Or am I missing something? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell

Re: [PATCH] ARM: omap3_logic: Cleanup usage of MUX_VAL

2021-09-28 Thread Wolfgang Denk
ther lines. You might want to fix that, too, while we are at it? Reviewd-by: Wolfgang Denk Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-1

Re: Bug in board/logicpd/omap3som/omap3logic.h ???

2021-09-27 Thread Wolfgang Denk
p anything up. Most > > of the time it's not used with one either, from a quick grep. > > I am guessing it was left out by accident. I would not have > intentionally done that. I can submit a patch to make it consistent > if you want. Yes, it should be made xonsistent, please -

[PATCH 1/4] WS cleanup: remove trailing empty lines

2021-09-27 Thread Wolfgang Denk
Signed-off-by: Wolfgang Denk --- arch/arm/cpu/arm926ejs/cache.c| 1 - arch/arm/cpu/armv7/psci-common.c | 1 - arch/arm/cpu/armv8/hisilicon/pinmux.c | 2 -- arch/arm/cpu/armv8/xen/hypercall.S

[PATCH 3/4] WS cleanup: remove trailing white space

2021-09-27 Thread Wolfgang Denk
Signed-off-by: Wolfgang Denk --- Licenses/lgpl-2.0.txt | 2 +- Makefile | 4 ++-- arch/arm/include/asm/arch-am33xx/cpu.h| 2 +- arch/arm/lib/lib1funcs.S | 6 +++--- arch/xtensa/include/asm/arch-de212

[PATCH 2/4] WS cleanup: remove excessive empty lines

2021-09-27 Thread Wolfgang Denk
Signed-off-by: Wolfgang Denk --- README| 1 - arch/arm/mach-mvebu/serdes/a38x/high_speed_env_spec.c | 2 -- arch/xtensa/include/asm/arch-dc232b/core.h| 2 -- arch/xtensa/include/asm/arch-dc232b/tie-asm.h | 4 arch/xtensa

[PATCH 0/4] White Space cleanup

2021-09-27 Thread Wolfgang Denk
. No code changes result from this. I am aware that such a global cosmetic cleanup is always kind of disruptive, but we are at -rc5, so the code should be pretty stable for now, and I've done a few rebases before, with little and easy to fix conflicts. Wolfgang Denk (4): WS cleanup: remove

Bug in board/logicpd/omap3som/omap3logic.h ???

2021-09-27 Thread Wolfgang Denk
I reckon this is a mistake and should be fixed? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de

Re: [PATCH v4 4/5] env: Allow environment files to use the C preprocessor

2021-09-20 Thread Wolfgang Denk
} Hm... this is (so far) a legal command: => setenv foobar+ foo+=bar Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-6698

Re: [PATCH v4 3/5] env: Allow U-Boot scripts to be placed in a .env file

2021-09-20 Thread Wolfgang Denk
# Is this the start of a new environment variable? > + if (match($0, "^([^ =][^ =]*)=(.*)", arr)) { This is not what you document above. > + if (length(env) != 0) { > + # Record the value of the variable now completed > +

Re: [PATCH v4 2/5] doc: Move environment documentation to rST

2021-09-20 Thread Wolfgang Denk
p IP address of the Gateway (Router) to use > +hostname Target hostname > +ipaddr See above > +netmaskSubnet Mask > +rootpath Pathname of the root filesystem on the NFS server > +serverip see above > += ===

Re: U-BOOT missing Security support

2021-09-15 Thread Wolfgang Denk
Standard). This algorithm uses a symetric key 1982 and is widely used as a streaming cipher. Different key lengths are 1983 supported by the algorithm but this command only supports 128 bits 1984 at present. 1985 Best regards, Wolfgang Denk -- DENX Software Engineering Gm

Re: [PATCH 1/2] xyz-modem: Wait infinitely for initial y-modem packet

2021-09-13 Thread Wolfgang Denk
ll possible > combinations. I would recommend to define a timeout (in seconds), this is easier to understand for the end user - without looking at the source code they cannot know how a retry count translates into a time interval. And yes, setting the timeout to 0 could mean it waits forever.

Re: [PATCH 1/2] xyz-modem: Wait infinitely for initial y-modem packet

2021-09-13 Thread Wolfgang Denk
e timeout adjustable so you can set it to something you can conveniently work with. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66

Re: [PATCH 2/2] xyz-modem: Wait infinitely for initial x-modem packet

2021-09-13 Thread Wolfgang Denk
; common/xyzModem.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) Ditto here. Please don't. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-669

Re: [PATCH 1/2] xyz-modem: Wait infinitely for initial y-modem packet

2021-09-13 Thread Wolfgang Denk
ry, so I recommend NOT to change the behaviour here, especially as it does not hurt. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142

Re: [PATCH v2] powerpc: mpc: Put U-Boot version string at correct place by linker script

2021-08-24 Thread Wolfgang Denk
are no longer found in new designs, nor does anybody care to keep U-Boot small and tidy. As a result, knowledge about such optimizations is disappearing. Hope this helps. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, O

Re: Remove the gitlab-ci-runner on source.denx.de?

2021-08-23 Thread Wolfgang Denk
or two), I will finally remove it. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de How much net work could a network work, if a network could net work?

Re: How should we deal with actual hush odd behavior?

2021-08-23 Thread Wolfgang Denk
o a board script failing and so a device not > booting... The new version should be optional in any case, at least for some longer migration period to give users time to test their scripts. If someone selects the new version in his board configuration, he probably has run enough tests to m

Re: [PATCH v6 10/12] watchdog: add gpio watchdog driver

2021-08-23 Thread Wolfgang Denk
| - Simon Glass in > > > > Well you've taken it out of context :-) It would make more sense if > you mention the need for tests Testing can show the presense of bugs, but not their absence. -- Edsger Dijkstr Best regards, Wolfgang Denk

Re: [PATCH v6 10/12] watchdog: add gpio watchdog driver

2021-08-19 Thread Wolfgang Denk
users. Wow. I think I'll add this to my signature database: | "Trying to catch [programming errors] in the field at runtime is not | very kind to your users." | | - Simon Glass in Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang

Re: [PATCH v6 10/12] watchdog: add gpio watchdog driver

2021-08-19 Thread Wolfgang Denk
happen" does not seem to be a clever approach to software engineering to me. I stop here. You know my opinion. You are the maintainer. Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, German

Re: [PATCH v6 10/12] watchdog: add gpio watchdog driver

2021-08-19 Thread Wolfgang Denk
w a policy to wave through code, and ask others to clean it up later? That's ... sad. Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 E

Re: [PATCH v6 10/12] watchdog: add gpio watchdog driver

2021-08-19 Thread Wolfgang Denk
doing a > > git grep -10 -E 'dev_get(_uclass)?_priv' > > and see how many cases you can find where that is followed by a NULL check? The existence of bad code is not a justification to add more of it. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Direct

Re: [PATCH v6 10/12] watchdog: add gpio watchdog driver

2021-08-19 Thread Wolfgang Denk
riv->always_running = dev_read_bool(dev, "always-running"); Ditto. > + ret = gpio_request_by_name(dev, "gpios", 0, >gpio, GPIOD_IS_OUT); > + if (ret < 0) { > + dev_err(dev, "Request for wdt gpio failed: %d\n", ret); > +

Re: [PATCH v6 09/12] watchdog: wdt-uclass.c: handle all DM watchdogs in watchdog_reset()

2021-08-19 Thread Wolfgang Denk
Do I see this crrectly that you remove here the code which you just added in patch 02 of this series? Why not doing it right from the beginning? > + uclass_foreach_dev(dev, uc) { > + if (!device_active(dev)) > + continue; > + priv = dev_get

Re: [PATCH v6 07/12] watchdog: wdt-uclass.c: add wdt_stop_all() helper

2021-08-19 Thread Wolfgang Denk
s_foreach_dev(dev, uc) { > + if (!device_active(dev)) > + continue; > + priv = dev_get_uclass_priv(dev); > + if (!priv->running) > + continue; Potential NULL pointer dereferencing. Best regards, Wolfgang Denk --

Re: [PATCH v6 05/12] watchdog: wdt-uclass.c: keep track of each device's running state

2021-08-19 Thread Wolfgang Denk
ass_priv(dev); > + > + priv->running = false; Same here. > @@ -156,6 +165,9 @@ void watchdog_reset(void) > > dev = gd->watchdog_dev; > priv = dev_get_uclass_priv(dev); > + if (!priv->running) > + return; > + And here agai

Re: [PATCH] configs: Layerscape: Remove the 'fdt_addr' env

2021-08-19 Thread Wolfgang Denk
t; /* SPDX-License-Identifier: GPL-2.0+ */ > /* > * Copyright 2014 Freescale Semiconductor, Inc. > - * Copyright 2019 NXP > + * Copyright 2019, 2021 NXP > */ Again, for deleting 2 lines of data. And so on. None of these changes has substance to claim a copyright for. Best regards,

Re: [PATCH v5 09/12] watchdog: wdt-uclass.c: handle all DM watchdogs in watchdog_reset()

2021-08-19 Thread Wolfgang Denk
gt;> + continue; > >>} > > > > Here the situation is different. The probing error is never > > reported anywhere. Is it really a normal condition that a > > device_probe() fails here? > > No, it is not a normal condition. I added

Re: [PATCH] cmd: boot: Update reset usage message

2021-08-13 Thread Wolfgang Denk
ting to boot from a flash which is in the wrong state. So my problem with this is primarily that I don't understand what the command really does, and the help command is of no help either. [And if I understand correctly, this is even board dependent?] Best regards, Wolfgang Denk -- DENX Software

Re: [PATCH v4 07/10] watchdog: wdt-uclass.c: handle all DM watchdogs in watchdog_reset()

2021-08-13 Thread Wolfgang Denk
. Omitting code to handle situations that are unlikely to happen is definitely not what I consider robust programming, and nothing which I would let pass a code review. But if you insist, there is no more to do for me here that to note that fact that we disagree. Wolfgang Denk -- DENX Software Engi

Re: [PATCH] cmd: boot: Update reset usage message

2021-08-13 Thread Wolfgang Denk
vel specifier > reset -w - warm reset if implemented In case of the hard (cold) reset - is it really only a reset of the CPU, or of the whole board hardware? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirch

Re: [PATCH v4 07/10] watchdog: wdt-uclass.c: handle all DM watchdogs in watchdog_reset()

2021-08-12 Thread Wolfgang Denk
s actually very little to decide. There should be only one possible action: stop here, before more damage happens. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (

Re: [PATCH] configs: Layerscape: Remove the 'fdt_addr' env

2021-08-12 Thread Wolfgang Denk
ow copyright works. You cannot claim any copyright on trivial changes. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-6

Re: [PATCH] configs: Layerscape: Remove the 'fdt_addr' env

2021-08-12 Thread Wolfgang Denk
> "fdtheader_addr_r=0x8010\0" \ > diff --git a/include/configs/ls1012afrwy.h b/include/configs/ls1012afrwy.h Adding or - like here, even worse - removing just a few lines of data definitions is certainly nothing where you can claim a copyright on. Best regards, Wo

Re: [PATCH v5 09/12] watchdog: wdt-uclass.c: handle all DM watchdogs in watchdog_reset()

2021-08-12 Thread Wolfgang Denk
continue; > } Here the situation is different. The probing error is never reported anywhere. Is it really a normal condition that a device_probe() fails here? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munic

Re: [PATCH v4 07/10] watchdog: wdt-uclass.c: handle all DM watchdogs in watchdog_reset()

2021-08-12 Thread Wolfgang Denk
sage by default every time. It does not matter where the error is reported - in the called function, or in some caller firther up the call tree. But it _must_ be reportet at least once. So if we don't issue an error message here, we need to check and fix the callers, too. Best regards, Wolfgang D

Re: [PATCH v4 07/10] watchdog: wdt-uclass.c: handle all DM watchdogs in watchdog_reset()

2021-08-11 Thread Wolfgang Denk
eturn value, there's no point making it return int. When that > user shows up, we can discuss which int (return early on failure? > remember that an error was seen but still call wdt_stop on remaining > devices? etc. etc.). Returning an error code is always a good ide, no matter if curre

Re: [EXT] Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-09 Thread Wolfgang Denk
sive shell scripts, for example... Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "Remember, Infor

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-09 Thread Wolfgang Denk
operation with much less potential for memory leaks etc. than using malloc(). Any assumption that a stack size of 4 kB or 16 kB or such will be sufficient is ... optimistic at best. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Mun

Re: [PATCH v1 1/5] lib/string: Add memset_simple()

2021-08-07 Thread Wolfgang Denk
you have to reimplement exactly the same code? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de [Brad

Re: [PATCH v1 4/5] arm64: arch/arm/lib: Add optimized memset/memcpy functions

2021-08-06 Thread Wolfgang Denk
Dear Stefan, In message <20210806133843.3642916-5...@denx.de> you wrote: > Ported from https://github.com/ARM-software/optimized-routines Please provide exact reference, at least including file names and git commit ID's. Best regards, Wolfgang Denk -- DENX Software Enginee

Re: [PATCH v1 1/5] lib/string: Add memset_simple()

2021-08-06 Thread Wolfgang Denk
memset() implementation here should work. Or does it not? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@de

Re: [PATCH 11/11] Remove including timestamp.h in version.h

2021-08-03 Thread Wolfgang Denk
ersion" command should produce a corresponding output, which means some parts _have_ to be recompiled, resulting in a new banner, too ? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenze

Re: [PATCH 13/15] RFC: lib: Support a binary prefix 0y

2021-07-24 Thread Wolfgang Denk
s a 19-year-old bug: (was lib_generic/vsprintc.c) > > 153d511e369 Initial revision Mea culpa. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142

Re: [PATCH 13/15] RFC: lib: Support a binary prefix 0y

2021-07-23 Thread Wolfgang Denk
ng starts with 0 it is interpreted > as octal. That's a bug, then. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de panic: can't find /

Re: [PATCH 13/15] RFC: lib: Support a binary prefix 0y

2021-07-22 Thread Wolfgang Denk
e how this should work... > Well, yes. Perhaps we should just drop octal? Drop? AFAICT we never supported octal. Something like "md 040" will start dumping at 0x0040, right? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang D

Re: [PATCH 13/15] RFC: lib: Support a binary prefix 0y

2021-07-21 Thread Wolfgang Denk
b please That doesn't work, as 0b010101 is in U-Boot in alost all contexts interpreted as 0x0b010101 (hex) = 184615169 (dec) Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Pho

Re: [PATCH 13/15] RFC: lib: Support a binary prefix 0y

2021-07-21 Thread Wolfgang Denk
numberbases, like 42. But ... do we really *need* all this stuff? %% (signatures) Perfection is reached, not when there is no longer anything to add, but when there is no longer anything to take away. - Antoine de Saint-Exupery Best regards, Wolfgang De

Re: [PATCH 00/15] lib: Add support for a decimal 0m prefix for numbers

2021-07-21 Thread Wolfgang Denk
h the code size? Simon's patches include some cleanup, which probably even reduces the size, so good. But whether it's 0m123 or 0t123 or 0!123 or ... is pretty much irrelevant - chose one symbol, use it, and be done with that. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH,

Re: [PATCH 00/15] lib: Add support for a decimal 0m prefix for numbers

2021-07-21 Thread Wolfgang Denk
cal configurations? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Sorry, but my karma just ran over your dogma.

Re: [RFC PATCH 02/28] cli: Add LIL shell

2021-07-08 Thread Wolfgang Denk
https://wiki.tcl-lang.org/page/Why+can+I+not+place+unmatched+braces+in+Tcl+comments [4] https://tbot.tools/ Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)

Re: [RFC PATCH 05/28] cli: lil: Rename some functions to be more like TCL

2021-07-08 Thread Wolfgang Denk
ms. Hey, they even list Forth there. Maybe somebody should port OpenBoot, so we can have a Forth interpreter as new commandline language? We could implement device trees in the old, traditional way then, too :-) Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Dir

Re: [RFC PATCH 03/28] cli: lil: Replace strclone with strdup

2021-07-08 Thread Wolfgang Denk
upstream codebase and porting it from scratch. Agreed. But this means porting some code, which still implements the very same language (i. e. "shell"). There would be no new language in this case - just a bigger subset, less restrictions, more options, probably. Best regards, Wolfga

Re: [RFC PATCH 02/28] cli: Add LIL shell

2021-07-07 Thread Wolfgang Denk
erse groups that just > dropping our old hush entirely might not be possible right away. Of > course, if all of the current in-tree complex cases Just Work, that > might be a good argument against needing to keep such levels of > backwards compatibility. There is only one way to test thi

Re: [RFC PATCH 02/28] cli: Add LIL shell

2021-07-07 Thread Wolfgang Denk
there are any systems with > non-trivial scripts but upgrade U-Boot and don't / won't / can't > re-validate their entire sequence, they can just use the old cli. Do you actually have an example where code working on our ancient port of hush would fail on the current upstream version? Best regards,

Re: [RFC PATCH 05/28] cli: lil: Rename some functions to be more like TCL

2021-07-07 Thread Wolfgang Denk
be doing before we hand things over to the OS? You are shooting yourself in the knee here. If you think out CLI should not be adding new features, then we should just stick with our ancient hush and neither update it nor replace it with something else that adds not only new features, but breaks backw

Re: [RFC PATCH 02/28] cli: Add LIL shell

2021-07-07 Thread Wolfgang Denk
ll you support IPv6?", "NFS does not work with recent Linux distros, will this be fixed?", "Can I download over WiFi?", "Can I download using HTTP/HTTPS?", "How can I harden U-Boot for security-critical environments?", etc. Best regards, Wolfgang Denk --

Re: [RFC PATCH 02/28] cli: Add LIL shell

2021-07-07 Thread Wolfgang Denk
r or no error handling, and comes with an incompatible command line interface? There is a zillion of shell scripts in the field, from non-trivial boot sequences to complex download-and-upgrade scripts. You can't really even think of breaking compatibility on such a level. Best regards, Wolfgang Denk -

Re: [ANN] U-Boot v2021.07 released

2021-07-06 Thread Wolfgang Denk
7 (3.7%) ARM 3 (1.6%) Intel3 (1.6%) Toradex 3 (1.6%) ... Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germ

Re: [RFC PATCH 05/28] cli: lil: Rename some functions to be more like TCL

2021-07-06 Thread Wolfgang Denk
NAK from me when when you think of it as a _replacement_ (even an optional one) of the standard shell. If you like, have it added as an _additional_ command, of course fully optional and without impact on the rest of U-Boot if not intentionally selected. Best regards, Wolfgang Denk -- DENX Softw

Re: [RFC PATCH 05/28] cli: lil: Rename some functions to be more like TCL

2021-07-06 Thread Wolfgang Denk
it. If you were right, there would be far less users of bash (or other "bourne derived shells"). Guess which percentage of users of UNIX operating systems is using a Tcl based command interpreter as their login shell? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH,

Re: [RFC PATCH 02/28] cli: Add LIL shell

2021-07-06 Thread Wolfgang Denk
as of today. I view adding > functions as one of the most important usability improvements we can > make. Again: this is not an issue with hush as is, but only with our resource-limited port of a nearly 20 year old version of it. Updating to a current version would fix this, in an almost 100% bac

Re: [RFC PATCH 02/28] cli: Add LIL shell

2021-07-06 Thread Wolfgang Denk
y think that replacing standard shell syntax with Tcl is "something that's comfortable to a large audience"? I seriously doubt that. > Something that has "sh" syntax but also clear to the user errors when > trying to do something not supported would also be interesting to see.

  1   2   3   4   5   6   7   8   9   10   >