Hi,
There is a gap from "clr_restart_det" 0xa8 to "comp_param1" 0xf4,
you should reserve a space for them.
Best regards,
Jun Chen
Simon Glass 於 2020年1月4日 週六 上午6:27寫道：
> Some versions of this peripherals provide more control of the bus
> behaviour. Add definitions for these registers.
>
>
Reviewed-by: Jun Chen
Simon Glass 於 2020年1月4日 週六 上午6:27寫道：
> We use struct clk here so really should include this header file to avoid
> build errors. Also switch the order of clk.h in the C file to match the
> required code style.
>
> Signed-off-by: Simon Glass
> Reviewed-by: Ley Foon Tan
>
Reviewed-by: Jun Chen
Simon Glass 於 2020年1月4日 週六 上午6:27寫道：
> Some SoCs support a higher speed than what is currently called 'max' in
> this driver. Rename it to 'high' speed, which is the official name of the
> 3.4MHz speed.
>
> Signed-off-by: Simon Glass
> ---
>
> Changes in v2: None
>
>
Hi Simon,
I found this commit has style problems reported by checkpatch.pl,
is it better to fix it?
Simon Glass 於 2020年1月4日 週六 上午6:27寫道：
> Convert the obvious uses of i2c bus speeds to use the enum.
>
> Use livetree access for code changes.
>
> Signed-off-by: Simon Glass
> ---
>
> Changes
Reviewed-by: Jun Chen
Simon Glass 於 2020年1月4日 週六 上午6:27寫道：
> Group these #defines into an enum to make it easier to understand the
> relationship between them.
>
> Signed-off-by: Simon Glass
> ---
>
> Changes in v2: None
>
> drivers/i2c/designware_i2c.c | 2 +-
>
>
> > -Original Message-
> > From: Simon Glass
> > Sent: Sunday, December 22, 2019 12:15 AM
> > To: U-Boot Mailing List
> > Cc: Jun Chen ; Heiko Schocher ; Tan,
> > Ley Foon ; Simon Glass
> > Subject: [PATCH 01/12] i2c: designware_i2c: Add more registers
> >
> > Some versions of this
6 matches
Mail list logo
