Re: [U-Boot] [PATCH] net/phy: refactor RTL8211F initialization
-Original Message-
From: Joe Hershberger [mailto:joe.hershber...@gmail.com]
Sent: Thursday, April 23, 2015 10:42 PM
To: Liu Shengzhou-B36685
Cc: u-boot
Subject: Re: [PATCH] net/phy: refactor RTL8211F initialization
Hi Shengzhou Liu,
On Wed, Apr 22, 2015 at 5:22 AM, Shengzhou Liu shengzhou@freescale.com
wrote:
RTL8211F needs to enalbe TXDLY for RGMII during phy initialization, so
move it to rtl8211f_config for early initialization.
Signed-off-by: Shengzhou Liu shengzhou@freescale.com
cc: Joe Hershberger joe.hershber...@gmail.com
---
drivers/net/phy/realtek.c | 25 +
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
index 3917c82..d48095b 100644
--- a/drivers/net/phy/realtek.c
+++ b/drivers/net/phy/realtek.c
@@ -43,6 +43,22 @@ static int rtl8211x_config(struct phy_device *phydev)
return 0;
}
+static int rtl8211f_config(struct phy_device *phydev) {
+ phy_write(phydev, MDIO_DEVAD_NONE, MII_BMCR, BMCR_RESET);
Do you not need to disable the phy interrupt here?
No need, It's disabled by default.
+
+ if (phydev-interface == PHY_INTERFACE_MODE_RGMII) {
+ /* enable TXDLY */
+ phy_write(phydev, MDIO_DEVAD_NONE,
+ MIIM_RTL8211F_PAGE_SELECT, 0xd08);
Why do you not need to change the page back to default? Does it only apply to
one following command or something? I haven't read the data sheet for this
phy to understand its behavior, but want to make sure it's clear here.
Please at least add a comment describing why the page need not be changed
back.
There is no other command, so it's working without back to default.
To avoid potential problem if one not set expected page, will have the page
back to default 0 in v2.
+ phy_write(phydev, MDIO_DEVAD_NONE, 0x11, 0x109);
Is this TX delay board specific? Seems like it would be. Should it be
parameterized to come from a board CONFIG_? If not, at least add a comment
describing these magic numbers.
It is not board specific. Will replace the magic number.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4] powerpc/t1023rdb: Add T1023 RDB board support
-Original Message- From: Sun York-R58495 Sent: Friday, April 17, 2015 3:22 AM To: Liu Shengzhou-B36685; u-boot@lists.denx.de Subject: Re: [PATCH v4] powerpc/t1023rdb: Add T1023 RDB board support On 03/27/2015 12:48 AM, Shengzhou Liu wrote: T1023RDB is a Freescale Reference Design Board that hosts the T1023 SoC. +++ b/configs/T1023RDB_NAND_defconfig @@ -0,0 +1,5 @@ +CONFIG_SPL=y +CONFIG_SYS_EXTRA_OPTIONS=PPC_T1023,T1023RDB,RAMBOOT_PBL,SPL_FSL_PBL,NAND ++S:CONFIG_PPC=y ++S:CONFIG_MPC85xx=y ++S:CONFIG_TARGET_T102XRDB=y Please do not use CONFIG_SYS_EXTRA_OPTIONS for new boards. York I noted config SYS_EXTRA_OPTIONS string Extra Options (DEPRECATED) in Kconfig. But we still have to use the CONFIG_SYS_EXTRA_OPTIONS in current configuration Infrastructure, unless a newer approach is available in future. Because there are some something like 'SPL_FSL_PBL', 'NAND', 'SPIFLASH''SDCARD' which must be defined dynamically during build u-boot for various boot-mode in those *_defconfig files instead of in static include/config.h Shengzhou ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v7] net/phy: Add support for CS4315/CS4340 PHY
-Original Message- From: Shengzhou Liu [mailto:shengzhou@freescale.com] Sent: Monday, November 10, 2014 6:32 PM To: u-boot@lists.denx.de; Sun York-R58495; joe.hershber...@gmail.com Cc: Liu Shengzhou-B36685 Subject: [PATCH v7] net/phy: Add support for CS4315/CS4340 PHY The link of previous version: http://patchwork.ozlabs.org/patch/350162/ Joe, York please review and ACK this version. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v6] net/phy: Add support for CS4315/CS4340 PHY
-Original Message- From: Shengzhou Liu [mailto:shengzhou@freescale.com] Sent: Wednesday, November 05, 2014 1:33 PM To: u-boot@lists.denx.de; Sun York-R58495; joe.hershber...@gmail.com Cc: Liu Shengzhou-B36685 Subject: [PATCH v6] net/phy: Add support for CS4315/CS4340 PHY The link of previous version v5 http://patchwork.ozlabs.org/patch/350162/ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/4] net/fm: add 2.5G SGMII support
-Original Message- From: Shengzhou Liu [mailto:shengzhou@freescale.com] Sent: Thursday, October 23, 2014 5:21 PM To: u-boot@lists.denx.de; Sun York-R58495 Cc: Liu Shengzhou-B36685; Xie Shaohui-B21989 Subject: [PATCH 1/4] net/fm: add 2.5G SGMII support [Shengzhou] This is a single patch, forgot to remove '1/4'. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/t1040: fix i2c2 address on t1040qds and t104xrdb
Four I2C controllers' offset are: #define CONFIG_SYS_FSL_I2C_OFFSET 0x118000 #define CONFIG_SYS_FSL_I2C2_OFFSET 0x118100 #define CONFIG_SYS_FSL_I2C3_OFFSET 0x119000 #define CONFIG_SYS_FSL_I2C4_OFFSET 0x119100 I will add I2C3 and I2C4. Thanks, Shengzhou -Original Message- From: Sun York-R58495 Sent: Wednesday, July 02, 2014 7:46 AM To: Jain Priyanka-B32167; Liu Shengzhou-B36685; u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH] powerpc/t1040: fix i2c2 address on t1040qds and t104xrdb Shengzhou, If u-boot uses 2nd I2C controller, it is good to have some comments. Please complete with four I2C controllers' offset. York On 07/01/2014 12:37 AM, Jain Priyanka-B32167 wrote: Hello Shengzhou, T1040 has two dual I2C controller. First Dual I2C Controller : 0x118 (first i2c bus), 0x1181000(second I2C bus) Second Dual I2C Controller : 0x119 (third i2c bus), 0x1191000(fourth I2C bus) My understanding is CONFIG_SYS_FSL_I2C_OFFSET is offset for first I2C controller and CONFIG_SYS_FSL_I2C2_OFFSET is offset for second I2C controller. Have you checked for dual I2C controller, CONFIG_SYS_FSL_I2C2_OFFSET implies offset for second I2C bus, not the controller? [Shengzhou] yes, I tested it with T1040. Regards Priyanka -Original Message- From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Shengzhou Liu Sent: Tuesday, July 01, 2014 11:32 AM To: u-boot@lists.denx.de; Sun York-R58495 Subject: [U-Boot] [PATCH] powerpc/t1040: fix i2c2 address on t1040qds and t104xrdb The base address of I2C2 is 0x118100 instead of 0x119000. Signed-off-by: Shengzhou Liu shengzhou@freescale.com --- include/configs/T1040QDS.h | 2 +- include/configs/T104xRDB.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/configs/T1040QDS.h b/include/configs/T1040QDS.h index 2215ac8..5b75562 100644 --- a/include/configs/T1040QDS.h +++ b/include/configs/T1040QDS.h @@ -443,7 +443,7 @@ unsigned long get_board_ddr_clk(void); #define CONFIG_SYS_FSL_I2C2_SPEED 5 /* I2C speed in Hz */ #define CONFIG_SYS_FSL_I2C2_SLAVE 0x7F #define CONFIG_SYS_FSL_I2C_OFFSET 0x118000 -#define CONFIG_SYS_FSL_I2C2_OFFSET0x119000 +#define CONFIG_SYS_FSL_I2C2_OFFSET0x118100 #define I2C_MUX_PCA_ADDR 0x77 #define I2C_MUX_PCA_ADDR_PRI 0x77 /* Primary Mux*/ diff --git a/include/configs/T104xRDB.h b/include/configs/T104xRDB.h index e564cb7..e265786 100644 --- a/include/configs/T104xRDB.h +++ b/include/configs/T104xRDB.h @@ -441,7 +441,7 @@ #define CONFIG_SYS_FSL_I2C2_SPEED 40 /* I2C speed in Hz */ #define CONFIG_SYS_FSL_I2C2_SLAVE 0x7F #define CONFIG_SYS_FSL_I2C_OFFSET 0x118000 -#define CONFIG_SYS_FSL_I2C2_OFFSET0x119000 +#define CONFIG_SYS_FSL_I2C2_OFFSET0x118100 /* I2C bus multiplexer */ #define I2C_MUX_PCA_ADDR0x70 -- 1.8.0 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/t2080rdb: Add T2080PCIe-RDB board support
-Original Message- From: Sun York-R58495 Sent: Saturday, March 01, 2014 12:48 AM To: Liu Shengzhou-B36685; u-boot@lists.denx.de Subject: Re: [PATCH] powerpc/t2080rdb: Add T2080PCIe-RDB board support On 02/28/2014 02:21 AM, Shengzhou Liu wrote: Shengzhou, I have said with your T2081QDS patch Next time, please format the patch with this command git format-patch -M -C --find-copies-harder I believe you didn't create these files from scratch. By using the proper command, you will format the patch to identify copies and moves. The change set will be smaller and easier to review. York At first, I used the patch generated by 'git format-patch -M -C --find-copies-harder', but found it can't directly apply to u-boot-mpc85xx base tree with conflictions, so I removed '-M -C --find-copies-harder' option, then it can directly apply to u-boot-mpc85xx tree without conflictions. -Shengzhou ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] how to get rid of No base64 encoded MIME text parts?
When replying the original email, outlook added automatically underline at some strings with @, such as u-boot@lists.denx.de. You can try to remove the underline. Regards, Shengzhou -Original Message- From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Yuantian Tang Sent: Thursday, February 13, 2014 4:38 PM To: u-boot@lists.denx.de Subject: [U-Boot] how to get rid of No base64 encoded MIME text parts? Hi all, I keep receiving Message rejected. No base64 encoded MIME text parts allowed. when I reply email. Could someone tell me how to find base64 encoded MIME text parts? Thanks, Yuantian ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] powerpc/T208xQDS: add mtdparts suppport
-Original Message- From: Shengzhou Liu [mailto:shengzhou@freescale.com] Sent: Wednesday, December 25, 2013 2:50 PM To: u-boot@lists.denx.de; Sun York-R58495 Cc: Liu Shengzhou-B36685 Subject: [PATCH] powerpc/T208xQDS: add mtdparts suppport We use dynamical mtdparts partition instead of directly puting mtd partitions nodes in device tree. Signed-off-by: Shengzhou Liu shengzhou@freescale.com Please hold on the patch due to compiling issue until we finish the transition from size 512KB to 768KB. -Shengzhou ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] t2080qds/ddr: update ddr parameters
-Original Message-
From: York Sun [mailto:york...@freescale.com]
Sent: Saturday, December 07, 2013 12:39 AM
To: Liu Shengzhou-B36685; u-boot@lists.denx.de
Subject: Re: [PATCH] t2080qds/ddr: update ddr parameters
On 12/06/2013 12:53 AM, Shengzhou Liu wrote:
- optimize ddr parameters for whole frequency range from 1500MT/s to
2140MT/s.
- remove unused patameters: 'cpo', 'wrdata delay', '2T', which is
unrelated
to DDR3/3L on t2080qds.
- remove unused rdimm code(only udimm is supported on t2080qds).
Signed-off-by: Shengzhou Liu shengzhou@freescale.com
---
Against master branch of git://git.denx.de/u-boot-mpc85xx.git
board/freescale/t2080qds/ddr.c | 20 ++---
board/freescale/t2080qds/ddr.h | 64
+-
2 files changed, 17 insertions(+), 67 deletions(-)
diff --git a/board/freescale/t2080qds/ddr.c
b/board/freescale/t2080qds/ddr.c index 5db5d21..bc366ae 100644
--- a/board/freescale/t2080qds/ddr.c
+++ b/board/freescale/t2080qds/ddr.c
@@ -24,24 +24,17 @@ void fsl_ddr_board_options(memctl_options_t *popts,
const struct board_specific_parameters *pbsp, *pbsp_highest = NULL;
ulong ddr_freq;
- if (ctrl_num 2) {
+ if (ctrl_num 1) {
printf(Not supported controller number %d\n, ctrl_num);
return;
}
if (!pdimm-n_ranks)
return;
- /*
-* we use identical timing for all slots. If needed, change the
code
-* to pbsp = rdimms[ctrl_num] or pbsp = udimms[ctrl_num];
-*/
- if (popts-registered_dimm_en)
- pbsp = rdimms[0];
- else
- pbsp = udimms[0];
+ pbsp = udimms[0];
This is not right. You should throw out an error if RDIMM is not supported.
[Shengzhou] okay.
But why isn't it supported? T2080 SoC can support RDIMM.
[Shengzhou] T2080 SoC can support uDIMM and rDIMM, but T2080QDS board supports
only UDIMM according to T2080QDS RM.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
