Re: [U-Boot] [PATCH v4 3/4] SDP: fix wrong usb request size and add high speed endpoint descriptor

2019-09-16 Thread Sherry Sun
Hi Lukasz, Ping. Any comments on V4? Best regards Sherry Sun > > Because the buffer length of sdp usb request is 65, we have to allocate > 65 bytes not 64 bytes. Otherwise there is potential buffer overflow. > > So the wMaxPacketSize of fullspeed can't meet the needs.

Re: [U-Boot] [PATCH v4 2/4] USB: host: Add the USB3 host driver

2019-09-09 Thread Sherry Sun
Hi Jean, > > Hi Sherry, > > On 03/09/2019 14:44, Sherry Sun wrote: > > Hi Jean, > > > >> > >> On 02/09/2019 13:29, Sherry Sun wrote: > >>> Hi Vignesh, > >>> > >>>> Hi Sherry, > >>>> > >>&g

Re: [U-Boot] [PATCH v4 2/4] USB: host: Add the USB3 host driver

2019-09-03 Thread Sherry Sun
Hi Jean, > > > On 02/09/2019 13:29, Sherry Sun wrote: > > Hi Vignesh, > > > >> Hi Sherry, > >> > >> [...] > >>>> AFAIK, U-Boot does not support runtime switching of USB port to > >>>> host from device and v

Re: [U-Boot] [PATCH v4 2/4] USB: host: Add the USB3 host driver

2019-09-02 Thread Sherry Sun
we add two subnodes for gadget and host. But I see a for loop in dwc3_glue_bind() as follows, if there only one single node representing both Host and Device node under usb wrapper node, why we need this for loop? 212 for (node = fdt_first_subnode(fdt, dev_of_offset(parent)); node > 0; 2

Re: [U-Boot] [PATCH v4 2/4] USB: host: Add the USB3 host driver

2019-08-30 Thread Sherry Sun
Hi Vignesh, > > > > On 30/08/19 3:36 PM, Sherry Sun wrote: > > Hi Jean, > > > >> > >> > >> On 28/08/2019 13:50, Sherry Sun wrote: > >>> Hi Jean, > >>> > >>>> Hi Jean, > >>>> > >

Re: [U-Boot] [PATCH v4 2/4] USB: host: Add the USB3 host driver

2019-08-30 Thread Sherry Sun
Hi Jean, > > > On 28/08/2019 13:50, Sherry Sun wrote: > > Hi Jean, > > > >> Hi Jean, > >> > >>> Hi Marek, Sherry, > >>> > >>> > >>>>>>> we keep the cdns3 node for usb gadget driver, then add a u

Re: [U-Boot] [PATCH v5 0/7] usb: Add cadence USB3 gadget/host/phy driver

2019-08-30 Thread Sherry Sun
Hi Vignesh, > > Hi, > > On 28/08/19 7:52 PM, Sherry Sun wrote: > > Hi Vignesh, > [...] > >> I see that Cadence USB driver for Linux kernel is still under > >> development and DT compatible binding is supposed to be "cdns,usb3" > not

Re: [U-Boot] [PATCH v5 0/7] usb: Add cadence USB3 gadget/host/phy driver

2019-08-28 Thread Sherry Sun
Hi Vignesh, > > Hi Sherry, > > On 21/08/19 8:05 PM, Sherry Sun wrote: > > These patches introduce new Cadence driver to U-Boot. > > The first patch is to add the Cadence USB3 IP(CDNS3) core and driver > > for the usb gadget. > > The second patch int

Re: [U-Boot] [PATCH v5 6/7] phy: Add USB PHY driver for the cadence USB3

2019-08-28 Thread Sherry Sun
Hi Jean, > > +Kishon who worked on this PHY under linux > > > Hi Sherry, > > > On 28/08/2019 10:05, Sherry Sun wrote: > > Hi Jean, > > > >> Hi Sherry, > >> > >> On 21/08/2019 16:36, Sherry Sun wrote: > >>> The cdns

Re: [U-Boot] [PATCH v4 2/4] USB: host: Add the USB3 host driver

2019-08-28 Thread Sherry Sun
he cdns3 usb node as both usb gadget device and usb > host device, do you mean that I should make the cdns3 usb node as a usb > wrapper device, and create two subnodes in it. > Then when binding the wrapper node, it will hard-coded the two subnodes > to different driver(gadge/h

Re: [U-Boot] [PATCH v5 6/7] phy: Add USB PHY driver for the cadence USB3

2019-08-28 Thread Sherry Sun
Hi Jean, > > Hi Sherry, > > On 21/08/2019 16:36, Sherry Sun wrote: > > The cdns3-usb-phy driver supports both host and peripheral mode of usb > > driver which use cadence usb3 IP. > > > > Signed-off-by: Sherry Sun > > --- > > drivers/phy/Kco

Re: [U-Boot] [PATCH v4 2/4] USB: host: Add the USB3 host driver

2019-08-28 Thread Sherry Sun
gt; This is done in dwc3_glue_bind(). Thanks for your suggestions. So if I want to use the cdns3 usb node as both usb gadget device and usb host device, do you mean that I should make the cdns3 usb node as a usb wrapper device, and create two subnode

[U-Boot] [PATCH v4 2/4] SDP: use CONFIG_SDP_LOADADDR as default load address

2019-08-26 Thread Sherry Sun
If SDP_WRITE and SDP_JUMP command addr is zero, use CONFIG_SDP_LOADADDR as default address. Signed-off-by: Sherry Sun Signed-off-by: Frank Li Reviewed-by: Lukasz Majewski --- drivers/usb/gadget/Kconfig | 4 drivers/usb/gadget/f_sdp.c | 6 -- 2 files changed, 8 insertions(+), 2

[U-Boot] [PATCH v4 3/4] SDP: fix wrong usb request size and add high speed endpoint descriptor

2019-08-26 Thread Sherry Sun
send packet with 512 byte size. Signed-off-by: Sherry Sun Signed-off-by: Ye Li --- drivers/usb/gadget/f_sdp.c | 37 ++--- 1 file changed, 34 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/f_sdp.c b/drivers/usb/gadget/f_sdp.c index 841814bc07

[U-Boot] [PATCH v4 4/4] SDP: Call usb_gadget_initialize and usb_gadget_release to support UDC

2019-08-26 Thread Sherry Sun
Need initialize UDC before run sdp download and release it at the end of sdp. Signed-off-by: Sherry Sun Signed-off-by: Frank Li Reviewed-by: Lukasz Majewski --- common/spl/spl_sdp.c | 4 1 file changed, 4 insertions(+) diff --git a/common/spl/spl_sdp.c b/common/spl/spl_sdp.c index

[U-Boot] [PATCH v4 1/4] imx: spl: Change USB boot device type for imx8/8m

2019-08-26 Thread Sherry Sun
The SPL SDP is configured as BOOT_DEVICE_BOARD, but for i.MX8 and i.MX8M, the boot_device_spl is still set to BOOT_DEVICE_USB, which may cause SDP can't work, in order to fix this issue, when booting from USB in spl, we change its type to BOOT_DEVICE_BOARD. Signed-off-by: Sherry Sun Signed-off

[U-Boot] [PATCH v4 0/4] Make some changes to SDP

2019-08-26 Thread Sherry Sun
is zero. The current patches have been validated on both i.MX8 and i.MX8M platform. Sherry Sun (4): imx: spl: Change USB boot device type for imx8/8m SDP: use CONFIG_SDP_LOADADDR as default load address SDP: fix wrong usb request size and add high speed endpoint descriptor SDP: Call

Re: [U-Boot] [PATCH v3 3/4] SDP: fix wrong usb request size and add high speed endpoint descriptor

2019-08-26 Thread Sherry Sun
Hi Lukasz, > > On Thu, 22 Aug 2019 01:46:20 +0000 > Sherry Sun wrote: > > > Because the buffer length of sdp usb request is 65, we have to > > allocate 65 bytes not 64 bytes. Otherwise there is potential buffer > > overflow. > > > > So the wMaxPacketS

[U-Boot] [PATCH v3 3/4] SDP: fix wrong usb request size and add high speed endpoint descriptor

2019-08-21 Thread Sherry Sun
send packet with 512 byte size. Signed-off-by: Sherry Sun Signed-off-by: Ye Li --- drivers/usb/gadget/f_sdp.c | 33 ++--- 1 file changed, 30 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/f_sdp.c b/drivers/usb/gadget/f_sdp.c index 841814bc07..8aaed92e9b

[U-Boot] [PATCH v3 1/4] imx: spl: Change USB boot device type for imx8/8m

2019-08-21 Thread Sherry Sun
The SPL SDP is configured as BOOT_DEVICE_BOARD, but for i.MX8 and i.MX8M, the boot_device_spl is still set to BOOT_DEVICE_USB, which may cause SDP can't work, in order to fix this issue, when booting from USB in spl, we change its type to BOOT_DEVICE_BOARD. Signed-off-by: Sherry Sun Signed-off

[U-Boot] [PATCH v3 4/4] SDP: Call usb_gadget_initialize and usb_gadget_release to support UDC

2019-08-21 Thread Sherry Sun
Need initialize UDC before run sdp download and release it at the end of sdp. Signed-off-by: Sherry Sun Signed-off-by: Frank Li Reviewed-by: Lukasz Majewski --- common/spl/spl_sdp.c | 4 1 file changed, 4 insertions(+) diff --git a/common/spl/spl_sdp.c b/common/spl/spl_sdp.c index

[U-Boot] [PATCH v3 0/4] Make some changes to SDP

2019-08-21 Thread Sherry Sun
high speed endpoint descriptor for sdp. 3. Add a macro definition--CONFIG_SDP_LOADADDR as default sdp load address while SDP_WRITE and SDP_JUMP command addr is zero. The current patches have been validated on both i.MX8 and i.MX8M platform. Sherry Sun (4): imx: spl: Change USB boot device type

[U-Boot] [PATCH v3 2/4] SDP: use CONFIG_SDP_LOADADDR as default load address

2019-08-21 Thread Sherry Sun
If SDP_WRITE and SDP_JUMP command addr is zero, use CONFIG_SDP_LOADADDR as default address. Signed-off-by: Sherry Sun Signed-off-by: Frank Li Reviewed-by: Lukasz Majewski --- drivers/usb/gadget/Kconfig | 4 drivers/usb/gadget/f_sdp.c | 6 -- 2 files changed, 8 insertions(+), 2

[U-Boot] [PATCH v2 2/4] SDP: use CONFIG_SDP_LOADADDR as default load address

2019-08-21 Thread Sherry Sun
If SDP_WRITE and SDP_JUMP command addr is zero, use CONFIG_SDP_LOADADDR as default address. Signed-off-by: Sherry Sun Signed-off-by: Frank Li --- drivers/usb/gadget/Kconfig | 4 drivers/usb/gadget/f_sdp.c | 6 -- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers

[U-Boot] [PATCH v2 1/4] imx: spl: Change USB boot device type for imx8/8m

2019-08-21 Thread Sherry Sun
The SPL SDP is configured as BOOT_DEVICE_BOARD, but for i.MX8 and i.MX8M, the boot_device_spl is still set to BOOT_DEVICE_USB, which may cause SDP can't work, in order to fix this issue, when booting from USB in spl, we change its type to BOOT_DEVICE_BOARD. Signed-off-by: Sherry Sun Signed-off

[U-Boot] [PATCH v2 3/4] SDP: fix wrong usb request size and add high speed endpoint descriptor

2019-08-21 Thread Sherry Sun
send packet with 512 byte size. Signed-off-by: Sherry Sun Signed-off-by: Ye Li --- drivers/usb/gadget/f_sdp.c | 33 ++--- 1 file changed, 30 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/f_sdp.c b/drivers/usb/gadget/f_sdp.c index 841814bc07..8aaed92e9b

[U-Boot] [PATCH v2 0/4] Make some changes to SDP

2019-08-21 Thread Sherry Sun
for sdp. 3. Add a macro definition--CONFIG_SDP_LOADADDR as default sdp load address while SDP_WRITE and SDP_JUMP command addr is zero. Sherry Sun (4): imx: spl: Change USB boot device type for imx8/8m SDP: use CONFIG_SDP_LOADADDR as default load address SDP: fix wrong usb request size and add

[U-Boot] [PATCH v2 4/4] SDP: Call usb_gadget_initialize and usb_gadget_release to support UDC

2019-08-21 Thread Sherry Sun
Need initialize UDC before run sdp download and release it at the end of sdp. Signed-off-by: Sherry Sun Signed-off-by: Frank Li --- common/spl/spl_sdp.c | 4 1 file changed, 4 insertions(+) diff --git a/common/spl/spl_sdp.c b/common/spl/spl_sdp.c index 806bf1327e..7b0a213d4c 100644

[U-Boot] [PATCH v5 5/7] usb: host: Add the USB3 host driver

2019-08-21 Thread Sherry Sun
Add the USB3 host driver for NXP imx8 platform, and the cadence IP is in it. The USB3 host driver support DM mode, it will probe USB3 host node in dts. Signed-off-by: Sherry Sun --- drivers/usb/host/Kconfig | 9 ++ drivers/usb/host/Makefile| 1 + drivers/usb/host/xhci-imx8.c | 210

[U-Boot] [PATCH v5 7/7] usb: gadget: core: introduce ->udc_set_speed() method

2019-08-21 Thread Sherry Sun
. So here introduce a new optional ->udc_set_speed() method which can be implemented by interested UDC drivers to achieve this purpose. Signed-off-by: Sherry Sun --- drivers/usb/gadget/udc/udc-core.c | 23 +++ include/linux/usb/gadget.h| 2 ++ 2 files changed,

[U-Boot] [PATCH v5 4/7] usb: gadget: Add gadget_is_cdns3 checking to provide bcdUSB value

2019-08-21 Thread Sherry Sun
Like other usb controllers, add gadget_is_cdns3 checking to provide bcdUSB value in device descriptor. Signed-off-by: Sherry Sun --- drivers/usb/gadget/gadget_chips.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/usb/gadget/gadget_chips.h b/drivers/usb/gadget

[U-Boot] [PATCH v5 3/7] usb: gadget: Add match_ep call back to usb_gadget_ops

2019-08-21 Thread Sherry Sun
information and configure the EP once the set configuration request is received. Signed-off-by: Sherry Sun --- drivers/usb/gadget/epautoconf.c | 4 include/linux/usb/gadget.h | 3 +++ 2 files changed, 7 insertions(+) diff --git a/drivers/usb/gadget/epautoconf.c b/drivers/usb/gadget

[U-Boot] [PATCH v5 6/7] phy: Add USB PHY driver for the cadence USB3

2019-08-21 Thread Sherry Sun
The cdns3-usb-phy driver supports both host and peripheral mode of usb driver which use cadence usb3 IP. Signed-off-by: Sherry Sun --- drivers/phy/Kconfig | 8 ++ drivers/phy/Makefile| 1 + drivers/phy/cdns3-usb-phy.c | 241 3 files

[U-Boot] [PATCH v5 2/7] usb: gadget: Add the cadence USB3 gadget driver

2019-08-21 Thread Sherry Sun
. Signed-off-by: Sherry Sun --- Makefile |1 + drivers/usb/Kconfig |2 + drivers/usb/cdns3/Kconfig | 20 + drivers/usb/cdns3/Makefile|5 + drivers/usb/cdns3/cdns3-generic.c | 114 ++ drivers/usb/cdns3/cdns3-nxp-reg

[U-Boot] [PATCH v5 1/7] dt-bindings: add dt-binding doc for CDNS3 controller

2019-08-21 Thread Sherry Sun
This patch aim at documenting USB related dt-bindings for the Cadence USB controller. Signed-off-by: Sherry Sun --- doc/device-tree-bindings/usb/cdns-usb3.txt | 53 ++ 1 file changed, 53 insertions(+) create mode 100644 doc/device-tree-bindings/usb/cdns-usb3.txt diff --git

[U-Boot] [PATCH v5 0/7] usb: Add cadence USB3 gadget/host/phy driver

2019-08-21 Thread Sherry Sun
Use "cdns,usb3-1.0.0" compatible instead "cdns,usb3". - Add DM_FLAG_OS_PREPARE flag to xhci-imx8 driver. Sherry Sun (7): dt-bindings: add dt-binding doc for CDNS3 controller usb: gadget: Add the cadence USB3 gadget driver usb: gadget: Add match_ep call back to usb

Re: [U-Boot] [PATCH v4 2/4] USB: host: Add the USB3 host driver

2019-08-20 Thread Sherry Sun
Hi Marek, > > On 8/20/19 5:42 PM, Sherry Sun wrote: > [...] > > >>>>>>> +U_BOOT_DRIVER(xhci_imx8) = { > >>>>>>> + .name = "xhci_imx8", > >>>>>>> + .id = UCLASS_USB, > >>

Re: [U-Boot] [PATCH v4 2/4] USB: host: Add the USB3 host driver

2019-08-20 Thread Sherry Sun
Hi Marek, > > On 8/20/19 5:24 PM, Sherry Sun wrote: > > Hi Marek, > > Hi, > > >> On 8/20/19 10:31 AM, Sherry Sun wrote: > >>> Hi Marek, > >>> > >>>> > >>>> On 8/19/19 8:10 AM, Sherry S

Re: [U-Boot] [PATCH v4 2/4] USB: host: Add the USB3 host driver

2019-08-20 Thread Sherry Sun
Hi Marek, > > On 8/20/19 10:31 AM, Sherry Sun wrote: > > Hi Marek, > > > >> > >> On 8/19/19 8:10 AM, Sherry Sun wrote: > >>> Add the USB3 host driver for NXP imx8 platform, and the cadence IP > >>> is in it. The USB3 host drive

Re: [U-Boot] [PATCH v4 2/4] USB: host: Add the USB3 host driver

2019-08-20 Thread Sherry Sun
Hi Marek, > > On 8/19/19 8:10 AM, Sherry Sun wrote: > > Add the USB3 host driver for NXP imx8 platform, and the cadence IP is > > in it. The USB3 host driver support DM mode, it will probe USB3 host > > node in dts. > > > > Signed-off-by: Sherry

Re: [U-Boot] [PATCH v4 1/4] USB: gadget: Add the cadence USB3 gadget driver

2019-08-20 Thread Sherry Sun
Hi Marek, > > On 8/19/19 8:10 AM, Sherry Sun wrote: > > This driver is ported from NXP i.MX U-Boot version imx_v2019.04 and > > some changes have also been made to adapt to U-Boot. > > > > Add the Cadence USB3 IP(CDNS3) driver for the gadget (device mode). > >

[U-Boot] [PATCH v4 1/4] USB: gadget: Add the cadence USB3 gadget driver

2019-08-19 Thread Sherry Sun
. Signed-off-by: Sherry Sun --- Makefile |1 + doc/device-tree-bindings/usb/cdns-usb3.txt | 39 + drivers/usb/Kconfig|2 + drivers/usb/cdns3/Kconfig | 20 + drivers/usb/cdns3/Makefile |5 + drivers

Re: [U-Boot] [PATCH 0/4] Make some changes to SDP

2019-08-19 Thread Sherry Sun
lso get my test patches at https://github.com/sherrysun1/u-boot-imx.git. You just need check the first four patches which I used to test for imx8mq_evk. And feel free to let me know if any problems. Best regards Sherry sun Hi Sherry, On Aug. 8, 2019 2:38 a.m., Sherry Sun mailto:sherry@nx

[U-Boot] [PATCH v4 3/4] phy: Add USB PHY driver for the cadence USB3

2019-08-19 Thread Sherry Sun
The cdns3-usb-phy driver supports both host and peripheral mode of usb driver which use cadence usb3 IP. Signed-off-by: Sherry Sun --- drivers/phy/Kconfig | 8 ++ drivers/phy/Makefile| 1 + drivers/phy/cdns3-usb-phy.c | 241 3 files

[U-Boot] [PATCH v4 4/4] USB: gadget: core: introduce ->udc_set_speed() method

2019-08-19 Thread Sherry Sun
. So here introduce a new optional ->udc_set_speed() method which can be implemented by interested UDC drivers to achieve this purpose. Signed-off-by: Sherry Sun --- drivers/usb/gadget/udc/udc-core.c | 23 +++ include/linux/usb/gadget.h| 2 ++ 2 files changed,

[U-Boot] [PATCH v4 2/4] USB: host: Add the USB3 host driver

2019-08-19 Thread Sherry Sun
Add the USB3 host driver for NXP imx8 platform, and the cadence IP is in it. The USB3 host driver support DM mode, it will probe USB3 host node in dts. Signed-off-by: Sherry Sun --- drivers/usb/host/Kconfig | 9 ++ drivers/usb/host/Makefile| 1 + drivers/usb/host/xhci-imx8.c | 209

[U-Boot] [PATCH v4 0/4] USB: Add cadence USB3 gadget/host/phy driver

2019-08-19 Thread Sherry Sun
at https://github.com/sherrysun1/u-boot-imx.git to start your test quickly. Changes in v4: - Keep all include list in files sorted. - Delete the unnecessary registers read in code. - Add ret return after wait_for_bit_le32() is failed. - Add macros instead those magic values. Sherry Sun (4

Re: [U-Boot] [PATCH v3 2/4] USB: host: Add the USB3 host driver

2019-08-18 Thread Sherry Sun
Hi Marek, > > On 8/16/19 8:10 AM, Sherry Sun wrote: > > [...] > > > diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index > > ac68aa2d27..cc1dfe463b 100644 > > --- a/drivers/usb/host/Kconfig > > +++ b/drivers/usb/host/Kconfig >

[U-Boot] 答复: 答复: [PATCH v2 1/4] USB: gadget: Add the cadence USB3 gadget driver

2019-08-17 Thread Sherry Sun
Hi Marek > > On 8/16/19 6:45 AM, Sherry Sun wrote: > > Hi Marek > > > >> > >> On 8/14/19 2:16 PM, sherry sun wrote: > >>> From: Sherry Sun > >>> > >>> This driver is ported from NXP i.MX U-Boot version imx_v2019.04 and &g

[U-Boot] [PATCH v3 1/4] USB: gadget: Add the cadence USB3 gadget driver

2019-08-16 Thread Sherry Sun
. Signed-off-by: Sherry Sun --- Makefile |1 + doc/device-tree-bindings/usb/cdns-usb3.txt | 39 + drivers/usb/Kconfig|2 + drivers/usb/cdns3/Kconfig | 20 + drivers/usb/cdns3/Makefile |5 + drivers

[U-Boot] [PATCH v3 4/4] USB: gadget: core: introduce ->udc_set_speed() method

2019-08-16 Thread Sherry Sun
. So here introduce a new optional ->udc_set_speed() method which can be implemented by interested UDC drivers to achieve this purpose. Signed-off-by: Sherry Sun --- drivers/usb/gadget/udc/udc-core.c | 23 +++ include/linux/usb/gadget.h| 2 ++ 2 files changed,

[U-Boot] [PATCH v3 2/4] USB: host: Add the USB3 host driver

2019-08-16 Thread Sherry Sun
Add the USB3 host driver for NXP imx8 platform, and the cadence IP is in it. The USB3 host driver support DM mode, it will probe USB3 host node in dts. Signed-off-by: Sherry Sun --- drivers/usb/host/Kconfig | 9 ++ drivers/usb/host/Makefile| 1 + drivers/usb/host/xhci-imx8.c | 189

[U-Boot] [PATCH v3 3/4] phy: Add USB PHY driver for the cadence USB3

2019-08-16 Thread Sherry Sun
The cdns3-usb-phy driver supports both host and peripheral mode of usb driver which use cadence usb3 IP. Signed-off-by: Sherry Sun --- drivers/phy/Kconfig | 8 ++ drivers/phy/Makefile| 1 + drivers/phy/cdns3-usb-phy.c | 243 3 files

[U-Boot] [PATCH v3 0/4] USB: Add cadence USB3 gadget/host/phy driver

2019-08-16 Thread Sherry Sun
) into two functions: cdns3_host_role_set() and cdns3_gadget_role_set(). Sherry Sun (4): USB: gadget: Add the cadence USB3 gadget driver USB: host: Add the USB3 host driver phy: Add USB PHY driver for the cadence USB3 USB: gadget: core: introduce ->udc_set_sp

[U-Boot] 答复: [PATCH v2 1/4] USB: gadget: Add the cadence USB3 gadget driver

2019-08-15 Thread Sherry Sun
Hi Marek > > On 8/14/19 2:16 PM, sherry sun wrote: > > From: Sherry Sun > > > > This driver is ported from NXP i.MX U-Boot version imx_v2019.04 and > > some changes have also been made to adapt to U-Boot. > > > > Add the Cadence USB3 IP(CDNS3) driver f

[U-Boot] 答复: [PATCH v2 2/4] USB: host: Add the USB3 host driver

2019-08-14 Thread Sherry Sun
Hi Marek, > > Hi Marek, > > > > > On 8/14/19 2:16 PM, sherry sun wrote: > > > From: Sherry Sun > > > > > > Add the USB3 host driver for NXP imx8 platform, and the cadence IP > > > is in it. The USB3 host driver support DM mode, it will p

[U-Boot] 答复: [PATCH v2 2/4] USB: host: Add the USB3 host driver

2019-08-14 Thread Sherry Sun
Hi Marek, > > On 8/14/19 2:16 PM, sherry sun wrote: > > From: Sherry Sun > > > > Add the USB3 host driver for NXP imx8 platform, and the cadence IP is > > in it. The USB3 host driver support DM mode, it will probe USB3 host > > node in dts. > > We alr

[U-Boot] [PATCH v2 1/4] USB: gadget: Add the cadence USB3 gadget driver

2019-08-14 Thread sherry sun
From: Sherry Sun This driver is ported from NXP i.MX U-Boot version imx_v2019.04 and some changes have also been made to adapt to U-Boot. Add the Cadence USB3 IP(CDNS3) driver for the gadget (device mode). The CDNS3 gadget driver support DM mode. CONFIG_DM_USB_GADGET should be enabled when use

[U-Boot] [PATCH v2 3/4] phy: Add USB PHY driver for the cadence USB3

2019-08-14 Thread sherry sun
From: Sherry Sun The cdns3-usb-phy driver supports both host and peripheral mode of usb driver which use cadence usb3 IP. Signed-off-by: Sherry Sun --- drivers/phy/Kconfig | 8 ++ drivers/phy/Makefile| 1 + drivers/phy/cdns3-usb-phy.c | 242

[U-Boot] [PATCH v2 4/4] USB: gadget: core: introduce ->udc_set_speed() method

2019-08-14 Thread sherry sun
From: Sherry Sun This patch was copied from kernel commit: 67fdfda4a99ed. Sometimes, the gadget driver we want to run has max_speed lower than what the UDC supports. In such situations, UDC might want to make sure we don't try to connect on speeds not supported by the gadget driver because

[U-Boot] [PATCH v2 2/4] USB: host: Add the USB3 host driver

2019-08-14 Thread sherry sun
From: Sherry Sun Add the USB3 host driver for NXP imx8 platform, and the cadence IP is in it. The USB3 host driver support DM mode, it will probe USB3 host node in dts. Signed-off-by: Sherry Sun --- drivers/usb/host/Kconfig | 9 ++ drivers/usb/host/Makefile| 1 + drivers/usb/host

[U-Boot] [PATCH v2 0/4] USB: Add cadence USB3 gadget driver and host driver

2019-08-14 Thread sherry sun
From: Sherry Sun These patches introduce new Cadence USBSS driver to U-Boot. The first patch is to add the Cadence USB3 IP(CDNS3) core and driver for the usb gadget. The second patch introduce the xhci-imx8 usb host driver separately. The third patch introduce the cdns3 phy driver which can

[U-Boot] 答复: 答复: 答复: [PATCH 0/4] Make some changes to SDP

2019-08-09 Thread Sherry Sun
Hi Angus, Hi Sherry, On Aug. 8, 2019 2:38 a.m., Sherry Sun mailto:sherry@nxp.com>> wrote: Hi Angus, Sorry for the late reply. > -邮件原件- > 发件人: Angus Ainslie mailto:an...@akkea.ca>> > 发送时间: 2019年8月2日 10:30 > 收件人: Peng Fan mailto:peng....@nxp.com>>

[U-Boot] 答复: 答复: [PATCH 0/4] Make some changes to SDP

2019-08-08 Thread Sherry Sun
Hi Angus, Sorry for the late reply. > -邮件原件- > 发件人: Angus Ainslie > 发送时间: 2019年8月2日 10:30 > 收件人: Peng Fan > 抄送: Sherry Sun ; sba...@denx.de; > feste...@gmail.com; lu...@denx.de; ma...@denx.de; > u-boot@lists.denx.de; dl-uboot-imx > 主题: Re: 答复: [U-Boot] [PATC

[U-Boot] 答复: [PATCH 0/3] USB: Add cadence USB3 gadget driver and host driver

2019-08-08 Thread Sherry Sun
Hi Igor, Sorry for the late reply. > > Igor, > > > Subject: Re: [U-Boot] [PATCH 0/3] USB: Add cadence USB3 gadget driver > > and host driver > > > > Hi Sherry, > > > > On Tue, Jul 16, 2019 at 4:15 PM sherry sun > wrote: > > > > &

[U-Boot] 答复: [PATCH 2/3] USB: host: Add the USB3 host driver

2019-08-01 Thread Sherry Sun
Hi, Marek I'm so sorry to check the e-mail and reply you so late. > On 7/16/19 2:08 PM, sherry sun wrote: > > From: Sherry Sun > > > > This driver is ported from NXP i.MX U-Boot version imx_v2019.04 and > > some changes have also been made to adapt to U-Boot. >

[U-Boot] 答复: [PATCH 0/4] Make some changes to SDP

2019-07-31 Thread Sherry Sun
Hi Angus > > Hi Sherry, > > On 2019-07-17 18:40, sherry sun wrote: > > From: Sherry Sun > > > > This patchset adds: > > 1. Add usb_gadget_initialize() and usb_gadget_release() to initialize > > and release UDC during sdp download. > > 2. Add hi

[U-Boot] 答复: [EXT] Re: Upstreaming usb host drivers for iMX8/iMX8M

2019-07-24 Thread Sherry Sun
Hi,Igor > -邮件原件- > 发件人: Igor Opaniuk > 发送时间: 2019年7月23日 20:43 > 收件人: Sherry Sun > 抄送: Ying Liu ; Peng Fan ; Jun Li > ; Ye Li ; U-Boot Mailing List > ; Peter Chen ; dl-uboot-imx > ; Marcel Ziswiler ; Max > Krummenacher ; Igor Opaniuk > ; Frank Li > 主题: R

[U-Boot] 答复: [PATCH 1/4] imx: spl: Change USB boot device type

2019-07-18 Thread Sherry Sun
i Lukasz, > > > > > > > > > Subject: Re: [PATCH 1/4] imx: spl: Change USB boot device type > > > > > > > > > > Hi Sherry, > > > > > > > > > > > From: Sherry Sun > > > >

[U-Boot] 答复: [EXT] Re: [PATCH 1/4] imx: spl: Change USB boot device type

2019-07-18 Thread Sherry Sun
Hi, Lukasz > > On Thu, 18 Jul 2019 07:38:10 + > Peng Fan wrote: > > > Hi Lukasz, > > > > > Subject: Re: [PATCH 1/4] imx: spl: Change USB boot device type > > > > > > Hi Sherry, > > > > > > > From: Sherry Sun > &g

[U-Boot] 答复: [PATCH 3/4] SDP: fix wrong usb request size and add high speed endpoint descriptor

2019-07-18 Thread Sherry Sun
Hi, Lukasz > > Hi Sherry, > > > From: Sherry Sun > > > > Because the buffer length of sdp usb request is 65, > > Is the value 65 mentioned somewhere (in any doc/spec)? > > As fair as I remember other protocols - like DFU use 64B. Do we need here to &

[U-Boot] [PATCH 3/4] SDP: fix wrong usb request size and add high speed endpoint descriptor

2019-07-17 Thread sherry sun
From: Sherry Sun Because the buffer length of sdp usb request is 65, we have to allocate 65 bytes not 64 bytes. Otherwise there is potential buffer overflow. So the wMaxPacketSize of fullspeed can't meet the needs. Add HS endpoint descriptor for SDP. Then we can use high speed endpoint

[U-Boot] [PATCH 0/4] Make some changes to SDP

2019-07-17 Thread sherry sun
From: Sherry Sun This patchset adds: 1. Add usb_gadget_initialize() and usb_gadget_release() to initialize and release UDC during sdp download. 2. Add high speed endpoint descriptor for sdp. 3. Add a macro definition--CONFIG_SDP_LOADADDR as default sdp load address while SDP_WRITE and SDP_JUMP

[U-Boot] [PATCH 2/4] SDP: use CONFIG_SDP_LOADADDR as default load address

2019-07-17 Thread sherry sun
From: Sherry Sun If SDP_WRITE and SDP_JUMP command addr is zero, use CONFIG_SDP_LOADADDR as default address. Signed-off-by: Sherry Sun Signed-off-by: Frank Li --- drivers/usb/gadget/Kconfig | 4 drivers/usb/gadget/f_sdp.c | 6 -- 2 files changed, 8 insertions(+), 2 deletions

[U-Boot] [PATCH 4/4] SDP: Call usb_gadget_initialize and usb_gadget_release to support UDC

2019-07-17 Thread sherry sun
From: Sherry Sun Need initialize UDC before run sdp download and release it at the end of sdp. Signed-off-by: Sherry Sun Signed-off-by: Frank Li --- common/spl/spl_sdp.c | 4 1 file changed, 4 insertions(+) diff --git a/common/spl/spl_sdp.c b/common/spl/spl_sdp.c index 806bf1327e

[U-Boot] [PATCH 1/4] imx: spl: Change USB boot device type

2019-07-17 Thread sherry sun
From: Sherry Sun The SPL SDP is configured as BOOT_DEVICE_BOARD, so when booting from USB, change its type to BOOT_DEVICE_BOARD, so we can use SDP. Signed-off-by: Sherry Sun Signed-off-by: Ye Li --- arch/arm/mach-imx/spl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[U-Boot] [PATCH 3/3] USB: gadget: core: introduce ->udc_set_speed() method

2019-07-16 Thread sherry sun
From: Sherry Sun This patch was copied from kernel commit: 67fdfda4a99ed. Sometimes, the gadget driver we want to run has max_speed lower than what the UDC supports. In such situations, UDC might want to make sure we don't try to connect on speeds not supported by the gadget driver because

[U-Boot] [PATCH 2/3] USB: host: Add the USB3 host driver

2019-07-16 Thread sherry sun
From: Sherry Sun This driver is ported from NXP i.MX U-Boot version imx_v2019.04 and some changes have also been made to adapt to U-Boot. Add the USB3 host driver for NXP imx8 platform, and the cadence IP is in it. The USB3 host driver support DM mode. It will probe USB3 host node, enable

[U-Boot] [PATCH 0/3] USB: Add cadence USB3 gadget driver and host driver

2019-07-16 Thread sherry sun
From: Sherry Sun These patches introduce new Cadence USBSS driver to U-Boot. The first patch is to add the Cadence USB3 IP(CDNS3) driver for the usb gadget, but the host mode is not supported now. The second patch introduce the xhci-imx8 usb host driver separately. The cdns3 usb gadget driver

[U-Boot] 答复: [EXT] Re: Upstreaming usb host drivers for iMX8/iMX8M

2019-07-01 Thread Sherry Sun
+ Ying > -邮件原件- > 发件人: Igor Opaniuk > 发送时间: 2019年7月1日 19:32 > 收件人: Sherry Sun > 抄送: Peng Fan ; Jun Li ; Ye Li > ; U-Boot Mailing List ; Peter Chen > ; dl-uboot-imx ; Marcel Ziswiler > ; Max Krummenacher > ; Igor Opaniuk > ; Frank Li > 主题: [EXT] Re: Upst