Re: [PATCH v4 14/14] dtoc: add test for cd-gpios

On Wed, 24 Jun 2020 at 22:11, Walter Lozano wrote: > > Add a test for dtoc taking into account the cd-gpios property. > > Signed-off-by: Walter Lozano > --- > > tools/dtoc/dtoc_test_phandle_cd_gpios.dts | 42 ++ > tools/dtoc/test_dtoc.py | 67 +++

Re: [PATCH v2] doc: driver-model: fix typo in design.rst

Fix the 'memeber' typo in doc/driver-model/design.rst. Signed-off-by: Dario Binacchi Reviewed-by: Simon Glass --- Changes in v2: - Add the commit message doc/driver-model/design.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied to u-boot-dm, thanks!

Re: [PATCH v2 02/14] rmboard: Move to Python 3

This script already works with Python 3. Make it use that by default so that it can import the patman libraries. Signed-off-by: Simon Glass --- Changes in v2: None tools/rmboard.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied to u-boot-dm, thanks!

Re: [PATCH v2 25/32] gitlab: Disable SDL when building sandbox

I am not sure how to add libsdl2-dev to the gitlab image, so disable building sandbox with SDL for now. Signed-off-by: Simon Glass --- Changes in v2: None .gitlab-ci.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v2] cli: Make the sandbox board_run_command the default

On Sat, Jan 11, 2020 at 1:32 AM Sean Anderson wrote: > > If CONFIG_CMDLINE=n, common/cli.c calls board_run_command. This fails to > link on most architectures. However, the sandbox architecture has an > implementation which we can use. > > Signed-off-by: Sean Anderson > --- > Changes for v2: > -

Re: [PATCH] buildman: Enable buildman on aarch64 hosts

On Fri, 17 Jan 2020 at 02:53, wrote: > > From: Matthias Brugger > > At kernel.org aarch64 toolchains are published in folder > arm64. Fix the URL for that case, so that we can fetch > toolchains on aarch64 machines. > > Signed-off-by: Matthias Brugger > > --- > > tools/buildman/toolchain.py | 2

Re: [PATCH] dtc: add ability to make nodes conditional on them being referenced

On Tue, 28 Jan 2020 10:07:18 -0700 Simon Glass wrote: Hi Simon, > On Sat, 25 Jan 2020 at 16:18, André Przywara wrote: > > > > On 25/01/2020 16:20, Tom Rini wrote: > > > > Hi Tom, > > > > thanks for having a look! > > > > > > > On Tue, Jan 21, 2020 at 10:23:17AM +, Andre Przywara wrote: > >

Re: [PATCH] tpm2: ftpm: A driver for firmware TPM running inside TEE

Hi Thirupathaiah, On Tue, 4 Feb 2020 at 10:08, Thirupathaiah Annapureddy wrote: > > Hi All, > > May I know what are the next steps in making forward progress on this? Can you please add a test for this? We need a sandbox driver of some sort - see the existing sandbox TPM driver. Regards, Simon

Re: [PATCH 01/21] dm: core: Use const where possible in device.h

Update this header file to use const devices where possible, to permit callers to also use const. Signed-off-by: Simon Glass --- drivers/core/device.c | 27 ++- include/dm/device.h | 30 -- include/dm/read.h | 4 ++-- 3 files changed, 3

Re: [PATCH 03/21] dm: pci: Update a few more interfaces for const udevice *

Tidy up a few places where const * should be used. Signed-off-by: Simon Glass --- drivers/pci/pci-uclass.c | 18 +- include/fdtdec.h | 2 +- include/pci.h| 16 lib/fdtdec.c | 2 +- 4 files changed, 19 insertions(+), 19 deletions

Re: [PATCH 04/21] dm: core: Use const device for the devfdt...() interface

These functions do not modify the device so should use a const pointer to it. Update the code accordingly. Signed-off-by: Simon Glass --- drivers/core/fdtaddr.c | 26 +- include/dm/fdtaddr.h | 26 +- 2 files changed, 26 insertions(+), 26 deletio

Re: [PATCH 05/21] dm: core: Use const device for the dev_read_...() interface

These functions do not modify the device so should use a const pointer to it. Update the code accordingly. Signed-off-by: Simon Glass --- drivers/core/read.c | 97 +++-- include/dm/read.h | 205 +++- 2 files changed, 159 insertions(+),

Re: [PATCH 19/21] console: Add a function to read a line of the output / eof

When recording the console output for testing it is useful to be able to read the output a line at a time to check that the output is correct. Also we need to check that we get to the end of the output. Add a console function to return the next line and another to see how must data is left. Signe

Re: [PATCH 20/21] test: Enable console recording in tests

At present we reset the console buffer before each test but do not actually set the recording flag. Without this, the output is not recorded. Update the code to set the flag before the test and clear it afterwards. Signed-off-by: Simon Glass --- test/dm/test-main.c | 4 ++-- 1 file changed, 2

Re: [PATCH] doc: dm: debugging: Fix the steps for activating debug

On Wed, 29 Jan 2020 at 10:45, Fabio Estevam wrote: > > Following the recommendation of adding '#define DEBUG' at the top > of drivers/core/lists.c does not cause the debug messages to be > shown. Change it to '#define LOG_DEBUG' instead, which actually > makes it work as per doc/README.log. > > Wh

Re: [PATCH] Include missing headers for fdt_support.h

fdt_support.h is missing declarations for bd_t. Including asm/u-boot.h pulls in the definition. Signed-off-by: Sean Anderson --- include/fdt_support.h | 1 + 1 file changed, 1 insertion(+) Applied to u-boot-dm, thanks!

Re: [PATCH 07/19] dm: core: Don't clear active flag twice when probe() fails

Remove this duplicated code, since the 'fail' label does this immediately. Signed-off-by: Simon Glass --- drivers/core/device.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH 06/19] aspeed: ast2500: Read clock ofdata in the correct method

Hi Cédric, On Tue, 7 Jan 2020 at 21:20, Cédric Le Goater wrote: > > On 12/30/19 5:19 AM, Simon Glass wrote: > > At present the clock driver reads its ofdata in the probe() method. This > > is not correct although it is often harmless. > > > > However in this case it causes a problem, something li

Re: [PATCH 08/19] dm: core: Move ofdata_to_platdata() call earlier

This method is supposed to extract platform data from the device tree. It should be done before the device itself is probed. Move it earlier in the device_probe() function. Signed-off-by: Simon Glass --- drivers/core/device.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-)

Re: [PATCH 11/19] dm: core: Export a new function to read platdata

Add a new internal function, device_ofdata_to_platdata() to handle allocating private space associated with each device and reading the platform data from the device tree. Call this new function from device_probe(). Signed-off-by: Simon Glass --- drivers/core/device.c| 29 +

Re: [PATCH 10/19] dm: core: Add a comment for DM_FLAG_OF_PLATDATA

This flag is missing a comment. Add one. Signed-off-by: Simon Glass --- include/dm/device.h | 1 + 1 file changed, 1 insertion(+) Applied to u-boot-dm, thanks!

Re: [PATCH 12/19] dm: core: Add a new flag to track platform data

We want to avoid allocating platform data twice. This could happen if device_probe() is called after device_ofdata_to_platdata() for the same device. Add a flag to track whether device_ofdata_to_platdata() has been called on a device. Check the flag to make sure it doesn't happen twice, and clear

Re: [PATCH 14/19] test: Add functions to find the amount of allocated memory

The malloc() implementations provides a way of finding out the approximate amount of memory that is allocated. Add helper functions to make it easier to access this and see changes over time. This is useful for tests that want to check if memory has been allocated or freed. Signed-off-by: Simon Gl

Re: [PATCH 15/19] dm: devres: Convert to use logging

At present when CONFIG_DEBUG_DEVRES is enabled, U-Boot prints log messages to the console with every devres allocation/free event. This causes most tests to fail since the console output is not as expected. In particular this prevents us from adding a device to sandbox which uses devres in its bin

Re: [PATCH 18/19] dm: devres: Use an enum for the allocation phase

At present we only support two phases where devres can be used: bind and probe. This is handled with a boolean. We want to add a new phase (platdata), so change this to an enum. Signed-off-by: Simon Glass --- drivers/core/devres.c | 22 -- 1 file changed, 16 insertions(+), 6

Re: [PATCH 16/19] dm: test: Add a test driver for devres

Add a driver which does devres allocations so that we can write tests for devres. Signed-off-by: Simon Glass --- arch/sandbox/dts/test.dts | 4 include/dm/uclass-id.h| 1 + include/test/test.h | 9 test/dm/test-fdt.c| 47 +++

Re: [PATCH 17/19] dm: devres: Add tests

The devres functionality has very few users in U-Boot, but it still should have tests. Add a few basic tests of the main functions. Signed-off-by: Simon Glass --- drivers/core/devres.c | 13 +++ include/dm/devres.h | 20 + test/dm/Makefile | 1 + test/dm/devres.c | 178 +

Re: [PATCH 19/19] dm: devres: Add a new OFDATA phase

Since the ofdata_to_platdata() method can allocate resources, add it as a new devres phase. Signed-off-by: Simon Glass --- drivers/core/devres.c | 18 +- include/test/test.h | 3 ++- test/dm/devres.c | 14 +++--- test/dm/test-fdt.c| 11 +++ 4 files ch

Re: [U-Boot] [PATCH v3 2/4] fdtdec: only create phandle if caller wants it in fdtdec_add_reserved_memory()

Am Mittwoch, 23. Oktober 2019, 16:46:39 CET schrieb Heiko Stuebner: > From: Heiko Stuebner > > The phandlep pointer returning the phandle to the caller is optional > and if it is not set when calling fdtdec_add_reserved_memory() it is > highly likely that the caller is not interested in a phandle

Re: [U-Boot] [PATCH v3 1/4] fdtdec: protect against another NULL phandlep in fdtdec_add_reserved_memory()

Am Mittwoch, 23. Oktober 2019, 16:46:38 CET schrieb Heiko Stuebner: > From: Heiko Stuebner > > The change adding fdtdec_add_reserved_memory() already protected the added > phandle against the phandlep being NULL - making the phandlep var optional. > > But in the early code checking for an already

Re: [U-Boot] [PATCH 01/13] pinctrol: dm: remove the function pinctrl_decode_pin_config

On Wed, 23 Oct 2019 at 07:44, Patrick Delaunay wrote: > > Remove the pinctrl_decode_pin_config() API, because this > function is unused and not compatible with livetree > (it uses fdtdec_get_bool instead of ofnode API). > > Signed-off-by: Patrick Delaunay > --- > > drivers/pinctrl/pinctrl-uclass

Re: [U-Boot] [PATCH 1/1] sandbox: use correct type reading /proc/self/maps

On Sat, 26 Oct 2019 at 15:17, Heinrich Schuchardt wrote: > > Compiling arch/sandbox/cpu/os.c results in an error > > ../arch/sandbox/cpu/os.c: In function ‘os_find_text_base’: > ../arch/sandbox/cpu/os.c:823:12: error: cast to pointer from > integer of different size [-Werror=int-to-pointer-cast] >

Re: [U-Boot] [PATCH] patman: fix coverletter cc list with nulls

Hi Robert, On Wed, 13 Nov 2019 at 12:40, Robert Beckett wrote: > > fixes: 8ab452d5877638a97e5bdd521d119403b70b45f5 > > When compiling list of cover letter cc addresses, using null as a > separater, then encoding to utf-8 results in lots of "\x00" as > separators. patman then doesnt understand tha

Re: [U-Boot] [PATCH] patman: fix some typos in comments

On Sun, 27 Oct 2019 at 10:55, Anatolij Gustschin wrote: > > s/Subprocress/Subprocess/ > s/easiler/easier/ > s/repositiory/repository/ > s/rangem/range/ > s/Retruns/Returns/ > > Signed-off-by: Anatolij Gustschin > --- > tools/patman/cros_subprocess.py | 4 ++-- > tools/patman/gitutil.py |

Re: [U-Boot] [PATCH] patman: fix coverletter cc list with nulls

Hi Robert, On Wed, 13 Nov 2019 at 12:40, Robert Beckett wrote: > > fixes: 8ab452d5877638a97e5bdd521d119403b70b45f5 > > When compiling list of cover letter cc addresses, using null as a > separater, then encoding to utf-8 results in lots of "\x00" as > separators. patman then doesnt understand tha

Re: [U-Boot] [PATCH 1/1] sandbox: use correct type reading /proc/self/maps

On Sat, 26 Oct 2019 at 15:17, Heinrich Schuchardt wrote: > > Compiling arch/sandbox/cpu/os.c results in an error > > ../arch/sandbox/cpu/os.c: In function ‘os_find_text_base’: > ../arch/sandbox/cpu/os.c:823:12: error: cast to pointer from > integer of different size [-Werror=int-to-pointer-cast] >

Re: [U-Boot] [PATCH v3 4/4] tests: add OP-TEE test suite

Am Mittwoch, 23. Oktober 2019, 16:46:41 CET schrieb Heiko Stuebner: > From: Heiko Stuebner > > OP-TEE can get supplied with a devicetree and will then insert > its firmware node and reserved-memory sections into it. > As this devicetree often is not the one supplied to a later > loaded kernel, a p

Re: [U-Boot] [PATCH v3 2/4] fdtdec: only create phandle if caller wants it in fdtdec_add_reserved_memory()

Am Mittwoch, 23. Oktober 2019, 16:46:39 CET schrieb Heiko Stuebner: > From: Heiko Stuebner > > The phandlep pointer returning the phandle to the caller is optional > and if it is not set when calling fdtdec_add_reserved_memory() it is > highly likely that the caller is not interested in a phandle

Re: [U-Boot] [PATCH 1/1] sandbox: use correct type reading /proc/self/maps

On Sat, 26 Oct 2019 at 15:17, Heinrich Schuchardt wrote: > > Compiling arch/sandbox/cpu/os.c results in an error > > ../arch/sandbox/cpu/os.c: In function ‘os_find_text_base’: > ../arch/sandbox/cpu/os.c:823:12: error: cast to pointer from > integer of different size [-Werror=int-to-pointer-cast] >

Re: [U-Boot] [PATCH] patman: fix some typos in comments

On Sun, 27 Oct 2019 at 10:55, Anatolij Gustschin wrote: > > s/Subprocress/Subprocess/ > s/easiler/easier/ > s/repositiory/repository/ > s/rangem/range/ > s/Retruns/Returns/ > > Signed-off-by: Anatolij Gustschin > --- > tools/patman/cros_subprocess.py | 4 ++-- > tools/patman/gitutil.py |

Re: [U-Boot] [PATCH v3 4/4] tests: add OP-TEE test suite

Am Mittwoch, 23. Oktober 2019, 16:46:41 CET schrieb Heiko Stuebner: > From: Heiko Stuebner > > OP-TEE can get supplied with a devicetree and will then insert > its firmware node and reserved-memory sections into it. > As this devicetree often is not the one supplied to a later > loaded kernel, a p

Re: [U-Boot] [PATCH] patman: fix some typos in comments

On Sun, 27 Oct 2019 at 10:55, Anatolij Gustschin wrote: > > s/Subprocress/Subprocess/ > s/easiler/easier/ > s/repositiory/repository/ > s/rangem/range/ > s/Retruns/Returns/ > > Signed-off-by: Anatolij Gustschin > --- > tools/patman/cros_subprocess.py | 4 ++-- > tools/patman/gitutil.py |

Re: [U-Boot] [PATCH] patman: fix coverletter cc list with nulls

Hi Robert, On Wed, 13 Nov 2019 at 12:40, Robert Beckett wrote: > > fixes: 8ab452d5877638a97e5bdd521d119403b70b45f5 > > When compiling list of cover letter cc addresses, using null as a > separater, then encoding to utf-8 results in lots of "\x00" as > separators. patman then doesnt understand tha

Re: [U-Boot] [PATCH v2 13/17] binman: Remember the pre-reset entry size

When preparing to possible expand or contract an entry we reset the size to the original value from the binman device-tree definition, which is often None. This causes binman to forget the original size of the entry. Remember this so that it can be used when needed. Signed-off-by: Simon Glass --

Re: [U-Boot] [PATCH v2 10/17] pylibfdt: Convert to Python 3

Build this swig module with Python 3. Signed-off-by: Simon Glass --- Changes in v2: None scripts/dtc/pylibfdt/Makefile | 2 +- scripts/dtc/pylibfdt/libfdt.i_shipped | 2 +- scripts/dtc/pylibfdt/setup.py | 2 +- tools/binman/entry.py | 16 ++-- too

Re: [U-Boot] [PATCH v2 08/17] move_config: Convert to Python 3

Convert this tool to Python 3 and make it use that, to meet the 2020 deadline. Signed-off-by: Simon Glass --- Changes in v2: None tools/moveconfig.py | 82 ++--- 1 file changed, 41 insertions(+), 41 deletions(-) Applied to u-boot-fdt ___

Re: [U-Boot] [PATCH 4/4] fdt: Sync up to the latest libfdt

Bring over the fdt from this commit: 430419c (origin/master) tests: fix some python warnings adding in the 'assumptions' series designed to reduce code size. Signed-off-by: Simon Glass --- lib/libfdt/fdt_ro.c | 420 --- scripts/dtc/libfdt/Makefile.libf

Re: [U-Boot] [PATCH 3/4] mx6: tbs2910: Minimise libfdt code size

This board appears to be very near its size limit and cannot accept the new checking code in libfdt. Disable this code so this the board can continue to build. Signed-off-by: Simon Glass --- configs/tbs2910_defconfig | 1 + 1 file changed, 1 insertion(+) Applied to u-boot-fdt _

Re: [U-Boot] [PATCH v2 06/17] test_dtoc: Move to use Python 3

Update this test to use Python 3 to meet the 2020 deadline. Also make it executable while we are here. Signed-off-by: Simon Glass --- Changes in v2: None tools/dtoc/dtoc.py | 2 +- tools/dtoc/test_dtoc.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) mode change 100644 => 10075

Re: [U-Boot] [PATCH v2 11/17] pylibfdt: Sync up with upstream

Sync up the libfdt Python bindings with upstream, commit: 430419c (tests: fix some python warnings) Signed-off-by: Simon Glass --- Changes in v2: None scripts/dtc/pylibfdt/libfdt.i_shipped | 45 --- 1 file changed, 33 insertions(+), 12 deletions(-) Applied to u-boot-f

Re: [U-Boot] [PATCH v2 07/17] microcode_tool: Convert to Python 3

Convert this tool to Python 3 and make it use that, to meet the 2020 deadline. Signed-off-by: Simon Glass --- Changes in v2: None tools/microcode-tool.py | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) Applied to u-boot-fdt

Re: [U-Boot] [PATCH v2 09/17] rkmux: Convert to Python 3

Convert this tool to Python 3 and make it use that, to meet the 2020 deadline. Signed-off-by: Simon Glass --- Changes in v2: None tools/rkmux.py | 16 1 file changed, 8 insertions(+), 8 deletions(-) Applied to u-boot-fdt ___ U-Boot

Re: [U-Boot] [PATCH v2 03/17] patman: Move to use Python 3

Update this tool to use Python 3 to meet the 2020 deadline. Signed-off-by: Simon Glass --- Changes in v2: None tools/patman/patman.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied to u-boot-fdt ___ U-Boot mailing list U-Boot@lists.de

Re: [U-Boot] [PATCH v2 02/17] patman: Use unicode for file I/O

At present patman test fail in some environments which don't use utf-8 as the default file encoding. Add this explicitly. Signed-off-by: Simon Glass --- Changes in v2: - Add new patch to explicitly use unicode for file I/O in patman tools/patman/func_test.py | 8 tools/patman/patchs

Re: [U-Boot] [PATCH v2 05/17] test_fdt: Move to use Python 3

Update this test to use Python 3 to meet the 2020 deadline. Signed-off-by: Simon Glass --- Changes in v2: None tools/dtoc/test_fdt.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied to u-boot-fdt ___ U-Boot mailing list U-Boot@lists.de

Re: [U-Boot] [PATCH v2 12/17] pylibfdt: Correct the type for fdt_property_stub()

This function should use a void * type, not char *. This causes an error: TypeError: in method 'fdt_property_stub', argument 3 of type 'char const *' Fix it. Signed-off-by: Simon Glass --- Changes in v2: None scripts/dtc/pylibfdt/libfdt.i_shipped | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [U-Boot] [PATCH 2/4] fdt: Add Kconfig options to control code size

On Sun, Oct 27, 2019 at 09:47:40AM -0600, Simon Glass wrote: > For better or worse libfdt recent grew a lot of code that checks the > validity of the device tree in great detail. When using unsigned or > unverified data this makes things safer, but it does add to code size. > > Add some controls t

Re: [U-Boot] [PATCH v2 01/17] patman: Adjust 'command' to return strings instead of bytes

At present all the 'command' methods return bytes. Most of the time we actually want strings, so change this. We still need to keep the internal representation as bytes since otherwise unicode strings might break over a read() boundary (e.g. 4KB), causing errors. But we can convert the end result t

Re: [U-Boot] [PATCH v2 04/17] buildman: Convert to Python 3

Convert buildman to Python 3 and make it use that, to meet the 2020 deadline. Signed-off-by: Simon Glass --- Changes in v2: - Use integer division for multiprocessing.cpu_count() - Use integer division in SetupBuild() and GetActionSummary() - Use HTTPMessage.getheader() instead of HTTPMessage.ge

Re: [U-Boot] [PATCH 1/4] fdt: Add INT32_MAX to kernel.h for libfdt

On Sun, Oct 27, 2019 at 09:47:39AM -0600, Simon Glass wrote: > Unfortunately libfdt needs this value now, which is present in the > stdint.h header. That file is just a placeholder in U-Boot and these sorts > of constants appear in the linux/kernel.h header instead. > > To keep libfdt happy, add I

Re: [U-Boot] [PATCH v2 16/17] binman: Move to use Python 3

On Thu, Oct 31, 2019 at 10:12:04AM -0600, Simon Glass wrote: > Hi Tom, > > On Thu, 31 Oct 2019 at 09:50, Tom Rini wrote: > > > > On Thu, Oct 31, 2019 at 09:19:50AM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Thu, 31 Oct 2019 at 07:55, Tom Rini wrote: > > > > > > > > On Thu, Oct 31, 201

Re: [U-Boot] [PATCH v2 14/17] binman: Convert a few tests to Python 3

Some tests have crept in with Python 2 strings and constructs. Convert then. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/ftest.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) Applied to u-boot-fdt ___ U-Bo

Re: [U-Boot] [PATCH v2 15/17] dtoc: Convert fdt.py to Python 3

Drop the now-unused Python 2 code to keep code coverage at 100%. Signed-off-by: Simon Glass --- Changes in v2: None tools/dtoc/fdt.py | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) Applied to u-boot-fdt ___ U-Boot mailing l

Re: [U-Boot] [PATCH 4/5] dm: regmap: Fix mask in regmap_update_bits()

On 12/10/2019 00:16, Simon Glass wrote: > This function assumes that the 'val' parameter has no masked bits set. > This is not defined by the function prototype though. Fix the function to > mask the value and update the documentation. > > Signed-off-by: Simon Glass > --- > > drivers/core/regmap

Re: [U-Boot] [PATCH 1/5] sandbox: test: Show hex values on failure

On Sat, Oct 12, 2019 at 6:28 AM Simon Glass wrote: > > Quite a few tests use addresses or hex values for comparisons. Add hex > output for test failures, e.g.: > >0x55ca22fa == reg: Expected 0x55ca22fa (1439310586), > got 0x55ea22fb (1441407739) > > Signed-off-by: Simon Glass > --- >

Re: [U-Boot] [PATCH v2 03/10] tiny-printf: Reorder code to support %p

With a bit of code reordering we can support %p using the existing code for ulong. Move the %p code up and adjust the logic accordingly. Signed-off-by: Simon Glass --- Changes in v2: - Add a new patch to support %p without DEBUG lib/tiny-printf.c | 30 +- 1 file ch

Re: [U-Boot] [PATCH v2 09/10] bootstage: Mark the start/end of TPL and SPL separately

At present bootstage in TPL and SPL use the same ID so it is not possible to see the timing of each. Separate out the IDs and use the correct one depending on which phase we are at. Example output: Timer summary in microseconds (14 records): MarkElapsed Stage 0 0 r

Re: [U-Boot] [PATCH 3/5] sandbox: test: Add a prototype for sandbox_set_enable_memio()

On Sat, Oct 12, 2019 at 6:22 AM Simon Glass wrote: > > This function needs a prototype so that tests can use it. Add one. > > Signed-off-by: Simon Glass > --- > > arch/sandbox/include/asm/test.h | 11 +++ > 1 file changed, 11 insertions(+) > Reviewed-by: Bin Meng Applied to u-boot-dm,

Re: [U-Boot] [PATCH 5/5] test: regmap: check the values read from the regmap

On Sat, Oct 12, 2019 at 6:28 AM Simon Glass wrote: > > From: Jean-Jacques Hiblot > > The test did reads after writes but didn't check the value. > It probably was because the sandbox didn't implement the writeX/readX > functions. > > Signed-off-by: Jean-Jacques Hiblot > Updated to use sandbox_se

Re: [U-Boot] [PATCH v2 06/10] bootstage: Fix counting of entries in stash

The current code searches for empty records but these not existing with bootstage now. This used to be needed when bootstage records were stored in a spare array. Drop the unnecessary code and fix a code-style nit at the same time. Signed-off-by: Simon Glass --- Changes in v2: None common/boo

Re: [U-Boot] [PATCH v2 10/10] bootstage: Allow SPL to obtain bootstage info from TPL

It is possible to enable bootstage in TPL. TPL can stash the info for SPL. But at present this information is then lost because SPL does not read from the stash. Add support for SPL not being the first phase to enable bootstage. Signed-off-by: Simon Glass --- Changes in v2: - Adjust SPL logic to

Re: [U-Boot] [PATCH v2 04/10] bloblist: Reserve an aligned base

Make sure that the bloblist starts on an aligned boundary. This protects against one of the early allocating causing the alignment to be lost. Signed-off-by: Simon Glass --- Changes in v2: None common/board_f.c | 1 + 1 file changed, 1 insertion(+) Applied to u-boot-dm, thanks! __

Re: [U-Boot] [PATCH 2/5] sandbox: Drop 'const' from sandbox_write()

Hi Simon, On Sat, Oct 12, 2019 at 6:22 AM Simon Glass wrote: > > This function writes to its address so the address should not be declared > as const. Fix it. > > Signed-off-by: Simon Glass > --- > > arch/sandbox/cpu/cpu.c| 3 +-- > arch/sandbox/include/asm/io.h | 11 +-- > 2 f

Re: [U-Boot] [PATCH v2 07/10] bootstage: Avoid conflicts between stash/unstash

At present there is a single shared address for bootstage data in both TPL and SPL. If SPL unstashs TPL bootstage info and then stashes it again to pass it to U-Boot, the new stash overwrites the strings of the old stash. Fix this by duplicating the strings into the malloc() region. This should be

Re: [U-Boot] [PATCH v2 05/10] bootstage: Store the next ID in the stash

When stashing bootstage info, store the next ID so that it can be used when the stash is restored. This avoids the ID starting at zero and potentially overwriting existing entries. Signed-off-by: Simon Glass --- Changes in v2: None common/bootstage.c | 11 +++ 1 file changed, 7 inserti

Re: [U-Boot] [PATCH v2 08/10] bootstage: Correct relocation algorithm

At present bootstage relocation assumes that it is possible to point back to memory available before relocation, so it does not relocate the strings. However this is not the case on some platforms, such as x86 which uses the cache as RAM and loses access to this when the cache is enabled. Move the

Re: [U-Boot] [PATCH v2 01/10] tiny-printf: Reduce size by removing ctype

The ctype array is brought into the image, adding 256 bytes, when it is unlikely to be needed. The extra code for %p is only present when DEBUG is defined, so let's drop ctype as well unless DEBUG is defined. Signed-off-by: Simon Glass --- Changes in v2: None lib/tiny-printf.c | 7 +++ 1 f

Re: [U-Boot] [PATCH v2 02/10] tiny-printf: Add print_grouped_ull()

On 22.10.19 01:26, Simon Glass wrote: > This function is used in the bootstage report which may be trigged in TPL > or TPL. Add a very basic implication of this function so that it builds. > There is no attempt to get the formatting right, since this would add too > much code size. > > Signed-off-b

Re: [U-Boot] [PATCH v2] patman: separate emails in CC list with NULs

On Mon, 21 Oct 2019 at 21:10, Dmitry Torokhov wrote: > > There is a contributor in Linux kernel with a comma in their name, which > confuses patman and results in invalid to- or cc- addresses on some > patches. To avoid this, let's use \0 as a separator when generating cc > file. > > Signed-off-by

Re: [U-Boot] [PATCH v2] fdt: Fix alignment issue when reading 64-bits properties from fdt

On Tue, 22 Oct 2019 at 02:05, Jean-Jacques Hiblot wrote: > > The FDT specification [0] gives a requirement of aligning properties on > 32-bits. Make sure that the compiler is aware of this constraint when > accessing 64-bits properties. > > [0]: > https://github.com/devicetree-org/devicetree-spec

Re: [U-Boot] [PATCH v2] dm: core: Update log method for uclass_find_device_by_seq

On Tue, 22 Oct 2019 at 01:40, Kever Yang wrote: > > Use log() insted of debug() for uclass_find_device_by_seq function, > since this print is very much and we can filter it out with log() > interface. > > Signed-off-by: Kever Yang > --- > > Changes in v2: > - use log_debug() instead of log() > >

Re: [U-Boot] [PATCH] dm: device: Fix typo in the non-DEVRES version of devm_kmalloc_array()

On Thu, 26 Sep 2019 at 07:44, Jean-Jacques Hiblot wrote: > > When DEVRES is not set, devm_kmalloc_array() is spelled > devm_kmaloc_array() (with one 'l' only). > Fixing it so that the name is the same with and without DEVRES. > > Signed-off-by: Jean-Jacques Hiblot > --- > include/dm/device.h | 4

Re: [U-Boot] [PATCH 1/4] dm: core: Allow for not controlling the power-domain by DM framework

Hi Lokesh, On Fri, 27 Sep 2019 at 02:19, Lokesh Vutla wrote: > > In some remoteproc cases, enabling the power domain of the core will > start running the core. In such cases image should be loaded before > enabling the power domain. But the current DM framework enables the > power-domain by defau

Re: [U-Boot] [PATCH v2] dm: Tidy up dump output when there are many devices

On Mon, 30 Sep 2019 at 02:19, Patrick Delaunay wrote: > > At present the 'Index' column of 'dm tree' assumes there is > two digits, this patch increase it to 3 digits. > > It also aligns output of 'dm uclass', assuming the same 3 digits index. > > The boards with CONFIG_PINCTRL_FULL activated have

Re: [U-Boot] [PATCH 2/4] remoteproc: k3_arm64: Enable DM_FLAG_DEFAULT_PD_CTRL_OFF

On Fri, 27 Sep 2019 at 02:19, Lokesh Vutla wrote: > > Enable DM_FLAG_DEFAULT_PD_CTRL_OFF for arm64 remote core so that > pd can be enabled after loading the image. > > Signed-off-by: Lokesh Vutla > --- > drivers/remoteproc/ti_k3_arm64_rproc.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by:

Re: [U-Boot] [PATCH] sandbox: fix build error due to missing struct udevice definition

On Thu, 3 Oct 2019 at 21:41, AKASHI Takahiro wrote: > > Without this patch, compiling may potentially fail. > > Signed-off-by: AKASHI Takahiro > --- > arch/sandbox/include/asm/u-boot-sandbox.h | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Simon Glass Applied to u-boot-dm, thanks! ___

Re: [U-Boot] [PATCH 3/4] power: domain: Introduce dev_power_domain_off

On Fri, 27 Sep 2019 at 02:19, Lokesh Vutla wrote: > > Add dev_power_domain_off() api to disable all the power-domains > corresponding to a device > > Signed-off-by: Lokesh Vutla > --- > drivers/power/domain/power-domain-uclass.c | 34 +- > include/power-domain.h

Re: [U-Boot] [PATCH 4/4] dm: core: device: switch off power domain after device removal

On Fri, 27 Sep 2019 at 02:19, Lokesh Vutla wrote: > > From: Anatolij Gustschin > > The power domain associated with a device is enabled when probing, > but currently the domain remains enabled when the device is removed. > Some boards started to disable power domains for selected devices > via cu

Re: [U-Boot] [PATCH 2/2] dm: spi: Do not assume first SPI bus

On Fri, 6 Sep 2019 at 04:52, Thomas Fitzsimmons wrote: > > When CONFIG_OF_PRIOR_STAGE is enabled, this workaround was needed > before device_bind_common assigned request numbers sequentially in the > absence of aliases. > > Signed-off-by: Thomas Fitzsimmons > Cc: Bin Meng > Cc: Simon Glass > --

Re: [U-Boot] [PATCH v2 1/4] libfdt: fdt_address_cells() and fdt_size_cells()

From: Matthias Brugger Add internal fdt_cells() to avoid copy and paste. Fix typo in fdt_size_cells() documentation comment. This is based in upstream commit: c12b2b0 ("libfdt: fdt_address_cells() and fdt_size_cells()") but misses the test cases, as we don't implement them in U-Boot. Signed-off

Re: [U-Boot] [PATCH] sandbox: fix cpu property in test.dts for pytest

On Tue, 27 Aug 2019 at 02:43, Bin Meng wrote: > > On Tue, Aug 27, 2019 at 4:15 PM AKASHI Takahiro > wrote: > > > > When I tried to run some new efi tests with pytest, efi_smbios_register() > > triggered a segmentation fault. Here is the location where it happened: > > efi_init_obj_list() > > ef

Re: [U-Boot] [PATCH v2 2/4] libfdt: return correct value if #size-cells property is not present

On 27/09/2019 03:48, Simon Glass wrote: > On Tue, 17 Sep 2019 at 09:52, Simon Glass wrote: >> >> Hi Matthias, >> >> On Tue, 17 Sep 2019 at 00:29, Matthias Brugger wrote: >>> >>> Hi Simon, >>> >>> On 17/09/2019 07:48, Simon Glass wrote: Hi, On Thu, 5 Sep 2019 at 02:49, wrote: >

Re: [U-Boot] [PATCH 1/2] pytest: vboot: add a test for required key

On Wed, 18 Sep 2019 at 08:05, Philippe Reynes wrote: > > This commit add a test in the vboot test to check that > when a required key is asked, only FIT signed with this > key is used/accepted by u-boot. > > Signed-off-by: Philippe Reynes > --- > test/py/tests/test_vboot.py

Re: [U-Boot] [PATCH v2 3/4] libfdt: Allow #size-cells of 0

On Mon, 16 Sep 2019 at 22:48, Simon Glass wrote: > > On Thu, 5 Sep 2019 at 02:49, wrote: > > > > From: Matthias Brugger > > > > The commit "libfdt: fdt_address_cells() and fdt_size_cells()" introduced > > a bug as it consolidated code between the helpers for getting > > be 0, and is frequently f

Re: [U-Boot] [PATCH 1/2] dm: device: Request next sequence number

On Sat, 14 Sep 2019 at 06:41, Thomas Fitzsimmons wrote: > > Hi Bin, > > Bin Meng writes: > > [...] > > > On Fri, Sep 6, 2019 at 7:52 PM Thomas Fitzsimmons > > wrote: > >> > >> For CONFIG_OF_PRIOR_STAGE, in the absence of a device tree alias for a > >> given device, use the next request number f

Re: [U-Boot] [PATCH] tpm2: Don't assume active low reset value

On Fri, 6 Sep 2019 at 16:08, Kayla Theil wrote: > > The reset function sets the pin to 0 then 1 but if the pin is marked > ACTIVE_LOW in the DT it gets inverted and leaves the TPM in reset. > Let the gpio driver take care of the reset polarity. > > Signed-off-by: Kayla Theil > --- > drivers/tpm/

Re: [U-Boot] [PATCH V3 1/4] sandbox: enable command aes

On Tue, 24 Sep 2019 at 02:32, Philippe Reynes wrote: > > This commit enable the command aes on sandbox. > Then, it may be used on pytest. > > Signed-off-by: Philippe Reynes > --- > configs/sandbox_defconfig | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Simon Glass Applied to u-boot-dm/

Re: [U-Boot] [PATCH v2 4/4] dm: Fix default address cells return value

On Thu, 5 Sep 2019 at 01:49, wrote: > > From: Matthias Brugger > > Default address cells value on the livetree access function > returns the wrong value. Fix this so that the value returned > corresponds to the device tree specification. > > Signed-off-by: Matthias Brugger > --- > > include/dm/

Re: [U-Boot] [PATCH 2/2] rsa: Return immediately if required-key verification fails

On Wed, 18 Sep 2019 at 08:05, Philippe Reynes wrote: > > From: Daniele Alessandrelli > > Currently, if image verification with a required key fails, rsa_verify() > code tries to find another key to verify the FIT image. This however, is > not the intended behavior as the documentation says that r

Re: [U-Boot] [PATCH V2] dm: pinctrl: Skip not associated gpio phandle and rise a warning message

On Tue, 17 Sep 2019 at 13:06, Michael Trimarchi wrote: > > Skip not associated gpio phandle let register the other gpios on a group. > We need anyway to send out a warning to the user to fix their > uboot-board.dtsi. > Thhe handle id can be found inside the decompiled dtb > > dtc -I dtb -O dts -o

  1   2   3   4   5   6   7   8   9   10   >