Re: [PATCH] Makefile: Ensure tools directory exists in output prior to use

2019-12-06 Thread Tom Rini 
On Wed, Dec 04, 2019 at 06:54:30PM -0500, Tom Rini wrote:

> With the change to make tools/version.h a file we need to make sure that
> the output directory exists first otherwise we will get a build failure.
> 
> Reported-by: Peter Robinson 
> Tested-by: Peter Robinson 
> Fixes: 4d90f6cd9813 ("tools: Avoid creating symbolic links for 
> tools/version.h")
> Signed-off-by: Tom Rini 
> Reviewed-by: Bin Meng 
> Reviewed-by: Simon Glass 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature

Re: [PATCH] Makefile: Ensure tools directory exists in output prior to use

2019-12-05 Thread Simon Glass 
On Wed, 4 Dec 2019 at 16:54, Tom Rini  wrote:
>
> With the change to make tools/version.h a file we need to make sure that
> the output directory exists first otherwise we will get a build failure.
>
> Reported-by: Peter Robinson 
> Tested-by: Peter Robinson 
> Fixes: 4d90f6cd9813 ("tools: Avoid creating symbolic links for 
> tools/version.h")
> Signed-off-by: Tom Rini 
> ---
>  Makefile | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Simon Glass

Re: [PATCH] Makefile: Ensure tools directory exists in output prior to use

2019-12-04 Thread Bin Meng 
On Thu, Dec 5, 2019 at 7:54 AM Tom Rini  wrote:
>
> With the change to make tools/version.h a file we need to make sure that
> the output directory exists first otherwise we will get a build failure.
>
> Reported-by: Peter Robinson 
> Tested-by: Peter Robinson 
> Fixes: 4d90f6cd9813 ("tools: Avoid creating symbolic links for 
> tools/version.h")
> Signed-off-by: Tom Rini 
> ---
>  Makefile | 1 +
>  1 file changed, 1 insertion(+)
>

Reviewed-by: Bin Meng

[PATCH] Makefile: Ensure tools directory exists in output prior to use

2019-12-04 Thread Tom Rini 
With the change to make tools/version.h a file we need to make sure that
the output directory exists first otherwise we will get a build failure.

Reported-by: Peter Robinson 
Tested-by: Peter Robinson 
Fixes: 4d90f6cd9813 ("tools: Avoid creating symbolic links for tools/version.h")
Signed-off-by: Tom Rini 
---
 Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Makefile b/Makefile
index 0ee0c701022a..960926caad45 100644
--- a/Makefile
+++ b/Makefile
@@ -1889,6 +1889,7 @@ checkarmreloc: u-boot
fi
 
 tools/version.h: include/version.h
+   $(Q)mkdir -p $(dir $@)
$(call if_changed,copy)
 
 envtools: scripts_basic $(version_h) $(timestamp_h) tools/version.h
-- 
2.17.1