Re: [PATCH 08/11] pci: _dm_pci_phys_to_bus can be static

[Tom Rini]

On Fri, Sep 17, 2021 at 03:11:27PM +0300, Vladimir Oltean wrote:

> To avoid W=1 build warnings, declare this function as static, since it
> is not used outside of this translation module.
> 
> Signed-off-by: Vladimir Oltean 
> Reviewed-by: Bin Meng 

Applied to u-boot/next, thanks!

-- 
Tom


signature.asc
Description: PGP signature

Re: [PATCH 08/11] pci: _dm_pci_phys_to_bus can be static

[Bin Meng]

On Fri, Sep 17, 2021 at 8:11 PM Vladimir Oltean  wrote:
>
> To avoid W=1 build warnings, declare this function as static, since it
> is not used outside of this translation module.
>
> Signed-off-by: Vladimir Oltean 
> ---
>  drivers/pci/pci-uclass.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>

Reviewed-by: Bin Meng 

[PATCH 08/11] pci: _dm_pci_phys_to_bus can be static

[Vladimir Oltean]

To avoid W=1 build warnings, declare this function as static, since it
is not used outside of this translation module.

Signed-off-by: Vladimir Oltean 
---
 drivers/pci/pci-uclass.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c
index f0313d059042..f3ac6fdb0031 100644
--- a/drivers/pci/pci-uclass.c
+++ b/drivers/pci/pci-uclass.c
@@ -1433,9 +1433,9 @@ phys_addr_t dm_pci_bus_to_phys(struct udevice *dev, 
pci_addr_t bus_addr,
return phys_addr;
 }
 
-int _dm_pci_phys_to_bus(struct udevice *dev, phys_addr_t phys_addr,
-   unsigned long flags, unsigned long skip_mask,
-   pci_addr_t *ba)
+static int _dm_pci_phys_to_bus(struct udevice *dev, phys_addr_t phys_addr,
+  unsigned long flags, unsigned long skip_mask,
+  pci_addr_t *ba)
 {
struct pci_region *res;
struct udevice *ctlr;
-- 
2.25.1