Re: [PATCH V2 01/17] common: make: Support show_board_info() as part of SPL build

[Tom Rini]

On Tue, Nov 02, 2021 at 07:35:42PM +0530, Sinthu Raja wrote:

> From: Sinthu Raja 
> 
> Enable support for show_board_info() in SPL build.
> 
> Signed-off-by: Sinthu Raja 

OK, but why do we need this, and won't it cause every platform that has
this defined to now grow in size?

-- 
Tom


signature.asc
Description: PGP signature

[PATCH V2 01/17] common: make: Support show_board_info() as part of SPL build

[Sinthu Raja]

From: Sinthu Raja 

Enable support for show_board_info() in SPL build.

Signed-off-by: Sinthu Raja 
---
 common/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/common/Makefile b/common/Makefile
index e7839027b6..55e455c5b8 100644
--- a/common/Makefile
+++ b/common/Makefile
@@ -19,7 +19,6 @@ endif
 # # boards
 obj-y += board_f.o
 obj-y += board_r.o
-obj-$(CONFIG_DISPLAY_BOARDINFO) += board_info.o
 obj-$(CONFIG_DISPLAY_BOARDINFO_LATE) += board_info.o
 
 obj-$(CONFIG_CMD_BOOTM) += bootm.o bootm_os.o
@@ -61,6 +60,8 @@ endif # !CONFIG_SPL_BUILD
 obj-$(CONFIG_$(SPL_TPL_)BOOTSTAGE) += bootstage.o
 obj-$(CONFIG_$(SPL_TPL_)BLOBLIST) += bloblist.o
 
+obj-$(CONFIG_DISPLAY_BOARDINFO) += board_info.o
+
 ifdef CONFIG_SPL_BUILD
 ifdef CONFIG_SPL_DFU
 obj-$(CONFIG_DFU_OVER_USB) += dfu.o
-- 
2.31.1