Re: [PATCH v2] usb: xhci-brcm: Include header file needed for dev_err
On 10/6/21 8:05 AM, Stefan Agner wrote: dev_err seems to be moved to different header file. Include dm/device_compat.h file to compile properly. Fixes: 69dae8902b16 ("linux/compat.h: Remove redefinition of dev_xxx macros") Signed-off-by: Stefan Agner --- Changes in v2: - Correctly place include drivers/usb/host/xhci-brcm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/xhci-brcm.c b/drivers/usb/host/xhci-brcm.c index 27c4bbfcba..fe17924028 100644 --- a/drivers/usb/host/xhci-brcm.c +++ b/drivers/usb/host/xhci-brcm.c @@ -8,6 +8,7 @@ #include #include #include +#include #include #define DRD2U3H_XHC_REGS_AXIWRA 0xC08 Does no defconfig compile this module? How was this include missing for so long? --Sean
Re: [PATCH v2] usb: xhci-brcm: Include header file needed for dev_err
On Wed, Oct 6, 2021 at 8:05 PM Stefan Agner wrote: > > dev_err seems to be moved to different header file. Include > dm/device_compat.h file to compile properly. > > Fixes: 69dae8902b16 ("linux/compat.h: Remove redefinition of dev_xxx macros") > Signed-off-by: Stefan Agner > --- > > Changes in v2: > - Correctly place include > Reviewed-by: Bin Meng
Re: [PATCH v2] usb: xhci-brcm: Include header file needed for dev_err
On Wed, 6 Oct 2021 at 06:05, Stefan Agner wrote: > > dev_err seems to be moved to different header file. Include > dm/device_compat.h file to compile properly. > > Fixes: 69dae8902b16 ("linux/compat.h: Remove redefinition of dev_xxx macros") > Signed-off-by: Stefan Agner > --- > > Changes in v2: > - Correctly place include > > drivers/usb/host/xhci-brcm.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Simon Glass > diff --git a/drivers/usb/host/xhci-brcm.c b/drivers/usb/host/xhci-brcm.c > index 27c4bbfcba..fe17924028 100644 > --- a/drivers/usb/host/xhci-brcm.c > +++ b/drivers/usb/host/xhci-brcm.c > @@ -8,6 +8,7 @@ > #include > #include > #include > +#include > #include > > #define DRD2U3H_XHC_REGS_AXIWRA0xC08 > -- > 2.33.0 >
[PATCH v2] usb: xhci-brcm: Include header file needed for dev_err
dev_err seems to be moved to different header file. Include dm/device_compat.h file to compile properly. Fixes: 69dae8902b16 ("linux/compat.h: Remove redefinition of dev_xxx macros") Signed-off-by: Stefan Agner --- Changes in v2: - Correctly place include drivers/usb/host/xhci-brcm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/xhci-brcm.c b/drivers/usb/host/xhci-brcm.c index 27c4bbfcba..fe17924028 100644 --- a/drivers/usb/host/xhci-brcm.c +++ b/drivers/usb/host/xhci-brcm.c @@ -8,6 +8,7 @@ #include #include #include +#include #include #define DRD2U3H_XHC_REGS_AXIWRA0xC08 -- 2.33.0