Re: [U-Boot] [PATCH] drivers: mmc: Change buffer type in ALLOC_CACHE_ALIGN_BUFFER macro

2017-08-18 Thread Jaehoon Chung 
On 08/04/2017 06:33 PM, Suniel Mahesh wrote:
> On Monday 17 July 2017 04:38 PM, Jaehoon Chung wrote:
>> On 06/19/2017 04:33 PM, suni...@techveda.org wrote:
>>> From: Suniel Mahesh 
>>>
>>> __be32_to_cpu() accepts argument of type __be32. This patch changes type of
>>> the buffer in ALLOC_CACHE_ALIGN_BUFFER macro to __be32, which is then passed
>>> to __be32_to_cpu().
>>> This prevents sparse build warnings.
>>> drivers/mmc/mmc.c: warning: cast to restricted __be32
>>>
>>> Signed-off-by: Suniel Mahesh 
>>> Signed-off-by: Karthik Tummala 
>>
>> Applied to u-boot-mmc.
> 
> Hi, It says the patch has been applied to u-boot-mmc git tree,
> but I couldn't find it there applied.
> http://git.denx.de/?p=u-boot/u-boot-mmc.git;a=summary
> 
> are there any issues with the patch or am I looking at the wrong place ? 

Will re-apply.
Thanks for pointing out.

Best Regards,
Jaehoon Chung

> 
> Thanks
> suniel
>>
>> Best Regards,
>> Jaehoon Chung
>>
>>> ---
>>> Note:
>>> - Build was carried out with the above changes, no build errors
>>>   reported.
>>> ---
>>>  drivers/mmc/mmc.c | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
>>> index 3cdf6a4..3d4da4c 100644
>>> --- a/drivers/mmc/mmc.c
>>> +++ b/drivers/mmc/mmc.c
>>> @@ -882,8 +882,8 @@ static int sd_change_freq(struct mmc *mmc)
>>>  {
>>> int err;
>>> struct mmc_cmd cmd;
>>> -   ALLOC_CACHE_ALIGN_BUFFER(uint, scr, 2);
>>> -   ALLOC_CACHE_ALIGN_BUFFER(uint, switch_status, 16);
>>> +   ALLOC_CACHE_ALIGN_BUFFER(__be32, scr, 2);
>>> +   ALLOC_CACHE_ALIGN_BUFFER(__be32, switch_status, 16);
>>> struct mmc_data data;
>>> int timeout;
>>>  
>>>
>>
> 
> 
> 
> 

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] drivers: mmc: Change buffer type in ALLOC_CACHE_ALIGN_BUFFER macro

2017-08-04 Thread Suniel Mahesh 
On Monday 17 July 2017 04:38 PM, Jaehoon Chung wrote:
> On 06/19/2017 04:33 PM, suni...@techveda.org wrote:
>> From: Suniel Mahesh 
>>
>> __be32_to_cpu() accepts argument of type __be32. This patch changes type of
>> the buffer in ALLOC_CACHE_ALIGN_BUFFER macro to __be32, which is then passed
>> to __be32_to_cpu().
>> This prevents sparse build warnings.
>> drivers/mmc/mmc.c: warning: cast to restricted __be32
>>
>> Signed-off-by: Suniel Mahesh 
>> Signed-off-by: Karthik Tummala 
> 
> Applied to u-boot-mmc.

Hi, It says the patch has been applied to u-boot-mmc git tree,
but I couldn't find it there applied.
http://git.denx.de/?p=u-boot/u-boot-mmc.git;a=summary

are there any issues with the patch or am I looking at the wrong place ? 

Thanks
suniel
> 
> Best Regards,
> Jaehoon Chung
> 
>> ---
>> Note:
>> - Build was carried out with the above changes, no build errors
>>   reported.
>> ---
>>  drivers/mmc/mmc.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
>> index 3cdf6a4..3d4da4c 100644
>> --- a/drivers/mmc/mmc.c
>> +++ b/drivers/mmc/mmc.c
>> @@ -882,8 +882,8 @@ static int sd_change_freq(struct mmc *mmc)
>>  {
>>  int err;
>>  struct mmc_cmd cmd;
>> -ALLOC_CACHE_ALIGN_BUFFER(uint, scr, 2);
>> -ALLOC_CACHE_ALIGN_BUFFER(uint, switch_status, 16);
>> +ALLOC_CACHE_ALIGN_BUFFER(__be32, scr, 2);
>> +ALLOC_CACHE_ALIGN_BUFFER(__be32, switch_status, 16);
>>  struct mmc_data data;
>>  int timeout;
>>  
>>
> 

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] drivers: mmc: Change buffer type in ALLOC_CACHE_ALIGN_BUFFER macro

2017-07-17 Thread Jaehoon Chung 
On 06/19/2017 04:33 PM, suni...@techveda.org wrote:
> From: Suniel Mahesh 
> 
> __be32_to_cpu() accepts argument of type __be32. This patch changes type of
> the buffer in ALLOC_CACHE_ALIGN_BUFFER macro to __be32, which is then passed
> to __be32_to_cpu().
> This prevents sparse build warnings.
> drivers/mmc/mmc.c: warning: cast to restricted __be32
> 
> Signed-off-by: Suniel Mahesh 
> Signed-off-by: Karthik Tummala 

Applied to u-boot-mmc.

Best Regards,
Jaehoon Chung

> ---
> Note:
> - Build was carried out with the above changes, no build errors
>   reported.
> ---
>  drivers/mmc/mmc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> index 3cdf6a4..3d4da4c 100644
> --- a/drivers/mmc/mmc.c
> +++ b/drivers/mmc/mmc.c
> @@ -882,8 +882,8 @@ static int sd_change_freq(struct mmc *mmc)
>  {
>   int err;
>   struct mmc_cmd cmd;
> - ALLOC_CACHE_ALIGN_BUFFER(uint, scr, 2);
> - ALLOC_CACHE_ALIGN_BUFFER(uint, switch_status, 16);
> + ALLOC_CACHE_ALIGN_BUFFER(__be32, scr, 2);
> + ALLOC_CACHE_ALIGN_BUFFER(__be32, switch_status, 16);
>   struct mmc_data data;
>   int timeout;
>  
> 

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH] drivers: mmc: Change buffer type in ALLOC_CACHE_ALIGN_BUFFER macro

2017-06-19 Thread sunil . m 
From: Suniel Mahesh 

__be32_to_cpu() accepts argument of type __be32. This patch changes type of
the buffer in ALLOC_CACHE_ALIGN_BUFFER macro to __be32, which is then passed
to __be32_to_cpu().
This prevents sparse build warnings.
drivers/mmc/mmc.c: warning: cast to restricted __be32

Signed-off-by: Suniel Mahesh 
Signed-off-by: Karthik Tummala 
---
Note:
- Build was carried out with the above changes, no build errors
  reported.
---
 drivers/mmc/mmc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
index 3cdf6a4..3d4da4c 100644
--- a/drivers/mmc/mmc.c
+++ b/drivers/mmc/mmc.c
@@ -882,8 +882,8 @@ static int sd_change_freq(struct mmc *mmc)
 {
int err;
struct mmc_cmd cmd;
-   ALLOC_CACHE_ALIGN_BUFFER(uint, scr, 2);
-   ALLOC_CACHE_ALIGN_BUFFER(uint, switch_status, 16);
+   ALLOC_CACHE_ALIGN_BUFFER(__be32, scr, 2);
+   ALLOC_CACHE_ALIGN_BUFFER(__be32, switch_status, 16);
struct mmc_data data;
int timeout;
 
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot