Re: [U-Boot] [PATCH 1/5 v2] sandbox: add lseek helper

[Mike Frysinger]

On Wednesday 01 February 2012 18:37:27 Simon Glass wrote:
 On Tue, Jan 31, 2012 at 11:53 AM, Mike Frysinger wrote:
  --- a/include/os.h
  +++ b/include/os.h
 
  +#define OS_SEEK_SET0
  +#define OS_SEEK_CUR0
  +#define OS_SEEK_END0
 
 0, 1, 2?

see if you can guess what 1 mode i tested ;)
-mike


signature.asc
Description: This is a digitally signed message part.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 1/5 v2] sandbox: add lseek helper

[Simon Glass]

Hi Mike,

On Tue, Jan 31, 2012 at 11:53 AM, Mike Frysinger vap...@gentoo.org wrote:
 Follow up patches want to be able to seek fd's.

 Signed-off-by: Mike Frysinger vap...@gentoo.org
 ---
  arch/sandbox/cpu/os.c |   13 +
  include/os.h          |   15 +++
  2 files changed, 28 insertions(+), 0 deletions(-)

 diff --git a/arch/sandbox/cpu/os.c b/arch/sandbox/cpu/os.c
 index 093e7dc..13331d2 100644
 --- a/arch/sandbox/cpu/os.c
 +++ b/arch/sandbox/cpu/os.c
 @@ -45,6 +45,19 @@ ssize_t os_write(int fd, const void *buf, size_t count)
        return write(fd, buf, count);
  }

 +off_t os_lseek(int fd, off_t offset, int whence)
 +{
 +       if (whence == OS_SEEK_SET)
 +               whence = SEEK_SET;
 +       else if (whence == OS_SEEK_CUR)
 +               whence = SEEK_CUR;
 +       else if (whence == OS_SEEK_END)
 +               whence = SEEK_END;

I suppose this is safest.

 +       else
 +               printf(%s: invalid whence value %i\n, __func__, whence);
 +       return lseek(fd, offset, whence);
 +}
 +
  int os_open(const char *pathname, int flags)
  {
        return open(pathname, flags);
 diff --git a/include/os.h b/include/os.h
 index c17a8a5..11017b7 100644
 --- a/include/os.h
 +++ b/include/os.h
 @@ -49,6 +49,21 @@ ssize_t os_read(int fd, void *buf, size_t count);
  ssize_t os_write(int fd, const void *buf, size_t count);

  /**
 + * Access to the OS lseek() system call
 + *
 + * \param fd   File descriptor as returned by os_open()
 + * \param offset       File offset (based on whence)
 + * \param whence       Position offset is relative to (see below)
 + * \return new file offset
 + */
 +off_t os_lseek(int fd, off_t offset, int whence);
 +
 +/* Defines for whence in os_lseek() */
 +#define OS_SEEK_SET    0
 +#define OS_SEEK_CUR    0
 +#define OS_SEEK_END    0

0, 1, 2?

 +
 +/**
  * Access to the OS open() system call
  *
  * \param pathname     Pathname of file to open
 --
 1.7.8.4

 ___
 U-Boot mailing list
 U-Boot@lists.denx.de
 http://lists.denx.de/mailman/listinfo/u-boot

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 1/5 v2] sandbox: add lseek helper

[Mike Frysinger]

Follow up patches want to be able to seek fd's.

Signed-off-by: Mike Frysinger vap...@gentoo.org
---
 arch/sandbox/cpu/os.c |   13 +
 include/os.h  |   15 +++
 2 files changed, 28 insertions(+), 0 deletions(-)

diff --git a/arch/sandbox/cpu/os.c b/arch/sandbox/cpu/os.c
index 093e7dc..13331d2 100644
--- a/arch/sandbox/cpu/os.c
+++ b/arch/sandbox/cpu/os.c
@@ -45,6 +45,19 @@ ssize_t os_write(int fd, const void *buf, size_t count)
return write(fd, buf, count);
 }
 
+off_t os_lseek(int fd, off_t offset, int whence)
+{
+   if (whence == OS_SEEK_SET)
+   whence = SEEK_SET;
+   else if (whence == OS_SEEK_CUR)
+   whence = SEEK_CUR;
+   else if (whence == OS_SEEK_END)
+   whence = SEEK_END;
+   else
+   printf(%s: invalid whence value %i\n, __func__, whence);
+   return lseek(fd, offset, whence);
+}
+
 int os_open(const char *pathname, int flags)
 {
return open(pathname, flags);
diff --git a/include/os.h b/include/os.h
index c17a8a5..11017b7 100644
--- a/include/os.h
+++ b/include/os.h
@@ -49,6 +49,21 @@ ssize_t os_read(int fd, void *buf, size_t count);
 ssize_t os_write(int fd, const void *buf, size_t count);
 
 /**
+ * Access to the OS lseek() system call
+ *
+ * \param fd   File descriptor as returned by os_open()
+ * \param offset   File offset (based on whence)
+ * \param whence   Position offset is relative to (see below)
+ * \return new file offset
+ */
+off_t os_lseek(int fd, off_t offset, int whence);
+
+/* Defines for whence in os_lseek() */
+#define OS_SEEK_SET0
+#define OS_SEEK_CUR0
+#define OS_SEEK_END0
+
+/**
  * Access to the OS open() system call
  *
  * \param pathname Pathname of file to open
-- 
1.7.8.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot