Re: [U-Boot] [PATCH 2/6 v5] x86: conga: Add option to select different config headers for baseboards
On Tue, Aug 8, 2017 at 6:06 PM, Bin Mengwrote: > On Tue, Aug 8, 2017 at 5:52 PM, Stefan Roese wrote: >> This patch adds the infrastructure to define different config headers >> with different configurations and default environment for the baseboards >> that can now be selected via Kconfig. The new configuration for the >> theadorable-x86-conga-qa3-e3845 is also added. Also the new defconfig >> file for this new target is added. >> >> Signed-off-by: Stefan Roese >> Cc: Simon Glass >> Cc: Bin Meng >> --- >> v5: >> - Added imply for some SPI NOR chips to the board Kconfig file >> >> v4: >> - Remove Gigadevice and Macronix flash support >> >> v3: >> - Rebased on latest master >> - Removed unused macros from config headers >> >> v2: >> - Added Bin's reviewed-by >> >> board/congatec/Kconfig | 11 + >> board/congatec/conga-qeval20-qa3-e3845/Kconfig | 9 ++-- >> board/congatec/conga-qeval20-qa3-e3845/MAINTAINERS | 2 + >> configs/theadorable-x86-conga-qa3-e3845_defconfig | 54 >> ++ >> include/configs/theadorable-x86-conga-qa3-e3845.h | 38 +++ >> 5 files changed, 109 insertions(+), 5 deletions(-) >> create mode 100644 configs/theadorable-x86-conga-qa3-e3845_defconfig >> create mode 100644 include/configs/theadorable-x86-conga-qa3-e3845.h >> > > Reviewed-by: Bin Meng applied to u-boot-x86, thanks! ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 2/6 v5] x86: conga: Add option to select different config headers for baseboards
Hi Bin, On 08.08.2017 13:32, Bin Meng wrote: Hi Stefan, On Tue, Aug 8, 2017 at 6:37 PM, Stefan Roesewrote: Hi Bin, On 08.08.2017 12:29, Bin Meng wrote: On Tue, Aug 8, 2017 at 6:06 PM, Bin Meng wrote: On Tue, Aug 8, 2017 at 5:52 PM, Stefan Roese wrote: This patch adds the infrastructure to define different config headers with different configurations and default environment for the baseboards that can now be selected via Kconfig. The new configuration for the theadorable-x86-conga-qa3-e3845 is also added. Also the new defconfig file for this new target is added. Signed-off-by: Stefan Roese Cc: Simon Glass Cc: Bin Meng --- v5: - Added imply for some SPI NOR chips to the board Kconfig file v4: - Remove Gigadevice and Macronix flash support v3: - Rebased on latest master - Removed unused macros from config headers v2: - Added Bin's reviewed-by board/congatec/Kconfig | 11 + board/congatec/conga-qeval20-qa3-e3845/Kconfig | 9 ++-- board/congatec/conga-qeval20-qa3-e3845/MAINTAINERS | 2 + configs/theadorable-x86-conga-qa3-e3845_defconfig | 54 ++ include/configs/theadorable-x86-conga-qa3-e3845.h | 38 +++ 5 files changed, 109 insertions(+), 5 deletions(-) create mode 100644 configs/theadorable-x86-conga-qa3-e3845_defconfig create mode 100644 include/configs/theadorable-x86-conga-qa3-e3845.h Reviewed-by: Bin Meng For some reason, this patch fails in buildman testing: 02: x86: conga: Add option to select different config headers for baseboards -make[2]: *** [theadorable-x86-conga-qa3-e3845_defconfig] Error 1 -make[1]: *** [theadorable-x86-conga-qa3-e3845_defconfig] Error 2 +../arch/x86/lib/acpi_s3.c:14:25: error: expected declaration specifiers or '...' before '*' token + static void asmlinkage (*acpi_do_wakeup)(void *vector) = (void *)WAKEUP_BASE; + ^ + acpi_do_wakeup(vector); + ^ +make[2]: *** [arch/x86/lib/acpi_s3.o] Error 1 +make[1]: *** [arch/x86/lib] Error 2 w+../arch/x86/lib/acpi_s3.c: In function 'acpi_jump_to_wakeup': w+../arch/x86/lib/acpi_s3.c:22:2: warning: implicit declaration of function 'acpi_do_wakeup' [-Wimplicit-function-declaration] But this failure disappears in patch [05/06]: 05: x86: conga: theadorable-x86-conga-qa3-e3845_defconfig: Misc defconfig updates x86: theadorable-x86-conga-qa3-e3845 -../arch/x86/lib/acpi_s3.c:14:25: error: expected declaration specifiers or '...' before '*' token - static void asmlinkage (*acpi_do_wakeup)(void *vector) = (void *)WAKEUP_BASE; - ^ - acpi_do_wakeup(vector); - ^ -make[2]: *** [arch/x86/lib/acpi_s3.o] Error 1 -make[1]: *** [arch/x86/lib] Error 2 w-../arch/x86/lib/acpi_s3.c: In function 'acpi_jump_to_wakeup': w-../arch/x86/lib/acpi_s3.c:22:2: warning: implicit declaration of function 'acpi_do_wakeup' [-Wimplicit-function-declaration] Could you please have a look at this? Thanks! I've seen this issue as well and am unable to tell, why this fails in this configuration and in others not. With patch 5/6 applied, the problem is gone though. Do you have an idea, where this issue might come from? A patch was just sent out. Please check http://patchwork.ozlabs.org/patch/799115/ Great, thank you very much. Thanks, Stefan ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 2/6 v5] x86: conga: Add option to select different config headers for baseboards
Hi Stefan, On Tue, Aug 8, 2017 at 6:37 PM, Stefan Roesewrote: > Hi Bin, > > > On 08.08.2017 12:29, Bin Meng wrote: >> >> On Tue, Aug 8, 2017 at 6:06 PM, Bin Meng wrote: >>> >>> On Tue, Aug 8, 2017 at 5:52 PM, Stefan Roese wrote: This patch adds the infrastructure to define different config headers with different configurations and default environment for the baseboards that can now be selected via Kconfig. The new configuration for the theadorable-x86-conga-qa3-e3845 is also added. Also the new defconfig file for this new target is added. Signed-off-by: Stefan Roese Cc: Simon Glass Cc: Bin Meng --- v5: - Added imply for some SPI NOR chips to the board Kconfig file v4: - Remove Gigadevice and Macronix flash support v3: - Rebased on latest master - Removed unused macros from config headers v2: - Added Bin's reviewed-by board/congatec/Kconfig | 11 + board/congatec/conga-qeval20-qa3-e3845/Kconfig | 9 ++-- board/congatec/conga-qeval20-qa3-e3845/MAINTAINERS | 2 + configs/theadorable-x86-conga-qa3-e3845_defconfig | 54 ++ include/configs/theadorable-x86-conga-qa3-e3845.h | 38 +++ 5 files changed, 109 insertions(+), 5 deletions(-) create mode 100644 configs/theadorable-x86-conga-qa3-e3845_defconfig create mode 100644 include/configs/theadorable-x86-conga-qa3-e3845.h >>> >>> Reviewed-by: Bin Meng >> >> >> For some reason, this patch fails in buildman testing: >> >> 02: x86: conga: Add option to select different config headers for >> baseboards >> -make[2]: *** [theadorable-x86-conga-qa3-e3845_defconfig] Error 1 >> -make[1]: *** [theadorable-x86-conga-qa3-e3845_defconfig] Error 2 >> +../arch/x86/lib/acpi_s3.c:14:25: error: expected declaration >> specifiers or '...' before '*' token >> + static void asmlinkage (*acpi_do_wakeup)(void *vector) = (void >> *)WAKEUP_BASE; >> + ^ >> + acpi_do_wakeup(vector); >> + ^ >> +make[2]: *** [arch/x86/lib/acpi_s3.o] Error 1 >> +make[1]: *** [arch/x86/lib] Error 2 >> w+../arch/x86/lib/acpi_s3.c: In function 'acpi_jump_to_wakeup': >> w+../arch/x86/lib/acpi_s3.c:22:2: warning: implicit declaration of >> function 'acpi_do_wakeup' [-Wimplicit-function-declaration] >> >> But this failure disappears in patch [05/06]: >> >> 05: x86: conga: theadorable-x86-conga-qa3-e3845_defconfig: Misc >> defconfig updates >> x86: theadorable-x86-conga-qa3-e3845 >> -../arch/x86/lib/acpi_s3.c:14:25: error: expected declaration >> specifiers or '...' before '*' token >> - static void asmlinkage (*acpi_do_wakeup)(void *vector) = (void >> *)WAKEUP_BASE; >> - ^ >> - acpi_do_wakeup(vector); >> - ^ >> -make[2]: *** [arch/x86/lib/acpi_s3.o] Error 1 >> -make[1]: *** [arch/x86/lib] Error 2 >> w-../arch/x86/lib/acpi_s3.c: In function 'acpi_jump_to_wakeup': >> w-../arch/x86/lib/acpi_s3.c:22:2: warning: implicit declaration of >> function 'acpi_do_wakeup' [-Wimplicit-function-declaration] >> >> Could you please have a look at this? Thanks! > > > I've seen this issue as well and am unable to tell, why this fails > in this configuration and in others not. > > With patch 5/6 applied, the problem is gone though. Do you have an > idea, where this issue might come from? > A patch was just sent out. Please check http://patchwork.ozlabs.org/patch/799115/ Regards, Bin ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 2/6 v5] x86: conga: Add option to select different config headers for baseboards
Hi Bin, On 08.08.2017 12:29, Bin Meng wrote: On Tue, Aug 8, 2017 at 6:06 PM, Bin Mengwrote: On Tue, Aug 8, 2017 at 5:52 PM, Stefan Roese wrote: This patch adds the infrastructure to define different config headers with different configurations and default environment for the baseboards that can now be selected via Kconfig. The new configuration for the theadorable-x86-conga-qa3-e3845 is also added. Also the new defconfig file for this new target is added. Signed-off-by: Stefan Roese Cc: Simon Glass Cc: Bin Meng --- v5: - Added imply for some SPI NOR chips to the board Kconfig file v4: - Remove Gigadevice and Macronix flash support v3: - Rebased on latest master - Removed unused macros from config headers v2: - Added Bin's reviewed-by board/congatec/Kconfig | 11 + board/congatec/conga-qeval20-qa3-e3845/Kconfig | 9 ++-- board/congatec/conga-qeval20-qa3-e3845/MAINTAINERS | 2 + configs/theadorable-x86-conga-qa3-e3845_defconfig | 54 ++ include/configs/theadorable-x86-conga-qa3-e3845.h | 38 +++ 5 files changed, 109 insertions(+), 5 deletions(-) create mode 100644 configs/theadorable-x86-conga-qa3-e3845_defconfig create mode 100644 include/configs/theadorable-x86-conga-qa3-e3845.h Reviewed-by: Bin Meng For some reason, this patch fails in buildman testing: 02: x86: conga: Add option to select different config headers for baseboards -make[2]: *** [theadorable-x86-conga-qa3-e3845_defconfig] Error 1 -make[1]: *** [theadorable-x86-conga-qa3-e3845_defconfig] Error 2 +../arch/x86/lib/acpi_s3.c:14:25: error: expected declaration specifiers or '...' before '*' token + static void asmlinkage (*acpi_do_wakeup)(void *vector) = (void *)WAKEUP_BASE; + ^ + acpi_do_wakeup(vector); + ^ +make[2]: *** [arch/x86/lib/acpi_s3.o] Error 1 +make[1]: *** [arch/x86/lib] Error 2 w+../arch/x86/lib/acpi_s3.c: In function 'acpi_jump_to_wakeup': w+../arch/x86/lib/acpi_s3.c:22:2: warning: implicit declaration of function 'acpi_do_wakeup' [-Wimplicit-function-declaration] But this failure disappears in patch [05/06]: 05: x86: conga: theadorable-x86-conga-qa3-e3845_defconfig: Misc defconfig updates x86: theadorable-x86-conga-qa3-e3845 -../arch/x86/lib/acpi_s3.c:14:25: error: expected declaration specifiers or '...' before '*' token - static void asmlinkage (*acpi_do_wakeup)(void *vector) = (void *)WAKEUP_BASE; - ^ - acpi_do_wakeup(vector); - ^ -make[2]: *** [arch/x86/lib/acpi_s3.o] Error 1 -make[1]: *** [arch/x86/lib] Error 2 w-../arch/x86/lib/acpi_s3.c: In function 'acpi_jump_to_wakeup': w-../arch/x86/lib/acpi_s3.c:22:2: warning: implicit declaration of function 'acpi_do_wakeup' [-Wimplicit-function-declaration] Could you please have a look at this? Thanks! I've seen this issue as well and am unable to tell, why this fails in this configuration and in others not. With patch 5/6 applied, the problem is gone though. Do you have an idea, where this issue might come from? Thanks, Stefan ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 2/6 v5] x86: conga: Add option to select different config headers for baseboards
Hi Stefan, On Tue, Aug 8, 2017 at 6:06 PM, Bin Mengwrote: > On Tue, Aug 8, 2017 at 5:52 PM, Stefan Roese wrote: >> This patch adds the infrastructure to define different config headers >> with different configurations and default environment for the baseboards >> that can now be selected via Kconfig. The new configuration for the >> theadorable-x86-conga-qa3-e3845 is also added. Also the new defconfig >> file for this new target is added. >> >> Signed-off-by: Stefan Roese >> Cc: Simon Glass >> Cc: Bin Meng >> --- >> v5: >> - Added imply for some SPI NOR chips to the board Kconfig file >> >> v4: >> - Remove Gigadevice and Macronix flash support >> >> v3: >> - Rebased on latest master >> - Removed unused macros from config headers >> >> v2: >> - Added Bin's reviewed-by >> >> board/congatec/Kconfig | 11 + >> board/congatec/conga-qeval20-qa3-e3845/Kconfig | 9 ++-- >> board/congatec/conga-qeval20-qa3-e3845/MAINTAINERS | 2 + >> configs/theadorable-x86-conga-qa3-e3845_defconfig | 54 >> ++ >> include/configs/theadorable-x86-conga-qa3-e3845.h | 38 +++ >> 5 files changed, 109 insertions(+), 5 deletions(-) >> create mode 100644 configs/theadorable-x86-conga-qa3-e3845_defconfig >> create mode 100644 include/configs/theadorable-x86-conga-qa3-e3845.h >> > > Reviewed-by: Bin Meng For some reason, this patch fails in buildman testing: 02: x86: conga: Add option to select different config headers for baseboards -make[2]: *** [theadorable-x86-conga-qa3-e3845_defconfig] Error 1 -make[1]: *** [theadorable-x86-conga-qa3-e3845_defconfig] Error 2 +../arch/x86/lib/acpi_s3.c:14:25: error: expected declaration specifiers or '...' before '*' token + static void asmlinkage (*acpi_do_wakeup)(void *vector) = (void *)WAKEUP_BASE; + ^ + acpi_do_wakeup(vector); + ^ +make[2]: *** [arch/x86/lib/acpi_s3.o] Error 1 +make[1]: *** [arch/x86/lib] Error 2 w+../arch/x86/lib/acpi_s3.c: In function 'acpi_jump_to_wakeup': w+../arch/x86/lib/acpi_s3.c:22:2: warning: implicit declaration of function 'acpi_do_wakeup' [-Wimplicit-function-declaration] But this failure disappears in patch [05/06]: 05: x86: conga: theadorable-x86-conga-qa3-e3845_defconfig: Misc defconfig updates x86: theadorable-x86-conga-qa3-e3845 -../arch/x86/lib/acpi_s3.c:14:25: error: expected declaration specifiers or '...' before '*' token - static void asmlinkage (*acpi_do_wakeup)(void *vector) = (void *)WAKEUP_BASE; - ^ - acpi_do_wakeup(vector); - ^ -make[2]: *** [arch/x86/lib/acpi_s3.o] Error 1 -make[1]: *** [arch/x86/lib] Error 2 w-../arch/x86/lib/acpi_s3.c: In function 'acpi_jump_to_wakeup': w-../arch/x86/lib/acpi_s3.c:22:2: warning: implicit declaration of function 'acpi_do_wakeup' [-Wimplicit-function-declaration] Could you please have a look at this? Thanks! Regards, Bin ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 2/6 v5] x86: conga: Add option to select different config headers for baseboards
On Tue, Aug 8, 2017 at 5:52 PM, Stefan Roesewrote: > This patch adds the infrastructure to define different config headers > with different configurations and default environment for the baseboards > that can now be selected via Kconfig. The new configuration for the > theadorable-x86-conga-qa3-e3845 is also added. Also the new defconfig > file for this new target is added. > > Signed-off-by: Stefan Roese > Cc: Simon Glass > Cc: Bin Meng > --- > v5: > - Added imply for some SPI NOR chips to the board Kconfig file > > v4: > - Remove Gigadevice and Macronix flash support > > v3: > - Rebased on latest master > - Removed unused macros from config headers > > v2: > - Added Bin's reviewed-by > > board/congatec/Kconfig | 11 + > board/congatec/conga-qeval20-qa3-e3845/Kconfig | 9 ++-- > board/congatec/conga-qeval20-qa3-e3845/MAINTAINERS | 2 + > configs/theadorable-x86-conga-qa3-e3845_defconfig | 54 > ++ > include/configs/theadorable-x86-conga-qa3-e3845.h | 38 +++ > 5 files changed, 109 insertions(+), 5 deletions(-) > create mode 100644 configs/theadorable-x86-conga-qa3-e3845_defconfig > create mode 100644 include/configs/theadorable-x86-conga-qa3-e3845.h > Reviewed-by: Bin Meng ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH 2/6 v5] x86: conga: Add option to select different config headers for baseboards
This patch adds the infrastructure to define different config headers with different configurations and default environment for the baseboards that can now be selected via Kconfig. The new configuration for the theadorable-x86-conga-qa3-e3845 is also added. Also the new defconfig file for this new target is added. Signed-off-by: Stefan RoeseCc: Simon Glass Cc: Bin Meng --- v5: - Added imply for some SPI NOR chips to the board Kconfig file v4: - Remove Gigadevice and Macronix flash support v3: - Rebased on latest master - Removed unused macros from config headers v2: - Added Bin's reviewed-by board/congatec/Kconfig | 11 + board/congatec/conga-qeval20-qa3-e3845/Kconfig | 9 ++-- board/congatec/conga-qeval20-qa3-e3845/MAINTAINERS | 2 + configs/theadorable-x86-conga-qa3-e3845_defconfig | 54 ++ include/configs/theadorable-x86-conga-qa3-e3845.h | 38 +++ 5 files changed, 109 insertions(+), 5 deletions(-) create mode 100644 configs/theadorable-x86-conga-qa3-e3845_defconfig create mode 100644 include/configs/theadorable-x86-conga-qa3-e3845.h diff --git a/board/congatec/Kconfig b/board/congatec/Kconfig index ff5a1d84a1..fb341bf24c 100644 --- a/board/congatec/Kconfig +++ b/board/congatec/Kconfig @@ -24,6 +24,17 @@ config TARGET_CONGA_QEVAL20_QA3_E3845 Note that PCIE_ECAM_BASE is set up by the FSP so the value used by U-Boot matches that value. +config TARGET_THEADORABLE_X86_CONGA_QA3_E3845 + bool "theadorable-x86 baseboard & conga-QA3/E3845" + help + This is the theadorable-x86 baseboard board equipped with the + conga-QA3/E3845-4G SoM. It contains an Atom E3845 with Ethernet, + micro-SD, USB 2, USB 3, SATA, serial console and HDMI 1.3 video + out. It requires some binary blobs - see README.x86 for details. + + Note that PCIE_ECAM_BASE is set up by the FSP so the value used + by U-Boot matches that value. + endchoice source "board/congatec/conga-qeval20-qa3-e3845/Kconfig" diff --git a/board/congatec/conga-qeval20-qa3-e3845/Kconfig b/board/congatec/conga-qeval20-qa3-e3845/Kconfig index c2649d299f..e1fae737ac 100644 --- a/board/congatec/conga-qeval20-qa3-e3845/Kconfig +++ b/board/congatec/conga-qeval20-qa3-e3845/Kconfig @@ -1,5 +1,3 @@ -if TARGET_CONGA_QEVAL20_QA3_E3845 - config SYS_BOARD default "conga-qeval20-qa3-e3845" @@ -10,7 +8,8 @@ config SYS_SOC default "baytrail" config SYS_CONFIG_NAME - default "conga-qeval20-qa3-e3845" + default "conga-qeval20-qa3-e3845" if TARGET_CONGA_QEVAL20_QA3_E3845 + default "theadorable-x86-conga-qa3-e3845" if TARGET_THEADORABLE_X86_CONGA_QA3_E3845 config SYS_TEXT_BASE default 0xfff0 if !EFI_STUB @@ -24,8 +23,8 @@ config BOARD_SPECIFIC_OPTIONS # dummy select BOARD_EARLY_INIT_F select BOARD_LATE_INIT select SPI_FLASH_STMICRO + imply SPI_FLASH_SPANSION + imply SPI_FLASH_WINBOND config PCIE_ECAM_BASE default 0xe000 - -endif diff --git a/board/congatec/conga-qeval20-qa3-e3845/MAINTAINERS b/board/congatec/conga-qeval20-qa3-e3845/MAINTAINERS index 3d7e8e2d61..6e065590ab 100644 --- a/board/congatec/conga-qeval20-qa3-e3845/MAINTAINERS +++ b/board/congatec/conga-qeval20-qa3-e3845/MAINTAINERS @@ -3,6 +3,8 @@ M: Stefan Roese S: Maintained F: board/congatec/conga-qeval20-qa3-e3845 F: include/configs/conga-qeval20-qa3-e3845.h +F: include/configs/theadorable-x86-conga-qa3-e3845.h F: configs/conga-qeval20-qa3-e3845_defconfig F: configs/conga-qeval20-qa3-e3845-internal-uart_defconfig +F: configs/theadorable-x86-conga-qa3-e3845_defconfig F: arch/x86/dts/conga-qeval20-qa3-e3845.dts diff --git a/configs/theadorable-x86-conga-qa3-e3845_defconfig b/configs/theadorable-x86-conga-qa3-e3845_defconfig new file mode 100644 index 00..32127fc087 --- /dev/null +++ b/configs/theadorable-x86-conga-qa3-e3845_defconfig @@ -0,0 +1,54 @@ +CONFIG_X86=y +CONFIG_VENDOR_CONGATEC=y +CONFIG_TARGET_THEADORABLE_X86_CONGA_QA3_E3845=y +CONFIG_DEFAULT_DEVICE_TREE="conga-qeval20-qa3-e3845" +CONFIG_INTERNAL_UART=y +CONFIG_DEBUG_UART=y +CONFIG_SMP=y +CONFIG_HAVE_VGA_BIOS=y +CONFIG_VGA_BIOS_ADDR=0xfffa +CONFIG_GENERATE_PIRQ_TABLE=y +CONFIG_GENERATE_MP_TABLE=y +CONFIG_GENERATE_ACPI_TABLE=y +CONFIG_HAVE_ACPI_RESUME=y +CONFIG_SEABIOS=y +CONFIG_FIT=y +CONFIG_FIT_SIGNATURE=y +CONFIG_BOOTSTAGE=y +CONFIG_BOOTSTAGE_REPORT=y +CONFIG_SYS_CONSOLE_INFO_QUIET=y +CONFIG_HUSH_PARSER=y +CONFIG_CMD_CPU=y +# CONFIG_CMD_IMLS is not set +# CONFIG_CMD_FLASH is not set +CONFIG_CMD_MMC=y +CONFIG_CMD_SF=y +CONFIG_CMD_SPI=y +CONFIG_CMD_I2C=y +CONFIG_CMD_USB=y +CONFIG_CMD_GPIO=y +# CONFIG_CMD_SETEXPR is not set +CONFIG_CMD_DHCP=y +# CONFIG_CMD_NFS is not set +CONFIG_CMD_PING=y +CONFIG_CMD_TIME=y +CONFIG_CMD_BOOTSTAGE=y +CONFIG_CMD_EXT2=y +CONFIG_CMD_EXT4=y