Re: [U-Boot] [PATCH u-boot 1/3] net: phy: Add Amlogic Meson GXL Internal PHY support

2017-10-29 Thread Neil Armstrong 


Le 29/10/2017 13:04, Tom Rini a écrit :
> On Thu, Oct 26, 2017 at 03:39:17PM +0200, Neil Armstrong wrote:
>> On 22/10/2017 16:36, Simon Glass wrote:
>>> On 18 October 2017 at 10:02, Neil Armstrong  wrote:
 The Amlogic Meson GXL/GXM families embeds an internal RMII Ethernet PHY.

 The PHY acts as a generic PHY but needs a slight configuration right
 before it's configuration.

 Signed-off-by: Neil Armstrong 
 ---
  drivers/net/phy/Kconfig |  3 +++
  drivers/net/phy/Makefile|  1 +
  drivers/net/phy/meson-gxl.c | 57 
 +
  drivers/net/phy/phy.c   |  3 +++
  include/phy.h   |  1 +
  5 files changed, 65 insertions(+)
  create mode 100644 drivers/net/phy/meson-gxl.c
>>>
>>> We really should create a uclass for PHY drivers before adding any
>>> more of these.
>>>
>>> Regards,
>>> Simon
>>>
>>
>> Hi Simon,
>>
>> Sure, this would indeed be necessary, but is it necessary to wait for
>> the uclass to merge mode PHYs ?
> 
> Well, this isn't going in before the next release (along with all of the
> other amlogic stuff, which looks good otherwise btw).  So, do you have
> time to take a pass at a uclass?
> 

Hi Tom, Simon,

I can give a try, but with my limited uclass/dm knowledge, it will only be 
basic and will some review.

Should the plan be to introduce DM support for net PHY subsystem, then 
introduce this meson GXL phy as first implementation ?

Should I remove support for non-dm PHY drivers and probing when DM is enabled ?

Neil
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH u-boot 1/3] net: phy: Add Amlogic Meson GXL Internal PHY support

2017-10-29 Thread Tom Rini 
On Thu, Oct 26, 2017 at 03:39:17PM +0200, Neil Armstrong wrote:
> On 22/10/2017 16:36, Simon Glass wrote:
> > On 18 October 2017 at 10:02, Neil Armstrong  wrote:
> >> The Amlogic Meson GXL/GXM families embeds an internal RMII Ethernet PHY.
> >>
> >> The PHY acts as a generic PHY but needs a slight configuration right
> >> before it's configuration.
> >>
> >> Signed-off-by: Neil Armstrong 
> >> ---
> >>  drivers/net/phy/Kconfig |  3 +++
> >>  drivers/net/phy/Makefile|  1 +
> >>  drivers/net/phy/meson-gxl.c | 57 
> >> +
> >>  drivers/net/phy/phy.c   |  3 +++
> >>  include/phy.h   |  1 +
> >>  5 files changed, 65 insertions(+)
> >>  create mode 100644 drivers/net/phy/meson-gxl.c
> > 
> > We really should create a uclass for PHY drivers before adding any
> > more of these.
> > 
> > Regards,
> > Simon
> > 
> 
> Hi Simon,
> 
> Sure, this would indeed be necessary, but is it necessary to wait for
> the uclass to merge mode PHYs ?

Well, this isn't going in before the next release (along with all of the
other amlogic stuff, which looks good otherwise btw).  So, do you have
time to take a pass at a uclass?

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH u-boot 1/3] net: phy: Add Amlogic Meson GXL Internal PHY support

2017-10-26 Thread Neil Armstrong 
On 22/10/2017 16:36, Simon Glass wrote:
> On 18 October 2017 at 10:02, Neil Armstrong  wrote:
>> The Amlogic Meson GXL/GXM families embeds an internal RMII Ethernet PHY.
>>
>> The PHY acts as a generic PHY but needs a slight configuration right
>> before it's configuration.
>>
>> Signed-off-by: Neil Armstrong 
>> ---
>>  drivers/net/phy/Kconfig |  3 +++
>>  drivers/net/phy/Makefile|  1 +
>>  drivers/net/phy/meson-gxl.c | 57 
>> +
>>  drivers/net/phy/phy.c   |  3 +++
>>  include/phy.h   |  1 +
>>  5 files changed, 65 insertions(+)
>>  create mode 100644 drivers/net/phy/meson-gxl.c
> 
> We really should create a uclass for PHY drivers before adding any
> more of these.
> 
> Regards,
> Simon
> 

Hi Simon,

Sure, this would indeed be necessary, but is it necessary to wait for the 
uclass to merge mode PHYs ?

Neil
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH u-boot 1/3] net: phy: Add Amlogic Meson GXL Internal PHY support

2017-10-22 Thread Simon Glass 
On 18 October 2017 at 10:02, Neil Armstrong  wrote:
> The Amlogic Meson GXL/GXM families embeds an internal RMII Ethernet PHY.
>
> The PHY acts as a generic PHY but needs a slight configuration right
> before it's configuration.
>
> Signed-off-by: Neil Armstrong 
> ---
>  drivers/net/phy/Kconfig |  3 +++
>  drivers/net/phy/Makefile|  1 +
>  drivers/net/phy/meson-gxl.c | 57 
> +
>  drivers/net/phy/phy.c   |  3 +++
>  include/phy.h   |  1 +
>  5 files changed, 65 insertions(+)
>  create mode 100644 drivers/net/phy/meson-gxl.c

We really should create a uclass for PHY drivers before adding any
more of these.

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH u-boot 1/3] net: phy: Add Amlogic Meson GXL Internal PHY support

2017-10-18 Thread Neil Armstrong 
The Amlogic Meson GXL/GXM families embeds an internal RMII Ethernet PHY.

The PHY acts as a generic PHY but needs a slight configuration right
before it's configuration.

Signed-off-by: Neil Armstrong 
---
 drivers/net/phy/Kconfig |  3 +++
 drivers/net/phy/Makefile|  1 +
 drivers/net/phy/meson-gxl.c | 57 +
 drivers/net/phy/phy.c   |  3 +++
 include/phy.h   |  1 +
 5 files changed, 65 insertions(+)
 create mode 100644 drivers/net/phy/meson-gxl.c

diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
index 4d02d8b..e32f1eb 100644
--- a/drivers/net/phy/Kconfig
+++ b/drivers/net/phy/Kconfig
@@ -55,6 +55,9 @@ config PHY_LXT
 config PHY_MARVELL
bool "Marvell Ethernet PHYs support"
 
+config PHY_MESON_GXL
+   bool "Amlogic Meson GXL Internal PHY support"
+
 config PHY_MICREL
bool "Micrel Ethernet PHYs support"
help
diff --git a/drivers/net/phy/Makefile b/drivers/net/phy/Makefile
index 54f32f6..1e264b2 100644
--- a/drivers/net/phy/Makefile
+++ b/drivers/net/phy/Makefile
@@ -21,6 +21,7 @@ obj-$(CONFIG_PHY_LXT) += lxt.o
 obj-$(CONFIG_PHY_MARVELL) += marvell.o
 obj-$(CONFIG_PHY_MICREL_KSZ8XXX) += micrel_ksz8xxx.o
 obj-$(CONFIG_PHY_MICREL_KSZ90X1) += micrel_ksz90x1.o
+obj-$(CONFIG_PHY_MESON_GXL) += meson-gxl.o
 obj-$(CONFIG_PHY_NATSEMI) += natsemi.o
 obj-$(CONFIG_PHY_REALTEK) += realtek.o
 obj-$(CONFIG_PHY_SMSC) += smsc.o
diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c
new file mode 100644
index 000..ccf70c9
--- /dev/null
+++ b/drivers/net/phy/meson-gxl.c
@@ -0,0 +1,57 @@
+/*
+ * Meson GXL Internal PHY Driver
+ *
+ * Copyright (C) 2015 Amlogic, Inc. All rights reserved.
+ * Copyright (C) 2016 BayLibre, SAS. All rights reserved.
+ * Author: Neil Armstrong 
+ *
+ * SPDX-License-Identifier:GPL-2.0+
+ */
+#include 
+#include 
+#include 
+#include 
+
+static int meson_gxl_phy_config(struct phy_device *phydev)
+{
+   /* Enable Analog and DSP register Bank access by */
+   phy_write(phydev, MDIO_DEVAD_NONE, 0x14, 0x);
+   phy_write(phydev, MDIO_DEVAD_NONE, 0x14, 0x0400);
+   phy_write(phydev, MDIO_DEVAD_NONE, 0x14, 0x);
+   phy_write(phydev, MDIO_DEVAD_NONE, 0x14, 0x0400);
+
+   /* Write Analog register 23 */
+   phy_write(phydev, MDIO_DEVAD_NONE, 0x17, 0x8E0D);
+   phy_write(phydev, MDIO_DEVAD_NONE, 0x14, 0x4417);
+
+   /* Enable fractional PLL */
+   phy_write(phydev, MDIO_DEVAD_NONE, 0x17, 0x0005);
+   phy_write(phydev, MDIO_DEVAD_NONE, 0x14, 0x5C1B);
+
+   /* Program fraction FR_PLL_DIV1 */
+   phy_write(phydev, MDIO_DEVAD_NONE, 0x17, 0x029A);
+   phy_write(phydev, MDIO_DEVAD_NONE, 0x14, 0x5C1D);
+
+   /* Program fraction FR_PLL_DIV1 */
+   phy_write(phydev, MDIO_DEVAD_NONE, 0x17, 0x);
+   phy_write(phydev, MDIO_DEVAD_NONE, 0x14, 0x5C1C);
+
+   return genphy_config(phydev);
+}
+
+static struct phy_driver meson_gxl_phy_driver = {
+   .name = "Meson GXL Internal PHY",
+   .uid = 0x01814400,
+   .mask = 0xfff0,
+   .features = PHY_BASIC_FEATURES,
+   .config = _gxl_phy_config,
+   .startup = _startup,
+   .shutdown = _shutdown,
+};
+
+int phy_meson_gxl_init(void)
+{
+   phy_register(_gxl_phy_driver);
+
+   return 0;
+}
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 5be51d7..fd3dd55 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -494,6 +494,9 @@ int phy_init(void)
 #ifdef CONFIG_PHY_MICREL_KSZ90X1
phy_micrel_ksz90x1_init();
 #endif
+#ifdef CONFIG_PHY_MESON_GXL
+   phy_meson_gxl_init();
+#endif
 #ifdef CONFIG_PHY_NATSEMI
phy_natsemi_init();
 #endif
diff --git a/include/phy.h b/include/phy.h
index a0b1f12..50f1e12 100644
--- a/include/phy.h
+++ b/include/phy.h
@@ -268,6 +268,7 @@ int phy_lxt_init(void);
 int phy_marvell_init(void);
 int phy_micrel_ksz8xxx_init(void);
 int phy_micrel_ksz90x1_init(void);
+int phy_meson_gxl_init(void);
 int phy_natsemi_init(void);
 int phy_realtek_init(void);
 int phy_smsc_init(void);
-- 
2.7.4

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot