Re: [U-Boot] [PATCH v2 0/3] CMD_USB_MASS_STORAGE implies USB_FUNCTION_MASS_STORAGE

2017-07-26 Thread Dr. Philipp Tomsich 

> On 17 Jul 2017, at 12:51, Łukasz Majewski  wrote:
> 
> Hi Marek,
> 
>> On 07/17/2017 10:39 AM, Łukasz Majewski wrote:
>>> On 07/14/2017 06:27 PM, Philipp Tomsich wrote:
 Up to now, there's been some ugliness associated with the
 dependency from CMD_USB_MASS_STORAGE to USB_FUNCTION_MASS_STORAGE:
 if someone only defined CMD_USB_MASS_STORAGE, they'd meet a linker
 error due to missing symbols that came from USB_FUNCTION_MASS_STORAGE.
 
 Most platforms seem to have resorted to unconditionally enable
 USB_FUNCTION_MASS_STORAGE via their 'common' config-header... some
 tried to tie this to an #ifdef CMD_USB_MASS_STORAGE (in fact I had a
 patch for the RK3399 that did just that and rather decided to clean
 this up once and for all instead of contributing to the prolongation
 of the status quo).  Neither is a good solution.
 
 So this series moves USB_FUNCTION_MASS_STORAGE to Kconfig and lets
 CMD_USB_MASS_STORAGE imply USB_FUNCTION_MASS_STORAGE.  Finally, we
 run moveconfig to contain the damage.
>>> 
>>> Thanks for the patch.
>>> 
>>> Rewieved-by: Lukasz Majewski 
>>> 
>>> 
>>> I was trying to apply those patches to Marek's -usb tree, but with some
>>> issues.
>>> 
>>> Marek, would you be some kind and update your's u-boot-denx-usb tree?
>> 
>> It's on u-boot/master + 1 patch for a while ... what's your problem ?
> 
> That is the patch 3/3 which causes the problem :-)
> 
> No issues from my side :-D
> 
>>  (HEAD -> refs/heads/master, refs/remotes/deploy/master)
>> 
>> ---
>> 807598a60c   | Masahiro Yamada | usb: add static to local symbols
>> ---
>> e14b1169c0   | Tom Rini| Merge git://www.denx.de/git/u-boot-marvell
>> 
>> Also cutting the screwed up CC list *eyeroll*
> 
> Yeah, I've realized that this list is too long after I've repied.
> 
> Philipp, could you make patch 3/3 applicable to Marek's u-boot-usb/master 
> tree?

Rebased onto u-boot-usb/master and resubmitted.

The CC list will still be excessive... but that’s due to moveconfig touching 
large
amounts of files and patman trying to keep everyone informed.

Regards,
Philipp.

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 0/3] CMD_USB_MASS_STORAGE implies USB_FUNCTION_MASS_STORAGE

2017-07-17 Thread Łukasz Majewski 

On 07/14/2017 06:27 PM, Philipp Tomsich wrote:

Up to now, there's been some ugliness associated with the
dependency from CMD_USB_MASS_STORAGE to USB_FUNCTION_MASS_STORAGE:
if someone only defined CMD_USB_MASS_STORAGE, they'd meet a linker
error due to missing symbols that came from USB_FUNCTION_MASS_STORAGE.

Most platforms seem to have resorted to unconditionally enable
USB_FUNCTION_MASS_STORAGE via their 'common' config-header... some
tried to tie this to an #ifdef CMD_USB_MASS_STORAGE (in fact I had a
patch for the RK3399 that did just that and rather decided to clean
this up once and for all instead of contributing to the prolongation
of the status quo).  Neither is a good solution.

So this series moves USB_FUNCTION_MASS_STORAGE to Kconfig and lets
CMD_USB_MASS_STORAGE imply USB_FUNCTION_MASS_STORAGE.  Finally, we
run moveconfig to contain the damage.


Thanks for the patch.

Rewieved-by: Lukasz Majewski 


I was trying to apply those patches to Marek's -usb tree, but with some 
issues.


Marek, would you be some kind and update your's u-boot-denx-usb tree?

Thanks in advance.



Changes in v2:
- ran 'tabify' on newly added lines (in Kconfig) to fix a spaces vs.
  tabs issues

Philipp Tomsich (3):
  usb: gadget: move USB_FUNCTION_MASS_STORAGE to Kconfig
  Kconfig: CMD_USB_MASS_STORAGE implies USB_FUNCTION_MASS_STORAGE
  config: move USB_FUNCTION_MASS_STORAGE

 cmd/Kconfig| 1 +
 configs/CHIP_pro_defconfig | 1 +
 configs/Nintendo_NES_Classic_Edition_defconfig | 1 +
 configs/Sinlinx_SinA33_defconfig   | 1 +
 configs/fennec-rk3288_defconfig| 1 +
 configs/firefly-rk3288_defconfig   | 1 +
 configs/kylin-rk3036_defconfig | 1 +
 configs/miqi-rk3288_defconfig  | 1 +
 configs/parrot_r16_defconfig   | 1 +
 configs/phycore-rk3288_defconfig   | 2 +-
 configs/popmetal-rk3288_defconfig  | 1 +
 configs/smdkv310_defconfig | 1 +
 configs/tinker-rk3288_defconfig| 1 +
 drivers/usb/gadget/Kconfig | 9 +
 include/configs/advantech_dms-ba16.h   | 1 -
 include/configs/apalis_imx6.h  | 1 -
 include/configs/bav335x.h  | 4 
 include/configs/cgtqmx6eval.h  | 2 --
 include/configs/colibri_imx6.h | 1 -
 include/configs/colibri_imx7.h | 2 --
 include/configs/colibri_vf.h   | 1 -
 include/configs/exynos4-common.h   | 2 --
 include/configs/ge_bx50v3.h| 1 -
 include/configs/gw_ventana.h   | 1 -
 include/configs/ma5d4evk.h | 1 -
 include/configs/mx6sabre_common.h  | 2 --
 include/configs/mx7dsabresd.h  | 2 --
 include/configs/nitrogen6x.h   | 2 --
 include/configs/odroid_xu3.h   | 1 -
 include/configs/opos6uldev.h   | 1 -
 include/configs/pico-imx6ul.h  | 1 -
 include/configs/pico-imx7d.h   | 2 --
 include/configs/rk3036_common.h| 1 -
 include/configs/rk322x_common.h| 1 -
 include/configs/rk3288_common.h| 1 -
 include/configs/rk3399_common.h| 4 
 include/configs/s5p_goni.h | 1 -
 include/configs/socfpga_common.h   | 2 --
 include/configs/sunxi-common.h | 1 -
 include/configs/tbs2910.h  | 1 -
 include/configs/tegra-common-usb-gadget.h  | 1 -
 include/configs/warp.h | 2 --
 include/configs/warp7.h| 2 --
 scripts/config_whitelist.txt   | 1 -
 44 files changed, 22 insertions(+), 47 deletions(-)




--
Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 0/3] CMD_USB_MASS_STORAGE implies USB_FUNCTION_MASS_STORAGE

2017-07-17 Thread Łukasz Majewski 

Hi Marek,


On 07/17/2017 10:39 AM, Łukasz Majewski wrote:

On 07/14/2017 06:27 PM, Philipp Tomsich wrote:

Up to now, there's been some ugliness associated with the
dependency from CMD_USB_MASS_STORAGE to USB_FUNCTION_MASS_STORAGE:
if someone only defined CMD_USB_MASS_STORAGE, they'd meet a linker
error due to missing symbols that came from USB_FUNCTION_MASS_STORAGE.

Most platforms seem to have resorted to unconditionally enable
USB_FUNCTION_MASS_STORAGE via their 'common' config-header... some
tried to tie this to an #ifdef CMD_USB_MASS_STORAGE (in fact I had a
patch for the RK3399 that did just that and rather decided to clean
this up once and for all instead of contributing to the prolongation
of the status quo).  Neither is a good solution.

So this series moves USB_FUNCTION_MASS_STORAGE to Kconfig and lets
CMD_USB_MASS_STORAGE imply USB_FUNCTION_MASS_STORAGE.  Finally, we
run moveconfig to contain the damage.


Thanks for the patch.

Rewieved-by: Lukasz Majewski 


I was trying to apply those patches to Marek's -usb tree, but with some
issues.

Marek, would you be some kind and update your's u-boot-denx-usb tree?


It's on u-boot/master + 1 patch for a while ... what's your problem ?


That is the patch 3/3 which causes the problem :-)

No issues from my side :-D


  (HEAD -> refs/heads/master, refs/remotes/deploy/master)

---
 807598a60c   | Masahiro Yamada | usb: add static to local symbols
---
 e14b1169c0   | Tom Rini| Merge git://www.denx.de/git/u-boot-marvell

Also cutting the screwed up CC list *eyeroll*


Yeah, I've realized that this list is too long after I've repied.

Philipp, could you make patch 3/3 applicable to Marek's 
u-boot-usb/master tree?


Thanks in advance.






--
Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 0/3] CMD_USB_MASS_STORAGE implies USB_FUNCTION_MASS_STORAGE

2017-07-17 Thread Marek Vasut 
On 07/17/2017 10:39 AM, Łukasz Majewski wrote:
> On 07/14/2017 06:27 PM, Philipp Tomsich wrote:
>> Up to now, there's been some ugliness associated with the
>> dependency from CMD_USB_MASS_STORAGE to USB_FUNCTION_MASS_STORAGE:
>> if someone only defined CMD_USB_MASS_STORAGE, they'd meet a linker
>> error due to missing symbols that came from USB_FUNCTION_MASS_STORAGE.
>>
>> Most platforms seem to have resorted to unconditionally enable
>> USB_FUNCTION_MASS_STORAGE via their 'common' config-header... some
>> tried to tie this to an #ifdef CMD_USB_MASS_STORAGE (in fact I had a
>> patch for the RK3399 that did just that and rather decided to clean
>> this up once and for all instead of contributing to the prolongation
>> of the status quo).  Neither is a good solution.
>>
>> So this series moves USB_FUNCTION_MASS_STORAGE to Kconfig and lets
>> CMD_USB_MASS_STORAGE imply USB_FUNCTION_MASS_STORAGE.  Finally, we
>> run moveconfig to contain the damage.
> 
> Thanks for the patch.
> 
> Rewieved-by: Lukasz Majewski 
> 
> 
> I was trying to apply those patches to Marek's -usb tree, but with some
> issues.
> 
> Marek, would you be some kind and update your's u-boot-denx-usb tree?

It's on u-boot/master + 1 patch for a while ... what's your problem ?
  (HEAD -> refs/heads/master, refs/remotes/deploy/master)

---
 807598a60c   | Masahiro Yamada | usb: add static to local symbols
---
 e14b1169c0   | Tom Rini| Merge git://www.denx.de/git/u-boot-marvell

Also cutting the screwed up CC list *eyeroll*

-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH v2 0/3] CMD_USB_MASS_STORAGE implies USB_FUNCTION_MASS_STORAGE

2017-07-14 Thread Philipp Tomsich 

Up to now, there's been some ugliness associated with the
dependency from CMD_USB_MASS_STORAGE to USB_FUNCTION_MASS_STORAGE:
if someone only defined CMD_USB_MASS_STORAGE, they'd meet a linker
error due to missing symbols that came from USB_FUNCTION_MASS_STORAGE.

Most platforms seem to have resorted to unconditionally enable
USB_FUNCTION_MASS_STORAGE via their 'common' config-header... some
tried to tie this to an #ifdef CMD_USB_MASS_STORAGE (in fact I had a
patch for the RK3399 that did just that and rather decided to clean
this up once and for all instead of contributing to the prolongation
of the status quo).  Neither is a good solution.

So this series moves USB_FUNCTION_MASS_STORAGE to Kconfig and lets
CMD_USB_MASS_STORAGE imply USB_FUNCTION_MASS_STORAGE.  Finally, we
run moveconfig to contain the damage.

Changes in v2:
- ran 'tabify' on newly added lines (in Kconfig) to fix a spaces vs.
  tabs issues

Philipp Tomsich (3):
  usb: gadget: move USB_FUNCTION_MASS_STORAGE to Kconfig
  Kconfig: CMD_USB_MASS_STORAGE implies USB_FUNCTION_MASS_STORAGE
  config: move USB_FUNCTION_MASS_STORAGE

 cmd/Kconfig| 1 +
 configs/CHIP_pro_defconfig | 1 +
 configs/Nintendo_NES_Classic_Edition_defconfig | 1 +
 configs/Sinlinx_SinA33_defconfig   | 1 +
 configs/fennec-rk3288_defconfig| 1 +
 configs/firefly-rk3288_defconfig   | 1 +
 configs/kylin-rk3036_defconfig | 1 +
 configs/miqi-rk3288_defconfig  | 1 +
 configs/parrot_r16_defconfig   | 1 +
 configs/phycore-rk3288_defconfig   | 2 +-
 configs/popmetal-rk3288_defconfig  | 1 +
 configs/smdkv310_defconfig | 1 +
 configs/tinker-rk3288_defconfig| 1 +
 drivers/usb/gadget/Kconfig | 9 +
 include/configs/advantech_dms-ba16.h   | 1 -
 include/configs/apalis_imx6.h  | 1 -
 include/configs/bav335x.h  | 4 
 include/configs/cgtqmx6eval.h  | 2 --
 include/configs/colibri_imx6.h | 1 -
 include/configs/colibri_imx7.h | 2 --
 include/configs/colibri_vf.h   | 1 -
 include/configs/exynos4-common.h   | 2 --
 include/configs/ge_bx50v3.h| 1 -
 include/configs/gw_ventana.h   | 1 -
 include/configs/ma5d4evk.h | 1 -
 include/configs/mx6sabre_common.h  | 2 --
 include/configs/mx7dsabresd.h  | 2 --
 include/configs/nitrogen6x.h   | 2 --
 include/configs/odroid_xu3.h   | 1 -
 include/configs/opos6uldev.h   | 1 -
 include/configs/pico-imx6ul.h  | 1 -
 include/configs/pico-imx7d.h   | 2 --
 include/configs/rk3036_common.h| 1 -
 include/configs/rk322x_common.h| 1 -
 include/configs/rk3288_common.h| 1 -
 include/configs/rk3399_common.h| 4 
 include/configs/s5p_goni.h | 1 -
 include/configs/socfpga_common.h   | 2 --
 include/configs/sunxi-common.h | 1 -
 include/configs/tbs2910.h  | 1 -
 include/configs/tegra-common-usb-gadget.h  | 1 -
 include/configs/warp.h | 2 --
 include/configs/warp7.h| 2 --
 scripts/config_whitelist.txt   | 1 -
 44 files changed, 22 insertions(+), 47 deletions(-)

-- 
2.1.4

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot