[U-Boot] [PATCH v2 1/6] h2200: Add support for iPAQ h2200 palmtop
Basic support of HP iPAQ h2200 palmtop. Support includes also USB
ethernet gadget.
Signed-off-by: Lukasz Dalek luk0...@gmail.com
---
board/h2200/Makefile | 51
board/h2200/h2200-header.S | 27 ++
board/h2200/h2200.c| 66 +++
board/h2200/h2200.h| 28 +++
boards.cfg |2 +
include/configs/h2200.h| 189
6 files changed, 363 insertions(+), 0 deletions(-)
create mode 100644 board/h2200/Makefile
create mode 100644 board/h2200/h2200-header.S
create mode 100644 board/h2200/h2200.c
create mode 100644 board/h2200/h2200.h
create mode 100644 include/configs/h2200.h
diff --git a/board/h2200/Makefile b/board/h2200/Makefile
new file mode 100644
index 000..2265aa9
--- /dev/null
+++ b/board/h2200/Makefile
@@ -0,0 +1,51 @@
+#
+# h2200 Support
+#
+# Copyright (C) 2012 Lukasz Dalek luk0...@gmail.com
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+include $(TOPDIR)/config.mk
+
+LIB= $(obj)lib$(BOARD).o
+
+COBJS := h2200.o
+
+SRCS := $(COBJS:.o=.c) h2200-header.S
+OBJS := $(addprefix $(obj),$(COBJS))
+
+ALL: $(LIB) h2200-header.bin
+
+h2200-header.o: h2200-header.S
+ $(CC) $(CFLAGS) -c -o $@ $
+
+h2200-header.bin: h2200-header.o
+ $(OBJCOPY) -O binary $ $@
+
+all: $(LIB) h2200-header.bin
+
+$(LIB):$(obj).depend $(OBJS)
+ $(call cmd_link_o_target, $(OBJS))
+
+#
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#
diff --git a/board/h2200/h2200-header.S b/board/h2200/h2200-header.S
new file mode 100644
index 000..c335bfe
--- /dev/null
+++ b/board/h2200/h2200-header.S
@@ -0,0 +1,27 @@
+/*
+ * iPAQ h2200 header
+ *
+ * Copyright (C) 2012 Lukasz Dalek luk0...@gmail.com
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ */
+
+ .word 0xea0003fe /* b 0x1000 */
+
+ .org 0x40
+ .ascii ECEC
+
+ .org 0x1000 - 1
+ .byte 0x0
diff --git a/board/h2200/h2200.c b/board/h2200/h2200.c
new file mode 100644
index 000..a6b1c48
--- /dev/null
+++ b/board/h2200/h2200.c
@@ -0,0 +1,66 @@
+/*
+ * iPAQ h2200 board configuration
+ *
+ * Copyright (C) 2012 Lukasz Dalek luk0...@gmail.com
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ */
+
+#include common.h
+#include asm/arch/pxa.h
+#include asm/arch/pxa-regs.h
+#include asm/io.h
+#include h2200.h
+
+DECLARE_GLOBAL_DATA_PTR;
+
+#ifdef CONFIG_H2200_USBETH
+int board_eth_init(bd_t *bis)
+{
+ usb_eth_initialize(bis);
+ return 0;
+}
+#endif
+
+int board_init(void)
+{
+ /* We have RAM, disable cache */
+ dcache_disable();
+ icache_disable();
+
+ gd-bd-bi_arch_number = MACH_TYPE_H2200;
+
+ /* adress of boot parameters */
+ gd-bd-bi_boot_params = 0xa100;
+
+ /*
Re: [U-Boot] [PATCH v2 1/6] h2200: Add support for iPAQ h2200 palmtop
Dear Lukasz Dalek,
[...]
+int dram_init(void)
+{
+ /*
+ * Everything except MSC0 was already set up by
+ * 1st stage bootloader
+ */
+ clrsetbits_le32(MSC0, 0x, 0x246c7ffc);
This magic would use more description eventually.
+ gd-ram_size = CONFIG_SYS_SDRAM_SIZE;
+ return 0;
+}
diff --git a/board/h2200/h2200.h b/board/h2200/h2200.h
new file mode 100644
Do you need this file at all? Can the udc_disconnect() not be put somewhere
into
usb.h ?
[...]
Rest seems fine, thanks.
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/6] h2200: Add support for iPAQ h2200 palmtop
On 23.09.2012 17:43, Marek Vasut wrote: + gd-ram_size = CONFIG_SYS_SDRAM_SIZE; + return 0; +} diff --git a/board/h2200/h2200.h b/board/h2200/h2200.h new file mode 100644 Do you need this file at all? Can the udc_disconnect() not be put somewhere into usb.h ? Can I just move this declaration into h2200.c? Łukasz Dałek ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/6] h2200: Add support for iPAQ h2200 palmtop
Dear Łukasz Dałek, On 23.09.2012 17:43, Marek Vasut wrote: + gd-ram_size = CONFIG_SYS_SDRAM_SIZE; + return 0; +} diff --git a/board/h2200/h2200.h b/board/h2200/h2200.h new file mode 100644 Do you need this file at all? Can the udc_disconnect() not be put somewhere into usb.h ? Can I just move this declaration into h2200.c? extern ... ? No, checkpatch will scream and extern is prohibited for a good reason. Łukasz Dałek Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/6] h2200: Add support for iPAQ h2200 palmtop
On 23.09.2012 21:31, Marek Vasut wrote: Dear Łukasz Dałek, On 23.09.2012 17:43, Marek Vasut wrote: + gd-ram_size = CONFIG_SYS_SDRAM_SIZE; + return 0; +} diff --git a/board/h2200/h2200.h b/board/h2200/h2200.h new file mode 100644 Do you need this file at all? Can the udc_disconnect() not be put somewhere into usb.h ? Can I just move this declaration into h2200.c? extern ... ? No, checkpatch will scream and extern is prohibited for a good reason. So where should I put it? Łukasz Dałek ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/6] h2200: Add support for iPAQ h2200 palmtop
Dear Łukasz Dałek, On 23.09.2012 21:31, Marek Vasut wrote: Dear Łukasz Dałek, On 23.09.2012 17:43, Marek Vasut wrote: +gd-ram_size = CONFIG_SYS_SDRAM_SIZE; +return 0; +} diff --git a/board/h2200/h2200.h b/board/h2200/h2200.h new file mode 100644 Do you need this file at all? Can the udc_disconnect() not be put somewhere into usb.h ? Can I just move this declaration into h2200.c? extern ... ? No, checkpatch will scream and extern is prohibited for a good reason. So where should I put it? Isn't it a general call? some include/usb.h ? Łukasz Dałek Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/6] h2200: Add support for iPAQ h2200 palmtop
On 23.09.2012 22:05, Marek Vasut wrote: Dear Łukasz Dałek, On 23.09.2012 21:31, Marek Vasut wrote: Dear Łukasz Dałek, On 23.09.2012 17:43, Marek Vasut wrote: + gd-ram_size = CONFIG_SYS_SDRAM_SIZE; + return 0; +} diff --git a/board/h2200/h2200.h b/board/h2200/h2200.h new file mode 100644 Do you need this file at all? Can the udc_disconnect() not be put somewhere into usb.h ? Can I just move this declaration into h2200.c? extern ... ? No, checkpatch will scream and extern is prohibited for a good reason. So where should I put it? Isn't it a general call? some include/usb.h ? For old layer maybe it is. I'm not sure but include/usb.h is for device implementing usb host but pxa can only be device. Including usb.h generate error. I'm going to add sd card support and other functions, maybe leaving it would be better idea? Łukasz Dałek ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/6] h2200: Add support for iPAQ h2200 palmtop
Dear Łukasz Dałek, On 23.09.2012 22:05, Marek Vasut wrote: Dear Łukasz Dałek, On 23.09.2012 21:31, Marek Vasut wrote: Dear Łukasz Dałek, On 23.09.2012 17:43, Marek Vasut wrote: + gd-ram_size = CONFIG_SYS_SDRAM_SIZE; + return 0; +} diff --git a/board/h2200/h2200.h b/board/h2200/h2200.h new file mode 100644 Do you need this file at all? Can the udc_disconnect() not be put somewhere into usb.h ? Can I just move this declaration into h2200.c? extern ... ? No, checkpatch will scream and extern is prohibited for a good reason. So where should I put it? Isn't it a general call? some include/usb.h ? For old layer maybe it is. I'm not sure but include/usb.h is for device implementing usb host but pxa can only be device. PXA can be both, actually u-boot is mostly about host. Just put it there. Including usb.h generate error. I'm going to add sd card support and other functions, maybe leaving it would be better idea? Why do you think usb.h is not a good place ? Łukasz Dałek Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/6] h2200: Add support for iPAQ h2200 palmtop
On 23.09.2012 22:52, Marek Vasut wrote: Dear Łukasz Dałek, On 23.09.2012 22:05, Marek Vasut wrote: Dear Łukasz Dałek, On 23.09.2012 21:31, Marek Vasut wrote: Dear Łukasz Dałek, On 23.09.2012 17:43, Marek Vasut wrote: + gd-ram_size = CONFIG_SYS_SDRAM_SIZE; + return 0; +} diff --git a/board/h2200/h2200.h b/board/h2200/h2200.h new file mode 100644 Do you need this file at all? Can the udc_disconnect() not be put somewhere into usb.h ? Can I just move this declaration into h2200.c? extern ... ? No, checkpatch will scream and extern is prohibited for a good reason. So where should I put it? Isn't it a general call? some include/usb.h ? For old layer maybe it is. I'm not sure but include/usb.h is for device implementing usb host but pxa can only be device. PXA can be both, actually u-boot is mostly about host. Just put it there. Including usb.h generate error. I'm going to add sd card support and other functions, maybe leaving it would be better idea? Why do you think usb.h is not a good place ? Because: #if defined(CONFIG_USB_UHCI) || defined(CONFIG_USB_OHCI) || \ defined(CONFIG_USB_EHCI) || defined(CONFIG_USB_OHCI_NEW) || \ defined(CONFIG_USB_SL811HS) || defined(CONFIG_USB_ISP116X_HCD) || \ defined(CONFIG_USB_R8A66597_HCD) || defined(CONFIG_USB_DAVINCI) || \ defined(CONFIG_USB_OMAP3) || defined(CONFIG_USB_DA8XX) || \ defined(CONFIG_USB_BLACKFIN) || defined(CONFIG_USB_AM35X) ... #else #error USB Lowlevel not defined #endif All of these definitions are usb host implementation (maybe OTG too) but pxa cannot be host. Łukasz Dałek ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/6] h2200: Add support for iPAQ h2200 palmtop
Dear Łukasz Dałek, On 23.09.2012 22:52, Marek Vasut wrote: Dear Łukasz Dałek, On 23.09.2012 22:05, Marek Vasut wrote: Dear Łukasz Dałek, On 23.09.2012 21:31, Marek Vasut wrote: Dear Łukasz Dałek, On 23.09.2012 17:43, Marek Vasut wrote: +gd-ram_size = CONFIG_SYS_SDRAM_SIZE; +return 0; +} diff --git a/board/h2200/h2200.h b/board/h2200/h2200.h new file mode 100644 Do you need this file at all? Can the udc_disconnect() not be put somewhere into usb.h ? Can I just move this declaration into h2200.c? extern ... ? No, checkpatch will scream and extern is prohibited for a good reason. So where should I put it? Isn't it a general call? some include/usb.h ? For old layer maybe it is. I'm not sure but include/usb.h is for device implementing usb host but pxa can only be device. PXA can be both, actually u-boot is mostly about host. Just put it there. Including usb.h generate error. I'm going to add sd card support and other functions, maybe leaving it would be better idea? Why do you think usb.h is not a good place ? Because: #if defined(CONFIG_USB_UHCI) || defined(CONFIG_USB_OHCI) || \ defined(CONFIG_USB_EHCI) || defined(CONFIG_USB_OHCI_NEW) || \ defined(CONFIG_USB_SL811HS) || defined(CONFIG_USB_ISP116X_HCD) || \ defined(CONFIG_USB_R8A66597_HCD) || defined(CONFIG_USB_DAVINCI) || \ defined(CONFIG_USB_OMAP3) || defined(CONFIG_USB_DA8XX) || \ defined(CONFIG_USB_BLACKFIN) || defined(CONFIG_USB_AM35X) ... #else #error USB Lowlevel not defined #endif All of these definitions are usb host implementation (maybe OTG too) but pxa cannot be host. PXA2xx is OHCI host with one OTG port. what about include/usb/pxa27x_udc.h ... btw can't pxa27x and pxa25x UDC use the same driver? Łukasz Dałek Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/6] h2200: Add support for iPAQ h2200 palmtop
On 23.09.2012 23:04, Marek Vasut wrote: Dear Łukasz Dałek, On 23.09.2012 22:52, Marek Vasut wrote: Dear Łukasz Dałek, On 23.09.2012 22:05, Marek Vasut wrote: Dear Łukasz Dałek, On 23.09.2012 21:31, Marek Vasut wrote: Dear Łukasz Dałek, On 23.09.2012 17:43, Marek Vasut wrote: + gd-ram_size = CONFIG_SYS_SDRAM_SIZE; + return 0; +} diff --git a/board/h2200/h2200.h b/board/h2200/h2200.h new file mode 100644 Do you need this file at all? Can the udc_disconnect() not be put somewhere into usb.h ? Can I just move this declaration into h2200.c? extern ... ? No, checkpatch will scream and extern is prohibited for a good reason. So where should I put it? Isn't it a general call? some include/usb.h ? For old layer maybe it is. I'm not sure but include/usb.h is for device implementing usb host but pxa can only be device. PXA can be both, actually u-boot is mostly about host. Just put it there. Including usb.h generate error. I'm going to add sd card support and other functions, maybe leaving it would be better idea? Why do you think usb.h is not a good place ? Because: #if defined(CONFIG_USB_UHCI) || defined(CONFIG_USB_OHCI) || \ defined(CONFIG_USB_EHCI) || defined(CONFIG_USB_OHCI_NEW) || \ defined(CONFIG_USB_SL811HS) || defined(CONFIG_USB_ISP116X_HCD) || \ defined(CONFIG_USB_R8A66597_HCD) || defined(CONFIG_USB_DAVINCI) || \ defined(CONFIG_USB_OMAP3) || defined(CONFIG_USB_DA8XX) || \ defined(CONFIG_USB_BLACKFIN) || defined(CONFIG_USB_AM35X) ... #else #error USB Lowlevel not defined #endif All of these definitions are usb host implementation (maybe OTG too) but pxa cannot be host. PXA2xx is OHCI host with one OTG port. From pxa255 documentation: The UDC supports 16 endpoints and can operate half-duplex at a rate of 12 Mbps (as a slave only, not as a host or hub controller). what about include/usb/pxa27x_udc.h ... btw can't pxa27x and pxa25x UDC use the same driver? pxa27x_udc driver is using older layer which doesn't work with usb ethernet driver. Btw. pxa27x can be host, pxa25x can't. Łukasz Dałek ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/6] h2200: Add support for iPAQ h2200 palmtop
Dear Łukasz Dałek, On 23.09.2012 23:04, Marek Vasut wrote: Dear Łukasz Dałek, On 23.09.2012 22:52, Marek Vasut wrote: Dear Łukasz Dałek, On 23.09.2012 22:05, Marek Vasut wrote: Dear Łukasz Dałek, On 23.09.2012 21:31, Marek Vasut wrote: Dear Łukasz Dałek, On 23.09.2012 17:43, Marek Vasut wrote: + gd-ram_size = CONFIG_SYS_SDRAM_SIZE; + return 0; +} diff --git a/board/h2200/h2200.h b/board/h2200/h2200.h new file mode 100644 Do you need this file at all? Can the udc_disconnect() not be put somewhere into usb.h ? Can I just move this declaration into h2200.c? extern ... ? No, checkpatch will scream and extern is prohibited for a good reason. So where should I put it? Isn't it a general call? some include/usb.h ? For old layer maybe it is. I'm not sure but include/usb.h is for device implementing usb host but pxa can only be device. PXA can be both, actually u-boot is mostly about host. Just put it there. Including usb.h generate error. I'm going to add sd card support and other functions, maybe leaving it would be better idea? Why do you think usb.h is not a good place ? Because: #if defined(CONFIG_USB_UHCI) || defined(CONFIG_USB_OHCI) || \ defined(CONFIG_USB_EHCI) || defined(CONFIG_USB_OHCI_NEW) || \ defined(CONFIG_USB_SL811HS) || defined(CONFIG_USB_ISP116X_HCD) || \ defined(CONFIG_USB_R8A66597_HCD) || defined(CONFIG_USB_DAVINCI) || \ defined(CONFIG_USB_OMAP3) || defined(CONFIG_USB_DA8XX) || \ defined(CONFIG_USB_BLACKFIN) || defined(CONFIG_USB_AM35X) ... #else #error USB Lowlevel not defined #endif All of these definitions are usb host implementation (maybe OTG too) but pxa cannot be host. PXA2xx is OHCI host with one OTG port. From pxa255 documentation: The UDC supports 16 endpoints and can operate half-duplex at a rate of 12 Mbps (as a slave only, not as a host or hub controller). what about include/usb/pxa27x_udc.h ... btw can't pxa27x and pxa25x UDC use the same driver? pxa27x_udc driver is using older layer which doesn't work with usb ethernet driver. Btw. pxa27x can be host, pxa25x can't. Can you update the new gadget driver to be compatible with pxa27x then ? Łukasz Dałek Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/6] h2200: Add support for iPAQ h2200 palmtop
On 23.09.2012 23:31, Marek Vasut wrote: Dear Łukasz Dałek, On 23.09.2012 23:04, Marek Vasut wrote: PXA2xx is OHCI host with one OTG port. From pxa255 documentation: The UDC supports 16 endpoints and can operate half-duplex at a rate of 12 Mbps (as a slave only, not as a host or hub controller). what about include/usb/pxa27x_udc.h ... btw can't pxa27x and pxa25x UDC use the same driver? pxa27x_udc driver is using older layer which doesn't work with usb ethernet driver. Btw. pxa27x can be host, pxa25x can't. Can you update the new gadget driver to be compatible with pxa27x then ? I don't have any board with pxa27x processor. And I'm quite sure that differences between pxa25x and pxa27x usb are too big. Even in Linux kernel are two separate drivers for 25x and 27x chips. Łukasz Dałek ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/6] h2200: Add support for iPAQ h2200 palmtop
Dear Łukasz Dałek, On 23.09.2012 23:31, Marek Vasut wrote: Dear Łukasz Dałek, On 23.09.2012 23:04, Marek Vasut wrote: PXA2xx is OHCI host with one OTG port. From pxa255 documentation: The UDC supports 16 endpoints and can operate half-duplex at a rate of 12 Mbps (as a slave only, not as a host or hub controller). what about include/usb/pxa27x_udc.h ... btw can't pxa27x and pxa25x UDC use the same driver? pxa27x_udc driver is using older layer which doesn't work with usb ethernet driver. Btw. pxa27x can be host, pxa25x can't. Can you update the new gadget driver to be compatible with pxa27x then ? I don't have any board with pxa27x processor. And I'm quite sure that differences between pxa25x and pxa27x usb are too big. Even in Linux kernel are two separate drivers for 25x and 27x chips. Isn't the 25x only a subset of the 27x ? Łukasz Dałek Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/6] h2200: Add support for iPAQ h2200 palmtop
On 24.09.2012 01:05, Marek Vasut wrote: Dear Łukasz Dałek, On 23.09.2012 23:31, Marek Vasut wrote: Dear Łukasz Dałek, On 23.09.2012 23:04, Marek Vasut wrote: PXA2xx is OHCI host with one OTG port. From pxa255 documentation: The UDC supports 16 endpoints and can operate half-duplex at a rate of 12 Mbps (as a slave only, not as a host or hub controller). what about include/usb/pxa27x_udc.h ... btw can't pxa27x and pxa25x UDC use the same driver? pxa27x_udc driver is using older layer which doesn't work with usb ethernet driver. Btw. pxa27x can be host, pxa25x can't. Can you update the new gadget driver to be compatible with pxa27x then ? I don't have any board with pxa27x processor. And I'm quite sure that differences between pxa25x and pxa27x usb are too big. Even in Linux kernel are two separate drivers for 25x and 27x chips. Isn't the 25x only a subset of the 27x ? Maybe it is. You've asked me if I could update driver to compatible with pxa27x and my answer is no. Maybe someone with pxa27x chip could. I will left that h2200.h header. I'm sure that it will be helpful some day. Łukasz Dałek ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/6] h2200: Add support for iPAQ h2200 palmtop
Dear Łukasz Dałek, On 24.09.2012 01:05, Marek Vasut wrote: Dear Łukasz Dałek, On 23.09.2012 23:31, Marek Vasut wrote: Dear Łukasz Dałek, On 23.09.2012 23:04, Marek Vasut wrote: PXA2xx is OHCI host with one OTG port. From pxa255 documentation: The UDC supports 16 endpoints and can operate half-duplex at a rate of 12 Mbps (as a slave only, not as a host or hub controller). what about include/usb/pxa27x_udc.h ... btw can't pxa27x and pxa25x UDC use the same driver? pxa27x_udc driver is using older layer which doesn't work with usb ethernet driver. Btw. pxa27x can be host, pxa25x can't. Can you update the new gadget driver to be compatible with pxa27x then ? I don't have any board with pxa27x processor. And I'm quite sure that differences between pxa25x and pxa27x usb are too big. Even in Linux kernel are two separate drivers for 25x and 27x chips. Isn't the 25x only a subset of the 27x ? Maybe it is. You've asked me if I could update driver to compatible with pxa27x and my answer is no. Maybe someone with pxa27x chip could. I can test it. It'd be good to have only one driver and get rid of the old one seems to be the way to go. I will left that h2200.h header. I'm sure that it will be helpful some day. For what exactly? Just put it into include/usb.h . Łukasz Dałek Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/6] h2200: Add support for iPAQ h2200 palmtop
On 24.09.2012 01:25, Marek Vasut wrote: Dear Łukasz Dałek, On 24.09.2012 01:05, Marek Vasut wrote: Dear Łukasz Dałek, On 23.09.2012 23:31, Marek Vasut wrote: Dear Łukasz Dałek, On 23.09.2012 23:04, Marek Vasut wrote: PXA2xx is OHCI host with one OTG port. From pxa255 documentation: The UDC supports 16 endpoints and can operate half-duplex at a rate of 12 Mbps (as a slave only, not as a host or hub controller). what about include/usb/pxa27x_udc.h ... btw can't pxa27x and pxa25x UDC use the same driver? pxa27x_udc driver is using older layer which doesn't work with usb ethernet driver. Btw. pxa27x can be host, pxa25x can't. Can you update the new gadget driver to be compatible with pxa27x then ? I don't have any board with pxa27x processor. And I'm quite sure that differences between pxa25x and pxa27x usb are too big. Even in Linux kernel are two separate drivers for 25x and 27x chips. Isn't the 25x only a subset of the 27x ? Maybe it is. You've asked me if I could update driver to compatible with pxa27x and my answer is no. Maybe someone with pxa27x chip could. I can test it. It'd be good to have only one driver and get rid of the old one seems to be the way to go. Does this driver work with usb ethernet gadget? I will left that h2200.h header. I'm sure that it will be helpful some day. For what exactly? Just put it into include/usb.h . I can't. It doesn't compile because of #error at 170 line. Łukasz Dałek ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/6] h2200: Add support for iPAQ h2200 palmtop
Dear Łukasz Dałek, On 24.09.2012 01:25, Marek Vasut wrote: Dear Łukasz Dałek, On 24.09.2012 01:05, Marek Vasut wrote: Dear Łukasz Dałek, On 23.09.2012 23:31, Marek Vasut wrote: Dear Łukasz Dałek, On 23.09.2012 23:04, Marek Vasut wrote: PXA2xx is OHCI host with one OTG port. From pxa255 documentation: The UDC supports 16 endpoints and can operate half-duplex at a rate of 12 Mbps (as a slave only, not as a host or hub controller). what about include/usb/pxa27x_udc.h ... btw can't pxa27x and pxa25x UDC use the same driver? pxa27x_udc driver is using older layer which doesn't work with usb ethernet driver. Btw. pxa27x can be host, pxa25x can't. Can you update the new gadget driver to be compatible with pxa27x then ? I don't have any board with pxa27x processor. And I'm quite sure that differences between pxa25x and pxa27x usb are too big. Even in Linux kernel are two separate drivers for 25x and 27x chips. Isn't the 25x only a subset of the 27x ? Maybe it is. You've asked me if I could update driver to compatible with pxa27x and my answer is no. Maybe someone with pxa27x chip could. I can test it. It'd be good to have only one driver and get rid of the old one seems to be the way to go. Does this driver work with usb ethernet gadget? I have no idea, I never used it (and I'm not quite sure it's used at all). It's a rotting piece of code, maybe we should throw it out altogether. I will left that h2200.h header. I'm sure that it will be helpful some day. For what exactly? Just put it into include/usb.h . I can't. It doesn't compile because of #error at 170 line. You know ... #elif defined () is your friend there. Besides seriously, it'd be very nice to share the error message if nothing else ... Łukasz Dałek Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
