Re: [U-Boot] [PATCH v2 2/7] i.MX6DL: mamoj: Add I2C support

2018-04-26 Thread Stefano Babic 
On 11/04/2018 14:36, Jagan Teki wrote:
> i.MX6DL Mamoj has i2c3 and i2c4 buses, add support
> through DM_I2C with dt definition.
> 
> i2c log:
> ===
> => i2c bus
> Bus 2:  i2c@021a8000
> Bus 3:  i2c@021f8000
> => i2c dev 2
> Setting bus to 2
> => i2c speed 40
> Setting bus speed to 40 Hz
> => i2c probe
> Valid chip addresses: 20 51 53
> => i2c md 53 0xff
> 00ff: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> => i2c md 51 0xff
> 00ff: a8 08 40 50 09 43 46 52 42 18 80 8e ae a9 d0 53..@P.CFRB..S
> => i2c dev 3
> Setting bus to 3
> => i2c speed 10
> Setting bus speed to 10 Hz
> => i2c probe
> Valid chip addresses: 08 40 48 4B
> => i2c md 08 0xff
> 00ff: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 
> Signed-off-by: Jagan Teki 
> Signed-off-by: Simone CIANNI 
> Signed-off-by: Raffaele RECALCATI 
> ---
>  arch/arm/dts/imx6dl-mamoj.dts  | 28 
>  arch/arm/mach-imx/mx6/Kconfig  |  1 +
>  configs/imx6dl_mamoj_defconfig |  2 ++
>  3 files changed, 31 insertions(+)
> 
> diff --git a/arch/arm/dts/imx6dl-mamoj.dts b/arch/arm/dts/imx6dl-mamoj.dts
> index 068d518de3..558043445b 100644
> --- a/arch/arm/dts/imx6dl-mamoj.dts
> +++ b/arch/arm/dts/imx6dl-mamoj.dts
> @@ -21,6 +21,20 @@
>   status = "okay";
>  };
>  
> + {
> + clock-frequency = <40>;
> + pinctrl-names = "default";
> + pinctrl-0 = <_i2c3>;
> + status = "okay";
> +};
> +
> + {
> + clock-frequency = <10>;
> + pinctrl-names = "default";
> + pinctrl-0 = <_i2c4>;
> + status = "okay";
> +};
> +
>   {
>   pinctrl-names = "default";
>   pinctrl-0 = <_uart3>;
> @@ -60,6 +74,20 @@
>   >;
>   };
>  
> + pinctrl_i2c3: i2c3grp {
> + fsl,pins = <
> + MX6QDL_PAD_GPIO_3__I2C3_SCL 0x4001b8b1
> + MX6QDL_PAD_GPIO_6__I2C3_SDA 0x4001b8b1
> + >;
> + };
> +
> + pinctrl_i2c4: i2c4grp {
> + fsl,pins = <
> + MX6QDL_PAD_GPIO_7__I2C4_SCL 0x4001b8b1
> + MX6QDL_PAD_GPIO_8__I2C4_SDA 0x4001b8b1
> + >;
> + };
> +
>   pinctrl_uart3: uart3grp {
>   fsl,pins = <
>   MX6QDL_PAD_EIM_D24__UART3_TX_DATA   0x1b0b1
> diff --git a/arch/arm/mach-imx/mx6/Kconfig b/arch/arm/mach-imx/mx6/Kconfig
> index c6acba7f85..5007fe3941 100644
> --- a/arch/arm/mach-imx/mx6/Kconfig
> +++ b/arch/arm/mach-imx/mx6/Kconfig
> @@ -233,6 +233,7 @@ config TARGET_MX6DL_MAMOJ
>   select DM
>   select DM_ETH
>   select DM_GPIO
> + select DM_I2C
>   select DM_MMC
>   select DM_THERMAL
>   select SPL
> diff --git a/configs/imx6dl_mamoj_defconfig b/configs/imx6dl_mamoj_defconfig
> index e45ca9a05a..e2a18d2c30 100644
> --- a/configs/imx6dl_mamoj_defconfig
> +++ b/configs/imx6dl_mamoj_defconfig
> @@ -12,6 +12,7 @@ CONFIG_SYS_PROMPT="=> "
>  CONFIG_CRC32_VERIFY=y
>  CONFIG_CMD_MEMTEST=y
>  CONFIG_CMD_GPIO=y
> +CONFIG_CMD_I2C=y
>  CONFIG_CMD_MMC=y
>  CONFIG_CMD_MII=y
>  CONFIG_CMD_PING=y
> @@ -37,3 +38,4 @@ CONFIG_USB_GADGET_VENDOR_NUM=0x0525
>  CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5
>  CONFIG_CI_UDC=y
>  CONFIG_IMX_THERMAL=y
> +CONFIG_SYS_I2C_MXC=y
> 

Reviewed-by: Stefano Babic 

Best regards,
Stefano Babic

-- 
=
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH v2 2/7] i.MX6DL: mamoj: Add I2C support

2018-04-11 Thread Jagan Teki 
i.MX6DL Mamoj has i2c3 and i2c4 buses, add support
through DM_I2C with dt definition.

i2c log:
===
=> i2c bus
Bus 2:  i2c@021a8000
Bus 3:  i2c@021f8000
=> i2c dev 2
Setting bus to 2
=> i2c speed 40
Setting bus speed to 40 Hz
=> i2c probe
Valid chip addresses: 20 51 53
=> i2c md 53 0xff
00ff: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
=> i2c md 51 0xff
00ff: a8 08 40 50 09 43 46 52 42 18 80 8e ae a9 d0 53..@P.CFRB..S
=> i2c dev 3
Setting bus to 3
=> i2c speed 10
Setting bus speed to 10 Hz
=> i2c probe
Valid chip addresses: 08 40 48 4B
=> i2c md 08 0xff
00ff: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

Signed-off-by: Jagan Teki 
Signed-off-by: Simone CIANNI 
Signed-off-by: Raffaele RECALCATI 
---
 arch/arm/dts/imx6dl-mamoj.dts  | 28 
 arch/arm/mach-imx/mx6/Kconfig  |  1 +
 configs/imx6dl_mamoj_defconfig |  2 ++
 3 files changed, 31 insertions(+)

diff --git a/arch/arm/dts/imx6dl-mamoj.dts b/arch/arm/dts/imx6dl-mamoj.dts
index 068d518de3..558043445b 100644
--- a/arch/arm/dts/imx6dl-mamoj.dts
+++ b/arch/arm/dts/imx6dl-mamoj.dts
@@ -21,6 +21,20 @@
status = "okay";
 };
 
+ {
+   clock-frequency = <40>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_i2c3>;
+   status = "okay";
+};
+
+ {
+   clock-frequency = <10>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_i2c4>;
+   status = "okay";
+};
+
  {
pinctrl-names = "default";
pinctrl-0 = <_uart3>;
@@ -60,6 +74,20 @@
>;
};
 
+   pinctrl_i2c3: i2c3grp {
+   fsl,pins = <
+   MX6QDL_PAD_GPIO_3__I2C3_SCL 0x4001b8b1
+   MX6QDL_PAD_GPIO_6__I2C3_SDA 0x4001b8b1
+   >;
+   };
+
+   pinctrl_i2c4: i2c4grp {
+   fsl,pins = <
+   MX6QDL_PAD_GPIO_7__I2C4_SCL 0x4001b8b1
+   MX6QDL_PAD_GPIO_8__I2C4_SDA 0x4001b8b1
+   >;
+   };
+
pinctrl_uart3: uart3grp {
fsl,pins = <
MX6QDL_PAD_EIM_D24__UART3_TX_DATA   0x1b0b1
diff --git a/arch/arm/mach-imx/mx6/Kconfig b/arch/arm/mach-imx/mx6/Kconfig
index c6acba7f85..5007fe3941 100644
--- a/arch/arm/mach-imx/mx6/Kconfig
+++ b/arch/arm/mach-imx/mx6/Kconfig
@@ -233,6 +233,7 @@ config TARGET_MX6DL_MAMOJ
select DM
select DM_ETH
select DM_GPIO
+   select DM_I2C
select DM_MMC
select DM_THERMAL
select SPL
diff --git a/configs/imx6dl_mamoj_defconfig b/configs/imx6dl_mamoj_defconfig
index e45ca9a05a..e2a18d2c30 100644
--- a/configs/imx6dl_mamoj_defconfig
+++ b/configs/imx6dl_mamoj_defconfig
@@ -12,6 +12,7 @@ CONFIG_SYS_PROMPT="=> "
 CONFIG_CRC32_VERIFY=y
 CONFIG_CMD_MEMTEST=y
 CONFIG_CMD_GPIO=y
+CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_MII=y
 CONFIG_CMD_PING=y
@@ -37,3 +38,4 @@ CONFIG_USB_GADGET_VENDOR_NUM=0x0525
 CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5
 CONFIG_CI_UDC=y
 CONFIG_IMX_THERMAL=y
+CONFIG_SYS_I2C_MXC=y
-- 
2.14.3

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot