Re: [U-Boot] [PATCH v2 3/3] mmc: omap_hsmmc: Use regulator_set_enable_if_allowed for enabling regulator

2019-01-21 Thread sjg
Use regulator_set_enable_if_allowed() api instead of regulator_set_enable()
while enabling io regulators. This way the driver doesn't see an error
when disabling an always-on regulator and when enabling is not supported.

Reviewed-by: Simon Glass 
Signed-off-by: Lokesh Vutla 
---
 drivers/mmc/omap_hsmmc.c | 16 
 1 file changed, 8 insertions(+), 8 deletions(-)

Applied to u-boot-dm, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


[U-Boot] [PATCH v2 3/3] mmc: omap_hsmmc: Use regulator_set_enable_if_allowed for enabling regulator

2019-01-11 Thread Lokesh Vutla
Use regulator_set_enable_if_allowed() api instead of regulator_set_enable()
while enabling io regulators. This way the driver doesn't see an error
when disabling an always-on regulator and when enabling is not supported.

Reviewed-by: Simon Glass 
Signed-off-by: Lokesh Vutla 
---
 drivers/mmc/omap_hsmmc.c | 16 
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/mmc/omap_hsmmc.c b/drivers/mmc/omap_hsmmc.c
index 5cb97eb02a..efbe75baa4 100644
--- a/drivers/mmc/omap_hsmmc.c
+++ b/drivers/mmc/omap_hsmmc.c
@@ -470,21 +470,21 @@ static int omap_hsmmc_set_io_regulator(struct mmc *mmc, 
int mV)
return 0;
 
/* Disable PBIAS */
-   ret = regulator_set_enable(priv->pbias_supply, false);
-   if (ret && ret != -ENOSYS)
+   ret = regulator_set_enable_if_allowed(priv->pbias_supply, false);
+   if (ret)
return ret;
 
/* Turn off IO voltage */
-   ret = regulator_set_enable(mmc->vqmmc_supply, false);
-   if (ret && ret != -ENOSYS)
+   ret = regulator_set_enable_if_allowed(mmc->vqmmc_supply, false);
+   if (ret)
return ret;
/* Program a new IO voltage value */
ret = regulator_set_value(mmc->vqmmc_supply, uV);
if (ret)
return ret;
/* Turn on IO voltage */
-   ret = regulator_set_enable(mmc->vqmmc_supply, true);
-   if (ret && ret != -ENOSYS)
+   ret = regulator_set_enable_if_allowed(mmc->vqmmc_supply, true);
+   if (ret)
return ret;
 
/* Program PBIAS voltage*/
@@ -492,8 +492,8 @@ static int omap_hsmmc_set_io_regulator(struct mmc *mmc, int 
mV)
if (ret && ret != -ENOSYS)
return ret;
/* Enable PBIAS */
-   ret = regulator_set_enable(priv->pbias_supply, true);
-   if (ret && ret != -ENOSYS)
+   ret = regulator_set_enable_if_allowed(priv->pbias_supply, true);
+   if (ret)
return ret;
 
return 0;
-- 
2.19.2

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot